Re: [PATCH v2 0/9] ARM: remove set_fs callers and implementation

2020-09-19 Thread Russell King - ARM Linux admin
On Fri, Sep 18, 2020 at 02:46:15PM +0200, Arnd Bergmann wrote: > Hi Christoph, Russell, > > Here is an updated series for removing set_fs() from arch/arm, > based on the previous feedback. > > I have tested the oabi-compat changes using the LTP tests for the three > modified syscalls using an

Re: [PATCH 2/9] ARM: traps: use get_kernel_nofault instead of set_fs()

2020-09-18 Thread Russell King - ARM Linux admin
On Thu, Sep 17, 2020 at 07:29:37PM +0200, Arnd Bergmann wrote: > On Tue, Sep 8, 2020 at 8:15 AM Christoph Hellwig wrote: > > > > > +static void dump_mem(const char *, const char *, unsigned long, unsigned > > > long, bool kernel_mode); > > > > This adds a pointlessly long line. > > Fixed. > >

Re: [PATCH 2/4] ARM/footbridge: switch to use dma_direct_set_offset for lbus DMA offsets

2020-09-17 Thread Russell King - ARM Linux admin
On Thu, Sep 17, 2020 at 07:32:27PM +0200, Christoph Hellwig wrote: > static int __init cats_pci_init(void) > { > - if (machine_is_cats()) > - pci_common_init(_pci); > + if (!machine_is_cats()) > + return 0; > + bus_register_notifier(_bus_type, _pci_dma_nb); >

Re: [PATCH 3/4] ARM/dma-mapping: don't handle NULL devices in dma-direct.h

2020-09-17 Thread Russell King - ARM Linux admin
On Thu, Sep 17, 2020 at 07:32:28PM +0200, Christoph Hellwig wrote: > The DMA API removed support for not passing in a device a long time > ago, so remove the NULL checks. What happens with ISA devices? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps

Re: [PATCH v2 2/2] ARM: support PHYS_OFFSET minimum aligned at 64KiB boundary

2020-09-16 Thread Russell King - ARM Linux admin
On Wed, Sep 16, 2020 at 09:57:15AM +0800, Leizhen (ThunderTown) wrote: > On 2020/9/16 3:01, Russell King - ARM Linux admin wrote: > > On Tue, Sep 15, 2020 at 09:16:15PM +0800, Zhen Lei wrote: > >> Currently, only support the kernels where the base of physical memory is > &

Re: [PATCH v2 0/2] ARM: support PHYS_OFFSET minimum aligned at 64KiB boundary

2020-09-15 Thread Russell King - ARM Linux admin
On Tue, Sep 15, 2020 at 09:16:13PM +0800, Zhen Lei wrote: > v1 --> v2: > Nothing changed, but add mail list: patc...@armlinux.org.uk It isn't a mailing list, it's a bot, and it should only be copied when you're ready to submit the patches, and only after they've been reviewed. It queues the

Re: [PATCH v2 2/2] ARM: support PHYS_OFFSET minimum aligned at 64KiB boundary

2020-09-15 Thread Russell King - ARM Linux admin
On Tue, Sep 15, 2020 at 09:16:15PM +0800, Zhen Lei wrote: > Currently, only support the kernels where the base of physical memory is > at a 16MiB boundary. Because the add/sub instructions only contains 8bits > unrotated value. But we can use one more "add/sub" instructions to handle > bits 23-16.

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Russell King - ARM Linux admin
On Fri, Sep 11, 2020 at 09:01:01AM -0700, Nathan Chancellor wrote: > On Fri, Sep 11, 2020 at 08:22:36AM -0700, Jakub Kicinski wrote: > > On Fri, 11 Sep 2020 12:11:58 +0100 Russell King - ARM Linux admin wrote: > > > On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor

Re: [PATCH 2/3] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE

2020-09-11 Thread Russell King - ARM Linux admin
On Thu, Sep 10, 2020 at 07:40:37AM +0200, Christoph Hellwig wrote: > The DMA offset notifier can only be used if PHYS_OFFSET is at least > KEYSTONE_HIGH_PHYS_START, which can't be represented by a 32-bit > phys_addr_t. Currently the code compiles fine despite that, a pending > change to the DMA

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-11 Thread Russell King - ARM Linux admin
On Thu, Sep 10, 2020 at 05:31:42PM -0700, Nathan Chancellor wrote: > On Thu, Sep 10, 2020 at 03:28:11PM -0700, David Miller wrote: > > From: Nathan Chancellor > > Date: Thu, 10 Sep 2020 10:48:27 -0700 > > > > > Clang warns (trimmed for brevity): > > > > > >

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-10 Thread Russell King - ARM Linux admin
On Thu, Sep 10, 2020 at 10:31:12PM +0200, Marek Behun wrote: > On Thu, 10 Sep 2020 19:34:35 +0100 > Russell King - ARM Linux admin wrote: > > > On Thu, Sep 10, 2020 at 08:31:54PM +0200, Andrew Lunn wrote: > > > Generally the driver will default to the hardware r

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-10 Thread Russell King - ARM Linux admin
On Thu, Sep 10, 2020 at 08:31:54PM +0200, Andrew Lunn wrote: > Generally the driver will default to the hardware reset blink > pattern. There are a few PHY drivers which change this at probe, but > not many. The silicon defaults are pretty good. The "right" blink pattern can be a matter of how

Re: [PATCH net v2] net: dsa: mt7530: fix advertising unsupported 1000baseT_Half

2020-08-28 Thread Russell King - ARM Linux admin
On Fri, Aug 28, 2020 at 06:52:44PM +0800, Landen Chao wrote: > Remove 1000baseT_Half to advertise correct hardware capability in > phylink_validate() callback function. > > Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5") > Signed-off-by: Landen Chao > Reviewed-by: Andrew Lunn >

Re: [PATCH] drm/etnaviv: fix external abort seen on GC600 rev 0x19

2020-08-23 Thread Russell King - ARM Linux admin
On Sun, Aug 23, 2020 at 09:10:25PM +0200, Christian Gmeiner wrote: > Hi > > > I have formally tested the patch with 5.7.10 - and it doesn't resolve > > the issue - sadly :( > > > > From my testing, the reads on > > VIVS_HI_CHIP_PRODUCT_ID > > VIVS_HI_CHIP_ECO_ID > > need to be conditional - while

Re: [PATCH] phylink: : fix function prototype kernel-doc warning

2020-08-17 Thread Russell King - ARM Linux admin
On Sun, Aug 16, 2020 at 09:14:51PM -0700, David Miller wrote: > From: Randy Dunlap > Date: Sun, 16 Aug 2020 15:25:49 -0700 > > > Fix a kernel-doc warning for the pcs_config() function prototype: > > > > ../include/linux/phylink.h:406: warning: Excess function parameter > >

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 03:26:09PM -0700, Doug Anderson wrote: > Hi, > > Sigh. OK, hopefully correct now: > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8997/2 LGTM. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down

Re: [PATCH] arm: Add support for ZSTD compressed kernel

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 05:46:50PM -0400, Peter Geis wrote: > Good Evening, > > I had attempted to get this working as well, but have run into > difficulties with both my implementation and yours as well. > My implementation was almost the same as yours, with the exception of > also changing: >

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 11:28:09AM -0700, Doug Anderson wrote: > Let's hope this one works: > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8997/1 Almost. It seems that you must have grabbed a copy off the patch system, edited it and sent it back? The commit message appears

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 04:41:44PM +0100, Russell King - ARM Linux admin wrote: > On Thu, Aug 06, 2020 at 08:05:10AM -0700, Doug Anderson wrote: > > Yet if I go check mainline the patch is not there. This came to my > > attention since we had my patch picked to the Chro

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 08:05:10AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Dec 2, 2019 at 8:36 AM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Nov 20, 2019 at 11:18 AM Will Deacon wrote: > > > > > > On Sat, Oct 19, 2019 at 11:12:26AM -0700, Douglas Anderson wrote: > > > > This is

Re: [PATCH] arm: Add support for ZSTD compressed kernel

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 10:45:42AM +0200, Norbert Lange wrote: > Am Do., 6. Aug. 2020 um 02:30 Uhr schrieb Russell King - ARM Linux > admin : > > > > On Thu, Aug 06, 2020 at 01:05:55AM +0200, Norbert Lange wrote: > > > diff --git a/arch/arm/boot/compressed/head.S >

Re: [PATCH] arm: Add support for ZSTD compressed kernel

2020-08-05 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 01:05:55AM +0200, Norbert Lange wrote: > diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S > index 434a16982e34..1af01bfe6638 100644 > --- a/arch/arm/boot/compressed/head.S > +++ b/arch/arm/boot/compressed/head.S > @@ -614,7 +614,11 @@

Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Russell King - ARM Linux admin
On Wed, Aug 05, 2020 at 03:09:34PM -0700, Joe Perches wrote: > On Wed, 2020-08-05 at 23:02 +0100, Russell King - ARM Linux admin wrote: > > On Wed, Aug 05, 2020 at 11:54:25AM -0700, Joe Perches wrote: > > > On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wro

Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Russell King - ARM Linux admin
On Wed, Aug 05, 2020 at 11:47:38AM -0700, Joe Perches wrote: > On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wrote: > > On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > > > On Wed, Aug 5, 2020 at 7:34 AM Russell King > > > wrote

Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Russell King - ARM Linux admin
On Wed, Aug 05, 2020 at 11:54:25AM -0700, Joe Perches wrote: > On Wed, 2020-08-05 at 19:22 +0100, Russell King - ARM Linux admin wrote: > > On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > > > On Wed, Aug 5, 2020 at 7:34 AM Russell King > > > wrote

Re: [PATCH] MAINTAINERS: update phylink/sfp keyword matching

2020-08-05 Thread Russell King - ARM Linux admin
On Wed, Aug 05, 2020 at 11:11:28AM -0700, Linus Torvalds wrote: > On Wed, Aug 5, 2020 at 7:34 AM Russell King > wrote: > > > > Is this something you're willing to merge directly please? > > Done. > > That said: > > > -K: phylink > > +K: > >

Re: KASAN: slab-out-of-bounds Read in hci_le_meta_evt

2020-08-03 Thread Russell King - ARM Linux admin
On Mon, Aug 03, 2020 at 10:21:04AM -0700, Eric Biggers wrote: > On Mon, Aug 03, 2020 at 06:12:33PM +0100, Russell King - ARM Linux admin > wrote: > > Dear syzbot, > > > > Please explain why you are spamming me with all these reports - four so > > far. I don't und

Re: KASAN: slab-out-of-bounds Read in hci_le_meta_evt

2020-08-03 Thread Russell King - ARM Linux admin
Dear syzbot, Please explain why you are spamming me with all these reports - four so far. I don't understand why you think I should be doing anything with these. Thanks. On Mon, Aug 03, 2020 at 08:05:21AM -0700, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:

Re: [PATCH 1/3] ARM: exynos: clear L220_AUX_CTRL_NS_LOCKDOWN in default l2c_aux_val

2020-08-03 Thread Russell King - ARM Linux admin
On Mon, Aug 03, 2020 at 03:34:39PM +0200, Krzysztof Kozlowski wrote: > On Wed, Jul 29, 2020 at 02:47:31PM +0100, Guillaume Tucker wrote: > > The L220_AUX_CTRL_NS_LOCKDOWN flag is set during the L2C enable > > sequence. There is no need to set it in the default register value, > > this was done

Re: [RFC PATCH 1/4] dt-binding: i2c: add generic properties for GPIO bus recovery

2020-08-03 Thread Russell King - ARM Linux admin
On Thu, Jul 30, 2020 at 09:00:36AM +, codrin.ciubota...@microchip.com wrote: > On 27.07.2020 13:50, Russell King - ARM Linux admin wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Mon, Jul 2

Re: [PATCH 2/3] ARM: l2c: update prefetch bits in L2X0_AUX_CTRL using DT value

2020-07-29 Thread Russell King - ARM Linux admin
On Wed, Jul 29, 2020 at 02:47:32PM +0100, Guillaume Tucker wrote: > The L310_PREFETCH_CTRL register bits 28 and 29 to enable data and > instruction prefetch respectively can also be accessed via the > L2X0_AUX_CTRL register. They appear to be actually wired together in > hardware between the

Re: [PATCH net-next v2] net: mvneta: fix comment about phylink_speed_down

2020-07-29 Thread Russell King - ARM Linux admin
On Wed, Jul 29, 2020 at 05:49:09PM +0800, Jisheng Zhang wrote: > mvneta has switched to phylink, so the comment should look > like "We may have called phylink_speed_down before". > > Signed-off-by: Jisheng Zhang Reviewed-by: Russell King > --- > Since v1: > - drop patch2 which tries to

Re: [PATCH v3] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-28 Thread Russell King - ARM Linux admin
On Tue, Jul 28, 2020 at 02:27:43PM +0200, Frank Wunderlich wrote: > From: Landen Chao > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > like these: Can the above also be fixed for incorrect capitalisation and improper hyphernation please? Thanks. > > eth0: mtu

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Russell King - ARM Linux admin
On Mon, Jul 27, 2020 at 06:16:32PM +0200, Alexandre Belloni wrote: > On 27/07/2020 17:55:50+0200, Jon Nettleton wrote: > > > So, can we please have that discussion, it is pertinent to this patch. > > > > > > > Thinking about this some more, I believe whether or not an IOCTL > > interface is in

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Russell King - ARM Linux admin
On Mon, Jul 27, 2020 at 05:41:04PM +0200, Alexandre Belloni wrote: > On 27/07/2020 16:24:39+0100, Russell King - ARM Linux admin wrote: > > On Mon, Jul 27, 2020 at 04:49:38PM +0200, Alexandre Belloni wrote: > > > On 27/07/2020 10:45:53+0100, Russell King - ARM

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Russell King - ARM Linux admin
On Mon, Jul 27, 2020 at 04:49:38PM +0200, Alexandre Belloni wrote: > On 27/07/2020 10:45:53+0100, Russell King - ARM Linux admin wrote: > > > This is but this shouldn't be a DT property as it has to be changed > > > dynamically. I'm working on an ioctl interface to change thi

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Russell King - ARM Linux admin
On Mon, Jul 27, 2020 at 03:33:17PM +0200, Jon Nettleton wrote: > On Mon, Jul 27, 2020 at 11:46 AM Russell King - ARM Linux admin > wrote: > > > > On Thu, Jul 23, 2020 at 09:57:55PM +0200, Alexandre Belloni wrote: > > > On 23/07/2020 11:49:05-0600, Rob Herring wrote: &

Re: [RFC PATCH 1/4] dt-binding: i2c: add generic properties for GPIO bus recovery

2020-07-27 Thread Russell King - ARM Linux admin
On Mon, Jul 27, 2020 at 10:44:57AM +, codrin.ciubota...@microchip.com wrote: > On 24.07.2020 23:52, Russell King - ARM Linux admin wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Fri, Jul 2

Re: [PATCH v2 1/3] dt-bindings: rtc: pcf8523: add DSM pm option for battery switch-over

2020-07-27 Thread Russell King - ARM Linux admin
On Thu, Jul 23, 2020 at 09:57:55PM +0200, Alexandre Belloni wrote: > On 23/07/2020 11:49:05-0600, Rob Herring wrote: > > On Mon, Jul 20, 2020 at 12:23:59PM +0100, miguelborgesdefrei...@gmail.com > > wrote: > > > From: Miguel Borges de Freitas > > > > > > This adds direct-switching mode as a

Re: [RFC PATCH 1/4] dt-binding: i2c: add generic properties for GPIO bus recovery

2020-07-24 Thread Russell King - ARM Linux admin
On Fri, Jul 24, 2020 at 09:39:13PM +0200, Wolfram Sang wrote: > On Sun, Jul 05, 2020 at 11:19:18PM +0200, Wolfram Sang wrote: > > > > > +- pinctrl > > > + add extra pinctrl to configure SCL/SDA pins to GPIO function for bus > > > + recovery, call it "gpio" or "recovery" state > > > > I think we

Re: [RFC PATCH] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-21 Thread Russell King - ARM Linux admin
On Tue, Jul 21, 2020 at 06:16:24PM +0100, Jonathan McDowell wrote: > This adds full 802.1q VLAN support to the qca8k, allowing the use of > vlan_filtering and more complicated bridging setups than allowed by > basic port VLAN support. > > Tested with a number of untagged ports with separate VLANs

Re: arm: tinyconfig: entry-common.S:156: Error: r13 not allowed here -- `bic tsk,sp,#(((1<<12)<<1)-1)&~63'

2020-07-21 Thread Russell King - ARM Linux admin
On Tue, Jul 21, 2020 at 05:43:15PM +0200, Arnd Bergmann wrote: > On Tue, Jul 21, 2020 at 5:07 PM Naresh Kamboju > wrote: > > > > This might add little value. > > > > arm build sets failed on linux next 20200721. > > The defconfig ( +config fragments ) builds PASS. > > The tinyconfig and

Re: [PATCH] thermal: sun8i: Be loud when probe fails

2020-07-20 Thread Russell King - ARM Linux admin
On Mon, Jul 20, 2020 at 03:55:26PM +0800, Icenowy Zheng wrote: > 在 2020-07-08星期三的 12:03 +0100,Russell King - ARM Linux admin写道: > > On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote: > > > I noticed several mobile Linux distributions failing to enable the > &

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-18 Thread Russell King - ARM Linux admin
On Sat, Jul 18, 2020 at 04:44:35PM +0200, Andrew Lunn wrote: > On Sat, Jul 18, 2020 at 02:20:11PM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jul 17, 2020 at 10:44:19PM +0200, John Crispin wrote: > > > in regards to the sgmii clk skew. I never understood

Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties

2020-07-18 Thread Russell King - ARM Linux admin
On Fri, Jul 17, 2020 at 10:44:19PM +0200, John Crispin wrote: > in regards to the sgmii clk skew. I never understood the electrics fully I > am afraid, but without the patch it simply does not work. my eletcric foo is > unfortunately is not sufficient to understand the "whys" I am afraid. Do you

Re: [PATCH net-next v6 1/4] net: phy: add USXGMII link partner ability constants

2020-07-13 Thread Russell King - ARM Linux admin
On Thu, Jul 09, 2020 at 11:35:23PM +0200, Michael Walle wrote: > The constants are taken from the USXGMII Singleport Copper Interface > specification. The naming are based on the SGMII ones, but with an MDIO_ > prefix. > > Signed-off-by: Michael Walle > --- > include/uapi/linux/mdio.h | 26

Re: [PATCH net-next v6 1/4] net: phy: add USXGMII link partner ability constants

2020-07-13 Thread Russell King - ARM Linux admin
On Thu, Jul 09, 2020 at 11:35:23PM +0200, Michael Walle wrote: > The constants are taken from the USXGMII Singleport Copper Interface > specification. The naming are based on the SGMII ones, but with an MDIO_ > prefix. > > Signed-off-by: Michael Walle > --- > include/uapi/linux/mdio.h | 26

Re: arm-linux-gnueabi-ld: section .rodata VMA overlaps section .bss VMA

2020-07-11 Thread Russell King - ARM Linux admin
I doubt anyone is going to fix this; it's an XIP kernel, and it looks like the .data and .rodata sections are correctly placed as per the configuration, but for some reason the .text (and sections that follow) are incorrectly placed in VMA space. The configuration file says that the kernel should

Re: [PATCH v2] net: ethernet: mtk_eth_soc: fix mtu warning

2020-07-09 Thread Russell King - ARM Linux admin
On Thu, Jul 09, 2020 at 03:41:15PM +0200, Andrew Lunn wrote: > On Thu, Jul 09, 2020 at 07:57:42AM +0200, Frank Wunderlich wrote: > > From: René van Dorst > > > > in recent Kernel-Versions there are warnings about incorrect MTU-Size > > like these: > > > > mt7530 mdio-bus:00: nonfatal error -95

Re: [PATCH] thermal: sun8i: Be loud when probe fails

2020-07-08 Thread Russell King - ARM Linux admin
On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote: > I noticed several mobile Linux distributions failing to enable the > thermal regulation correctly, because the kernel is silent > when thermal driver fails to probe. Add enough error reporting > to debug issues and warn users in case

Re: [PATCH net-next v4 1/3] net: dsa: felix: move USXGMII defines to common place

2020-07-07 Thread Russell King - ARM Linux admin
On Tue, Jul 07, 2020 at 12:02:53AM +0200, Michael Walle wrote: > The ENETC has the same PCS PHY and thus needs the same definitions. Move > them into the common enetc_mdio.h header which has already the macros > for the SGMII PCS. > > Signed-off-by: Michael Walle > --- >

Re: [PATCH] net: sfp: Unique GPIO interrupt names

2020-07-06 Thread Russell King - ARM Linux admin
On Mon, Jul 06, 2020 at 12:38:37PM -0700, Chris Healy wrote: > Dynamically generate a unique GPIO interrupt name, based on the > device name and the GPIO name. For example: > > 103: 0 sx1503q 12 Edge sff2-los > 104: 0 sx1503q 13 Edge sff3-los > > The sffX

Re: [PATCH RESEND net-next v3 0/3] net: enetc: remove bootloader dependency

2020-07-04 Thread Russell King - ARM Linux admin
On Thu, Jul 02, 2020 at 12:41:39PM +0300, Vladimir Oltean wrote: > On Thu, 2 Jul 2020 at 11:41, Russell King - ARM Linux admin > wrote: > > > > On Thu, Jul 02, 2020 at 01:04:02AM +0300, Vladimir Oltean wrote: > > > On Thu, 2 Jul 2020 at 00:53, Russell King - A

Re: [PATCH net-next] net: dsa: microchip: split adjust_link() in phylink_mac_link_{up|down}()

2020-07-02 Thread Russell King - ARM Linux admin
On Thu, Jul 02, 2020 at 12:54:39PM +0300, Codrin Ciubotariu wrote: > The DSA subsystem moved to phylink and adjust_link() became deprecated in > the process. This patch removes adjust_link from the KSZ DSA switches and > adds phylink_mac_link_up() and phylink_mac_link_down(). > > Signed-off-by:

Re: [PATCH RESEND net-next v3 0/3] net: enetc: remove bootloader dependency

2020-07-02 Thread Russell King - ARM Linux admin
On Thu, Jul 02, 2020 at 01:04:02AM +0300, Vladimir Oltean wrote: > On Thu, 2 Jul 2020 at 00:53, Russell King - ARM Linux admin > wrote: > > > > fixing up almost every driver the best I can with the exception of two - > > felix DSA and Mediatek. > > > > I'm not

Re: [PATCH RESEND net-next v3 0/3] net: enetc: remove bootloader dependency

2020-07-01 Thread Russell King - ARM Linux admin
On Wed, Jul 01, 2020 at 11:34:30PM +0200, Michael Walle wrote: > This is a resend of the series because the conversion to the phylink > interface will likely take longer: > https://lore.kernel.org/netdev/CA+h21hpBodyY8CtNH2ktRdc2FqPi=Fjp94=vvzvzsvbnvnf...@mail.gmail.com/ I don't think it will;

Re: [PATCH v4 14/17] arm/build: Warn on orphan section placement

2020-06-29 Thread Russell King - ARM Linux admin
On Mon, Jun 29, 2020 at 11:54:01AM -0400, Arvind Sankar wrote: > On Sun, Jun 28, 2020 at 11:18:37PM -0700, Kees Cook wrote: > > We don't want to depend on the linker's orphan section placement > > heuristics as these can vary between linkers, and may change between > > versions. All sections need

Re: [PATCH v4 14/17] arm/build: Warn on orphan section placement

2020-06-29 Thread Russell King - ARM Linux admin
On Mon, Jun 29, 2020 at 02:15:14PM -0400, Arvind Sankar wrote: > On Mon, Jun 29, 2020 at 07:07:04PM +0100, Russell King - ARM Linux admin > wrote: > > On Mon, Jun 29, 2020 at 11:54:01AM -0400, Arvind Sankar wrote: > > > On Sun, Jun 28, 2020 at 11:18:37PM -0700, Kees Cook wr

Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver support

2020-06-29 Thread Russell King - ARM Linux admin
On Fri, Jun 26, 2020 at 12:02:05PM -0700, Florian Fainelli wrote: > On 6/22/20 8:08 AM, Madalin Bucur (OSS) wrote: > > Hi Andrew, the reasons behind this selection: > > > > - the PCS that is controlled by the backplane driver belongs to the PHY > > layer so the representation as a PHY device is

Re: [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()'

2020-06-25 Thread Russell King - ARM Linux admin
On Thu, Jun 25, 2020 at 10:47:30PM +0200, Christophe JAILLET wrote: > The dev_id used in 'request_irq()' and 'free_irq()' should match. > Use 'info' in both cases. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Christophe JAILLET Acked-by: Russell King Thanks Christophe. > ---

Re: [PATCH 14/15] net: phy: add PHY regulator support

2020-06-24 Thread Russell King - ARM Linux admin
On Wed, Jun 24, 2020 at 05:57:19PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Jun 23, 2020 at 06:27:06PM +0200, Bartosz Golaszewski wrote: > > wt., 23 cze 2020 o 11:56 Russell King - ARM Linux admin > > napisał(a): > > > > > > On Tue, Jun 23,

Re: [PATCH 14/15] net: phy: add PHY regulator support

2020-06-24 Thread Russell King - ARM Linux admin
On Tue, Jun 23, 2020 at 06:27:06PM +0200, Bartosz Golaszewski wrote: > wt., 23 cze 2020 o 11:56 Russell King - ARM Linux admin > napisał(a): > > > > On Tue, Jun 23, 2020 at 11:46:15AM +0200, Bartosz Golaszewski wrote: > > > wt., 23 cze 2020 o 11:43 Russell King - ARM

Re: [PATCH 09/15] net: phy: delay PHY driver probe until PHY registration

2020-06-24 Thread Russell King - ARM Linux admin
On Wed, Jun 24, 2020 at 09:06:28AM -0700, Florian Fainelli wrote: > On 6/24/2020 6:48 AM, Bartosz Golaszewski wrote: > > I didn't expect to open such a can of worms... > > > > This has evolved into several new concepts being proposed vs my > > use-case which is relatively simple. The former will

Re: [PATCH 2/2] net: ethernet: mvneta: Add back interface mode validation

2020-06-24 Thread Russell King - ARM Linux admin
On Wed, Jun 24, 2020 at 09:00:45AM +0200, Sascha Hauer wrote: > When writing the serdes configuration register was moved to > mvneta_config_interface() the whole code block was removed from > mvneta_port_power_up() in the assumption that its only purpose was to > write the serdes configuration

Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes

2020-06-24 Thread Russell King - ARM Linux admin
On Wed, Jun 24, 2020 at 09:00:44AM +0200, Sascha Hauer wrote: > In mvneta_config_interface() the RGMII modes are catched by the default > case which is an error return. The RGMII modes are valid modes for the > driver, so instead of returning an error add a break statement to return >

Re: [PATCH v3 2/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Russell King - ARM Linux admin
On Tue, Jun 23, 2020 at 08:36:46PM -0700, Florian Fainelli wrote: > Le 2020-06-23 à 20:26, Jisheng Zhang a écrit : > > Call phy_disable_interrupts() in phy_init_hw() to "have a defined init > > state as we don't know in which state the PHY is if the PHY driver is > > loaded. We shouldn't assume

Re: [PATCH 14/15] net: phy: add PHY regulator support

2020-06-23 Thread Russell King - ARM Linux admin
On Tue, Jun 23, 2020 at 11:46:15AM +0200, Bartosz Golaszewski wrote: > wt., 23 cze 2020 o 11:43 Russell King - ARM Linux admin > napisał(a): > > > > On Tue, Jun 23, 2020 at 11:41:11AM +0200, Bartosz Golaszewski wrote: > > > pon., 22 cze 2020 o 15:29 Russell King - ARM

Re: [PATCH 14/15] net: phy: add PHY regulator support

2020-06-23 Thread Russell King - ARM Linux admin
On Tue, Jun 23, 2020 at 11:41:11AM +0200, Bartosz Golaszewski wrote: > pon., 22 cze 2020 o 15:29 Russell King - ARM Linux admin > napisał(a): > > > > [snip!] > > > > > This is likely to cause issues for some PHY drivers. Note that we have > > some P

Re: [PATCH v2 05/15] net: pylink.h: add kernel-doc descriptions for new fields at phylink_config

2020-06-23 Thread Russell King - ARM Linux admin
On Tue, Jun 23, 2020 at 09:09:01AM +0200, Mauro Carvalho Chehab wrote: > Some fields were moved from struct phylink into phylink_config. > Update the kernel-doc markups for the config struct accordingly > > Fixes: 5c05c1dbb177 ("net: phylink, dsa: eliminate phylink_fixed_state_cb()") >

Re: [PATCH 1/2] net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy

2020-06-22 Thread Russell King - ARM Linux admin
On Tue, Jun 16, 2020 at 10:31:39AM +0200, Sascha Hauer wrote: > The MVNETA_SERDES_CFG register is only available on older SoCs like the > Armada XP. On newer SoCs like the Armada 38x the fields are moved to > comphy. This patch moves the writes to this register next to the comphy > initialization,

Re: [PATCH 14/15] net: phy: add PHY regulator support

2020-06-22 Thread Russell King - ARM Linux admin
On Mon, Jun 22, 2020 at 11:37:43AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The MDIO sub-system now supports PHY regulators. Let's reuse the code > to extend this support over to the PHY device. > > Signed-off-by: Bartosz Golaszewski > --- >

Re: [PATCH 13/15] net: phy: mdio: add support for PHY supply regulator

2020-06-22 Thread Russell King - ARM Linux admin
On Mon, Jun 22, 2020 at 11:37:42AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently many MAC drivers control the regulator supplying the PHY but > this is conceptually wrong. The regulator should be defined as a property > of the PHY node on the MDIO bus and controlled

Re: [PATCH v7 2/3] serial: 8250_dw: Simplify the ref clock rate setting procedure

2020-06-20 Thread Russell King - ARM Linux admin
On Fri, Jun 19, 2020 at 11:02:50PM +0300, Serge Semin wrote: > Really instead of twice checking the clk_round_rate() return value > we could do it once, and if it isn't error the clock rate can be changed. > By doing so we decrease a number of ret-value tests and remove a weird > goto-based

Re: [PATCH net 2/2] net: phy: Check harder for errors in get_phy_id()

2020-06-19 Thread Russell King - ARM Linux admin
On Fri, Jun 19, 2020 at 03:26:59PM +0200, Andrew Lunn wrote: > On Thu, Jun 18, 2020 at 09:47:59PM -0700, Florian Fainelli wrote: > > Commit 02a6efcab675 ("net: phy: allow scanning busses with missing > > phys") added a special condition to return -ENODEV in case -ENODEV or > > -EIO was returned

Re: [PATCH] Fix unwind_frame for clang-built kernels

2020-06-18 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 06:23:48AM +0200, Sedat Dilek wrote: > On Wed, Jun 17, 2020 at 12:36 AM 'Nathan Huckleberry' via Clang Built > Linux wrote: > > > > Since clang does not push pc and sp in function prologues, the current > > implementation of unwind_frame does not work. By using the

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 06:01:29PM +0200, Heiko Stübner wrote: > Am Donnerstag, 18. Juni 2020, 17:47:48 CEST schrieb Russell King - ARM Linux > admin: > > On Thu, Jun 18, 2020 at 05:41:54PM +0200, Heiko Stübner wrote: > > > Though I'm not sure how this fits in the whole bri

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 05:41:54PM +0200, Heiko Stübner wrote: > Am Donnerstag, 18. Juni 2020, 15:41:02 CEST schrieb Russell King - ARM Linux > admin: > > On Thu, Jun 18, 2020 at 03:28:22PM +0200, Andrew Lunn wrote: > > > On Thu, Jun 18, 2020 at 02:11:39PM +0200,

Re: [PATCH v5 3/3] net: phy: mscc: handle the clkout control on some phy variants

2020-06-18 Thread Russell King - ARM Linux admin
On Thu, Jun 18, 2020 at 03:28:22PM +0200, Andrew Lunn wrote: > On Thu, Jun 18, 2020 at 02:11:39PM +0200, Heiko Stuebner wrote: > > From: Heiko Stuebner > > > > At least VSC8530/8531/8540/8541 contain a clock output that can emit > > a predefined rate of 25, 50 or 125MHz. > > > > This may then

Re: [PATCH net v1] net: phy: smsc: fix printing too many logs

2020-06-17 Thread Russell King - ARM Linux admin
On Wed, Jun 17, 2020 at 08:43:34PM +0200, Andrew Lunn wrote: > You have explained what the change does. But not why it is > needed. What exactly is happening. To me, the key thing is > understanding why we get -110, and why it is not an actual error we > should be reporting as an error. That is

Re: [PATCH v3 1/3] net: phy: mscc: move shared probe code into a helper

2020-06-16 Thread Russell King - ARM Linux admin
On Tue, Jun 16, 2020 at 11:10:27AM +0200, Heiko Stübner wrote: > > > > You also need to provide a proper header posting when you repost this series > > after fixing this bug. > > not sure I understand what you mean with "header posting" here. David is requesting that you send a "0/N" email

Re: [RFC 1/3] lib: copy_{from,to}_user using gup & kmap_atomic()

2020-06-13 Thread Russell King - ARM Linux admin
On Sat, Jun 13, 2020 at 05:34:32PM +0530, afzal mohammed wrote: > Hi, > > On Fri, Jun 12, 2020 at 10:07:28PM +0200, Arnd Bergmann wrote: > > > I think a lot > > of usercopy calls are only for a few bytes, though this is of course > > highly workload dependent and you might only care about the

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 01:52:50PM +0200, Sascha Hauer wrote: > On Fri, Jun 12, 2020 at 12:30:31PM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 12:22:13PM +0100, Russell King - ARM Linux admin > > wrote: > > > On Fri, Jun 12, 2020 at 11:

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 02:06:04PM +0200, Sascha Hauer wrote: > And here is the same patch which applies on master and the net tree. > It works as expected on my Armada XP in 2.5Gbps mode. Provided you are > happy with the patch I can send it as a formal patch on monday if by > then you haven't

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 12:22:13PM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 11:42:08AM +0100, Russell King - ARM Linux admin > wrote: > > With the obvious mistakes fixed (extraneous 'i' and lack of default > > case), it seems to still work on Armad

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 11:42:08AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 11:18:20AM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 11:01:15AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Fri,

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 11:18:20AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 11:01:15AM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 09:47:10AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Fri,

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 11:01:15AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 09:47:10AM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 10:38:47AM +0200, Sascha Hauer wrote: > > > The Marvell MVNETA Ethernet controll

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 09:47:10AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 10:38:47AM +0200, Sascha Hauer wrote: > > The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode > > called DRSGMII. Depending on the Port MAC Control Reg

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 10:38:47AM +0200, Sascha Hauer wrote: > The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode > called DRSGMII. Depending on the Port MAC Control Register0 PortType > setting this seems to be either an overclocked SGMII mode or 2500BaseX. > > This patch adds

Re: [PATCH 1/2] net: dsa: qca8k: Switch to PHYLINK instead of PHYLIB

2020-06-11 Thread Russell King - ARM Linux admin
On Wed, Jun 10, 2020 at 08:14:03PM +0100, Jonathan McDowell wrote: > Update the driver to use the new PHYLINK callbacks, removing the > legacy adjust_link callback. Looks good, there's a couple of issues / questions > static void > +qca8k_phylink_mac_config(struct dsa_switch *ds, int port,

Re: [PATCH 2/2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-11 Thread Russell King - ARM Linux admin
On Wed, Jun 10, 2020 at 08:15:13PM +0100, Jonathan McDowell wrote: > This patch improves the handling of the SGMII interface on the QCA8K > devices. Previously the driver did no configuration of the port, even if > it was selected. We now configure it up in the appropriate > PHY/MAC/Base-X mode

Re: [RFC PATCH v2] net: dsa: qca8k: Improve SGMII interface handling

2020-06-08 Thread Russell King - ARM Linux admin
Hi Jonathan, A quick read through on the first review... On Mon, Jun 08, 2020 at 07:39:53PM +0100, Jonathan McDowell wrote: > +static int > +qca8k_phylink_mac_link_state(struct dsa_switch *ds, int port, > + struct phylink_link_state *state) > +{ > + struct qca8k_priv

Re: [PATCH] net: ethernet: mvneta: add support for 2.5G DRSGMII mode

2020-06-08 Thread Russell King - ARM Linux admin
On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote: > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode > called DRSGMII. > > This patch adds a corresponding phy-mode string 'drsgmii' and parses it > from DT. The MVNETA then configures the SERDES protocol value >

Re: ARM: vmsplit 4g/4g

2020-06-07 Thread Russell King - ARM Linux admin
On Sun, Jun 07, 2020 at 06:29:32PM +0530, afzal mohammed wrote: > Hi, > > On Sat, May 16, 2020 at 09:35:57AM +0200, Arnd Bergmann wrote: > > On Sat, May 16, 2020 at 8:06 AM afzal mohammed > > wrote: > > > > Okay, so the conclusion i take is, > > > 1. VMSPLIT 4G/4G have to live alongside

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Russell King - ARM Linux admin
On Sat, Jun 06, 2020 at 11:59:09AM +0100, Jonathan McDowell wrote: > So the device in question is a 7 port stand alone switch chip. There's a > single SGMII port which is configurable between port 0 + 6 (they can > also be configure up as RGMII, while the remaining 5 ports have their > own phys).

Re: [PATCHv9 00/12] PCI: Recode Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs

2020-06-06 Thread Russell King - ARM Linux admin
On Sat, Jun 06, 2020 at 12:53:43AM +0100, Russell King - ARM Linux admin wrote: > On Sat, Feb 29, 2020 at 11:04:56AM +, Russell King - ARM Linux admin > wrote: > > Adding Ted and Andreas... > > > > Here's the debugfs -n "id" output for dpkg.status.5.g

Re: [PATCH 2/2] net: dsa: qca8k: introduce SGMII configuration options

2020-06-06 Thread Russell King - ARM Linux admin
On Sat, Jun 06, 2020 at 08:49:16AM +0100, Jonathan McDowell wrote: > On Fri, Jun 05, 2020 at 08:38:43PM +0200, Andrew Lunn wrote: > > On Fri, Jun 05, 2020 at 07:10:58PM +0100, Jonathan McDowell wrote: > > > The QCA8337(N) has an SGMII port which can operate in MAC, PHY or BASE-X > > > mode

Re: [PATCHv9 00/12] PCI: Recode Mobiveil driver and add PCIe Gen4 driver for NXP Layerscape SoCs

2020-06-05 Thread Russell King - ARM Linux admin
On Sat, Feb 29, 2020 at 11:04:56AM +, Russell King - ARM Linux admin wrote: > Adding Ted and Andreas... > > Here's the debugfs -n "id" output for dpkg.status.5.gz (which is fine, > and probably a similar size): > > debugfs: id <917527> > a481

Re: [PATCH net-next 7/8] net: phy: Add Synopsys DesignWare XPCS MDIO module

2020-06-05 Thread Russell King - ARM Linux admin
Hi Jose, I just tripped over a bug while grepping for something else and reading a bit of this driver: On Mon, Mar 09, 2020 at 09:36:26AM +0100, Jose Abreu wrote: > +static int xpcs_read_lpa(struct mdio_xpcs_args *xpcs, > + struct phylink_link_state *state) > +{ > + int

Re: Security Random Number Generator support

2020-06-05 Thread Russell King - ARM Linux admin
On Fri, Jun 05, 2020 at 04:59:42PM +0800, Neal Liu wrote: > On Fri, 2020-06-05 at 09:09 +0100, Russell King - ARM Linux admin wrote: > > On Fri, Jun 05, 2020 at 03:19:03PM +0800, Neal Liu wrote: > > > On Wed, 2020-06-03 at 17:34 +0800, Russell King - ARM Linux admin wrote:

<    1   2   3   4   5   6   7   8   9   10   >