Re: [PATCH 00/20] sh: Fix missing prototypes

2024-05-02 Thread John Paul Adrian Glaubitz
1 + > arch/sh/math-emu/math.c | 2 + > arch/sh/mm/nommu.c | 2 + > arch/sh/mm/pgtable.c| 4 +- > arch/sh/mm/tlbex_32.c | 1 + > 23 files changed, 68 insertions(+), 189 deletions(-) > create mode

Re: [PATCH 20/20] [RFC] sh: dma: Remove unused functionality

2024-05-02 Thread John Paul Adrian Glaubitz
Hi Geert, On Thu, 2024-05-02 at 09:03 +0200, Geert Uytterhoeven wrote: > On Wed, May 1, 2024 at 3:58 PM John Paul Adrian Glaubitz > wrote: > > On Wed, 2024-05-01 at 11:12 +0200, John Paul Adrian Glaubitz wrote: > > > On Fri, 2024-03-01 at 22:02 +0100, Geert Uytterhoeven wrot

Re: [PATCH 20/20] [RFC] sh: dma: Remove unused functionality

2024-05-01 Thread John Paul Adrian Glaubitz
Hi Geert, On Wed, 2024-05-01 at 11:12 +0200, John Paul Adrian Glaubitz wrote: > Hi Geert, > > On Fri, 2024-03-01 at 22:02 +0100, Geert Uytterhoeven wrote: > > dma_extend(), get_dma_info_by_name(), register_chan_caps(), and > > request_dma_bycap() are unused. Remove them,

Re: [PATCH 00/20] sh: Fix missing prototypes

2024-05-01 Thread John Paul Adrian Glaubitz
_32.c | 1 + > arch/sh/math-emu/math.c | 2 + > arch/sh/mm/nommu.c | 2 + > arch/sh/mm/pgtable.c| 4 +- > arch/sh/mm/tlbex_32.c | 1 + > 23 files changed, 68 insertions(+), 189 deletions(-) >

Re: [PATCH 20/20] [RFC] sh: dma: Remove unused functionality

2024-05-01 Thread John Paul Adrian Glaubitz
igned long flags); > > extern int register_dmac(struct dma_info *info); > extern void unregister_dmac(struct dma_info *info); > -extern struct dma_info *get_dma_info_by_name(const char *dmac_name); > - > -extern int dma_extend(unsigned int chan, unsigned long op, void *param); > -extern int register_chan_caps(const char *dmac, struct dma_chan_caps > *capslist); > > /* arch/sh/drivers/dma/dma-sysfs.c */ > extern int dma_create_sysfs_files(struct dma_channel *, struct dma_info *); I assume we could re-add these again in case we need them, but it would be good if Yoshinori could comment on whether we should keep these functions or not. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Re: [PATCH 12/20] sh: dma: Remove unused dmac_search_free_channel()

2024-05-01 Thread John Paul Adrian Glaubitz
gned-off-by: Geert Uytterhoeven > --- > dma_extend(), get_dma_info_by_name(), register_chan_caps(), and > request_dma_bycap() are also unused, but don't trigger warnings > --- I assume the other functions didn't trigger a warning because their symbols were exported. Correct me if

Re: [PATCH v2] locking/atomic: sh: Use generic_cmpxchg_local for arch_cmpxchg_local()

2023-11-02 Thread John Paul Adrian Glaubitz
nsigned long)(o), \ > + (unsigned long)(n), \ > + sizeof(*(ptr))); \ > +}) > + > #endif /* __ASM_SH_CMPXCHG_H */ Reviewed-by: John Paul Adrian Glaubitz -- .''`. John Paul Adrian

Re: [PATCH] locking/atomic: sh: Use generic_cmpxchg_local for arch_cmpxchg_local()

2023-10-25 Thread John Paul Adrian Glaubitz
arch_cmpxchg_local() is > > defined as raw "cmpxchg" without lock prefix. > > > > #define __cmpxchg_local(ptr, old, new, size) \ > > __raw_cmpxchg((ptr), (old), (new), (size), "") > > > > Yes, you're right; s

Re: [PATCH] locking/atomic: sh: Use generic_cmpxchg_local for arch_cmpxchg_local()

2023-10-24 Thread John Paul Adrian Glaubitz
(unsigned long)_n_, sizeof(*(ptr))); \ >}) > > +#include > + > #endif /* __ASM_SH_CMPXCHG_H */ Reviewed-by: John Paul Adrian Glaubitz -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Re: [PATCH] perf auxtrace: Fix potential null pointer dereference

2021-04-20 Thread Adrian Hunter
gt; callback pointer "itr->parse_snapshot_options" is dereferenced without > performing NULL check. > > Add a NULL check for the pointer "itr->parse_snapshot_options" before > invoke the callback. > > Fixes: d20031bb63dd ("perf tools: Add AUX area tracing Snapshot Mode&

Re: [PATCH v4 1/2] mmc: block: Issue flush only if allowed

2021-04-20 Thread Adrian Hunter
way, verify that The cache function is > turned ON before doing so. > > fixes: 1e8e55b67030 (mmc: block: Add CQE support) > > Reported-by: Brendan Peter > Tested-by: Brendan Peter > Signed-off-by: Avri Altman Acked-by: Adrian Hunter > --- > drivers/mmc/core/bloc

Re: [PATCH v3 2/2] mmc: block: Update ext_csd.cache_ctrl if it was written

2021-04-20 Thread Adrian Hunter
ctrl on ext-csd write. > > Signed-off-by: Avri Altman Acked-by: Adrian Hunter > --- > drivers/mmc/core/block.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c > index 5b6501fc9fb7..8b07ed5e08de 10

Re: [PATCH v3 1/2] mmc: block: Issue flush only if allowed

2021-04-20 Thread Adrian Hunter
On 20/04/21 8:53 am, Avri Altman wrote: > The cache may be flushed to the nonvolatile storage by writing to > FLUSH_CACHE byte (EXT_CSD byte [32]). When in command queueing mode, the > cache may be flushed by issuing a CMDQ_TASK_ DEV_MGMT (CMD48) with a > FLUSH_CACHE op-code. Either way, verify

Re: [PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-20 Thread Adrian Hunter
On 20/04/21 7:15 am, Adrian Hunter wrote: > On 20/04/21 12:53 am, Asutosh Das (asd) wrote: >> On 4/19/2021 11:37 AM, Adrian Hunter wrote: >>> On 16/04/21 10:49 pm, Asutosh Das wrote: >>>> >>>> Co-developed-by: Can Guo >>>> S

Re: [PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-19 Thread Adrian Hunter
On 20/04/21 12:53 am, Asutosh Das (asd) wrote: > On 4/19/2021 11:37 AM, Adrian Hunter wrote: >> On 16/04/21 10:49 pm, Asutosh Das wrote: >>> >>> Co-developed-by: Can Guo >>> Signed-off-by: Can Guo >>> Signed-off-by: Asutosh Das >>> --- >

Re: [PATCH v20 1/2] scsi: ufs: Enable power management for wlun

2021-04-19 Thread Adrian Hunter
On 16/04/21 10:49 pm, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if

Re: [PATCH] scsi: ufs: Check for bkops in runtime suspend

2021-04-18 Thread Adrian Hunter
On 18/04/21 10:21 am, Avri Altman wrote: > The UFS driver allowed BKOPS and WB Flush operations to be completed on > Runtime suspend. Adding the DeepSleep support, this is no longer true: > the driver will ignore BKOPS and WB Flush states, and force a link state > transition to UIC_LINK_OFF_STATE.

Re: [PATCH v19 1/2] scsi: ufs: Enable power management for wlun

2021-04-16 Thread Adrian Hunter
On 16/04/21 12:22 pm, Adrian Hunter wrote: > On 16/04/21 2:36 am, Asutosh Das wrote: >> During runtime-suspend of ufs host, the scsi devices are >> already suspended and so are the queues associated with them. >> But the ufs host sends SSU (START_STOP_UNIT) to wlun >>

Re: [PATCH v19 1/2] scsi: ufs: Enable power management for wlun

2021-04-16 Thread Adrian Hunter
On 16/04/21 2:36 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if the

Re: [PATCH v18 1/2] scsi: ufs: Enable power management for wlun

2021-04-15 Thread Adrian Hunter
On 14/04/21 9:58 pm, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if the

Re: [PATCH v18 2/2] ufs: sysfs: Resume the proper scsi device

2021-04-15 Thread Adrian Hunter
On 14/04/21 9:58 pm, Asutosh Das wrote: > Resumes the actual scsi device the unit descriptor of which > is being accessed instead of the hba alone. > > Reviewed-by: Can Guo > Signed-off-by: Asutosh Das Reviewed-by: Adrian Hunter > --- > drivers/scsi

Re: Bug#986561: linux: Regression in drivers/hid/hid-dr.c causing horizontal D-pad to malfunction on SNES joystick

2021-04-14 Thread Ioan-Adrian Ratiu
Hi, On Wed, 14 Apr 2021, Salvatore Bonaccorso wrote: Hi Ioan-Adrian, On Wed, Apr 07, 2021 at 02:47:24PM +0200, Alessandro Grassi wrote: Source: linux Severity: normal Tags: upstream X-Debbugs-Cc: alessan...@aggro.it Greetings, I am encountering the issue described in this thread[1

Re: [PATCH 2/2] perf intel-pt: Use aux_watermark

2021-04-14 Thread Adrian Hunter
On 8/04/21 6:31 pm, Alexander Shishkin wrote: > Turns out, the default setting of attr.aux_watermark to half of the total > buffer size is not very useful, especially with smaller buffers. The > problem is that, after half of the buffer is filled up, the kernel updates > ->aux_head and sets up the

Re: [PATCH v17 1/2] scsi: ufs: Enable power management for wlun

2021-04-11 Thread Adrian Hunter
On 8/04/21 5:49 pm, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if the

Re: [PATCH v17 2/2] ufs: sysfs: Resume the proper scsi device

2021-04-10 Thread Adrian Hunter
On 8/04/21 5:49 pm, Asutosh Das wrote: > Resumes the actual scsi device the unit descriptor of which > is being accessed instead of the hba alone. > > Reviewed-by: Can Guo > Signed-off-by: Asutosh Das > --- > drivers/scsi/ufs/ufs-sysfs.c | 30 +- > 1 file changed,

Re: [PATCH] perf session: Dump PERF_RECORD_TIME_CONV event

2021-04-10 Thread Adrian Hunter
__u64time_mask; bool cap_user_time_zero; bool cap_user_time_short; That means checking the event size. Also PERF_RECORD_TIME_CONV should have its own byte-swapper instead of perf_event__all64_swap() - also checking event size. i.e. fixes for: commit d110162cafc80dad0622cfd40f3113aebb77e1bb Author: Leo Yan Date: Mon Sep 14 19:53:09 2020 +0800 perf tsc: Support cap_user_time_short for event TIME_CONV Regards Adrian

Re: [PATCH v17 1/2] scsi: ufs: Enable power management for wlun

2021-04-09 Thread Adrian Hunter
On 9/04/21 8:15 pm, Asutosh Das (asd) wrote: > On 4/9/2021 3:07 AM, Adrian Hunter wrote: >> On 9/04/21 5:27 am, Daejun Park wrote: >>> Hi Asutosh Das, >>> >>>> During runtime-suspend of ufs host, the scsi devices are >>>> already s

Re: [PATCH v17 1/2] scsi: ufs: Enable power management for wlun

2021-04-09 Thread Adrian Hunter
On 9/04/21 5:27 am, Daejun Park wrote: > Hi Asutosh Das, > >> During runtime-suspend of ufs host, the scsi devices are >> already suspended and so are the queues associated with them. >> But the ufs host sends SSU (START_STOP_UNIT) to wlun >> during its runtime-suspend. >> During the process

Re: [PATCH v16 1/2] scsi: ufs: Enable power management for wlun

2021-04-08 Thread Adrian Hunter
On 7/04/21 9:08 pm, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if the

Re: [PATCH v2 0/7] perf arm-spe: Enable timestamp

2021-04-07 Thread Adrian Hunter
On 7/04/21 4:15 pm, Leo Yan wrote: > Hi Al, > > On Tue, Apr 06, 2021 at 09:38:32AM +, Al Grant wrote: > > [...] > >>> This patch set is to enable timestamp for Arm SPE trace. It reads out TSC >>> parameters from mmap page and stores into auxtrace info structure; >> >> Why not synthesize a

Re: [PATCH v15 1/2] scsi: ufs: Enable power management for wlun

2021-04-07 Thread Adrian Hunter
On 6/04/21 8:52 pm, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if the

Re: [PATCH] ia64: module: fix symbolizer crash on fdescr

2021-04-04 Thread John Paul Adrian Glaubitz
re module_finalize() now > zeroes out all variables relevant to module loading only. Typo: s/zeroes/zero/. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

[PATCH] perf inject: Fix repipe usage

2021-04-01 Thread Adrian Hunter
repipe' to true only if the output is a pipe. Fixes: e558a5bd8b74 ("perf inject: Work with files") Signed-off-by: Adrian Hunter --- tools/perf/builtin-inject.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c index 6fe

Re: [PATCH v14 1/2] scsi: ufs: Enable power management for wlun

2021-04-01 Thread Adrian Hunter
On 1/04/21 4:40 am, Asutosh Das (asd) wrote: > On 3/31/2021 11:19 AM, Adrian Hunter wrote: >> On 31/03/21 1:31 am, Asutosh Das wrote: >>> During runtime-suspend of ufs host, the scsi devices are >>> already suspended and so are the queues associated with them. >

Re: [PATCH v14 1/2] scsi: ufs: Enable power management for wlun

2021-03-31 Thread Adrian Hunter
On 31/03/21 1:31 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if the

Re: [PATCH v13 1/2] scsi: ufs: Enable power management for wlun

2021-03-30 Thread Adrian Hunter
On 25/03/21 3:39 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU (START_STOP_UNIT) to wlun > during its runtime-suspend. > During the process blk_queue_enter checks if the

Re: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)

2021-03-29 Thread John Paul Adrian Glaubitz
machine. > > CC: linux-i...@vger.kernel.org > CC: storage...@microchip.com > CC: linux-s...@vger.kernel.org > CC: Joe Szczypek > CC: Scott Benesh > CC: Scott Teel > CC: Tomas Henzl > CC: "Martin K. Petersen" > CC: Don Brace > Reported-by: John Pa

Re: [PATCH] tools: Remove duplicate definition of ia64_mf() on ia64

2021-03-28 Thread John Paul Adrian Glaubitz
Hello! On 3/23/21 7:25 PM, John Paul Adrian Glaubitz wrote: > The ia64_mf() macro defined in tools/arch/ia64/include/asm/barrier.h > is already defined in on ia64 which causes libbpf > failing to build: > > CC /usr/src/linux/tools/bpf/bpftool//libbpf/staticobjs/lib

Re: [PATCH, v2] tools: Remove inclusion of ia64-specific version of errno.h header

2021-03-28 Thread John Paul Adrian Glaubitz
Hello! On 3/23/21 7:04 PM, John Paul Adrian Glaubitz wrote: > There is no longer an ia64-specific version of the errno.h header > below arch/ia64/include/uapi/asm/, so trying to build tools/bpf > fails with: > > CC /usr/src/linux/tools/bpf/bpftool/btf_dumper.o > In

Re: [PATCH] ia64: simplify code flow around swiotlb init

2021-03-26 Thread John Paul Adrian Glaubitz
is not present on system. ^^ typo s/is/if/ I will test this patch to make sure it doesn't break on the BL870c i4. Adrian > CC: Andrew Morton > CC: linux-i...@vger.kernel.org > Signed-off-by: Sergei Trofimovich > --- > arch/ia64/mm/init.c | 7 +-- > 1 file changed, 5 in

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-25 Thread Adrian Hunter
On 25/03/21 4:14 am, Asutosh Das (asd) wrote: > On 3/23/2021 12:19 PM, Adrian Hunter wrote: >> On 23/03/21 5:13 pm, Asutosh Das (asd) wrote: >>> On 3/22/2021 11:12 PM, Adrian Hunter wrote: >>>> On 22/03/21 9:53 pm, Asutosh Das (asd) wrote: >>>>&g

Re: [PATCH] ia64: mca: allocate early mca with GFP_ATOMIC

2021-03-24 Thread John Paul Adrian Glaubitz
Hi Andrew! On 3/24/21 11:39 PM, Andrew Morton wrote: > On Wed, 24 Mar 2021 11:20:45 +0100 John Paul Adrian Glaubitz > wrote: > >>>> #NEXT_PATCHES_START mainline-later (next week, approximately) >>>> ia64-mca-allocate-early-mca-with-gfp_atomic.patch >>

Re: [PATCH] ia64: Ensure proper NUMA distance and possible map initialization

2021-03-24 Thread John Paul Adrian Glaubitz
the possible map to >> the parsed map, which in this case seems to be the online map. >> >> Link: >> http://lore.kernel.org/r/255d6b5d-194e-eb0e-ecdd-97477a534...@physik.fu-berlin.de >> Fixes: 620a6dc40754 ("sched/topology: Make sched_init_numa() use a set for

Re: [PATCH] ia64: mca: allocate early mca with GFP_ATOMIC

2021-03-24 Thread John Paul Adrian Glaubitz
Hi Sergei! On 3/23/21 6:47 PM, Sergei Trofimovich wrote: > On Tue, 23 Mar 2021 16:15:06 +0100 > John Paul Adrian Glaubitz wrote: > >> Hi Andrew! >> >> On 3/15/21 9:50 AM, Sergei Trofimovich wrote: >>> The sleep warning happens at early boot right at

Re: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)

2021-03-24 Thread John Paul Adrian Glaubitz
> CC: Scott Teel > CC: Tomas Henzl > CC: "Martin K. Petersen" > CC: Don Brace > Reported-by: John Paul Adrian Glaubitz > Suggested-by: Don Brace > Fixes: f749d8b7a "scsi: hpsa: Correct dev cmds outstanding for retried cmds" > Signed-off-by: Sergei

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-23 Thread Adrian Hunter
On 23/03/21 5:13 pm, Asutosh Das (asd) wrote: > On 3/22/2021 11:12 PM, Adrian Hunter wrote: >> On 22/03/21 9:53 pm, Asutosh Das (asd) wrote: >>> On 3/19/2021 10:47 AM, Adrian Hunter wrote: >>>> On 19/03/21 2:35 am, Asutosh Das wrote: >>>>> During

[PATCH] tools: Remove duplicate definition of ia64_mf() on ia64

2021-03-23 Thread John Paul Adrian Glaubitz
"mf" ::: "memory") | cc1: all warnings being treated as errors Thus, remove the definition from tools/arch/ia64/include/asm/barrier.h. Signed-off-by: John Paul Adrian Glaubitz --- tools/arch/ia64/include/asm/barrier.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/t

[PATCH, v2] tools: Remove inclusion of ia64-specific version of errno.h header

2021-03-23 Thread John Paul Adrian Glaubitz
eneric wrappers") Signed-off-by: John Paul Adrian Glaubitz --- tools/include/uapi/asm/errno.h | 2 -- 1 file changed, 2 deletions(-) v2: - Rephrase summary diff --git a/tools/include/uapi/asm/errno.h b/tools/include/uapi/asm/errno.h index 637189ec1ab9..d30439b4b8ab 100644 --- a/tools/incl

[PATCH] tools: Remove ia64-specific errno.h inclusion from errno.h header

2021-03-23 Thread John Paul Adrian Glaubitz
eneric wrappers") Signed-off-by: John Paul Adrian Glaubitz --- tools/include/uapi/asm/errno.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/include/uapi/asm/errno.h b/tools/include/uapi/asm/errno.h index 637189ec1ab9..d30439b4b8ab 100644 --- a/tools/include/uapi/asm/errno.h +++ b/to

[PATCH] tools: Remove ia64-specific errno.h inclusion from errno.h header

2021-03-23 Thread John Paul Adrian Glaubitz
eneric wrappers") Signed-off-by: John Paul Adrian Glaubitz --- tools/include/uapi/asm/errno.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/include/uapi/asm/errno.h b/tools/include/uapi/asm/errno.h index 637189ec1ab9..d30439b4b8ab 100644 --- a/tools/include/uapi/asm/errno.h +++ b/to

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-23 Thread Catangiu, Adrian Costin
. What are your thoughts on it? Thanks, Adrian. On 23/03/2021, 14:57, "Greg KH" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Mar 08, 202

Re: [PATCH] ia64: mca: allocate early mca with GFP_ATOMIC

2021-03-23 Thread John Paul Adrian Glaubitz
- data = (void *)__get_free_pages(GFP_KERNEL, > + data = (void *)__get_free_pages(GFP_ATOMIC, > get_order(sz)); > if (!data) > panic("Could not allocate MCA memory for cpu %d\n", &g

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-23 Thread Adrian Hunter
On 22/03/21 9:53 pm, Asutosh Das (asd) wrote: > On 3/19/2021 10:47 AM, Adrian Hunter wrote: >> On 19/03/21 2:35 am, Asutosh Das wrote: >>> During runtime-suspend of ufs host, the scsi devices are >>> already suspended and so are the queues associated with them. >

Re: [PATCH 2/2] mmc: block: Update ext_csd.cache_ctrl if it was written

2021-03-22 Thread Adrian Hunter
On 22/03/21 3:36 pm, Avri Altman wrote: > The cache function can be turned ON and OFF by writing to the CACHE_CTRL > byte (EXT_CSD byte [33]). However, card->ext_csd.cache_ctrl is only > set on init if cache size > 0. > > Fix that by explicitly setting ext_csd.cache_ctrl on ext-csd write. > >

Re: [PATCH 1/2] mmc: block: Issue flush only if allowed

2021-03-22 Thread Adrian Hunter
On 22/03/21 3:36 pm, Avri Altman wrote: > The cache may be flushed to the nonvolatile storage by writing to > FLUSH_CACHE byte (EXT_CSD byte [32]). When in command queueing mode, the > cache may be flushed by issuing a CMDQ_TASK_ DEV_MGMT (CMD48) with a > FLUSH_CACHE op-code. Either way, verify

Re: [PATCH 02/10] ARM: disable CONFIG_IDE in footbridge_defconfig

2021-03-22 Thread John Paul Adrian Glaubitz
235071 2 ata_generic,pata_cypress root@tsunami:~ Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Re: remove the legacy ide driver

2021-03-21 Thread John Paul Adrian Glaubitz
eems pretty little work for someone experienced with libata. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Re: [PATCH] ia64: Ensure proper NUMA distance and possible map initialization

2021-03-20 Thread John Paul Adrian Glaubitz
On 3/19/21 8:10 PM, Sergei Trofimovich wrote: > On Fri, 19 Mar 2021 15:47:09 +0100 > John Paul Adrian Glaubitz wrote: > >> Hi Valentin! >> >> On 3/18/21 2:06 PM, Valentin Schneider wrote: >>> John Paul reported a warning about bogus NUMA d

Re: [PATCH] IA64: Trivial spelling fixes

2021-03-20 Thread John Paul Adrian Glaubitz
all-lowercase letters for architecture names in the Linux kernel, so it should probably be "ia64: Trivial spelling fixes". And the easiest way to get those fixes into the kernel would be through Andrew Morton's tree. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer -

Re: [PATCH v12 1/2] scsi: ufs: Enable power management for wlun

2021-03-19 Thread Adrian Hunter
On 19/03/21 2:35 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU to wlun during its runtime-suspend. > During the process blk_queue_enter checks if the queue is not in >

Re: [PATCH] ia64: Ensure proper NUMA distance and possible map initialization

2021-03-19 Thread John Paul Adrian Glaubitz
6b5d-194e-eb0e-ecdd-97477a534...@physik.fu-berlin.de > Fixes: 620a6dc40754 ("sched/topology: Make sched_init_numa() use a set for > the deduplicating sort") > Reported-by: John Paul Adrian Glaubitz > Signed-off-by: Valentin Schneider > --- > This might need an earlier Fi

Re: sparc: clang: error: unknown argument: '-mno-fpu'

2021-03-19 Thread John Paul Adrian Glaubitz
nd he said, they are interested in supporting as many architectures as possible in their efforts. Adrian > [1] http://m68k.info/#llvm:linux:video -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de

Re: sparc: clang: error: unknown argument: '-mno-fpu'

2021-03-19 Thread John Paul Adrian Glaubitz
ere. There are some other SPARC-related clang bugs that need to be squashed first. We have made quite some improvements and it's actually maintained by the community. Of course, we don't have a commercial backer but that shouldn't be necessary for open source to work. Adrian -- .''`. John Paul

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-18 Thread Adrian Hunter
On 18/03/21 7:58 pm, Asutosh Das (asd) wrote: > On 3/18/2021 10:54 AM, Rafael J. Wysocki wrote: >> On Thu, Mar 18, 2021 at 6:33 PM Asutosh Das (asd) >> wrote: >>> >>> On 3/18/2021 7:00 AM, Rafael J. Wysocki wrote: >>>> On Wed, Mar 17, 2021 at 7:37 AM

Re: [PATCH 0/1] sched/topology: NUMA distance deduplication

2021-03-18 Thread John Paul Adrian Glaubitz
Hello! On 3/18/21 12:26 AM, John Paul Adrian Glaubitz wrote: >> b) do anything? > > It fixes the problem for me. Here are the kernel messages with your patch applied: [0.00] Linux version 5.12.0-rc3+ (glaubitz@epyc) (ia64-linux-gcc (GCC) 10.1.0, GNU ld (GNU Binutils) 2.

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-18 Thread John Paul Adrian Glaubitz
poration 82541PI Gigabit Ethernet Controller (rev 05) root@tsunami:~> lsmod|grep pata pata_cypress3595 3 libata235071 2 ata_generic,pata_cypress root@tsunami:~> I also have two AlphaStation 233 currently in storage which I assume use different IDE chipset which I could

Re: [PATCH 0/1] sched/topology: NUMA distance deduplication

2021-03-17 Thread John Paul Adrian Glaubitz
arch/ia64/kernel/setup.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1851: arch/ia64/kernel] Error 2 -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Re: [PATCH 0/1] sched/topology: NUMA distance deduplication

2021-03-17 Thread John Paul Adrian Glaubitz
system doesn't end up with nr_node_ids=1. >> > > Does the below > a) compile Yes. > b) do anything? It fixes the problem for me. Will test Sergei's patch now. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - g

Re: [PATCH 0/1] sched/topology: NUMA distance deduplication

2021-03-17 Thread John Paul Adrian Glaubitz
omewhat generic kernel image > on a wide host of machines; d) is also a bit yucky... Shouldn't the kernel be able to cope with quirky hardware? From what I remember in the past, ACPI tables used to be broken quite a lot and the kernel contained workarounds for such cases, didn't it? Adrian

Re: 5.11 regression: "ia64: add support for TIF_NOTIFY_SIGNAL" breaks ia64 boot

2021-03-17 Thread John Paul Adrian Glaubitz
Hi! On 3/17/21 6:42 PM, John Paul Adrian Glaubitz wrote: >> Here are dmesg and config from my machine with successfull boot: >> https://dev.gentoo.org/~slyfox/configs/guppy-dmesg-5.11 >> https://dev.gentoo.org/~slyfox/configs/guppy-config-5.11 > > Just gave it

Re: 5.11 regression: "ia64: add support for TIF_NOTIFY_SIGNAL" breaks ia64 boot

2021-03-17 Thread John Paul Adrian Glaubitz
>> >> [0.036000] 00 00 00 00 00 00 > > I don't see this string in the 5.11 kernel source. But > > https://lore.kernel.org/lkml/161356785681.20312.13022545187499987936.tip-bot2@tip-bot2/T/ > hints it's might be something very

Re: [PATCH] hpsa: fix boot on ia64 (atomic_t alignment)

2021-03-17 Thread John Paul Adrian Glaubitz
move packing annotation from struct but only > restores alignment of atomic variable. > > The change is tested on the same rx3600 machine. I just gave it a try on my RX2660 and for me, the hpsa driver won't load even with your patch. Can you share your kernel configuration so I c

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-17 Thread Adrian Hunter
On 16/03/21 10:35 pm, Asutosh Das (asd) wrote: > On 3/16/2021 12:48 AM, Adrian Hunter wrote: >> On 16/03/21 12:22 am, Asutosh Das (asd) wrote: >>> On 3/14/2021 1:11 AM, Adrian Hunter wrote: >>>> On 10/03/21 5:04 am, Asutosh Das (asd) wrote: >>>>>

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-16 Thread Adrian Hunter
On 16/03/21 12:22 am, Asutosh Das (asd) wrote: > On 3/14/2021 1:11 AM, Adrian Hunter wrote: >> On 10/03/21 5:04 am, Asutosh Das (asd) wrote: >>> On 3/9/2021 7:56 AM, Asutosh Das (asd) wrote: >>>> On 3/8/2021 9:17 AM, Rafael J. Wysocki wrote: >>>>> On

Re: [PATCH v1 1/1] mmc: sdhci-acpi: Add support for NVIDIA BlueField-3 SoC

2021-03-15 Thread Adrian Hunter
On 15/03/21 7:00 pm, Liming Sun wrote: > Thanks Adrian. Yes, I did consider adding this ACPI support into > sdhci-of-dwcmshc.c, but not sure which one is the preferred way. > Is this (sdhci-of-dwcmshc.c) what you recommend? I'll post the revised > changes in patch v2. Yes, that

Re: [PATCH v11 1/2] scsi: ufs: Enable power management for wlun

2021-03-15 Thread Adrian Hunter
On 12/03/21 12:19 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU to wlun during its runtime-suspend. > During the process blk_queue_enter checks if the queue is not in >

Re: [PATCH v1 1/1] mmc: sdhci-acpi: Add support for NVIDIA BlueField-3 SoC

2021-03-15 Thread Adrian Hunter
On 12/03/21 3:48 pm, Liming Sun wrote: > This commit adds ACPI support for the BlueField-3 SoC which uses > the DWC_mshc eMMC controller. The boundary check logic in static > function dwcmshc_adma_write_desc() comes from sdhci-of-dwcmshc.c. Did you consider adding ACPI support to

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-14 Thread Adrian Hunter
c_run_entry_fn+0x48/0x128 > [    7.574695][  T212]  process_one_work+0x1f0/0x470 > [    7.574698][  T212]  worker_thread+0x26c/0x4c8 > [    7.574700][  T212]  kthread+0x13c/0x320 > [    7.574703][  T212]  ret_from_fork+0x10/0x18 > [    7.574706][  T212] sd 0:0:0:4: scsi_runtime_idle > [    7.574712][  T212] sd 0:0:0:4: __pm_runtime_idle: aft: [UFSDBG]: > pwr.timer_autosuspends: 1 pwr.request_pending: 0 retval: -16 pwr.request: 0 > usage_count: 0 rpm_status: 0 link-rpm_active:2 > [    7.574715][  T212] sd 0:0:0:4: sd_probe: [UFSDBG]: Exit > [    7.574738][  T212] sd 0:0:0:4: __pm_runtime_idle: b4: [UFSDBG]: > pwr.request: 0 usage_count: 0 rpm_status: 0 link-rpm_active:2 > > [    7.574752][  T212] Workqueue: events_unbound async_run_entry_fn > [    7.574754][  T212] Call trace: > [    7.574758][  T212]  dump_backtrace+0x0/0x1d4 > [    7.574761][  T212]  show_stack+0x18/0x24 > [    7.574765][  T212]  dump_stack+0xc4/0x144 > [    7.574767][  T212]  __pm_runtime_idle+0xb4/0x184 > [    7.574770][  T212]  driver_probe_device+0x94/0xf0 > [    7.574773][  T212]  __device_attach_driver+0x114/0x138 > [    7.574775][  T212]  bus_for_each_drv+0x84/0xd0 > [    7.574778][  T212]  __device_attach_async_helper+0x7c/0xf0 > [    7.574781][  T212]  async_run_entry_fn+0x48/0x128 > [    7.574783][  T212]  process_one_work+0x1f0/0x470 > [    7.574786][  T212]  worker_thread+0x26c/0x4c8 > [    7.574788][  T212]  kthread+0x13c/0x320 > [    7.574791][  T212]  ret_from_fork+0x10/0x18 > [    7.574848][   T80] sd 0:0:0:4: scsi_runtime_idle > [    7.574858][  T212] sd 0:0:0:4: __pm_runtime_idle: aft: [UFSDBG]: > pwr.timer_autosuspends: 1 pwr.request_pending: 0 retval: 0 pwr.request: 0 > usage_count: 0 rpm_status: 0 link-rpm_active:2 > [    7.574863][  T212] sd 0:0:0:4: pm_runtime_put_suppliers: [UFSDBG]: > rpm_status: 0 link-rpm_active:1 > [    7.574866][  T212] sd 0:0:0:4: async probe completed > [    7.574870][  T212] sd 0:0:0:4: __pm_runtime_idle: b4: [UFSDBG]: > pwr.request: 0 usage_count: 0 rpm_status: 0 link-rpm_active:1 > > > So, from the above it looks like when async probe is enabled this is a > possibility. > > I don't see a way around this. Please let me know if you > (@Alan/@Bart/@Adrian) have any thoughts on this. > > Thanks, > -asd >

[PATCH] scsi: ufs-pci: Add support for Intel LKF

2021-03-12 Thread Adrian Hunter
Add PCI ID and callbacks to support Intel LKF. This includes the ability to use an ACPI device-specific method (DSM) to perform a UFS device reset. Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd-pci.c | 169 ++ 1 file changed, 169 insertions(+) diff

Re: [PATCH] mmc: sdhci-pci: Avoid comma separated statements

2021-03-11 Thread Adrian Hunter
On 11/03/21 12:14 pm, Jisheng Zhang wrote: > Use semicolons. > > Signed-off-by: Jisheng Zhang Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-pci-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pci-core

Re: [PATCH] mmc: sdhci: Use "mmc" directly rather than "host->mmc"

2021-03-11 Thread Adrian Hunter
11000463add w3, w3, #0x1 > 908: 94000000bl 0 > ... > > We saved one ldr instruction: "ldr x0, [x0, #1160]" > > Signed-off-by: Jisheng Zhang Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci.c | 33 ++

Re: [PATCH] ia64: kernel: Few typos fixed in the file fsys.S

2021-03-10 Thread John Paul Adrian Glaubitz
s tree will just work fine in this case? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Re: [GIT] SPARC

2021-03-08 Thread John Paul Adrian Glaubitz
It fixes a hard kernel crash under certain loads which we have seen in Debian quite frequently. Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546

[PATCH] perf auxtrace: Fix auxtrace queue conflict

2021-03-08 Thread Adrian Hunter
sample mode to trace multiple threads. Consequently, fix that case by removing the check. Reported-by: Andi Kleen Fixes: e502789302a6 ("perf auxtrace: Add helpers for queuing AUX area tracing data") Signed-off-by: Adrian Hunter --- tools/perf/util/auxtrace.c | 4 1 file

[PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-08 Thread Adrian Catangiu
does not guarantee complete snapshot safety to applications using it. A certain workflow needs to be followed at the system level, in order to make the system snapshot-resilient. Please see the "Snapshot Safety Prerequisites" section in the included documentation. Signed-off-by: Adria

[PATCH 1/1] Documentation/x86/boot: Correct algorithm for runtime start address

2021-03-07 Thread Adrian Huang
From: Adrian Huang Commit 8ab3820fd5b2 ("x86, kaslr: Return location from decompress_kernel") enforces CONFIG_PHYSICAL_START as the minimum relocation address when the kernel option CONFIG_RELOCATABLE is enabled. This change should be included accordingly. Signed-off-by: Adrian Huang

Re: [PATCH v7 0/2] System Generation ID driver and VMGENID backend

2021-03-04 Thread Catangiu, Adrian Costin
Hi Michael, On 24/02/2021, 11:06, "Michael S. Tsirkin" wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Wed, Feb 24, 2021 at 10:47:30AM +02

Re: [PATCH v10 1/2] scsi: ufs: Enable power management for wlun

2021-03-04 Thread Adrian Hunter
On 3/03/21 12:52 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU to wlun during its runtime-suspend. > During the process blk_queue_enter checks if the queue is not in >

Re: [PATCH v10 2/2] ufs: sysfs: Resume the proper scsi device

2021-03-03 Thread Adrian Hunter
On 3/03/21 12:52 am, Asutosh Das wrote: > Resumes the actual scsi device the unit descriptor of which > is being accessed instead of the hba alone. Since "scsi: ufs: ufs-debugfs: Add user-defined exception_event_mask" is now in linux-next, a similar change is needed for ufs-debugfs.c. Probably

Re: [PATCH v2 1/1] mmc: cqhci: fix random crash when remove mmc module

2021-03-03 Thread Adrian Hunter
(2) pass check here > cq_host->enable = false; > > task_desc= > get_desc(cq_host,tag); > ^^^^ crash here > (3) acces

Re: [PATCH V1] mmc: sdhci: Check for reset prior to DMA address unmap

2021-03-03 Thread Adrian Hunter
completed. So we don't run into this > scenario. > > Swap the reset, un-map steps sequence in sdhci_request_done(). > > Suggested-by: Veerabhadrarao Badiganti > Signed-off-by: Pradeep P V K Seems like a good change to make. A couple of cosmetic tweaks below, but: Acked-by: Adri

Re: 5.11 regression: "ia64: add support for TIF_NOTIFY_SIGNAL" breaks ia64 boot

2021-03-02 Thread John Paul Adrian Glaubitz
signal regression merged as well as your two fixes for strace. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913

Re: [PATCH] sh: Use generic GGC library routines

2021-03-02 Thread John Paul Adrian Glaubitz
he include path in arch/sh/boot/compressed accordingly. > > Signed-off-by: Geert Uytterhoeven There is a funny typo in the subject you probably want to fix :-). Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub..

Re: [PATCH 1/1] mmc: cqhci: fix random crash when remove mmc module

2021-03-02 Thread Adrian Hunter
On 2/03/21 5:12 pm, Zhi Li wrote: > > > On Tue, Mar 2, 2021 at 1:03 AM Adrian Hunter <mailto:adrian.hun...@intel.com>> wrote: > > On 1/03/21 7:21 pm, Frank Li wrote: > > [ 6684.493350] Unable to handle kernel paging request at virtual > address 8

Re: [PATCH v9 1/2] scsi: ufs: Enable power management for wlun

2021-03-02 Thread Adrian Hunter
On 2/03/21 5:21 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But the ufs host sends SSU to wlun during its runtime-suspend. > During the process blk_queue_enter checks if the queue is not in >

Re: [PATCH] scsi: ufs: Fix incorrect ufshcd_state after ufshcd_reset_and_restore()

2021-03-02 Thread Adrian Hunter
_RESET in the start of each >> loop in ufshcd_reset_and_restore(). If there is an error, >> ufshcd_reset_and_restore() will change the state to UFSHCD_STATE_ERROR, >> otherwise ufshcd_probe_hba() will have set the state appropriately. >> >> Fixes: 4db7a2360597 ("scsi: ufs: Fi

Re: [PATCH 1/1] mmc: cqhci: fix random crash when remove mmc module

2021-03-02 Thread Adrian Hunter
On 1/03/21 7:21 pm, Frank Li wrote: > [ 6684.493350] Unable to handle kernel paging request at virtual address > 800011c5b0f0 > [ 6684.498531] mmc0: card 0001 removed > [ 6684.501556] Mem abort info: > [ 6684.509681] ESR = 0x9647 > [ 6684.512786] EC = 0x25: DABT (current EL), IL = 32

[PATCH] scsi: ufs: Fix incorrect ufshcd_state after ufshcd_reset_and_restore()

2021-03-01 Thread Adrian Hunter
to UFSHCD_STATE_ERROR, otherwise ufshcd_probe_hba() will have set the state appropriately. Fixes: 4db7a2360597 ("scsi: ufs: Fix concurrency of error handler and other error recovery paths") Signed-off-by: Adrian Hunter --- drivers/scsi/ufs/ufshcd.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v8 1/2] scsi: ufs: Enable power management for wlun

2021-03-01 Thread Adrian Hunter
On 1/03/21 8:10 pm, Asutosh Das wrote: > On Mon, Mar 01 2021 at 05:23 -0800, Adrian Hunter wrote: >> On 26/02/21 1:37 am, Asutosh Das wrote: >>> @@ -8901,43 +9125,14 @@ static int ufshcd_resume(struct ufs_hba *hba, enum >>> ufs_pm_op pm_op) >>&

Re: [PATCH v8 1/2] scsi: ufs: Enable power management for wlun

2021-03-01 Thread Adrian Hunter
Hi A couple of minor things, but also a potential issue with when link state transitions are done. Please see comments below. On 26/02/21 1:37 am, Asutosh Das wrote: > During runtime-suspend of ufs host, the scsi devices are > already suspended and so are the queues associated with them. > But

  1   2   3   4   5   6   7   8   9   10   >