Re: [PATCH v19 0/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-22 Thread Alex Williamson
rs/vfio/pci/nvgrace-gpu/main.c | 879 ++ > drivers/vfio/pci/vfio_pci_config.c| 42 ++ > drivers/vfio/pci/vfio_pci_rdwr.c | 16 +- > drivers/vfio/pci/virtio/main.c| 72 +-- > include/linux/vfio_pci_core.h | 10 +- > 10 files changed, 993 insertions(+), 59 deletions(-) > create mode 100644 drivers/vfio/pci/nvgrace-gpu/Kconfig > create mode 100644 drivers/vfio/pci/nvgrace-gpu/Makefile > create mode 100644 drivers/vfio/pci/nvgrace-gpu/main.c > Applied to vfio next branch for v6.9. Thanks, Alex

Re: [PATCH v17 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-09 Thread Alex Williamson
On Fri, 9 Feb 2024 13:19:03 -0400 Jason Gunthorpe wrote: > On Fri, Feb 09, 2024 at 08:55:31AM -0700, Alex Williamson wrote: > > I think Kevin's point is also relative to this latter scenario, in the > > L1 instance of the nvgrace-gpu driver the mmap of the usemem BAR is >

Re: [PATCH v17 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-09 Thread Alex Williamson
through the fake BARs, the virtualization of the device has already happened in the level 1 assignment. I think Kevin's point is also relative to this latter scenario, in the L1 instance of the nvgrace-gpu driver the mmap of the usemem BAR is cachable, but in the L2 instance of the driver where we only use the vfio-pci-core ops nothing maintains that cachable mapping. Is that a problem? An uncached mapping on top of a cachable mapping is often prone to problems. Thanks, Alex

Re: [PATCH v17 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-08 Thread Alex Williamson
t; > >> > +   mem_count = 0; > > >> > > >> If mem_count == 0, going through nvgrace_gpu_map_and_read() is not > > >> necessary. > > > > > > Harmless, other than the possibly unnecessary call through to > > > nvgra

Re: [PATCH v17 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-07 Thread Alex Williamson
..@vger.kernel.org > +S: Supported > +F: drivers/vfio/pci/nvgrace-gpu/ > + Entries should be alphabetical. This will end up colliding with [1] so I'll plan to fix it either way. Otherwise just a couple optional comments from me below. I see Zhi also has a few good comments.

Re: [PATCH v17 3/3] vfio/nvgrace-gpu: Add vfio pci variant module for grace hopper

2024-02-07 Thread Alex Williamson
memregion->memlength, > > + MEMREMAP_WB); > > + if (!memregion->memaddr) > > + ret = -ENOMEM; > > + } else if (index == RESMEM_REGION_INDEX && > > !mem

Re: [PATCH] vfio: fix virtio-pci dependency

2024-01-10 Thread Alex Williamson
mp;& VIRTIO_PCI_ADMIN_LEGACY > select VFIO_PCI_CORE > help >This provides support for exposing VIRTIO NET VF devices which > support Applied to vfio next branch for v6.8. Thanks! Alex

Re: [PATCH 35/40] drm/amd/amdgpu/amdgpu_cs: Repair some function naming disparity

2021-04-20 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 16, 2021 at 11:54 AM Christian König wrote: > > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c:685: warning: expecting prototype > > f

Re: [PATCH 33/40] drm/amd/amdgpu/amdgpu_ring: Provide description for 'sched_score'

2021-04-20 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 16, 2021 at 11:54 AM Christian König wrote: > > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:169: warning: Function parameter > &g

Re: [PATCH 32/40] drm/amd/amdgpu/amdgpu_ttm: Fix incorrectly documented function 'amdgpu_ttm_copy_mem_to_mem()'

2021-04-20 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 16, 2021 at 11:53 AM Christian König wrote: > > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:311: warning: expecting prototype > >

Re: [PATCH 31/40] drm/amd/amdgpu/amdgpu_gart: Correct a couple of function names in the docs

2021-04-20 Thread Alex Deucher
Applied. thanks! Alex On Fri, Apr 16, 2021 at 11:53 AM Christian König wrote: > > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:73: warning: expecting prototype > &

Re: [PATCH 29/40] drm/amd/amdgpu/amdgpu_fence: Provide description for 'sched_score'

2021-04-20 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 16, 2021 at 11:52 AM Christian König wrote: > > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:444: warning: Function > > paramet

Re: [PATCH 25/40] drm/radeon/radeon_device: Provide function name in kernel-doc header

2021-04-20 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 16, 2021 at 11:51 AM Christian König wrote: > > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_device.c:1101: warning: This comment starts > >

Re: [PATCH 26/40] drm/amd/amdgpu/amdgpu_device: Remove unused variable 'r'

2021-04-20 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Apr 16, 2021 at 10:38 AM Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function > ‘amdgpu_device_suspend’: > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:3733:6: warning

Re: [RFC PATCH 2/3] vfio/hisilicon: register the driver to vfio

2021-04-20 Thread Alex Williamson
host kernel to support this rather than implementing it in userspace? For example, QEMU could know about this device, manipulate the BAR size to expose only the operational portion of MMIO to the VM and use the remainder to support migration itself. I'm afraid that just like mdev, the vfio migration uAPI is going to be used as an excuse to create kernel drivers simply to be able to make use of that uAPI. I haven't looked at this driver to know if it has some other reason to exist beyond what could be done through vfio-pci and userspace migration support. Thanks, Alex

Re: [PATCH 23/40] drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs'

2021-04-20 Thread Alex Deucher
> > Cc: linaro-mm-...@lists.linaro.org > > Signed-off-by: Lee Jones > > Reviewed-by: Christian König Can you push the ttm and sched fixes to drm-misc? Alex > > > --- > > drivers/gpu/drm/ttm/ttm_bo.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v5 1/3] riscv: Move kernel mapping outside of linear mapping

2021-04-18 Thread Alex Ghiti
Hi Palmer, Le 4/15/21 à 2:00 PM, Alex Ghiti a écrit : Le 4/15/21 à 12:54 AM, Alex Ghiti a écrit : Le 4/15/21 à 12:20 AM, Palmer Dabbelt a écrit : On Sun, 11 Apr 2021 09:41:44 PDT (-0700), a...@ghiti.fr wrote: This is a preparatory patch for relocatable kernel and sv48 support. The kernel

Re: [PATCH] riscv: Protect kernel linear mapping only if CONFIG_STRICT_KERNEL_RWX is set

2021-04-17 Thread Alex Ghiti
s, Thanks for sorting this out so quickly! Otherwise it looks good. Reviewed-by: Anup Patel Thank you! Alex Regards, Anup ---   arch/riscv/kernel/setup.c | 8   1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setu

Re: [PATCH v4 1/3] riscv: Move kernel mapping outside of linear mapping

2021-04-17 Thread Alex Ghiti
kernel in this series, I fixed that here: Thank you for testing and reporting, Alex Guenter ___ linux-riscv mailing list linux-ri...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH V4 05/18] iommu/ioasid: Redefine IOASID set and allocation APIs

2021-04-16 Thread Alex Williamson
vfio-pci as doing, > > it can even do them the same way you just described. > > > > Stated another way, do you plan to duplicate all of this code someday > > for vfio-cxl? What about for vfio-platform? ARM SMMU can be hooked to > > platform devices, right? > > > &

[PATCH net-next 2/2] net: ipa: optionally define firmware name via DT

2021-04-16 Thread Alex Elder
pose. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_main.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index aad915e2ce523..9915603ed10ba 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/driver

[PATCH net-next 1/2] dt-bindings: net: qcom,ipa: add firmware-name property

2021-04-16 Thread Alex Elder
") is used. Signed-off-by: Alex Elder --- .../devicetree/bindings/net/qcom,ipa.yaml | 19 +++ 1 file changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index da5212e693e91..7443490d4cc

[PATCH net-next 0/2] net: ipa: allow different firmware names

2021-04-16 Thread Alex Elder
Add the ability to define a "firmware-name" property in the IPA DT node, specifying an alternate name to use for the firmware file. Used only if the AP (Trust Zone) does early IPA initialization. -Alex Alex Elder (2): dt-bindings: net: qco

Re: [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-16 Thread Alex Elder
On 4/15/21 10:40 PM, zhuguangqin...@gmail.com wrote: From: Guangqing Zhu This is not required here. -Alex https://lore.kernel.org/netdev/d57e0a43-4d87-93cf-471c-c8185ea85...@ieee.org/ Coccinelle noticed: drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary handler

Re: [PATCH] riscv: Protect kernel linear mapping only if CONFIG_STRICT_KERNEL_RWX is set

2021-04-16 Thread Alex Ghiti
mapping. Signed-off-by: Alexandre Ghiti Maybe you should add "Fixes:" tag in commit tag ? Yes you're right I should have done that. Maybe Palmer will squash it as it just entered for-next? Otherwise it looks good. Reviewed-by: Anup Patel Thank you! Alex Regards, An

Re: linux-next: build warning after merge of the amdgpu tree

2021-04-15 Thread Alex Deucher
On Fri, Apr 16, 2021 at 1:47 AM Liang, Prike wrote: > > [AMD Public Use] > > > From: Stephen Rothwell > > Sent: Friday, April 16, 2021 12:09 PM > > To: Liang, Prike > > Cc: Alex Deucher ; S-k, Shyam-sundar > sundar@amd.com>; Linux Kernel Mailing List

Re: [Regression] amdgpu driver broken on AMD HD7770 GHz edition.

2021-04-15 Thread Alex Deucher
On Fri, Apr 16, 2021 at 12:48 AM David Niklas wrote: > > Hey, > > I forgot to give you a bug tracker in case you want one. > Here: https://bugzilla.kernel.org/show_bug.cgi?id=212691 I've followed up on the bug report. Please take a look there. Alex

Re: [External] : Re: [PATCH v14 4/6] locking/qspinlock: Introduce starvation avoidance into CNA

2021-04-15 Thread Alex Kogan
> On Apr 13, 2021, at 8:03 AM, Peter Zijlstra wrote: > > On Thu, Apr 01, 2021 at 11:31:54AM -0400, Alex Kogan wrote: > >> @@ -49,13 +55,33 @@ struct cna_node { >> u16 real_numa_node; >> u32 encoded_

Re: [RFC PATCH 0/3] vfio/hisilicon: add acc live migration driver

2021-04-15 Thread Alex Williamson
[Cc+ NVIDIA folks both from migration and vfio-pci-core discussion] On Tue, 13 Apr 2021 11:36:20 +0800 Longfang Liu wrote: > The live migration solution relies on the vfio_device_migration_info protocol. > The structure vfio_device_migration_info is placed at the 0th offset of > the VFIO_REGION_

Re: [PATCH 3/3] vfio/iommu_type1: Add support for manual dirty log clear

2021-04-15 Thread Alex Williamson
ag used in combination with _GET or a separate _GET_NOCLEAR operations. Thanks, Alex > Co-developed-by: Keqian Zhu > Signed-off-by: Kunkun Jiang > --- > drivers/vfio/vfio_iommu_type1.c | 100 ++-- > include/uapi/linux/vfio.h | 28 - > 2 fi

Re: linux-next: manual merge of the vfio tree with the drm tree

2021-04-15 Thread Alex Williamson
gt; > from the vfio tree. > > > > I fixed it up (I used the latter version) and can carry the fix as > > necessary. > > Yes that is right, thank you Yep, thanks! Alex

Re: QCA6174 pcie wifi: Add pci quirks

2021-04-15 Thread Alex Williamson
[cc +Pali] On Thu, 15 Apr 2021 20:02:23 +0200 Ingmar Klein wrote: > First thanks to you both, Alex and Bjorn! > I am in no way an expert on this topic, so I have to fully rely on your > feedback, concerning this issue. > > If you should have any other solution approach, in form

Re: [PATCH v5 1/3] riscv: Move kernel mapping outside of linear mapping

2021-04-15 Thread Alex Ghiti
Le 4/15/21 à 12:54 AM, Alex Ghiti a écrit : Le 4/15/21 à 12:20 AM, Palmer Dabbelt a écrit : On Sun, 11 Apr 2021 09:41:44 PDT (-0700), a...@ghiti.fr wrote: This is a preparatory patch for relocatable kernel and sv48 support. The kernel used to be linked at PAGE_OFFSET address therefore we

Re: [PATCH] drm/radeon/si: Fix inconsistent indenting

2021-04-15 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Apr 15, 2021 at 5:30 AM Yang Li wrote: > > Kernel test robot throws below warning -> > > smatch warnings: > drivers/gpu/drm/radeon/si.c:4514 si_vm_packet3_cp_dma_check() warn: > inconsistent indenting > > Fixed the inconsistent indent

Re: [PATCH v5 1/3] riscv: Move kernel mapping outside of linear mapping

2021-04-14 Thread Alex Ghiti
This is breaking boot for me with CONFIG_STRICT_KERNEL_RWX=n.  I'm not even really convinced that's a useful config to support, but it's currently optional and I'd prefer to avoid breaking it if possible. I can't quite figure out what's going on here and I'm pretty much tired out for tonight.  LMK if you don't have time to look at it and I'll try to give it another shot. I'm taking a look at that. Thanks, Alex

Re: QCA6174 pcie wifi: Add pci quirks

2021-04-14 Thread Alex Williamson
On Wed, 14 Apr 2021 16:03:50 -0500 Bjorn Helgaas wrote: > [+cc Alex] > > On Fri, Apr 09, 2021 at 11:26:33AM +0200, Ingmar Klein wrote: > > Edit: Retry, as I did not consider, that my mail-client would make this > > party html. > > > > Dear maintainers, > >

Re: [External] : Re: [PATCH v14 6/6] locking/qspinlock: Introduce the shuffle reduction optimization into CNA

2021-04-14 Thread Alex Kogan
Hi, Andreas. Thanks for the great questions. > On Apr 14, 2021, at 3:47 AM, Andreas Herrmann wrote: > > On Thu, Apr 01, 2021 at 11:31:56AM -0400, Alex Kogan wrote: >> This performance optimization chooses probabilistically to avoid moving >> threads from the main queue i

[GIT PULL] VFIO fix for v5.12-rc8/final

2021-04-14 Thread Alex Williamson
Hi Linus, Sorry for the late request. The following changes since commit d434405aaab7d0ebc516b68a8fc4100922d7f5ef: Linux 5.12-rc7 (2021-04-11 15:16:13 -0700) are available in the Git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v5.12-rc8 for you to fetch changes up to

Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-14 Thread Alex Elder
On 4/14/21 9:29 AM, Joe Perches wrote: On Wed, 2021-04-14 at 08:17 -0500, Alex Elder wrote: Perhaps (like the -W options for GCC) there could be a way to specify in a Makefile which checkpatch messages are reported/not reported? I don't claim that's a good suggestion, but if I could

Re: [PATCH v5] docs/zh_CN: add translations in zh_CN/dev-tools/gcov

2021-04-14 Thread Alex Shi
Reviewed-by: Alex Shi On 2021/4/14 下午9:21, Wu XiangCheng wrote: > From: Bernard Zhao > > Add new zh translations > * zh_CN/dev-tools/gcov.rst > * zh_CN/dev-tools/index.rst > and link them to zh_CN/index.rst > > Signed-off-by: Bernard Zhao > Reviewed-by: Wu Xian

Re: [PATCH] staging: greybus: Match parentheses alignment

2021-04-14 Thread Alex Elder
make it readable. I've made a mental note to go look at this and see if I can make it better. I can't say when I'll get to it but I think it's a good suggestion. -Alex Using identifiers of that length makes using 80 column, or e

Re: [PATCH v4] docs/zh_CN: add translations in zh_CN/dev-tools/gcov

2021-04-14 Thread Alex Shi
da`` > +gcov工具可以识别的覆盖率统计数据文件,向该文件写入数据后 > + 会将本文件的gcov统计数据清0 > + > +``/sys/kernel/debug/gcov/path/to/compile/dir/file.gcno`` > +gcov工具需要的软连接文件(指向编译时生成的信息统计文件),这个文件是 > +在gcc编译时如果配置了选项 ``-ftest-coverage`` 时生成的。 > + > + > +针对模块的统计 > +-- > +

Re: [PATCH] implement flush_cache_vmap for RISC-V

2021-04-14 Thread Alex Ghiti
Hi, Le 4/12/21 à 3:08 AM, Jisheng Zhang a écrit : Hi Jiuyang, On Mon, 12 Apr 2021 00:05:30 + Jiuyang Liu wrote: This patch implements flush_cache_vmap for RISC-V, since it modifies PTE. Without this patch, SFENCE.VMA won't be added to related codes, which might introduce a bug in the o

Re: [External] : Re: [PATCH v14 4/6] locking/qspinlock: Introduce starvation avoidance into CNA

2021-04-13 Thread Alex Kogan
; So you don’t think we need the command-line parameter, just the module_param? > > module_params can be changed at the command line too, so yes. Got it, thanks again. — Alex

Re: [External] : Re: [PATCH v14 3/6] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2021-04-13 Thread Alex Kogan
Peter, thanks for all the comments and suggestions! > On Apr 13, 2021, at 7:30 AM, Peter Zijlstra wrote: > > On Thu, Apr 01, 2021 at 11:31:53AM -0400, Alex Kogan wrote: > >> +/* >> + * cna_splice_tail -- splice the next node from the primary queue onto &g

Re: [PATCH] efifb: Check efifb_pci_dev before using it

2021-04-13 Thread Alex Deucher
On Tue, Apr 13, 2021 at 2:37 PM Daniel Vetter wrote: > > On Tue, Apr 13, 2021 at 8:02 PM Alex Deucher wrote: > > > > On Tue, Apr 13, 2021 at 1:05 PM Kai-Heng Feng > > wrote: > > > > > > On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb

Re: [External] : Re: [PATCH v14 4/6] locking/qspinlock: Introduce starvation avoidance into CNA

2021-04-13 Thread Alex Kogan
Hi, Andi. Thanks for your comments! > On Apr 13, 2021, at 2:03 AM, Andi Kleen wrote: > > Alex Kogan writes: >> >> +numa_spinlock_threshold=[NUMA, PV_OPS] >> +Set the time threshold in milliseconds for the >> +

Re: [PATCH] vfio/iommu_type1: Remove unused pinned_page_dirty_scope in vfio_iommu

2021-04-13 Thread Alex Williamson
here. > > Signed-off-by: Keqian Zhu > --- > > However, I'm not clear about the root problem. Is there a bug in git? Strange, clearly I broke something in merge commit 76adb20f924f, but it's not evident to me how that line reappeared. Thanks for spotting it, I'll qu

Re: [PATCH] efifb: Check efifb_pci_dev before using it

2021-04-13 Thread Alex Deucher
r efifb stays at PCI > D0") > BugLink: https://bugs.launchpad.net/bugs/1922403 > Signed-off-by: Kai-Heng Feng Reviewed-by: Alex Deucher > --- > drivers/video/fbdev/efifb.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/efi

[PATCH net-next 2/2] arm64: dts: qcom: sm8350-mtp: enable IPA

2021-04-13 Thread Alex Elder
Enable IPA for the SM8350 MTP. Signed-off-by: Alex Elder --- arch/arm64/boot/dts/qcom/sm8350-mtp.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-mtp.dts b/arch/arm64/boot/dts/qcom/sm8350-mtp.dts index 6ca638b4e3213..93740444dd1ea 100644 --- a/arch

[PATCH net-next 1/2] arm64: dts: qcom: sm8350: add IPA information

2021-04-13 Thread Alex Elder
Add IPA-related nodes and definitions to "sm8350.dtsi", which uses IPA v4.9. Signed-off-by: Alex Elder --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 51 1 file changed, 51 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boo

[PATCH net-next 0/2] arm64: dts: qcom: enable SM8350

2021-04-13 Thread Alex Elder
Add IPA-related information to "sm8350.dtsi", and enable IPA for the SM8350 MTP platform. -Alex Alex Elder (2): arm64: dts: qcom: sm8350: add IPA information arm64: dts: qcom: sm8350-mtp: enable IPA arch/arm64/boot/dts/qcom/sm8350-mt

[PATCH net-next 2/2] net: ipa: add IPA v4.9 configuration data

2021-04-13 Thread Alex Elder
Add support for the SM8350 SoC, which includes IPA version 4.9. Signed-off-by: Alex Elder --- drivers/net/ipa/Makefile| 3 +- drivers/net/ipa/ipa_data-v4.9.c | 430 drivers/net/ipa/ipa_data.h | 1 + drivers/net/ipa/ipa_main.c | 4 + 4

[PATCH net-next 1/2] dt-bindings: net: qcom,ipa: add support for SM8350

2021-04-13 Thread Alex Elder
Add support for "qcom,sm8350-ipa", which uses IPA v4.9. Use "enum" rather than "oneOf/const ..." to specify compatible strings, as suggested by Rob Herring. Signed-off-by: Alex Elder --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 11 ++- 1 fi

[PATCH net-next 0/2] net: ipa: add support for the SM8350 SoC

2021-04-13 Thread Alex Elder
files to support this SoC will be sent separately and will go through the Qualcomm tree.) -Alex Alex Elder (2): dt-bindings: net: qcom,ipa: add support for SM8350 net: ipa: add IPA v4.9 configuration data .../devicetree/bindings/net/qcom,ipa.yaml | 11

Re: [PATCH v8] RISC-V: enable XIP

2021-04-13 Thread Alex Ghiti
Le 4/13/21 à 2:35 AM, Alexandre Ghiti a écrit : From: Vitaly Wool Introduce XIP (eXecute In Place) support for RISC-V platforms. It allows code to be executed directly from non-volatile storage directly addressable by the CPU, such as QSPI NOR flash which can be found on many RISC-V platforms.

Re: [PATCH v2 2/2] drivers: gpio: add virtio-gpio guest driver

2021-04-13 Thread Alex Bennée
d the canonical source of truth for any implementation (Linux or otherwise). By all means have the distilled documentation for the driver in the kernel source tree but trying to upstream an implementation before starting the definition in the standard is a little back to front IMHO*. * that's not to say these things can't be done in parallel as the spec is reviewed and worked on and the kinks worked out but you want the final order of upstreaming to start with the spec. -- Alex Bennée

Re: Regression: gvt: vgpu 1: MI_LOAD_REGISTER_MEM handler error

2021-04-12 Thread Alex Williamson
On Mon, 12 Apr 2021 10:32:14 -0600 Alex Williamson wrote: > Running a Windows guest on a i915-GVTg_V4_2 from an HD 5500 IGD on > v5.12-rc6 results in host logs: > > gvt: vgpu 1: lrm access to register (20c0) > gvt: vgpu 1: MI_LOAD_REGISTER_MEM handler error > gvt: vgpu 1: cmd

Regression: gvt: vgpu 1: MI_LOAD_REGISTER_MEM handler error

2021-04-12 Thread Alex Williamson
works well with the same guest and userspace software stack on Fedora's kernel 5.11.11-200.fc33.x86_64. Thanks, Alex

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-12 Thread Alex Williamson
On Mon, 12 Apr 2021 19:41:41 +1000 Michael Ellerman wrote: > Alex Williamson writes: > > On Fri, 26 Mar 2021 07:13:10 +0100 > > Christoph Hellwig wrote: > > > >> This driver never had any open userspace (which for VFIO would include > >> VM kernel driv

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-12 Thread Alex Elder
On 4/12/21 2:26 AM, Leon Romanovsky wrote: On Sun, Apr 11, 2021 at 08:42:15AM -0500, Alex Elder wrote: On 4/11/21 8:28 AM, Leon Romanovsky wrote: I think *not* checking an available return value is questionable practice. I'd really rather have a build option for a "__need_not_chec

Re: [PATCH v7] RISC-V: enable XIP

2021-04-11 Thread Alex Ghiti
Le 4/9/21 à 10:42 AM, Vitaly Wool a écrit : On Fri, Apr 9, 2021 at 3:59 PM Mike Rapoport wrote: On Fri, Apr 09, 2021 at 02:46:17PM +0200, David Hildenbrand wrote: Also, will that memory properly be exposed in the resource tree as System RAM (e.g., /proc/iomem) ? Otherwise some things (/proc/k

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-11 Thread Alex Elder
eturns a value, all callers of that function ought to be checking it. If the return value is not necessary it should be a void function if possible. I don't expect the world to change, but I just think the default should be "must check" rather than "check optional". -Alex

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-11 Thread Alex Elder
On 4/11/21 1:34 AM, Leon Romanovsky wrote: > On Fri, Apr 09, 2021 at 01:07:19PM -0500, Alex Elder wrote: >> In ipa_modem_stop(), if the modem netdev pointer is non-null we call >> ipa_stop(). We check for an error and if one is returned we handle >> it. But ipa_stop() never

[PATCH net-next 4/4] net: ipa: add IPA v4.11 configuration data

2021-04-09 Thread Alex Elder
Add support for the SC7280 SoC, which includes IPA version 4.11. Signed-off-by: Alex Elder --- drivers/net/ipa/Makefile | 2 +- drivers/net/ipa/ipa_data-v4.11.c | 382 +++ drivers/net/ipa/ipa_data.h | 1 + drivers/net/ipa/ipa_main.c | 4 + 4

[PATCH net-next 2/4] net: ipa: disable checksum offload for IPA v4.5+

2021-04-09 Thread Alex Elder
m metadata supplied with messages. Currently, the RMNet driver does not support inline checksum offload. This support is imminent, but until it is available, do not allow newer versions of IPA to specify checksum offload for endpoints. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpo

[PATCH net-next 3/4] net: ipa: add IPA v4.5 configuration data

2021-04-09 Thread Alex Elder
in SDX55 versus the other two existing platforms (SDM845 and SC7180): - SDX55 uses a 32-bit Linux kernel - SDX55 has four interconnects rather than three - SDX55 uses IPA v4.5, which uses inline checksum offload Signed-off-by: Alex Elder --- drivers/net/ipa/Makefile| 3 +- drivers/n

[PATCH net-next 1/4] dt-bindings: net: qcom,ipa: add some compatible strings

2021-04-09 Thread Alex Elder
Add existing supported platform "qcom,sc7180-ipa" to the set of IPA compatible strings. Also add newly-supported "qcom,sdx55-ipa", "qcom,sc7280-ipa". Signed-off-by: Alex Elder --- Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +- 1 file change

[PATCH net-next 0/4] net: ipa: support two more platforms

2021-04-09 Thread Alex Elder
um offload used for IPA v4.5+, and once those are present this capability will be enabled for IPA. The third and fourth patches add configuration data for IPA versions 4.5 (used for the SDX55 SoC) and 4.11 (used for the SD7280 SoC). -Alex Alex Elder (4): d

[PATCH net-next 5/7] net: ipa: get rid of empty IPA functions

2021-04-09 Thread Alex Elder
removed, resulting in some code simplification. Add comments in these spots making it explicit that there is no inverse. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_main.c | 29 + drivers/net/ipa/ipa_mem.c | 9 +++-- drivers/net/ipa/ipa_mem.h | 5

[PATCH net-next 7/7] net: ipa: three small fixes

2021-04-09 Thread Alex Elder
it's only referenced inside "ipa_endpoint.c". Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_endpoint.c | 6 +++--- drivers/net/ipa/ipa_endpoint.h | 2 -- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpo

[PATCH net-next 6/7] net: ipa: get rid of empty GSI functions

2021-04-09 Thread Alex Elder
cases. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 54 +-- 1 file changed, 6 insertions(+), 48 deletions(-) diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 1c835b3e1a437..9f06663cef263 100644 --- a/drivers/net/ipa/gsi.c +++ b/driver

[PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-09 Thread Alex Elder
handling is needed at this spot. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_modem.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index 8a6ccebde2889..af9aedbde717a 100644 --- a/drivers/net/ipa

[PATCH net-next 3/7] net: ipa: only set endpoint netdev pointer when in use

2021-04-09 Thread Alex Elder
_stop() before unregistering the network device. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_modem.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ipa/ipa_modem.c b/drivers/net/ipa/ipa_modem.c index 9b08eb8239846..8a6ccebde2889 100644 --- a/dr

[PATCH net-next 2/7] net: ipa: update sequence type for modem TX endpoint

2021-04-09 Thread Alex Elder
ned-off-by: Alex Elder --- drivers/net/ipa/ipa_data-v3.5.1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ipa/ipa_data-v3.5.1.c b/drivers/net/ipa/ipa_data-v3.5.1.c index 57703e95a3f9c..ead1a82f32f5c 100644 --- a/drivers/net/ipa/ipa_data-v3.5.1.c +++ b/drivers/net/ipa/ipa_dat

[PATCH net-next 1/7] net: ipa: relax pool entry size requirement

2021-04-09 Thread Alex Elder
d-off-by: Alex Elder --- drivers/net/ipa/gsi_trans.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c index 70c2b585f98d6..8c795a6a85986 100644 --- a/drivers/net/ipa/gsi_trans.c +++ b/drivers/net/ipa/gsi_trans.c @@

[PATCH net-next 0/7] net: ipa: a few small fixes

2021-04-09 Thread Alex Elder
er warning. -Alex Alex Elder (7): net: ipa: relax pool entry size requirement net: ipa: update sequence type for modem TX endpoint net: ipa: only set endpoint netdev pointer when in use net: ipa: ipa_stop() does not return an error net: ipa: get rid of empty IPA functions

[PATCH] ARM: dts: qcom: sdx55: add IPA information

2021-04-09 Thread Alex Elder
Add IPA-related nodes and definitions to "sdx55.dtsi". The SMP2P nodes (ipa_smp2p_out and ipa_smp2p_in) are already present. Signed-off-by: Alex Elder --- Note: This depends on this series posted by Mani Sadhasivam: https://lore.kernel.org/linux-arm-msm/202104081704

[PATCH] ARM: configs: qcom_defconfig: enable IPA and RMNET

2021-04-09 Thread Alex Elder
The SDX55 is a 32-bit ARM device that includes IPA v4.5. Add CONFIG_QCOM_IPA=m and CONFIG_RMNET=m to "qcom_defconfig". Signed-off-by: Alex Elder --- arch/arm/configs/qcom_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/qcom_defconfig b/arch/a

Re: [PATCH v1 01/14] vfio: Create vfio_fs_type with inode per device

2021-04-09 Thread Alex Williamson
On Fri, 9 Apr 2021 04:54:23 + "Zengtao (B)" wrote: > > -邮件原件----- > > 发件人: Alex Williamson [mailto:alex.william...@redhat.com] > > 发送时间: 2021年3月9日 5:47 > > 收件人: alex.william...@redhat.com > > 抄送: coh...@redhat.com; k...@vger.kernel.org; > >

[PATCH] clk: qcom: rpmh: add support for SDX55 rpmh IPA clock

2021-04-09 Thread Alex Elder
The IPA core clock is required for SDX55. Define it. Signed-off-by: Alex Elder --- drivers/clk/qcom/clk-rpmh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c index c623ce9004063..552d1cbfea4c0 100644 --- a/drivers/clk/qcom/clk

Re: [PATCH v7] RISC-V: enable XIP

2021-04-09 Thread Alex Ghiti
Le 4/9/21 à 8:07 AM, David Hildenbrand a écrit : On 09.04.21 13:39, Alex Ghiti wrote: Hi David, Le 4/9/21 à 4:23 AM, David Hildenbrand a écrit : On 09.04.21 09:14, Alex Ghiti wrote: Le 4/9/21 à 2:51 AM, Alexandre Ghiti a écrit : From: Vitaly Wool Introduce XIP (eXecute In Place) support

Re: [PATCH v7] RISC-V: enable XIP

2021-04-09 Thread Alex Ghiti
Hi David, Le 4/9/21 à 4:23 AM, David Hildenbrand a écrit : On 09.04.21 09:14, Alex Ghiti wrote: Le 4/9/21 à 2:51 AM, Alexandre Ghiti a écrit : From: Vitaly Wool Introduce XIP (eXecute In Place) support for RISC-V platforms. It allows code to be executed directly from non-volatile storage

Re: [PATCH v7] RISC-V: enable XIP

2021-04-09 Thread Alex Ghiti
): the fact that we don't have any struct page to back the text and rodata in flash is the problem but to which extent ? Thanks, Alex Signed-off-by: Alexandre Ghiti [ Rebase on top of "Move kernel mapping outside the linear mapping ] Signed-off-by: Vitaly Wool --- Changes in v2: -

Re: [PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect()

2021-04-08 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Apr 7, 2021 at 2:23 AM wrote: > > From: Yingjie Wang > > In radeon_dp_mst_detect(), We should check whether or not @connector > has been unregistered from userspace. If the connector is unregistered, > we should return disconnected status. >

Re: [PATCH] drm/amd/pm: convert sysfs snprintf to sysfs_emit

2021-04-07 Thread Alex Deucher
> drivers/gpu/drm/amd/pm//amdgpu_pm.c:2965:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm/amd/pm//amdgpu_pm.c:2972:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm/amd/pm//amdgpu_pm.c:3006:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm/amd/pm//

Re: [PATCH] driver: of: Properly truncate command line if too long

2021-04-06 Thread Alex Ghiti
(int)(cmd_p - (char *)data + 1)); Do you really need that casting? No, I can use %td to print a pointer difference. I'll send a v2. Thanks, Alex +               } +       } +         /*          * CONFIG_CMDLINE is meant to be a default in case nothing else  

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-04-06 Thread Alex Deucher
ng here. Daniel your patch is not > really correct. > > The problem is rather that we don't set the tt object to bound if it > doesn't have a GTT address. > > Going to provide a patch for this. Did this patch ever land? Alex > > Regards, > Christian. > >

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-06 Thread Alex Williamson
ci_private.h | 14 - > include/uapi/linux/vfio.h | 38 +-- > 6 files changed, 4 insertions(+), 563 deletions(-) > delete mode 100644 drivers/vfio/pci/vfio_pci_nvlink2.c Hearing no objections, applied to vfio next branch for v5.13. Thanks, Alex

Re: [PATCH v1] vfio/type1: Remove the almost unused check in vfio_iommu_type1_unpin_pages

2021-04-06 Thread Alex Williamson
-unpin_exit: > mutex_unlock(&iommu->lock); > - return i > npage ? npage : (i > 0 ? i : -EINVAL); > + return i > 0 ? i : -EINVAL; > } > > static long vfio_sync_unpin(struct vfio_dma *dma, struct vfio_domain *domain, Very odd behavior previously. Applied to vfio next branch for v5.13. Thanks, Alex

Re: [PATCH 0/4] vfio: fix a couple of spelling mistakes detected by codespell tool

2021-04-06 Thread Alex Williamson
ers/vfio/pci/vfio_pci_config.c | 2 +- > drivers/vfio/pci/vfio_pci_nvlink2.c | 4 ++-- > drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 +- > drivers/vfio/vfio_iommu_type1.c | 6 +++--- > 6 files changed, 9 insertions(+), 9 deletions(-) > Applied to vfio next branch for v5.13. Thanks, Alex

Re: [PATCH] vfio: pci: Spello fix in the file vfio_pci.c

2021-04-06 Thread Alex Williamson
data used by all devices */ > + /* Allocate shared config space permission data used by all devices */ > ret = vfio_pci_init_perm_bits(); > if (ret) > return ret; > -- > 2.26.2 > Applied to vfio next branch for v5.13. Thanks, Alex

Re: [PATCH v3 2/5] RISC-V: Add kexec support

2021-04-06 Thread Alex Ghiti
Le 4/5/21 à 4:57 AM, Nick Kossifidis a écrit : This patch adds support for kexec on RISC-V. On SMP systems it depends on HOTPLUG_CPU in order to be able to bring up all harts after kexec. It also needs a recent OpenSBI version that supports the HSM extension. I tested it on riscv64 QEMU on both

Re: [PATCH v3 4/5] RISC-V: Add kdump support

2021-04-06 Thread Alex Ghiti
Hi Nick, Le 4/5/21 à 4:57 AM, Nick Kossifidis a écrit : This patch adds support for kdump, the kernel will reserve a region for the crash kernel and jump there on panic. In order for userspace tools (kexec-tools) to prepare the crash kernel kexec image, we also need to expose some information on

Re: [PATCH v6] RISC-V: enable XIP

2021-04-06 Thread Alex Ghiti
Le 4/6/21 à 3:54 AM, Vitaly Wool a écrit : On Tue, Apr 6, 2021 at 8:47 AM Alex Ghiti wrote: Hi Vitaly, Le 4/5/21 à 4:34 AM, Vitaly Wool a écrit : On Sun, Apr 4, 2021 at 10:39 AM Vitaly Wool wrote: On Sat, Apr 3, 2021 at 12:00 PM Alex Ghiti wrote: Hi Vitaly, Le 4/1/21 à 7:10 AM

Re: [PATCH] driver: of: Properly truncate command line if too long

2021-04-06 Thread Alex Ghiti
Le 4/6/21 à 9:40 AM, Rob Herring a écrit : On Sat, Apr 3, 2021 at 7:09 AM Alex Ghiti wrote: Hi, Le 3/16/21 à 3:38 PM, Alexandre Ghiti a écrit : In case the command line given by the user is too long, warn about it and truncate it to the last full argument. This is what efi already does in

Re: [PATCH] PCI: merge slot and bus reset implementations

2021-04-06 Thread Alex Williamson
On Sun, 4 Apr 2021 11:04:32 +0300 Leon Romanovsky wrote: > On Thu, Apr 01, 2021 at 10:56:16AM -0600, Alex Williamson wrote: > > On Thu, 1 Apr 2021 15:27:37 +0300 > > Leon Romanovsky wrote: > > > > > On Thu, Apr 01, 2021 at 05:37:16AM +, Raphael Norwitz wr

Re: [PATCH v6] RISC-V: enable XIP

2021-04-05 Thread Alex Ghiti
Hi Vitaly, Le 4/5/21 à 4:34 AM, Vitaly Wool a écrit : On Sun, Apr 4, 2021 at 10:39 AM Vitaly Wool wrote: On Sat, Apr 3, 2021 at 12:00 PM Alex Ghiti wrote: Hi Vitaly, Le 4/1/21 à 7:10 AM, Alex Ghiti a écrit : Le 4/1/21 à 4:52 AM, Vitaly Wool a écrit : Hi Alex, On Thu, Apr 1, 2021 at 10

Re: [PATCH] driver: of: Properly truncate command line if too long

2021-04-03 Thread Alex Ghiti
se * managed to set the command line, unless CONFIG_CMDLINE_FORCE Any thought about that ? Thanks, Alex

Re: [PATCH v6] RISC-V: enable XIP

2021-04-03 Thread Alex Ghiti
Hi Vitaly, Le 4/1/21 à 7:10 AM, Alex Ghiti a écrit : Le 4/1/21 à 4:52 AM, Vitaly Wool a écrit : Hi Alex, On Thu, Apr 1, 2021 at 10:11 AM Alex Ghiti wrote: Hi, Le 3/30/21 à 4:04 PM, Alex Ghiti a écrit : Le 3/30/21 à 3:33 PM, Palmer Dabbelt a écrit : On Tue, 30 Mar 2021 11:39:10 PDT

  1   2   3   4   5   6   7   8   9   10   >