Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-21 Thread andrey.smir...@convergeddevices.net
On 09/21/2012 12:31 AM, Hans Verkuil wrote: > On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote: >> On 09/13/2012 11:44 PM, Hans Verkuil wrote: >>> Hi Andrey! >>> >>> Thanks for posting this driver. One request for the future: pl

Re: [PATCH 1/3] Add a core driver for SI476x MFD

2012-09-20 Thread andrey.smir...@convergeddevices.net
On 09/13/2012 11:44 PM, Hans Verkuil wrote: > Hi Andrey! > > Thanks for posting this driver. One request for the future: please split this > patch up in smaller pieces: one for each c source for example. That makes it > easier to review. Will do for next version. > + > +/** > + * __core_send_comm