platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
commit message was not correct.
drivers/net/can/xilinx_can.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/n
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2:
commit message was not correct.
drivers/net/can/xilinx_can.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can
The platform_get_irq() function returns negative number if an error
occurs, Zero if No irq is found and positive number if irq gets successful.
platform_get_irq() error checking only for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes
The platform_get_irq() function returns negative number if an error
occurs, Zero if No irq is found and positive number if irq gets successful.
platform_get_irq() error checking only for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2:
commit message
The platform_get_irq() function returns negative number if an error
occurs, Zero if No irq is found and positive number if irq gets successful.
platform_get_irq() error checking only for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes
The platform_get_irq() function returns negative number if an error
occurs, Zero if No irq is found and positive number if irq gets successful.
platform_get_irq() error checking only for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2:
commit message
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
commit message was not correct.
drivers/net/ethernet/smsc/smc911x.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drive
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2:
commit message was not correct.
drivers/net/ethernet/smsc/smc911x.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smc911x.c
b
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
commit message was not correct.
drivers/net/fjes/fjes_main.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/ne
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2:
commit message was not correct.
drivers/net/fjes/fjes_main.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
commit message was not correct.
drivers/net/ethernet/natsemi/jazzsonic.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/d
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2:
commit message was not correct.
drivers/net/ethernet/natsemi/jazzsonic.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/natsemi
The platform_get_irq() function returns negative number if an error occurs,
Zero if No irq is found and positive number if irq gets successful.
platform_get_irq() error checking only for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes
The platform_get_irq() function returns negative number if an error occurs,
Zero if No irq is found and positive number if irq gets successful.
platform_get_irq() error checking only for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2:
commit message
The platform_get_irq() function returns negative number if an error
occurs, Zero if No irq is found and positive number if irq gets successful.
platform_get_irq() error checking for only zero is not correct.
Removed Other 3 patch which is not related to this series.
Arvind Yadav (7):
[PATCH 1
The platform_get_irq() function returns negative number if an error
occurs, Zero if No irq is found and positive number if irq gets successful.
platform_get_irq() error checking for only zero is not correct.
Removed Other 3 patch which is not related to this series.
Arvind Yadav (7):
[PATCH 1
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
1 file chan
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/ethernet/i825xx/sni_82596.c | 3 ++-
1 file chan
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/net/ethernet/i825xx/sni_82596.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct. And remove unnecessary check for free_netdev().
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/et
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct. And remove unnecessary check for free_netdev().
Signed-off-by: Arvind Yadav
---
drivers/net/ethernet/ezchip/nps_enet.c | 7
platform_get_irq() and platform_get_resource() can fail here and
we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/fjes/fjes_main.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/fjes/fjes_main.c b/drive
platform_get_irq() and platform_get_resource() can fail here and
we must check its return value.
Signed-off-by: Arvind Yadav
---
drivers/net/fjes/fjes_main.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index 750954b
platform_get_irq_byname() can fail here and we must check its return
value
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/ethernet/ti/cpmac.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
platform_get_irq_byname() can fail here and we must check its return
value
Signed-off-by: Arvind Yadav
---
drivers/net/ethernet/ti/cpmac.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
index 9b8a30b..f3acfc0 100644
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/ethernet/smsc/smc911x.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smc911x.c
b/drivers/net/ethernet/smsc/smc
platform_get_irq_byname() can fail here and we must check its return
value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/ethernet/korina.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
drivers/net/ethernet/smsc/smc911x.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/smsc/smc911x.c
b/drivers/net/ethernet/smsc/smc911x.c
index 0515744..a1cf18c
platform_get_irq_byname() can fail here and we must check its return
value.
Signed-off-by: Arvind Yadav
---
drivers/net/ethernet/korina.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c
index ae195f8..e778504 100644
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/ethernet/natsemi/jazzsonic.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c
b/drivers/net/et
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
drivers/net/ethernet/natsemi/jazzsonic.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/natsemi/jazzsonic.c
b/drivers/net/ethernet/natsemi/jazzsonic.c
index
The change is to call free_netdev(), If of_match_node() will fail.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmg
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/net/can/xilinx_can.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
index 89aec07..e
()
Arvind Yadav (10):
[PATCH 01/10] net: bcmgenet: Fix platform_get_irq's error checking
[PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error
[PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking
[PATCH 04/10] can: xilinx: Handle return value
The change is to call free_netdev(), If of_match_node() will fail.
Signed-off-by: Arvind Yadav
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
b/drivers/net/ethernet
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
drivers/net/can/xilinx_can.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
index 89aec07..e36e2a2 100644
--- a/drivers/net
()
Arvind Yadav (10):
[PATCH 01/10] net: bcmgenet: Fix platform_get_irq's error checking
[PATCH 02/10] net: bcmgenet: free netdev on of_match_node() error
[PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking
[PATCH 04/10] can: xilinx: Handle return value
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
It's should be 'irq <= 0' instead of
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2:
It's should be 'irq <= 0' instead of 'irq < 0'.
drivers/gpi
Here, variable 'err' is already initialised. So no need to reinitialize.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/staging/irda/drivers/pxaficp_ir.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c
b/drivers/stagin
Here, variable 'err' is already initialised. So no need to reinitialize.
Signed-off-by: Arvind Yadav
---
drivers/staging/irda/drivers/pxaficp_ir.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c
b/drivers/staging/irda/drivers/pxaficp_ir.c
index
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Remove unnecessary 'err' initialization for irda driver.
Arvind Yadav (3):
[PATCH 1/3] iio: trigger: Fix platform_get_irq's error
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 4 ++--
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Remove unnecessary 'err' initialization for irda driver.
Arvind Yadav (3):
[PATCH 1/3] iio: trigger: Fix platform_get_irq's error
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 4 ++--
1 file changed, 2 insertions(+), 2
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c
b/drivers/s
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
drivers/staging/irda/drivers/pxaficp_ir.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c
b/drivers/staging/irda/drivers/pxaficp_ir.c
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/gpio/gpio-ftgpio010.c | 4 ++--
1 file changed, 2 inse
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/gpio/gpio-ftgpio010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
irq was unsigned. so using signed va
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
irq was unsigned. so using signed variable ret.
changes in v3
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
Return -ENODEV insted of irq.
c
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
Return -ENODEV insted of irq.
changes in v4 :
Add se
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
Return -EIO insted of ctx->i
platform_get_irq() can fail here and we must check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
changes in v3 :
Return -EIO insted of ctx->irq_num.
changes in v4 :
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
irq was unsigned. so changed it to
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
irq was unsigned. so changed it to signed.
changes in v3
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
irq was unsigned. so changed it to
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav
---
changes in v2 :
irq was unsigned. so changed it to signed.
changes in v3
Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
subject was incorrect. subsystem/driver was wrong.
drivers/misc/enclosure.c | 4 ++--
1 file changed, 2 insertions
Fix checkpatch.pl error:
ERROR: space prohibited before open square bracket '['.
Signed-off-by: Arvind Yadav
---
changes in v2:
subject was incorrect. subsystem/driver was wrong.
drivers/misc/enclosure.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
It is not necessary to check return value of class_register.
enclosure_init returns both successful and error value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
subject was incorrect. subsystem/driver was wrong.
drivers/misc/enclosure
It is not necessary to check return value of class_register.
enclosure_init returns both successful and error value.
Signed-off-by: Arvind Yadav
---
changes in v2:
subject was incorrect. subsystem/driver was wrong.
drivers/misc/enclosure.c | 8 +---
1 file changed, 1 insertion
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2:
Rese
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav
---
changes in v2:
Resend all changes as single patch
Hi Rafael,
On Wednesday 29 November 2017 02:28 AM, Rafael J. Wysocki wrote:
On Tue, Nov 28, 2017 at 11:01 AM, Arvind Yadav
<arvind.yadav...@gmail.com> wrote:
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with
Hi Rafael,
On Wednesday 29 November 2017 02:28 AM, Rafael J. Wysocki wrote:
On Tue, Nov 28, 2017 at 11:01 AM, Arvind Yadav
wrote:
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/i2c/busses/i2c-cht-wc.c | 2
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav
---
drivers/i2c/busses/i2c-cht-wc.c | 2 +-
1 file changed, 1 insertion
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/acpi/pmic/intel_pmic_bxtwc
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav
---
drivers/acpi/pmic/intel_pmic_bxtwc.c | 2 +-
1 file changed, 1
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Arvind Yadav (2):
[PATCH 1/2] ACPI / PMIC: constify platform_device_id
[PATCH 2/2] ACPI / PMIC
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/acpi/pmic/intel_pmic_chtwc
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Arvind Yadav (2):
[PATCH 1/2] ACPI / PMIC: constify platform_device_id
[PATCH 2/2] ACPI / PMIC
platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by
work with const platform_device_id. So mark the non-const structs as
const.
Signed-off-by: Arvind Yadav
---
drivers/acpi/pmic/intel_pmic_chtwc.c | 2 +-
1 file changed, 1
Hi,
On Monday 27 November 2017 03:01 PM, Ulf Hansson wrote:
On 17 November 2017 at 17:35, Arvind Yadav <arvind.yadav...@gmail.com> wrote:
platform_get_irq_byname() can fail here and we must check its return value.
NAK.
You need to check the code more carefully. irq_cd is dealt with
Hi,
On Monday 27 November 2017 03:01 PM, Ulf Hansson wrote:
On 17 November 2017 at 17:35, Arvind Yadav wrote:
platform_get_irq_byname() can fail here and we must check its return value.
NAK.
You need to check the code more carefully. irq_cd is dealt with later
below in the same function
Make these pdc2027x_*_timing structures const as it is never modified.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/ata/pata_pdc2027x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
Make these pdc2027x_*_timing structures const as it is never modified.
Signed-off-by: Arvind Yadav
---
drivers/ata/pata_pdc2027x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c
index d1e8b63..141bf81 100644
board_idx? PDC_133_MHZ:PDC_100_MHZ;
ERROR: that open brace { should be on the previous line
+ const struct ata_port_info *ppi[] =
+ { _port_info[board_idx], NULL };
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v1:
These cheange was a part of '[PATC
board_idx? PDC_133_MHZ:PDC_100_MHZ;
ERROR: that open brace { should be on the previous line
+ const struct ata_port_info *ppi[] =
+ { _port_info[board_idx], NULL };
Signed-off-by: Arvind Yadav
---
changes in v1:
These cheange was a part of '[PATCH] pata_pdc2027x:
Here, The function pdc_hardware_init always return zero. So it is not
necessary to check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
changes in v2 :
Make function return type 'void' instead of 'int.
Add sapce between ':'.
c
Here, The function pdc_hardware_init always return zero. So it is not
necessary to check its return value.
Signed-off-by: Arvind Yadav
---
changes in v2 :
Make function return type 'void' instead of 'int.
Add sapce between ':'.
changes in v3 :
Fix
All attribute group created during sys_init_dir() should be removed
in sys_free_dir()
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/staging/ccree/ssi_sysfs.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_sysfs.c
b/d
All attribute group created during sys_init_dir() should be removed
in sys_free_dir()
Signed-off-by: Arvind Yadav
---
drivers/staging/ccree/ssi_sysfs.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_sysfs.c
b/drivers/staging/ccree/ssi_sysfs.c
All attribute group created during ldlm_setup() should be removed
in ldlm_cleanup().
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/
All attribute group created during ldlm_setup() should be removed
in ldlm_cleanup().
Signed-off-by: Arvind Yadav
---
drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c
b/drivers
All attribute group created during dim2_sysfs_probe() should be removed
in dim2_sysfs_destroy().
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/staging/most/hdm-dim2/dim2_sysfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/hdm-dim2/dim2_s
All attribute group created during dim2_sysfs_probe() should be removed
in dim2_sysfs_destroy().
Signed-off-by: Arvind Yadav
---
drivers/staging/most/hdm-dim2/dim2_sysfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/most/hdm-dim2/dim2_sysfs.c
b/drivers/staging/most/hdm
Arvind Yadav (4):
[PATCH 1/4] staging: ccree: Remove a attribute group from a kobject
[PATCH 2/4] staging: lustre: ldlm: Remove a attribute group from a kobject
[PATCH 3/4] staging: lustre: obdclass: Remove a attribute group from a kobject
[PATCH 4/4] staging: most: Remove a attribute
All attribute group created during class_procfs_init() should be
removed.
if class_procfs_init() will fail and also in class_procfs_clean().
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +++
1 file chan
Arvind Yadav (4):
[PATCH 1/4] staging: ccree: Remove a attribute group from a kobject
[PATCH 2/4] staging: lustre: ldlm: Remove a attribute group from a kobject
[PATCH 3/4] staging: lustre: obdclass: Remove a attribute group from a kobject
[PATCH 4/4] staging: most: Remove a attribute
All attribute group created during class_procfs_init() should be
removed.
if class_procfs_init() will fail and also in class_procfs_clean().
Signed-off-by: Arvind Yadav
---
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers
OR: spaces required around that '?' (ctx:VxW)
+ long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
ERROR: that open brace { should be on the previous line
+ const struct ata_port_info *ppi[] =
+ { _port_info[board_idx], NULL };
Signed-off-by: Arvind Yadav <arvind.yadav
OR: spaces required around that '?' (ctx:VxW)
+ long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
ERROR: that open brace { should be on the previous line
+ const struct ata_port_info *ppi[] =
+ { _port_info[board_idx], NULL };
Signed-off-by: Arvind Yadav
---
cha
' (ctx:VxW)
+ long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
ERROR: that open brace { should be on the previous line
+ const struct ata_port_info *ppi[] =
+ { _port_info[board_idx], NULL };
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/ata
' (ctx:VxW)
+ long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
ERROR: that open brace { should be on the previous line
+ const struct ata_port_info *ppi[] =
+ { _port_info[board_idx], NULL };
Signed-off-by: Arvind Yadav
---
drivers/ata/pata_pdc2027x.c | 14 ++-
The platform_get_irq_byname() function returns -1 if an error occurs.
zero or positive number on success. platform_get_irq_byname() error
checking for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
drivers/power/supply/cpcap-battery.c | 4 ++--
1 file chan
The platform_get_irq_byname() function returns -1 if an error occurs.
zero or positive number on success. platform_get_irq_byname() error
checking for zero is not correct.
Signed-off-by: Arvind Yadav
---
drivers/power/supply/cpcap-battery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
201 - 300 of 3336 matches
Mail list logo
