RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-26 Thread bpqw
>First of all, can you fix your mail so that you have a proper 'From'? >That should be your real name (not bpqw), so that it gives a proper patch >author. >If you can't get your mail header to have the right 'From:' line, then it also >works to begin your mail with: Sorry for

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-26 Thread bpqw
>You probably aren't based on l2-mtd.git. Your patch still doesn't build. >I can fix it up if it's easy, but FYI. Still reviewing... >Brian Hi, Brian Thanks for your hard work. Finally received your response, I am very happy. How about this patch? Whether or not rebuild it based on lastest

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-26 Thread bpqw
You probably aren't based on l2-mtd.git. Your patch still doesn't build. I can fix it up if it's easy, but FYI. Still reviewing... Brian Hi, Brian Thanks for your hard work. Finally received your response, I am very happy. How about this patch? Whether or not rebuild it based on lastest l2-mtd?

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-26 Thread bpqw
First of all, can you fix your mail so that you have a proper 'From'? That should be your real name (not bpqw), so that it gives a proper patch author. If you can't get your mail header to have the right 'From:' line, then it also works to begin your mail with: Sorry for this confusion

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-13 Thread bpqw
>> This maybe your spi controller is still extended mode, Once EVCR bit 7 >> is set to 0, the spi nor device will operate in quad >> I/O.Command-address-data line is 4-x-4. >> So after send WRITE EVCR command , spi controller also must transfer >> to quad I/O Mode,and set its

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-13 Thread bpqw
This maybe your spi controller is still extended mode, Once EVCR bit 7 is set to 0, the spi nor device will operate in quad I/O.Command-address-data line is 4-x-4. So after send WRITE EVCR command , spi controller also must transfer to quad I/O Mode,and set its Command-address-data line

[V3 PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-12 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology,Inc.is an American multinational corporation based in Boise, Idaho,best known for producing many forms of semiconductor devices.This includes DRAM,SDRAM,flash memory,eMMC and SSDs.

RE: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-12 Thread bpqw
>Patch looks okay to me content-wise, but you might want to use proper names >and >capitalization for the From: and Signed-off-by: lines. bpqw doesn't look like >a real name to me, and "bean huo" should probably be "Bean Huo". >Thierry Thanks,will modify

RE: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-12 Thread bpqw
Patch looks okay to me content-wise, but you might want to use proper names and capitalization for the From: and Signed-off-by: lines. bpqw doesn't look like a real name to me, and bean huo should probably be Bean Huo. Thierry Thanks,will modify it and submit V3. -- To unsubscribe from

[V3 PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-12 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology,Inc.is an American multinational corporation based in Boise, Idaho,best known for producing many forms of semiconductor devices.This includes DRAM,SDRAM,flash memory,eMMC and SSDs.

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-11 Thread bpqw
>I have almost verified all the micros parts for operating quad mode and the >quad enable bit is >volatile by default and no need to set it on software. >Why this code is meant for - does micron has changed this bit operation on >newly added parts? >thanks! >-- >Jagan. For Micron Spi

RE: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-11 Thread bpqw
>Signed-off-by: bean huo >Signed-off-by: bpqw >--- >V2: > - Add signed-off-by > - Modify commit logs that wrapped to less than 80 columns Dear maintainers: Please give some tips,if this patch is OK?thanks! -- To unsubscribe from this list: send the line "unsubscribe li

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-11 Thread bpqw
>Hi, I'm having trouble with this patch using a Cadence QSPI controller and >Micron n25q00 part. >I can use quad commands in Extended SPI mode, but I can't make this EVCR Quad >mode work. Yes,but if you use quad commands in Extended spi mode,only for Quad commands,the command line is DQ0,

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-11 Thread bpqw
Hi, I'm having trouble with this patch using a Cadence QSPI controller and Micron n25q00 part. I can use quad commands in Extended SPI mode, but I can't make this EVCR Quad mode work. Yes,but if you use quad commands in Extended spi mode,only for Quad commands,the command line is DQ0,

RE: [PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-11 Thread bpqw
Signed-off-by: bean huo bean...@micron.com Signed-off-by: bpqw b...@micron.com --- V2: - Add signed-off-by - Modify commit logs that wrapped to less than 80 columns Dear maintainers: Please give some tips,if this patch is OK?thanks! -- To unsubscribe from this list: send the line unsubscribe

RE: [V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-11 Thread bpqw
I have almost verified all the micros parts for operating quad mode and the quad enable bit is volatile by default and no need to set it on software. Why this code is meant for - does micron has changed this bit operation on newly added parts? thanks! -- Jagan. For Micron Spi norflash,if you

[V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-05 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash,enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0,the SPI NOR flash will operate in

RE: [PATCH 1/1 v4] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-05 Thread bpqw
>> This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. >Also, your patch is still corrupt and cannot be applied as-is. >Please double-check your mailer settings and resend once you have something I >can apply. >Brian Hi,Brian Thanks your patience.this maybe linux

RE: [PATCH 1/1 v4] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-05 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. Also, your patch is still corrupt and cannot be applied as-is. Please double-check your mailer settings and resend once you have something I can apply. Brian Hi,Brian Thanks your patience.this maybe linux kernel has

[V5 PATCH 1/1] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-05 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash,enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0,the SPI NOR flash will operate in

[PATCH 1/1 v4] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-04 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash,enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0,the SPI NOR flash will operate in

[PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-04 Thread bpqw
. Signed-off-by: bean huo Signed-off-by: bpqw --- V2: - Add signed-off-by - Modify commit logs that wrapped to less than 80 columns .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt

[PATCH 1/1 V2] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-04 Thread bpqw
. Signed-off-by: bean huo bean...@micron.com Signed-off-by: bpqw b...@micron.com --- V2: - Add signed-off-by - Modify commit logs that wrapped to less than 80 columns .../devicetree/bindings/vendor-prefixes.txt|1 + 1 file changed, 1 insertion(+) diff --git a/Documentation

[PATCH 1/1 v4] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-11-04 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash,enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0,the SPI NOR flash will operate in

RE: [PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-03 Thread bpqw
>This patch is used to add vendor prefix for >Micron Technology Inc in the vendor-prefixes.txt file. >Micron Technology, Inc. is an American >multinational corporation based in Boise, >Idaho, best known for producing many forms >of semiconductor devices. This includes DRAM, >SDRAM, flash

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-03 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory,

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-03 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory,

RE: [PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-11-03 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory, eMMC

RE: [PATCH 1/1 v3] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-10-30 Thread bpqw
>This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. >For Micron SPI NOR flash, enabling or disabling quad I/O >protocol is controlled by EVCR (Enhanced Volatile Configuration >Register), Quad I/O protocol bit 7.When EVCR bit 7 is reset to 0, >the SPI NOR flash will

RE: [PATCH 1/1 v3] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-10-30 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash, enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7.When EVCR bit 7 is reset to 0, the SPI NOR flash will operate in

RE: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-27 Thread bpqw
Hi,rafal Maybe this patch is not very reasonable.But for fix this case,I will develop a new patch that is just used to add extended ID for micron spi nor in the spi_nor_ids[]. Thanks for your review my patch.

RE: [PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-27 Thread bpqw
Hi,Mark >This is the *third* time you've sent this patch this week, please stop and >allow a reasonable time for the maintainers to respond, a few weeks would be >normal. I'm sorry,I'm new linux patch deveploper and this is my second patch. Maybe my experience is not rich,there is a little

RE: [PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-27 Thread bpqw
Hi,Mark This is the *third* time you've sent this patch this week, please stop and allow a reasonable time for the maintainers to respond, a few weeks would be normal. I'm sorry,I'm new linux patch deveploper and this is my second patch. Maybe my experience is not rich,there is a little

RE: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-27 Thread bpqw
Hi,rafal Maybe this patch is not very reasonable.But for fix this case,I will develop a new patch that is just used to add extended ID for micron spi nor in the spi_nor_ids[]. Thanks for your review my patch.

[PATCH 1/1 v3] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-10-26 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash, enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0, the SPI NOR flash will operate in

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-26 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory, eMMC

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-26 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory, eMMC

[PATCH 1/1 v3] driver:mtd:spi-nor: Add quad I/O support for Micron spi nor

2014-10-26 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash, enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0, the SPI NOR flash will operate in

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-23 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory,

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-23 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory,

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-23 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory,

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-23 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory,

RE: [PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-22 Thread bpqw
>This patch is used to add vendor prefix for Micron Technology Inc in the >vendor-prefixes.txt file. >Micron Technology, Inc. is an American multinational corporation based in >Boise, Idaho, best known for producing many forms of semiconductor devices. >This includes DRAM, SDRAM, flash memory,

RE: [PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-22 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory, eMMC

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-21 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory, eMMC

[PATCH 1/1] devicetree: bindings: Add vendor prefix for Micron Technology Co., Ltd.

2014-10-21 Thread bpqw
This patch is used to add vendor prefix for Micron Technology Inc in the vendor-prefixes.txt file. Micron Technology, Inc. is an American multinational corporation based in Boise, Idaho, best known for producing many forms of semiconductor devices. This includes DRAM, SDRAM, flash memory, eMMC

[PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-10-19 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash, enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0, the SPI NOR flash will operate

[PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-10-19 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash, enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0, the SPI NOR flash will operate

RE: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-16 Thread bpqw
>I really wasn't looking into details yet and I'm aware my patch does something >else. I just say we should first fix the regression and then base next patches >on top of that regression fix. I'm not NACKing your changes :) I will take into account for your patch,and will cover all these isse

RE: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-16 Thread bpqw
I really wasn't looking into details yet and I'm aware my patch does something else. I just say we should first fix the regression and then base next patches on top of that regression fix. I'm not NACKing your changes :) I will take into account for your patch,and will cover all these isse in

RE: [PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-10-15 Thread bpqw
>Acked-by: Marek Vasut Hi,brian How about this patch? And can be accepted by linux-mtd? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

RE: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-15 Thread bpqw
>Won't $info contain an undefined value in case the newly added condition isn't >met ? The old code initialized $info to a certain value always, the new code >does not do that. Hi,Marek Vasut Thanks.the $info has been defined before as below: info = (void *)id->driver_data; Unless id has

RE: [PATCH 1/1 v2] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-15 Thread bpqw
Won't $info contain an undefined value in case the newly added condition isn't met ? The old code initialized $info to a certain value always, the new code does not do that. Hi,Marek Vasut Thanks.the $info has been defined before as below: info = (void *)id-driver_data; Unless id has not

RE: [PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-10-15 Thread bpqw
Acked-by: Marek Vasut ma...@denx.de Hi,brian How about this patch? And can be accepted by linux-mtd? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-12 Thread bpqw
This patch used to modify the method of spi_nor_scan overwrite platform Id. If type of platform data match with the name of spi_nor_ids set, and JEDEC ID also match with INFO ID of spi_nor_ids set,spi device ID point(this is before probed according to device name) shouldn't be

[PATCH 1/1] driver:mtd:spi-nor:fix spi_nor_scan overwrite platform ID point

2014-10-12 Thread bpqw
This patch used to modify the method of spi_nor_scan overwrite platform Id. If type of platform data match with the name of spi_nor_ids set, and JEDEC ID also match with INFO ID of spi_nor_ids set,spi device ID point(this is before probed according to device name) shouldn't be

RE: [PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-10-03 Thread bpqw
>> Signed-off-by: bean huo >I don't see anything obviously wrong. >Acked-by: Marek Vasut Hi,Brian How do you think about this patch? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-10-03 Thread bpqw
Signed-off-by: bean huo bean...@micron.com I don't see anything obviously wrong. Acked-by: Marek Vasut ma...@denx.de Hi,Brian How do you think about this patch? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

[PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-10-01 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash, enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0, the SPI NOR flash will operate

[PATCH 1/1 v3] driver:mtd:spi-nor: Add Micron quad I/O support

2014-10-01 Thread bpqw
This patch adds code which enables Quad I/O mode on Micron SPI NOR flashes. For Micron SPI NOR flash, enabling or disabling quad I/O protocol is controlled by EVCR (Enhanced Volatile Configuration Register), Quad I/O protocol bit 7. When EVCR bit 7 is reset to 0, the SPI NOR flash will operate

RE: [PATCH 1/1 v2] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-28 Thread bpqw
>> For Micron spi norflash,you can enable Quad spi transfer by clear >> EVCR(Enhanced Volatile Configuration Register) Quad I/O protocol bit. > >OK, this information is nice and all, but what does this patch do? I can't >learn this information from the commit message as it is, can I ? >And ,

RE: [PATCH 1/1 v2] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-28 Thread bpqw
For Micron spi norflash,you can enable Quad spi transfer by clear EVCR(Enhanced Volatile Configuration Register) Quad I/O protocol bit. OK, this information is nice and all, but what does this patch do? I can't learn this information from the commit message as it is, can I ? And , the

[PATCH 1/1 v2] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-27 Thread bpqw
For Micron spi norflash,you can enable Quad spi transfer by clear EVCR(Enhanced Volatile Configuration Register) Quad I/O protocol bit. Signed-off-by: bean huo --- v1-v2:modified to that capture wait_till_ready() return value,if error,directly return its the value.

[PATCH 1/1 v2] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-27 Thread bpqw
For Micron spi norflash,you can enable Quad spi transfer by clear EVCR(Enhanced Volatile Configuration Register) Quad I/O protocol bit. Signed-off-by: bean huo bean...@micron.com --- v1-v2:modified to that capture wait_till_ready() return value,if error,directly return its the

RE: [PATCH 1/1] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-26 Thread bpqw
>> +/* set EVCR ,enable quad I/O */ >> +nor->cmd_buf[0] = val & ~EVCR_QUAD_EN_MICRON; >> +ret = nor->write_reg(nor, SPINOR_OP_WD_EVCR, nor->cmd_buf, 1, 0); >> +if (ret < 0) { >> +dev_err(nor->dev, >> +"error while writing EVCR register\n"); >> +

RE: [PATCH 1/1] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-26 Thread bpqw
+/* set EVCR ,enable quad I/O */ +nor-cmd_buf[0] = val ~EVCR_QUAD_EN_MICRON; +ret = nor-write_reg(nor, SPINOR_OP_WD_EVCR, nor-cmd_buf, 1, 0); +if (ret 0) { +dev_err(nor-dev, +error while writing EVCR register\n); +return -EINVAL;

[PATCH 1/1] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-25 Thread bpqw
For Micron spi norflash,you can enable Quad spi transfer by clear EVCR(Enhanced Volatile Configuration Register) Quad I/O protocol bit. Signed-off-by: bean huo --- drivers/mtd/spi-nor/spi-nor.c | 45 + include/linux/mtd/spi-nor.h |6 ++ 2

[PATCH 1/1] driver:mtd:spi-nor: Add Micron quad I/O support

2014-09-25 Thread bpqw
For Micron spi norflash,you can enable Quad spi transfer by clear EVCR(Enhanced Volatile Configuration Register) Quad I/O protocol bit. Signed-off-by: bean huo bean...@micron.com --- drivers/mtd/spi-nor/spi-nor.c | 45 + include/linux/mtd/spi-nor.h |

[PATCH 1/1] mtd: cfi_cmdset_0002:add fixup for Micron M29EW after erase operation

2014-08-31 Thread bpqw
For Micron M29EW,20ms delay is needed after erase operation. Signed-off-by: BeanHuo --- drivers/mtd/chips/cfi_cmdset_0002.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 5a4bfe3..9b0de91 100644

[PATCH 1/1] mtd: cfi_cmdset_0002:add fixup for Micron M29EW after erase operation

2014-08-31 Thread bpqw
For Micron M29EW,20ms delay is needed after erase operation. Signed-off-by: BeanHuo b...@micron.com --- drivers/mtd/chips/cfi_cmdset_0002.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-08-04 Thread bpqw
nal Message- From: Brian Norris [mailto:computersforpe...@gmail.com] Sent: Tuesday, August 05, 2014 6:48 AM To: bpqw Cc: dw...@infradead.org; b32...@freescale.com; artem.bityuts...@linux.intel.com; r...@debian.org; u.kleine-koe...@pengutronix.de; ezequiel.gar...@free-electrons.com; linux-..

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-08-04 Thread bpqw
- From: Brian Norris [mailto:computersforpe...@gmail.com] Sent: Tuesday, August 05, 2014 6:48 AM To: bpqw Cc: dw...@infradead.org; b32...@freescale.com; artem.bityuts...@linux.intel.com; r...@debian.org; u.kleine-koe...@pengutronix.de; ezequiel.gar...@free-electrons.com; linux

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-08-03 Thread bpqw
Hi Brain, How about my patch? Do you have any other doubts? Br White Ding -Original Message- From: bpqw Sent: Monday, July 28, 2014 3:47 PM To: Brian Norris; bpqw Cc: dw...@infradead.org; b32...@freescale.com; artem.bityuts...@linux.intel.com; r...@debian.org; u.kleine-koe

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-08-03 Thread bpqw
Hi Brain, How about my patch? Do you have any other doubts? Br White Ding -Original Message- From: bpqw Sent: Monday, July 28, 2014 3:47 PM To: Brian Norris; bpqw Cc: dw...@infradead.org; b32...@freescale.com; artem.bityuts...@linux.intel.com; r...@debian.org; u.kleine-koe

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-07-30 Thread bpqw
Hi Brain, How about my patch do you have any other proposal? Br White Ding EBU APAC Application Engineering Tel:86-21-38997078 Mobile: 86-13761729112 Address: No 601 Fasai Rd, Waigaoqiao Free Trade Zone Pudong, Shanghai, China -Original Message- From: bpqw

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-07-30 Thread bpqw
Hi Brain, How about my patch do you have any other proposal? Br White Ding EBU APAC Application Engineering Tel:86-21-38997078 Mobile: 86-13761729112 Address: No 601 Fasai Rd, Waigaoqiao Free Trade Zone Pudong, Shanghai, China -Original Message- From: bpqw

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-07-28 Thread bpqw
on to a locked block. Br White Ding EBU APAC Application Engineering Tel:86-21-38997078 Mobile: 86-13761729112 Address: No 601 Fasai Rd, Waigaoqiao Free Trade Zone Pudong, Shanghai, China -Original Message- From: Brian Norris [mailto:computers

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-07-28 Thread bpqw
APAC Application Engineering Tel:86-21-38997078 Mobile: 86-13761729112 Address: No 601 Fasai Rd, Waigaoqiao Free Trade Zone Pudong, Shanghai, China -Original Message- From: Brian Norris [mailto:computersforpe...@gmail.com] Sent: Monday, July 28, 2014 2:10 PM To: bpqw Cc: dw

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-07-24 Thread bpqw
>OK, I won't drop them yet. >As you note, there's no user-space support. There's actually no one using them >even in the kernel, which is why I considered dropping them. >If you want to use them, find a proper way to use them then! (I'm not >sure: do they match with mtd_lock() / ioctl(MEMLOCK)

RE: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-07-24 Thread bpqw
OK, I won't drop them yet. As you note, there's no user-space support. There's actually no one using them even in the kernel, which is why I considered dropping them. If you want to use them, find a proper way to use them then! (I'm not sure: do they match with mtd_lock() / ioctl(MEMLOCK)

Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-07-23 Thread bpqw
Do nand reset before write protect check If we want to check the WP# low or high through STATUS READ and check bit 7, we must reset the device, other operation (eg.erase/program a locked block) can also clear the bit 7 of status register. Signed-off-by: White Ding ---

Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function

2014-07-23 Thread bpqw
Do nand reset before write protect check If we want to check the WP# low or high through STATUS READ and check bit 7, we must reset the device, other operation (eg.erase/program a locked block) can also clear the bit 7 of status register. Signed-off-by: White Ding b...@micron.com ---