Re: [PATCH v2 4/6] virtiofs: support bounce buffer backed by scattered pages

2024-03-13 Thread Brian Foster
On Sat, Mar 09, 2024 at 12:14:23PM +0800, Hou Tao wrote: > Hi, > > On 2/29/2024 11:01 PM, Brian Foster wrote: > > On Wed, Feb 28, 2024 at 10:41:24PM +0800, Hou Tao wrote: > >> From: Hou Tao > >> > >> When reading a file kept in virtiofs from

Re: [PATCH v2 4/6] virtiofs: support bounce buffer backed by scattered pages

2024-02-29 Thread Brian Foster
very copy/call. It looks like offset is already incremented in the callers of the argbuf copy helpers. Perhaps iov_iter could be lifted into the callers and passed down, or even just include it in the argbuf structure and init it at alloc time? Brian > + > + copied = _copy_to_iter

RE: [PATCH v3 4/5] arch,locking/atomic: hexagon: add arch_cmpxchg[64]_local

2023-11-22 Thread Brian Cain
> -Original Message- > From: wuqiang.matt > Sent: Tuesday, November 21, 2023 8:24 AM > To: ubiz...@gmail.com; mark.rutl...@arm.com; vgu...@kernel.org; Brian > Cain ; jo...@southpole.se; > stefan.kristians...@saunalahti.fi; sho...@gmail.com; ch...@zankel.net; > j

Re: [PATCH 1/2] dt-bindings: mwifiex: document use with the SD8777 chipset

2023-11-02 Thread Brian Norris
On Sun, Oct 29, 2023 at 12:08:16PM +0100, Karel Balej wrote: > Document the corresponding compatible string for the use of this driver > with the Marvell SD8777 wireless chipset. > > Signed-off-by: Karel Balej FWIW, the binding looks fine from mwifiex point of view, so: Acked-by:

Re: [PATCH 0/2] net: mwifiex: add support for the SD8777 chipset

2023-11-02 Thread Brian Norris
On Sun, Oct 29, 2023 at 12:08:15PM +0100, Karel Balej wrote: > The driver requires proprietary firmware which is not yet part of > linux-firmware, but it is packaged in postmarketOS. You gotta get that done:

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-14 Thread Brian Foster
On Wed, Sep 14, 2022 at 05:38:02PM +0800, Yang, Xiao/杨 晓 wrote: > On 2022/9/14 14:44, Yang, Xiao/杨 晓 wrote: > > On 2022/9/9 21:01, Brian Foster wrote: > > > Yes.. I don't recall all the internals of the tools and test, but IIRC > > > it relied on discard to perform

Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition

2022-09-09 Thread Brian Foster
fc5870da485aec0f9196a0f2bed32f73f6b2c664 # generic/470: use thin-pool > > > > > > So, this case was never able to run since the second commit? (I didn't > > > notice the not run case. I thought it was expected to be not run.) > > > > > > And according

Re: [PATCH bpf-next v4 0/3] add batched ops for percpu array

2021-04-19 Thread Brian Vazquez
Sorry I missed this. I don't recall why I didn't add the array percpu variant, but LGTM. Acked-by: Brian Vazquez On Fri, Apr 16, 2021 at 3:09 PM Martin KaFai Lau wrote: > > On Thu, Apr 15, 2021 at 02:46:16PM -0300, Pedro Tammela wrote: > > This patchset introduces batche

Re: [PATCH] wireless/marvell/mwifiex: Fix a double free in mwifiex_send_tdls_action_frame

2021-04-13 Thread Brian Norris
_code, > > dialog_token, status_code, > > skb)) { > > - dev_kfree_skb_any(skb); Good catch, and this looks correct for most cases, but I'll note that you missed one issue: mwifiex_cons

Re: [PATCH] xfs: fix return of uninitialized value in variable error

2021-04-09 Thread Brian Foster
gt; retval = xfs_attr_node_hasname(args, ); > if (retval != -ENOATTR && retval != -EEXIST) > goto out; I think it would be nicer to initialize at the top of the function as opposed to try and "preserve" historical behavior, but that nit aside: Reviewed-by: Brian Foster > -- > 2.30.2 >

Re: [PATCH] mremap.2: MREMAP_DONTUNMAP to reflect to supported mappings

2021-03-26 Thread Brian Geffon
Hi Alex, It has not landed yet, it's currently in Andrew's mm tree. I can reach out again when it makes it into Linus' tree. Brian On Thu, Mar 25, 2021 at 2:34 PM Alejandro Colomar (man-pages) wrote: > > Hello Brian, > > Is this already merged in Linux? I guess not, as I've

[PATCH] mremap.2: MREMAP_DONTUNMAP to reflect to supported mappings

2021-03-23 Thread Brian Geffon
mremap(2) now supports MREMAP_DONTUNMAP with mapping types other than private anonymous. Signed-off-by: Brian Geffon --- man2/mremap.2 | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/man2/mremap.2 b/man2/mremap.2 index 3ed0c0c0a..72acbc111 100644 --- a/man2

[PATCH v5 3/3] selftests: Add a MREMAP_DONTUNMAP selftest for shmem

2021-03-23 Thread Brian Geffon
This test extends the current mremap tests to validate that the MREMAP_DONTUNMAP operation can be performed on shmem mappings. Signed-off-by: Brian Geffon --- tools/testing/selftests/vm/mremap_dontunmap.c | 52 +++ 1 file changed, 52 insertions(+) diff --git a/tools/testing

[PATCH v5 2/3] Revert "mremap: don't allow MREMAP_DONTUNMAP on special_mappings and aio"

2021-03-23 Thread Brian Geffon
nce expanded support of MREMAP_DONTUNMAP to non-anonymous mappings, and these special mappings are still protected by the existing check of !VM_DONTEXPAND and !VM_PFNMAP which will result in a -EINVAL. 1. https://lkml.org/lkml/2020/12/28/2340 Signed-off-by: Brian Geffon Acked-by: Hugh Dickins --- arch/

[PATCH v5 1/3] mm: Extend MREMAP_DONTUNMAP to non-anonymous mappings

2021-03-23 Thread Brian Geffon
g/linux-mm/20210302000133.272579-1-axelrasmus...@google.com/ Signed-off-by: Brian Geffon Acked-by: Hugh Dickins Tested-by: Lokesh Gidra --- mm/mremap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index ec8f840399ed..db5b8b28c2dd 100644 --- a/m

[PATCH] mremap.2: MREMAP_DONTUNMAP to reflect to supported mappings

2021-03-23 Thread Brian Geffon
mremap(2) now supports MREMAP_DONTUNMAP with mapping types other than private anonymous. Signed-off-by: Brian Geffon --- man2/mremap.2 | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/man2/mremap.2 b/man2/mremap.2 index 3ed0c0c0a..72acbc111 100644 --- a/man2

[PATCH v4 1/3] mm: Extend MREMAP_DONTUNMAP to non-anonymous mappings

2021-03-23 Thread Brian Geffon
g/linux-mm/20210302000133.272579-1-axelrasmus...@google.com/ Signed-off-by: Brian Geffon Acked-by: Hugh Dickins Tested-by: Lokesh Gidra --- mm/mremap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index ec8f840399ed..db5b8b28c2dd 100644 --- a/m

[PATCH v4 3/3] selftests: Add a MREMAP_DONTUNMAP selftest for shmem

2021-03-23 Thread Brian Geffon
This test extends the current mremap tests to validate that the MREMAP_DONTUNMAP operation can be performed on shmem mappings. Signed-off-by: Brian Geffon --- tools/testing/selftests/vm/mremap_dontunmap.c | 52 +++ 1 file changed, 52 insertions(+) diff --git a/tools/testing

[PATCH v4 2/3] Revert "mremap: don't allow MREMAP_DONTUNMAP on special_mappings and aio"

2021-03-23 Thread Brian Geffon
nce expanded support of MREMAP_DONTUNMAP to non-anonymous mappings, and these special mappings are still protected by the existing check of !VM_DONTEXPAND and !VM_PFNMAP which will result in a -EFAULT. 1. https://lkml.org/lkml/2020/12/28/2340 Signed-off-by: Brian Geffon Acked-by: Hugh Dickins --- arch/

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2021-03-22 Thread Brian Norris
dev for NAPI than they expose to /sys/class/net/), but it's there. I'm not sure if people had something else in mind in the stuff you're quoting though. Brian

Re: [PATCH 2/2] ibmvfc: make ibmvfc_wait_for_ops MQ aware

2021-03-19 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 1/2] ibmvfc: fix potential race in ibmvfc_wait_for_ops

2021-03-19 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

[PATCH v3 2/2] Revert "mremap: don't allow MREMAP_DONTUNMAP on special_mappings and aio"

2021-03-17 Thread Brian Geffon
nce expanded support of MREMAP_DONTUNMAP to non-anonymous mappings, and these special mappings are still protected by the existing check of !VM_DONTEXPAND and !VM_PFNMAP which will result in a -EFAULT. 1. https://lkml.org/lkml/2020/12/28/2340 Signed-off-by: Brian Geffon --- arch/x86/kernel/cpu/resc

[PATCH v3 1/2] mm: Allow non-VM_DONTEXPAND and VM_PFNMAP mappings with MREMAP_DONTUNMAP

2021-03-17 Thread Brian Geffon
using UFFDIO_CONTINUE for the new userfaultfd-based heap compaction." [1] https://lore.kernel.org/linux-mm/20201215030730.nc3cu98e4%25a...@linux-foundation.org/ [2] https://lore.kernel.org/linux-mm/20210302000133.272579-1-axelrasmus...@google.com/ Signed-off-by: Brian Geffon --- mm/mremap.c | 4 ++

Re: [PATCH v2 1/2] mm: Allow non-VM_DONTEXPAND and VM_PFNMAP mappings with MREMAP_DONTUNMAP

2021-03-17 Thread Brian Geffon
You're 100% correct, I'll mail a new patch in a few Brian On Wed, Mar 17, 2021 at 5:19 PM Peter Xu wrote: > > On Wed, Mar 17, 2021 at 04:44:25PM -0400, Brian Geffon wrote: > > Hi Peter, > > Hi, Brian, > > > Thank you as always for taking a look. This change relie

Re: [PATCH v2 1/2] mm: Allow non-VM_DONTEXPAND and VM_PFNMAP mappings with MREMAP_DONTUNMAP

2021-03-17 Thread Brian Geffon
Hi Peter, Thank you as always for taking a look. This change relies on the existing check in vma_to_resize on line 686: https://elixir.bootlin.com/linux/v5.12-rc3/source/mm/mremap.c#L686 which returns -EFAULT when the vma is VM_DONTEXPAND or VM_PFNMAP. Thanks Brian On Wed, Mar 17, 2021 at 4:40

[PATCH v2 2/2] Revert "mremap: don't allow MREMAP_DONTUNMAP on special_mappings and aio"

2021-03-17 Thread Brian Geffon
nce expanded support of MREMAP_DONTUNMAP to non-anonymous mappings, and these special mappings are still protected by the existing check of !VM_DONTEXPAND and !VM_PFNMAP which will result in a -EFAULT. 1. https://lkml.org/lkml/2020/12/28/2340 Signed-off-by: Brian Geffon --- arch/x86/kernel/cpu/resc

[PATCH v2 1/2] mm: Allow non-VM_DONTEXPAND and VM_PFNMAP mappings with MREMAP_DONTUNMAP

2021-03-17 Thread Brian Geffon
a...@linux-foundation.org/ [2] https://lore.kernel.org/linux-mm/20210302000133.272579-1-axelrasmus...@google.com/ Signed-off-by: Brian Geffon --- mm/mremap.c | 4 1 file changed, 4 deletions(-) diff --git a/mm/mremap.c b/mm/mremap.c index ec8f840399ed..2c57dc4bc8b6 100644 --- a/mm/mremap.

Re: [PATCH] mm: Allow shmem mappings with MREMAP_DONTUNMAP

2021-03-16 Thread Brian Geffon
> Whether or not there was before, it ought to get one now. Yes, the mremap(2) man page was updated when this flag was added and it will require a further update to reflect this expanded mapping support. Thanks Brian 1. https://lkml.org/lkml/2020/12/28/2340

[PATCH] eventfd: Introduce EFD_ZERO_ON_WAKE

2021-03-10 Thread Brian Geffon
a read is performed without EFD_NONBLOCK it will block until a write occurs. In both cases after the read completes successfully the internal value is reset to 0. When polling with POLLIN, upon return of a POLLIN event the internal value will be reset to 0. Signed-off-by: Brian Geffon

Re: [PATCH v3 05/11] x86/entry: Convert ret_from_fork to C

2021-03-04 Thread Brian Gerst
_fn)(void *), > +void *kernel_thread_arg, > +struct pt_regs *user_regs) > +{ > + instrumentation_begin(); > + > + schedule_tail(prev); > + > + if (kernel_thread_fn) { This should have an unlikely(), as kernel threads should be the rare case. -- Brian Gerst

Re: [PATCH] mm: Allow shmem mappings with MREMAP_DONTUNMAP

2021-03-03 Thread Brian Geffon
I apologize, this patch didn't include my signed off by, here it is: Signed-off-by: Brian Geffon On Wed, Mar 3, 2021 at 9:53 AM Brian Geffon wrote: > > Currently MREMAP_DONTUNMAP only accepts private anonymous mappings. This > change > will widen the support to include sh

[PATCH] mm: Allow shmem mappings with MREMAP_DONTUNMAP

2021-03-03 Thread Brian Geffon
Currently MREMAP_DONTUNMAP only accepts private anonymous mappings. This change will widen the support to include shmem mappings. The primary use case is to support MREMAP_DONTUNMAP on mappings which may have been created from a memfd. Lokesh Gidra who works on the Android JVM, provided an

Re: [PATCH v4 5/5] ibmvfc: reinitialize sub-CRQs and perform channel enquiry after LPM

2021-02-26 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v4 2/5] ibmvfc: fix invalid sub-CRQ handles after hard reset

2021-02-26 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v2 5/5] ibmvfc: reinitialize sub-CRQs and perform channel enquiry after LPM

2021-02-25 Thread Brian King
els = 0; > + > + ibmvfc_init_sub_crqs(vhost); > + > + spin_unlock(vhost->crq.q_lock); > + spin_unlock_irqrestore(vhost->host->host_lock, flags); ibmvfc_init_sub_crqs can sleep, for multiple reasons, so you can't hold a lock when you call it. There is a GFP_KERNEL allocation in it, and the patch before this one adds an msleep in an error path. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v2 4/5] ibmvfc: store return code of H_FREE_SUB_CRQ during cleanup

2021-02-25 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

[PATCH] mwifiex: don't print SSID to logs

2021-02-24 Thread Brian Norris
providing tools that convey kernel logs on behalf of a user -- e.g., when reporting bugs. So for example, it's easy to automatically filter logs for MAC addresses, but it's much harder to filter SSIDs out of unstructured text. Signed-off-by: Brian Norris --- drivers/net/wireless/marvell/mwifiex

Re: [PATCH v2] nand: brcmnand: fix OOB R/W with Hamming ECC

2021-02-24 Thread Brian Norris
d easily have obvious bugs like this. And since I got this far, and I'm still in MAINTAINERS, I guess: Acked-by: Brian Norris

Re: [PATCH 4/4] ibmvfc: store return code of H_FREE_SUB_CRQ during cleanup

2021-02-16 Thread Brian King
e); > } while (rc == H_BUSY || H_IS_LONG_BUSY(rc)); Other places in the driver where we get a busy return code back we have an msleep(100). Should we be doing that here as well? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 3/4] ibmvfc: treat H_CLOSED as success during sub-CRQ registration

2021-02-16 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 2/4] ibmvfc: fix invalid sub-CRQ handles after hard reset

2021-02-16 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH] xfs: Wake CIL push waiters more reliably

2021-02-16 Thread Brian Foster
is > > if (ctx->space_used >= XLOG_CIL_BLOCKING_SPACE_LIMIT(log)) > wake_up_all(>xc_push_wait); > > , which doesn't work reliably, preferable to > > if (waitqueue_active(>xc_push_wait)) > wake_up_all(>xc_push_wait); > > which does?

Re: [PATCH 1/4] ibmvfc: simplify handling of sub-CRQ initialization

2021-02-15 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH] xfs: fix boolreturn.cocci warnings

2021-02-10 Thread Brian Foster
; true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Fixes: 37444fc4cc39 ("xfs: lift writable fs check up into log worker task") > CC: Brian Foster > Reported-by: kernel test robot > Signed-off-by: kernel test robot >

Re: rcu: INFO: rcu_sched self-detected stall on CPU: Workqueue: xfs-conv/md0 xfs_end_io

2021-02-08 Thread Brian Foster
On Tue, Feb 09, 2021 at 07:43:14AM +1100, Dave Chinner wrote: > On Mon, Feb 08, 2021 at 09:28:24AM -0800, Darrick J. Wong wrote: > > On Mon, Feb 09, 2021 at 09:11:40AM -0800, Paul E. McKenney wrote: > > > On Mon, Feb 08, 2021 at 10:44:58AM -0500, Brian Foster wrote: > > &

Re: rcu: INFO: rcu_sched self-detected stall on CPU: Workqueue: xfs-conv/md0 xfs_end_io

2021-02-08 Thread Brian Foster
On Mon, Feb 08, 2021 at 09:28:24AM -0800, Darrick J. Wong wrote: > On Mon, Feb 09, 2021 at 09:11:40AM -0800, Paul E. McKenney wrote: > > On Mon, Feb 08, 2021 at 10:44:58AM -0500, Brian Foster wrote: > > > On Mon, Feb 08, 2021 at 06:57:24AM -0800, Paul E. McKenney wrote: >

Re: rcu: INFO: rcu_sched self-detected stall on CPU: Workqueue: xfs-conv/md0 xfs_end_io

2021-02-08 Thread Brian Foster
On Mon, Feb 08, 2021 at 06:57:24AM -0800, Paul E. McKenney wrote: > On Mon, Feb 08, 2021 at 09:07:24AM -0500, Brian Foster wrote: > > On Fri, Feb 05, 2021 at 09:12:40AM -0800, Paul E. McKenney wrote: > > > On Fri, Feb 05, 2021 at 08:29:06AM +0100, Paul Menzel wrote: > &

Re: rcu: INFO: rcu_sched self-detected stall on CPU: Workqueue: xfs-conv/md0 xfs_end_io

2021-02-08 Thread Brian Foster
f16d5f1..06be426 100644 > --- a/fs/xfs/xfs_aops.c > +++ b/fs/xfs/xfs_aops.c > @@ -390,6 +390,7 @@ xfs_end_io( > list_del_init(>io_list); > xfs_ioend_try_merge(ioend, _list); > xfs_end_ioend(ioend); > + cond_resched(); >

[PATCH net-next 1/2] net: add EXPORT_INDIRECT_CALLABLE wrapper

2021-02-04 Thread Brian Vazquez
introduces a new indirect call wrapper: EXPORT_INDIRECT_CALLABLE. This basically does EXPORT_SYMBOL when CONFIG_RETPOLINE is set, but does nothing when it's not. Reported-by: Stephen Rothwell Signed-off-by: Brian Vazquez --- include/linux/indirect_call_wrapper.h | 2 ++ 1 file changed, 2

[PATCH net-next 2/2] net: fix building errors on powerpc when CONFIG_RETPOLINE is not set

2021-02-04 Thread Brian Vazquez
MBOL ERROR: modpost: "ip6_mtu" [vmlinux] is a static EXPORT_SYMBOL Fixes: f67fbeaebdc0 ("net: use indirect call helpers for dst_mtu") Fixes: bbd807dfbf20 ("net: indirect call helpers for ipv4/ipv6 dst_check functions") Reported-by: Stephen Rothwell Signed-off-by: Bri

[PATCH net-next 2/2] net: fix building errors on powerpc when CONFIG_RETPOLINE is not set

2021-02-04 Thread Brian Vazquez
MBOL ERROR: modpost: "ip6_mtu" [vmlinux] is a static EXPORT_SYMBOL Fixes: f67fbeaebdc0 ("net: use indirect call helpers for dst_mtu") Fixes: bbd807dfbf20 ("net: indirect call helpers for ipv4/ipv6 dst_check functions") Reported-by: Stephen Rothwell Signed-off-by: Bri

Re: [PATCH] xfs: fix unused variable warning

2021-02-04 Thread Brian Foster
variable] > > Remove the variable declaration and open-code it inside > of the assertion. > > Fixes: 303591a0a947 ("xfs: cover the log during log quiesce") > Signed-off-by: Arnd Bergmann > --- I sent basically the same patch[1] about a week ago, but either one is

Re: [PATCH net-next 1/2] net: add EXPORT_INDIRECT_CALLABLE wrapper

2021-02-04 Thread Brian Vazquez
Yeah, I'm also not seeing it on patchwork. But I did get the email on both corp and personal email. So maybe something is failing at patchwork? On Thu, Feb 4, 2021 at 9:50 AM George McCollister wrote: > > I don't see the second patch. > > Regards, > George McCollister

Re: linux-next: build failure after merge of the net-next tree

2021-02-04 Thread Brian Vazquez
Hi all, I've just sent the patch series: https://patchwork.kernel.org/project/netdevbpf/list/?series=428099. Thanks, Brian On Thu, Feb 4, 2021 at 7:36 AM Vladimir Oltean wrote: > > Hi Brian, > > On Wed, Feb 03, 2021 at 07:52:08PM -0800, Brian Vazquez wrote: > > Hi Stephen, tha

[PATCH net-next 1/2] net: add EXPORT_INDIRECT_CALLABLE wrapper

2021-02-04 Thread Brian Vazquez
introduces a new indirect call wrapper: EXPORT_INDIRECT_CALLABLE. This basically does EXPORT_SYMBOL when CONFIG_RETPOLINE is set, but does nothing when it's not. Reported-by: Stephen Rothwell Signed-off-by: Brian Vazquez --- include/linux/indirect_call_wrapper.h | 2 ++ 1 file changed, 2

Re: linux-next: build failure after merge of the net-next tree

2021-02-03 Thread Brian Vazquez
Hi Stephen, thanks for the report. I'm having trouble trying to compile for ppc, but I believe this should fix the problem, could you test this patch, please? Thanks! diff --git a/include/linux/indirect_call_wrapper.h b/include/linux/indirect_call_wrapper.h index 54c02c84906a..077f96be65c6 100644

Re: [PATCH] mwifiex: Report connected BSS with cfg80211_connect_bss()

2021-02-01 Thread Brian Norris
bss to a bss with the wrong channel. > > Let mwifiex_cfg80211_assoc return the selected BSS and then the caller > can report it cfg80211_connect_bss. > > Signed-off-by: Yen-lin Lai This seems sane to me: Reviewed-by: Brian Norris

[PATCH net-next v3 2/4] net: use indirect call helpers for dst_output

2021-02-01 Thread Brian Vazquez
This patch avoids the indirect call for the common case: ip6_output and ip_output Signed-off-by: Brian Vazquez --- include/net/dst.h | 8 +++- net/ipv4/ip_output.c | 1 + net/ipv6/ip6_output.c | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/net/dst.h b

[PATCH net-next v3 3/4] net: use indirect call helpers for dst_mtu

2021-02-01 Thread Brian Vazquez
This patch avoids the indirect call for the common case: ip6_mtu and ipv4_mtu Signed-off-by: Brian Vazquez --- include/net/dst.h | 4 +++- net/ipv4/route.c | 6 -- net/ipv6/route.c | 6 -- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/include/net/dst.h b/include/net

[PATCH net-next v3 4/4] net: indirect call helpers for ipv4/ipv6 dst_check functions

2021-02-01 Thread Brian Vazquez
This patch avoids the indirect call for the common case: ip6_dst_check and ipv4_dst_check Signed-off-by: Brian Vazquez --- include/net/dst.h | 7 ++- net/core/sock.c | 12 ++-- net/ipv4/route.c| 7 +-- net/ipv4/tcp_ipv4.c | 5 - net/ipv6/route.c| 7

[PATCH net-next v3 0/4] net: use INDIRECT_CALL in some dst_ops

2021-02-01 Thread Brian Vazquez
06e-09 No difference proven at 80.0% confidence Changed in v3: - fix From: tag - provide measurements Changed in v2: -fix build issues reported by kernel test robot Brian Vazquez (4): net: use indirect call helpers for dst_input net: use indirect call helpers for dst_output net: use i

[PATCH net-next v3 1/4] net: use indirect call helpers for dst_input

2021-02-01 Thread Brian Vazquez
This patch avoids the indirect call for the common case: ip_local_deliver and ip6_input Signed-off-by: Brian Vazquez --- include/net/dst.h | 6 +- net/ipv4/ip_input.c | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/net/dst.h b/include/net/dst.h index

Re: [PATCH] drm/msm/mdp5: Fix wait-for-commit for cmd panels

2021-01-31 Thread Brian Masney
Rob Clark > Fixes: 2d99ced787e3d ("drm/msm: async commit support") Nice job tracking down this fix! Reviewed-by: Brian Masney Tested-by: Brian Masney

Re: [PATCH] soc: qcom: ocmem: don't return NULL in of_get_ocmem

2021-01-31 Thread Brian Masney
> leading to a NULL pointer dereference. > > Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver") > Signed-off-by: Luca Weiss Reviewed-by: Brian Masney

Re: [PATCH V2 3/6] x86_32/sysenter: switch to the task stack without emptying the entry stack

2021-01-26 Thread Brian Gerst
->ip = 0 (placeholder) */ > - pushl %eax/* pt_regs->orig_ax */ > + pushl (%eax) /* pt_regs->orig_ax */ Add an %ss: override here too. > SAVE_ALL pt_regs_ax=$-ENOSYS/* save rest, stack already switched > */ > > /* > -- > 2.19.1.6.gb485710b > -- Brian Gerst

Re: linux-next: build warning after merge of the xfs tree

2021-01-25 Thread Brian Foster
unused variable 'log' [-Wunused-variable] > | struct xlog *log = mp->m_log; > |^~~ > > Introduced by commit > > 303591a0a947 ("xfs: cover the log during log quiesce") > Oops, patch below. Feel free to apply or squ

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add gpu support

2021-01-24 Thread Brian Masney
hen feel free to drop my name from the patch. I thought that I had made these changes already but apparently not. :/ Brian

Re: [PATCH] xfs: set inode size after creating symlink

2021-01-21 Thread Brian Foster
> Signed-off-by: Jeffrey Mitchell > --- Reviewed-by: Brian Foster > fs/xfs/xfs_symlink.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c > index 1f43fd7f3209..c835827ae389 100644 > --- a/fs/xfs/xf

Re: [PATCH] marvell/mwifiex: replace one-element array with flexible-array member.

2021-01-19 Thread Brian Norris
One more thing, for context: On Tue, Jan 19, 2021 at 11:11 AM Brian Norris wrote: > On Fri, Jan 15, 2021 at 1:39 AM Jiapeng Zhong > wrote: > > > > Fix the follow coccicheck warnings: > > > > ./drivers/net/wireless/marvell/mwifiex/fw.h: WARNING use flexible-

Re: [PATCH] marvell/mwifiex: replace one-element array with flexible-array member.

2021-01-19 Thread Brian Norris
of these structs, it's nice to make a small explanation of why this is correct, so I (and other readers) don't have to ask these questions :) Regards, Brian

RE: [PATCH 04/18] arch: hexagon: Don't select HAVE_OPROFILE

2021-01-15 Thread Brian Cain
; > Don't select HAVE_OPROFILE for hexagon anymore. Acked-by: Brian Cain > Suggested-by: Christoph Hellwig > Suggested-by: Linus Torvalds > Signed-off-by: Viresh Kumar > --- > arch/hexagon/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/h

RE: [PATCH] hexagon: remove CONFIG_EXPERIMENTAL from defconfigs

2021-01-15 Thread Brian Cain
> -Original Message- > From: Randy Dunlap ... > Since CONFIG_EXPERIMENTAL was removed in 2013, go ahead and drop it > from any defconfig files. Acked-by: Brian Cain > Fixes: 3d374d09f16f ("final removal of CONFIG_EXPERIMENTAL") > Signed-off-by: Randy Dunlap

Re: [PATCH v5 00/21] ibmvfc: initial MQ development/enablement

2021-01-14 Thread Brian King
, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v5 21/21] ibmvfc: provide modules parameters for MQ settings

2021-01-14 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v5 18/21] ibmvfc: send Cancel MAD down each hw scsi channel

2021-01-14 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v4 01/21] ibmvfc: add vhost fields and defaults for MQ enablement

2021-01-14 Thread Brian King
On 1/13/21 7:27 PM, Ming Lei wrote: > On Wed, Jan 13, 2021 at 11:13:07AM -0600, Brian King wrote: >> On 1/12/21 6:33 PM, Tyrel Datwyler wrote: >>> On 1/12/21 2:54 PM, Brian King wrote: >>>> On 1/11/21 5:12 PM, Tyrel Datwyler wrote: >>>>> Introduce s

Re: [PATCH v4 00/21] ibmvfc: initial MQ development

2021-01-13 Thread Brian King
With the exception of the few comments I've shared, the rest of this looks good to me and you can add my: Reviewed-by: Brian King Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v4 21/21] ibmvfc: provide modules parameters for MQ settings

2021-01-13 Thread Brian King
t;mq_enabled = IBMVFC_MQ; > - vhost->client_scsi_channels = IBMVFC_SCSI_CHANNELS; > + vhost->mq_enabled = mq_enabled; > + vhost->client_scsi_channels = min(nr_scsi_hw_queues, nr_scsi_channels); > vhost->using_channels = 0; > vhost->do_enquiry = 1; > > -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v4 01/21] ibmvfc: add vhost fields and defaults for MQ enablement

2021-01-13 Thread Brian King
On 1/12/21 6:33 PM, Tyrel Datwyler wrote: > On 1/12/21 2:54 PM, Brian King wrote: >> On 1/11/21 5:12 PM, Tyrel Datwyler wrote: >>> Introduce several new vhost fields for managing MQ state of the adapter >>> as well as initial defaults for MQ enablement. >>&g

Re: [PATCH v4 01/21] ibmvfc: add vhost fields and defaults for MQ enablement

2021-01-12 Thread Brian King
ement our own host wide busy reference counting, which doesn't sound very good, or we need to add some API to block / scsi that allows us to dynamically change can_queue. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH v4 18/21] ibmvfc: send Cancel MAD down each hw scsi channel

2021-01-12 Thread Brian King
default break needs to be a return -EIO. > + } > + } > + } > + > + sdev_printk(KERN_INFO, sdev, "Successfully cancelled outstanding > commands\n"); > + return 0; > +} > + > +static int ibmvfc_cancel_all_sq(struct scsi_device *sdev, int type) > { > struct ibmvfc_host *vhost = shost_priv(sdev->host); > struct ibmvfc_event *evt, *found_evt; > @@ -2498,6 +2559,27 @@ static int ibmvfc_cancel_all(struct scsi_device *sdev, > int type) > return 0; > } > -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2021-01-11 Thread Brian Norris
X_SSID_LEN)) Ah, good catch. So this may not be a true overflow issue at all, even if it's confusing and bad code. The "problem" is that this piece of the struct is variable-length, and unless we're going to dynamically resize/reallocate the whole buffer, we have to assume the initial allocation was large enough (and per your note, it is). > For sure something to improve here instead of using a confusing 'u8 ssid[1]' > in struct mwifiex_ie_types_wildcard_ssid_params... Yep. Brian

Re: [PATCH] xfs: Wake CIL push waiters more reliably

2021-01-11 Thread Brian Foster
On Fri, Jan 08, 2021 at 11:56:57AM -0500, Brian Foster wrote: > On Fri, Jan 08, 2021 at 08:54:44AM +1100, Dave Chinner wrote: > > On Mon, Jan 04, 2021 at 11:23:53AM -0500, Brian Foster wrote: > > > On Thu, Dec 31, 2020 at 09:16:11AM +1100, Dave Chinner wrote: > > > >

Re: [PATCH] x86/vm86/32: Remove VM86_SCREEN_BITMAP support

2021-01-08 Thread Brian Gerst
+336,6 @@ static long do_sys_vm86(struct vm86plus_struct __user > *user_vm86, bool plus) > update_task_stack(tsk); > preempt_enable(); > > - if (vm86->flags & VM86_SCREEN_BITMAP) > - mark_screen_rdonly(tsk->mm); > - > memcpy((struct kernel_vm86_regs *)regs, , sizeof(vm86regs)); > return regs->ax; > } You can also remove screen_bitmap from struct vm86 (the kernel internal structure), and the check_v8086_mode() function. -- Brian Gerst

Re: [PATCH] xfs: Wake CIL push waiters more reliably

2021-01-08 Thread Brian Foster
On Fri, Jan 08, 2021 at 08:54:44AM +1100, Dave Chinner wrote: > On Mon, Jan 04, 2021 at 11:23:53AM -0500, Brian Foster wrote: > > On Thu, Dec 31, 2020 at 09:16:11AM +1100, Dave Chinner wrote: > > > On Wed, Dec 30, 2020 at 12:56:27AM +0100, Donald Buczek wrote: > > >

Re: [PATCH] xfs: Wake CIL push waiters more reliably

2021-01-04 Thread Brian Foster
nd I don't have specific examples off the top of my head, but perhaps based on the ability of various structures to change formats and the ability of log vectors to shrink in size, shouldn't we expect the possibility of a CIL context to shrink in size as well? Just from poking around the CIL it seems like the surrounding code supports it (xlog_cil_insert_items() checks len > 0 for recalculating split res as well)... Brian > Cheers, > > Dave. > -- > Dave Chinner > da...@fromorbit.com >

Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add gpu support

2020-12-30 Thread Brian Masney
On Wed, Dec 30, 2020 at 05:51:29PM +0200, Iskren Chernev wrote: > From: Brian Masney > > Add support for the a3xx GPU > > Signed-off-by: Brian Masney Reviewed-by: Brian Masney

Re: [PATCH 1/2] drm/msm: Call msm_init_vram before binding the gpu

2020-12-30 Thread Brian Masney
On Wed, Dec 30, 2020 at 05:29:42PM +0200, Iskren Chernev wrote: > From: Craig Tatlor > > vram.size is needed when binding a gpu without an iommu and is defined > in msm_init_vram(), so run that before binding it. > > Signed-off-by: Craig Tatlor For the series: Reviewe

Re: [PATCH 2/6] mm/mremap: For MREMAP_DONTUNMAP check security_vm_enough_memory_mm()

2020-12-30 Thread Brian Geffon
Ah, you're right. This individual patch looks good to me. Brian On Mon, Dec 28, 2020 at 11:12 AM Dmitry Safonov wrote: > > On 12/28/20 6:21 PM, Brian Geffon wrote: > > This looks good to me with a small comment. > > > >> if (do_munmap(mm, old_a

Re: [PATCH 2/6] mm/mremap: For MREMAP_DONTUNMAP check security_vm_enough_memory_mm()

2020-12-28 Thread Brian Geffon
This looks good to me with a small comment. > if (do_munmap(mm, old_addr, old_len, uf_unmap) < 0) { > /* OOM: unable to split vma, just get accounts right */ > - if (vm_flags & VM_ACCOUNT) > + if (vm_flags & VM_ACCOUNT && !(flags &

Re: [PATCH 3/6] mremap: Don't allow MREMAP_DONTUNMAP on special_mappings and aio

2020-12-28 Thread Brian Geffon
I don't think this situation can ever happen MREMAP_DONTUNMAP is already restricted to anonymous mappings (defined as not having vm_ops) and vma_to_resize checks that the mapping is anonymous before move_vma is called. On Mon, Oct 12, 2020 at 6:34 PM Dmitry Safonov wrote: > > As kernel expect

[tip: x86/urgent] fanotify: Fix sys_fanotify_mark() on native x86-32

2020-12-28 Thread tip-bot2 for Brian Gerst
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 2ca408d9c749c32288bc28725f9f12ba30299e8f Gitweb: https://git.kernel.org/tip/2ca408d9c749c32288bc28725f9f12ba30299e8f Author:Brian Gerst AuthorDate:Mon, 30 Nov 2020 17:30:59 -05:00 Committer

Re: v5.10.1 xfs deadlock

2020-12-18 Thread Brian Foster
On Thu, Dec 17, 2020 at 10:30:37PM +0100, Donald Buczek wrote: > On 17.12.20 20:43, Brian Foster wrote: > > On Thu, Dec 17, 2020 at 06:44:51PM +0100, Donald Buczek wrote: > > > Dear xfs developer, > > > > > > I was doing some testing on a Linux 5.10.1 system wi

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-17 Thread Brian Norris
On Thu, Dec 17, 2020 at 2:57 PM Ben Greear wrote: > On 12/17/20 2:24 PM, Brian Norris wrote: > > I'd also note that we don't operate in AP mode -- only STA -- and IIRC > > Ben, you've complained about AP mode in the past. > > I complain about all sorts of things, but I'm usua

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-17 Thread Brian Norris
who uses a decent mail reader, with proper threading). See for example the lore archive, which only is threading replies to this cover letter: https://lore.kernel.org/linux-wireless/20201215172113.5038-1-yough...@codeaurora.org/ Regards, Brian

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-17 Thread Brian Norris
rom "seamless" restarts, as noted in patch 3.) I'd also note that we don't operate in AP mode -- only STA -- and IIRC Ben, you've complained about AP mode in the past. Brian

Re: v5.10.1 xfs deadlock

2020-12-17 Thread Brian Foster
-scsi) , but it is unlikely that this blocking is related to that, > because the md block devices itself are responsive (`xxd /dev/md0` ) > > I can keep the system in the state for a while. Is there an idea what was > going from or an idea what data I could collect from the running system to > help? I have full debug info and could walk lists or retrieve data structures > with gdb. > It might be useful to dump the values under /sys/fs/xfs//log/* for each fs to get an idea of the state of the logs as well... Brian > Best > Donald >

[PATCH net-next v2 4/4] net: indirect call helpers for ipv4/ipv6 dst_check functions

2020-12-11 Thread Brian Vazquez
From: brianvv This patch avoids the indirect call for the common case: ip6_dst_check and ipv4_dst_check Signed-off-by: brianvv --- include/net/dst.h | 7 ++- net/core/sock.c | 12 ++-- net/ipv4/route.c| 7 +-- net/ipv4/tcp_ipv4.c | 5 - net/ipv6/route.c|

[PATCH net-next v2 3/4] net: use indirect call helpers for dst_mtu

2020-12-11 Thread Brian Vazquez
From: brianvv This patch avoids the indirect call for the common case: ip6_mtu and ipv4_mtu Signed-off-by: brianvv --- include/net/dst.h | 4 +++- net/ipv4/route.c | 6 -- net/ipv6/route.c | 6 -- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/include/net/dst.h

  1   2   3   4   5   6   7   8   9   10   >