Re: [PATCH bpf 2/4] nsfs: add an ioctl to discover the network namespace cookie

2021-03-01 Thread Christian Brauner
On Wed, Feb 10, 2021 at 12:04:23PM +, Lorenz Bauer wrote: > Network namespaces have a globally unique non-zero identifier aka a > cookie, in line with socket cookies. Add an ioctl to retrieve the > cookie from user space without going via BPF. > > Cc: linux-...@vger.kernel.org >

[PATCH] mount_setattr.2: New manual page documenting the mount_setattr() system call

2021-03-01 Thread Christian Brauner
Signed-off-by: Christian Brauner --- man2/mount_setattr.2 | 1071 ++ 1 file changed, 1071 insertions(+) create mode 100644 man2/mount_setattr.2 diff --git a/man2/mount_setattr.2 b/man2/mount_setattr.2 new file mode 100644 index 0..23d1a1036

Re: [PATCH -next] fs: libfs: fix kernel-doc for mnt_userns

2021-02-16 Thread Christian Brauner
On Tue, Feb 16, 2021 at 09:48:25AM +0100, Christoph Hellwig wrote: > On Mon, Feb 15, 2021 at 08:29:27PM -0800, Randy Dunlap wrote: > > Fix kernel-doc warning in libfs.c. > > > > ../fs/libfs.c:498: warning: Function parameter or member 'mnt_userns' not > > described in 'simple_setattr' > >

[GIT PULL] idmapped mounts for v5.12

2021-02-13 Thread Christian Brauner
:pub/scm/linux/kernel/git/brauner/linux tags/idmapped-mounts-ext4-v5.12 4. Tag containing infrastructure and only the xfs port: g...@gitolite.kernel.org:pub/scm/linux/kernel/git/brauner/linux tags/idmapped-mounts-xfs-v5.12 Thanks! Christian idmapped-mounts-v5.12

Re: [PATCH] nios2: fixed broken sys_clone syscall

2021-02-05 Thread Christian Brauner
ken > --- Thanks for catching this! Acked-by: Christian Brauner

Re: forkat(int pidfd), execveat(int pidfd), other awful things?

2021-02-01 Thread Christian Brauner
On Mon, Feb 01, 2021 at 06:47:17PM +0100, Jason A. Donenfeld wrote: > Hi Andy & others, > > I was reversing some NT stuff recently and marveling over how wild and > crazy things are over in Windows-land. A few things related to process > creation caught my interest: > > - It's possible to create

Re: [PATCH v6] close_range.2: new page documenting close_range(2)

2021-01-29 Thread Christian Brauner
On Thu, Jan 28, 2021 at 09:50:23PM +0100, Michael Kerrisk (man-pages) wrote: > Hello Stephen, (and CHristian, please!) Ah, I think this was mostly done which is why I kept quiet. Christian

Re: linux-next: manual merge of the pidfd tree with the xfs tree

2021-01-27 Thread Christian Brauner
On Tue, Jan 26, 2021 at 07:11:15PM -0800, Darrick J. Wong wrote: > On Wed, Jan 27, 2021 at 11:24:41AM +1100, Stephen Rothwell wrote: > > Hi all, > > > > On Mon, 25 Jan 2021 17:14:14 +1100 Stephen Rothwell > > wrote: > > > > > > Today's linux-next merge of the pidfd tree got a conflict in: > > >

Re: Dealing with complex patch series in linux-next

2021-01-26 Thread Christian Brauner
On Tue, Jan 26, 2021 at 07:00:30PM +1100, Stephen Rothwell wrote: > Hi Christian, > > On Mon, 25 Jan 2021 10:43:23 +0100 Christian Brauner > wrote: > > > > After having received another round of acks on the idmapped mounts > > series and other fses about to mov

Dealing with complex patch series in linux-next

2021-01-25 Thread Christian Brauner
Hey, After having received another round of acks on the idmapped mounts series and other fses about to move forward with porting I moved forward with merging [1] into my for-next branch which is tracked by sfr in linux-next. Given the nature of the series I expected there to be a good chunk of

[GIT PULL] misc fixes for v5.11-rc5

2021-01-24 Thread Christian Brauner
Hi Linus, Here are some fixes for v5.11-rc5 that should hopefully be fairly uncontroversial. I've had them sitting around for a bit but only got around sending them now after concluding the idmapped mounts stuff. Sorry for the delay. /* Summary */ - Jann reported sparse complaints because of a

Re: [PATCH] sh: Remove unused HAVE_COPY_THREAD_TLS macro

2021-01-19 Thread Christian Brauner
On Mon, Oct 12, 2020 at 11:50:24AM +0800, Jinyang He wrote: > Fixes:e1cc9d8d596e ("sh: switch to copy_thread_tls()") > Signed-off-by: Jinyang He > --- Acked-by: Christian Brauner weird that I missed to remove this during the conversion. Thanks! Christian

Re: [PATCH net-next] net: core: Namespace-ify sysctl_wmem_default and sysctl_rmem_default

2021-01-18 Thread Christian Brauner
On Sun, Jan 17, 2021 at 06:23:19PM +0800, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > For now, sysctl_wmem_default and sysctl_rmem_default are globally > unified. It's not convenient in some case. For example, when we > use docker and try to control the default udp socket receive

Re: [RFC 1/1] s390/pci: expose UID checking state in sysfs

2021-01-14 Thread Christian Brauner
>> currently don't have any other global attributes > >> that we are planning to expose but those could of > >> course come up in the future. > > > > Ah, I missed the fact that this is a kobj_attribute, not a > > device_attribute. Maybe KERNEL_ATTR_RO()? Ve

Re: [PATCH] kthread: remove comments about old _do_fork() helper

2021-01-11 Thread Christian Brauner
On Mon, Jan 11, 2021 at 06:48:07PM +0800, yanfei...@windriver.com wrote: > From: Yanfei Xu > > The old _do_fork() helper has been removed in favor of kernel_clone(). > Here correct some comments which still contain _do_fork() > > Signed-off-by: Yanfei Xu > --- Acked-

Re: [PATCH 01/10] clone: add CLONE_PIDFD

2021-01-04 Thread Christian Brauner
On Mon, Jan 04, 2021 at 02:17:40PM +0100, Greg Kroah-Hartman wrote: > On Mon, Jan 04, 2021 at 02:13:42PM +0100, Christian Brauner wrote: > > On Mon, Jan 04, 2021 at 02:03:14PM +0100, Greg Kroah-Hartman wrote: > > > On Fri, Dec 04, 2020 at 02:31:55AM +0800, Wen Yang wrote: >

Re: [PATCH 01/10] clone: add CLONE_PIDFD

2021-01-04 Thread Christian Brauner
On Mon, Jan 04, 2021 at 02:03:14PM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 04, 2020 at 02:31:55AM +0800, Wen Yang wrote: > > From: Christian Brauner > > > > [ Upstream commit b3e5838252665ee4cfa76b82bdf1198dca81e5be ] > > > > This patchset makes

Re: Bug in __mmdrop() triggered by io-uring on v5.11-rc1

2020-12-29 Thread Christian Brauner
On Mon, Dec 28, 2020 at 05:00:53PM -0700, Jens Axboe wrote: > On 12/28/20 9:54 AM, Christian Brauner wrote: > > Hey everyone, > > > > The following oops can be triggered on a pristine v5.11-rc1 which I > > discovered > > while rebasing my idmap

Re: [PATCH] Kernel: fork.c: Fix coding style: Do not use {} around single-line statements

2020-12-29 Thread Christian Brauner
On Sat, Dec 26, 2020 at 12:40:21PM +0100, Alexander Guril wrote: > Fixed two coding style issues in kernel/fork.c > Do not use {} around single-line statements. > > Signed-off-by: Alexander Guril > --- Acked-by: Christian Brauner I'll pick this up, thanks!

Bug in __mmdrop() triggered by io-uring on v5.11-rc1

2020-12-28 Thread Christian Brauner
Hey everyone, The following oops can be triggered on a pristine v5.11-rc1 which I discovered while rebasing my idmapped mount patchset onto v5.11-rc1: [ 577.716339][ T7216] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009)/LXD, BIOS 0.0.0 02/06/2015 [ 577.718584][ T7216] Call Trace: [

Re: [PATCH] Kernel: Fixed two bracket problems in fork.c

2020-12-21 Thread Christian Brauner
On Mon, Dec 21, 2020 at 04:05:02PM +0100, Alexander Guril wrote: > This fixes two bracket problems in kernel/fork.c > > Signed-off-by: Alexander Guril > --- Thanks for the patch. Unfortunately, there's no real rationale for the change in the commit message. You probably want to mention that our

Re: [PATCH] signal: Don't init struct kernel_siginfo fields to zero again

2020-12-20 Thread Christian Brauner
On Mon, Dec 21, 2020 at 12:43:05AM +0900, Rae Kim wrote: > > It looks like compiler optimization is smart enough to know that > assigning zero is unnecessary after clear_siginfo() which is memset() > under the hood. At least in my x86_64 machine, w/ or w/o this patch, > there is no difference in

Re: [PATCH] signal: Don't init struct kernel_siginfo fields to zero again

2020-12-20 Thread Christian Brauner
gt; all bits in the struct are cleared after it. > > [1]: commit 8c5dbf2ae00b ("signal: Introduce clear_siginfo") > > Signed-off-by: Leesoo Ahn > --- Acked-by: Christian Brauner I have a __user annotation fix in my tree from Jann that I plan to send soon so I'll just s

[GIT PULL] close_range fix v5.11

2020-12-19 Thread Christian Brauner
lose-range-cloexec-unshare-v5.11 tag. Thanks! Christian close-range-cloexec-unshare-v5.11 ---- Christian Brauner (4): close_range: unshare all fds for CLOSE_RAN

Re: KASAN: null-ptr-deref Read in filp_close

2020-12-17 Thread Christian Brauner
On Thu, Dec 17, 2020 at 07:54:09AM -0800, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:5e60366d Merge tag 'fallthrough-fixes-clang-5.11-rc1' of g.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=15f1541350 >

Re: regression: 9a56493f6942 "uts: Use generic ns_common::count" broke makedumpfile 1.6.7

2020-12-16 Thread Christian Brauner
On Wed, Dec 16, 2020 at 06:20:36PM +0300, Kirill Tkhai wrote: > On 16.12.2020 17:49, Mike Galbraith wrote: > > On Wed, 2020-12-16 at 15:31 +0100, Mike Galbraith wrote: > >> On Wed, 2020-12-16 at 17:23 +0300, Kirill Tkhai wrote: > >>> > >>> Does this regression only cause that one error message

Re: regression: 9a56493f6942 "uts: Use generic ns_common::count" broke makedumpfile 1.6.7

2020-12-16 Thread Christian Brauner
On Wed, Dec 16, 2020 at 05:23:30PM +0300, Kirill Tkhai wrote: > On 16.12.2020 16:32, Mike Galbraith wrote: > > On Wed, 2020-12-16 at 15:35 +0300, Kirill Tkhai wrote: > >> Hi, Alexander, > >> > >> On 16.12.2020 14:02, Mike Galbraith wrote: > >>> Greetings, > >>> > >>> With this commit, bisected and

[GIT PULL] close_range()/openat2() v5.11

2020-12-15 Thread Christian Brauner
Hi Linus, /* Summary */ This contains a fix for openat2() to make RESOLVE_BENEATH and RESOLVE_IN_ROOT mutually exclusive. It doesn't make sense to specify both at the same time. The openat2() selftests have been extended to verify that these two flags can't be specified together. This also adds

Re: [GIT PULL] Some fixes for v5.11

2020-12-15 Thread Christian Brauner
On Mon, Dec 14, 2020 at 04:45:50PM -0800, Linus Torvalds wrote: > On Mon, Dec 14, 2020 at 5:27 AM Christian Brauner > wrote: > > > > /* Conflicts */ > > At the time of creating this PR no merge conflicts were reported from > > linux-next and no merge conflict with 2c

Re: [GIT PULL] Some fixes for v5.11

2020-12-15 Thread Christian Brauner
On Tue, Dec 15, 2020 at 03:37:51PM +1100, Stephen Rothwell wrote: > Hi Linus, > > On Mon, 14 Dec 2020 16:45:50 -0800 Linus Torvalds > wrote: > > > > On Mon, Dec 14, 2020 at 5:27 AM Christian Brauner > > wrote: > > > > > > /* Conflicts */ > >

[GIT PULL] Some fixes for v5.11

2020-12-14 Thread Christian Brauner
when pulling the tag. Please consider pulling these changes from the signed fixes-v5.11 tag. Thanks! Christian fixes-v5.11 -------- Christian Brauner (2): ns: A

[GIT PULL] time namespace fixes for v5.11

2020-12-14 Thread Christian Brauner
Hi Linus, Here are some time namespace fixes for v5.11. /* Summary */ When time namespaces were introduced we missed to virtualize the "btime" field in /proc/stat. This confuses tasks which are in another time namespace with a virtualized boottime which is common in some container workloads.

Re: [PATCH v2] close_range.2: new page documenting close_range(2)

2020-12-12 Thread Christian Brauner
On Thu, Dec 10, 2020 at 01:24:28AM +0100, Alejandro Colomar (man-pages) wrote: > Hi Stephen, > > A few more comments below. > > Michael, please have a look at them too. > > Christian, do you have any program that you used to test the syscall > that could be added as an example program to the

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-12 Thread Christian Brauner
On Thu, Dec 10, 2020 at 03:36:42PM +0100, Alejandro Colomar (man-pages) wrote: > Hi Christian, Hi Alex, > > Thanks for confirming that behavior. Seems reasonable. > > I was wondering... > If this call is equivalent to unshare(2)+{close(2) in a loop}, > shouldn't it fail for the same reasons

Re: [PATCH] files: rcu free files_struct

2020-12-10 Thread Christian Brauner
On Thu, Dec 10, 2020 at 09:36:24PM +, Al Viro wrote: > On Thu, Dec 10, 2020 at 01:29:01PM -0600, Eric W. Biederman wrote: > > Al Viro writes: > > > > What are the users of that thing and is there any chance to replace it > > > with something saner? IOW, what *is* realistically called for

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Christian Brauner
On Wed, Dec 09, 2020 at 11:44:22AM +0100, Alejandro Colomar (man-pages) wrote: > Hey Christian, > > I have a question for you below. > > Thanks, Hey Alex, Sure! > > Alex > > On 12/9/20 10:58 AM, Christian Brauner wrote: > > On Tue, Dec 08, 2020 at 10:

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Christian Brauner
On Tue, Dec 08, 2020 at 10:51:33PM +0100, Stephen Kitt wrote: > This documents close_range(2) based on information in > 278a5fbaed89dacd04e9d052f4594ffd0e0585de and > 60997c3d45d9a67daf01c56d805ae4fec37e0bd8. > > Signed-off-by: Stephen Kitt > --- Hey Stephen, Thanks for working on this that's

Re: [patch] close_range.2: new page documenting close_range(2)

2020-12-09 Thread Christian Brauner
On Wed, Dec 09, 2020 at 09:50:38AM +0100, Michael Kerrisk (man-pages) wrote: > Hello Stephen > > Thank you for writing this page! Some comments/questions below. > > On Tue, 8 Dec 2020 at 22:51, Stephen Kitt wrote: > > > > This documents close_range(2) based on information in > >

Re: [PATCH] signal: propagate __user annotations properly

2020-12-07 Thread Christian Brauner
On Mon, Dec 07, 2020 at 01:36:10PM +0100, Lukas Bulwahn wrote: > Commit 3eb39f47934f ("signal: add pidfd_send_signal() syscall") introduced > copy_siginfo_from_user_any(), but missed to add the __user annotation to > the user pointer that is passed as second argument. > > Hence, when

Re: [PATCH pidfd] signal: Add missing __user annotation to copy_siginfo_from_user_any

2020-12-07 Thread Christian Brauner
On Mon, Dec 07, 2020 at 01:02:52AM +0100, Jann Horn wrote: > copy_siginfo_from_user_any() takes a userspace pointer as second > argument; annotate the parameter type accordingly. > > Signed-off-by: Jann Horn > --- > I'm messing around with clang's version of __user annotation checking > and it

Re: [PATCH v3 0/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-12-04 Thread Christian Brauner
On Wed, Nov 18, 2020 at 11:47:44AM +0100, Giuseppe Scrivano wrote: > When the new flag is used, close_range will set the close-on-exec bit > for the file descriptors instead of close()-ing them. > > It is useful for e.g. container runtimes that want to minimize the > number of syscalls used after

Re: linux-next: Signed-off-by missing for commit in the pidfd tree

2020-12-03 Thread Christian Brauner
On Thu, Dec 03, 2020 at 07:59:11AM +1100, Stephen Rothwell wrote: > Hi all, > > Commits > > 440ec82ebed2 ("selftests: openat2: add RESOLVE_ conflict test") > 295983402a1a ("openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT") > > are missing a Signed-off-by from their committers. Thank you!

Re: [PATCH v2 0/2] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT

2020-12-02 Thread Christian Brauner
On Wed, Oct 28, 2020 at 10:50:42AM +1100, Aleksa Sarai wrote: > This was an oversight in the original implementation, as it makes no > sense to specify both scoping flags to the same openat2(2) invocation > (before this patch, the result of such an invocation was equivalent to > RESOLVE_IN_ROOT

Re: [PATCH] selftests/clone3: Add gun99 to compile in Makefile.

2020-11-26 Thread Christian Brauner
or (int i = 0; i < 10; i++) { > ^ > test_core.c:87:2: note: use option -std=c99 or -std=gnu99 to compile > your code > > Signed-off-by: Xingxing Su > --- Acked-by: Christian Brauner Seems alright to me and apparently some selftests already set. Though another option would be to

Re: [PATCH] syscalls: Document OCI seccomp filter interactions & workaround

2020-11-24 Thread Christian Brauner
On Tue, Nov 24, 2020 at 06:15:36PM +0100, Greg KH wrote: > On Tue, Nov 24, 2020 at 06:06:38PM +0100, Jann Horn wrote: > > +seccomp maintainers/reviewers > > [thread context is at > > https://lore.kernel.org/linux-api/87lfer2c0b@oldenburg2.str.redhat.com/ > > ] > > > > On Tue, Nov 24, 2020 at

Re: [PATCH] syscalls: Document OCI seccomp filter interactions & workaround

2020-11-24 Thread Christian Brauner
On Tue, Nov 24, 2020 at 01:08:20PM +0100, Florian Weimer wrote: > This documents a way to safely use new security-related system calls > while preserving compatibility with container runtimes that require > insecure emulation (because they filter the system call by default). > Admittedly, it is

Re: [PATCH v5 2/2] NFSv4: Refactor to use user namespaces for nfs4idmap

2020-11-19 Thread Christian Brauner
Sorry for chiming in, but Sargun, Alban and I had a chat about this yesterday and so I took a closer at this patch and NFS today. On Thu, Nov 12, 2020 at 02:09:52AM -0800, Sargun Dhillon wrote: > In several patches work has been done to enable NFSv4 to use user > namespaces: > 58002399da65:

Re: linux-next: Signed-off-by missing for commit in the pidfd-fixes tree

2020-11-19 Thread Christian Brauner
On Thu, Nov 19, 2020 at 07:34:00AM +1100, Stephen Rothwell wrote: > Hi all, > > Commit > > 59b617b192f5 ("nsproxy: use put_nsproxy() in switch_task_namespaces()") > > is missing a Signed-off-by from its committer. Thanks for reporting this. This is now fixed. Christian

Re: [PATCH] nsproxy: use put_nsproxy() in switch_task_namespaces()

2020-11-18 Thread Christian Brauner
On Mon, Nov 16, 2020 at 02:00:54AM +0800, Hui Su wrote: > Use put_nsproxy() instead of ' > if (atomic_dec_and_test(>count)) { > free_nsproxy(ns); > }' in switch_task_namespaces(). > > and remove the whitespace by the way. > > Signed-off-by: Hui Su > --

Re: [PATCH 1/1] RFC: add pidfd_send_signal flag to reclaim mm while killing a process

2020-11-18 Thread Christian Brauner
On Fri, Nov 13, 2020 at 03:55:39PM -0800, Andrew Morton wrote: > On Fri, 13 Nov 2020 09:34:48 -0800 Suren Baghdasaryan > wrote: > > > When a process is being killed it might be in an uninterruptible sleep > > which leads to an unpredictable delay in its memory reclaim. In low memory > >

Re: [PATCH v2] namespace: make timens_on_fork() return nothing

2020-11-18 Thread Christian Brauner
Signed-off-by: Hui Su > --- Acked-by: Christian Brauner Applied to: https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=time_namespace on top of the other timens patches I've queued up already. Thanks! Christian

Re: [PATCH v2 0/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-11-18 Thread Christian Brauner
On Thu, Oct 29, 2020 at 05:47:53PM +0100, Giuseppe Scrivano wrote: > Hi Christian, > > Christian Brauner writes: > > > On Mon, Oct 19, 2020 at 12:26:52PM +0200, Giuseppe Scrivano wrote: > >> When the new flag is used, close_range will set the close-on-exec bit &g

Re: [PATCH] selftests/cgroup: Fix build on older distros

2020-11-04 Thread Christian Brauner
f-by: Michael Ellerman > > --- Thanks Michael for taking care fo this. Much appreciated. I think with the fix that Sachin pointed out this should work out fine! Once that's fixed up: Acked-by: Christian Brauner Thanks! Christian

Re: [PATCH 1/3] seccomp: Return from SECCOMP_IOCTL_NOTIF_RECV when children are gone

2020-11-03 Thread Christian Brauner
On Mon, Nov 02, 2020 at 09:37:04PM +0100, Jann Horn via Containers wrote: > At the moment, the seccomp notifier API is hard to use without combining > it with APIs like poll() or epoll(); if all target processes have gone > away, the polling APIs will raise an error indication on the file >

Re: [RFC PATCH v1 1/4] Increase size of ucounts to atomic_long_t

2020-11-02 Thread Christian Brauner
On Mon, Nov 02, 2020 at 05:50:30PM +0100, Alexey Gladkov wrote: > In order to be able to use ucounts for rlimits, the size must be increased. > For example user_struct.mq_bytes (RLIMIT_MSGQUEUE) is unsigned long. I don't have any issues with this change I just wonder what the exact reason is.

Re: [RFC PATCH v1 0/4] Per user namespace rlimits

2020-11-02 Thread Christian Brauner
On Mon, Nov 02, 2020 at 05:50:29PM +0100, Alexey Gladkov wrote: > Preface > --- > These patches are for binding the rlimits to a user in the user namespace. > This patch set can be applied on top of: > > git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > v5.8-2-g43e210d68200 > >

Re: [PATCH 32/34] overlayfs: handle idmapped lower directories

2020-10-30 Thread Christian Brauner
On Fri, Oct 30, 2020 at 01:10:52PM +0200, Amir Goldstein wrote: > [reducing CC list for overlayfs specific comments] > > On Thu, Oct 29, 2020 at 2:41 AM Christian Brauner > wrote: > > > > As an overlay filesystem overlayfs can be mounted on top of other > > f

Re: [PATCH v2 0/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-29 Thread Christian Brauner
On Mon, Oct 19, 2020 at 12:26:52PM +0200, Giuseppe Scrivano wrote: > When the new flag is used, close_range will set the close-on-exec bit > for the file descriptors instead of close()-ing them. > > It is useful for e.g. container runtimes that want to minimize the > number of syscalls used after

Re: [PATCH] selftests/ftrace: Use $FUNCTION_FORK to reference kernel fork function

2020-10-29 Thread Christian Brauner
xamining /proc/kallsyms. > > Note, available_filter_functions could also be used, but because some tests > should be able to pass without function tracing enabled, it could not be > used. > > Fixes: eea11285dab3 ("tracing: switch to kernel_clone()") > Signed-off-by: Steven Rostedt (VMware) Thank you! Acked-by: Christian Brauner

Re: For review: seccomp_user_notif(2) manual page [v2]

2020-10-29 Thread Christian Brauner
On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: > Hi all (and especially Tycho and Sargun), > > Following review comments on the first draft (thanks to Jann, Kees, > Christian and Tycho), I've made a lot of changes to this page. > I've also added a few FIXMEs relating

Re: [PATCH v5 0/3] time namespace aware system boot time

2020-10-29 Thread Christian Brauner
t the boot timestamp in > 'fs/proc/stat.c' as result of the discussion with Andrei and Thomas. > > v2 Changes: > Fixed compile errors with TIME_NS not set in config Thank you Michael, Acked-by: Christian Brauner As discussed with Thomas, I'm picking this up now! Thanks! Christian

Re: [PATCH v2 2/2] selftests: add tests for CLOSE_RANGE_CLOEXEC

2020-10-20 Thread Christian Brauner
First, thank you for the selftests. That's great to see! Could you please add a short explanation what you're testing here to the commit message? On Mon, Oct 19, 2020 at 12:26:54PM +0200, Giuseppe Scrivano wrote: > Signed-off-by: Giuseppe Scrivano > --- >

Re: [PATCH v2 1/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-20 Thread Christian Brauner
On Mon, Oct 19, 2020 at 12:26:53PM +0200, Giuseppe Scrivano wrote: > When the flag CLOSE_RANGE_CLOEXEC is set, close_range doesn't > immediately close the files but it sets the close-on-exec bit. > > It is useful for e.g. container runtimes that usually install a > seccomp profile "as late as

Re: [RFC][PATCH] userns: Limit process in a user namespace to what the creator is allowed

2020-10-20 Thread Christian Brauner
On Mon, Oct 19, 2020 at 03:07:02PM -0500, Eric W. Biederman wrote: > Ordinary unix permissions and posix acls have the ability to > expression that processes show uid or gid match have fewer permissions > than processes without matches that use the other permissions. I'm stumbling a bit reading

Re: LPC 2020 Hackroom Session: summary and next steps for isolated user namespaces

2020-10-18 Thread Christian Brauner
On Sat, Oct 17, 2020 at 11:51:22AM -0500, Eric W. Biederman wrote: > "Enrico Weigelt, metux IT consult" writes: > > > On 30.08.20 16:39, Christian Brauner wrote: > > > > Hi Christian, > > > >> P1. Isolated id mappings can only be guaranteed to

[GIT PULL] thread changes for v5.10

2020-10-14 Thread Christian Brauner
--- threads-v5.10 ---- Christian Brauner (5): exit: support non-blocking pidfds pidfd: support PIDFD_NONBLOCK in pidfd_open() tests: port pidfd_wait to kselftest harness tests: add waitid() tests for non-

[GIT PULL] kernel_clone() for v5.10

2020-10-14 Thread Christian Brauner
the signed kernel-clone-v5.9 tag. Thanks! Christian kernel-clone-v5.9 ---- Christian Brauner (11): fork: introduce kernel_clone() h8300: switch to kernel_clone()

Re: [PATCH 1/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-13 Thread Christian Brauner
On Tue, Oct 13, 2020 at 10:09:25PM +0100, Al Viro wrote: > On Tue, Oct 13, 2020 at 04:06:08PM +0200, Giuseppe Scrivano wrote: > > + spin_lock(_fds->file_lock); > > + fdt = files_fdtable(cur_fds); > > + cur_max = fdt->max_fds - 1; > > + max_fd = min(max_fd,

Re: [PATCH 1/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-13 Thread Christian Brauner
On Tue, Oct 13, 2020 at 11:04:21PM +0200, Rasmus Villemoes wrote: > On 13/10/2020 22.54, Christian Brauner wrote: > > On Tue, Oct 13, 2020 at 04:06:08PM +0200, Giuseppe Scrivano wrote: > > > > Hey Guiseppe, > > > > Thanks for the patch! > > > &

Re: [PATCH 1/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC

2020-10-13 Thread Christian Brauner
On Tue, Oct 13, 2020 at 04:06:08PM +0200, Giuseppe Scrivano wrote: Hey Guiseppe, Thanks for the patch! > When the flag CLOSE_RANGE_CLOEXEC is set, close_range doesn't > immediately close the files but it sets the close-on-exec bit. Hm, please expand on the use-cases a little here so people

Re: [PATCH] binder: fix UAF when releasing todo list

2020-10-13 Thread Christian Brauner
the binder_work element > must not be accessed after releasing the inner_proc_lock while > processing the todo list elements since another thread might be > handling a deref on the node containing the binder_work element > leading to the node being freed. > > Signed-off-by: Todd Kjos > --- Thanks! Acked-by: Christian Brauner

Re: [PATCH v2 2/4] time: make getboottime64 aware of time namespace

2020-10-13 Thread Christian Brauner
On Sat, Oct 10, 2020 at 12:19:14AM -0700, Andrei Vagin wrote: > On Fri, Oct 09, 2020 at 03:28:15PM +0200, Christian Brauner wrote: > > On Thu, Oct 08, 2020 at 07:39:42AM +0200, Michael Weiß wrote: > > > getboottime64() provides the time stamp of system boot. In case of >

Re: [PATCH v2 2/4] time: make getboottime64 aware of time namespace

2020-10-09 Thread Christian Brauner
On Thu, Oct 08, 2020 at 07:39:42AM +0200, Michael Weiß wrote: > getboottime64() provides the time stamp of system boot. In case of > time namespaces, the offset to the boot time stamp was not applied > earlier. However, getboottime64 is used e.g., in /proc/stat to print > the system boot time to

Re: [PATCH v2 0/4] time namespace aware system boot time

2020-10-09 Thread Christian Brauner
On Thu, Oct 08, 2020 at 07:39:40AM +0200, Michael Weiß wrote: > Time namespaces make it possible to virtualize time inside of > containers, e.g., it is feasible to reset the uptime of a container > to zero by setting the time namespace offset for boottime to the > negated current value of the

Re: [PATCH v2 07/11] drivers/android/binder: convert stats, transaction_log to counter_atomic32

2020-10-09 Thread Christian Brauner
on doesn't change the overflow wrap around behavior. > > Signed-off-by: Shuah Khan > Reviewed-by: Joel Fernandes (Google) > Reviewed-by: Kees Cook > --- Thanks! Reviewed-by: Christian Brauner

Re: [PATCH 00/13] selftests fixes

2020-10-09 Thread Christian Brauner
On Thu, Oct 08, 2020 at 03:26:20PM +0300, Tommi Rantala wrote: > Hi, small fixes to issues I hit with selftests. > > Tommi Rantala (13): > selftests: filter kselftest headers from command in lib.mk > selftests: pidfd: fix compilation errors due to wait.h > selftests: add vmaccess to

Re: [PATCH 01/13] selftests: filter kselftest headers from command in lib.mk

2020-10-09 Thread Christian Brauner
1056d3d2c97e ("selftests: enforce local header dependency in lib.mk") > Signed-off-by: Tommi Rantala > --- Thanks! Reviewed-by: Christian Brauner

Re: [PATCH 09/13] selftests: android: fix multiple definition of sock_name

2020-10-09 Thread Christian Brauner
moved from the kernel soon but this seems like an ok bugfix. Thanks! Acked-by: Christian Brauner

Re: [PATCH 07/13] selftests: pidfd: add CONFIG_CHECKPOINT_RESTORE=y to config

2020-10-09 Thread Christian Brauner
On Thu, Oct 08, 2020 at 03:26:27PM +0300, Tommi Rantala wrote: > kcmp syscall is used in pidfd_getfd_test.c, so add > CONFIG_CHECKPOINT_RESTORE=y to config to ensure kcmp is available. > > Signed-off-by: Tommi Rantala > --- Good catch, thanks! Acked-by: Christian Brauner

Re: [PATCH 08/13] selftests: pidfd: drop needless linux/kcmp.h inclusion in pidfd_setns_test.c

2020-10-09 Thread Christian Brauner
On Thu, Oct 08, 2020 at 03:26:28PM +0300, Tommi Rantala wrote: > kcmp is not used in pidfd_setns_test.c, so do not include > > Signed-off-by: Tommi Rantala > --- Thanks! Acked-by: Christian Brauner

Re: [PATCH 06/13] selftests: pidfd: skip test on kcmp() ENOSYS

2020-10-09 Thread Christian Brauner
On Thu, Oct 08, 2020 at 03:26:26PM +0300, Tommi Rantala wrote: > Skip test if kcmp() is not available, for example if kernel is compiled > without CONFIG_CHECKPOINT_RESTORE=y. > > Signed-off-by: Tommi Rantala > --- Good catch, thanks! Acked-by: Christian Brauner

Re: [PATCH 05/13] selftests: pidfd: use ksft_test_result_skip() when skipping test

2020-10-09 Thread Christian Brauner
d > namespace not permitted > # Totals: pass:7 fail:0 xfail:0 xpass:0 skip:1 error:0 > > Signed-off-by: Tommi Rantala > --- Thanks, I never got around to fixing this myself. Acked-by: Christian Brauner

Re: [PATCH 03/13] selftests: add vmaccess to .gitignore

2020-10-09 Thread Christian Brauner
ks") > Signed-off-by: Tommi Rantala > --- Thanks! Reviewed-by: Christian Brauner

Re: [PATCH 04/13] selftests/harness: prettify SKIP message whitespace again

2020-10-09 Thread Christian Brauner
ot;selftests/harness: Refactor XFAIL into SKIP") > Signed-off-by: Tommi Rantala > --- Thanks! Reviewed-by: Christian Brauner

Re: [PATCH] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT

2020-10-09 Thread Christian Brauner
) syscall") > Signed-off-by: Aleksa Sarai > Acked-by: Christian Brauner > Cc: # v5.6+ > --- Thanks! This is a good fix imho. Christian

Re: selftests: pidfd: pidfd_wait hangs on linux next kernel on all devices

2020-10-09 Thread Christian Brauner
On Fri, Oct 02, 2020 at 11:01:34PM +0530, Naresh Kamboju wrote: > On Thu, 24 Sep 2020 at 21:51, Christian Brauner > wrote: > > > > On Thu, Sep 24, 2020 at 04:33:17PM +0200, Christian Brauner wrote: > > > On Wed, Sep 23, 2020 at 07:52:05PM +0530, Naresh Kamboju wrot

Re: [PATCH 12/13] selftests: clone3: use SKIP instead of XFAIL

2020-10-09 Thread Christian Brauner
Tommi Rantala > --- Thanks! Acked-by: Christian Brauner

Re: [PATCH 11/13] selftests: core: use SKIP instead of XFAIL in close_range_test.c

2020-10-09 Thread Christian Brauner
Tommi Rantala > --- Thanks! Acked-by: Christian Brauner

Re: [PATCH 13/13] selftests: binderfs: use SKIP instead of XFAIL

2020-10-09 Thread Christian Brauner
Tommi Rantala > --- Thanks! Acked-by: Christian Brauner

Re: [PATCH 02/13] selftests: pidfd: fix compilation errors due to wait.h

2020-10-09 Thread Christian Brauner
; numeric constant >17 | #define P_ALL 0 > |^ > > Signed-off-by: Tommi Rantala > --- Thanks! Acked-by: Christian Brauner

Re: [PATCH v3 -next] binder: simplify the return expression of binder_mmap

2020-10-02 Thread Christian Brauner
On Tue, Sep 29, 2020 at 09:52:16AM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin > --- Thanks! Acked-by: Christian Brauner

Re: For review: seccomp_user_notif(2) manual page

2020-10-01 Thread Christian Brauner
On Thu, Oct 01, 2020 at 10:58:50AM -0600, Tycho Andersen wrote: > On Thu, Oct 01, 2020 at 05:47:54PM +0200, Jann Horn via Containers wrote: > > On Thu, Oct 1, 2020 at 2:54 PM Christian Brauner > > wrote: > > > On Wed, Sep 30, 2020 at 05:53:46PM +0200, Jann H

Re: For review: seccomp_user_notif(2) manual page

2020-10-01 Thread Christian Brauner
On Thu, Oct 01, 2020 at 05:47:54PM +0200, Jann Horn wrote: > On Thu, Oct 1, 2020 at 2:54 PM Christian Brauner > wrote: > > On Wed, Sep 30, 2020 at 05:53:46PM +0200, Jann Horn via Containers wrote: > > > On Wed, Sep 30, 2020 at 1:07 PM Michael Kerrisk (man-pages) > &

Re: For review: seccomp_user_notif(2) manual page

2020-10-01 Thread Christian Brauner
On Wed, Sep 30, 2020 at 05:53:46PM +0200, Jann Horn via Containers wrote: > On Wed, Sep 30, 2020 at 1:07 PM Michael Kerrisk (man-pages) > wrote: > > I knew it would be a big ask, but below is kind of the manual page > > I was hoping you might write [1] for the seccomp user-space notification > >

Re: For review: seccomp_user_notif(2) manual page

2020-10-01 Thread Christian Brauner
[I'm on vacation so I'll just give this a quick glance for now.] On Wed, Sep 30, 2020 at 01:07:38PM +0200, Michael Kerrisk (man-pages) wrote: > Hi Tycho, Sargun (and all), > > I knew it would be a big ask, but below is kind of the manual page > I was hoping you might write [1] for the seccomp

Re: selftests: pidfd: pidfd_wait hangs on linux next kernel on all devices

2020-09-24 Thread Christian Brauner
On Thu, Sep 24, 2020 at 04:33:17PM +0200, Christian Brauner wrote: > On Wed, Sep 23, 2020 at 07:52:05PM +0530, Naresh Kamboju wrote: > > selftests: pidfd: pidfd_wait hangs on linux next kernel on x86_64, > > i386 and arm64 Juno-r2 > > These devices are using NFS mounted root

Re: selftests: pidfd: pidfd_wait hangs on linux next kernel on all devices

2020-09-24 Thread Christian Brauner
On Wed, Sep 23, 2020 at 07:52:05PM +0530, Naresh Kamboju wrote: > selftests: pidfd: pidfd_wait hangs on linux next kernel on x86_64, > i386 and arm64 Juno-r2 > These devices are using NFS mounted rootfs. > I have tested pidfd testcases independently and all test PASS. > > The Hang or exit from

Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

2020-09-21 Thread Christian Brauner
On Mon, Sep 21, 2020 at 04:55:37PM +0200, Michal Hocko wrote: > On Mon 21-09-20 16:43:55, Christian Brauner wrote: > > On Mon, Sep 21, 2020 at 10:38:47AM -0400, Tejun Heo wrote: > > > Hello, > > > > > > On Mon, Sep 21, 2020 at 04:28:34PM +0200, Mich

Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

2020-09-21 Thread Christian Brauner
On Mon, Sep 21, 2020 at 10:38:47AM -0400, Tejun Heo wrote: > Hello, > > On Mon, Sep 21, 2020 at 04:28:34PM +0200, Michal Hocko wrote: > > Fundamentaly CLONE_INTO_CGROUP is similar to regular fork + move to the > > target cgroup after the child gets executed. So in principle there > > shouldn't be

Re: [PATCH 1/4] mm: Trial do_wp_page() simplification

2020-09-21 Thread Christian Brauner
On Mon, Sep 21, 2020 at 03:42:00PM +0200, Michal Hocko wrote: > [Cc Tejun and Christian - this is a part of a larger discussion which is > not directly related to this particular question so let me trim the > original email to the bare minimum.] > > On Fri 18-09-20 12:40:32, Peter Xu wrote: >

<    1   2   3   4   5   6   7   8   9   10   >