On 9/25/25 12:35 PM, Mehdi Ben Hadj Khelifa wrote:
-Change only variable types for correct sign comparisons
Signed-off-by: Mehdi Ben Hadj Khelifa
Pls write some better commit messages and not just copy/paste the same $subj/
message every time; proper sentences w/o the weird " -" indent. Also
On 9/24/25 9:57 PM, Mehdi Ben Hadj Khelifa wrote:
-Change all the source files and the corresponding headers
to having matching sign comparisons.
Signed-off-by: Mehdi Ben Hadj Khelifa
---
Changelog:
Changes since v1:
- Fix CI failed builds where it failed due to do missing .c and
.h files in m
On Sat, Sep 20, 2025 at 4:16 PM Peng Fan wrote:
>
> Add an entry for the i.MX remoteproc driver
>
> Signed-off-by: Peng Fan
Acked-by: Daniel Baluta
ruct because is used with imx_dsp_rproc.
With that,
Reviewed-by: Daniel Baluta
On Fri, Sep 19, 2025 at 5:02 AM Peng Fan wrote:
>
> Hi Daniel,
>
> > Subject: Re: [PATCH 1/5] remoteproc: imx_rproc: Simplify clock enable
> > logic using dcfg flags
> > > + /* Remote core is under control of Linux or clock is not
> > > + managed by fi
gement behavior.
>
> Signed-off-by: Peng Fan
Reviewed-by: Daniel Baluta
vailable.
>
> Also, the dcfg->method check with IMX_RPROC_SCU_API is removed.
>
> No functional changes.
>
> Signed-off-by: Peng Fan
Reviewed-by: Daniel Baluta
On Thu, Sep 18, 2025 at 2:51 PM Peng Fan wrote:
>
> Simplify the clock enable logic by removing the dedicated
> imx_rproc_clk_enable() function and integrate the clock handling directly
> into the probe function to simplify the code.
>
> Add a new IMX_RPROC_NEED_CLKS flag in dcfg to indicate wheth
ndling path and remove path.
>
> Tested on
> i.MX8MP-EVK, i.MX8MM-EVK, i.MX93-11x11-EVK, i.MX8QXP-MEK, and i.MX8ULP-EVK.
>
> There is still a 3rd patchset to do further cleanup. After this patchset
> get reviewed, the 3rd patchset will be posted out to list.
>
> Thanks to Daniel a
> >> Can you remove 'method' in data struct also?
> >
> >The method is used in other places and other purpose, imx_rproc_detach
> >imx_rproc_put_scu, imx_rproc_remove, it is also referred
> >imx_dsp_rproc.c.
> >
> >Could we keep it for now?
>
> The method could not be removed from the data struct
n the hypothetical scenario where an attacker
can trigger this panic but can't insert custom modules,
the worst that could happen is a DoS
caused by future module insertion / removal attempts.
Signed-off-by: Daniel Kirschten
---
I hope that the wording is clear enough now about this not bei
lat_ops to wrap platform start,stop,detect_mode.
> Each imx_rproc_dcfg data structure is assigned a ops pointer.
> The common imx_rproc_{start,stop}() directly invokes the plat ops, no
> need the switch-case.
> mmio/smc/scu_api ops are included.
> No functional changes.
>
On 29/08/2025 10.49, Jinchao Wang wrote:
> Make module signature rejection messages more visible by using pr_err
> instead of pr_notice.
Can you elaborate a bit more? Why is this needed?
IMO, I don't think making it more visible is enough rational to increase the
level.
> >Please give detailed suggestions, but not a general comment.
>
>
> @Daniel, @Frank — since you've reviewed and R-b'd this patchset, do you
> have thoughts on the latest feedback from Mathieu? Would you agree that
> further simplification is needed, or is t
On 29/08/2025 10.49, Jinchao Wang wrote:
> Include reason in error message when force loading is disabled.
>
> Signed-off-by: Jinchao Wang
> ---
> kernel/module/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index c66b26184936..e748
On 24/08/2025 08.49, Daniel Gomez wrote:
> This includes a fix as part of the KSPP (Kernel Self Protection Project) to
> replace the deprecated and unsafe strcpy() calls in the kernel parameter
> string
> handler and sysfs parameters for built-in modules. Single commit, no
The following changes since commit 8f5ae30d69d7543eee0d70083daf4de8fe15d585:
Linux 6.17-rc1 (2025-08-10 19:41:16 +0300)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git
tags/modules-6.17-rc3.fixes
for you to fetch changes up to 5eb4b9a
Enjoy!
Daniel
ve a bug already reported.
How should we fix this:
1) Add res->flags = IORESOURCE_MEM; in of_reserved_mem_region_to_resource
OR
2) Use devm_ioremap_wc instead of devm_ioremap_resource_wc.
thanks,
Daniel.
Daniel.
copystring);
>> @@ -841,7 +842,7 @@ static void __init param_sysfs_builtin(void)
>> dot = strchr(kp->name, '.');
>> if (!dot) {
>> /* This happens for core_param() */
>> -strcpy(modname, "kernel");
>> +strscpy(modname, "kernel");
>> name_len = 0;
>> } else {
>> name_len = dot - kp->name + 1;
>
> Reviewed-by: Petr Pavlu
>
Reviewed-by: Daniel Gomez
The following changes since commit 260f6f4fda93c8485c8037865c941b42b9cba5d2:
Merge tag 'drm-next-2025-07-30' of https://gitlab.freedesktop.org/drm/kernel
(2025-07-30 19:26:49 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git/
tag
prefix length check
commit: bdc877ba6b7ff1b6d2ebeff11e63da4a50a54854
[4/5] tracing: Replace MAX_PARAM_PREFIX_LEN with MODULE_NAME_LEN
commit: a7c54b2b41dd1f6ec780e7fbfb13f70c64c9731d
[5/5] module: Rename MAX_PARAM_PREFIX_LEN to __MODULE_NAME_LEN
commit: 40a826bd6c82ae45cfd3a19cd2a60a10f56b74c0
Best regards,
--
Daniel Gomez
Signed-off-by: Shengjiu Wang
Changes looks good to me:
Reviewed-by: Daniel Baluta
I've tested it with Zephyr synchronization samples inducing a crash
via debugfs interface. App
can recover correctly.
> + static_assert(sizeof(""prefix) - 1 <= __MODULE_NAME_LEN); \
> static const char __param_str_##name[] = prefix #name; \
> static struct kernel_param __moduleparam_const __param_##name \
> __used __section("__param") \
LGTM,
Reviewed-by: Daniel Gomez
t char this_mod[] = "__this_module";
> - char modname[MAX_PARAM_PREFIX_LEN + sizeof(this_mod) + 2];
> + char modname[MODULE_NAME_LEN + sizeof(this_mod) + 2];
> unsigned long val;
> int n;
>
LGTM,
Reviewed-by: Daniel Gomez
On 21/07/2025 11.21, Petr Pavlu wrote:
> On 7/17/25 9:23 PM, Daniel Gomez wrote:
>> On 30/06/2025 16.32, Petr Pavlu wrote:
>>> The moduleparam code allows modules to provide their own definition of
>>> MODULE_PARAM_PREFIX, instead of using the default KBUILD_
5ECA 5D0A 306C
All keys used for the above files and repositories can be found on the
following git repository:
git://git.kernel.org/pub/scm/docs/kernel/pgpkeys.git
Enjoy!
Daniel
Changes from v6.12.28-rt10:
---
Daniel Wagner (1):
v6.12.39-rt11
---
localversion-rt | 2 +-
1 file chang
the Fixes tag.
Also, allow me on more day on Monday to test this patch.
Thanks,
Daniel.
>
> Signed-off-by: Shengjiu Wang
> ---
> drivers/remoteproc/imx_dsp_rproc.c | 43 +++---
> 1 file changed, 27 insertions(+), 16 deletions(-)
>
> diff --git a/drive
On 30/06/2025 16.32, Petr Pavlu wrote:
> The moduleparam code allows modules to provide their own definition of
> MODULE_PARAM_PREFIX, instead of using the default KBUILD_MODNAME ".".
>
> Commit 730b69d22525 ("module: check kernel param length at compile time,
> not runtime") added a check to ensu
static struct {
> - char name[MODULE_NAME_LEN + 1];
> + char name[MODULE_NAME_LEN];
> char taints[MODULE_FLAGS_BUF_SIZE];
> } last_unloaded_module;
>
LGTM,
Reviewed-by: Daniel Gomez
new code not only returns the correct errors
indicated in delete_module(2) but also checks for the case user passes an
empty string and the case where NUL char is not found when copying (with len
== MODULE_NAME_LEN) as well as it's using the correct length (MODULE_NAME_LEN)
for copying.
Reviewed-by: Daniel Gomez
On 11/07/2025 15.51, Thomas WeiÃschuh wrote:
> On Fri, Jul 11, 2025 at 03:39:04PM +0200, Daniel Gomez wrote:
>>
>> On Fri, 11 Jul 2025 15:31:35 +0200, Thomas Weißschuh wrote:
>>> Code using IS_ENABLED(CONFIG_MODULES) as a C expression may need access
>>> to th
4d878577e2b8c46ed7b6be5f5459
[2/3] module: make structure definitions always visible
commit: 02281b559cd1fdfdc8f7eb05bbbe3ab7b35246f0
[3/3] kunit: test: Drop CONFIG_MODULE ifdeffery
commit: dffcba8acea3a80b3478750ac32f17bd5345b68e
Best regards,
--
Daniel Gomez
r errors can be detected faster.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Daniel Gomez
On 11/07/2025 08.29, Thomas WeiÃschuh wrote:
> On Mon, Jul 07, 2025 at 09:11:05PM +0200, Daniel Gomez wrote:
>> On 12/06/2025 16.53, Thomas WeiÃschuh wrote:
>>> To write code that works with both CONFIG_MODULES=y and CONFIG_MODULES=n
>>> it is convenient to use &qu
> This is a much better approach. During my last review I said that I would not
> move forward with this work until Daniel or Iuliana provide their R-B and yet,
> they have not been added to the recipient list.
Thanks Mathieu, we will have a look at this asap.
We are
On 08/07/2025 22.21, Linus Torvalds wrote:
> On Tue, 8 Jul 2025 at 12:38, Daniel Gomez wrote:
>>
>> Petr and Sebastian went down to the archive history (before Git) and
>> found the commit that broke it b3b91325f3c7 ("Don't relocate
>> non-allocated region
af1ccf546e5f2915fbbde26841db43a971d81cf3:
MAINTAINERS: update Daniel Gomez's role and email address (2025-07-08
20:52:30 +0200)
Modules fixes for 6.16-rc6
This includes 2 fixes: one introduced in the current release cycle (v6.1
On 12/06/2025 16.53, Thomas WeiÃschuh wrote:
> To write code that works with both CONFIG_MODULES=y and CONFIG_MODULES=n
> it is convenient to use "if (IS_ENABLED(CONFIG_MODULES))" over raw #ifdef.
> The code will still fully typechecked but the unreachable parts are
> discarded by the compiler. Thi
t with CONFIG_PACKET=m.
Enabling CONFIG_PACKET=y ensures that sockaddr_ll is available in vmlinux,
allowing it to be captured in the generated vmlinux.h for bpf selftests.
Reported-by: Sachin P Bappalige
Signed-off-by: Saket Kumar Bhaskar
Acked-by: Daniel Borkmann
On Fri, 04 Jul 2025 21:39:59 +0200, Daniel Gomez wrote:
> Update Daniel Gomez's modules reviewer role to maintainer. This is
> according to the plan [1][2] of scaling with more reviewers for modules
> (for the incoming Rust support [3]) and rotate [4] every 6 months.
>
&g
From: Daniel Gomez
Update Daniel Gomez's modules reviewer role to maintainer. This is
according to the plan [1][2] of scaling with more reviewers for modules
(for the incoming Rust support [3]) and rotate [4] every 6 months.
[1] Link:
https://lore.kernel.org/linux-modules/
zspanzx4
From: Daniel Gomez
On Wed, 18 Jun 2025 14:26:25 +0200, Petr Pavlu wrote:
> The first patch is an actual fix. The second patch is a minor related
> cleanup.
>
> Changes since v1 [1]:
> - Initialize t to MOD_MEM_NUM_TYPES in move_module(), instead of assigning
> the value la
On 18/06/2025 14.26, Petr Pavlu wrote:
> The function move_module() uses the variable t to track how many memory
> types it has allocated and consequently how many should be freed if an
> error occurs.
>
> The variable is initially set to 0 and is updated when a call to
> module_memory_alloc() fai
ymore, so the structure can be made internal.
>
> Signed-off-by: Thomas Weißschuh
Reviewed-by: Daniel Gomez
,7 +2776,7 @@ static int move_module(struct module *mod, struct
> load_info *info)
> return 0;
> out_err:
> module_memory_restore_rox(mod);
> - for (t--; t >= 0; t--)
> + while (t--)
> module_memory_free(mod, t);
> if (codetag_section_found)
> codetag_free_module_sections(mod);
Reviewed-by: Daniel Gomez
NUM_TYPES;
> - int ret = -ENOMEM;
> bool codetag_section_found = false;
>
> for_each_mod_mem_type(type) {
Reviewed-by: Daniel Gomez
>> One thing though, we are "releasing" the memory even if we have skipped the
>> allocation in the first place. So, I think it would make sense to release
>> only
>> for the types we have actually allocated. What do you think?
>
> I noticed this too, specifically because move_module() is inco
> Do you mean the following, or something else:
>
> static int move_module(struct module *mod, struct load_info *info)
> {
> int i;
> enum mod_mem_type t = MOD_MEM_NUM_TYPES;
> int ret;
> bool codetag_section_found = false;
>
> for_each_mod_mem_type(type) {
>
es on pre-Linux software(U-Boot) to do
> M7 TCM ECC initialization. In future, we could add the support in Linux
> to decouple U-Boot and Linux.
>
> Signed-off-by: Peng Fan
Reviewed-by: Daniel Baluta
On Fri, Jun 6, 2025 at 4:57 AM Peng Fan (OSS) wrote:
>
> From: Peng Fan
>
> i.MX95 has a System Manager(SM) core runs the System Control Management
> Interface(SCMI) firmware. Vendor extenions are implemented in the
> firmware, Logical Machine Management(LMM) protocol to manage
> Logical Machines
> This seems to be off by one. For instance, if the loop reaches the last
> valid type in mod_mem_type, MOD_INIT_RODATA, and successfully allocates
> its memory, the variable t gets set to MOD_INIT_RODATA. Subsequently, if
> an error occurs later in move_module() and control is transferred to
> out
ed-off-by: Petr Pavlu
Reviewed-by: Daniel Gomez
> ---
> kernel/module/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index 322b38c0a782..06511607075c 100644
> --- a/kernel/module/main.c
> +++ b/kernel
On 07/06/2025 18.16, Petr Pavlu wrote:
> The function move_module() uses the variable t to track how many memory
> types it has allocated and consequently how many should be freed if an
> error occurs.
>
> The variable is initially set to 0 and is updated when a call to
> module_memory_alloc() fai
Hi Peng,
Thanks a lot for the patches. Comments inline:
On Wed, Jun 4, 2025 at 5:36 AM Peng Fan (OSS) wrote:
>
> From: Peng Fan
>
> i.MX95 features a Cortex-M33 core, six Cortex-A55 cores, and
> one Cortex-M7 core. The System Control Management Interface(SCMI)
> firmware runs on the M33 core. T
On Wed, Jun 4, 2025 at 5:37 AM Peng Fan (OSS) wrote:
>
> From: Peng Fan
>
> Add imx_rproc_cfg_imx95_m7 and address(TCM and DDR) mapping
> Add i.MX95 of_device_id entry
>
> Signed-off-by: Peng Fan
Reviewed-by: Daniel Baluta
("net: add UAPI to the header guard in various network
headers")
Reported-by: Venkat Rao Bagalkote
Closes:
https://lore.kernel.org/all/c2bc466d-dff2-4d0d-a797-9af7f676c...@linux.ibm.com/
Tested-by: Venkat Rao Bagalkote
Signed-off-by: Saket Kumar Bhaskar
Acked-by: Daniel Borkmann
On Thu, May 1, 2025, at 7:28 AM, Lorenz Bauer wrote:
> I'd like to cut down the memory usage of parsing vmlinux BTF in ebpf-go.
> With some upcoming changes the library is sitting at 5MiB for a parse.
> Most of that memory is simply copying the BTF blob into user space.
> By allowing vmlinux BTF to
Hi Shawn,
Gentle ping.
On Thu, Mar 20, 2025 at 2:08 PM Daniel Baluta wrote:
>
> DSP found in i.MX8MP SOC can be used by multiple frameworks in order to
> enable various applications:
> - rproc/rpmsg framework, used to load for example Zephyr samples
> - Soun
ed) ChromeOS kernel trees, so the
> > compatibility impact should be minimal. I will also try to clean up
> > the leftover bits on the crosvm side just to clear things up.
>
> Thanks for your reply, and thanks for clarifying+cleaning it up.
>
[...]
> >> IIRC, in that com
bpf_check(), as it currently exists, will soon be going away to make way
for loadable BPF verifier support. Fixup selftests so they fentry attach
to a more reliable location.
Signed-off-by: Daniel Xu
---
tools/testing/selftests/bpf/progs/exceptions_assert.c | 2 +-
tools/testing/selftests/bpf
> >
> > Which does not seem to reflect reality ...
Please feel free to disregard these features and reuse their bits and
queue indexes; as far as I know, they are not actually enabled
anywhere currently and the corresponding guest patches were only
applied to some (no-longer-used) Chrome
eset controller API (changes merged ->
https://patchwork.kernel.org/project/linux-arm-kernel/cover/20250311085812.1296243-1-daniel.bal...@nxp.com/)
- drop patches related to DSP run/stall/reset via syscon
- picked up patch related to using run_stall via reset
contr
With imx8mp-evk board we are now configuring 'dsp' node for rproc usage,
so add rproc specific memory regions.
Also, enable dsp node because it is ready to be used.
Reviewed-by: Ahmad Fatoum
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/
11085812.1296243-1-daniel.bal...@nxp.com/)
- drop patches related to DSP run/stall/reset via syscon
- picked up patch related to using run_stall via reset
controller API.
Daniel Baluta (5):
arm64: dts: imx8mp: Use resets property
arm64: dts: imx8mp: Add mu2 root clock
ware) will need to
create a separate dts file (or an overlay).
This change follows the approach taken for other i.MX8 boards
in commit 391a319c81f6d7 ("arm64: dts: imx8-ss-audio: configure dsp node
for rproc usage")
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by:
e patch matches the spec, so from that
perspective, looks fine:
Reviewed-by: Daniel Verkamp
Since the driver code has been using the wrong order since support for
this message was added in 2010, but there is no support for sending
this message in the current qemu device implementation, I wondered
wh
be writable - tainting kernel\n",
+ pr_warn(
+"%s: ro_after_init failed with %d, data might be writable - tainting kernel\n",
mod->name, ret);
add_taint_module(mod, TAINT_BAD_PAGE, LOCKDEP_STILL_OK);
}
Daniel
DSP core needs ocram, core and debug clocks.
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
b/arch/arm64/boot/dts
ware) will need to
create a separate dts file (or an overlay).
This change follows the approach taken for other i.MX8 boards
in commit 391a319c81f6d7 ("arm64: dts: imx8-ss-audio: configure dsp node
for rproc usage")
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by:
Add resets property to dsp node in order to be able to control the dsp
run/stall bit from audio block control.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch
Enable all relevant nodes to support remoteproc with imx8mp-evk board.
- add rproc specific memory regions
- enable dsp_reserved node
- enable mu2 node
- enable dsp node
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 14
Enable MU2 node and add mu2 root clock.
MU2 is used to communicate with DSP core.
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale
oject/linux-arm-kernel/cover/20250311085812.1296243-1-daniel.bal...@nxp.com/)
- drop patches related to DSP run/stall/reset via syscon
- picked up patch related to using run_stall via reset
controller API.
Daniel Baluta (5):
arm64: dts: imx8mp: Use resets property
arm6
: 0||
1024 -> 2047 : 10748||
Tested-by: Daniel Gomez
Andreas, Petr, Miguel,
Based on the discussion in v7, it seems that all these patches will go through
the Rust tree. Is that correct? What would be missing from t
-862b-fd77552ae...@suse.com/ [1]
> Signed-off-by: Andreas Hindborg
And this is what we signed up for here:
https://lore.kernel.org/all/zspanzx4-5dro...@bombadil.infradead.org/
Acked-by: Daniel Gomez
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/
Enable MU2 node and add mu2 root clock.
MU2 is used to communicate with DSP core.
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 4
arch/arm64/boot/dts/freescale/imx8mp.dtsi| 1 +
2 files changed, 5
Add resets property to dsp node in order to be able to control the dsp
run/stall bit from audio block control.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch
DSP core needs ocram, core and debug clocks.
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
b/arch/arm64/boot/dts
lback to handle resource table parsing and to
> process DSP-specific resource, to determine if waiting is needed.
>
> Update imx_dsp_rproc_start() to handle this condition accordingly.
>
> Signed-off-by: Iuliana Prodan
Reviewed-by: Daniel Baluta
rved_mem_region_to_resource() which is checked for an error.
>
> Signed-off-by: Rob Herring (Arm)
For IMX part:
Reviewed-by: Daniel Baluta
" and then get
> the region's address and size. As this is a standard property, it should
> have common functions for drivers to use. Add new functions to count the
> number of regions and retrieve the region's address as a resource.
>
> Signed-off-by: Rob Herring (Arm)
Reviewed-by: Daniel Baluta
On Mon, Mar 17, 2025 at 5:30 PM Alexander Stein
wrote:
>
> Am Montag, 17. März 2025, 14:33:03 CET schrieb Daniel Baluta:
> > Enable MU2 node and add mu2 root clock.
> > MU2 is used to communicate with DSP core.
> >
> > Reviewed-by: Iuliana Prodan
> > Revi
Enable MU2 node and add mu2 root clock.
MU2 is used to communicate with DSP core.
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot
DSP core needs ocram, core and debug clocks.
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
b/arch/arm64/boot/dts
ware) will need to
create a separate dts file (or an overlay).
This change follows the approach taken for other i.MX8 boards
in commit 391a319c81f6d7 ("arm64: dts: imx8-ss-audio: configure dsp node
for rproc usage")
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by:
Add resets property to dsp node in order to be able to control the dsp
run/stall bit from audio block control.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch
With imx8mp-evk board we are now configuring 'dsp' node for rproc usage,
so add rproc specific memory regions.
Also, enable dsp node because it is ready to be used.
Reviewed-by: Ahmad Fatoum
Reviewed-by: Iuliana Prodan
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
arch/
trol the
DSP")
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202503142125.ie33scto-...@intel.com/
Signed-off-by: Daniel Baluta
---
drivers/remoteproc/imx_dsp_rproc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/imx_dsp_rproc.c
b/
https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.bal...@nxp.com/
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/remoteproc/imx_dsp_rproc.c | 25 +
drivers/remoteproc/imx_rproc.h | 2 ++
2 files changed, 19 insertions(
ff-by: Daniel Baluta
---
.../devicetree/bindings/dsp/fsl,dsp.yaml | 24 ++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml
index ab93ffd3d2e5..b8693e4b4b0d 1
For EARC and EARC PHY the reset happens when clearing the reset bits.
Refactor assert/deassert function in order to take into account the
active_low configuration option.
Reviewed-by: Philipp Zabel
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset
We can Run/Stall the DSP via audio block control bits found in audiomix.
Implement this functionality using the reset controller and use assert
for Stall and deassert for Run.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c
On Mon, Mar 10, 2025 at 5:43 PM Mathieu Poirier
wrote:
>
> Good day,
>
> On Wed, Mar 05, 2025 at 12:00:36PM +0200, Daniel Baluta wrote:
> > DSP on i.MX8MP doesn't have a direct reset line so according to hardware
> > design team in order to handle assert/deassert/re
Current code supports EARC PHY Software Reset and EARC Software Reset
but it is not easily extensible to more reset bits.
So, refactor the code in order to easily allow more reset bits in the
future.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
drivers/reset
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show
that specific macros are related to audiomix.
Reviewed-by: Philipp Zabel
Reviewed-by: Frank Li
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 14 +++---
1 file
Add resets property to dsp node in order to be able to control the dsp
run/stall bit from audio block control.
Reviewed-by: Peng Fan
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch
Add reset ids used for EARC and DSP on i.MX8MP platform.
Acked-by: Rob Herring (Arm)
Reviewed-by: Frank Li
Signed-off-by: Daniel Baluta
---
include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 +
1 file changed, 13 insertions(+)
create mode 100644 include/dt-bindings/reset
- add correct include in the yaml dts snippet example
Changes since v1:
(https://lore.kernel.org/imx/20250219030809.GD6537@nxa18884-linux/T/)
- addresed comments received on v1
- picked up R-b and A-b tags
Daniel Baluta (8):
dt-bindings: reset: audiomix: Add reset ids for EA
This adds IMX8MP_AUDIOMIX_ prefix to internal macros in order to show
that specific macros are related to audiomix.
Reviewed-by: Philipp Zabel
Reviewed-by: Frank Li
Reviewed-by: Peng Fan
Signed-off-by: Daniel Baluta
---
drivers/reset/reset-imx8mp-audiomix.c | 14 +++---
1 file
1 - 100 of 6411 matches
Mail list logo
