Re: [PATCH 4.19 54/86] Input: elan_i2c - only increment wakeup count on touch

On Mon, Jul 27, 2020 at 3:01 PM Dmitry Torokhov wrote: > > On Mon, Jul 27, 2020 at 11:29:33PM +0200, Pavel Machek wrote: > > Hi! > > > > > From: Derek Basehore > > > > > > [ Upstream commit 966334dfc472bdfa67bed864842943b19755d192 ] > > > > > > This moves the wakeup increment for elan devices to

Re: [PATCH] Input: elan_i2c - only increment wakeup count on touch

On Mon, Jun 29, 2020 at 10:16 PM Dmitry Torokhov wrote: > > On Mon, Jun 29, 2020 at 05:57:07PM -0700, Derek Basehore wrote: > > This moves the wakeup increment for elan devices to the touch report. > > This prevents the drivers from incorrectly reporting a wakeup when the > > resume callback

Re: [PATCH v3 1/4] drm/panel: Add helper for reading DT rotation

On Mon, Jun 24, 2019 at 1:36 PM Sam Ravnborg wrote: > > Hi Derek. > > On Fri, Jun 21, 2019 at 08:41:02PM -0700, Derek Basehore wrote: > > This adds a helper function for reading the rotation (panel > > orientation) from the device tree. > > > > Signed-off-by: Derek Basehore > > --- > >

Re: [PATCH 3/5] drm/panel: Add attach/detach callbacks

On Tue, Jun 11, 2019 at 1:57 AM Daniel Vetter wrote: > > On Mon, Jun 10, 2019 at 09:03:48PM -0700, Derek Basehore wrote: > > This adds the attach/detach callbacks. These are for setting up > > internal state for the connector/panel pair that can't be done at > > probe (since the connector doesn't

Re: [PATCH v3 3/6] clk: change rates via list iteration

On Mon, Mar 4, 2019 at 8:49 PM Derek Basehore wrote: > > This changes the clk_set_rate code to use lists instead of recursion. > While making this change, also add error handling for clk_set_rate. > This means that errors in the set_rate/set_parent/set_rate_and_parent > functions will not longer

Re: [PATCH v2 1/6] clk: Remove recursion in clk_core_{prepare,enable}()

On Tue, Mar 5, 2019 at 5:35 PM dbasehore . wrote: > > On Tue, Mar 5, 2019 at 10:49 AM Stephen Boyd wrote: > > > > Quoting Derek Basehore (2019-03-04 20:49:31) > > > From: Stephen Boyd > > > > > > Enabling and preparing clocks can be written quite nat

Re: [PATCH v2 1/6] clk: Remove recursion in clk_core_{prepare,enable}()

On Tue, Mar 5, 2019 at 10:49 AM Stephen Boyd wrote: > > Quoting Derek Basehore (2019-03-04 20:49:31) > > From: Stephen Boyd > > > > Enabling and preparing clocks can be written quite naturally with > > recursion. We start at some point in the tree and recurse up the > > tree to find the oldest

Re: [PATCH 0/6] Coordinated Clks

On Thu, Dec 20, 2018 at 1:15 PM Stephen Boyd wrote: > > Quoting Derek Basehore (2018-10-23 18:31:26) > > Here's the first set of patches that I'm working on for the Common > > Clk Framework. Part of this patch series adds a new clk op, > > pre_rate_req. This is designed to replace the clk

Re: RFC [PATCH 1/1] locking/lockdep: Fix nest lock warning on unlock

On Wed, Dec 12, 2018 at 1:09 AM Peter Zijlstra wrote: > > On Tue, Dec 11, 2018 at 06:25:06PM -0800, Derek Basehore wrote: > > The function __lock_acquire checks that the nest lock is held passed > > in as an argument. The issue with this is that __lock_acquire is used > > for internal bookkeeping

Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk

On Mon, Nov 19, 2018 at 1:41 AM Heiko Stübner wrote: > > Am Freitag, 16. November 2018, 19:23:59 CET schrieb Doug Anderson: > > Hi, > > > > On Fri, Nov 16, 2018 at 9:39 AM dbasehore . wrote: > > > On Fri, Nov 16, 2018 at 8:01 AM Doug Anderson > wrote: > &

Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk

On Mon, Nov 19, 2018 at 1:41 AM Heiko Stübner wrote: > > Am Freitag, 16. November 2018, 19:23:59 CET schrieb Doug Anderson: > > Hi, > > > > On Fri, Nov 16, 2018 at 9:39 AM dbasehore . wrote: > > > On Fri, Nov 16, 2018 at 8:01 AM Doug Anderson > wrote: > &

Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk

On Fri, Nov 16, 2018 at 8:01 AM Doug Anderson wrote: > > Hi, > > On Thu, Nov 15, 2018 at 9:17 PM Derek Basehore wrote: > > > > This adds the xin32k clock to the RK3399 CPU. Even though it's not > > directly used, muxes will end up traversing the entire clk tree on > > calls to determine_rate if

Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk

On Fri, Nov 16, 2018 at 8:01 AM Doug Anderson wrote: > > Hi, > > On Thu, Nov 15, 2018 at 9:17 PM Derek Basehore wrote: > > > > This adds the xin32k clock to the RK3399 CPU. Even though it's not > > directly used, muxes will end up traversing the entire clk tree on > > calls to determine_rate if

Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk

On Thu, Nov 15, 2018 at 9:03 PM Doug Anderson wrote: > > Hi, > > On Thu, Nov 15, 2018 at 4:42 PM Derek Basehore wrote: > > > > This adds the xin32k clock to the RK3399 CPU. Even though it's not > > directly used, muxes will end up traversing the entire clk tree on > > calls to determine_rate if

Re: [PATCH] arm64: dts: rockchip: rk3399: Add xin32k clk

On Thu, Nov 15, 2018 at 9:03 PM Doug Anderson wrote: > > Hi, > > On Thu, Nov 15, 2018 at 4:42 PM Derek Basehore wrote: > > > > This adds the xin32k clock to the RK3399 CPU. Even though it's not > > directly used, muxes will end up traversing the entire clk tree on > > calls to determine_rate if

Re: [PATCH] clk: fix clk_calc_subtree compute duplications

On Fri, Aug 31, 2018 at 2:20 PM Derek Basehore wrote: > > clk_calc_subtree was called at every step up the clk tree in > clk_calc_new_rates. Since it recursively calls itself for its > children, this means it would be called once on each clk for each > step above the top clk is. > > This is fixed

Re: [PATCH] clk: fix clk_calc_subtree compute duplications

On Fri, Aug 31, 2018 at 2:20 PM Derek Basehore wrote: > > clk_calc_subtree was called at every step up the clk tree in > clk_calc_new_rates. Since it recursively calls itself for its > children, this means it would be called once on each clk for each > step above the top clk is. > > This is fixed

Re: [PATCH] Input: elants_i2c - Fix sw reset delays

On Mon, Aug 27, 2018 at 4:52 AM Andi Shyti wrote: > > Hi Derek, > > next time, could you please avoid using html mails when replying > to the mailing list? They are not clear. Sorry, my plain text setting was reset for some reason. > > On Fri, Aug 24, 2018 at 04:07:41PM -07

Re: [PATCH] Input: elants_i2c - Fix sw reset delays

On Mon, Aug 27, 2018 at 4:52 AM Andi Shyti wrote: > > Hi Derek, > > next time, could you please avoid using html mails when replying > to the mailing list? They are not clear. Sorry, my plain text setting was reset for some reason. > > On Fri, Aug 24, 2018 at 04:07:41PM -07

Re: [PATCH] Input: elants_i2c - Fix sw reset delays

On Fri, Aug 24, 2018 at 4:07 PM dbasehore . wrote: > > > > On Fri, Aug 24, 2018 at 1:49 AM Andi Shyti wrote: >> >> Hi Derek, >> >> > > > On Thu, Aug 23, 2018 at 04:10:13PM -0700, Derek Basehore wrote: >> > > > > We

Re: [PATCH] Input: elants_i2c - Fix sw reset delays

On Fri, Aug 24, 2018 at 4:07 PM dbasehore . wrote: > > > > On Fri, Aug 24, 2018 at 1:49 AM Andi Shyti wrote: >> >> Hi Derek, >> >> > > > On Thu, Aug 23, 2018 at 04:10:13PM -0700, Derek Basehore wrote: >> > > > > We

Re: [PATCH] i2c: enable async suspend/resume on i2c devices

On Fri, Jul 27, 2018 at 5:07 AM Hans de Goede wrote: > Hi, > > On 07/27/2018 12:44 PM, Andy Shevchenko wrote: > > On Fri, Jul 27, 2018 at 1:55 AM, Derek Basehore > wrote: > >> This enables the async suspend property for i2c devices. This reduces > >> the suspend/resume time considerably on

Re: [PATCH] i2c: enable async suspend/resume on i2c devices

On Fri, Jul 27, 2018 at 5:07 AM Hans de Goede wrote: > Hi, > > On 07/27/2018 12:44 PM, Andy Shevchenko wrote: > > On Fri, Jul 27, 2018 at 1:55 AM, Derek Basehore > wrote: > >> This enables the async suspend property for i2c devices. This reduces > >> the suspend/resume time considerably on

Re: [PATCH v7 1/3] irqchip/gic-v3-its: add ability to save/restore ITS state

On Wed, Mar 14, 2018 at 2:44 PM, dbasehore . <dbaseh...@chromium.org> wrote: > On Wed, Mar 14, 2018 at 3:22 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: >> On 02/03/18 02:08, dbasehore . wrote: >>> On Thu, Mar 1, 2018 at 4:29 AM, Marc Zyngier <marc.zyn

Re: [PATCH v7 1/3] irqchip/gic-v3-its: add ability to save/restore ITS state

On Wed, Mar 14, 2018 at 2:44 PM, dbasehore . wrote: > On Wed, Mar 14, 2018 at 3:22 AM, Marc Zyngier wrote: >> On 02/03/18 02:08, dbasehore . wrote: >>> On Thu, Mar 1, 2018 at 4:29 AM, Marc Zyngier wrote: >>>> Hi Mark, >>>> >>>> On 01/03/18

Re: [PATCH v7 1/3] irqchip/gic-v3-its: add ability to save/restore ITS state

On Wed, Mar 14, 2018 at 3:22 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: > On 02/03/18 02:08, dbasehore . wrote: >> On Thu, Mar 1, 2018 at 4:29 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: >>> Hi Mark, >>> >>> On 01/03/18 11:41, Mark Rutlan

Re: [PATCH v7 1/3] irqchip/gic-v3-its: add ability to save/restore ITS state

On Wed, Mar 14, 2018 at 3:22 AM, Marc Zyngier wrote: > On 02/03/18 02:08, dbasehore . wrote: >> On Thu, Mar 1, 2018 at 4:29 AM, Marc Zyngier wrote: >>> Hi Mark, >>> >>> On 01/03/18 11:41, Mark Rutland wrote: >>>> On Wed, Feb 28, 2018 at 09

Re: [PATCH] cpu_pm: add syscore_suspend error handling

On Thu, Mar 1, 2018 at 12:39 AM, Sebastian Andrzej Siewior wrote: > On 2018-02-28 19:27:54 [-0800], Derek Basehore wrote: >> If cpu_cluster_pm_enter() fails, cpu_pm_exit() should be called. This >> will put the CPU in the correct state to resume from the failure. > > Was

Re: [PATCH] cpu_pm: add syscore_suspend error handling

On Thu, Mar 1, 2018 at 12:39 AM, Sebastian Andrzej Siewior wrote: > On 2018-02-28 19:27:54 [-0800], Derek Basehore wrote: >> If cpu_cluster_pm_enter() fails, cpu_pm_exit() should be called. This >> will put the CPU in the correct state to resume from the failure. > > Was this triggered or found

Re: [PATCH v7 1/3] irqchip/gic-v3-its: add ability to save/restore ITS state

On Thu, Mar 1, 2018 at 4:29 AM, Marc Zyngier wrote: > Hi Mark, > > On 01/03/18 11:41, Mark Rutland wrote: >> On Wed, Feb 28, 2018 at 09:48:18PM -0800, Derek Basehore wrote: >>> Some platforms power off GIC logic in suspend, so we need to >>> save/restore state. The

Re: [PATCH v7 1/3] irqchip/gic-v3-its: add ability to save/restore ITS state

On Thu, Mar 1, 2018 at 4:29 AM, Marc Zyngier wrote: > Hi Mark, > > On 01/03/18 11:41, Mark Rutland wrote: >> On Wed, Feb 28, 2018 at 09:48:18PM -0800, Derek Basehore wrote: >>> Some platforms power off GIC logic in suspend, so we need to >>> save/restore state. The distributor and redistributor

Re: [PATCH v5 3/4] DT/arm,gic-v3-its: add reset-on-suspend property

On Wed, Feb 7, 2018 at 1:21 AM, Marc Zyngier wrote: > On 07/02/18 01:41, Derek Basehore wrote: >> This adds documentation for the new reset-on-suspend property. This >> property enables saving and restoring the ITS for when it loses state >> in system suspend. >> >>

Re: [PATCH v5 3/4] DT/arm,gic-v3-its: add reset-on-suspend property

On Wed, Feb 7, 2018 at 1:21 AM, Marc Zyngier wrote: > On 07/02/18 01:41, Derek Basehore wrote: >> This adds documentation for the new reset-on-suspend property. This >> property enables saving and restoring the ITS for when it loses state >> in system suspend. >> >> Signed-off-by: Derek Basehore

Re: [PATCH v5 4/4] irqchip/gic-v3-its: add ability to resend MAPC on resume

On Wed, Feb 7, 2018 at 3:22 PM, Brian Norris wrote: > Hi Marc, > > I'm really not an expert on this, so take my observations with a large > grain of salt: > > On Wed, Feb 07, 2018 at 08:46:42AM +, Marc Zyngier wrote: >> On 07/02/18 01:41, Derek Basehore wrote: >> >

Re: [PATCH v5 4/4] irqchip/gic-v3-its: add ability to resend MAPC on resume

On Wed, Feb 7, 2018 at 3:22 PM, Brian Norris wrote: > Hi Marc, > > I'm really not an expert on this, so take my observations with a large > grain of salt: > > On Wed, Feb 07, 2018 at 08:46:42AM +, Marc Zyngier wrote: >> On 07/02/18 01:41, Derek Basehore wrote: >> > This adds functionality to

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Tue, Feb 6, 2018 at 8:23 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: > On 05/02/18 21:33, dbasehore . wrote: >> On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: >>> On 03/02/18 01:24, Derek Basehore wrote: >>>> Some platf

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Tue, Feb 6, 2018 at 8:23 AM, Marc Zyngier wrote: > On 05/02/18 21:33, dbasehore . wrote: >> On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier wrote: >>> On 03/02/18 01:24, Derek Basehore wrote: >>>> Some platforms power off GIC logic in suspend, so we n

Re: [PATCH v4 4/5] irqchip/gic-v3-its: add ability to resend MAPC on resume

On Tue, Feb 6, 2018 at 8:40 AM, Marc Zyngier wrote: > On 03/02/18 01:24, Derek Basehore wrote: >> This adds functionality to resend the MAPC command to an ITS node on >> resume. If the ITS is powered down during suspend and the collections >> are not backed by memory, the

Re: [PATCH v4 4/5] irqchip/gic-v3-its: add ability to resend MAPC on resume

On Tue, Feb 6, 2018 at 8:40 AM, Marc Zyngier wrote: > On 03/02/18 01:24, Derek Basehore wrote: >> This adds functionality to resend the MAPC command to an ITS node on >> resume. If the ITS is powered down during suspend and the collections >> are not backed by memory, the ITS will lose that

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Feb 5, 2018 at 5:01 PM, dbasehore . <dbaseh...@chromium.org> wrote: > On Mon, Feb 5, 2018 at 4:33 PM, dbasehore . <dbaseh...@chromium.org> wrote: >> On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: >>> On 03/02/18 01:24, Derek

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Feb 5, 2018 at 5:01 PM, dbasehore . wrote: > On Mon, Feb 5, 2018 at 4:33 PM, dbasehore . wrote: >> On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier wrote: >>> On 03/02/18 01:24, Derek Basehore wrote: >>>> Some platforms power off GIC logic in suspend, so we n

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Feb 5, 2018 at 4:33 PM, dbasehore . <dbaseh...@chromium.org> wrote: > On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: >> On 03/02/18 01:24, Derek Basehore wrote: >>> Some platforms power off GIC logic in suspend, so we

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Feb 5, 2018 at 4:33 PM, dbasehore . wrote: > On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier wrote: >> On 03/02/18 01:24, Derek Basehore wrote: >>> Some platforms power off GIC logic in suspend, so we need to >>> save/restore state. The distributor and r

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier wrote: > On 03/02/18 01:24, Derek Basehore wrote: >> Some platforms power off GIC logic in suspend, so we need to >> save/restore state. The distributor and redistributor registers need >> to be handled in platform code due to

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier wrote: > On 03/02/18 01:24, Derek Basehore wrote: >> Some platforms power off GIC logic in suspend, so we need to >> save/restore state. The distributor and redistributor registers need >> to be handled in platform code due to access permissions on

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier wrote: > On 03/02/18 01:24, Derek Basehore wrote: >> Some platforms power off GIC logic in suspend, so we need to >> save/restore state. The distributor and redistributor registers need >> to be handled in platform code due to

Re: [PATCH v4 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Feb 5, 2018 at 7:56 AM, Marc Zyngier wrote: > On 03/02/18 01:24, Derek Basehore wrote: >> Some platforms power off GIC logic in suspend, so we need to >> save/restore state. The distributor and redistributor registers need >> to be handled in platform code due to access permissions on

Re: [PATCH v3 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Jan 29, 2018 at 5:00 PM, Derek Basehore wrote: > Some platforms power off GIC logic in suspend, so we need to > save/restore state. The distributor and redistributor registers need > to be handled in platform code due to access permissions on those > registers, but

Re: [PATCH v3 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Mon, Jan 29, 2018 at 5:00 PM, Derek Basehore wrote: > Some platforms power off GIC logic in suspend, so we need to > save/restore state. The distributor and redistributor registers need > to be handled in platform code due to access permissions on those > registers, but the ITS registers can

Re: [PATCH v3 4/5] irqchip/gic-v3-its: add ability to resend MAPC on resume

On Mon, Jan 29, 2018 at 5:00 PM, Derek Basehore wrote: > This adds functionality to resend the MAPC command to an ITS node on > resume. If the ITS is powered down during suspend and the collections > are not backed by memory, the ITS will lose that state. This just sets >

Re: [PATCH v3 4/5] irqchip/gic-v3-its: add ability to resend MAPC on resume

On Mon, Jan 29, 2018 at 5:00 PM, Derek Basehore wrote: > This adds functionality to resend the MAPC command to an ITS node on > resume. If the ITS is powered down during suspend and the collections > are not backed by memory, the ITS will lose that state. This just sets > up the known state for

Re: [PATCH v2 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Fri, Jan 26, 2018 at 12:59 PM, Brian Norris wrote: > One trivial comment: > > On Thu, Jan 25, 2018 at 11:38:32PM -0800, Derek Basehore wrote: >> Some platforms power off GIC logic in suspend, so we need to >> save/restore state. The distributor and redistributor

Re: [PATCH v2 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

On Fri, Jan 26, 2018 at 12:59 PM, Brian Norris wrote: > One trivial comment: > > On Thu, Jan 25, 2018 at 11:38:32PM -0800, Derek Basehore wrote: >> Some platforms power off GIC logic in suspend, so we need to >> save/restore state. The distributor and redistributor registers need >> to be handled

Re: [PATCH 6/8] irqchip/gic-v3-its: add ability to resend MAPC on resume

On Sun, Jan 14, 2018 at 2:56 AM, Marc Zyngier wrote: > On Fri, 12 Jan 2018 21:24:20 +, > Derek Basehore wrote: >> >> This adds a DT-binding to resend the MAPC command to an ITS node on > > This isn't a DT binding. That's the driver implementation. The binding > is what

Re: [PATCH 6/8] irqchip/gic-v3-its: add ability to resend MAPC on resume

On Sun, Jan 14, 2018 at 2:56 AM, Marc Zyngier wrote: > On Fri, 12 Jan 2018 21:24:20 +, > Derek Basehore wrote: >> >> This adds a DT-binding to resend the MAPC command to an ITS node on > > This isn't a DT binding. That's the driver implementation. The binding > is what you put in

Re: [PATCH 4/8] irqchip/gic-v3: add ability to save/restore GIC/ITS state

On Fri, Jan 19, 2018 at 1:22 AM, Marc Zyngier wrote: > On 18/01/18 23:33, Brian Norris wrote: >> Hi, >> >> On Sat, Jan 13, 2018 at 06:10:52PM +, Marc Zyngier wrote: >>> On Fri, 12 Jan 2018 21:24:18 +, >>> Derek Basehore wrote: Some platforms power off GIC

Re: [PATCH 4/8] irqchip/gic-v3: add ability to save/restore GIC/ITS state

On Fri, Jan 19, 2018 at 1:22 AM, Marc Zyngier wrote: > On 18/01/18 23:33, Brian Norris wrote: >> Hi, >> >> On Sat, Jan 13, 2018 at 06:10:52PM +, Marc Zyngier wrote: >>> On Fri, 12 Jan 2018 21:24:18 +, >>> Derek Basehore wrote: Some platforms power off GIC logic in S3, so we need

Re: Save and Restore Generic Interrupt Controller for System Sleep on ARM

On Thu, Nov 30, 2017 at 1:44 AM, Marc Zyngier <marc.zyng...@arm.com> wrote: > On Wed, Nov 29 2017 at 2:49:18 pm GMT, "dbasehore ." > <dbaseh...@chromium.org> wrote: >> There was some work in ARM Trusted Firmware to support saving and >> restoring the Gen

Re: Save and Restore Generic Interrupt Controller for System Sleep on ARM

On Thu, Nov 30, 2017 at 1:44 AM, Marc Zyngier wrote: > On Wed, Nov 29 2017 at 2:49:18 pm GMT, "dbasehore ." > wrote: >> There was some work in ARM Trusted Firmware to support saving and >> restoring the Generic Interrupt Controller (GICv3) before and after >>

Save and Restore Generic Interrupt Controller for System Sleep on ARM

There was some work in ARM Trusted Firmware to support saving and restoring the Generic Interrupt Controller (GICv3) before and after sleep, but it seems that the plan is to have this all in the kernel now. The point of doing this is to save power during sleep. On an RK3399 system, we save about

Save and Restore Generic Interrupt Controller for System Sleep on ARM

There was some work in ARM Trusted Firmware to support saving and restoring the Generic Interrupt Controller (GICv3) before and after sleep, but it seems that the plan is to have this all in the kernel now. The point of doing this is to save power during sleep. On an RK3399 system, we save about

Re: [PATCH v2] pwm_bl: Fix overflow condition

Okay, I think that this is just my email client confusing me. Please ignore this email and just review the first "PATCH v2" patch.

Re: [PATCH v2] pwm_bl: Fix overflow condition

Okay, I think that this is just my email client confusing me. Please ignore this email and just review the first "PATCH v2" patch.

Re: [PATCH] pwm_bl: Fix overflow condition

Did not mean to send this in-reply to. It seems that git send-email was not applying my "PATCH v2" prefix. Will resend as a separate thread.

Re: [PATCH] pwm_bl: Fix overflow condition

Did not mean to send this in-reply to. It seems that git send-email was not applying my "PATCH v2" prefix. Will resend as a separate thread.

Re: [PATCH] pwm_bl: Fix overflow condition

On Tue, Aug 29, 2017 at 7:05 AM, Thierry Reding wrote: > On Mon, Aug 28, 2017 at 01:00:33PM -0700, Derek Basehore wrote: >> This fixes and overflow condition that happens with a high value of >> brightness-levels-scale by using a 64-bit variable. The issue would >>

Re: [PATCH] pwm_bl: Fix overflow condition

On Tue, Aug 29, 2017 at 7:05 AM, Thierry Reding wrote: > On Mon, Aug 28, 2017 at 01:00:33PM -0700, Derek Basehore wrote: >> This fixes and overflow condition that happens with a high value of >> brightness-levels-scale by using a 64-bit variable. The issue would >> prevent a range of higher

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Tue, Jul 18, 2017 at 3:22 PM, Thomas Gleixner <t...@linutronix.de> wrote: > On Tue, 18 Jul 2017, dbasehore . wrote: >> On Tue, Jul 18, 2017 at 2:53 PM, Thomas Gleixner <t...@linutronix.de> wrote: >> > On Tue, 18 Jul 2017, dbasehore . wrote: >> >>

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Tue, Jul 18, 2017 at 3:22 PM, Thomas Gleixner wrote: > On Tue, 18 Jul 2017, dbasehore . wrote: >> On Tue, Jul 18, 2017 at 2:53 PM, Thomas Gleixner wrote: >> > On Tue, 18 Jul 2017, dbasehore . wrote: >> >> On Mon, Jul 17, 2017 at 11:40 PM, Thomas Gleixner >&

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Tue, Jul 18, 2017 at 2:53 PM, Thomas Gleixner <t...@linutronix.de> wrote: > On Tue, 18 Jul 2017, dbasehore . wrote: >> On Mon, Jul 17, 2017 at 11:40 PM, Thomas Gleixner <t...@linutronix.de> wrote: >> > On Mon, 17 Jul 2017, dbasehore . wrote: >> >>

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Tue, Jul 18, 2017 at 2:53 PM, Thomas Gleixner wrote: > On Tue, 18 Jul 2017, dbasehore . wrote: >> On Mon, Jul 17, 2017 at 11:40 PM, Thomas Gleixner wrote: >> > On Mon, 17 Jul 2017, dbasehore . wrote: >> >> On Mon, Jul 17, 2017 at 6:33 PM, Rafael J. Wysocki &

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Mon, Jul 17, 2017 at 11:40 PM, Thomas Gleixner <t...@linutronix.de> wrote: > On Mon, 17 Jul 2017, dbasehore . wrote: >> On Mon, Jul 17, 2017 at 6:33 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: >> I could make a patch to try it out. I would probably add a flag t

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Mon, Jul 17, 2017 at 11:40 PM, Thomas Gleixner wrote: > On Mon, 17 Jul 2017, dbasehore . wrote: >> On Mon, Jul 17, 2017 at 6:33 PM, Rafael J. Wysocki wrote: >> I could make a patch to try it out. I would probably add a flag to rtc >> timers to indicate whether it wake

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Mon, Jul 17, 2017 at 6:33 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: > On Tue, Jul 18, 2017 at 2:30 AM, dbasehore . <dbaseh...@chromium.org> wrote: >> On Sat, Jul 15, 2017 at 5:39 AM, Rafael J. Wysocki <r...@rjwysocki.net> >> wrote: >>> On Thu

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Mon, Jul 17, 2017 at 6:33 PM, Rafael J. Wysocki wrote: > On Tue, Jul 18, 2017 at 2:30 AM, dbasehore . wrote: >> On Sat, Jul 15, 2017 at 5:39 AM, Rafael J. Wysocki >> wrote: >>> On Thursday, July 13, 2017 03:58:53 PM dbasehore . wrote: >>>> On Thu, Jul 13

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Sat, Jul 15, 2017 at 5:39 AM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: > On Thursday, July 13, 2017 03:58:53 PM dbasehore . wrote: >> On Thu, Jul 13, 2017 at 8:09 AM, Rafael J. Wysocki <raf...@kernel.org> wrote: >> > On Thu, Jul 13, 2017 at 9:32 AM, Peter

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Sat, Jul 15, 2017 at 5:39 AM, Rafael J. Wysocki wrote: > On Thursday, July 13, 2017 03:58:53 PM dbasehore . wrote: >> On Thu, Jul 13, 2017 at 8:09 AM, Rafael J. Wysocki wrote: >> > On Thu, Jul 13, 2017 at 9:32 AM, Peter Zijlstra >> > wrote: >> >> O

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Thu, Jul 13, 2017 at 8:09 AM, Rafael J. Wysocki wrote: > On Thu, Jul 13, 2017 at 9:32 AM, Peter Zijlstra wrote: >> On Fri, Jul 07, 2017 at 05:03:00PM -0700, Derek Basehore wrote: >>> Adds a new feature to tick to schedule wakeups on a CPU during

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Thu, Jul 13, 2017 at 8:09 AM, Rafael J. Wysocki wrote: > On Thu, Jul 13, 2017 at 9:32 AM, Peter Zijlstra wrote: >> On Fri, Jul 07, 2017 at 05:03:00PM -0700, Derek Basehore wrote: >>> Adds a new feature to tick to schedule wakeups on a CPU during freeze. >>> This won't fully wake up the system

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Wed, Jul 12, 2017 at 10:11 PM, Thomas Gleixner <t...@linutronix.de> wrote: > On Wed, 12 Jul 2017, dbasehore . wrote: >> On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner <t...@linutronix.de> wrote: >> > There are more issues with this: If there is a hrtimer schedul

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Wed, Jul 12, 2017 at 10:11 PM, Thomas Gleixner wrote: > On Wed, 12 Jul 2017, dbasehore . wrote: >> On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: >> > There are more issues with this: If there is a hrtimer scheduled on that >> > last CPU which e

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Wed, Jul 12, 2017 at 2:25 PM, Thomas Gleixner wrote: > On Fri, 7 Jul 2017, Derek Basehore wrote: >> Adds a new feature to tick to schedule wakeups on a CPU during freeze. >> This won't fully wake up the system (devices are not resumed), but >> allow simple platform

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Wed, Jul 12, 2017 at 2:25 PM, Thomas Gleixner wrote: > On Fri, 7 Jul 2017, Derek Basehore wrote: >> Adds a new feature to tick to schedule wakeups on a CPU during freeze. >> This won't fully wake up the system (devices are not resumed), but >> allow simple platform functionality to be run

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: > On Fri, 7 Jul 2017, Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds after entering

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: > On Fri, 7 Jul 2017, Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds after entering freeze. After X seconds,

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: > On Fri, 7 Jul 2017, Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds after entering

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Wed, Jul 12, 2017 at 3:16 PM, Thomas Gleixner wrote: > On Fri, 7 Jul 2017, Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds after entering freeze. After X seconds,

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Mon, Jul 10, 2017 at 3:09 PM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: > On Monday, July 10, 2017 02:57:48 PM dbasehore . wrote: >> On Mon, Jul 10, 2017 at 6:33 AM, Rafael J. Wysocki <r...@rjwysocki.net> >> wrote: >> > On Friday, July 07, 2

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Mon, Jul 10, 2017 at 3:09 PM, Rafael J. Wysocki wrote: > On Monday, July 10, 2017 02:57:48 PM dbasehore . wrote: >> On Mon, Jul 10, 2017 at 6:33 AM, Rafael J. Wysocki >> wrote: >> > On Friday, July 07, 2017 05:03:03 PM Derek Basehore wrote: >> >>

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Mon, Jul 10, 2017 at 6:33 AM, Rafael J. Wysocki wrote: > On Friday, July 07, 2017 05:03:03 PM Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds

Re: [PATCH v5 5/5] intel_idle: Add S0ix validation

On Mon, Jul 10, 2017 at 6:33 AM, Rafael J. Wysocki wrote: > On Friday, July 07, 2017 05:03:03 PM Derek Basehore wrote: >> This adds validation of S0ix entry and enables it on Skylake. Using >> the new tick_set_freeze_event function, we program the CPU to wake up >> X seconds after entering

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Sat, Jul 8, 2017 at 9:05 AM, Andy Shevchenko wrote: > On Sat, Jul 8, 2017 at 3:03 AM, Derek Basehore wrote: >> Adds a new feature to tick to schedule wakeups on a CPU during freeze. >> This won't fully wake up the system (devices are not

Re: [PATCH v5 2/5] tick: Add freeze timer events

On Sat, Jul 8, 2017 at 9:05 AM, Andy Shevchenko wrote: > On Sat, Jul 8, 2017 at 3:03 AM, Derek Basehore wrote: >> Adds a new feature to tick to schedule wakeups on a CPU during freeze. >> This won't fully wake up the system (devices are not resumed), but >> allow simple platform functionality to

Re: [PATCH v10 5/5] drm/rockchip: Add dmc notifier in vop driver

On Wed, Sep 7, 2016 at 1:31 PM, Sean Paul <seanp...@google.com> wrote: > On Wed, Sep 7, 2016 at 2:13 PM, dbasehore . <dbaseh...@chromium.org> wrote: >> On Tue, Sep 6, 2016 at 10:18 AM, Sean Paul <seanp...@google.com> wrote: >>> On Mon, Sep 5, 2016 at 1:06 AM, L

Re: [PATCH v10 5/5] drm/rockchip: Add dmc notifier in vop driver

On Wed, Sep 7, 2016 at 1:31 PM, Sean Paul wrote: > On Wed, Sep 7, 2016 at 2:13 PM, dbasehore . wrote: >> On Tue, Sep 6, 2016 at 10:18 AM, Sean Paul wrote: >>> On Mon, Sep 5, 2016 at 1:06 AM, Lin Huang wrote: >>>> when in ddr frequency scaling process, vop can

Re: [PATCH v10 5/5] drm/rockchip: Add dmc notifier in vop driver

On Tue, Sep 6, 2016 at 10:18 AM, Sean Paul wrote: > On Mon, Sep 5, 2016 at 1:06 AM, Lin Huang wrote: >> when in ddr frequency scaling process, vop can not do enable or >> disable operation, since in dcf we check vop clock to see whether >> vop work. If

Re: [PATCH v10 5/5] drm/rockchip: Add dmc notifier in vop driver

On Tue, Sep 6, 2016 at 10:18 AM, Sean Paul wrote: > On Mon, Sep 5, 2016 at 1:06 AM, Lin Huang wrote: >> when in ddr frequency scaling process, vop can not do enable or >> disable operation, since in dcf we check vop clock to see whether >> vop work. If vop work, dcf do ddr frequency scaling when

Re: [PATCH v10 5/5] drm/rockchip: Add dmc notifier in vop driver

On Tue, Sep 6, 2016 at 12:07 PM, Sean Paul wrote: > On Tue, Sep 6, 2016 at 3:01 PM, hl wrote: >> Hi >> >> >> On 2016年09月07日 02:55, Sean Paul wrote: >>> >>> On Tue, Sep 6, 2016 at 2:15 PM, hl wrote: Hi Sean,

Re: [PATCH v10 5/5] drm/rockchip: Add dmc notifier in vop driver

On Tue, Sep 6, 2016 at 12:07 PM, Sean Paul wrote: > On Tue, Sep 6, 2016 at 3:01 PM, hl wrote: >> Hi >> >> >> On 2016年09月07日 02:55, Sean Paul wrote: >>> >>> On Tue, Sep 6, 2016 at 2:15 PM, hl wrote: Hi Sean, On 2016年09月07日 01:18, Sean Paul wrote: > > On Mon, Sep

Re: [PATCH v4 2/5] clockevents: Add timed freeze

On Thu, Jun 9, 2016 at 3:43 PM, Thomas Gleixner wrote: > On Thu, 9 Jun 2016, dbaseh...@chromium.org wrote: >> >> +/* >> + * Clockevent device may run during freeze >> + */ >> +# define CLOCK_EVT_FEAT_FREEZE 0x000100 > > This is a bad name and a horrible comment.

  1   2   >