Re: [PATCH 134/141] video: fbdev: lxfb_ops: Fix fall-through warnings for Clang

2020-11-26 Thread deloptes
Gustavo A. R. Silva wrote: > Absolutely. We'll never know how many bugs this will catch in the > future decades of kernel development, before the code is even > committed/submitted. :) A little bit OT here, but what are the plans for Geode in general as there was discussion around the fact that

Re: [PATCH] fbdev: geocode: remove unneeded NULL check

2015-02-02 Thread deloptes
Tomi Valkeinen wrote: > On 06/01/15 14:45, Sudip Mukherjee wrote: >> the check for info is not required as we are checking it immediately >> after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM >> if it is NULL. >> >> Signed-off-by: Sudip Mukherjee >> --- >> Hi Tomi, >> This

Re: [PATCH] fbdev: geocode: remove unneeded NULL check

2015-02-02 Thread deloptes
Tomi Valkeinen wrote: On 06/01/15 14:45, Sudip Mukherjee wrote: the check for info is not required as we are checking it immediately after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM if it is NULL. Signed-off-by: Sudip Mukherjee su...@vectorindia.org --- Hi Tomi, This