[PATCH v2 2/4] of: Documentation: of_overlay_apply() replaced by of_overlay_fdt_apply()

2018-02-12 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- Changes from v1: - new patch Documentation/devicetree/overlay-notes.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/overlay-notes.txt b/Documentation/devicetree/overlay-notes.txt index c

[PATCH v2] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

2018-02-11 Thread frowand . list
From: Frank Rowand Create a cache of the nodes that contain a phandle property. Use this cache to find the node for a given phandle value instead of scanning the devicetree to find the node. If the phandle value is not found in the cache, of_find_node_by_phandle() will fall back to the tree sca

[PATCH] of: cache phandle nodes to decrease cost of of_find_node_by_phandle()

2018-01-31 Thread frowand . list
From: Frank Rowand Create a cache of the nodes that contain a phandle property. Use this cache to find the node for a given phandle value instead of scanning the devicetree to find the node. If the phandle value is not found in the cache, of_find_node_by_phandle() will fall back to the tree sca

[PATCH] of: cache phandle nodes to decrease cost of of_find_node_by_phandle()

2018-01-31 Thread frowand . list
From: Frank Rowand Create a cache of the nodes that contain a phandle property. Use this cache to find the node for a given phandle value instead of scanning the devicetree to find the node. If the phandle value is not found in the cache, of_find_node_by_phandle() will fall back to the tree sca

[PATCH 0/2] of: change overlay apply input data from EDT to FDT

2018-01-28 Thread frowand . list
From: Frank Rowand Move duplicating and unflattening of an overlay flattened devicetree (FDT) into the overlay application code. To accomplish this, of_overlay_apply() is replaced by of_overlay_fdt_apply(). The copy of the FDT (aka "duplicate FDT") now belongs to devicetree code, which is thus

[PATCH 1/2] of: change overlay apply input data from EDT to FDT

2018-01-28 Thread frowand . list
From: Frank Rowand Move duplicating and unflattening of an overlay flattened devicetree (FDT) into the overlay application code. To accomplish this, of_overlay_apply() is replaced by of_overlay_fdt_apply(). The copy of the FDT (aka "duplicate FDT") now belongs to devicetree code, which is thus

[PATCH 2/2] of: convert unittest overlay devicetree source to sugar syntax

2018-01-28 Thread frowand . list
From: Frank Rowand The unittest-data overlays have been pulled into proper overlay devicetree source files without changing their format. The next step is to convert them to use sugar syntax instead of hand coding overlay fragments structure. A few of the overlays can not be converted because t

[PATCH] Add Frank Rowand to list of enforcement statement endorsers

2017-11-03 Thread frowand . list
From: Frank Rowand Add my name to the list. Signed-off-by: Frank Rowand --- Hi Greg, I noticed that there is a double entry for Ivan Safonov, just below where my name goes. I didn't want to create a merge conflict with this patch, so I'm leaving that alone. Documentation/process/kernel-enf

Re: [PATCH v3] of: dynamic: fix memory leak related to properties of __of_node_dup

2017-10-19 Thread frowand . list
From: Frank Rowand This is Lixin's patch v3, reworded for my preferred style. --- If Lixin agrees, Reviewed-by: Frank Rowand drivers/of/dynamic.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c in

[PATCH] of: overlay: make pr_err() string unique

2017-10-19 Thread frowand . list
From: Frank Rowand The same error string occurs in drivers/of/resolver.c. Change the error here to more precisely describe this case, and avoid the possible confusion of looking in the wrong source location to understand the cause of an error. Signed-off-by: Frank Rowand --- And yes, I was lo

[PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove

2017-10-19 Thread frowand . list
From: Frank Rowand A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP, or an embedded errno. overlay_notify() incorrectly reports an error for NOTIFY_OK. Reported-by: at...@kernel.org Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 01/12] of: overlay.c: Remove comments that state the obvious, to reduce clutter

2017-10-17 Thread frowand . list
From: Frank Rowand Follows recommendations in Documentation/process/coding-style.rst, section 8, Commenting. Some in function comments are promoted to function header comments. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 47 ++- 1 file ch

[PATCH v3 06/12] of: overlay: detect cases where device tree may become corrupt

2017-10-17 Thread frowand . list
From: Frank Rowand When an attempt to apply an overlay changeset fails, an effort is made to revert any partial application of the changeset. When an attempt to remove an overlay changeset fails, an effort is made to re-apply any partial reversion of the changeset. The existing code does not che

[PATCH v3 02/12] of: overlay.c: Convert comparisons to zero or NULL to logical expressions

2017-10-17 Thread frowand . list
From: Frank Rowand Use normal shorthand for comparing a variable to zero. For variable "XXX": convert (XXX == 0) to (!XXX) convert (XXX != 0) to (XXX) Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 36 ++-- 1 file changed, 18 insertions(+), 18 dele

[PATCH v3 05/12] of: overlay: minor restructuring

2017-10-17 Thread frowand . list
From: Frank Rowand Continue improving the readability of overlay.c. The previous patches renamed identifiers. This patch is split out from the previous patches to make the previous patches easier to review. Changes are: - minor code restructuring - some initialization of an overlay changes

[PATCH v3 07/12] of: overlay: expand check of whether overlay changeset can be removed

2017-10-17 Thread frowand . list
From: Frank Rowand The test of whether it is safe to remove an overlay changeset looked at whether any node in the overlay changeset was in a subtree rooted at any more recently applied overlay changeset node. The test failed to determine whether any node in the overlay changeset was the root of

[PATCH v3 08/12] of: overlay: loosen overly strict phandle clash check

2017-10-17 Thread frowand . list
From: Frank Rowand When an overlay contains a node that already exists in the live device tree, the overlay node is not allowed to change the phandle of the existing node. The existing check refused to allow an overlay node to set the node phandle even when the existing node did not have a phand

[PATCH v3 09/12] of: overlay: avoid race condition between applying multiple overlays

2017-10-17 Thread frowand . list
From: Frank Rowand The process of applying an overlay consists of: - unflatten an overlay FDT (flattened device tree) into an EDT (expanded device tree) - fixup the phandle values in the overlay EDT to fit in a range above the phandle values in the live device tree - create the over

[PATCH v3 03/12] of: overlay: rename identifiers to more reflect what they do

2017-10-17 Thread frowand . list
From: Frank Rowand This patch is aimed primarily at drivers/of/overlay.c, but those changes also have a small impact in a few other files. overlay.c is difficult to read and maintain. Improve readability: - Rename functions, types and variables to better reflect what they do and to be con

[PATCH v3 11/12] of: overlay: remove a dependency on device node full_name

2017-10-17 Thread frowand . list
From: Frank Rowand The "%pOF" printf format was recently added to print the full name of a device tree node, with the intent of changing the node full_name field to contain only the node name instead of the full path of the node. dup_and_fixup_symbol_prop() duplicates a property from the "/__sym

[PATCH v3 10/12] of: overlay: simplify applying symbols from an overlay

2017-10-17 Thread frowand . list
From: Frank Rowand The code to apply symbols from an overlay to the live device tree was implemented with the intent to be minimally intrusive on the existing code. After recent restructuring of the overlay apply code, it is easier to disintangle the code that applies the symbols, and to make th

[PATCH v3 12/12] of: overlay: remove unneeded check for NULL kbasename()

2017-10-17 Thread frowand . list
From: Frank Rowand kbasename() will not return NULL if passed a valid string. If the parameter passed to kbasename() in this case is already NULL then the devicetree has been corrupted. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/d

[PATCH v3 00/12] of: overlay: clean up device tree overlay code

2017-10-17 Thread frowand . list
From: Frank Rowand I have found the device tree overlay code to be difficult to read and maintain. This patch series attempts to improve that situation. The cleanup includes some changes visible to users of overlays. The only in kernel user of overlays is fixed up for those changes. The in ke

[PATCH v3 04/12] of: overlay: rename identifiers in dup_and_fixup_symbol_prop()

2017-10-17 Thread frowand . list
From: Frank Rowand More renaming of identifiers to better reflect what they do. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 69610637af88..bb8

[PATCH v2 02/12] of: overlay.c: Convert comparisons to zero or NULL to logical expressions

2017-10-16 Thread frowand . list
From: Frank Rowand Use normal shorthand for comparing a variable to zero. For variable "XXX": convert (XXX == 0) to (!XXX) convert (XXX != 0) to (XXX) Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 36 ++-- 1 file changed, 18 insertions(+), 18 dele

[PATCH v2 01/12] of: overlay.c: Remove comments that state the obvious, to reduce clutter

2017-10-16 Thread frowand . list
From: Frank Rowand Follows recommendations in Documentation/process/coding-style.rst, section 8, Commenting. Some in function comments are promoted to function header comments. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 53 1 fi

[PATCH v2 04/12] of: overlay: rename identifiers in dup_and_fixup_symbol_prop()

2017-10-16 Thread frowand . list
From: Frank Rowand More renaming of identifiers to better reflect what they do. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 397ef10d1f26..c35

[PATCH v2 05/12] of: overlay: minor restructuring

2017-10-16 Thread frowand . list
From: Frank Rowand Continue improving the readability of overlay.c. The previous patches renamed identifiers. This patch is split out from the previous patches to make the previous patches easier to review. Changes are: - minor code restructuring - some initialization of an overlay changes

[PATCH v2 06/12] of: overlay: detect cases where device tree may become corrupt

2017-10-16 Thread frowand . list
From: Frank Rowand When an attempt to apply an overlay changeset fails, an effort is made to revert any partial application of the changeset. When an attempt to remove an overlay changeset fails, an effort is made to re-apply any partial reversion of the changeset. The existing code does not che

[PATCH v2 08/12] of: overlay: loosen overly strict phandle clash check

2017-10-16 Thread frowand . list
From: Frank Rowand When an overlay contains a node that already exists in the live device tree, the overlay node is not allowed to change the phandle of the existing node. The existing check refused to allow an overlay node to set the node phandle even when the existing node did not have a phand

[PATCH v2 03/12] of: overlay: rename identifiers to more reflect what they do

2017-10-16 Thread frowand . list
From: Frank Rowand This patch is aimed primarily at drivers/of/overlay.c, but those changes also have a small impact in a few other files. overlay.c is difficult to read and maintain. Improve readability: - Rename functions, types and variables to better reflect what they do and to be con

[PATCH v2 10/12] of: overlay: simplify applying symbols from an overlay

2017-10-16 Thread frowand . list
From: Frank Rowand The code to apply symbols from an overlay to the live device tree was implemented with the intent to be minimally intrusive on the existing code. After recent restructuring of the overlay apply code, it is easier to disintangle the code that applies the symbols, and to make th

[PATCH v2 09/12] of: overlay: avoid race condition between applying multiple overlays

2017-10-16 Thread frowand . list
From: Frank Rowand The process of applying an overlay consists of: - unflatten an overlay FDT (flattened device tree) into an EDT (expanded device tree) - fixup the phandle values in the overlay EDT to fit in a range above the phandle values in the live device tree - create the over

[PATCH v2 00/12] of: overlay: clean up device tree overlay code

2017-10-16 Thread frowand . list
From: Frank Rowand I have found the device tree overlay code to be difficult to read and maintain. This patch series attempts to improve that situation. The cleanup includes some changes visible to users of overlays. The only in kernel user of overlays is fixed up for those changes. The in ke

[PATCH v2 11/12] of: overlay: remove a dependency on device node full_name

2017-10-16 Thread frowand . list
From: Frank Rowand The "%pOF" printf format was recently added to print the full name of a device tree node, with the intent of changing the node full_name field to contain only the node name instead of the full path of the node. dup_and_fixup_symbol_prop() duplicates a property from the "/__sym

[PATCH v2 07/12] of: overlay: expand check of whether overlay changeset can be removed

2017-10-16 Thread frowand . list
From: Frank Rowand The test of whether it is safe to remove an overlay changeset looked at whether any node in the overlay changeset was in a subtree rooted at any more recently applied overlay changeset node. The test failed to determine whether any node in the overlay changeset was the root of

[PATCH v2 12/12] of: overlay: remove unneeded check for NULL kbasename()

2017-10-16 Thread frowand . list
From: Frank Rowand kbasename() will not return NULL if passed a valid string. If the parameter passed to kbasename() in this case is already NULL then the devicetree has been corrupted. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/d

[PATCH] of: overlay: move resolve phandles into of_overlay_apply()

2017-10-10 Thread frowand . list
From: Frank Rowand Move more code into of_overlay_apply() so that it does not have to be duplicated by each caller of of_overlay_apply(). The test in of_resolve_phandles() that the overlay tree is detached is temporarily disabled so that old style overlay unittests do not fail. Signed-off-by: F

[PATCH 01/12] of: overlay.c: Remove comments that state the obvious, to reduce clutter

2017-10-02 Thread frowand . list
From: Frank Rowand Follows recommendations in Documentation/process/coding-style.rst, section 8, Commenting. Some in function comments are promoted to function header comments. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 53 1 fi

[PATCH 03/12] of: overlay: rename identifiers to more reflect what they do

2017-10-02 Thread frowand . list
From: Frank Rowand This patch is aimed primarily at drivers/of/overlay.c, but those changes also have a small impact in a few other files. overlay.c is difficult to read and maintain. Improve readability: - Rename functions, types and variables to better reflect what they do and to be con

[PATCH 00/12] of: overlay: clean up device tree overlay code

2017-10-02 Thread frowand . list
From: Frank Rowand I have found the device tree overlay code to be difficult to read and maintain. This patch series attempts to improve that situation. The cleanup includes some changes visible to users of overlays. The only in kernel user of overlays is fixed up for those changes. The in ke

[PATCH 04/12] of: overlay: rename identifiers in dup_and_fixup_symbol_prop()

2017-10-02 Thread frowand . list
From: Frank Rowand More renaming of identifiers to better reflect what they do. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 397ef10d1f26..c35

[PATCH 07/12] of: overlay: expand check of whether overlay changeset can be removed

2017-10-02 Thread frowand . list
From: Frank Rowand The test of whether it is safe to remove an overlay changeset looked at whether any node in the overlay changeset was in a subtree rooted at any more recently applied overlay changeset node. The test failed to determine whether any node in the overlay changeset was the root of

[PATCH 06/12] of: overlay: detect cases where device tree may become corrupt

2017-10-02 Thread frowand . list
From: Frank Rowand When an attempt to apply an overlay changeset fails, an effort is made to revert any partial application of the changeset. When an attempt to remove an overlay changeset fails, an effort is made to re-apply any partial reversion of the changeset. The existing code does not che

[PATCH 08/12] of: overlay: loosen overly strict phandle clash check

2017-10-02 Thread frowand . list
From: Frank Rowand When an overlay contains a node that already exists in the live device tree, the overlay node is not allowed to change the phandle of the existing node. The existing check refused to allow an overlay node to set the node phandle even when the existing node did not have a phand

[PATCH 02/12] of: overlay.c: Convert comparisons to zero or NULL to logical expressions

2017-10-02 Thread frowand . list
From: Frank Rowand Use normal shorthand for comparing a variable to zero. For variable "XXX": convert (XXX == 0) to (!XXX) convert (XXX != 0) to (XXX) Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 36 ++-- 1 file changed, 18 insertions(+), 18 dele

[PATCH 11/12] of: overlay: remove a dependency on device node full_name

2017-10-02 Thread frowand . list
From: Frank Rowand The "%pOF" printf format was recently added to print the full name of a device tree node, with the intent of changing the node full_name field to contain only the node name instead of the full path of the node. dup_and_fixup_symbol_prop() duplicates a property from the "/__sym

[PATCH 10/12] of: overlay: simplify applying symbols from an overlay

2017-10-02 Thread frowand . list
From: Frank Rowand The code to apply symbols from an overlay to the live device tree was implemented with the intent to be minimally intrusive on the existing code. After recent restructuring of the overlay apply code, it is easier to disintangle the code that applies the symbols, and to make th

[PATCH 05/12] of: overlay: minor restructuring

2017-10-02 Thread frowand . list
From: Frank Rowand Continue improving the readability of overlay.c. The previous patches renamed identifiers. This patch is split out from the previous patches to make the previous patches easier to review. Changes are: - minor code restructuring - some initialization of an overlay changes

[PATCH 09/12] of: overlay: avoid race condition between applying multiple overlays

2017-10-02 Thread frowand . list
From: Frank Rowand The process of applying an overlay consists of: - unflatten an overlay FDT (flattened device tree) into an EDT (expanded device tree) - fixup the phandle values in the overlay EDT to fit in a range above the phandle values in the live device tree - create the over

[PATCH 12/12] of: overlay: remove unneeded check for NULL kbasename()

2017-10-02 Thread frowand . list
From: Frank Rowand kbasename() will not return NULL if passed a valid string. If the parameter passed to kbasename() in this case is already NULL then the devicetree has been corrupted. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/d

[PATCH v3] scripts/dtc: dtx_diff - 2nd update of include dts paths to match build

2017-09-18 Thread frowand . list
From: Frank Rowand Update dtx_diff include paths in the same manner as: commit b12869a8d519 ("of: remove drivers/of/testcase-data from include search path for CPP"), commit 5ffa2aed389c ("of: remove arch/$(SRCARCH)/boot/dts from include search path for CPP"), and commit 50f9ddaf64e1 ("of: search

[PATCH v2] scripts/dtc: dtx_diff - 2nd update of include dts paths to

2017-09-18 Thread frowand . list
From: Frank Rowand Update dtx_diff include paths in the same manner as: commit b12869a8d519 ("of: remove drivers/of/testcase-data from include search path for CPP"), commit 5ffa2aed389c ("of: remove arch/$(SRCARCH)/boot/dts from include search path for CPP"), and commit 50f9ddaf64e1 ("of: search

[PATCH] scripts/dtc: update dtx_diff cpp and dts include paths to match build

2017-09-15 Thread frowand . list
From: Frank Rowand Update dtx_diff include paths in the same manner as: commit b12869a8d519 ("of: remove drivers/of/testcase-data from include search path for CPP"), commit 5ffa2aed389c ("of: remove arch/$(SRCARCH)/boot/dts from include search path for CPP"), and commit 50f9ddaf64e1 ("of: search

[PATCH] docs: submitting-patches - change non-ascii character to ascii

2017-07-20 Thread frowand . list
From: Frank Rowand Documentation/process/submitting-patches.rst contains a non-ascii character. Change it to the ascii equivalent. Signed-off-by: Frank Rowand --- Documentation/process/submitting-patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/pro

[PATCH 1/2] MAINTAINERS: device property: acpi: add fwnode.h

2017-07-20 Thread frowand . list
From: Frank Rowand ACPI is impacted by changes to fwnode.h, add a file entry to ACPI Signed-off-by: Frank Rowand --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 205d3977ac46..c0ac362e850a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -302,6 +

[PATCH 0/2] add fwnode.h to several MAINTAINERS entries

2017-07-20 Thread frowand . list
From: Frank Rowand Rafael, can you please take patch 1? Rob, can you please take patch 2? Several maintainers are impacted by changes to fwnode.h, add a file entry for those maintainers. Frank Rowand (2): MAINTAINERS: device property: acpi: add fwnode.h MAINTAINERS: device property: of: ad

[PATCH 2/2] MAINTAINERS: device property: of: add fwnode.h

2017-07-20 Thread frowand . list
From: Frank Rowand Device tree is impacted by changes to fwnode.h, add a file entry to OPEN FIRMWARE AND FLATTENED DEVICE TREE Signed-off-by: Frank Rowand --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c0ac362e850a..cb58c20b1ef8 100644 --- a

[PATCH] scripts/dtc: dtx_diff - update include dts paths to match build

2017-07-19 Thread frowand . list
From: Frank Rowand Update the cpp include flags for compiling device tree dts files to match the changes made to the kernel build process in commit d5d332d3f7e8 ("devicetree: Move include prefixes from arch to separate directory"). Cc: # 4.12 Signed-off-by: Frank Rowand --- scripts/dtc/dtx_di

[PATCH v4 2/3] of: overlay: correctly apply overlay node with unit-address

2017-07-19 Thread frowand . list
From: Frank Rowand Correct existing node name detection when overlay node name has a unit-address. Expected test result is overlay will update the nodes and properties for /testcase-data-2/fairway-1/ride@100/ after this commit. Before this commit: Console error message near end of unittest:

[PATCH v4 1/3] of: overlay: add overlay unittest data for node names and symbols

2017-07-19 Thread frowand . list
From: Frank Rowand Add nodes and properties to overlay_base and overlay dts files to test for - incorrect existing node name detection when overlay node name has a unit-address - adding overlay __symbols__ properties to live tree when an overlay is added to the live tree The foll

[PATCH v4 3/3] of: overlay: add overlay symbols to live device tree

2017-07-19 Thread frowand . list
From: Frank Rowand Add overlay __symbols__ properties to live tree when an overlay is added to the live tree so that the symbols are available to subsequent overlays. Expected test result is new __symbols__ entries for labels from the overlay after this commit. Before this commit: Console e

[PATCH v4 0/3] of: overlay: load overlay symbols into live device tree

2017-07-19 Thread frowand . list
From: Frank Rowand Symbols in a loaded overlay are not currently available to subsequently loaded overlays because the properties in the overlay's __symbols__ node are not loaded into the live device tree. Patch 1 is unittests to test patches 2 and 3. Patch 2 fixes a problem discovered while de

[PATCH v3 1/3] of: overlay: add overlay unittest data for node names and symbols

2017-07-18 Thread frowand . list
From: Frank Rowand Add nodes and properties to overlay_base and overlay dts files to test for - incorrect existing node name detection when overlay node name has a unit-address - adding overlay __symbols__ properties to live tree when an overlay is added to the live tree The foll

[PATCH v3 3/3] of: overlay: add overlay symbols to live device tree

2017-07-18 Thread frowand . list
From: Frank Rowand Add overlay __symbols__ properties to live tree when an overlay is added to the live tree so that the symbols are available to subsequent overlays. Expected test result is new __symbols__ entries for labels from the overlay after this commit. Before this commit: Console e

[PATCH v3 0/3] of: overlay: load overlay symbols into live device tree

2017-07-18 Thread frowand . list
From: Frank Rowand Symbols in a loaded overlay are not currently available to subsequently loaded overlays because the properties in the overlay's __symbols__ node are not loaded into the live device tree. Patch 1 is unittests to test patches 2 and 3. Patch 2 fixes a problem discovered while de

[PATCH v3 2/3] of: overlay: correctly apply overlay node with unit-address

2017-07-18 Thread frowand . list
From: Frank Rowand Correct existing node name detection when overlay node name has a unit-address. Expected test result is overlay will update the nodes and properties for /testcase-data-2/fairway-1/ride@100/ after this commit. Before this commit: Console error message near end of unittest:

[PATCH] regulator: of: regulator_of_get_init_data() missing of_node_get()

2017-07-18 Thread frowand . list
From: Frank Rowand Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error: OF: ERROR: Bad of_node_put() on /soc/spmi@fc4cf000/pm8941@1/regulators The error will occur if the configuration is set to: CONFIG_OF_OVERLAY y CONFIG_OF_UNITTEST y CONFIG_OF_DYNAMIC y CONFIG_OF_RESOLV

[PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()

2017-07-18 Thread frowand . list
From: Frank Rowand Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error: OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000 The error will occur if the configuration is set to: CONFIG_OF_OVERLAY y CONFIG_OF_UNITTEST y CONFIG_OF_DYNAMIC y CONFIG_OF_RESOLVE y If CONFIG_OF_DYN

[PATCH v2 3/3] of: overlay: add overlay symbols to live device tree

2017-07-10 Thread frowand . list
From: Frank Rowand Add overlay __symbols__ properties to live tree when an overlay is added to the live tree so that the symbols are available to subsequent overlays. Expected test result is new __symbols__ entries for labels from the overlay after the patch is applied. Before this patch is app

[PATCH v2 0/3] of: overlay: load overlay symbols into live device tree

2017-07-10 Thread frowand . list
From: Frank Rowand Symbols in a loaded overlay are not currently available to subsequently loaded overlays because the properties in the overlay's __symbols__ node are not loaded into the live device tree. Patch 1 is unittests to test patches 2 and 3. Patch 2 fixes a problem discovered while de

[PATCH v2 1/3] of: overlay: add overlay unittest data for node names and symbols

2017-07-10 Thread frowand . list
From: Frank Rowand Add nodes and properties to overlay_base and overlay dts files to test for - incorrect existing node name detection when overlay node name has a unit-address - adding overlay __symbols__ properties to live tree when an overlay is added to the live tree Expected

[PATCH v2 2/3] of: overlay: correctly apply overlay node with unit-address

2017-07-10 Thread frowand . list
From: Frank Rowand Correct existing node name detection when overlay node name has a unit-address. Expected test result is overlay will update the nodes and properties for /testcase-data-2/fairway-1/ride@100/ after the patch is applied. Before this patch is applied: Console error message ne

[PATCH 1/3] of: overlay: add overlay unittest data for node names and symbols

2017-07-07 Thread frowand . list
From: Frank Rowand Add nodes and properties to overlay_base and overlay dts files to test for - incorrect existing node name detection when overlay node name has a unit-address - adding overlay __symbols__ properties to live tree when an overlay is added to the live tree Expected

[PATCH 2/3] of: overlay: correctly apply overlay node with unit-address

2017-07-07 Thread frowand . list
From: Frank Rowand Correct existing node name detection when overlay node name has a unit-address. Expected test result is overlay will update the nodes and properties for /testcase-data-2/fairway-1/ride@100/ after the patch is applied. Before this patch is applied: Console error message ne

[PATCH 3/3] of: overlay: add overlay symbols to live device tree

2017-07-07 Thread frowand . list
From: Frank Rowand Add overlay __symbols__ properties to live tree when an overlay is added to the live tree so that the symbols are available to subsequent overlays. Expected test result is new __symbols__ entries for labels from the overlay after the patch is applied. Before this patch is app

[PATCH 0/3] of: overlay: load overlay symbols into live device tree

2017-07-07 Thread frowand . list
From: Frank Rowand Symbols in a loaded overlay are not currently available to subsequently loaded overlays because the properties in the overlay's __symbols__ node are not loaded into the live device tree. Patch 1 is unittests to test patches 2 and 3. Patch 2 fixes a problem discovered while de

[PATCH v3] of: document /sys/firmware/fdt

2017-06-28 Thread frowand . list
From: Frank Rowand Add ABI documentation for /sys/firmware/fdt Update contact email for /sys/firmware/devicetree/* and add mail list Signed-off-by: Frank Rowand --- changes from v2: - ignore v2, v3 is based on v1 changes from v1: - updated Grant's email address - updated Frank's email

[PATCH v2] of: document /sys/firmware/fdt

2017-06-28 Thread frowand . list
From: Frank Rowand Add ABI documentation for /sys/firmware/fdt Change obsolete contact for /sys/firmware/devicetree/* to mail list Signed-off-by: Frank Rowand --- changes from v1: - Remove obsolete email address as contact for /sys/firmware/devicetree/* - For newly documented /sys/firmwar

[PATCH v2] of: update ePAPR references to point to Devicetree Specification

2017-06-22 Thread frowand . list
From: Frank Rowand The Devicetree Specification has superseded the ePAPR as the base specification for bindings. Update files in Documentation to reference the new document. First reference to ePAPR in Documentation/devicetree/bindings/arm/cci.txt is generic, remove it. Some files are not upda

[PATCH] of: detect invalid phandle in overlay

2017-06-21 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4 in

[PATCH] of: be consistent in form of file mode

2017-06-21 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that pending patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1

[PATCH] of: make __of_attach_node() static

2017-06-21 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH] of: address.c header comment typo

2017-06-20 Thread frowand . list
From: Frank Rowand Fix typo in header comment for of_address_to_resource() Signed-off-by: Frank Rowand --- drivers/of/address.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index 72914cdfce2a..580bbf6ca2b1 100644 --- a/drivers/

[PATCH] of: fdt.c header comment typo

2017-06-20 Thread frowand . list
From: Frank Rowand Fix typo in header comment for early_init_dt_scan_memory() Signed-off-by: Frank Rowand --- drivers/of/fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 3080d9dd031d..c053b4f4fbc1 100644 --- a/drivers/of/fdt.c

[PATCH] of: make of_fdt_is_compatible() static

2017-06-20 Thread frowand . list
From: Frank Rowand The callers of of_fdt_is_compatible() are all in fdt.c so make it static. Signed-off-by: Frank Rowand --- drivers/of/fdt.c | 2 +- include/linux/of_fdt.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index 30

[PATCH] dt-bindings: display-timing.txt convert non-ascii characters to ascii

2017-06-20 Thread frowand . list
From: Frank Rowand Convert non-ascii up and down arrows to '^' and 'v' Signed-off-by: Frank Rowand --- .../devicetree/bindings/display/panel/display-timing.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/d

[PATCH] Documentation: remove overlay-notes reference to non-existent file

2017-06-20 Thread frowand . list
From: Frank Rowand File dt-object-internal.txt does not exist. Remove a reference to it and fix up tags for references to other files. Reported-by: afaer...@suse.de Signed-off-by: Frank Rowand --- Documentation/devicetree/overlay-notes.txt | 8 +++- 1 file changed, 3 insertions(+), 5 dele

[PATCH v6 0/4] of: remove *phandle properties from expanded device tree

2017-06-20 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field and will still be displayed as if it is a property in /proc/device_tree. This is to resolve the issue found by Stephen Boyd [1] whe

[PATCH v6 2/4] of: make __of_attach_node() static

2017-06-20 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH v6 3/4] of: be consistent in form of file mode

2017-06-20 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1 file cha

[PATCH v6 1/4] of: remove *phandle properties from expanded device tree

2017-06-20 Thread frowand . list
From: Frank Rowand Remove "phandle", "linux,phandle", and "ibm,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field and will still be displayed as if it is a property in /proc/device_tree. This is to resolve the issue found by Step

[PATCH v6 4/4] of: detect invalid phandle in overlay

2017-06-20 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4 in

[PATCH] of: document /sys/firmware/fdt

2017-06-13 Thread frowand . list
From: Frank Rowand Add ABI documentation for /sys/firmware/fdt Update contact for /sys/firmware/devicetree/* to include mail list Signed-off-by: Frank Rowand --- Documentation/ABI/testing/sysfs-firmware-ofw | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) dif

[PATCH] of: update ePAPR references to point to Devicetree Specification

2017-06-13 Thread frowand . list
From: Frank Rowand The Devicetree Specification has superseded the ePAPR as the base specification for bindings. Update files in Documentation to reference the new document. Some files are not updated because there is no hypervisor chapter in the Devicetree Specification: Documentation/devic

[PATCH] MAINTAINERS: add device tree ABI documentation file

2017-06-13 Thread frowand . list
From: Frank Rowand sysfs-firmware-ofw describes the /sys/firmware/devicetree/ hierarchy and /proc/device-tree so add a file line for it to the entry OPEN FIRMWARE AND FLATTENED DEVICE TREE Signed-off-by: Frank Rowand --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINE

[PATCH v5 4/4] of: detect invalid phandle in overlay

2017-06-09 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup of properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4 in

[PATCH v5 2/4] of: make __of_attach_node() static

2017-06-09 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH v5 1/4] of: remove *phandle properties from expanded device tree

2017-06-09 Thread frowand . list
From: Frank Rowand Remove "phandle", "linux,phandle", and "ibm,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void

[PATCH v5 0/4] of: remove *phandle properties from expanded device tree

2017-06-09 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void

<    1   2   3   >