[PATCH] genwqe: Take R/W permissions into account when dealing with memory pages

2017-10-20 Thread Guilherme G. Piccoli
of read-only-pages). Signed-off-by: Frank Haverkamp <ha...@linux.vnet.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- Arnd/Greg, we found this bug recently, although not critical, it's really a boring issue affecting driver functionality. If it's poss

[PATCH] genwqe: Take R/W permissions into account when dealing with memory pages

2017-10-20 Thread Guilherme G. Piccoli
of read-only-pages). Signed-off-by: Frank Haverkamp Signed-off-by: Guilherme G. Piccoli --- Arnd/Greg, we found this bug recently, although not critical, it's really a boring issue affecting driver functionality. If it's possible to take this patch still on v4.14, we'd be really thankful! But we

Re: [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset

2017-10-15 Thread Guilherme G. Piccoli
atch > proposed will PERST top level PHBs which will propagate as hot reset > down switches, not 100% PERST but still useful. > Exactly, this reset happens on early arch stage of PCI initialization, not trivial to drivers perform it. Anyway, let me know if you want a V2 with improvements or to drop it..I still see use cases for this. Thanks, Guilherme > Cheers, > Ben. >

Re: [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset

2017-10-15 Thread Guilherme G. Piccoli
atch > proposed will PERST top level PHBs which will propagate as hot reset > down switches, not 100% PERST but still useful. > Exactly, this reset happens on early arch stage of PCI initialization, not trivial to drivers perform it. Anyway, let me know if you want a V2 with improvements or to drop it..I still see use cases for this. Thanks, Guilherme > Cheers, > Ben. >

Re: [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset

2017-10-13 Thread Guilherme G. Piccoli
option to help the users, specifically the ones debugging drivers, to try using a hammer to recover bad devices! To this issue that I mentioned as an example, the fix specifically goes in the FW of the adapter. Anyway, since you really dislike it, let's drop it, no big deal! Cheers, Guilherme

Re: [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset

2017-10-13 Thread Guilherme G. Piccoli
option to help the users, specifically the ones debugging drivers, to try using a hammer to recover bad devices! To this issue that I mentioned as an example, the fix specifically goes in the FW of the adapter. Anyway, since you really dislike it, let's drop it, no big deal! Cheers, Guilherme

[PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset

2017-10-12 Thread Guilherme G. Piccoli
of it. This is a PowerPC-only change. Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- This patch was built/tested against powerpc/next branch. We recently had a situation in which i40e driver couldn't start, even after a full power cycle, due to a bug in its FW triggered by a DCB con

[PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset

2017-10-12 Thread Guilherme G. Piccoli
of it. This is a PowerPC-only change. Signed-off-by: Guilherme G. Piccoli --- This patch was built/tested against powerpc/next branch. We recently had a situation in which i40e driver couldn't start, even after a full power cycle, due to a bug in its FW triggered by a DCB condition in switch (thanks Mauro

Re: [PATCH v2] Documentation: rewrite confusing statement about memory barriers

2017-09-21 Thread Guilherme G. Piccoli
On 09/21/2017 04:50 PM, Paul E. McKenney wrote: > On Thu, Sep 21, 2017 at 04:29:01PM -0300, Guilherme G. Piccoli wrote: >> In this specific portion of the write memory barriers description, >> the documentation mentions sequential order of stores, which is >> confusing sinc

Re: [PATCH v2] Documentation: rewrite confusing statement about memory barriers

2017-09-21 Thread Guilherme G. Piccoli
On 09/21/2017 04:50 PM, Paul E. McKenney wrote: > On Thu, Sep 21, 2017 at 04:29:01PM -0300, Guilherme G. Piccoli wrote: >> In this specific portion of the write memory barriers description, >> the documentation mentions sequential order of stores, which is >> confusing sinc

[PATCH v2] Documentation: rewrite confusing statement about memory barriers

2017-09-21 Thread Guilherme G. Piccoli
aul...@linux.vnet.ibm.com> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- v2: added Paul in CC. Documentation/memory-barriers.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barrie

[PATCH v2] Documentation: rewrite confusing statement about memory barriers

2017-09-21 Thread Guilherme G. Piccoli
-by: Guilherme G. Piccoli --- v2: added Paul in CC. Documentation/memory-barriers.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index b759a60624fd..a4bbbd1b63a0 100644 --- a/Documentation/memory

[PATCH] Documentation: rewrite confusing statement about memory barriers

2017-09-21 Thread Guilherme G. Piccoli
In this specific portion of the write memory barriers description, the documentation mentions sequential order of stores, which is confusing since sequential ordering is not guaranteed. This patch tries to improve the doc in order to avoid any mis-understanding. Signed-off-by: Guilherme G

[PATCH] Documentation: rewrite confusing statement about memory barriers

2017-09-21 Thread Guilherme G. Piccoli
In this specific portion of the write memory barriers description, the documentation mentions sequential order of stores, which is confusing since sequential ordering is not guaranteed. This patch tries to improve the doc in order to avoid any mis-understanding. Signed-off-by: Guilherme G

Re: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA

2017-08-08 Thread Magalhaes, Guilherme (Brazil R)
? -- Guilherme > -Original Message- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: quinta-feira, 27 de julho de 2017 17:52 > To: Magalhaes, Guilherme (Brazil R) <guilherme.magalh...@hpe.com>; > Mimi Zohar <zo...@linux.vnet.ibm.com>; Serge E. Hal

Re: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA

2017-08-08 Thread Magalhaes, Guilherme (Brazil R)
? -- Guilherme > -Original Message- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: quinta-feira, 27 de julho de 2017 17:52 > To: Magalhaes, Guilherme (Brazil R) ; > Mimi Zohar ; Serge E. Hallyn > Cc: Mehmet Kayaalp ; Yuqiong Sun > ; containers foundati

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-28 Thread Magalhaes, Guilherme (Brazil R)
a measurement added to the parent namespace could be misleading since the file pathname makes sense in the current namespace but possibly not for the parent namespace. This is the reason why I believe some new field might be needed in the IMA template format to indicate or uniquely identify the namespace. -- Guilherme

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-28 Thread Magalhaes, Guilherme (Brazil R)
a measurement added to the parent namespace could be misleading since the file pathname makes sense in the current namespace but possibly not for the parent namespace. This is the reason why I believe some new field might be needed in the IMA template format to indicate or uniquely identify the namespace. -- Guilherme

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-27 Thread Magalhaes, Guilherme (Brazil R)
> -Original Message- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: quinta-feira, 27 de julho de 2017 14:50 > To: Magalhaes, Guilherme (Brazil R) > <guilherme.magalh...@hpe.com>; Mimi Zohar > <zo...@linux.vnet.ibm.com>; Serge E. Hallyn &

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-27 Thread Magalhaes, Guilherme (Brazil R)
> -Original Message- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: quinta-feira, 27 de julho de 2017 14:50 > To: Magalhaes, Guilherme (Brazil R) > ; Mimi Zohar > ; Serge E. Hallyn > Cc: Mehmet Kayaalp ; Yuqiong Sun > ; containers found

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-27 Thread Magalhaes, Guilherme (Brazil R)
> -Original Message- > From: Mimi Zohar [mailto:zo...@linux.vnet.ibm.com] > Sent: quinta-feira, 27 de julho de 2017 11:39 > To: Magalhaes, Guilherme (Brazil R) > <guilherme.magalh...@hpe.com>; Serge E. Hallyn <se...@hallyn.com> > Cc: Mehmet Kayaalp <mka

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-27 Thread Magalhaes, Guilherme (Brazil R)
> -Original Message- > From: Mimi Zohar [mailto:zo...@linux.vnet.ibm.com] > Sent: quinta-feira, 27 de julho de 2017 11:39 > To: Magalhaes, Guilherme (Brazil R) > ; Serge E. Hallyn > Cc: Mehmet Kayaalp ; Yuqiong Sun > ; containers foundation.org>; linux-kernel ;

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-27 Thread Magalhaes, Guilherme (Brazil R)
> -Original Message- > From: Mimi Zohar [mailto:zo...@linux.vnet.ibm.com] > Sent: terça-feira, 25 de julho de 2017 18:29 > To: Serge E. Hallyn > Cc: Mehmet Kayaalp ; Yuqiong Sun > ; containers

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-27 Thread Magalhaes, Guilherme (Brazil R)
> -Original Message- > From: Mimi Zohar [mailto:zo...@linux.vnet.ibm.com] > Sent: terça-feira, 25 de julho de 2017 18:29 > To: Serge E. Hallyn > Cc: Mehmet Kayaalp ; Yuqiong Sun > ; containers foundation.org>; linux-kernel ; David Safford > ; James Bottomley > ; linux-security-module

Re: [PATCH 1/3] PCI: ensure the PCI device is locked over ->reset_notify calls

2017-06-22 Thread Guilherme G. Piccoli
ug by injecting > errors while removing and rescanning devices below the bridge? Well, although I don't consider myself an enterprising soul...heheh I can test it, just CC me in next spin and provide some comment on how to test (or point me the thread of original report). I guess it was myself the reporter of the issue, I tried a simple fix for our case and Christoph mentioned issue was more generic and needed a proper fix.. Hopefully this one is that fix! Thanks, Guilherme > > Bjorn >

Re: [PATCH 1/3] PCI: ensure the PCI device is locked over ->reset_notify calls

2017-06-22 Thread Guilherme G. Piccoli
ug by injecting > errors while removing and rescanning devices below the bridge? Well, although I don't consider myself an enterprising soul...heheh I can test it, just CC me in next spin and provide some comment on how to test (or point me the thread of original report). I guess it was myself the reporter of the issue, I tried a simple fix for our case and Christoph mentioned issue was more generic and needed a proper fix.. Hopefully this one is that fix! Thanks, Guilherme > > Bjorn >

RE: [RFC 04/11] ima: add support to namespace securityfs file

2017-05-25 Thread Magalhaes, Guilherme (Brazil R)
on the same namespace. These mechanisms would not require a change in the proposed design. Do you think these mechanisms are enough for the flexibility you asked? Thanks. -- Guilherme -Original Message- From: Mimi Zohar [mailto:zo...@linux.vnet.ibm.com] Sent: quinta-feira, 25 de maio de 2017

RE: [RFC 04/11] ima: add support to namespace securityfs file

2017-05-25 Thread Magalhaes, Guilherme (Brazil R)
on the same namespace. These mechanisms would not require a change in the proposed design. Do you think these mechanisms are enough for the flexibility you asked? Thanks. -- Guilherme -Original Message- From: Mimi Zohar [mailto:zo...@linux.vnet.ibm.com] Sent: quinta-feira, 25 de maio de 2017

[PATCH] MAINTAINERS: Change maintainer of genwqe driver

2017-05-18 Thread Guilherme G. Piccoli
Gabriel won't maintain this driver anymore. So, I'll maintain it with Frank. Thanks Gabriel for all your work on genwqe. Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAI

[PATCH] MAINTAINERS: Change maintainer of genwqe driver

2017-05-18 Thread Guilherme G. Piccoli
Gabriel won't maintain this driver anymore. So, I'll maintain it with Frank. Thanks Gabriel for all your work on genwqe. Signed-off-by: Guilherme G. Piccoli --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f7d568b8f133

[RFC 07/11] ima: new namespace policy structure to track initial namespace policy data

2017-05-11 Thread Guilherme Magalhaes
the ima_initial_namespace_policy. If the given namespace has not yet defined a private IMA policy, the IMA policy for that namespace falls back to the initial IMA policy by using ima_initial_namespace_policy. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima

[RFC 07/11] ima: new namespace policy structure to track initial namespace policy data

2017-05-11 Thread Guilherme Magalhaes
the ima_initial_namespace_policy. If the given namespace has not yet defined a private IMA policy, the IMA policy for that namespace falls back to the initial IMA policy by using ima_initial_namespace_policy. Signed-off-by: Guilherme Magalhaes --- security/integrity/ima/ima.h| 6 ++ security

[RFC 06/11] ima, fs: release namespace policy resources

2017-05-11 Thread Guilherme Magalhaes
Release all namespace IMA policy resources when the mount namespace is released. This is the suggested mechanism to release namespace policy resources, but we still can discuss other methods to avoid cross-component changes. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> -

[RFC 06/11] ima, fs: release namespace policy resources

2017-05-11 Thread Guilherme Magalhaes
Release all namespace IMA policy resources when the mount namespace is released. This is the suggested mechanism to release namespace policy resources, but we still can discuss other methods to avoid cross-component changes. Signed-off-by: Guilherme Magalhaes --- fs/namespace.c

[RFC 08/11] ima: block initial namespace id on the namespace policy interface

2017-05-11 Thread Guilherme Magalhaes
The initial namespace policy is set through the existent interface in the ima/policy securityfs file. Block the initial namespace id when it is written to the ima/namespace securityfs file. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima/ima_fs.

[RFC 08/11] ima: block initial namespace id on the namespace policy interface

2017-05-11 Thread Guilherme Magalhaes
The initial namespace policy is set through the existent interface in the ima/policy securityfs file. Block the initial namespace id when it is written to the ima/namespace securityfs file. Signed-off-by: Guilherme Magalhaes --- security/integrity/ima/ima_fs.c | 18 ++ 1 file

[RFC 05/11] ima: store new namespace policy structure in a radix tree

2017-05-11 Thread Guilherme Magalhaes
id from the current context. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima/ima.h| 37 + security/integrity/ima/ima_fs.c | 79 ++--- security/integrity/ima/ima_init.c | 2 + se

[RFC 05/11] ima: store new namespace policy structure in a radix tree

2017-05-11 Thread Guilherme Magalhaes
id from the current context. Signed-off-by: Guilherme Magalhaes --- security/integrity/ima/ima.h| 37 + security/integrity/ima/ima_fs.c | 79 ++--- security/integrity/ima/ima_init.c | 2 + security/integrity/ima/ima_policy.c | 29

[RFC 04/11] ima: add support to namespace securityfs file

2017-05-11 Thread Guilherme Magalhaes
. With this interface, there is no need to give visibility for the securityfs inside mount namespaces or containers in userspace. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima/ima.h| 4 + security/integrity/ima/ima_fs.c

[RFC 04/11] ima: add support to namespace securityfs file

2017-05-11 Thread Guilherme Magalhaes
. With this interface, there is no need to give visibility for the securityfs inside mount namespaces or containers in userspace. Signed-off-by: Guilherme Magalhaes --- security/integrity/ima/ima.h| 4 + security/integrity/ima/ima_fs.c | 183 2 files

[RFC 09/11] ima: delete namespace policy securityfs file in write-once mode

2017-05-11 Thread Guilherme Magalhaes
When policy file is written and write-once is enabled, the policy file must be deleted. Select the namespace policy structure to get the correct policy file descriptor. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima/ima_fs.

[RFC 09/11] ima: delete namespace policy securityfs file in write-once mode

2017-05-11 Thread Guilherme Magalhaes
When policy file is written and write-once is enabled, the policy file must be deleted. Select the namespace policy structure to get the correct policy file descriptor. Signed-off-by: Guilherme Magalhaes --- security/integrity/ima/ima_fs.c | 27 +-- 1 file changed, 25

[RFC 02/11] ima: qualify pathname in audit measurement record

2017-05-11 Thread Guilherme Magalhaes
by a different namespace. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima/ima_api.c | 8 1 file changed, 8 insertions(+) diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c index c2edba8..b05c1fd 100644 --- a/security/int

[RFC 02/11] ima: qualify pathname in audit measurement record

2017-05-11 Thread Guilherme Magalhaes
by a different namespace. Signed-off-by: Guilherme Magalhaes --- security/integrity/ima/ima_api.c | 8 1 file changed, 8 insertions(+) diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c index c2edba8..b05c1fd 100644 --- a/security/integrity/ima/ima_api.c +++ b/security

[RFC 03/11] ima: qualify pathname in measurement file

2017-05-11 Thread Guilherme Magalhaes
-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima/Kconfig| 8 security/integrity/ima/ima.h | 12 ++ security/integrity/ima/ima_template.c | 10 - security/integrity/ima/ima_template_lib.

[RFC 03/11] ima: qualify pathname in measurement file

2017-05-11 Thread Guilherme Magalhaes
-by: Guilherme Magalhaes --- security/integrity/ima/Kconfig| 8 security/integrity/ima/ima.h | 12 ++ security/integrity/ima/ima_template.c | 10 - security/integrity/ima/ima_template_lib.c | 70 +++ security/integrity/ima

[RFC 01/11] ima: qualify pathname in audit info record

2017-05-11 Thread Guilherme Magalhaes
and later reused by a different namespace. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/integrity_audit.c | 5 + 1 file changed, 5 insertions(+) diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c index 9

[RFC 01/11] ima: qualify pathname in audit info record

2017-05-11 Thread Guilherme Magalhaes
and later reused by a different namespace. Signed-off-by: Guilherme Magalhaes --- security/integrity/integrity_audit.c | 5 + 1 file changed, 5 insertions(+) diff --git a/security/integrity/integrity_audit.c b/security/integrity/integrity_audit.c index 90987d1..e675e42 100644 --- a/security

[RFC 10/11] ima: handling all policy flags per namespace using ima_ns_policy structure

2017-05-11 Thread Guilherme Magalhaes
() functions. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima/ima.h | 17 +++--- security/integrity/ima/ima_api.c | 6 +- security/integrity/ima/ima_appraise.c | 21 +-- security/integrity/ima/ima_fs.c | 26 ++--- se

[RFC 10/11] ima: handling all policy flags per namespace using ima_ns_policy structure

2017-05-11 Thread Guilherme Magalhaes
() functions. Signed-off-by: Guilherme Magalhaes --- security/integrity/ima/ima.h | 17 +++--- security/integrity/ima/ima_api.c | 6 +- security/integrity/ima/ima_appraise.c | 21 +-- security/integrity/ima/ima_fs.c | 26 ++--- security/integrity/ima/ima_init.c

[RFC 00/11] ima: namespace support for IMA policy

2017-05-11 Thread Guilherme Magalhaes
to completely namespace IMA. For instance, EVM and templates per namespace are not yet covered. Guilherme Magalhaes (11): ima: qualify pathname in audit info record ima: qualify pathname in audit measurement record ima: qualify pathname in measurement file ima: add support to namespace securityfs

[RFC 00/11] ima: namespace support for IMA policy

2017-05-11 Thread Guilherme Magalhaes
to completely namespace IMA. For instance, EVM and templates per namespace are not yet covered. Guilherme Magalhaes (11): ima: qualify pathname in audit info record ima: qualify pathname in audit measurement record ima: qualify pathname in measurement file ima: add support to namespace securityfs

[RFC 11/11] ima: appraise mode per namespace with new enforce_ns appraise mode

2017-05-11 Thread Guilherme Magalhaes
while namespaces can set their appraise modes separatedly. Signed-off-by: Guilherme Magalhaes <guilherme.magalh...@hpe.com> --- security/integrity/ima/ima.h | 6 +- security/integrity/ima/ima_appraise.c | 11 +++ security/integrity/ima/ima_fs.c | 7 ++- se

[RFC 11/11] ima: appraise mode per namespace with new enforce_ns appraise mode

2017-05-11 Thread Guilherme Magalhaes
while namespaces can set their appraise modes separatedly. Signed-off-by: Guilherme Magalhaes --- security/integrity/ima/ima.h | 6 +- security/integrity/ima/ima_appraise.c | 11 +++ security/integrity/ima/ima_fs.c | 7 ++- security/integrity/ima/ima_main.c

RE: [RFC 00/11] ima: namespace support for IMA policy

2017-05-11 Thread Magalhaes, Guilherme (Brazil R)
different appraise modes per namespace. -- Guilherme -Original Message- From: Magalhaes, Guilherme (Brazil R) Sent: quinta-feira, 11 de maio de 2017 11:00 To: dmitry.kasat...@gmail.com; zo...@linux.vnet.ibm.com Cc: v...@zeniv.linux.org.uk; james.l.mor...@oracle.com; se...@hallyn.com

RE: [RFC 00/11] ima: namespace support for IMA policy

2017-05-11 Thread Magalhaes, Guilherme (Brazil R)
different appraise modes per namespace. -- Guilherme -Original Message- From: Magalhaes, Guilherme (Brazil R) Sent: quinta-feira, 11 de maio de 2017 11:00 To: dmitry.kasat...@gmail.com; zo...@linux.vnet.ibm.com Cc: v...@zeniv.linux.org.uk; james.l.mor...@oracle.com; se...@hallyn.com

Re: [PATCH] powerpc/xmon: Fix an unexpected xmon onoff state change

2017-02-17 Thread Guilherme G. Piccoli
tively disables xmon for most of the boot, which we do not >> want to do. >> > Although it is not often that kernel got stucked during boot. Yes, the > behavior changed anyway. Will fix that in v3. Pan/Michael, I'm working my patches on top of Pan's. So, I sent his V2 on my series, as patch #1. Guess the workflow is better/easier if we can work the patches on the series exclusively, since each time Pan's patch is changed, I need to refactor my patches. Pan, if possible send your V3 to me, I'll refactor my series on top of it and send again on the list. Or if you or Michael have better suggestions of workflow, let me know. Thanks, Guilherme > >> cheers >> >

Re: [PATCH] powerpc/xmon: Fix an unexpected xmon onoff state change

2017-02-17 Thread Guilherme G. Piccoli
hich we do not >> want to do. >> > Although it is not often that kernel got stucked during boot. Yes, the > behavior changed anyway. Will fix that in v3. Pan/Michael, I'm working my patches on top of Pan's. So, I sent his V2 on my series, as patch #1. Guess the workflow is better/easier if we can work the patches on the series exclusively, since each time Pan's patch is changed, I need to refactor my patches. Pan, if possible send your V3 to me, I'll refactor my series on top of it and send again on the list. Or if you or Michael have better suggestions of workflow, let me know. Thanks, Guilherme > >> cheers >> >

Re: [PATCH] powerpc/xmon: Fix an unexpected xmon onoff state change

2017-02-16 Thread Guilherme G. Piccoli
gt; +if (xmon_off) >> +xmon_init(0); >> } > > I don't think this is right. > > xmon_off is only true if you boot with xmon=off on the command line. > > So if you boot with CONFIG_XMON_DEFAULT=n, and nothing on the command > line, then enter xmon via sysrq, then exit, xmon will still be enabled. > Agreed, noticed it after some work in V2 of my patch. I'm addressing it there, so maybe no harm in keeping this way here.. Thanks, Guilherme > cheers >

Re: [PATCH] powerpc/xmon: Fix an unexpected xmon onoff state change

2017-02-16 Thread Guilherme G. Piccoli
gt; } > > I don't think this is right. > > xmon_off is only true if you boot with xmon=off on the command line. > > So if you boot with CONFIG_XMON_DEFAULT=n, and nothing on the command > line, then enter xmon via sysrq, then exit, xmon will still be enabled. > Agreed, noticed it after some work in V2 of my patch. I'm addressing it there, so maybe no harm in keeping this way here.. Thanks, Guilherme > cheers >

Re: [PATCH] powerpc/xmon: Fix an unexpected xmon onoff state change

2017-02-15 Thread Guilherme G. Piccoli
Xinhui <xinhui@linux.vnet.ibm.com> Patch is fine - minor typo: interrut => interrupt Feel free to add my: Tested-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Thanks, Guilherme > --- > arch/powerpc/xmon/xmon.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion

Re: [PATCH] powerpc/xmon: Fix an unexpected xmon onoff state change

2017-02-15 Thread Guilherme G. Piccoli
Patch is fine - minor typo: interrut => interrupt Feel free to add my: Tested-by: Guilherme G. Piccoli Thanks, Guilherme > --- > arch/powerpc/xmon/xmon.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmo

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-20 Thread Guilherme G. Piccoli
tors total, 3072 bytes done. > [...] sd 0:0:0:0: [sda] tag#0 checking 3072 bytes for alignment > (sector size 4096, remainder 3072, resid 1024) > [...] sd 0:0:0:0: [sda] tag#0 sd_done: completed 4096 of 4096 bytes > [...] sd 0:0:0:0: [sda] tag#0 8 sectors tota

Re: [PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-20 Thread Guilherme G. Piccoli
tors total, 3072 bytes done. > [...] sd 0:0:0:0: [sda] tag#0 checking 3072 bytes for alignment > (sector size 4096, remainder 3072, resid 1024) > [...] sd 0:0:0:0: [sda] tag#0 sd_done: completed 4096 of 4096 bytes > [...] sd 0:0:0:0: [sda] tag#0 8 sectors tot

Re: [PATCH] genirq/affinity: fix node generation from cpumask

2016-12-15 Thread Guilherme G. Piccoli
is outright wrong. See: > https://marc.info/?l=linux-kernel=147351236615103 > > I'll fix that up when applying the patch. > > Thanks, > > tglx > Thanks you all very much for the reviews and comments - lesson learned about the brackets in multi-line if/for statements! Thanks for fixing it Thomas. Cheers, Guilherme

Re: [PATCH] genirq/affinity: fix node generation from cpumask

2016-12-15 Thread Guilherme G. Piccoli
is outright wrong. See: > https://marc.info/?l=linux-kernel=147351236615103 > > I'll fix that up when applying the patch. > > Thanks, > > tglx > Thanks you all very much for the reviews and comments - lesson learned about the brackets in multi-line if/for statements! Thanks for fixing it Thomas. Cheers, Guilherme

[tip:irq/urgent] genirq/affinity: Fix node generation from cpumask

2016-12-15 Thread tip-bot for Guilherme G. Piccoli
Commit-ID: c0af52437254fda8b0cdbaae5a9b6d9327f1fcd5 Gitweb: http://git.kernel.org/tip/c0af52437254fda8b0cdbaae5a9b6d9327f1fcd5 Author: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> AuthorDate: Wed, 14 Dec 2016 16:01:12 -0200 Committer: Thomas Gleixner <t...@linutronix.de>

[tip:irq/urgent] genirq/affinity: Fix node generation from cpumask

2016-12-15 Thread tip-bot for Guilherme G. Piccoli
Commit-ID: c0af52437254fda8b0cdbaae5a9b6d9327f1fcd5 Gitweb: http://git.kernel.org/tip/c0af52437254fda8b0cdbaae5a9b6d9327f1fcd5 Author: Guilherme G. Piccoli AuthorDate: Wed, 14 Dec 2016 16:01:12 -0200 Committer: Thomas Gleixner CommitDate: Thu, 15 Dec 2016 12:32:35 +0100 genirq

[PATCH] genirq/affinity: fix node generation from cpumask

2016-12-14 Thread Guilherme G. Piccoli
ve _more_ nodes than vectors. Fixes: 34c3d9819fda ("genirq/affinity: Provide smarter irq spreading infrastructure") Reported-by: Gabriel Krisman Bertazi <gabr...@krisman.be> Signed-off-by: Guilherme G. Piccoli <gpicc...@linux.vnet.ibm.com> Cc: sta...@vger.kernel.org # v4

[PATCH] genirq/affinity: fix node generation from cpumask

2016-12-14 Thread Guilherme G. Piccoli
ve _more_ nodes than vectors. Fixes: 34c3d9819fda ("genirq/affinity: Provide smarter irq spreading infrastructure") Reported-by: Gabriel Krisman Bertazi Signed-off-by: Guilherme G. Piccoli Cc: sta...@vger.kernel.org # v4.9+ Cc: Christoph Hellwig Cc: linuxppc-...@lists.ozlabs.org

Re: [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors

2016-06-15 Thread Guilherme G. Piccoli
Thanks for the responses Bart and Christoph. On 06/15/2016 07:10 AM, Christoph Hellwig wrote: On Tue, Jun 14, 2016 at 06:54:22PM -0300, Guilherme G. Piccoli wrote: On 06/14/2016 04:58 PM, Christoph Hellwig wrote: This is lifted from the blk-mq code and adopted to use the affinity mask

Re: [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors

2016-06-15 Thread Guilherme G. Piccoli
Thanks for the responses Bart and Christoph. On 06/15/2016 07:10 AM, Christoph Hellwig wrote: On Tue, Jun 14, 2016 at 06:54:22PM -0300, Guilherme G. Piccoli wrote: On 06/14/2016 04:58 PM, Christoph Hellwig wrote: This is lifted from the blk-mq code and adopted to use the affinity mask

Re: [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors

2016-06-14 Thread Guilherme G. Piccoli
have 128 online cpus, 8 per core (meaning 16 cores) and 64 vecs, I guess would be ideal to distribute 4 vecs _per core_, leaving 4 CPUs in each core without vecs. Makes sense for you? Thanks, Guilherme +int irq_create_affinity_mask(struct cpumask **affinity_mask, + unsigned i

Re: [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors

2016-06-14 Thread Guilherme G. Piccoli
us, 8 per core (meaning 16 cores) and 64 vecs, I guess would be ideal to distribute 4 vecs _per core_, leaving 4 CPUs in each core without vecs. Makes sense for you? Thanks, Guilherme +int irq_create_affinity_mask(struct cpumask **affinity_mask, + unsigned int *nr_vecs) +{ +

Re: [PATCH] Use MICRO UINT_MAX instead of actual value

2016-05-16 Thread Guilherme G. Piccoli
On 04/30/2016 07:13 AM, Minfei Huang wrote: Ping. Any comment is appreciate. Hi Minfei, I guess a good idea would be to resend the patch with the typo fixed, as a v2 patch. What do you think? Cheers, Guilherme Thanks Minfei On 04/25/16 at 11:13P, Minfei Huang wrote: It's more

Re: [PATCH] Use MICRO UINT_MAX instead of actual value

2016-05-16 Thread Guilherme G. Piccoli
On 04/30/2016 07:13 AM, Minfei Huang wrote: Ping. Any comment is appreciate. Hi Minfei, I guess a good idea would be to resend the patch with the typo fixed, as a v2 patch. What do you think? Cheers, Guilherme Thanks Minfei On 04/25/16 at 11:13P, Minfei Huang wrote: It's more

Re: WANTED: kernel projects for CS students

2007-10-15 Thread Guilherme Amadio
with the kernel. Thanks in advance, Guilherme - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: WANTED: kernel projects for CS students

2007-10-15 Thread Guilherme Amadio
with the kernel. Thanks in advance, Guilherme - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Which companies are helping developing the kernel

2007-10-14 Thread Guilherme Amadio
ed to Linux? Thanks in advance. Guilherme - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Which companies are helping developing the kernel

2007-10-14 Thread Guilherme Amadio
in advance. Guilherme - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Problem to recognize that the file system is full

2007-09-04 Thread Guilherme Vilela
this problem? Thanks, Guilherme //io-stress.cpp #include #include #include using namespace std; int main() { int i = 0; string roller( "|/-\\" ); string sample( "*", 1024 ); ofstream ofs( "io-stress.txt" ); ofs.exceptio

Problem to recognize that the file system is full

2007-09-04 Thread Guilherme Vilela
this problem? Thanks, Guilherme //io-stress.cpp #include iostream #include fstream #include string using namespace std; int main() { int i = 0; string roller( |/-\\ ); string sample( *, 1024 ); ofstream ofs( io-stress.txt ); ofs.exceptions( ios::failbit | ios

Re: [PATCH] Blacklist Dell Optiplex 320 from using the HPET

2007-05-05 Thread Guilherme M. Schroeder
blacklist against his system so the HPET is not used. Many thanks to Guilherme for the slow and laborious testing that finally narrowed down this issue. Before going to hard to maintain DMI black lists we should first check if it's a more general problem and can't it be solved better? Most likely

Re: [PATCH] Blacklist Dell Optiplex 320 from using the HPET

2007-05-05 Thread Guilherme M. Schroeder
blacklist against his system so the HPET is not used. Many thanks to Guilherme for the slow and laborious testing that finally narrowed down this issue. Before going to hard to maintain DMI black lists we should first check if it's a more general problem and can't it be solved better? Most likely

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-25 Thread Guilherme M. Schroeder
John, Removing the three lines doesn't help too. It just boot ok with clocksource=acpi_pm. Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br john stultz wrote: On Mon, 2007-04-23 at 15:30 -0700

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-25 Thread Guilherme M. Schroeder
John, The dynticks doesn't affect HPET here at all. The machine freeze with or w/o dynticks. Gonna try the patch and i tell you. Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br john stultz wrote

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-25 Thread Guilherme M. Schroeder
John, Just a doubt, you want me to test the patch with dynticks disabled? Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br john stultz wrote: On Mon, 2007-04-23 at 15:30 -0700, john stultz wrote

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-25 Thread Guilherme M. Schroeder
John, Just a doubt, you want me to test the patch with dynticks disabled? Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br john stultz wrote: On Mon, 2007-04-23 at 15:30 -0700, john stultz wrote

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-25 Thread Guilherme M. Schroeder
John, The dynticks doesn't affect HPET here at all. The machine freeze with or w/o dynticks. Gonna try the patch and i tell you. Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br john stultz wrote

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-25 Thread Guilherme M. Schroeder
John, Removing the three lines doesn't help too. It just boot ok with clocksource=acpi_pm. Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br john stultz wrote: On Mon, 2007-04-23 at 15:30 -0700

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-21 Thread Guilherme M. Schroeder
John, Boot ok with clocksource=acpi_pm and HPET enabled. Any clue? john stultz wrote: On 4/19/07, guilherme <[EMAIL PROTECTED]> wrote: Hi, If i enable "High Resolution Timer Support", my machine stops here at boot: Clocksource tsc unstable (delta = -297340790165 ns) Time:

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-21 Thread Guilherme M. Schroeder
John, Boot ok with clocksource=acpi_pm and HPET enabled. Any clue? john stultz wrote: On 4/19/07, guilherme [EMAIL PROTECTED] wrote: Hi, If i enable High Resolution Timer Support, my machine stops here at boot: Clocksource tsc unstable (delta = -297340790165 ns) Time: hpet clocksource has

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-20 Thread guilherme
7e8dec2db4f9052ed5e M include :04 04 dfca91fe8a0b3ee7de842b4dd3451220634516f1 4c2ec00e90009d296f44f3e0b89c50e43336c6bc M kernel [EMAIL PROTECTED]:/usr/src/linux-2.6# Thanks. Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-20 Thread guilherme
Sorry, i put the wrong option in the last mail. The options that freeze my machine at boot is "HPET Timer Support". Thanks. -- Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br - To unsubs

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-20 Thread guilherme
Sorry, i put the wrong option in the last mail. The options that freeze my machine at boot is HPET Timer Support. Thanks. -- Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br - To unsubscribe from

Re: 2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-20 Thread guilherme
dfca91fe8a0b3ee7de842b4dd3451220634516f1 4c2ec00e90009d296f44f3e0b89c50e43336c6bc M kernel [EMAIL PROTECTED]:/usr/src/linux-2.6# Thanks. Guilherme M. Schroeder Network Administrator Central de Vendas Informatica LTDA Tel.: (11) 3665-2000 Ramal: 2008 http://www.centralinf.com.br Andi Kleen wrote

2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-19 Thread guilherme
Hi, If i enable "High Resolution Timer Support", my machine stops here at boot: Clocksource tsc unstable (delta = -297340790165 ns) Time: hpet clocksource has been installed. If i disable HPET, it boots fine. I attach my .config (with hpet enable) and my bootable dmesg. Thanks. --

2.6.21-rc7: HPET enabled freeze my machine at boot

2007-04-19 Thread guilherme
Hi, If i enable High Resolution Timer Support, my machine stops here at boot: Clocksource tsc unstable (delta = -297340790165 ns) Time: hpet clocksource has been installed. If i disable HPET, it boots fine. I attach my .config (with hpet enable) and my bootable dmesg. Thanks. -- Guilherme M

<    1   2