Acked-by: Mike Isely
On Thu, 20 Aug 2020, Tong Zhang wrote:
> pvr2_std_str_to_id() returns 0 on failure and 1 on success,
> however the caller is checking failure case using <0
>
> Co-developed-by: Hans Verkuil
> Signed-off-by: Tong Zhang
> ---
>
> v2: return -
Acked-by: Mike Isely
On Mon, 26 Aug 2019, Yizhuo wrote:
> Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag
> will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL.
> However, it will be used in the later if statement, which is
> potentially unsafe.
>
> Sig
Acked-by: Mike Isely
On Wed, 21 Aug 2019, Yizhuo wrote:
> Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag
> will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL.
> However, it will be used in the later if statement, which is
> potentially unsafe.
>
> Sig
Acked-by: Mike Isely
-Mike
On Fri, 28 Jun 2019, Fuqian Huang wrote:
> kmalloc + memset(0) -> kzalloc
>
> Signed-off-by: Fuqian Huang
> ---
> drivers/media/usb/pvrusb2/pvrusb2-eeprom.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git
Acked-By: Mike Isely
On Wed, 5 Jun 2019, Kefeng Wang wrote:
> The class_ptr will be NULL if pvr2_sysfs_class_create() fails
> in pvr_init(), when call pvr2_sysfs_class_destroy(), it will
> lead to null-ptr-deref, fix it.
>
> Reported-by: Hulk Robot
> Signed-o
PM, Kees Cook wrote:
> > In preparation for unconditionally passing the struct timer_list pointer to
> > all timer callbacks, switch to using the new timer_setup() and from_timer()
> > to pass the timer pointer explicitly.
> >
> > Cc: Mike Isely
> > Cc: Mauro Ca
Acked-By: Mike Isely
On Tue, 24 Oct 2017, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> Cc: Mike Ise
118
> pvr2_context_thread_func+0x361/0x8c0
> drivers/media/usb/pvrusb2/pvrusb2-context.c:167
> kthread+0x3a1/0x470 kernel/kthread.c:231
> ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431
> Code: 48 8b 85 30 ff ff ff 48 8d b8 98 00 00 00 e8 ee 82 89 fe 45 89
> e8 44 89 f1 4c
Acked-by: Mike Isely
-Mike
On Sat, 26 Aug 2017, Bhumika Goyal wrote:
> Make these const as they are only used during a copy operation.
>
> Signed-off-by: Bhumika Goyal
> ---
> Changes in v2:
> * Combine the patch series sent for drivers/media/usb/ into a
> single
Acked-by: Mike Isely
On Sat, 19 Aug 2017, Bhumika Goyal wrote:
> Make these const as they are only used in a copy operation.
> Done using Coccinelle
>
> Signed-off-by: Bhumika Goyal
> ---
> drivers/media/usb/au0828/au0828-i2c.c| 2 +-
> drivers/media/usb/
Acked-by: Mike Isely
On Fri, 18 Aug 2017, Bhumika Goyal wrote:
> Make these const as they are only used in a copy operation or
> are stored in the algo field of i2c_adapter structure, which is const.
>
> Signed-off-by: Bhumika Goyal
> ---
> drivers/media/usb/au0828/au082
rol infrastructure.
> Add support for the new field which on structure
> v4l2_ext_controls
>
> Acked-by: Mike Isely
> Signed-off-by: Ricardo Ribalda Delgado
> ---
> drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 16 ++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
down
to choosing between pvr2_ctrl_get_value() vs pvr2_ctrl_get_def().
It's not a correctness comment; what you have should work fine. So I'm
ack'ing this in any case:
Acked-By: Mike Isely
But you can do the above pretty easily & safely, and simplify it a bit
further.
Nice. I wonder if a previous merge mechanically resulted in this. I
can't imagine deliberately writing code like that.
-Mike
Acked-by: Mike Isely
On Thu, 10 Jul 2014, Andrey Utkin wrote:
> The issue was discovered by static analysis. It turns out that code is
> somewhat in
I never liked that designation in the first place, so no argument
here...
Acked-By: Mike Isely
On Tue, 23 Oct 2012, Kees Cook wrote:
> This config item has not carried much meaning for a while now and is
> almost always enabled by default. As agreed during the Linux kernel
> summi
Acked-By: Mike Isely
-Mike
On Thu, 26 Jul 2012, Tim Gardner wrote:
> Cc: Mike Isely
> Cc: Mauro Carvalho Chehab
> Cc: linux-me...@vger.kernel.org
> Signed-off-by: Tim Gardner
> ---
> drivers/media/video/pvrusb2/pvrusb2-devattr.c | 17 -
> 1 file c
Signed-off-by: Mike Isely <[EMAIL PROTECTED]>
On Sun, 12 Aug 2007, [EMAIL PROTECTED] wrote:
> Add file pattern to MAINTAINER entry
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 62b6ede..3889034 1006
Whoops. A straggler.
Signed-off-by: Mike Isely <[EMAIL PROTECTED]>
On Fri, 27 Apr 2007, Matthias Kaehlcke wrote:
> the pvrusb2 driver use a semaphore as mutex. use the mutex API instead
> of the (binary) semaphore
>
> Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]&
initial patch a while back I then combed through the entire
pvrusb2 driver and cleaned up all the other cases. Those patches should
already be on a trajectory for 2.6.21. I'll check it against this patch
but I think these should already all be handled.
-Mike
--
propriate.
>
> Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]>
> ---
Ahmed:
I've pulled your patch into my driver source and will propagate it up
appropriately as part of the next batch of pvrusb2 changes to come out
of the v4l-dvb repository.
-M
ed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>
>
>
Signed-off-by: Mike Isely <[EMAIL PROTECTED]>
-Mike
--
| Mike Isely | PGP fingerprint
Spammers Die!! | | 03 54 43 4D 75 E5 CC 92
21 matches
Mail list logo
