Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-01-28 Thread jckuo
Thanks Thierry. Reviewed-by: JC Kuo On 1/28/19 4:00 PM, Thierry Reding wrote: On Mon, Jan 28, 2019 at 03:22:09PM +0800, jckuo wrote: Hi Thierry, I think any non-zero return value of regulator_bulk_enable()/devm_regulator_bulk_get() means error. Thanks, JC Theoretically I think only

Re: [PATCH 4/6] arm64: tegra: Add XUSB and pad controller on Tegra186

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:30 PM, Thierry Reding wrote: From: Thierry Reding Adds the XUSB pad and XUSB controllers on Tegra186. Signed-off-by: Thierry Reding --- arch/arm64/boot/dts/nvidia/tegra186.dtsi | 135 +++ 1 file changed, 135 insertions(+) diff --git

Re: [PATCH 3/6] usb: host: xhci-tegra: Add Tegra186 XUSB support

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:30 PM, Thierry Reding wrote: From: JC Kuo This commit adds Tegra186 XUSB host mode controller support. This is very similar to the existing support for Tegra124 and Tegra210, except that the number of ports and PHYs differs and the IPFS wrapper being gone.

Re: [PATCH 2/6] usb: host: xhci-tegra: Selectively program IPFS

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:30 PM, Thierry Reding wrote: From: JC Kuo Starting with Tegra186, the XUSB controller no longer has the IPFS wrapper. This commit adds a "has_ipfs" field to struct tegra_xusb_soc that can be used to declare the existence of the IPFS wrapper. For the existing

Re: [PATCH 1/6] dt-bindings: usb: xhci-tegra: Add Tegra186 support

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:30 PM, Thierry Reding wrote: From: Thierry Reding Extend the bindings to cover the set of features found in Tegra186. Signed-off-by: Thierry Reding --- .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt | 4 1 file changed, 4

Re: [PATCH 5/5] phy: tegra: xusb: Add Tegra186 support

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:25 PM, Thierry Reding wrote: From: JC Kuo Add support for the XUSB pad controller found on Tegra186 SoCs. It is mostly similar to the same IP found on earlier chips, but the number of pads exposed differs, as do the programming sequences. Note that the

Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies

2019-01-27 Thread jckuo
Hi Thierry, I think any non-zero return value of regulator_bulk_enable()/devm_regulator_bulk_get() means error. Thanks, JC On 1/25/19 7:25 PM, Thierry Reding wrote: From: Thierry Reding Support enabling various supplies needed to provide power to the PLLs and logic used to drive the USB,

Re: [PATCH 3/5] phy: tegra: xusb: Parse dual-role mode property

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:25 PM, Thierry Reding wrote: From: Thierry Reding The device tree bindings document the "mode" property of "ports" subnodes, but the driver was not parsing the property. In preparation for adding role switching, parse the property at probe time. Based on

Re: [PATCH 2/5] phy: tegra: xusb: Skip single function lane programming

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:25 PM, Thierry Reding wrote: From: JC Kuo Tegra186 USB2 pads and USB3 pads do not have hardware mux for changing the pad function. For such "lanes", we can skip the lane mux register programming. Signed-off-by: JC Kuo Signed-off-by: Thierry Reding ---

Re: [PATCH 1/5] dt-bindings: phy: tegra: Add Tegra186 support

2019-01-27 Thread jckuo
Reviewed-by: JC Kuo On 1/25/19 7:25 PM, Thierry Reding wrote: From: Thierry Reding Extend the bindings to cover the set of features found in Tegra186. Note that, technically, there are four more supplies connected to the XUSB pad controller (DVDD_PEX, DVDD_PEX_PLL, HVDD_PEX and