Re: [PATCH net v2] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-14 Thread Jesse Brandeburg
Jason Xing wrote: > On Wed, Apr 14, 2021 at 12:27 AM Jesse Brandeburg > wrote: > > > > kerneljasonx...@gmail.com wrote: > > > > > From: Jason Xing > > > > Hi Jason, > > > > Sorry, I missed this on the first time: Added intel-wired-la

Re: [PATCH net v3] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-14 Thread Jesse Brandeburg
ed/0x120 > [2160294.719365] rtnl_newlink+0x73b/0x860 > > Fixes: 41c445ff0f48 ("i40e: main driver core") > Co-developed-by: Shujin Li > Signed-off-by: Shujin Li > Signed-off-by: Jason Xing Reviewed-by: Jesse Brandeburg @Jakub/@DaveM - feel free to apply this directly.

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2021-04-14 Thread Jesse Brandeburg
Nitesh Narayan Lal wrote: > > The original issue as seen, was that if you rmmod/insmod a driver > > *without* irqbalance running, the default irq mask is -1, which means > > any CPU. The older kernels (this issue was patched in 2014) used to use > > that affinity mask, but the value programmed

Re: [PATCH net v2] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-13 Thread Jesse Brandeburg
igned-off-by: Shujin ... Signed-off-by: Jason ... Your signature should be last if you sent the patch. The sign-offs are like a chain of custody, please review https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by Thanks, Jesse

Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-12 Thread Jesse Brandeburg
kerneljasonx...@gmail.com wrote: > From: Jason Xing > > Re: [PATCH] i40e: fix the panic when running bpf in xdpdrv mode Please use netdev style subject lines when patching net kernel to indicate which kernel tree this is targeted at, "net" or "net-next" [PATCH net v2] i40e: ... > Fix this by

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2021-04-06 Thread Jesse Brandeburg
> >     e2e64a932 genirq: Set initial affinity in irq_set_affinity_hint() > > > > Continuing the conversation about the above commit and adding Jesse. > I was trying to understand the problem that the commit message explains > "The default behavior of the kernel is somewh

Re: [PATCH] net: ethernet: intel: Fix a typo in the file ixgbe_dcb_nl.c

2021-03-17 Thread Jesse Brandeburg
Bhaskar Chowdhury wrote: > > s/Reprogam/Reprogram/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Jesse Brandeburg

Re: [page-reclaim] Augmented Page Reclaim

2021-02-09 Thread Jesse Barnes
en under memory pressure, and this approach significantly improves these (see Yu's data). We do expect this approach will also be beneficial to cloud workloads, and so are looking for people to try it out in their environments with their favorite key tests or workloads. Thanks, Jesse

Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS

2021-02-04 Thread Jesse Brandeburg
ot;net: stmmac: Add support for CBS QDISC") > Suggested-by: Gomes, Vinicius > Signed-off-by: Mohammad Athari Bin Ismail > Signed-off-by: Song, Yoong Siang Reviewed-by: Jesse Brandeburg

Re: [net-next v3 00/14] Add Marvell CN10K support

2021-02-04 Thread Jesse Brandeburg
Geetha sowjanya wrote: > v2-v3 > Reposting as a single thread. FYI, it didn't work, suggest you try adding the git-send-email option (via git-config) sendemail.thread=true sendemail.chainreplyto=false And you can test locally by using first using git send-email to export to mbox and checking

Re: [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions

2021-02-04 Thread Jesse Brandeburg
t; > Suggested-by: David Rientjes > Suggested-by: Jakub Kicinski > Cc: John Hubbard > Signed-off-by: Alexander Lobakin I don't know why it was missed in the series update, but: Reviewed-by: Jesse Brandeburg

Re: [PATCH net-next] net: Return the correct errno code

2021-02-04 Thread Jesse Brandeburg
Zheng Yongjun wrote: > When kzalloc failed, should return ENOMEM rather than ENOBUFS. All these patches have the same subject and description, couldn't they just be part of a single series with a good cover letter? I'm not saying make them a single patch, because that is bad for bisection, but

Re: [PATCH] octeontx2-af: remove unneeded semicolon

2021-02-03 Thread Jesse Brandeburg
ding like [PATCH net-next] otherwise, for net-next: Reviewed-by: Jesse Brandeburg

Re: [PATCH net] hv_netvsc: Reset the RSC count if NVSP_STAT_FAIL in netvsc_receive()

2021-02-03 Thread Jesse Brandeburg
uot;hv_netvsc: Add validation for untrusted Hyper-V > values") Reviewed-by: Jesse Brandeburg

Re: [PATCH][next] net: hns3: remove redundant null check of an array

2021-02-03 Thread Jesse Brandeburg
gainst 0") > Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority > and qset info") > Signed-off-by: Colin Ian King Reviewed-by: Jesse Brandeburg

Re: [PATCH][next] net/mlx5e: Fix spelling mistake "Unknouwn" -> "Unknown"

2021-02-03 Thread Jesse Brandeburg
Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a netdev_warn message. Fix it. > > Signed-off-by: Colin Ian King Trivial patch, looks fine! Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-02-02 Thread Jesse Brandeburg
d 10 duplex full autoneg on > > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-02-02 Thread Jesse Brandeburg
pause frame use: No > Advertised auto-negotiation: No > Advertised FEC modes: None > > ethtool lbk0 > Settings for lbk0: > Speed: 10Mb/s > Duplex: Full > > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Goutham > Signed-

Re: [Patch v3 net-next 5/7] octeontx2-af: advertised link modes support on cgx

2021-02-02 Thread Jesse Brandeburg
gt; Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 4/7] octeontx2-af: Physical link configuration support

2021-02-02 Thread Jesse Brandeburg
adds mailbox handler set_link_mode, fw_data_get to > configure and read these parameters. > > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-02-02 Thread Jesse Brandeburg
- ethtool --show-fec eth0 > > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-02-02 Thread Jesse Brandeburg
CMD_GET_PHY_FEC_STATS, also add CGX_CMD_PRBS and > CGX_CMD_DISPLAY_EYE to enum cgx_cmd_id so that Linux's enum list is in sync > with firmware's enum list. > > Signed-off-by: Felix Manlunas > Signed-off-by: Christina Jacob > Signed-off-by: Sunil Kovvuri Goutham > Signed-off

Re: [Patch v3 net-next 1/7] octeontx2-af: forward error correction configuration

2021-02-02 Thread Jesse Brandeburg
t; Signed-off-by: Sunil Goutham > Signed-off-by: Hariprasad Kelam Reviewed-by: Jesse Brandeburg

Re: [Patch v3 net-next 0/7] ethtool support for fec and link configuration

2021-02-02 Thread Jesse Brandeburg
ied to the previous posting of v3 that it looked good. Reviewed-by: Jesse Brandeburg

Re: [PATCH v2 net-next 0/4] net: consolidate page_is_pfmemalloc() usage

2021-01-27 Thread Jesse Brandeburg
rst argument of > skb_propagate_pfmemalloc(). > In Page Pool core code, it can be simply inlined instead. > Most of the callers from NIC drivers were just doppelgangers of > the same condition tests. Derive them into a new common function > do deduplicate the code. This is a useful cleanup! Thanks. For the

Re: [PATCH v2 net-next 3/4] net: introduce common dev_page_is_reserved()

2021-01-27 Thread Jesse Brandeburg
ellanox/mlx5/core/en_rx.c | 7 +-- > include/linux/skbuff.h| 15 +++ > 11 files changed, 27 insertions(+), 83 deletions(-) For the patch, and esp. for the Intel drivers: Reviewed-by: Jesse Brandeburg

Re: [PATCH 1/1] ice: fix array overflow on receiving too many fragments for a packet

2020-12-06 Thread Jesse Brandeburg
Xiaohui Zhang wrote: > From: Zhang Xiaohui > > If the hardware receives an oversized packet with too many rx fragments, > skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. > This becomes especially visible if it corrupts the freelist pointer of > a slab page. As I

Re: [PATCH 1/1] ionic: fix array overflow on receiving too many fragments for a packet

2020-12-06 Thread Jesse Brandeburg
Xiaohui Zhang wrote: > From: Zhang Xiaohui > > If the hardware receives an oversized packet with too many rx fragments, > skb_shinfo(skb)->frags can overflow and corrupt memory of adjacent pages. > This becomes especially visible if it corrupts the freelist pointer of > a slab page. > >

Re: [PATCH V4 net-next 0/4] net: hns3: updates for -next

2020-11-23 Thread Jesse Brandeburg
h needs more discussion. > V3 - fix a typo error in #1 reported by Jakub Kicinski. > rewrite #9 commit log. > remove #11 from this series. > V2 - reorder #2 & #3 to fix compiler error. > fix some checkpatch warnings in #10 & #11. For the series: Reviewed-by: Jesse Brandeburg

Re: [PATCH] x86/gpu: add JSL stolen memory support

2020-11-19 Thread Jesse Barnes
On Thu, Nov 19, 2020 at 11:19 AM Bjorn Helgaas wrote: > > [+cc Jesse] > > On Thu, Nov 19, 2020 at 10:37:10AM +0100, Daniel Vetter wrote: > > On Thu, Nov 19, 2020 at 12:14 AM Bjorn Helgaas wrote: > > > On Wed, Nov 18, 2020 at 10:57:26PM +0100, Daniel Vetter wrote: &

Re: [PATCH net] iavf: fix error return code in iavf_init_get_resources()

2020-11-12 Thread Jesse Brandeburg
Zhang Changzhong wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: b66c7bc1cd4d ("iavf: Refactor init state machine") > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong

Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

2020-10-16 Thread Jesse Brandeburg
Jakub Kicinski wrote: > On Fri, 16 Oct 2020 14:23:48 -0700 Jesse Brandeburg wrote: > > > These are tested to be the latest as part of the tools/lib/bpf build. > > > > But you didn't mention why you're making these changes, and you're > > removing a lot of comment

Re: [PATCH net-next v2 0/9] net: ethernet: ti: am65-cpsw: add multi port support in mac-only mode

2020-10-16 Thread Jesse Brandeburg
Grygorii Strashko wrote: > Hi > > This series adds multi-port support in mac-only mode (multi MAC mode) to TI > AM65x CPSW driver in preparation for enabling support for multi-port devices, > like Main CPSW0 on K3 J721E SoC or future CPSW3g on K3 AM64x SoC. For the series Rev

Re: [PATCH 1/2] tools/include: Update if_link.h and netlink.h

2020-10-16 Thread Jesse Brandeburg
Hi Ian, Ian Rogers wrote: > These are tested to be the latest as part of the tools/lib/bpf build. But you didn't mention why you're making these changes, and you're removing a lot of comments without explaining why/where there might be a replacement or why the comments are useless. I now see

Re: [RFC][Patch v1 2/3] i40e: limit msix vectors based on housekeeping CPUs

2020-09-17 Thread Jesse Brandeburg
ight? I'm sure ixgbe and ice both have this problem too, you should fix them as well, at a minimum, and probably other vendors drivers: $ rg -c --stats num_online_cpus drivers/net/ethernet ... 50 files contained matches for this patch i40e Acked-by: Jesse Brandeburg

Re: [RFC][Patch v1 1/3] sched/isolation: API to get num of hosekeeping CPUs

2020-09-17 Thread Jesse Brandeburg
Nitesh Narayan Lal wrote: > Introduce a new API num_housekeeping_cpus(), that can be used to retrieve > the number of housekeeping CPUs by reading an atomic variable > __num_housekeeping_cpus. This variable is set from housekeeping_setup(). > > This API is introduced for the purpose of drivers

Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for i40e

2020-09-10 Thread Jesse Brandeburg
Wang Hai wrote: > Wang Hai (3): > i40e: Fix some kernel-doc warnings in i40e_client.c > i40e: Fix some kernel-doc warnings in i40e_common.c > i40e: Fix a kernel-doc warning in i40e_ptp.c > > drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- >

Re: [Intel-wired-lan] VRRP not working on i40e X722 S2600WFT

2020-08-31 Thread Jesse Brandeburg
Lennart Sorensen wrote: > On Thu, Aug 27, 2020 at 02:30:39PM -0400, Lennart Sorensen wrote: > > I have hit a new problem with the X722 chipset (Intel R1304WFT server). > > VRRP simply does not work. > > > > When keepalived registers a vmac interface, and starts transmitting > > multicast packets

Re: [net v2 PATCH 1/2] net: ethernet: ti: cpsw: fix clean up of vlan mc entries for host port

2020-08-21 Thread Jesse Brandeburg
Murali Karicheri wrote: > To flush the vid + mc entries from ALE, which is required when a VLAN > interface is removed, driver needs to call cpsw_ale_flush_multicast() > with ALE_PORT_HOST for port mask as these entries are added only for > host port. Without this, these entries remain in the ALE

Re: [net v2 PATCH 2/2] net: ethernet: ti: cpsw_new: fix clean up of vlan mc entries for host port

2020-08-21 Thread Jesse Brandeburg
Murali Karicheri wrote: > To flush the vid + mc entries from ALE, which is required when a VLAN > interface is removed, driver needs to call cpsw_ale_flush_multicast() > with ALE_PORT_HOST for port mask as these entries are added only for > host port. Without this, these entries remain in the ALE

Re: [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled

2020-08-20 Thread Jesse Barnes
t; >>> ../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of > >>> function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? > >>> [-Werror=implicit-function-declaration] > >>>acpi_noirq_set(); > > > > Reviewed-by: And

Re: NETDEV WATCHDOG: WARNING: at net/sched/sch_generic.c:442 dev_watchdog

2020-08-19 Thread Jesse Brandeburg
Steven Rostedt wrote: > On Wed, 19 Aug 2020 17:01:06 +0530 > Naresh Kamboju wrote: > > > kernel warning noticed on x86_64 while running LTP tracing > > ftrace-stress-test > > case. started noticing on the stable-rc linux-5.8.y branch. > > > > This device booted with KASAN config and DYNAMIC

Re: [PATCH] qed_main: Remove unnecessary cast in kfree

2020-08-18 Thread Jesse Brandeburg
on kfree Did you use a coccinelle script to find these? They could all have Fixes tags. I'd resend the whole bunch as a series. Since this has no functional change, you could mention that in the series commit message text. Jesse

Re: [PATCH] net/bluetooth/hidp/sock.c: add CAP_NET_RAW check.

2020-08-18 Thread Jesse Brandeburg
On Tue, 18 Aug 2020 16:21:03 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > > Signed-off-by: Qingyu Li Please see my replies to your previous patches.

Re: [PATCH] net/bluetooth/cmtp/sock.c: add CAP_NET_RAW check.

2020-08-18 Thread Jesse Brandeburg
On Tue, 18 Aug 2020 16:15:55 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. Please see my previous replies.

Re: [PATCH] net/bluetooth/bnep/sock.c: add CAP_NET_RAW check.

2020-08-18 Thread Jesse Brandeburg
On Tue, 18 Aug 2020 16:07:03 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > These changes should be part of a series (patch 0,1,2 at least), and all my replies on your other patch apply to this one as well.

Re: [PATCH] net/bluetooth/hci_sock.c: add CAP_NET_RAW check.

2020-08-18 Thread Jesse Brandeburg
On Tue, 18 Aug 2020 15:56:48 +0800 Qingyu Li wrote: > When creating a raw PF_BLUETOOTH socket, > CAP_NET_RAW needs to be checked first. > Thanks for the patch! Your subject doesn't need to end in a period. In your commit message, I can guess why you'd want this patch, but your commit message

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-17 Thread Jesse Brandeburg
On Mon, 17 Aug 2020 16:27:01 +0300 Kalle Valo wrote: > I was surprised to see that someone was using this driver in 2015, so > I'm not sure anymore what to do. Of course we could still just remove > it and later revert if someone steps up and claims the driver is still > usable. Hmm. Does anyone

Re: [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled

2020-08-13 Thread Jesse Barnes
tion ‘intel_mid_pci_init’: > ../arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of > function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? > [-Werror=implicit-function-declaration] > acpi_noirq_set(); > > Signed-off-by: Randy Dunlap > Cc: Jacob Pan > Cc: Le

Re: [PATCH 4.19 47/48] i40e: Memory leak in i40e_config_iwarp_qvlist

2020-08-11 Thread Jesse Brandeburg
me name was confusing to you? It confused me for a moment while I investigated, but I believe there is no actual problem. The reason for the function working this way is that the input data is from the VF message, and the driver data structures in the PF (i40e) driver representing state of the VF are managed separately. Jesse

Darlehensangebot

2020-07-16 Thread Jesse Peterson
Haben Sie nach Finanzierungsmöglichkeiten für Ihr Unternehmen, den Kauf eines neuen Eigenheims, den Bau, den Immobilienkredit, die Refinanzierung, die Schuldenkonsolidierung, den persönlichen oder geschäftlichen Zweck gesucht? Willkommen in der Zukunft! Finanzierung mit uns leicht gemacht.

Re: [RFC] Restrict the untrusted devices, to bind to only a set of "whitelisted" drivers

2020-06-08 Thread Jesse Barnes
do it with our coreboot based firmware, but there's no guarantee other vendors will adopt the same approach. But I think at least for the ChromeOS ecosystem we can come up with something that'll work, and allow us to dtrt in userspace wrt driver binding. Thanks, Jesse

Re: [RFC] Restrict the untrusted devices, to bind to only a set of "whitelisted" drivers

2020-06-08 Thread Jesse Barnes
e USB is an exception) I think driver authors haven't had to consider this case much, and so I think it's prudent to expect bugs in this area that we need to find & fix. Thanks, Jesse

Re: [PATCH RFC] sched: Add a per-thread core scheduling interface

2020-05-21 Thread Jesse Barnes
e. Just let us know if you want to make changes or port to another environment so we can try to stay in sync wrt new features, etc. Thanks, Jesse

Re: [PATCH v5] x86: bitops: fix build regression

2020-05-08 Thread Jesse Brandeburg
appreciate the work done to find the right fix and clean up the code while not breaking sparse! I had a look at the assembly from gcc 9.3.1 and it looks good. Thanks! Reviewed-by: Jesse Brandeburg

Re: [PATCH v6 1/2] x86: fix bitops.h warning with a moved cast

2020-05-04 Thread Jesse Brandeburg
On Mon, 4 May 2020 12:51:12 -0700 Nick Desaulniers wrote: > Sorry for the very late report. It turns out that if your config > tickles __builtin_constant_p just right, this now produces invalid > assembly: > > $ cat foo.c > long a(long b, long c) { > asm("orb\t%1, %0" : "+q"(c): "r"(b)); >

[PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.

2019-09-29 Thread Jesse Barton
Removed function argument wrapping to new line. Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c

[PATCH 2/3] Staging: exfat: exfat_super.c: fixed multiple coding style issues with camelcase and parentheses

2019-09-29 Thread Jesse Barton
ese enums Opt_uid Opt_gid Opt_umask Opt_dmask Opt_fmask Opt_allow_utime Opt_codepage Opt_charset Opt_namecase Opt_debug Opt_err_cont Opt_err_panic Opt_err_ro Opt_utf8_hack Opt_err Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 210 ++-- 1 file changed, 10

[PATCH 1/3] Staging: exfat: exfat_super.c: fixed camelcase coding style issue

2019-09-29 Thread Jesse Barton
Changed function names: ffsUmountVol to ffs_umount_vol ffsMountVol to ffs_mount_vol ffsSyncVol to ffs_sync_vol Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/exfat

[PATCH 2/3] Staging: exfat: exfat_super.c: fixed multiple coding style issues with camelcase and parentheses

2019-09-28 Thread Jesse Barton
Fixed coding style issues with camelcase on functions and various parentheses that were not needed Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 210 ++-- 1 file changed, 105 insertions(+), 105 deletions(-) diff --git a/drivers/staging/exfat

[PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.

2019-09-28 Thread Jesse Barton
Fixed Coding Style issues Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 3c7e2b7c2195

[PATCH] Staging: exfat: exfat_super.c: fixed camelcase coding style issue

2019-09-28 Thread Jesse Barton
Fixed a coding style issue. Signed-off-by: Jesse Barton --- drivers/staging/exfat/exfat_super.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 5f6caee819a6..665eb25e318d

Re: [PATCH net-next 0/6] net: stmmac: Improvements for -next

2019-09-10 Thread Jesse Brandeburg
mmac: ARP Offload for GMAC4+ Cores For the series, looks good to me. Reviewed-by: Jesse Brandeburg

Re: [PATCH] team: Add vlan tx offload to hw_enc_features

2019-08-07 Thread Jesse Brandeburg
On Wed, 7 Aug 2019 10:38:08 +0800 YueHaibing wrote: > We should also enable bonding's vlan tx offload in hw_enc_features, You mean team's vlan tx offload? > pass the vlan packets to the slave devices with vlan tci, let them s/let them to/let the slave/ > to handle vlan tunneling offload

Re: [PATCH] myri10ge: remove unneeded variable

2019-08-07 Thread Jesse Brandeburg
On Wed, 31 Jul 2019 16:53:46 +0800 Ding Xiang wrote: > "error" is unneeded,just return 0 > > Signed-off-by: Ding Xiang Reviewed-by: Jesse Brandeburg

Re: [PATCH 2/2] net: ag71xx: Use GFP_KERNEL instead of GFP_ATOMIC in 'ag71xx_rings_init()'

2019-08-07 Thread Jesse Brandeburg
On Wed, 31 Jul 2019 10:06:48 +0200 Christophe JAILLET wrote: > There is no need to use GFP_ATOMIC here, GFP_KERNEL should be enough. > The 'kcalloc()' just a few lines above, already uses GFP_KERNEL. > > Signed-off-by: Christophe JAILLET Reviewed-by: Jesse Brandeburg

Re: [PATCH 1/2] net: ag71xx: Slighly simplify code in 'ag71xx_rings_init()'

2019-08-07 Thread Jesse Brandeburg
Christophe JAILLET Reviewed-by: Jesse Brandeburg

Re: [PATCH] net: ethernet: et131x: Use GFP_KERNEL instead of GFP_ATOMIC when allocating tx_ring->tcb_ring

2019-08-07 Thread Jesse Brandeburg
EL which should be enough. > > Signed-off-by: Christophe JAILLET Sure, but generally I'd say GFP_ATOMIC is ok if you're in an init path and you can afford to have the allocation thread sleep while memory is being found by the kernel. Reviewed-by: Jesse Brandeburg

Re: [PATCH net-next] net: Drop unlikely before IS_ERR(_OR_NULL)

2019-06-05 Thread Jesse Brandeburg
On Wed, 5 Jun 2019 22:24:26 +0800 Kefeng wrote: > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag, > so no need to do that again from its callers. Drop it. > > segs = __skb_gso_segment(skb, features, false); > - if (unlikely(IS_ERR_OR_NULL(segs))) { > + if

Re: [PATCH net-next v4] hinic: add LRO support

2019-06-04 Thread Jesse Brandeburg
On Tue, 4 Jun 2019 01:16:08 + Xue wrote: > This patch adds LRO support for the HiNIC driver. > > Reported-by: kbuild test robot > Reviewed-by: Jesse Brandeburg > Signed-off-by: Xue Chaojing Hm, you added my reviewed-by tag, but I didn't add it myself, I only comment

Re: [PATCH net-next v3] hinic: add LRO support

2019-06-03 Thread Jesse Brandeburg
some review comments below... On Mon, 3 Jun 2019 04:35:36 + Xue Chaojing wrote: > This patch adds LRO support for the HiNIC driver. > > Signed-off-by: Xue Chaojing > --- > .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 2 + > .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 8 +- >

Re: Regression causes a hang on boot with a Comtrol PCI card

2019-04-01 Thread Jesse Hathaway
On Fri, Mar 22, 2019 at 3:02 PM Jesse Hathaway wrote: > > Can you boot v5.0 vanilla with "initcall_debug"? Maybe we can narrow > > it down to a specific quirk. > > yup, added the "initcall_debug" output to the ticket: > https://bugzilla.kernel.org/sho

Re: Regression causes a hang on boot with a Comtrol PCI card

2019-03-22 Thread Jesse Hathaway
alling quirk_usb_early_handoff+0x0/0x6a0 @ 1 thanks, Jesse Hathaway

Re: Regression causes a hang on boot with a Comtrol PCI card

2019-03-14 Thread Jesse Hathaway
[ 10.628124] UDP hash table entries: 65536 (order: 9, 2097152 bytes) [ 10.635541] UDP-Lite hash table entries: 65536 (order: 9, 2097152 bytes) [ 10.643669] NET: Registered protocol family 1 Please let me know if there is anything else I can provide, I am also happy to test any patches, Jesse Hathaway

Regression causes a hang on boot with a Comtrol PCI card

2019-03-13 Thread Jesse Hathaway
Two regressions cause Linux to hang on boot when a Comtrol PCI card is present. If I revert the following two commits, I can boot again and the card operates without issue: 1302fcf0d03e (refs/bisect/bad) PCI: Configure *all* devices, not just hot-added ones 1c3c5eab1715 sched/core: Enable

Retouching added

2018-09-05 Thread Jesse Kurtz
, Jesse

Retouching added

2018-09-05 Thread Jesse Kurtz
, Jesse

Retouching added

2018-09-05 Thread Jesse Kurtz
, Jesse

Retouching added

2018-09-05 Thread Jesse Kurtz
, Jesse

Replace your photos

2018-09-05 Thread Jesse Kurtz
, Jesse

Replace your photos

2018-09-05 Thread Jesse Kurtz
, Jesse

Photo replacing

2018-09-05 Thread Jesse Kurtz
, Jesse

Photo replacing

2018-09-05 Thread Jesse Kurtz
, Jesse

Re: [RFC PATCH net-next 10/12] vhost_net: build xdp buff

2018-05-21 Thread Jesse Brandeburg
On Mon, 21 May 2018 17:04:31 +0800 Jason wrote: > This patch implement build XDP buffers in vhost_net. The idea is do > userspace copy in vhost_net and build XDP buff based on the > page. Vhost_net can then submit one or an array of XDP buffs to > underlayer socket (e.g TUN). TUN can choose to do

Re: [RFC PATCH net-next 10/12] vhost_net: build xdp buff

2018-05-21 Thread Jesse Brandeburg
On Mon, 21 May 2018 17:04:31 +0800 Jason wrote: > This patch implement build XDP buffers in vhost_net. The idea is do > userspace copy in vhost_net and build XDP buff based on the > page. Vhost_net can then submit one or an array of XDP buffs to > underlayer socket (e.g TUN). TUN can choose to do

Re: [RFC PATCH net-next 04/12] vhost_net: split out datacopy logic

2018-05-21 Thread Jesse Brandeburg
On Mon, 21 May 2018 17:04:25 +0800 Jason wrote: > Instead of mixing zerocopy and datacopy logics, this patch tries to > split datacopy logic out. This results for a more compact code and > specific optimization could be done on top more easily. > > Signed-off-by: Jason Wang

Re: [RFC PATCH net-next 04/12] vhost_net: split out datacopy logic

2018-05-21 Thread Jesse Brandeburg
On Mon, 21 May 2018 17:04:25 +0800 Jason wrote: > Instead of mixing zerocopy and datacopy logics, this patch tries to > split datacopy logic out. This results for a more compact code and > specific optimization could be done on top more easily. > > Signed-off-by: Jason Wang > --- >

Re: [RFC PATCH net-next 03/12] vhost_net: introduce vhost_has_more_pkts()

2018-05-21 Thread Jesse Brandeburg
On Mon, 21 May 2018 17:04:24 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index de544ee..4ebac76 100644 > ---

Re: [RFC PATCH net-next 03/12] vhost_net: introduce vhost_has_more_pkts()

2018-05-21 Thread Jesse Brandeburg
On Mon, 21 May 2018 17:04:24 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index de544ee..4ebac76 100644 > --- a/drivers/vhost/net.c >

Re: [RFC PATCH net-next 02/12] vhost_net: introduce vhost_exceeds_weight()

2018-05-21 Thread Jesse Brandeburg
On Mon, 21 May 2018 17:04:23 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 15d191a..de544ee 100644 > ---

Re: [RFC PATCH net-next 02/12] vhost_net: introduce vhost_exceeds_weight()

2018-05-21 Thread Jesse Brandeburg
On Mon, 21 May 2018 17:04:23 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 15d191a..de544ee 100644 > --- a/drivers/vhost/net.c >

Re: [RFC PATCH net-next 01/12] vhost_net: introduce helper to initialize tx iov iter

2018-05-21 Thread Jesse Brandeburg
Hi Jason, a few nits. On Mon, 21 May 2018 17:04:22 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/net.c

Re: [RFC PATCH net-next 01/12] vhost_net: introduce helper to initialize tx iov iter

2018-05-21 Thread Jesse Brandeburg
Hi Jason, a few nits. On Mon, 21 May 2018 17:04:22 +0800 Jason wrote: > Signed-off-by: Jason Wang > --- > drivers/vhost/net.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index

Re: [uml-devel] [PATCH] uml: Fix build with recent glibc

2018-03-01 Thread Jesse Brandeburg
e.com/user-mode-linux-devel@lists.sourceforge.net/msg10071.html Reviewed-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [uml-devel] [PATCH] uml: Fix build with recent glibc

2018-03-01 Thread Jesse Brandeburg
se the typedefs which are still available. They also work on > older glibcs. > > Signed-off-by: Andi Kleen same patch that I sent on Feb 1st. Hope you can get more traction than I did. https://www.mail-archive.com/user-mode-linux-devel@lists.sourceforge.net/msg10071.html Reviewed-by: Jesse Brandeburg

[PATCH] um: fix user mode linux build

2018-01-25 Thread Jesse Brandeburg
ger <rich...@nod.at> Cc: user-mode-linux-de...@lists.sourceforge.net Signed-off-by: Jesse Brandeburg <jesse.brandeb...@intel.com> --- arch/um/os-Linux/signal.c | 2 +- arch/x86/um/stub_segv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/um/os-Linux/signal

[PATCH] um: fix user mode linux build

2018-01-25 Thread Jesse Brandeburg
-de...@lists.sourceforge.net Signed-off-by: Jesse Brandeburg --- arch/um/os-Linux/signal.c | 2 +- arch/x86/um/stub_segv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/um/os-Linux/signal.c b/arch/um/os-Linux/signal.c index a86d7cc2c2d8..a5c0c909c48b 100644 --- a/arch/um

Re: [Intel-wired-lan] [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()

2018-01-02 Thread Jesse Brandeburg
> This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Thanks for the patch. Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com>

Re: [Intel-wired-lan] [PATCH] i40e: Delete an error message for a failed memory allocation in i40e_init_interrupt_scheme()

2018-01-02 Thread Jesse Brandeburg
d-off-by: Markus Elfring Thanks for the patch. Acked-by: Jesse Brandeburg

[PATCH] phy: qcom-ufs: add missing MODULE_DESCRIPTION/LICENSE

2017-11-20 Thread Jesse Chan
f the file. MODULE_DESCRIPTION is also added. Signed-off-by: Jesse Chan <j...@linux.com> --- drivers/phy/qualcomm/phy-qcom-ufs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c b/drivers/phy/qualcomm/phy-qcom-ufs.c index c5ff4525edef..124dc70f6986 100644 -

  1   2   3   4   5   6   7   8   9   10   >