Re: [PATCH v5 0/6] Deliver vGPU display refresh event to userspace

2019-09-05 Thread kra...@redhat.com
Hi, > Option 2: QEMU provides the emulated display refresh event to the > vgpus provided by vendor driver. For vgpus, the display refresh event > can be considered as the vblank event which is leveraged by guest > window manager to do the plane update or mode-setting. > People are asking if

Re: [PATCH v5 2/6] vfio: Introduce vGPU display irq type

2019-08-20 Thread kra...@redhat.com
> > > +#define VFIO_IRQ_TYPE_GFX(1) > > > +/* > > > + * vGPU vendor sub-type > > > + * vGPU device display related interrupts e.g. vblank/pageflip */ > > > +#define VFIO_IRQ_SUBTYPE_GFX_DISPLAY_IRQ (1) > > > > If this is a GFX/DISPLAY IRQ, why are we

Re: [RFC PATCH v4 2/6] vfio: Introduce vGPU display irq type

2019-08-02 Thread kra...@redhat.com
Hi, > > > Couldn't you expose this as another capability within the IRQ_INFO return > > > data? If you were to define it as a macro, I assume that means it would > > > be > > > hard coded, in which case this probably becomes an Intel specific IRQ, > > > rather > > > than what appears to be

Re: [RFC PATCH v2 1/3] vfio: Use capability chains to handle device specific irq

2019-06-05 Thread kra...@redhat.com
Hi, > > Really need to split for different planes? I'd like a > > VFIO_IRQ_SUBTYPE_GFX_DISPLAY_EVENT > > so user space can probe change for all. > User space can choose to user different handlers according to the > specific event. For example, user space might not want to handle every > cursor

Re: [PATCH] drm/bochs: Fix the ID mismatch error

2019-02-21 Thread kra...@redhat.com
On Thu, Feb 21, 2019 at 10:44:06AM -0800, Alistair Francis wrote: > On Thu, Feb 21, 2019 at 3:52 AM kra...@redhat.com wrote: > > > > On Thu, Feb 21, 2019 at 12:33:03AM +, Alistair Francis wrote: > > > When running RISC-V QEMU with the Bochs device attached

Re: [PATCH] drm/bochs: Fix the ID mismatch error

2019-02-21 Thread kra...@redhat.com
On Thu, Feb 21, 2019 at 12:33:03AM +, Alistair Francis wrote: > When running RISC-V QEMU with the Bochs device attached via PCIe the > probe of the Bochs device fails with: > [drm:bochs_hw_init] *ERROR* ID mismatch > > This was introduced by this commit: > 7780eb9ce8 bochs: convert to