Hi Lee,
I am wondering if you have accepted this patch?
Best Regards.
micky.
On 10/11/2014 09:07 AM, Micky Ching wrote:
On 10/10/2014 06:21 PM, Lee Jones wrote:
On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
Fix rts5227&5249 failed send buffer cmd after sus
Hi Lee,
I am wondering if you have accepted this patch?
Best Regards.
micky.
On 10/11/2014 09:07 AM, Micky Ching wrote:
On 10/10/2014 06:21 PM, Lee Jones wrote:
On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts52275249 failed send
On 10/10/2014 06:21 PM, Lee Jones wrote:
On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
Fix rts5227&5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead re
On 10/10/2014 05:24 PM, Lee Jones wrote:
On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
Fix rts5227&5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead re
On 10/10/2014 05:24 PM, Lee Jones wrote:
On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts52275249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed
On 10/10/2014 06:21 PM, Lee Jones wrote:
On Fri, 10 Oct 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts52275249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed
On 09/19/2014 08:21 AM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky wrote:
On 09/18/2014 12:53 PM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
Fix rts5227&5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any bu
On 09/19/2014 08:21 AM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky wrote:
On 09/18/2014 12:53 PM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts52275249 failed send buffer cmd after suspend,
PM_CTRL3 should
On 09/18/2014 12:53 PM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
Fix rts5227&5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead re
. This will lead UHSI card
failed to enter UHSI mode.
It is hard to control the UEFI driver leaving state, so we power off the
card power during probe.
Signed-off-by: Roger Tseng
Signed-off-by: Micky Ching
---
drivers/mmc/host/rtsx_pci_sdmmc.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion
have no chance to make card power off. This will lead UHSI card
failed to enter UHSI mode.
It is hard to control the UEFI driver leaving state, so we power off the
card power during probe.
Signed-off-by: Roger Tseng rogera...@realtek.com
Signed-off-by: Micky Ching micky_ch...@realsil.com.cn
On 09/18/2014 12:53 PM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Fix rts52275249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed
don't
know if it makes a difference here?
Hi Dan,
these function never return positive value, but other part of the driver
code
use (err < 0), I use (err < 0) here for consistency.
(err) and (err < 0) is same at least for these function called here.
Best Regards.
micky.
--
To unsub
,
these function never return positive value, but other part of the driver
code
use (err 0), I use (err 0) here for consistency.
(err) and (err 0) is same at least for these function called here.
Best Regards.
micky.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On 08/02/2014 01:55 AM, Fabio Falzoi wrote:
On Wed, Jul 30, 2014 at 09:52:35AM +0800, micky wrote:
Documentation/printk-formats.txt
Raw buffer as a hex string:
%*ph00 01 02 ... 3f
%*phC 00:01:02: ... :3f
%*phD 00-01-02- ... -3f
%*phN 000102 ... 3f
On 08/02/2014 01:55 AM, Fabio Falzoi wrote:
On Wed, Jul 30, 2014 at 09:52:35AM +0800, micky wrote:
Documentation/printk-formats.txt
Raw buffer as a hex string:
%*ph00 01 02 ... 3f
%*phC 00:01:02: ... :3f
%*phD 00-01-02- ... -3f
%*phN 000102 ... 3f
On 07/07/2014 03:10 PM, Fabio Falzoi wrote:
Fix an incorrect use of the %d format specifier in dev_err that caused a
warning.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/rtsx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c
len), false)
+#ifdef DEBUG
+#define rtsx_hex_dump(buf, len)\
+ print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, buf, len)
#else
-#define RTSX_DUMP(buf, buf_len)
+#define rtsx_hex_dump(buf, len)\
+ do {;}while(0)
Hi,
here e
)
+#define rtsx_hex_dump(buf, len)\
+ do {;}while(0)
Hi,
here exist some checkpatch errors.
Best Regards.
micky.
#endif
#endif /* __REALTEK_RTSX_TRACE_H */
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On 07/07/2014 03:10 PM, Fabio Falzoi wrote:
Fix an incorrect use of the %d format specifier in dev_err that caused a
warning.
Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com
---
drivers/staging/rts5208/rtsx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On 06/18/2014 04:00 PM, Lee Jones wrote:
On Mon, 16 Jun 2014, Ulf Hansson wrote:
On 16 June 2014 14:20, Lee Jones wrote:
From: Micky Ching
rtsx driver using a single function for transfer data, dma map/unmap are
placed in one fix function. We need map/unmap dma in different place(for
mmc
On 06/18/2014 04:00 PM, Lee Jones wrote:
On Mon, 16 Jun 2014, Ulf Hansson wrote:
On 16 June 2014 14:20, Lee Jones lee.jo...@linaro.org wrote:
From: Micky Ching micky_ch...@realsil.com.cn
rtsx driver using a single function for transfer data, dma map/unmap are
placed in one fix function. We
Hi Uffe,
do you accepted this patch?
if accepted, I will submit again with jones ack.
Best Regards.
micky.
On 06/19/2014 09:57 AM, micky wrote:
On 06/18/2014 07:03 PM, Ulf Hansson wrote:
On 18 June 2014 12:08, micky wrote:
On 06/18/2014 03:39 PM, Ulf Hansson wrote:
On 18 June 2014 03:17
Hi Uffe,
do you accepted this patch?
if accepted, I will submit again with jones ack.
Best Regards.
micky.
On 06/19/2014 09:57 AM, micky wrote:
On 06/18/2014 07:03 PM, Ulf Hansson wrote:
On 18 June 2014 12:08, micky micky_ch...@realsil.com.cn wrote:
On 06/18/2014 03:39 PM, Ulf Hansson wrote
On 06/18/2014 07:03 PM, Ulf Hansson wrote:
On 18 June 2014 12:08, micky wrote:
On 06/18/2014 03:39 PM, Ulf Hansson wrote:
On 18 June 2014 03:17, micky wrote:
On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky wrote:
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16
On 06/18/2014 03:39 PM, Ulf Hansson wrote:
On 18 June 2014 03:17, micky wrote:
On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky wrote:
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky wrote:
On 06/16/2014 04:42 PM, Ulf Hansson wrote
On 06/18/2014 03:39 PM, Ulf Hansson wrote:
On 18 June 2014 03:17, micky micky_ch...@realsil.com.cn wrote:
On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky micky_ch...@realsil.com.cn wrote:
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky micky_ch
On 06/18/2014 07:03 PM, Ulf Hansson wrote:
On 18 June 2014 12:08, micky micky_ch...@realsil.com.cn wrote:
On 06/18/2014 03:39 PM, Ulf Hansson wrote:
On 18 June 2014 03:17, micky micky_ch...@realsil.com.cn wrote:
On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky micky_ch
On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky wrote:
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky wrote:
On 06/16/2014 04:42 PM, Ulf Hansson wrote:
@@ -36,7 +37,10 @@ struct realtek_pci_sdmmc {
struct rtsx_pcr *pcr
On 06/17/2014 03:45 PM, Ulf Hansson wrote:
On 17 June 2014 03:04, micky micky_ch...@realsil.com.cn wrote:
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky micky_ch...@realsil.com.cn wrote:
On 06/16/2014 04:42 PM, Ulf Hansson wrote:
@@ -36,7 +37,10 @@ struct
.
micky.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky wrote:
On 06/16/2014 04:42 PM, Ulf Hansson wrote:
@@ -36,7 +37,10 @@ struct realtek_pci_sdmmc {
struct rtsx_pcr *pcr;
struct mmc_host *mmc;
struct mmc_request *mrq
ng handle request.
So I use workq, we just queue a work and return in ops->request(),
The mmc core can continue without blocking at ops->request().
Best Regards.
micky.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to m
a work and return in ops-request(),
The mmc core can continue without blocking at ops-request().
Best Regards.
micky.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On 06/16/2014 08:40 PM, Ulf Hansson wrote:
On 16 June 2014 11:09, micky micky_ch...@realsil.com.cn wrote:
On 06/16/2014 04:42 PM, Ulf Hansson wrote:
@@ -36,7 +37,10 @@ struct realtek_pci_sdmmc {
struct rtsx_pcr *pcr;
struct mmc_host *mmc;
struct
.
micky.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
up again.
Kind regards
Ulf Hansson
From: Micky Ching
This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d08.
The patch depend on commit c42deffd5b53c9e583d83c7964854ede2f12410d
, but the previous
patch was discard. So we have to delete the patch.
Signed-off-by: Micky Ching
Acked-by: Ulf
, until Chris
shows up again.
Kind regards
Ulf Hansson
From: Micky Chingmicky_ch...@realsil.com.cn
This reverts commit 1f7b581b3ffcb2a8437397a02f4af89fa6934d08.
The patch depend on commit c42deffd5b53c9e583d83c7964854ede2f12410d
mmc: rtsx: add support for pre_req and post_req, but the previous
Hi Lee
Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx:
add support for pre_reqand post_req"
if need for 3.15 fix.
Best Regards.
micky.
On 04/29/2014 03:36 PM, Ulf Hansson wrote:
On 29 April 2014 03:54, wrote:
>From: Micky Ching
>
>
Hi Lee
It seems Chris is too busy to responding, so would you help to pick this
patch for 3.15 fix.
Best Regards.
micky.
On 04/29/2014 03:30 PM, Ulf Hansson wrote:
On 29 April 2014 03:54, wrote:
>From: Micky Ching
>
>This reverts commit 1f7b581b3ffcb2a8437397a02f4af89
Hi Lee
It seems Chris is too busy to responding, so would you help to pick this
patch for 3.15 fix.
Best Regards.
micky.
On 04/29/2014 03:30 PM, Ulf Hansson wrote:
On 29 April 2014 03:54,micky_ch...@realsil.com.cn wrote:
From: Micky Chingmicky_ch...@realsil.com.cn
This reverts commit
Hi Lee
Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert mmc: rtsx:
add support for pre_reqand post_req
if need for 3.15 fix.
Best Regards.
micky.
On 04/29/2014 03:36 PM, Ulf Hansson wrote:
On 29 April 2014 03:54,micky_ch...@realsil.com.cn wrote:
From: Micky Chingmicky_ch
Hi Lee,
On 04/29/2014 04:02 PM, Lee Jones wrote:
From: Micky Ching
The commit have some problem,
using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix
these problem, and better to use a new method. So just remove it.
The commit depends
on the previous patch
Hi Dan,
I have send this patch to fix the static checker warning, but not
applied yet.
Best Regards.
micky.
On 04/02/2014 05:58 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
The patch fa590c222fba: "staging: rts5208: add support for rts5208
and rts5288" from Nov 12, 2
Hi Dan,
I have send this patch to fix the static checker warning, but not
applied yet.
Best Regards.
micky.
On 04/02/2014 05:58 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
The patch fa590c222fba: staging: rts5208: add support for rts5208
and rts5288
Hi Lee,
On 04/29/2014 04:02 PM, Lee Jones wrote:
From: Micky Ching micky_ch...@realsil.com.cn
The commit mmc: rtsx: add support for pre_req and post_req have some problem,
using mutex_unlock() in atomic context, spinlock deadlock, it is hard to fix
these problem, and better to use a new method
Hi Chris and Ulf,
This patch is denpend on commit c42deffd5b53c9e583d83c7964854ede2f12410d.
, and we discard the
previous commit.
we want discard this patch also(it it now in linux-next), need I send
another patch to
revert or it will be discard automatically?
Best Regards.
micky.
On 03/27
Hi Chris and Ulf,
This patch should be applied to 3.15(rc), 3.14, 3.13.
without this patch the MMC card can not identified.
Best Regards.
micky.
On 03/27/2014 01:35 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
commit a27fbf2f067b0cd6f172c8b696b9a44c58bfaa7a
produced a cmd.flags
Hi Chris and Ulf,
Since the original commit is merged into kernel 3.15-rc, we want this patch
apply to the 3.15-rc to avoid cause serious problem.
Is there any thing I need do?
Best Regards.
micky.
On 04/28/2014 03:36 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
This reverts
Hi Chris and Ulf,
Since the original commit is merged into kernel 3.15-rc, we want this patch
apply to the 3.15-rc to avoid cause serious problem.
Is there any thing I need do?
Best Regards.
micky.
On 04/28/2014 03:36 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch
Hi Chris and Ulf,
This patch should be applied to 3.15(rc), 3.14, 3.13.
without this patch the MMC card can not identified.
Best Regards.
micky.
On 03/27/2014 01:35 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
commit
automatically?
Best Regards.
micky.
On 03/27/2014 01:35 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Using non-DMA dump-regs, which would be more exactly for DMA transfer failed.
More careful handle when cmd/data timeout, add stop(CMD12) cmd before go
Hi Borislav
Thank you for test the patch. It seems we can't use tasklet here due to
mutex_lock.
And the spinlock may removed, I'm prepare to resend a different patch later.
Best Regards.
micky
On 04/20/2014 08:20 PM, Borislav Petkov wrote:
Hi,
On Wed, Apr 16, 2014 at 09:50:15AM +0800, micky
Hi Peter,
I'm considering not using spinlock to get it work and will resend the
patch later.
Thank you.
Best Regards.
micky
On 04/19/2014 07:13 AM, Peter Wu wrote:
So, I reverted c42deffd5b53c9e583d83c7964854ede2f12410d ("mmc: rtsx: add
support for pre_req and post_req") on top of
Hi Peter,
I'm considering not using spinlock to get it work and will resend the
patch later.
Thank you.
Best Regards.
micky
On 04/19/2014 07:13 AM, Peter Wu wrote:
So, I reverted c42deffd5b53c9e583d83c7964854ede2f12410d (mmc: rtsx: add
support for pre_req and post_req) on top of v3.15-rc1-49
Hi Borislav
Thank you for test the patch. It seems we can't use tasklet here due to
mutex_lock.
And the spinlock may removed, I'm prepare to resend a different patch later.
Best Regards.
micky
On 04/20/2014 08:20 PM, Borislav Petkov wrote:
Hi,
On Wed, Apr 16, 2014 at 09:50:15AM +0800, micky
Hi Borislav,
On 04/16/2014 01:49 AM, Borislav Petkov wrote:
Hi all,
I'm seeing the following when I insert an sd card. Kernel is 3.15-rc1+.
Thanks.
The patch below may fix this problem.
From: Micky Ching
To avoid dead lock, we need make sure host->lock is always acquire
before pcr-&g
Hi Borislav,
On 04/16/2014 01:49 AM, Borislav Petkov wrote:
Hi all,
I'm seeing the following when I insert an sd card. Kernel is 3.15-rc1+.
Thanks.
The patch below may fix this problem.
From: Micky Chingmicky_ch...@realsil.com.cn
To avoid dead lock, we need make sure host-lock is always
Hi Ulf,
On 03/25/2014 06:44 PM, Ulf Hansson wrote:
On 25 March 2014 10:47, wrote:
From: Micky Ching
Add new command type(R1 without CRC) handle, without this
patch mmc card initialize will be failed.
Using a more careful handle in request timeout, this would
improve error recover
Hi Ulf,
On 03/25/2014 06:44 PM, Ulf Hansson wrote:
On 25 March 2014 10:47, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Add new command type(R1 without CRC) handle, without this
patch mmc card initialize will be failed.
Using a more careful handle in request
Hi Chris,
Could you please give me some idea about this patch-set?
I send this patch-set many times, but didn't get any reply.
Best Regards.
micky
On 02/17/2014 04:45 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
First we fix the card poweroff bug: the card power is not shutdown
Hi Chris,
Could you please give me some idea about this patch-set?
I send this patch-set many times, but didn't get any reply.
Best Regards.
micky micky_ch...@realsil.com.cn
On 02/17/2014 04:45 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
First we fix
Hi,
On 01/10/2014 03:26 PM, Francis Moreau wrote:
I still can see any traces of this fix in Linus' tree.
Shouldn't this get merged before 3.13 is out ?
Thanks
Good, I think it is good to merge. Thanks.
Best Regards.
micky.
--
To unsubscribe from this list: send the line "unsubscribe
Hi,
On 01/10/2014 03:26 PM, Francis Moreau wrote:
I still can see any traces of this fix in Linus' tree.
Shouldn't this get merged before 3.13 is out ?
Thanks
Good, I think it is good to merge. Thanks.
Best Regards.
micky.
--
To unsubscribe from this list: send the line unsubscribe linux
Hi,
Is there anything wrong with this patch? It seems a long time, but I
didn't got any reply.
On 12/03/2013 10:34 AM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
If the driver removed while sd card still in the slot, the card power
will not power down correctly, if we insert
Hi,
Is there anything wrong with this patch? It seems a long time, but I
didn't got any reply.
On 12/03/2013 10:34 AM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
If the driver removed while sd card still in the slot, the card power
will not power down
Hi Francis,
We are trying to get the environment same with yours, so it may take
some to solve this problem.
maybe next month.
Best Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Francis,
We are trying to get the environment same with yours, so it may take
some to solve this problem.
maybe next month.
Best Regards.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
:56 AM, micky wrote:
Hi Francis:
On 12/10/2013 09:39 AM, wwang wrote:
which is based on Thomas' patch.
Can you help us test this patch, we disable irq while suspend here.
This patch doesn't seem to help, it still oops:
[ 29.843910] [ cut here ]
[ 29.843917] WARNING
On 12/17/2013 03:28 PM, Dan Carpenter wrote:
On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote:
diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h
index 947e79b..26b52ec 100644
--- a/drivers/mfd/rtsx_pcr.h
+++ b/drivers/mfd/rtsx_pcr.h
@@ -63,4 +63,12 @@ static
On 12/17/2013 03:28 PM, Dan Carpenter wrote:
On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ch...@realsil.com.cn wrote:
diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h
index 947e79b..26b52ec 100644
--- a/drivers/mfd/rtsx_pcr.h
+++ b/drivers/mfd/rtsx_pcr.h
@@ -63,4 +63,12 @@ static
:56 AM, micky wrote:
Hi Francis:
On 12/10/2013 09:39 AM, wwang wrote:
which is based on Thomas' patch.
Can you help us test this patch, we disable irq while suspend here.
This patch doesn't seem to help, it still oops:
[ 29.843910] [ cut here ]
[ 29.843917] WARNING
Hi Francis:
On 12/10/2013 09:39 AM, wwang wrote:
which is based on Thomas' patch.
Can you help us test this patch, we disable irq while suspend here.
From 6b2bd6d85780bfd8d4fe5289aee1b09dd655d2d4 Mon Sep 17 00:00:00 2001
From: Micky Ching
Date: Thu, 5 Dec 2013 16:44:19 +0800
Subject: [PATCH
Hi Francis:
On 12/10/2013 09:39 AM, wwang wrote:
which is based on Thomas' patch.
Can you help us test this patch, we disable irq while suspend here.
From 6b2bd6d85780bfd8d4fe5289aee1b09dd655d2d4 Mon Sep 17 00:00:00 2001
From: Micky Ching micky_ch...@realsil.com.cn
Date: Thu, 5 Dec 2013 16:44
nitialized in this
function [-Wuninitialized]
drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this
function [-Wuninitialized]
Signed-off-by: Lee Jones
Tested-by: Micky Ching
I know this is a bit of
On 12/03/2013 06:40 PM, Lee Jones wrote:
By the way, I'm going to apply this patch now.
So, in next patch-set, I will not include this patch.
--
Best Regards
Micky.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
On 12/03/2013 06:45 PM, Lee Jones wrote:
From: Micky Ching
Add card reader rtl8042, rtl8402 is much like rtl8411, so just add it to
rtl8411.c
Signed-off-by: Lee Jones
I have never signed this patch off.
These tags actually 'mean' something. Please don't apply them willy-nilly!
ok, I
nitialized in this
function [-Wuninitialized]
drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this
function [-Wuninitialized]
Signed-off-by: Lee Jones
Tested-by: Micky Ching
I know this is a bit of
' is used uninitialized in this
function [-Wuninitialized]
drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this
function [-Wuninitialized]
Signed-off-by: Lee Jones lee.jo...@linaro.org
Tested-by: Micky Ching
On 12/03/2013 06:45 PM, Lee Jones wrote:
From: Micky Chingmicky_ch...@realsil.com.cn
Add card reader rtl8042, rtl8402 is much like rtl8411, so just add it to
rtl8411.c
Signed-off-by: Lee Joneslee.jo...@linaro.org
I have never signed this patch off.
These tags actually 'mean' something
On 12/03/2013 06:40 PM, Lee Jones wrote:
By the way, I'm going to apply this patch now.
So, in next patch-set, I will not include this patch.
--
Best Regards
Micky.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
' is used uninitialized in this
function [-Wuninitialized]
drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this
function [-Wuninitialized]
Signed-off-by: Lee Jones lee.jo...@linaro.org
Tested-by: Micky Ching
zero
on success?
"phase_point" might be helpful but I don't know what a phase_point is.
Add a comment about that maybe.
Yes, thank you for your suggestion, the function name is really not good.
I want use test_phase_bit(u32 phase_map, unsigned int bit), is that ok?
regards,
dan carpenter
what a phase_point is.
Add a comment about that maybe.
Yes, thank you for your suggestion, the function name is really not good.
I want use test_phase_bit(u32 phase_map, unsigned int bit), is that ok?
regards,
dan carpenter
.
--
Best Regards
Micky.
--
To unsubscribe from this list: send
the if-else not work correctly.
--
Best Regards
Micky.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
1v8);
if (err < 0)
return err;
- val = (BPP_ASIC_1V8 << BPP_TUNED18_SHIFT_8411) | BPP_PAD_1V8;
+ val = (BPP_ASIC_1V8 << shift) | BPP_PAD_1V8;
} else {
return -EINVAL;
}
--
Best Regard
)
return err;
- val = (BPP_ASIC_1V8 BPP_TUNED18_SHIFT_8411) | BPP_PAD_1V8;
+ val = (BPP_ASIC_1V8 shift) | BPP_PAD_1V8;
} else {
return -EINVAL;
}
--
Best Regards
Micky.
--
To unsubscribe from this list: send the line unsubscribe
the if-else not work correctly.
--
Best Regards
Micky.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
send
me your Signed-off-by: for that one, I will add that and make you the
author.
Sorry, I haven't received the patch-set you send, can you please resend
the patch to me?
--
Best Regards
Micky.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
send
me your Signed-off-by: for that one, I will add that and make you the
author.
Sorry, I haven't received the patch-set you send, can you please resend
the patch to me?
--
Best Regards
Micky.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
change , and I will add it in a later time.
So, I wanna to send the merged patch first, is that ok?
On 11/08/2013 05:56 PM, Lee Jones wrote:
On Fri, 01 Nov 2013, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
Add card reader rtl8042, rtl8402 is much like rtl8411, so just add
change , and I will add it in a later time.
So, I wanna to send the merged patch first, is that ok?
On 11/08/2013 05:56 PM, Lee Jones wrote:
On Fri, 01 Nov 2013, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
Add card reader rtl8042, rtl8402 is much like
card, ms card use normal read/write mode for DMA
data transfer.
What are the user-visible effects of this bug?
Please always include this information when fixing bugs so that others
can decide whether they (or their customers) need the patch.
.
--
Best Regards
Micky.
--
To unsubscribe from
wrote:
unlike mspro card, ms card use normal read/write mode for DMA
data transfer.
What are the user-visible effects of this bug?
Please always include this information when fixing bugs so that others
can decide whether they (or their customers) need the patch.
.
--
Best Regards
Micky
Hi Chris:
Have you accepted this patch, I'm waiting a long time for your reply.
Best Reagards.
micky
On 09/02/2013 05:16 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
The new phase searching method is more concise, and makes the code
easier to understand.
Signed-off-by: Micky
Hi Chris:
Have you accepted this patch, I'm waiting a long time for your reply.
Best Reagards.
micky
On 09/02/2013 05:16 PM, micky_ch...@realsil.com.cn wrote:
From: Micky Ching micky_ch...@realsil.com.cn
The new phase searching method is more concise, and makes the code
easier to understand
Hi Chris:
have you accepted this patch ?
micky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Chris:
have you accepted this patch ?
micky
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
98 matches
Mail list logo
