On Wed, Sep 13, 2023 at 05:13:04PM +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
Thanks, applied to my next tree.
-corey
>
> In this case, strncpy is being used specifically for its NUL-padding
> behavior (and has been commented as
On Tue, Sep 12, 2023 at 05:55:02PM -0700, Justin Stitt wrote:
> On Tue, Sep 12, 2023 at 5:19 PM Corey Minyard wrote:
> >
> > On Tue, Sep 12, 2023 at 11:43:05PM +, Justin Stitt wrote:
> > > `strncpy` is deprecated for use on NUL-terminated destination strings [1].
On Tue, Sep 12, 2023 at 11:43:05PM +, Justin Stitt wrote:
> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>
> In this case, strncpy is being used specifically for its NUL-padding
> behavior (and has been commented as such). We can use a more robust and
> less
On Thu, Apr 08, 2021 at 10:27:46AM +0930, Andrew Jeffery wrote:
> Hi Corey,
>
> On Fri, 19 Mar 2021, at 16:49, Andrew Jeffery wrote:
> > Hello,
> >
> > This series is a bit of a mix of things, but its primary purpose is to
> > expose BMC KCS IPMI devices to userspace in a way that enables
On Tue, Mar 30, 2021 at 09:10:28PM +0700, Quan Nguyen wrote:
> The SMBus system interface (SSIF) IPMI BMC driver can be used to perform
> in-band IPMI communication with their host in management (BMC) side.
>
> This commits adds support specifically for Aspeed AST2500 which commonly
> used as
On Wed, Apr 07, 2021 at 08:09:50PM +0700, Quan Nguyen wrote:
> Hi Corey,
>
> Thank you for reviewing
> I'll put my respond inline below.
>
> -Quan
>
> On 02/04/2021 21:21, Corey Minyard wrote:
> > On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote:
b folder to use new header.
> Though for time being include new header back to kernel.h to avoid twisted
> indirected includes for existing users.
For the IPMI portion:
Acked-by: Corey Minyard
>
> Signed-off-by: Andy Shevchenko
> ---
> arch/powerpc/kernel/setup-common.c | 1
On Fri, Apr 02, 2021 at 08:43:24PM +0300, Andy Shevchenko wrote:
> The series contains set of clean ups, main parts of which are:
> - use ne platform_get_mem_or_io() API
> - use match_string() API
As I have already said, a very nice set of cleanups. Thank you.
These are applied and in the ipmi
On Tue, Mar 30, 2021 at 09:10:26PM +0700, Quan Nguyen wrote:
> This series add support for the Aspeed specific SSIF BMC driver which
> is to perform in-band IPMI communication with the host in management
> (BMC) side.
I don't have any specific feedback for this, but I'm wondering if it's
really
On Tue, Mar 30, 2021 at 09:16:40PM +0300, Andy Shevchenko wrote:
> Switch to use new platform_get_mem_or_io() instead of home grown analogue.
> Note, we also introduce ipmi_set_addr_data_and_space() helper here.
You didn't send a part 0 that I saw, so just using this. This is a nice
cleanup set,
On Tue, Mar 30, 2021 at 09:16:45PM +0300, Andy Shevchenko wrote:
> Instead of making the comparison one by one, reuse si_to_str array
> in ipmi_hardcode_init_one() in conjunction with match_string() API.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/char/ipmi/ipmi_si.h | 3 +++
>
On Tue, Mar 30, 2021 at 09:16:44PM +0300, Andy Shevchenko wrote:
> Instead of twice repeat the constant literals, introduce
> panic_event_str array. It allows to simplify the code with
> help of match_string() API.
>
> Signed-off-by: Andy Shevchenko
> ---
> drivers/char/ipmi/ipmi_msghandler.c |
On Tue, Mar 30, 2021 at 09:16:42PM +0300, Andy Shevchenko wrote:
> By one of the previous clean up change we got a temporary variable to hold
> a device pointer. It can be utilized in other calls in the ->probe() and
> save a bit of LOCs.
The description here isn't accurate, there is no previous
On Thu, Mar 04, 2021 at 12:03:12PM +0300, Heikki Krogerus wrote:
> The old device property API is going to be removed.
> Replacing the device_add_properties() call with the software
> node API equivalent, device_create_managed_software_node().
Ok, this has been queued for next release.
Thanks,
This looks ok, it's queued for 5.12.
Thanks,
-corey
On Mon, Mar 01, 2021 at 10:05:15PM +0800, Liguang Zhang wrote:
> This function actually needs no return value. So remove the unneeded
> check and make it void.
>
> Signed-off-by: Liguang Zhang
> ---
> drivers/char/ipmi/ipmi_ssif.c | 81
The following changes since commit 76c057c84d286140c6c416c3b4ba832cd1d8984e:
Merge branch 'parisc-5.11-2' of
git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux (2021-01-27
11:06:15 -0800)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git
On Thu, Jan 28, 2021 at 01:53:50PM +0100, Wolfram Sang wrote:
> On Thu, Jan 28, 2021 at 06:37:57AM -0600, Corey Minyard wrote:
> > Looks good, do you want this in the IPMI tree or are you handling this
> > another way?
>
> I can take it but would prefer the IPMI tree.
Ok,
nebhi
> Acked-by: Corey Minyard
> ---
>
> No change since V1, Only added tags given in private communication.
>
> drivers/char/ipmi/ipmb_dev_int.c | 24
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/char/ipmi/i
style point of view, but that's all I can tell. So I'm ok with it.
Acked-by: Corey Minyard
>
> Thanks,
> Chiawei
>
> > -Original Message-
> > From: Andrew Jeffery
> > Sent: Wednesday, January 20, 2021 1:03 PM
> > Subject: Re: [PATCH v5 3/5
On Tue, Jan 12, 2021 at 05:41:29PM +0100, Wolfram Sang wrote:
> The block-write function of the core was not used because there was no
> client-struct to use. However, in this case it seems apropriate to use a
> temporary client struct. Because we are answering a request we recieved
> when being a
On Fri, Jan 08, 2021 at 11:37:04PM +, Asmaa Mnebhi wrote:
> Hi Corey,
>
> I have a question for you related to the following function in
> ipmi_msghandler.c
>
> static void __get_guid(struct ipmi_smi *intf)
> {
> int rv;
> struct bmc_device *bmc = intf->bmc;
>
>
On Mon, Nov 23, 2020 at 06:49:02PM -0600, miny...@acm.org wrote:
> From: Corey Minyard
>
> Remove the tty_vhangup() from the pty code and just release the
> redirect. The tty_vhangup() results in data loss and data out of order
> issues.
It's been a while, so ping on this.
Some very minor fixes. One came it today, but it was just changing
some commas to semicolons. The rest have been lying around a month or
more.
The following changes since commit 9ff9b0d392ea08090cd1780fb196f36dbb586529:
Merge tag 'net-next-5.10' of
From: Corey Minyard
This will be required by the pty code when it removes tty_vhangup() on
master close.
Signed-off-by: Corey Minyard
---
drivers/tty/tty_io.c | 32
include/linux/tty.h | 1 +
2 files changed, 25 insertions(+), 8 deletions(-)
diff --git
From: Corey Minyard
Remove the tty_vhangup() from the pty code and just release the
redirect. The tty_vhangup() results in data loss and data out of order
issues.
If you write to a pty master an immediately close the pty master, the
receiver might get a chunk of data dropped, but then receive
I finally got some time to spend with this issue, and I think I have a
good fix. Not really a v2, this is a completely different fix.
Basically, calling tty_vhangup() on the slave when closing a pty master
is just a bad idea.
>From what I can tell, the tty_vhangup() is there in case there was a
On Thu, Nov 19, 2020 at 03:08:39PM +0800, Qinglang Miao wrote:
> while running ipmi, ipmi_smi_watcher_register() caused
> a suspicious RCU usage warning.
Thanks. I had looked at this and found it was ok, but I hand't spent
the time to figure out how to suppress it. It's in my next queue.
On Mon, Nov 16, 2020 at 03:30:07PM +0800, Yejune Deng wrote:
> atomic_inc() and atomic_dec() looks better
Yes, that's a little neater. Queued for next release.
Thanks,
-corey
>
> Signed-off-by: Yejune Deng
> ---
> drivers/char/ipmi/ipmi_watchdog.c | 8
> 1 file changed, 4
On Mon, Oct 19, 2020 at 12:48:05PM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a return
Ok, it's in my next tree.
Thanks,
-corey
>
> Signed-off-by: Tom Rix
> ---
> drivers/char/ipmi/ipmi_devintf.c | 1 -
> 1 file changed, 1 deletion(-)
>
>
On Sat, Oct 17, 2020 at 09:40:10AM +0800, Tian Tao wrote:
> It is redundant to do irqsave and irqrestore in hardIRQ context.
Are ACPI GPEs run in hardirq context? I looked around a bit and
couldn't tell. If not, then I can't take this patch. Otherwise, it's
ok.
-corey
>
> Signed-off-by:
started up. So a retry was added.
Allen Pais (1):
char: ipmi: convert tasklets to use new tasklet_setup() API
Corey Minyard (1):
ipmi: Clean up some printks
Dan Carpenter (1):
ipmi: msghandler: Fix a signedness
On Thu, Sep 10, 2020 at 11:08:40AM +, Boehme, Markus via Openipmi-developer
wrote:
> > > - && ipmi_version_minor(id) >= 5)) {
> > > - unsigned int set;
> > > + if (ipmi_version_major(id) == 1 && ipmi_version_minor(id) < 5) {
> > This is incorrect, it
a dummy platform
> devices")
> Cc: Corey Minyard
> Signed-off-by: Tianjia Zhang
> ---
> drivers/char/ipmi/ipmi_si_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c
> b/drivers/char/ipmi/ipmi_si
s:
>- |
> #include
> diff --git
> a/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> b/Documentation/devicetree/bindings/iio/proximity/vishay,vcnl3020.yaml
> index 51dba64037f6..fbd3a2e32280 100644
> --- a/Documentation/devicetree/bindings/iio/pro
From: Corey Minyard
If you write to a pty master an immediately close the pty master, the
receiver might get a chunk of data dropped, but then receive some later
data. That's obviously something rather unexpected for a user. It
certainly confused my test program.
It turns out that tty_vhangup
From: Corey Minyard
If you write to a pty master an immediately close the pty master, the
receiver might get a chunk of data dropped, but then receive some later
data. That's obviously something rather unexpected for a user. It
certainly confused my test program.
It turns out that tty_vhangup
rom these.
Acked-by: Corey Minyard
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d6b9445649e5..a6f0a3ec0047 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4101,6 +4101,11 @@ T: git
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> F:
On Sun, Sep 27, 2020 at 01:37:51PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 25, 2020 at 05:05:36PM -0500, Corey Minyard wrote:
> > I've been trying to track down a bug in a library I support (named
> > gensio; it does all kinds of stream I/O) and I have figured out that
reset the stats and no change with the conversion.
>
> Convert them to use counter_atomic32.
>
> Signed-off-by: Shuah Khan
Reviewed-by: Corey Minyard
I assume for this conversion that the plan is to eliminate atomic_t
completely and convert all atomic counters used for object lifetime to
struct kre
I've been trying to track down a bug in a library I support (named
gensio; it does all kinds of stream I/O) and I have figured out that
the problem is not in the library, it's in the kernel. I have
attached a reproducer program, more on how to run it later.
Basically, if you have a pty master
On Wed, Sep 23, 2020 at 04:48:31PM +0800, Wu Bo wrote:
> On 2020/9/23 2:43, Corey Minyard wrote:
> > On Tue, Sep 22, 2020 at 01:29:40PM -0500, miny...@acm.org wrote:
> > > From: Corey Minyard
> > >
> > > If kdump is enabled, the handling of shooting down CPUs
On Tue, Sep 22, 2020 at 01:29:40PM -0500, miny...@acm.org wrote:
> From: Corey Minyard
>
> If kdump is enabled, the handling of shooting down CPUs does not use the
> RESET_VECTOR irq before trying to use NMIs to shoot down the CPUs.
>
> For normal errors that is fi
From: Corey Minyard
If kdump is enabled, the handling of shooting down CPUs does not use the
RESET_VECTOR irq before trying to use NMIs to shoot down the CPUs.
For normal errors that is fine. MCEs, however, are already running in
an NMI, so sending them an NMI won't do anything. The MCE code
On Tue, Sep 22, 2020 at 08:31:44AM -0500, Corey Minyard wrote:
> On Mon, Sep 21, 2020 at 10:00:08PM +0800, Wu Bo wrote:
> > In my virtual machine (have 4 cpus), Use mce_inject to inject errors
> > into the system. After mce-inject injects an uncorrectable error,
> > t
On Mon, Sep 21, 2020 at 10:00:08PM +0800, Wu Bo wrote:
> In my virtual machine (have 4 cpus), Use mce_inject to inject errors
> into the system. After mce-inject injects an uncorrectable error,
> there is a probability that the virtual machine is not reset immediately,
> but hangs for more than
On Thu, Sep 17, 2020 at 06:37:50PM +0800, Wu Bo wrote:
> In my virtual machine (have 4 cpus), Use mce_inject to inject errors
> into the system. After mce-inject injects an uncorrectable error,
> there is a probability that the virtual machine is not reset immediately,
> but hangs for more than
On Wed, Sep 16, 2020 at 02:21:29PM +0800, Xianting Tian wrote:
> Use retry machanism to give device more opportunitys to correctly response
> kernel when we received specific completion codes.
>
> This is similar to what we done in __get_device_id().
Thanks. I moved GET_DEVICE_ID_MAX_RETRY to
rformance if you don't
do this.
Thanks,
-corey
>
> Thanks a lot.
>
> -Original Message-
> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard
> Sent: Monday, September 14, 2020 11:40 PM
> To: tianxianting (RD)
> Cc: a...@arndb.de; gre...@lin
On Mon, Sep 14, 2020 at 04:13:13PM +0800, Xianting Tian wrote:
> We can't get bmc's device id with low probability when loading ipmi driver,
> it caused bmc device register failed. When this issue happened, we got
> below kernel printks:
This patch is moving in the right direction. For the final
;
> Thanks in advance if you can feedback again.
>
> -Original Message-
> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard
> Sent: Sunday, September 13, 2020 8:40 PM
> To: tianxianting (RD)
> Cc: a...@arndb.de; gre...@linuxfoundation.org;
>
On Sun, Sep 13, 2020 at 08:02:03PM +0800, Xianting Tian wrote:
> We can't get bmc's device id with low probability when loading ipmi driver,
> it caused bmc device register failed. This issue may caused by bad lpc
> signal quality. When this issue happened, we got below kernel printks:
>
On Mon, Sep 07, 2020 at 06:25:37PM +0200, Markus Boehme wrote:
> We have observed hosts with misbehaving BMCs that receive a Get Channel
> Info command but don't respond. This leads to an indefinite wait in the
> ipmi_msghandler's __scan_channels function, showing up as hung task
> messages for
On Mon, Sep 07, 2020 at 06:25:36PM +0200, Markus Boehme wrote:
> We have observed hosts with misbehaving BMCs that receive a Get Device
> GUID command but don't respond. This leads to an indefinite wait in the
> ipmi_msghandler's __get_guid function, showing up as hung task messages
> for
On Mon, Sep 07, 2020 at 06:25:35PM +0200, Markus Boehme wrote:
> When failing to send a command we don't expect a response. Clear the
> `null_user_handler` like is done in the success path.
This is correct. I guess, from the next two patches, I know how you
found this.
I can incude this, but I
On Thu, Sep 03, 2020 at 07:01:13PM +0800, Xiongfeng Wang wrote:
> When I cat ipmi_msghandler parameter 'panic_op' by sysfs, it displays as
> follows. It's better to add a newline for easy reading.
>
> root@(none):/# cat /sys/module/ipmi_msghandler/parameters/panic_op
> noneroot@(none):/#
Thanks,
On Tue, Aug 18, 2020 at 02:46:23PM +0530, Allen wrote:
> > >
> > > Signed-off-by: Romain Perier
> > > Signed-off-by: Allen Pais
> >
> > This looks good to me.
> >
> > Reviewed-by: Corey Minyard
> >
> > Are you planning to push
On Mon, Aug 17, 2020 at 10:44:57AM -0300, Marcelo Ricardo Leitner wrote:
> On Sun, Aug 16, 2020 at 06:06:24PM -0500, Corey Minyard wrote:
> > I'm seeing the following when an SCTP connection terminates. This is on
> > Raspian on a Raspberry Pi, version is Linux version 5.4.51-v7+.
pointer explicitly.
>
> Signed-off-by: Romain Perier
> Signed-off-by: Allen Pais
This looks good to me.
Reviewed-by: Corey Minyard
Are you planning to push this, or do you want me to take it? If you
want me to take it, what is the urgency?
-corey
> ---
> drivers/char/ipmi/ipmi_msg
I'm seeing the following when an SCTP connection terminates. This is on
Raspian on a Raspberry Pi, version is Linux version 5.4.51-v7+. That's
32-bit ARM.
I haven't looked into it yet, I thought I would report before trying to
chase anything down. I'm not seeing it on 5.4 x86_64 systems.
Aug
The following changes since commit a5dc8300df75e8b8384b4c82225f1e4a0b4d9b55:
scripts/decode_stacktrace: warn when modpath is needed but is unset
(2020-06-15 15:37:24 -0700)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/for-linus-5.9-1
for you to
On Tue, Jul 21, 2020 at 02:35:09PM +0800, Xiongfeng Wang wrote:
> When I cat some ipmi_watchdog parameters by sysfs, it displays as
> follows. It's better to add a newline for easy reading.
>
> root@(none):/# cat /sys/module/ipmi_watchdog/parameters/action
> resetroot@(none):/# cat
On Mon, Jul 20, 2020 at 10:03:25AM +0800, Xiongfeng Wang wrote:
> When I cat some ipmi_watchdog parameters by sysfs, it displays as
> follows. It's better to add a newline for easy reading.
>
> root@(none):/# cat /sys/module/ipmi_watchdog/parameters/action
> resetroot@(none):/# cat
On Mon, Jul 20, 2020 at 04:08:38PM +0800, Jing Xiangfeng wrote:
> __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an
> error path. So we can remove duplicate code in the if (rv).
Looks correct, queued for next release.
Thanks,
-corey
>
> Signed-off-by: Jing Xiangfeng
> ---
;
> The fix is to not add IPv4 addresses to ipv6only sockets.
Fixes the issue for me.
Tested-by: Corey Minyard
Thanks a bunch.
-corey
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: Corey Minyard
> Signed-off-by: Marcelo Ricardo Leitner
> ---
> include/ne
On Tue, Jun 23, 2020 at 01:17:28PM +, David Laight wrote:
> From: Marcelo Ricardo Leitner
> > Sent: 22 June 2020 19:33
> > On Mon, Jun 22, 2020 at 08:01:24PM +0200, Michael Tuexen wrote:
> > > > On 22. Jun 2020, at 18:57, Corey Minyard wrote:
> > > >
>
From: Corey Minyard
If a socket was set ipv6only, it would still send IPv4 addresses in the
init and init ack packets. So don't add IPv4 addresses to ipv6only
sockets.
Based on a patch by Xin Long
Signed-off-by: Corey Minyard
---
I have tested this and it seem to fix the issue. However
On Tue, Jun 23, 2020 at 11:40:21PM +0800, Xin Long wrote:
> On Tue, Jun 23, 2020 at 9:29 PM Corey Minyard wrote:
> >
> > On Tue, Jun 23, 2020 at 06:13:30PM +0800, Xin Long wrote:
> > > On Tue, Jun 23, 2020 at 2:34 AM Michael Tuexen
> > > wrote:
> >
0, Michael Tuexen wrote:
> > >>> On 22. Jun 2020, at 18:57, Corey Minyard wrote:
> > >>>
> > >>> On Mon, Jun 22, 2020 at 08:01:23PM +0800, Xin Long wrote:
> > >>>> On Sun, Jun 21, 2020 at 11:56 PM Corey Minyard wrote:
> > >>
On Mon, Jun 22, 2020 at 08:01:23PM +0800, Xin Long wrote:
> On Sun, Jun 21, 2020 at 11:56 PM Corey Minyard wrote:
> >
> > I've stumbled upon a strange problem with SCTP and IPv6. If I create an
> > sctp listening socket on :: and set the IPV6_V6ONLY socket option o
I've stumbled upon a strange problem with SCTP and IPv6. If I create an
sctp listening socket on :: and set the IPV6_V6ONLY socket option on it,
then I make a connection to it using ::1, the connection will drop after
2.5 seconds with an ECONNRESET error.
It only happens on SCTP, it doesn't have
On Tue, Jun 09, 2020 at 01:04:10AM -0500, wu000...@umn.edu wrote:
> From: Qiushi Wu
>
> All the previous get/put operations against intf->refcount are
> inside the mutex. Thus, put the last kref_put() also inside mutex
> to make sure get/put functions execute in order and prevent the
> potential
Andy Shevchenko (1):
ipmi: Replace guid_copy() with import_guid() where it makes sense
Corey Minyard (2):
Try to load acpi_ipmi when an SSIF ACPI IPMI interface is added
ipmi:ssif: Remove dynamic platform device handing
Feng Tang (1):
ipmi: use vzalloc instead
The following changes since commit ae83d0b416db002fe95601e7f97f64b59514d936:
Linux 5.7-rc2 (2020-04-19 14:35:30 -0700)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/for-linus-5.7-2
for you to fetch changes up to
On Wed, May 13, 2020 at 09:10:04AM +0200, Wolfram Sang wrote:
>
> > > - addr_info->added_client = i2c_new_device(to_i2c_adapter(adev),
> > > - _info->binfo);
> > > + addr_info->added_client = i2c_new_client_device(to_i2c_adapter(adev),
> > > +
On Wed, May 13, 2020 at 10:37:46AM +0200, Wolfram Sang wrote:
> On Tue, May 12, 2020 at 04:45:32PM -0500, miny...@acm.org wrote:
> > From: Wolfram Sang
> >
> > Move away from the deprecated API.
> >
> > Based on a patch by Wolfram Sang .
> >
> >
On Wed, May 13, 2020 at 10:30:34AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> 73d0824e48eb ("char: ipmi: convert to use i2c_new_client_device()")
>
> is missing a Signed-off-by from its author.
Fixed, thanks.
-corey
>
> --
> Cheers,
> Stephen Rothwell
From: Wolfram Sang
Move away from the deprecated API.
Based on a patch by Wolfram Sang .
Signed-off-by: Corey Minyard
---
I think this works.
drivers/char/ipmi/ipmi_ssif.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char
On Thu, Mar 26, 2020 at 10:09:58PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API.
Well, I should have looked a little closer first... comment inline
>
> Signed-off-by: Wolfram Sang
> ---
> drivers/char/ipmi/ipmi_ssif.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
On Thu, Mar 26, 2020 at 10:09:58PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API.
>
> Signed-off-by: Wolfram Sang
Ok by me.
Acked-by: Corey Minyard
Do you want me to take this, or is this part of something else? I can
submit it if you like.
-corey
> ---
>
On Tue, May 05, 2020 at 06:29:06PM +0800, Tang Bin wrote:
> If the function platform_get_irq() failed, the negative value
> returned will not be detected here. So fix error handling in
> bt_bmc_config_irq(). And in the function bt_bmc_probe(),
> when get irq failed, it will print error message. So
On Sun, Apr 19, 2020 at 02:29:26PM +0800, Tang Bin wrote:
> Hi, Corey:
>
> On 2020/4/18 21:49, Corey Minyard wrote:
> > On Sat, Apr 18, 2020 at 04:02:29PM +0800, Tang Bin wrote:
> > > If the function platform_get_irq() failed, the negative
> > > value returned
Mauro Carvalho Chehab
This is fine with me.
Acked-by: Corey Minyard
> ---
> Documentation/driver-api/index.rst | 1 +
> Documentation/{IPMI.txt => driver-api/ipmi.rst} | 0
> 2 files changed, 1 insertion(+)
> rename Documentation/{IPMI.txt => d
...@acm.org wrote:
> > From: Corey Minyard
> >
> > If something has the IPMI driver open, don't allow the device
> > module to be unloaded. Before it would unload and the user would
> > get errors on use.
> >
> > This change is made on user request, a
On Mon, Oct 21, 2019 at 03:06:48PM -0500, Navid Emamdoost wrote:
> In the impelementation of __ipmi_bmc_register() the allocated memory for
> bmc should be released in case ida_simple_get() fails.
Thanks, queued for next merge window.
-corey
>
> Fixes: 68e7e50f195f ("ipmi: Don't use BMC
On Wed, Oct 16, 2019 at 03:25:56PM -0400, Tony Camuso wrote:
> On 10/14/19 11:46 AM, miny...@acm.org wrote:
> > From: Corey Minyard
> >
> > If something has the IPMI driver open, don't allow the device
> > module to be unloaded. Before it would unload and the user
On Wed, Oct 16, 2019 at 04:41:07PM +0200, Cédric Le Goater wrote:
> On 16/10/2019 16:19, Corey Minyard wrote:
> > On Wed, Oct 16, 2019 at 05:21:31PM +0800, YueHaibing wrote:
> >> Use devm_platform_ioremap_resource() to simplify the code a bit.
> >> This is detected by
On Wed, Oct 16, 2019 at 05:21:31PM +0800, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
Adding the module author and others. I can't see a reason to not do
this.
-corey
>
> Signed-off-by: YueHaibing
> ---
>
On Fri, Oct 11, 2019 at 06:50:36PM +0300, Andy Shevchenko wrote:
> From: Andy Shevchenko
>
> Use %*ph format to print small buffer as hex string.
>
> The change is safe since the specifier can handle up to 64 bytes and taking
> into account the buffer size of 100 bytes on stack the function has
From: Corey Minyard
If something has the IPMI driver open, don't allow the device
module to be unloaded. Before it would unload and the user would
get errors on use.
This change is made on user request, and it makes it consistent
with the I2C driver, which has the same behavior.
It does
On Tue, Oct 08, 2019 at 11:49:15AM +0200, Pavel Machek wrote:
> Hi!
>
> > @@ -1013,11 +1016,20 @@ static int ipmi_thread(void *data)
> > spin_unlock_irqrestore(&(smi_info->si_lock), flags);
> > busy_wait = ipmi_thread_busy_wait(smi_result, smi_info,
> >
minor things that people have found and
some minor reworks for names and include files.
Thanks,
-corey
Corey Minyard (6):
ipmi_si: Convert timespec64 to timespec
ipmi_si: Rework some include files
ipmi_si: Convert
>
> >
> > {disable,enable}_si_irq() themselves are racy:
> >
> > static inline bool disable_si_irq(struct smi_info *smi_info)
> > {
> > if ((smi_info->io.irq) && (!smi_info->interrupt_disabled)) {
> > smi_info->interrupt_disabled = true;
> >
> > Basically
On Wed, Aug 28, 2019 at 08:53:47PM -0400, Jes Sorensen wrote:
> On 8/28/19 6:32 PM, Corey Minyard wrote:
> > On Wed, Aug 28, 2019 at 04:36:24PM -0400, Jes Sorensen wrote:
> >> From: Jes Sorensen
> >>
> >> I came across this in 4.16, but I believe the bug is sti
On Wed, Aug 28, 2019 at 04:36:24PM -0400, Jes Sorensen wrote:
> From: Jes Sorensen
>
> I came across this in 4.16, but I believe the bug is still present
> in current 5.x, even if it is less likely to trigger.
>
> Basially stop_timer_and_thread() only calls del_timer_sync() if
> timer_running
I am considering moving the IPMI watchdog over to the standard
watchdog framework. This will require the removal of the feature
that provides a byte of read data when the pretimeout occurs,
since that is not available in the standard framework.
Before I remove this, I thought I would ask: Is
From: Corey Minyard
These files were added as part of the FMC subsystem, but were not
removed when the FMC subsystem was removed in 6a80b30086 "fmc: Delete
the FMC subsystem". They have no users, so remove them.
Signed-off-by: Corey Minyard
Cc: Linus Walleij
Cc: Pat Riehecky
Cc:
On Wed, Jul 24, 2019 at 03:32:57PM -0400, Asmaa Mnebhi wrote:
> ret at line 112 of ipmb_dev_int.c is uninitialized which
> results in a warning during build regressions.
> This warning was found by build regression/improvement
> testing for v5.3-rc1.
Applied, thanks for sticking with it :).
On Wed, Jul 24, 2019 at 01:45:57PM -0400, Asmaa Mnebhi wrote:
> Signed-off-by: Asmaa Mnebhi
> Reported-by: Geert Uytterhoeven
Sorry to be picky here, but it's considered bad style to have an
empty message. I probably wasn't clear before, but you should
add some text like "Found by build
On Wed, Jul 24, 2019 at 10:36:42AM -0400, Asmaa Mnebhi wrote:
> Signed-off-by: Asmaa Mnebhi
The patch is, of course, fine, but you should add some info
about how it was found and a Reported-by: tag.
Thanks,
-corey
> ---
> drivers/char/ipmi/ipmb_dev_int.c | 2 +-
> 1 file changed, 1
The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9:
Linux 5.2-rc1 (2019-05-19 15:47:09 -0700)
are available in the Git repository at:
https://github.com/cminyard/linux-ipmi.git tags/for-linus-5.3
for you to fetch changes up to
1 - 100 of 1417 matches
Mail list logo
