Re: [PATCH] scripts: stable: add script to validate backports

On Tue, Mar 23, 2021 at 6:56 AM Greg Kroah-Hartman wrote: > > On Tue, Mar 16, 2021 at 02:31:33PM -0700, Nick Desaulniers wrote: > > A common recurring mistake made when backporting patches to stable is > > forgetting to check for additional commits tagged with `Fixes:`. This &g

Re: sparc: clang: error: unknown argument: '-mno-fpu'

ps, > riscv > and arc. We definitely cannot yet build arc. $ cmake ... -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD="ARC" $ ARCH=arc CROSS_COMPILE=arc-linux-gnu- make LLVM=1 -j72 defconfig vmlinux ... clang-13: error: unknown argument: '-mmedium-calls' clang-13: error: unknown argument: '-fsection-anchors' clang-13: error: unknown argument: '-mlock' clang-13: error: unknown argument: '-mswape' clang-13: error: unknown argument: '-mno-sdata' clang-13: error: unknown argument: '-fcall-used-gp' -- Thanks, ~Nick Desaulniers

[PATCH] Makefile: fix GDB warning with CONFIG_RELR

/ClangBuiltLinux/linux/issues/1057 Suggested-by: Peter Collingbourne Signed-off-by: Nick Desaulniers --- Makefile | 2 +- scripts/tools-support-relr.sh | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 5160ff8903c1..47741cb60995

Re: [PATCH v2 04/17] module: ensure __cfi_check alignment

t; +* With CONFIG_CFI_CLANG, we assume __cfi_check is at the beginning > +* of the .text section, and is aligned to PAGE_SIZE. > +*/ > + .text : ALIGN_CFI { > + *(.text.__cfi_check) > + *(.text .text.[0-9a-zA-Z_]* .text..L.cfi*) > + } > } > > /* bring in arch-specific sections */ > -- > 2.31.0.291.g576ba9dcdaf-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 07/17] kallsyms: strip ThinLTO hashes from static functions

name, KSYM_NAME_LEN); > modname[0] = '\0'; > - return 0; > + goto found; > } > /* See if it's in a module. */ > - return lookup_module_symbol_attrs(addr, size, offset, modname, name); > + res = lookup_module_symbol_attrs(addr, size, offset, modname, name); > + if (res) > + return res; > + > +found: > + cleanup_symbol_name(name); > + return 0; > } > > /* Look up a kernel symbol and return it in a text buffer. */ > -- > 2.31.0.291.g576ba9dcdaf-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 05/17] workqueue: use WARN_ON_FUNCTION_MISMATCH

timer->function != delayed_work_timer_fn); > + WARN_ON_FUNCTION_MISMATCH(timer->function, delayed_work_timer_fn); > WARN_ON_ONCE(timer_pending(timer)); > WARN_ON_ONCE(!list_empty(>entry)); > > -- > 2.31.0.291.g576ba9dcdaf-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 10/17] lkdtm: use __va_function

On Thu, Mar 18, 2021 at 11:43 AM Nick Desaulniers wrote: > > On Thu, Mar 18, 2021 at 10:11 AM Sami Tolvanen > wrote: > > > > To ensure we take the actual address of a function in kernel text, use > > __va_function. Otherwise, with CONFIG_CFI_CLANG, the compil

Re: [PATCH v2 10/17] lkdtm: use __va_function

unconst + PAGE_SIZE)) { > pr_warn("copy_to_user failed, but lacked Oops\n"); > goto free_user; > -- > 2.31.0.291.g576ba9dcdaf-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 09/17] lib/list_sort: fix function type mismatches

e final merge, rebuilding prev links */ > - merge_final(priv, (cmp_func)cmp, head, pending, list); > + merge_final(priv, cmp, head, pending, list); > } > EXPORT_SYMBOL(list_sort); > -- > 2.31.0.291.g576ba9dcdaf-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 02/17] cfi: add __cficanonical

ported version of clang for the kernel, and this series depends on LTO which depends on clang-12, so no additional guards are necessary). Reviewed-by: Nick Desaulniers > --- > include/linux/compiler-clang.h | 1 + > include/linux/compiler_types.h | 4 > include/linux/init.h

Re: s390: kernel/entry.o: in function `sys_call_table_emu': (.rodata+0x1bc0): undefined reference to `__s390_'

(Replying to https://lore.kernel.org/linux-s390/ca+g9fytbw0hav5ooayck2rz_m2sj73krxpj0idzt+o8qtc1...@mail.gmail.com/) Yeah, our CI is failing today, too with the same error on linux-next: https://github.com/ClangBuiltLinux/continuous-integration2/runs/2138006304?check_suite_focus=true

[PATCH] scripts: stable: add script to validate backports

the commit message and retry. $ git commit --amend $ ./scripts/stable/check_backports.py Checking 2 local commits for additional Fixes: in master $ echo $? 0 This allows for client side validation by the backports author, and server side validation by the stable kernel maintainers. Signed-off-by: Nick

Re: [PATCH] memblock: fix section mismatch warning again

rnel.org/lkml/202103160133.uzhgy0wt-...@intel.com > Fixes: 34dc2efb39a2 ("memblock: fix section mismatch warning") > Signed-off-by: Mike Rapoport > Reported-by: kernel test robot > Reviewed-by: Arnd Bergmann Thank you Mike. Acked-by: Nick Desaulniers > --- > > @A

Re: WARNING: modpost: vmlinux.o(.text+0x74fea4): Section mismatch in reference from the function memblock_find_in_range_node() to the function .init.text:memblock_bottom_up()

direction. > */ > -static inline __init bool memblock_bottom_up(void) > +static inline __init_memblock bool memblock_bottom_up(void) > { > return memblock.bottom_up; > } > > > -- > Sincerely yours, > Mike. > > -- > You received this message because you are subscribed to the Google Groups > "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/YFBYWjtWJrnGyiVp%40linux.ibm.com. -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 3/3] kbuild: dwarf: use AS_VERSION instead of test_dwarf5_support.sh

C code is as follows: > > - gcc + gnu as -> requires gcc 5.0+ (but 7.0+ for full support) > - clang + gnu as-> requires binutils 2.35.2+ > - clang + integrated as -> OK > > Signed-off-by: Masahiro Yamada > Reviewed-by: Nathan Chancellor Revi

[PATCH v3] ASoC: Intel: Skylake: skl-topology: fix -frame-larger-than

Shevchenko Signed-off-by: Nick Desaulniers --- Changes V2 -> V3: * change to kmalloc+memset to fix logic error, as per Andy. Changes V1 -> V2: * rebased on mainline. sound/soc/intel/skylake/skl-topology.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/sou

[PATCH v2] ASoC: Intel: Skylake: skl-topology: fix -frame-larger-than

Fixes: sound/soc/intel/skylake/skl-topology.c:3613:13: warning: stack frame size of 1304 bytes in function 'skl_tplg_complete' [-Wframe-larger-than=] struct snd_ctl_elem_value is 1224 bytes in my configuration. Heap allocate it, then free it within the current frame. Signed-off-by: Nick

[PATCH] ASoC: Intel: Skylake: skl-topology: fix -frame-larger-than

Fixes: sound/soc/intel/skylake/skl-topology.c:3613:13: warning: stack frame size of 1304 bytes in function 'skl_tplg_complete' [-Wframe-larger-than=] struct snd_ctl_elem_value is 1224 bytes in my configuration. Heap allocate it, then free it within the current frame. Signed-off-by: Nick

[PATCH v2 2/2] gcov: clang: drop support for clang-10 and older

/rGcdd683b516d147925212724b09ec6fb792a40041 Link: https://reviews.llvm.org/rG13a633b438b6500ecad9e4f936ebadf3411d0f44 Suggested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- For an easier time reviewing this series, reviewers may want to apply these patches, then check the overall diff with `git diff origin

[PATCH v2 1/2] gcov: fix clang-11+ support

Chancellor Reviewed-by: Fangrui Song Signed-off-by: Nick Desaulniers Tested-by: Nathan Chancellor --- Changes V1 -> V2: * Use CONFIG_CLANG_VERSION instead of __clang_major__. * Pick up and retain Suggested-by, Tested-by, and Reviewed-by tags. * Drop note from commit message about `git blame`

[PATCH v2 0/2] gcov fixes for clang-11

/rG13a633b438b6500ecad9e4f936ebadf3411d0f44 Nick Desaulniers (2): gcov: fix clang-11+ support gcov: clang: drop support for clang-10 and older kernel/gcov/Kconfig | 1 + kernel/gcov/clang.c | 32 2 files changed, 9 insertions(+), 24 deletions(-) base-commit

Re: [PATCH] gcov: fix clang-11+ support

ionally produce it? We might be able to reuse more code in the kernel between the two impelementations, though I expect the symbols the runtime is expected to provide will still differ. Seeing the `B` in `B02*` is also curious. Thanks for the review, will include your tag in v2. -- Thanks, ~Nick Desaulniers

Re: [PATCH] gcov: fix clang-11+ support

On Fri, Mar 12, 2021 at 12:51 PM Nathan Chancellor wrote: > > On Fri, Mar 12, 2021 at 12:14:42PM -0800, Nick Desaulniers wrote: > > On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor > > wrote: > > > > > > On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Des

Re: [PATCH] Makefile: LTO: have linker check -Wframe-larger-than

On Fri, Mar 12, 2021 at 9:55 AM Nick Desaulniers wrote: > > On Thu, Mar 11, 2021 at 5:09 PM Nick Desaulniers > wrote: > > > > -Wframe-larger-than= requires stack frame information, which the > > frontend cannot provide. This diagnostic is emitted late during > >

Re: [PATCH] gcov: fix clang-11+ support

On Fri, Mar 12, 2021 at 12:14 PM Nick Desaulniers wrote: > > On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor wrote: > > > > On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Desaulniers wrote: > > > LLVM changed the expected function signatur

Re: [PATCH] gcov: fix clang-11+ support

On Fri, Mar 12, 2021 at 11:58 AM Nathan Chancellor wrote: > > On Fri, Mar 12, 2021 at 11:21:39AM -0800, Nick Desaulniers wrote: > > LLVM changed the expected function signatures for llvm_gcda_start_file() > > and llvm_gcda_emit_function() in the clang-11 release. Users of cla

Re: [PATCH] kbuild: fix ld-version.sh to not be affected by locale

user's environment. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=212105 > Reported-by: Marco Scardovi > Signed-off-by: Masahiro Yamada Recensito-Da: Nick Desaulniers In realtà non parlo italiano, ma so come usare Google Translate. > --- > > scripts/ld-version.sh | 2

[PATCH] gcov: fix clang-11+ support

/rGcdd683b516d147925212724b09ec6fb792a40041 Link: https://reviews.llvm.org/rG13a633b438b6500ecad9e4f936ebadf3411d0f44 Cc: Fangrui Song Reported-by: Prasad Sodagudi Signed-off-by: Nick Desaulniers --- kernel/gcov/clang.c | 69 + 1 file changed, 69 insertions(+) diff --git a/kernel/gcov

Re: [PATCH] Makefile: LTO: have linker check -Wframe-larger-than

On Thu, Mar 11, 2021 at 5:09 PM Nick Desaulniers wrote: > > -Wframe-larger-than= requires stack frame information, which the > frontend cannot provide. This diagnostic is emitted late during > compilation once stack frame size is available. > > When building with LTO, the fronte

[PATCH] Makefile: LTO: have linker check -Wframe-larger-than

or revert this based on the minimum support version of Clang. The error message is not generated during link: LTO vmlinux.o ld.lld: warning: stack size limit exceeded (8224) in foobarbaz Cc: Sami Tolvanen Reported-by: Candle Sun Suggested-by: Fangrui Song Signed-off-by: Nick Desaulniers

Re: [PATCH] ARM: Make UNWINDER_ARM depend on ld.bfd or ld.lld 11.0.0+

om/ClangBuiltLinux/linux/issues/732 > Link: > https://github.com/llvm/llvm-project/commit/48aebfc908ba7b9372aaa478a9c200789491096e > Suggested-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Thanks for the patch. We discussed at the kernelCI meeting yesterday and the clangb

Re: [PATCH] [RFC] arm64: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION

prevents the function > from being garbage-collected unless that other option is removed > as well? I wish the linker had a debug flag that could let developers discover the decisions it made during --gc-sections as to why certain symbols were retained/kept or not. -- Thanks, ~Nick Desaulniers

Re: [RFC PATCH v2 00/13] objtool: add base support for arm64

On Fri, Mar 5, 2021 at 3:51 PM Nick Desaulniers wrote: > > (in response to > https://lore.kernel.org/linux-arm-kernel/20210303170932.1838634-1-jthie...@redhat.com/ > from the command line) > > > Changes since v1[2]: > > - Drop gcc plugin in favor of -fno-jump-tables

Re: [RFC PATCH v2 00/13] objtool: add base support for arm64

config with LLVM=1 with this series applied. Tested-by: Nick Desaulniers One thing I noticed was a spew of warnings for allmodconfig, like: init/main.o: warning: objtool: asan.module_ctor()+0xc: call without frame pointer save/setup init/main.o: warning: objtool: asan.module_dtor()+0xc: call w

Re: [PATCH 3/4] kbuild: check the minimum assembler version in Kconfig

; +# Split the line on spaces. > +IFS=' ' > +set -- $line > + > +tool_version=$(dirname $0)/tool-version.sh > + > +if [ "$1" = GNU -a "$2" = assembler ]; then > + shift $(($# - 1)) > + version=$1 > + min_version=$($tool_version binutils) > + name=GNU > +else > + echo "$orig_args: unknown assembler invoked" >&2 > + exit 1 > +fi > + > +# Some distributions append a package release number, as in 2.34-4.fc32 > +# Trim the hyphen and any characters that follow. > +version=${version%-*} > + > +cversion=$(get_canonical_version $version) > +min_cversion=$(get_canonical_version $min_version) > + > +if [ "$cversion" -lt "$min_cversion" ]; then > + echo >&2 "***" > + echo >&2 "*** Assembler is too old." > + echo >&2 "*** Your $name assembler version:$version" > + echo >&2 "*** Minimum $name assembler version: $min_version" > + echo >&2 "***" > + exit 1 > +fi > + > +echo $name $cversion > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

n gcc-10, third try") > > Perhaps we can ask the toolchain folks to help add such an attribute. Or > maybe the feature already exists somewhere, but hidden. > > +Cc linux-toolcha...@vger.kernel.org > > > > But I'm also not sure if with all that we'd be guaranteed the code we > > > want, even though in practice it might. > > > > True! I'd just like to be on the least dodgy ground we can be. > > It's been dodgy for a while, and I'd welcome any low-cost fixes to make > it less dodgy in the short-term at least. :-) > > Thanks, > -- Marco -- Thanks, ~Nick Desaulniers

Re: [PATCH v3] MIPS: Make MIPS32_O32 depends on !CC_IS_CLANG

ue to lack of > resources". It's my hope we will fix the resourcing issue. I'm working on that; it's a non-technical challenge though. Acked-by: Nick Desaulniers > > It is not a good idea to remove CONFIG_MIPS32_O32=y directly > in defconfig because GCC works, as Nathan said, the conf

Re: [PATCH v2] sched: Optimize __calc_delta.

983 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -36,6 +36,7 @@ > #include > > #include > +#include This hunk of the patch is curious. I assume that bitops.h is needed for fls(); if so, why not #include it in kernel/sched/fair.c? Otherwise this potentially hurts compile time for all TUs that include kernel/sched/sched.h. > #include > #include > #include > -- > 2.30.1.766.gb4fecdf3b7-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH 1/4] kbuild: remove LLVM=1 test from HAS_LTO_CLANG

$(success,test $(LLVM) -eq 1) IIRC, we needed some other LLVM utilities like llvm-nm and llvm-ar, which are checked below. So I guess we can still support CC=clang AR=llvm-ar NM=llvm-nm, and this check is redundant. > depends on $(success,test $(LLVM_IAS) -eq 1) > depends on $(success,$(NM) --help | head -n 1 | grep -qi llvm) > depends on $(success,$(AR) --help | head -n 1 | grep -qi llvm) > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH 4/4] kbuild: dwarf: use AS_VERSION instead of test_dwarf5_support.sh

0x00`. Should be fixed in GNU binutils > -# 2.35.2. https://sourceware.org/bugzilla/show_bug.cgi?id=25611 > -echo '.file 0 "filename" md5 0x7a0b65214090b6693bd1dc24dd248245' | \ > - $* -gdwarf-5 -Wno-unused-command-line-argument -c -x assembler -o > /dev/null - > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as

On Tue, Mar 2, 2021 at 2:09 PM Nick Desaulniers wrote: > > On Tue, Mar 2, 2021 at 2:02 PM Fangrui Song wrote: > > > > On 2021-03-02, Nathan Chancellor wrote: > > >When building with LLVM_IAS=1, there is no point to specifying > > >'--prefix=' because that

Re: [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag

ibution version of LLVM 11.1.0 without binutils in the LLVM > toolchain locations. > > Signed-off-by: Nathan Chancellor Thanks for the patch! Reviewed-by: Nick Desaulniers Tested-by: Nick Desaulniers I see this pattern still being used in arch/arm64/kernel/vdso32/Makefile, but that

Re: [PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as

, don't set --prefix), with either of the two above configs, which objcopy get's exec'd? > > With LLVM_IAS=1, these cases are ruled out. -- Thanks, ~Nick Desaulniers

Re: hppa64-linux-ld: kernel/sched/core.o(.init.text+0x90): cannot reach printk

+ Arnd On Tue, Mar 2, 2021 at 10:03 AM Helge Deller wrote: > > On 3/2/21 6:29 PM, Nick Desaulniers wrote: > > + pa-risc folks > > Thanks for looking into this, Nick! > > > On Tue, Mar 2, 2021 at 2:59 AM kernel test robot wrote: > >> > >> tree: ht

Re: hppa64-linux-ld: kernel/sched/core.o(.init.text+0x90): cannot reach printk

tk >hppa64-linux-ld: certs/system_keyring.o(.init.text+0x20): cannot reach > printk >hppa64-linux-ld: certs/system_keyring.o(.init.text+0x8c): cannot reach > panic >hppa64-linux-ld: certs/system_keyring.o(.init.text+0x118): cannot reach > printk >hppa64-linux-ld: certs/system_keyring.o(.init.text+0x1d4): cannot reach > printk >hppa64-linux-ld: certs/system_keyring.o(.init.text+0x1f8): cannot reach > printk >hppa64-linux-ld: certs/system_keyring.o(.init.text+0x238): cannot reach > printk >hppa64-linux-ld: mm/workingset.o(.init.text+0xfc): cannot reach printk >hppa64-linux-ld: fs/filesystems.o(.init.text+0xb0): cannot reach > _raw_read_lock >hppa64-linux-ld: fs/filesystems.o(.init.text+0x130): cannot reach > _raw_read_unlock >hppa64-linux-ld: fs/block_dev.o(.init.text+0xf0): cannot reach panic >hppa64-linux-ld: fs/aio.o(.init.text+0x50): cannot reach panic >hppa64-linux-ld: fs/ext4/super.o(.init.text+0x1e4): cannot reach printk >hppa64-linux-ld: fs/ext4/super.o(.init.text+0x220): cannot reach printk >hppa64-linux-ld: fs/jbd2/journal.o(.init.text+0x164): cannot reach printk >hppa64-linux-ld: fs/jbd2/journal.o(.init.text+0x1a4): cannot reach unknown >hppa64-linux-ld: fs/xfs/xfs_super.o(.init.text+0x6ec): cannot reach printk >hppa64-linux-ld: fs/xfs/xfs_super.o(.init.text+0x8ac): cannot reach > wait_for_completion >hppa64-linux-ld: fs/xfs/xfs_super.o(.init.text+0x934): cannot reach unknown >hppa64-linux-ld: fs/xfs/xfs_super.o(.init.text+0x944): cannot reach unknown >hppa64-linux-ld: security/keys/proc.o(.init.text+0x94): cannot reach panic >hppa64-linux-ld: crypto/jitterentropy-kcapi.o(.init.text+0x38): cannot > reach printk >hppa64-linux-ld: block/bsg.o(.init.text+0x150): cannot reach printk >hppa64-linux-ld: lib/sg_pool.o(.init.text+0xa4): cannot reach printk >hppa64-linux-ld: drivers/phy/phy-core.o(.init.text+0x64): cannot reach > printk >hppa64-linux-ld: drivers/gpio/gpio-mockup.o(.init.text+0x2f4): cannot > reach unknown >hppa64-linux-ld: drivers/char/ipmi/ipmi_msghandler.o(.init.text+0x4c): > cannot reach mutex_lock > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org -- Thanks, ~Nick Desaulniers

Re: [PATCH] [v2] spi: rockchip: avoid objtool warning

Signed-off-by: Arnd Bergmann Thanks for the v2! Reviewed-by: Nick Desaulniers > --- > v2: use 'return' instead of 'BUG()' > --- > drivers/spi/spi-rockchip.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-ro

Re: [PATCH] ARM: ep93xx: don't use clang IAS for crunch

r way, please consider adding a Link: https://github.com/ClangBuiltLinux/linux/issues/1272 tag. That will help us notice when/where this lands in order to close out the issue. Thanks for the patch. (if we go with this rather than removing the driver:) Acked-by: Nick Desaulniers (I'm also fine with removing the driver; my ack is not conditional on one way or the other). -- Thanks, ~Nick Desaulniers

Re: [PATCH] x86: mark some mpspec inline functions as __init

On Thu, Feb 25, 2021 at 1:33 PM Borislav Petkov wrote: > > On Thu, Feb 25, 2021 at 12:31:33PM -0800, Nick Desaulniers wrote: > > (full thread: > > https://lore.kernel.org/lkml/20210225112247.2240389-1-a...@kernel.org/) > > I suspect in this specific case, "Inter

Re: [PATCH 2/2] mt76: mt7921: remove incorrect error handling

lize the > variable 'stats' to silence this warning > struct mt7921_sta_stats *stats; > ^ > Just remove the obviously incorrect line. Yeah, looks like perhaps a small mistake from when the driver was introduced. Thanks for the patch! Reviewed-by

Re: [PATCH] drm/amd/display: Fix an uninitialized index variable

return valid_vsdb_found; > + > + return valid_vsdb_found ? i : -ENODEV; Thanks for the patch! I don't think we need a local variable to store the return value from one function call that's immediately returned, ie. return parse_edid_cea(aconnector, edid_ext, EDID_LENGT

Re: [PATCH] coresight: etm4x: work around clang-12+ build failure

here are dozens of places in the coresight drivers where such patterns > are > used. Why are those not flagged as well? And shouldn't the real fix be with > clang? It's important to understand the __builtin_constant_p is highly sensitive to optimizations; code using it typically relies on optimizations being performed before it's evaluated. Which optimizations, applied successfully or not, in what order, by which compiler or versions of the same compiler can affect what __builtin_constant_p evaluates to. Code generally needs to be written to assume that failure for __builtin_constant_p to evaluate to a specific value or not is _not a bug_. > > Thanks, > Mathieu > > > config->cntr_val[i] = > > etm4x_relaxed_read32(csa, TRCCNTVRn(i)); > > } > > -- > > 2.29.2 > > -- Thanks, ~Nick Desaulniers

Re: [PATCH] spi: rockchip: avoid objtool warning

bling call from callable instruction > with modified stack frame > > Use BUG() instead of unreachable() to avoid the undefined behavior > if it does happen. Thanks for the patch! Reviewed-by: Nick Desaulniers > > Fixes: 65498c6ae241 ("spi: rockchip: support 4bit words&quo

Re: [kbuild-all] Re: WARNING: modpost: vmlinux.o(.text+0x1a8edb8): Section mismatch in reference from the function stop_machine() to the function .init.text:intel_rng_hw_init()

; > Rong Chen > > Hi Rong, > > Known issue. LLVM 13 cut over to the new pass manager (NPM) which has > changed some of the inlining heuristics. I would probably recommend > cutting over to the "release/12.x" branch for now, which should be more ehh...we still want coverage of ToT LLVM though, to spot potential issues like this. I'd take both (clang-12 and 13) if possible; both are pre-release and still undergoing active development. > up to date but also stable. > > Additionally, Arnd sent a fix for this particular warning here: > https://lore.kernel.org/lkml/20210225130153.1956990-1-a...@kernel.org/ Looks like it got picked up by akpm@ in -mm? > > Cheers, > Nathan -- Thanks, ~Nick Desaulniers

Re: [PATCH] linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*

r-*.h > > > mutually exclusive") > > > Signed-off-by: Arnd Bergmann > > > > Cc: sta...@vger.kernel.org > > I figured 4% better compile time isn't significant enough to justify a > backport. Thoughts? If I made a mistake in 815f0ddb346c, then it woul

Re: [PATCH] x86: mark some mpspec inline functions as __init

llee (so they are distinct functions now), inlines those into get_smp_config()/early_get_smp_config(), then there's too many callers of those in a single TU where inlining would cause excessive code bloat. Either way, it's a deep topic and I'm always happy to learn more about it to help answer

Re: [PATCH -next] fbdev: atyfb: always declare aty_{ld,st}_lcd()

xtern either (since that's the implicit default), but I don't feel strongly about it. Thanks for sending a cleanup for this. Acked-by: Nick Desaulniers > > Fixes: bfa5782b9caa ("fbdev: atyfb: add stubs for aty_{ld,st}_lcd()") > Signed-off-by: Randy Dunlap > Reported-by:

Re: [PATCH] Makefile: reuse CC_VERSION_TEXT

On Fri, Feb 5, 2021 at 5:49 PM Masahiro Yamada wrote: > > On Sat, Feb 6, 2021 at 7:01 AM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > I noticed we're invoking $(CC) via $(shell) more than once to check the > > version. Let's reuse the first string c

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

o unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20210211194258.4137998-1-nathan%40kernel.org. -- Thanks, ~Nick Desaulniers

Re: gfp.h:20:32: error: redefinition of typedef 'gfp_t' is a C11 feature

your system. > # > # To install tuxmake on your system globally: > # sudo pip3 install -U tuxmake > # > # See https://docs.tuxmake.org/ for complete documentation. > > tuxmake --runtime podman --target-arch arm --toolchain clang-10 > --kconfig davinci_all_defconfig > > build log, > https://builds.tuxbuild.com/1opbM56yvX4uyeXV8JBwFNz9WEQ/ > > -- > Linaro LKFT > https://lkft.linaro.org -- Thanks, ~Nick Desaulniers

Re: [PATCH v3] perf probe: fix kretprobe issue caused by GCC bug

add kretprobe event with debuginfo of vmlinux which > is > +* compiled by gcc with -fpatchable-function-entry option enabled. The > +* same issue with kernel module. The retprobe doesn`t need debuginfo. > + * This workaround solution use map to query the probe function > address > +* for retprobe event. > +*/ > + if (pev->point.retprobe) > + return 0; > + > dinfo = open_debuginfo(pev->target, pev->nsi, !need_dwarf); > if (!dinfo) { > if (need_dwarf) > -- > 2.25.1 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2] ARM: Implement Clang's SLS mitigation

ARDEN_SLS_ALL via menuconfig, but I wonder if the default value is funny because the cc-option check is failing? > +help > + Enables straight-line speculation vulnerability hardening > + at highest level. > + > config GCC_PLUGIN_STRUCTLEAK_VERBOSE > bool "Report forcefully initialized variables" > depends on GCC_PLUGIN_STRUCTLEAK > -- -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 1/2] x86/stackprotector/32: Make the canary into a regular percpu variable

or and updates GSBASE, which is now > always the user base. This means that the overall effect is > the same on 32-bit and 64-bit, which avoids some ifdeffery. > > Cc: Sedat Dilek > Cc: Nick Desaulniers > Signed-off-by: Andy Lutomirski > --- > arch/x86/Kconfig

Re: [PATCH v2 0/2] Clean up x86_32 stackprotector

has-stack-protector.sh | 6 +- > 20 files changed, 62 insertions(+), 265 deletions(-) > > -- > 2.29.2 > -- Thanks, ~Nick Desaulniers

Re: [PATCH] RTIC: selinux: ARM64: Move selinux_state to a separate page

ge to enhance > protection. > > Signed-off-by: Preeti Nagar This addresses my feedback from the RFC regarding the section symbols. No comment on whether there is a better approach, or the 2MB vs page alignment, but perhaps other folks cc'ed can please take a look. Acked-by: Nick Desaulniers

Re: [PATCH mips-next] vmlinux.lds.h: catch more UBSAN symbols into .data

..L* > .data..compoundliteral* .data.$__unnamed_* .data.$Lubsan_* Are these sections only created when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is selected? (Same with .data.$__unnamed_*) > #define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]* > #define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]* .rodata..L* > #define BSS_MAIN .bss .bss.[0-9a-zA-Z_]* .bss..compoundliteral* > -- > 2.30.1 > > -- Thanks, ~Nick Desaulniers

Re: [PATCH 2/2] kbuild: check the minimum linker version in Kconfig

g] Error 1 > make[1]: *** [Makefile:600: syncconfig] Error 2 > make: *** [Makefile:708: include/config/auto.conf] Error 2 > > Thanks to David Laight for suggesting shell script improvements. > > Signed-off-by: Masahiro Yamada Acked-by: Nick Desaulniers > --- &g

Re: [PATCH v5 1/2] ARM: kprobes: fix UNPREDICTABLE warnings

On Thu, Feb 11, 2021 at 12:15 AM Ard Biesheuvel wrote: > > On Thu, 11 Feb 2021 at 03:52, Nick Desaulniers > wrote: > > > > GNU as warns twice for this file: > > Warning: using r15 results in unpredictable behaviour > > > > via the Arm ARM: > >

Re: [tip: objtool/urgent] objtool: Fix seg fault with Clang non-section symbols

e.kernel.org/stable/yclejcqfsdisr...@kroah.com/ (Maybe it was reported on a different list; I only searched stable ML). -- Thanks, ~Nick Desaulniers

Re: [RFC][PATCH v2 0/7] objtool x86 decoder fixes

s/issues observed during a build. Tested-by: Nick Desaulniers > > v2: > - actually Cc'ed LKML :/ > -- Thanks, ~Nick Desaulniers

[PATCH v5 1/2] ARM: kprobes: fix UNPREDICTABLE warnings

. Link: https://github.com/ClangBuiltLinux/linux/issues/1271 Link: https://reviews.llvm.org/D95586 Reported-by: kernelci.org bot Suggested-by: Peter Smith Suggested-by: Renato Golin Suggested-by: David Spickett Signed-off-by: Nick Desaulniers --- arch/arm/probes/kprobes/test-arm.c | 4 ++-- 1 file

[PATCH v5 2/2] ARM: kprobes: rewrite test-arm.c in UAL

ux/linux/issues/1271 Reported-by: Arnd Bergmann Signed-off-by: Nick Desaulniers --- arch/arm/probes/kprobes/test-arm.c | 290 ++-- arch/arm/probes/kprobes/test-core.h | 1 + 2 files changed, 146 insertions(+), 145 deletions(-) diff --git a/arch/arm/probes/kprobes/test-arm.

[PATCH v5 0/2] ARM: kprobes: asm warning fixes and UAL conversion

B2_KERNEL. LLVM requires more fixes for .w suffixes for thumb2 mode. Changes V1 -> V2: * Fix additonal swpvsb case in test-arm.c when __LINUX_ARM_ARCH__ < 6, reported by Arnd. * Fix arch/arm/probes/kprobes/test-thumb.c, reported by Arnd. * Modify the oneline to note I'm modifying test-*.c. N

Re: [PATCH v2] arm64: Make CPU_BIG_ENDIAN depend on ld.bfd or ld.lld 13.0.0+

n > Signed-off-by: Nathan Chancellor LGTM, thanks for implementing BE support for aarch64 in LLD, Fangrui! (And Nathan for the kernel patch+testing) Reviewed-by: Nick Desaulniers > --- > > v1 -> v2: > > * Conditionally disable CONFIG_CPU_BIG_ENDIAN for older versions of > l

Re: [PATCH v9 1/3] vmlinux.lds.h: add DWARF v5 sections

On Fri, Feb 5, 2021 at 4:00 PM Andrew Morton wrote: > > On Fri, 5 Feb 2021 12:22:18 -0800 Nick Desaulniers > wrote: > > > We expect toolchains to produce these new debug info sections as part of > > DWARF v5. Add explicit placements to prevent the linker warnings from &

[PATCH v4] ARM: kprobes: rewrite test-arm.c in UAL

BuiltLinux/linux/issues/1271 Link: https://reviews.llvm.org/D95586 Suggested-by: Peter Smith Suggested-by: Renato Golin Suggested-by: David Spickett Reported-by: Arnd Bergmann Signed-off-by: Nick Desaulniers --- arch/arm/probes/kprobes/test-arm.c | 292 ++--- 1 file ch

[PATCH] Makefile: reuse CC_VERSION_TEXT

I noticed we're invoking $(CC) via $(shell) more than once to check the version. Let's reuse the first string captured in $CC_VERSION_TEXT. Fixes: 315bab4e972d ("kbuild: fix endless syncconfig in case arch Makefile sets CROSS_COMPILE") Signed-off-by: Nick Desaulniers --- Mak

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

On Fri, Feb 5, 2021 at 1:17 PM Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 10:10 PM Nick Desaulniers > wrote: > > > > > Hi, > > > > > > when building with pahole v1.20 and binutils v2.35.2 plus Clang > > > v12.0.0-rc1 and DWARF-v5 I

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

On Fri, Feb 5, 2021 at 4:49 AM Mark Wielaard wrote: > > Hi Nick, > > On Thu, 2021-02-04 at 14:06 -0800, Nick Desaulniers wrote: > > On Thu, Feb 4, 2021 at 12:28 PM Mark Wielaard wrote: > > > I believe so yes, we did a mass-rebuild of all of Fedora a few weeks > >

Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type

> Hi, > > when building with pahole v1.20 and binutils v2.35.2 plus Clang > v12.0.0-rc1 and DWARF-v5 I see: > ... > + info BTF .btf.vmlinux.bin.o > + [ != silent_ ] > + printf %-7s %s\n BTF .btf.vmlinux.bin.o > BTF .btf.vmlinux.bin.o > + LLVM_OBJCOPY=/opt/binutils/bin/objcopy

[PATCH v9 2/3] Kbuild: make DWARF version a choice

-by: Masahiro Yamada Suggested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Makefile | 5 +++-- lib/Kconfig.debug | 30 +- 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 28019532e55a..a7eee28dd091

[PATCH v9 3/3] Kconfig: allow explicit opt in to DWARF v5

ada Suggested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Makefile | 1 + lib/Kconfig.debug | 18 ++ scripts/test_dwarf5_support.sh | 8 3 files changed, 27 insertions(+) create mode 100755 scripts/test_dwarf5_support.sh d

[PATCH v9 1/3] vmlinux.lds.h: add DWARF v5 sections

=1922707 Reported-by: Chris Murphy Suggested-by: Fangrui Song Reviewed-by: Nathan Chancellor Tested-by: Sedat Dilek Signed-off-by: Nick Desaulniers --- include/asm-generic/vmlinux.lds.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/asm-generic/vmlinux.lds.h

[PATCH v9 0/3] Kbuild: DWARF v5 support

ro. * remove -u from test_dwarf5_support.sh as per Masahiro. * add a -gdwarf-5 cc-option check to Kconfig as per Jakub. Nick Desaulniers (3): vmlinux.lds.h: add DWARF v5 sections Kbuild: make DWARF version a choice Kconfig: allow explicit opt in to DWARF v5 Makefile | 6 ++--

Re: [PATCH] x86/efi: Remove EFI PGD build time checks

t. > > See https://github.com/ClangBuiltLinux/linux/issues/256 for more info. > > Reported-by: Arnd Bergmann > Link: http://lkml.kernel.org/r/20210107223424.4135538-1-a...@kernel.org > Signed-off-by: Borislav Petkov Thanks, this fixes the failed assertion for me. Tested-by: N

Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent

ert_414 > >>> referenced by mremap.c > >>> mremap.o:(get_extent) in archive mm/built-in.a > > Mark the function as __always_inline to avoid it. > > Fixes: 9ad9718bfa41 ("mm/mremap: calculate extent in one place") > Signed-off-by: Arnd Ber

Re: [PATCH] x86: efi: avoid BUILD_BUG_ON() for non-constant p4d_index

handle_alignment_assumption' > ld: mm/vmalloc.o:/home/boris/kernel/linux/mm/vmalloc.c:1213: more undefined > references to `__ubsan_handle_alignment_assumption' follow > make: *** [Makefile:1164: vmlinux] Error 1 > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette -- Thanks, ~Nick Desaulniers

Re: [PATCH v5 0/3] Kbuild: DWARF v5 support

Moving a bunch of folks + lists to BCC. On Thu, Feb 4, 2021 at 3:54 PM Andrii Nakryiko wrote: > > On Wed, Feb 3, 2021 at 7:13 PM Nick Desaulniers > wrote: > > > > On Wed, Feb 3, 2021 at 6:58 PM Andrii Nakryiko > > wrote: > > > > > > On

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

On Thu, Feb 4, 2021 at 12:28 PM Mark Wielaard wrote: > > On Thu, 2021-02-04 at 12:04 -0800, Nick Desaulniers wrote: > > On Thu, Feb 4, 2021 at 11:56 AM Mark Wielaard wrote: > > > I agree with Jakub. Now that GCC has defaulted to DWARF5 all the > > > tools > &g

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

On Thu, Feb 4, 2021 at 11:56 AM Mark Wielaard wrote: > > On Thu, 2021-02-04 at 11:18 -0800, Nick Desaulniers wrote: > > On Thu, Feb 4, 2021 at 2:41 AM Mark Wielaard wrote: > > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > > >

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

On Thu, Feb 4, 2021 at 2:41 AM Mark Wielaard wrote: > > Hi Nick, > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > the default. Does so in a way that's forward compatible w

Re: next/master bisection: baseline.login on rk3288-rock2-square

On Thu, Feb 4, 2021 at 10:12 AM Nathan Chancellor wrote: > > On Thu, Feb 04, 2021 at 10:06:08AM -0800, 'Nick Desaulniers' via Clang Built > Linux wrote: > > On Thu, Feb 4, 2021 at 8:02 AM Ard Biesheuvel wrote: > > > > > > On Thu, 4 Feb 2021 at 16:

Re: [PATCH] ARM: s3c: fix fiq for clang IAS

here are apparently two problems: one with extraneous or duplicate > labels, and one with old-style opcode mnemonics. Stefan Agner has > previously fixed other problems like this, but missed this particular > file. Thanks for the patch. Pre-UAL syntax Reviewed-by: Nick Desaulniers >

Re: next/master bisection: baseline.login on rk3288-rock2-square

is in asm code. Is it > possible to build with Clang but use the GNU linker? rk3288 might be the last 32b ARM platform ChromeOS uses. "veyron" -- Thanks, ~Nick Desaulniers

Re: [PATCH v8 0/2] Kbuild: DWARF v5 support

It can be difficult to know what's broken if you apply too many out of tree patches though. -- Thanks, ~Nick Desaulniers

[PATCH v8 2/2] Kbuild: implement support for DWARF v5

iro Yamada Suggested-by: Nathan Chancellor Reviewed-by: Nathan Chancellor Signed-off-by: Nick Desaulniers --- Makefile | 1 + include/asm-generic/vmlinux.lds.h | 7 ++- lib/Kconfig.debug | 18 ++ scripts/test_dwarf5_support.sh|

[PATCH v8 1/2] Kbuild: make DWARF version a choice

Chancellor Suggested-by: Arvind Sankar Suggested-by: Fangrui Song Suggested-by: Nathan Chancellor Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- Makefile | 5 ++--- lib/Kconfig.debug | 16 +++- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git

[PATCH v8 0/2] Kbuild: DWARF v5 support

r Masahiro. * add a -gdwarf-5 cc-option check to Kconfig as per Jakub. Nick Desaulniers (2): Kbuild: make DWARF version a choice Kbuild: implement support for DWARF v5 Makefile | 6 +++--- include/asm-generic/vmlinux.lds.h | 7 +- lib/Kconfig.debug

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

On Wed, Feb 3, 2021 at 4:30 PM Masahiro Yamada wrote: > > On Thu, Feb 4, 2021 at 8:16 AM Nick Desaulniers > wrote: > > > > On Wed, Feb 3, 2021 at 2:24 PM Masahiro Yamada wrote: > > > > > > On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor > >

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

On Fri, Jan 29, 2021 at 5:52 PM Nathan Chancellor wrote: > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > the default. Does so in a way that's forward compatible with existing >

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

On Wed, Feb 3, 2021 at 7:32 PM Fangrui Song wrote: > > On 2021-02-04, Masahiro Yamada wrote: > >On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor wrote: > >> > >> On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > >> > Modifi

<    1   2   3   4   5   6   7   8   9   10   >