This function returns a string with the currently in-use implementation
of the crc32c algorithm, i.e crc32c-generic (for unoptimised, generic
implementation) or crc32c-intel for the sse optimised version. This
will be used by btrfs.
Signed-off-by: Nikolay Borisov
---
include/linux/crc32c.h | 1
On 4.01.2018 02:47, Tim Mouraveiko wrote:
> Hi,
>
> In all my years of extensive experience writing drivers and kernels, I never
> came across a situation
> where you could brick an x86 CPU. Not until recently, when I was working on
> debugging a piece of
> code and I bricked an Intel CPU.
On 16/12/17 12:40, Nikolay Aleksandrov wrote:
> On 16/12/17 11:29, Nikolay Aleksandrov wrote:
>> On 16/12/17 11:17, Nikolay Aleksandrov wrote:
>>> On 16/12/17 02:37, Andrei Vagin wrote:
>>>> Hi,
>>>>
>>>> We run criu tests for linux-next and
On 16/12/17 11:29, Nikolay Aleksandrov wrote:
> On 16/12/17 11:17, Nikolay Aleksandrov wrote:
>> On 16/12/17 02:37, Andrei Vagin wrote:
>>> Hi,
>>>
>>> We run criu tests for linux-next and today we get this bug:
>>>
>>> The kernel version
On 16/12/17 11:17, Nikolay Aleksandrov wrote:
> On 16/12/17 02:37, Andrei Vagin wrote:
>> Hi,
>>
>> We run criu tests for linux-next and today we get this bug:
>>
>> The kernel version is 4.15.0-rc3-next-20171215
>>
>> [ 235.397328] BUG: unable to
On 16/12/17 02:37, Andrei Vagin wrote:
> Hi,
>
> We run criu tests for linux-next and today we get this bug:
>
> The kernel version is 4.15.0-rc3-next-20171215
>
> [ 235.397328] BUG: unable to handle kernel NULL pointer dereference
> at 000c
> [ 235.398624] IP: fdb_find_rcu+0x3c/0x
On 11.12.2017 18:00, Scott Bauer wrote:
> Signed-off-by: Scott Bauer
> ---
> Documentation/device-mapper/dm-unstripe.txt | 82
> +
> 1 file changed, 82 insertions(+)
> create mode 100644 Documentation/device-mapper/dm-unstripe.txt
>
> diff --git a/Documentation/de
On 9.12.2017 21:25, Tejun Heo wrote:
> After the recent updates to use generation number and state based
> synchronization, we can easily replace REQ_ATOM_STARTED usages by
> adding an extra state to distinguish completed but not yet freed
> state.
>
> Add MQ_RQ_COMPLETE and replace REQ_ATOM_ST
On 12.12.2017 09:21, Yaowei Bai wrote:
> On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote:
>> On Mon, 11 Dec 2017, Yaowei Bai wrote:
>>
>>> This patchset makes some *_is_* like functions return bool because
>>> these functions only use true or false as their return values.
>>>
>>> N
On 9.11.2017 15:08, Matthew Wilcox wrote:
> On Thu, Nov 09, 2017 at 01:41:24PM +0200, Nikolay Borisov wrote:
>> On 9.11.2017 05:22, NeilBrown wrote:
>>> @@ -493,12 +496,18 @@ void __d_drop(struct dentry *dentry)
>>> } else
>>>
On 9.11.2017 05:22, NeilBrown wrote:
> d_move() will call __d_drop() and then __d_rehash()
> on the dentry being moved. This creates a small window
> when the dentry appears to be unhashed. Many tests
> of d_unhashed() are made under ->d_lock and so are safe
> from racing with this window, but
[CCing some memory-barriers people + checkpatch maintainers]
On 1.11.2017 13:08, Eric W. Biederman wrote:
> Nikolay Borisov writes:
>
>> On 1.11.2017 01:48, Eric W. Biederman wrote:
>>>
>>> This is important so reading /proc//{uid_map,gid_map,projid_map} whil
On 1.11.2017 01:48, Eric W. Biederman wrote:
>
> This is important so reading /proc//{uid_map,gid_map,projid_map} while
> the map is being written does not do strange things.
>
> Signed-off-by: "Eric W. Biederman"
> ---
> kernel/user_namespace.c | 6 --
> 1 file changed, 4 insertions(+),
On 23.10.2017 09:39, Nikolay Borisov wrote:
>
>
> On 19.10.2017 22:11, Christian Brauner wrote:
>> - Add a struct containing two pointer to extents and wrap both the static
>> extent
>> array and the struct into a union. This is done in preparation for bumping
&g
On 19.10.2017 22:11, Christian Brauner wrote:
> - Add a struct containing two pointer to extents and wrap both the static
> extent
> array and the struct into a union. This is done in preparation for bumping
> the
> {g,u}idmap limits for user namespaces.
> - Add brackets around anonymous un
On 10.10.2017 13:48, Rakesh Pandit wrote:
> Commit a53f4f8e9c8eb ("btrfs: Don't call btrfs_start_transaction() on
> frozen fs to avoid deadlock.") started using internal calls and we
> replace them with more suitable ones.
>
> Signed-off-by: Rakesh Pandit
> ---
> fs/btrfs/super.c | 4 ++--
> 1
on __ versions are just wrappers around the __ specific calls. So
the code is identical.
Reviewed-by: Nikolay Borisov
o the last user of free_more_memory(), kill
> it off completely.
>
> Signed-off-by: Jens Axboe
Reviewed-by: Nikolay Borisov
> ---
> fs/buffer.c | 23 ---
> 1 file changed, 23 deletions(-)
>
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 3b60cd84
gt; Signed-off-by: Jens Axboe
Reviewed-by: Nikolay Borisov
> ---
> drivers/md/bitmap.c | 2 +-
> fs/buffer.c | 33 ++---
> fs/ntfs/aops.c | 2 +-
> fs/ntfs/mft.c | 2 +-
> include/linux/buffer_head.h
On 27.09.2017 23:13, Jens Axboe wrote:
> We currently it it for find_or_create_page(), which means that it
nit: Perhaps you wanted to write "We currently use it for find_..."
otherwise:
Reviewed-by: Nikolay Borisov
> cannot fail. Ensure we also pass in &#
On 2.08.2017 10:10, Nikolay Borisov wrote:
> We already get the block counts and the calculate the end block at the
> beginning of the function. Let's use the local variables for consistency and
> readability. No functional changes
>
> Signed-off-by: Nikolay Borisov
>
On 11 September 2017 19:07:33 EEST, "Mahesh Bandewar (महेश बंडेवार)"
wrote:
>On Sat, Sep 9, 2017 at 4:28 AM, Nikolay Aleksandrov
> wrote:
>> On 07/09/17 01:47, Kosuke Tatsukawa wrote:
>>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in
changed, 3 insertions(+), 0 deletions(-)
>
This fix is simpler and more suitable for -net, it fixes the case where
we switch to ALB mode with tlb_dynamic_lb = 0. After it is in I'll fix the
default tlb_dynamic_lb issue and restore the original behaviour.
Acked-by: Nikolay Aleksandrov
On 09/09/17 13:29, Nikolay Aleksandrov wrote:
> On 09/09/17 02:54, Mahesh Bandewar (महेश बंडेवार) wrote:
>> On Fri, Sep 8, 2017 at 7:30 AM, Nikolay Aleksandrov
>> wrote:
>>> On 08/09/17 17:17, Kosuke Tatsukawa wrote:
[snip]
>>>
>> I think the underlying iss
On 09/09/17 02:54, Mahesh Bandewar (महेश बंडेवार) wrote:
> On Fri, Sep 8, 2017 at 7:30 AM, Nikolay Aleksandrov
> wrote:
>> On 08/09/17 17:17, Kosuke Tatsukawa wrote:
>>> Hi,
>>>
>>>> On 08/09/17 13:10, Nikolay Aleksandrov wrote:
>>>>
On 08/09/17 17:17, Kosuke Tatsukawa wrote:
> Hi,
>
>> On 08/09/17 13:10, Nikolay Aleksandrov wrote:
>>> On 08/09/17 05:06, Kosuke Tatsukawa wrote:
>>>> Hi,
>>>>
>>>>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote:
>>>&
On 08/09/17 13:10, Nikolay Aleksandrov wrote:
> On 08/09/17 05:06, Kosuke Tatsukawa wrote:
>> Hi,
>>
>>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote:
>>>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in
>>>> balance-alb m
On 08/09/17 05:06, Kosuke Tatsukawa wrote:
> Hi,
>
>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote:
>>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in
>>> balance-alb mode") tried to fix transmit dynamic load balancing in
>>> balance-alb mode, which wasn't working after commit 8
On 7.09.2017 01:47, Kosuke Tatsukawa wrote:
> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in
> balance-alb mode") tried to fix transmit dynamic load balancing in
> balance-alb mode, which wasn't working after commit 8b426dc54cf4
> ("bonding: remove hardcoded value").
>
> It tu
Hello Tejun,
I've hit the following problems under memory-heavy workload conditions:
First is a BUG_ON : J_ASSERT(journal_current_handle() == handle);
[ 64.261793] kernel BUG at fs/jbd2/transaction.c:1644!
[ 64.263894] invalid opcode: [#1] SMP
[ 64.266187
On 30.08.2017 18:00, Christoph Hellwig wrote:
> Instead of playing with the addressing limits.
>
> Signed-off-by: Christoph Hellwig
> ---
Reviewed-by: Nikolay Borisov
> fs/btrfs/send.c | 18 --
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
&g
Currently there are no ->swap_{in,out} method in address_space_operations
sructure definition, so the statement that anything is going to be proxied
through them is wrong.
Signed-off-by: Nikolay Borisov
---
Documentation/filesystems/vfs.txt | 4 +---
1 file changed, 1 insertion(+), 3 deleti
On 23/08/17 14:59, Colin King wrote:
> From: Colin Ian King
>
> iph is being assigned the same value twice; remove the redundant
> first assignment. (Thanks to Nikolay Aleksandrov for pointing out
> that the first asssignment should be removed and not the second)
>
> Fixe
On 23/08/17 14:13, Colin King wrote:
> From: Colin Ian King
>
> iph is being assigned the same value twice; remove the redundant
> second assignment.
>
> Fixes warning:
> net/ipv4/ip_gre.c:265:2: warning: Value stored to 'iph' is never read
>
> Signed-off-by: Colin Ian King
> ---
> net/ipv4/i
minor nit below
On 18.07.2017 01:22, Andy Lutomirski wrote:
> We can currently blow past the stack rlimit and cause odd behavior
> if there are accounting bugs, rounding issues, or races. It's not
> clear that the odd behavior is actually a problem, but it's nicer to
> fail the exec instead of ge
On 8.08.2017 09:00, Byungchul Park wrote:
> On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote:
> + llist_for_each_entry_safe(cl, t, reverse, list) {
Just wondering why not using llist_for_each_entry(), or you use the
_safe version on purpose ?
>>>
>>> If I use llist_for_
We already get the block counts and the calculate the end block at the
beginning of the function. Let's use the local variables for consistency and
readability. No functional changes
Signed-off-by: Nikolay Borisov
---
fs/direct-io.c | 5 ++---
1 file changed, 2 insertions(+), 3 dele
On 10.07.2017 16:12, Nikolay Borisov wrote:
>
>
> On 4.07.2017 14:49, Aleksa Sarai wrote:
>> Several distributions mount the "proper root" as ro during initrd and
>> then remount it as rw before pivot_root(2). Thus, if a rescan had been
>> aborted by
On 4.07.2017 14:49, Aleksa Sarai wrote:
> Several distributions mount the "proper root" as ro during initrd and
> then remount it as rw before pivot_root(2). Thus, if a rescan had been
> aborted by a previous shutdown, the rescan would never be resumed.
>
> This issue would manifest itself as s
[CC'ing Andrew since he seems to be taking those patches through -mm ]
On 23.06.2017 18:11, Nikolay Borisov wrote:
> wb_stat_sum disables interrupts and calls __wb_stat_sum which eventually calls
> __percpu_counter_sum. However, the percpu routine is already irq-safe.
> Simplify
&g
__wb_stat_sum which was
just a wrapper over percpu_counter_sum_positive
Signed-off-by: Nikolay Borisov
---
include/linux/backing-dev.h | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index e9c967b86054
just pass in the bdi and super
block directly so we can avoid using mapping. This will allow us to still use
balance_dirty_pages for dirty metadata pages that are not backed by an
address_mapping.
Signed-off-by: Josef Bacik
Reviewed-by: Jan Kara
Acked-by: Tejun Heo
Signed-off-by: Nikolay Bo
ystem. This is also needed so things like dirty
throttling know that this is dirtyable memory as well and easily reclaimed.
This patch doesn't introduce any functional changes.
Signed-off-by: Josef Bacik
Signed-off-by: Nikolay Borisov
---
Changs since previous posting [1]:
- Forward
Hello,
This series is a report of Josef's original posting [1]. I've included
fine-grained changelog in each patch with my changes. Basically, I've forward
ported it to 4.12-rc6 and tried incorporating the feedback which was given to
every individual patch (I've included link with that informat
Reviewed-by: Tejun Heo
Signed-off-by: Nikolay Borisov
---
Changes since previous posting [1] :
- Forward ported to 4.12-rc6 kernel
I've retained the review-by tags since I didn't introduce any changes.
[1] https://patchwork.kernel.org/patch/9395213/
fs/fs-writeback.
hange the counters as well. Additionally, scale
WB_STAT_BATCH based on whether we are incrementing byte-based or page-based
counters.
Signed-off-by: Josef Bacik
Signed-off-by: Nikolay Borisov
---
Changes since previous posting [1]:
- Incorporated Jan Kara's feedback to rename __wb_write
On 22.06.2017 09:44, Michal Hocko wrote:
> On Tue 20-06-17 18:14:28, Nikolay Borisov wrote:
>> Currently there are a multiple files with the following code:
>> #define K(x) ((x) << (PAGE_SHIFT - 10))
>> ... some code..
>> #undef K
>>
>> This is
ance. This will likely result in better runtime of code which deals with
modifying the stat counters.
While at it also document why percpu_counter_add_batch is in fact preempt and
irq-safe since at least 3 people got confused.
Signed-off-by: Nikolay Borisov
---
Changes since v2:
* Fixed bui
++
> net/ipv6/ip6mr.c | 71
> ++--
> 2 files changed, 81 insertions(+), 2 deletions(-)
>
Reviewed-by: Nikolay Aleksandrov
+++
> net/ipv4/ipmr.c | 69
> +++--
> 2 files changed, 79 insertions(+), 2 deletions(-)
>
Thanks,
Reviewed-by: Nikolay Aleksandrov
On 20.06.2017 23:30, Tejun Heo wrote:
> Hello,
>
> On Tue, Jun 20, 2017 at 11:28:30PM +0300, Nikolay Borisov wrote:
>>> Heh, looks like I was confused. __percpu_counter_add() is not
>>> irq-safe. It disables preemption and uses __this_cpu_read(), so
>>> th
On 20.06.2017 22:37, Tejun Heo wrote:
> Hello, Nikolay.
>
> On Tue, Jun 20, 2017 at 09:02:00PM +0300, Nikolay Borisov wrote:
>> Currently the writeback statistics code uses a percpu counters to hold
>> various statistics. Furthermore we have 2 families of functions - t
ance. This will likely result in better runtime of code which deals with
modifying the stat counters.
Signed-off-by: Nikolay Borisov
---
include/linux/backing-dev.h | 24 ++--
mm/page-writeback.c | 10 +-
2 files changed, 7 insertions(+), 27 deletions(-)
di
of CONFIG_SMP. The only difference is that the
__ version takes a batch parameter.
Make this a bit more explicit by just renaming __percpu_counter_add to
percpu_counter_add_batch.
Signed-off-by: Nikolay Borisov
---
fs/btrfs/disk-io.c | 4 ++--
fs/btrfs/extent_io.c | 2
eader since currently it's being included in all files which exhibit
this pattern. Also let's rename it to something a bit more verbose.
This patch doesn't introduce any functional changes
[1] https://patchwork.kernel.org/patch/9395205/
Signed-off-by: Nikolay Borisov
---
arch/t
pective of CONFIG_SNMP value.
The only difference is that the __ version takes a batch parameter.
Make this a bit more explicit by just renaming __percpu_counter_add to
percpu_counter_add_batch.
Signed-off-by: Nikolay Borisov
---
fs/btrfs/disk-io.c | 4 ++--
fs/btrfs/extent_io.c
ikely result in better runtime of code which deals with modifying the stat
counters.
Signed-off-by: Nikolay Borisov
---
Hello Tejun,
This patch resulted from me reading your feedback on Josef's memory
throttling prep patch https://patchwork.kernel.org/patch/9395219/ . If these
changes are m
On 19/06/17 23:44, Julien Gomes wrote:
> Add Netlink notifications on cache reports in ip6mr, in addition to the
> existing mrt6msg sent to mroute6_sk.
> Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R.
>
> MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the
> same
On 19/06/17 23:44, Julien Gomes wrote:
> Add Netlink notifications on cache reports in ipmr, in addition to the
> existing igmpmsg sent to mroute_sk.
> Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R.
>
> MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the
> same d
ned-off-by: Julien Gomes
> ---
> include/uapi/linux/rtnetlink.h | 4
> net/core/rtnetlink.c | 13 +
> 2 files changed, 17 insertions(+)
Thanks!
Suggested-by: Nikolay Aleksandrov
Signed-off-by: Nikolay Aleksandrov
> include/uapi/linux/rtnetlink.h | 3 +++
> security/selinux/nlmsgtab.c| 3 ++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
Reviewed-by: Nikolay Aleksandrov
>>> I agree. Noisy logging output is not good.
>>>
>>> Perhaps a general conversion of the dozens
>>> of existing netdev_info uses in this file to
>>> netdev_dbg and adding this at netdev_dbg is
>>> appropriate.
>>
>> In general I agree.
On 2.06.2017 02:02, Yu Zhao wrote:
> mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() have
> identical logics. Refactor code so we don't need to keep two pieces
> of code that does same thing.
>
> Signed-off-by: Yu Zhao
> ---
> mm/memcontrol.c | 71
> +---
On 01/06/17 17:16, Nikolay Aleksandrov wrote:
> On 01/06/17 17:00, Nikolay Aleksandrov wrote:
>> On 01/06/17 15:34, Sebastian Ott wrote:
>>> On Thu, 1 Jun 2017, Xin Long wrote:
>>>> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott
>>>> wrote:
>>>&g
On 01/06/17 17:00, Nikolay Aleksandrov wrote:
> On 01/06/17 15:34, Sebastian Ott wrote:
>> On Thu, 1 Jun 2017, Xin Long wrote:
>>> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott
>>> wrote:
>>>> [...]
>>> I couldn't see any bridge-related thin
On 01/06/17 15:34, Sebastian Ott wrote:
> On Thu, 1 Jun 2017, Xin Long wrote:
>> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott
>> wrote:
>>> [...]
>> I couldn't see any bridge-related thing here, and it couldn't be reproduced
>> with virbr0 (stp=1) on my box (on both s390x and x86_64), I guess th
On 5/18/17 12:27 AM, Vivien Didelot wrote:
Retrieve the message type from the nlmsghdr structure instead of
hardcoding it in both br_mdb_add and br_mdb_del.
Signed-off-by: Vivien Didelot
---
net/bridge/br_mdb.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/ne
On 5/18/17 6:08 PM, Vivien Didelot wrote:
Hi Nikolay,
Nikolay Aleksandrov writes:
err = __br_mdb_del(br, entry);
- if (!err)
- __br_mdb_notify(dev, p, entry, RTM_DELMDB);
+ if (err
On 5/18/17 12:27 AM, Vivien Didelot wrote:
Be symmetric with br_mdb_add and break if __br_mdb_del returns an error.
Signed-off-by: Vivien Didelot
---
net/bridge/br_mdb.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index d
On 10.05.2017 19:47, Trond Myklebust wrote:
> Hi Linus,
>
> The following changes since commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3:
>
> Linux 4.11-rc7 (2017-04-16 13:00:18 -0700)
>
> are available in the git repository at:
>
> git://git.linux-nfs.org/projects/trondmy/linux-nfs.git ta
On 21/04/17 22:50, Nikolay Aleksandrov wrote:
> On 21/04/17 22:36, David Miller wrote:
>> From: Nikolay Aleksandrov
>> Date: Fri, 21 Apr 2017 21:30:42 +0300
>>
>>> On 21/04/17 20:42, Nikolay Aleksandrov wrote:
>>>> Andrey Konovalov reported a BU
On 21/04/17 22:36, David Miller wrote:
> From: Nikolay Aleksandrov
> Date: Fri, 21 Apr 2017 21:30:42 +0300
>
>> On 21/04/17 20:42, Nikolay Aleksandrov wrote:
>>> Andrey Konovalov reported a BUG caused by the ip6mr code which is caused
>>> because we call unreg
On 21/04/17 20:42, Nikolay Aleksandrov wrote:
> Andrey Konovalov reported a BUG caused by the ip6mr code which is caused
> because we call unregister_netdevice_many for a device that is already
> being destroyed. In IPv4's ipmr that has been resolved by two commits
> long time a
On 21/04/17 20:42, Linus Torvalds wrote:
> On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds
> wrote:
>>
>> I'm assuming that the real cause is simply that "dev->reg_state" ends
>> up being NETREG_UNREGISTERING or something. Maybe the BUG_ON() could
>> be just removed, and replaced by the previous
On 14.04.2017 17:07, Andrey Ryabinin wrote:
> invalidate_bdev() calls cleancache_invalidate_inode() iff ->nrpages != 0
> which doen't make any sense.
> Make invalidate_bdev() always invalidate cleancache data.
>
> Fixes: c515e1fd361c ("mm/fs: add hooks to support cleancache")
> Signed-off-by: An
On 31.03.2017 22:26, Jeff Layton wrote:
> Most filesystems currently use mapping_set_error and
> filemap_check_errors for setting and reporting/clearing writeback errors
> at the mapping level. filemap_check_errors is indirectly called from
> most of the filemap_fdatawait_* functions and from
> f
On 24.03.2017 10:25, Nikolay Borisov wrote:
> register_shrinker allocates dynamic memory and thus is susceptible to failures
> under low-memory situation. Currently,get_userns ignores the return value of
> register_shrinker, potentially exposing not fully initialised object. This
> c
is referenced.
Fix this by failing to register the filesystem in case there is not enough
memory to fully construct the shrinker object.
Signed-off-by: Nikolay Borisov
---
fs/super.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/fs/super.c b/fs/super.c
in
is referenced.
Fix this by failing to register the filesystem in case there is not enough
memory to fully construct the shrinker object.
Signed-off-by: Nikolay Borisov
Fixes: 1d3d4437eae1 ("vmscan: per-node deferred work")
Link:
lkml.kernel.org/r/CACT4Y+b-purC3HHbw=sctms3ma8fkqtnyz
is referenced.
Fix this by failing to register the filesystem in case there is not enough
memory to fully construct the shrinker object.
Signed-off-by: Nikolay Borisov
---
fs/super.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/fs/super.c b/fs/super.c
in
On 9.03.2017 11:46, Andrey Ryabinin wrote:
> On 03/08/2017 11:10 AM, Nikolay Borisov wrote:
>
>>
>> So apparently this is indeed a false positive, resulting from using the old
>> compiler. I used the attached patch to verify it.
>>
>> And what it prints is
On 9.03.2017 03:58, Theodore Ts'o wrote:
> On Tue, Mar 07, 2017 at 10:40:53PM +0200, Nikolay Borisov wrote:
>> So this is wrong, the reason why the issues seemed fix is because I
>> switched my compiler to version 5.4.0. So this manifests only if I'm
>> using gc
On 7.03.2017 17:54, Dmitry Vyukov wrote:
> On Tue, Mar 7, 2017 at 4:35 PM, Nikolay Borisov
> wrote:
>> Hello,
>>
>> I've been chasing a particular UAF as reported by kasan
>> (https://www.spinics.net/lists/kernel/msg2458136.html). However, one
>> thin
>>
>>
>> New report from linux-next/c0b7b2b33bd17f7155956d0338ce92615da686c9
>>
>> [ cut here ]
>> kernel BUG at net/unix/garbage.c:149!
>> invalid opcode: [#1] SMP KASAN
>> Dumping ftrace buffer:
>>(ftrace buffer empty)
>> Modules linked in:
>> CPU: 0 PID: 1806 Co
On 7.03.2017 16:33, Nikolay Borisov wrote:
>
>
> On 7.03.2017 11:38, Nikolay Borisov wrote:
>>
>>
>> On 7.03.2017 00:35, Rafael J. Wysocki wrote:
>>> On Mon, Mar 6, 2017 at 9:31 PM, Nikolay Borisov
>>> wrote:
>>>> Hello,
>&g
On 7.03.2017 19:51, Alexander Potapenko wrote:
> On Tue, Mar 7, 2017 at 6:33 PM, Nikolay Borisov
> wrote:
>>
>>
>> On 7.03.2017 18:05, Alexander Potapenko wrote:
>>> On Tue, Mar 7, 2017 at 4:54 PM, Dmitry Vyukov wrote:
>>>> On Tue, Mar 7,
On 7.03.2017 18:05, Alexander Potapenko wrote:
> On Tue, Mar 7, 2017 at 4:54 PM, Dmitry Vyukov wrote:
>> On Tue, Mar 7, 2017 at 4:35 PM, Nikolay Borisov
>> wrote:
>>> Hello,
>>>
>>> I've been chasing a particular UAF as reported by kasan
>&
the
splats. Is this valid behavior ?
Regards,
Nikolay
On 7.03.2017 11:38, Nikolay Borisov wrote:
>
>
> On 7.03.2017 00:35, Rafael J. Wysocki wrote:
>> On Mon, Mar 6, 2017 at 9:31 PM, Nikolay Borisov
>> wrote:
>>> Hello,
>>>
>>> Booting 4.11-rc1 with kasan enabled and "slub_debug=F"
On 7.03.2017 00:35, Rafael J. Wysocki wrote:
> On Mon, Mar 6, 2017 at 9:31 PM, Nikolay Borisov
> wrote:
>> Hello,
>>
>> Booting 4.11-rc1 with kasan enabled and "slub_debug=F" produces the
>&g
Hello,
Booting 4.11-rc1 with kasan enabled and "slub_debug=F" produces the following
errors:
[7.070797]
==
[7.071724] BUG: KASAN: slab-out-of-bounds in filldir+0xc3/0x160 at addr
88006bc2b0ae
[7.071724] Read of si
r __GFP_FS when PF_MEMALLOC_NOIO is set")
Signed-off-by: Nikolay Borisov
---
kernel/locking/lockdep.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Changes since v2:
* Incorporate Michal's suggestion of using memalloc_noio_flags
explicitly.
* Tune the commi
On 1.03.2017 12:31, Michal Hocko wrote:
> On Wed 01-03-17 11:22:51, Vlastimil Babka wrote:
>> On 03/01/2017 08:48 AM, Nikolay Borisov wrote:
>>> Commit 21caf2fc1931 ("mm: teach mm by current context info to not do I/O
>>> during memory allocation")
On 1.03.2017 11:46, Peter Zijlstra wrote:
> On Wed, Mar 01, 2017 at 09:59:00AM +0200, Nikolay Borisov wrote:
>> Commit 21caf2fc1931 ("mm: teach mm by current context info to not do I/O
>> during memory allocation") added the memalloc_noio_(save|restore) functions
>
k into the filesystem
without explicitly changing the flags for every allocation site. Yet, lockdep
not being aware of that is prone to showing false positives. Fix this
by teaching it that the presence of PF_MEMALLOC_NOIO flag mean we are not
going to issue any I/O
Signed-off-by: Nikolay Borisov
---
kern
k into the filesystem
without explicitly changing the flags for every allocation site. Yet, lockdep
not being aware of that is prone to showing false positives. Fix this
by teaching it that the presence of PF_MEMALLOC_NOIO flag mean we are not
going to issue any I/O
Signed-off-by: Nikolay Borisov
---
kern
;
Actually that code can be reduced further, I'll follow up with a patch later.
Reviewed-by: Nikolay Aleksandrov
| 39 ++-
> net/bridge/br_mdb.c | 2 +-
> net/bridge/br_multicast.c| 90
>
> net/bridge/br_netlink.c | 5 +++
> net/bridge/br_private.h | 3 +-
> net/bridge/br_sysfs_if.c | 2 +
> 8 files changed, 114 insertions(+), 29 deletions(-)
>
Reviewed-by: Nikolay Aleksandrov
On 20.01.2017 20:05, Eric W. Biederman wrote:
> Nikolay Borisov writes:
>
>> On 20.01.2017 15:07, Dmitry Vyukov wrote:
>>> Hello,
>>>
>>> I've got the following deadlock report while running syzkaller fuzzer
>>> on eec0d3d065bfcdf9cd5f56dd2a
2000 2820a478
> [] el1_irq+0xb8/0x130 arch/arm64/kernel/entry.S:486
> [< inline >] arch_local_irq_restore
> ./arch/arm64/include/asm/irqflags.h:81
> [] rcu_idle_exit+0x64/0xa8 kernel/rcu/tree.c:1030
> [< inline >] cpuidle_id
301 - 400 of 653 matches
Mail list logo
