Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 08/09/17 17:17, Kosuke Tatsukawa wrote: > Hi, > >> On 08/09/17 13:10, Nikolay Aleksandrov wrote: >>> On 08/09/17 05:06, Kosuke Tatsukawa wrote: >>>> Hi, >>>> >>>>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>&g

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 08/09/17 13:10, Nikolay Aleksandrov wrote: > On 08/09/17 05:06, Kosuke Tatsukawa wrote: >> Hi, >> >>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>>> balance-al

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 08/09/17 13:10, Nikolay Aleksandrov wrote: > On 08/09/17 05:06, Kosuke Tatsukawa wrote: >> Hi, >> >>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>>> balance-al

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 08/09/17 05:06, Kosuke Tatsukawa wrote: > Hi, > >> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>> balance-alb mode") tried to fix transmit dynamic load balancing in >>> balance-alb mode, which wasn't working after commit

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 08/09/17 05:06, Kosuke Tatsukawa wrote: > Hi, > >> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>> balance-alb mode") tried to fix transmit dynamic load balancing in >>> balance-alb mode, which wasn't working after commit

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 7.09.2017 01:47, Kosuke Tatsukawa wrote: > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balancing in > balance-alb mode, which wasn't working after commit 8b426dc54cf4 > ("bonding: remove hardcoded value"). > > It

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

On 7.09.2017 01:47, Kosuke Tatsukawa wrote: > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balancing in > balance-alb mode, which wasn't working after commit 8b426dc54cf4 > ("bonding: remove hardcoded value"). > > It

workqueue threads ->journal_info buggery

Hello Tejun, I've hit the following problems under memory-heavy workload conditions: First is a BUG_ON : J_ASSERT(journal_current_handle() == handle); [ 64.261793] kernel BUG at fs/jbd2/transaction.c:1644! [ 64.263894] invalid opcode: [#1] SMP [

workqueue threads ->journal_info buggery

Hello Tejun, I've hit the following problems under memory-heavy workload conditions: First is a BUG_ON : J_ASSERT(journal_current_handle() == handle); [ 64.261793] kernel BUG at fs/jbd2/transaction.c:1644! [ 64.263894] invalid opcode: [#1] SMP [

Re: [PATCH 10/16] btrfs: switch write_buf to kernel_write

On 30.08.2017 18:00, Christoph Hellwig wrote: > Instead of playing with the addressing limits. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > --- Reviewed-by: Nikolay Borisov <nbori...@suse.com> > fs/btrfs/send.c | 18 -- > 1 file changed,

Re: [PATCH 10/16] btrfs: switch write_buf to kernel_write

On 30.08.2017 18:00, Christoph Hellwig wrote: > Instead of playing with the addressing limits. > > Signed-off-by: Christoph Hellwig > --- Reviewed-by: Nikolay Borisov > fs/btrfs/send.c | 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) > &g

[PATCH] swap: Remove obsolete sentence

Currently there are no ->swap_{in,out} method in address_space_operations sructure definition, so the statement that anything is going to be proxied through them is wrong. Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- Documentation/filesystems/vfs.txt | 4 +--- 1 file c

[PATCH] swap: Remove obsolete sentence

Currently there are no ->swap_{in,out} method in address_space_operations sructure definition, so the statement that anything is going to be proxied through them is wrong. Signed-off-by: Nikolay Borisov --- Documentation/filesystems/vfs.txt | 4 +--- 1 file changed, 1 insertion(+), 3 deleti

Re: [PATCH][V2][netdev-next] gre: remove duplicated assignment of iph

On 23/08/17 14:59, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > iph is being assigned the same value twice; remove the redundant > first assignment. (Thanks to Nikolay Aleksandrov for pointing out > that the first asssignment should be remov

Re: [PATCH][V2][netdev-next] gre: remove duplicated assignment of iph

On 23/08/17 14:59, Colin King wrote: > From: Colin Ian King > > iph is being assigned the same value twice; remove the redundant > first assignment. (Thanks to Nikolay Aleksandrov for pointing out > that the first asssignment should be removed and not the second) > > Fixe

Re: [PATCH][netdev-next] gre: remove duplicated assignment of iph

On 23/08/17 14:13, Colin King wrote: > From: Colin Ian King > > iph is being assigned the same value twice; remove the redundant > second assignment. > > Fixes warning: > net/ipv4/ip_gre.c:265:2: warning: Value stored to 'iph' is never read > > Signed-off-by: Colin

Re: [PATCH][netdev-next] gre: remove duplicated assignment of iph

On 23/08/17 14:13, Colin King wrote: > From: Colin Ian King > > iph is being assigned the same value twice; remove the redundant > second assignment. > > Fixes warning: > net/ipv4/ip_gre.c:265:2: warning: Value stored to 'iph' is never read > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH] exec: Check stack space more strictly

minor nit below On 18.07.2017 01:22, Andy Lutomirski wrote: > We can currently blow past the stack rlimit and cause odd behavior > if there are accounting bugs, rounding issues, or races. It's not > clear that the odd behavior is actually a problem, but it's nicer to > fail the exec instead of

Re: [PATCH] exec: Check stack space more strictly

minor nit below On 18.07.2017 01:22, Andy Lutomirski wrote: > We can currently blow past the stack rlimit and cause odd behavior > if there are accounting bugs, rounding issues, or races. It's not > clear that the odd behavior is actually a problem, but it's nicer to > fail the exec instead of

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

On 8.08.2017 09:00, Byungchul Park wrote: > On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote: > + llist_for_each_entry_safe(cl, t, reverse, list) { Just wondering why not using llist_for_each_entry(), or you use the _safe version on purpose ? >>> >>> If I use

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

On 8.08.2017 09:00, Byungchul Park wrote: > On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote: > + llist_for_each_entry_safe(cl, t, reverse, list) { Just wondering why not using llist_for_each_entry(), or you use the _safe version on purpose ? >>> >>> If I use

[PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

We already get the block counts and the calculate the end block at the beginning of the function. Let's use the local variables for consistency and readability. No functional changes Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- fs/direct-io.c | 5 ++--- 1 file changed, 2 inse

[PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

We already get the block counts and the calculate the end block at the beginning of the function. Let's use the local variables for consistency and readability. No functional changes Signed-off-by: Nikolay Borisov --- fs/direct-io.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions

Re: [PATCH] btrfs: resume qgroup rescan on rw remount

On 10.07.2017 16:12, Nikolay Borisov wrote: > > > On 4.07.2017 14:49, Aleksa Sarai wrote: >> Several distributions mount the "proper root" as ro during initrd and >> then remount it as rw before pivot_root(2). Thus, if a rescan had been >> aborted by

Re: [PATCH] btrfs: resume qgroup rescan on rw remount

On 10.07.2017 16:12, Nikolay Borisov wrote: > > > On 4.07.2017 14:49, Aleksa Sarai wrote: >> Several distributions mount the "proper root" as ro during initrd and >> then remount it as rw before pivot_root(2). Thus, if a rescan had been >> aborted by

Re: [PATCH] btrfs: resume qgroup rescan on rw remount

On 4.07.2017 14:49, Aleksa Sarai wrote: > Several distributions mount the "proper root" as ro during initrd and > then remount it as rw before pivot_root(2). Thus, if a rescan had been > aborted by a previous shutdown, the rescan would never be resumed. > > This issue would manifest itself as

Re: [PATCH] btrfs: resume qgroup rescan on rw remount

On 4.07.2017 14:49, Aleksa Sarai wrote: > Several distributions mount the "proper root" as ro during initrd and > then remount it as rw before pivot_root(2). Thus, if a rescan had been > aborted by a previous shutdown, the rescan would never be resumed. > > This issue would manifest itself as

Re: [PATCH] writeback: Simplify wb_stat_sum

[CC'ing Andrew since he seems to be taking those patches through -mm ] On 23.06.2017 18:11, Nikolay Borisov wrote: > wb_stat_sum disables interrupts and calls __wb_stat_sum which eventually calls > __percpu_counter_sum. However, the percpu routine is already irq-safe. > Simplify > th

Re: [PATCH] writeback: Simplify wb_stat_sum

[CC'ing Andrew since he seems to be taking those patches through -mm ] On 23.06.2017 18:11, Nikolay Borisov wrote: > wb_stat_sum disables interrupts and calls __wb_stat_sum which eventually calls > __percpu_counter_sum. However, the percpu routine is already irq-safe. > Simplify > th

[PATCH] writeback: Simplify wb_stat_sum

__wb_stat_sum which was just a wrapper over percpu_counter_sum_positive Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- include/linux/backing-dev.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h

[PATCH] writeback: Simplify wb_stat_sum

__wb_stat_sum which was just a wrapper over percpu_counter_sum_positive Signed-off-by: Nikolay Borisov --- include/linux/backing-dev.h | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h index e9c967b86054

[PATCH 1/4] remove mapping from balance_dirty_pages*()

@suse.cz> Acked-by: Tejun Heo <t...@kernel.org> Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- Changes since previous posting [1]: - No functional/logic changes, just forwarded-ported to 4.12-rc6, as such I've retained the acked-by and reviewed-by tags. [1] https://patc

[PATCH 1/4] remove mapping from balance_dirty_pages*()

pass in the bdi and super block directly so we can avoid using mapping. This will allow us to still use balance_dirty_pages for dirty metadata pages that are not backed by an address_mapping. Signed-off-by: Josef Bacik Reviewed-by: Jan Kara Acked-by: Tejun Heo Signed-off-by: Nikolay Borisov

[PATCH 3/4] writeback: add counters for metadata usage

s used for metadata on the system. This is also needed so things like dirty throttling know that this is dirtyable memory as well and easily reclaimed. This patch doesn't introduce any functional changes. Signed-off-by: Josef Bacik <jba...@fb.com> Signed-off-by: Nikolay Borisov <nbori...@suse.c

[PATCH 3/4] writeback: add counters for metadata usage

. This is also needed so things like dirty throttling know that this is dirtyable memory as well and easily reclaimed. This patch doesn't introduce any functional changes. Signed-off-by: Josef Bacik Signed-off-by: Nikolay Borisov --- Changs since previous posting [1]: - Forward ported

[RFC PATCH 0/4] Support for metadata specific accounting

Hello, This series is a report of Josef's original posting [1]. I've included fine-grained changelog in each patch with my changes. Basically, I've forward ported it to 4.12-rc6 and tried incorporating the feedback which was given to every individual patch (I've included link with that

[PATCH 4/4] writeback: introduce super_operations->write_metadata

b.com> Reviewed-by: Jan Kara <j...@suse.cz> Reviewed-by: Tejun Heo <t...@kernel.org> Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- Changes since previous posting [1] : - Forward ported to 4.12-rc6 kernel I've retained the review-by tags since I didn'

[PATCH 2/4] writeback: convert WB_WRITTEN/WB_DIRITED counters to bytes

unting stuff to change the counters as well. Additionally, scale WB_STAT_BATCH based on whether we are incrementing byte-based or page-based counters. Signed-off-by: Josef Bacik <jba...@fb.com> Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- Changes since previous posting [1]:

[RFC PATCH 0/4] Support for metadata specific accounting

Hello, This series is a report of Josef's original posting [1]. I've included fine-grained changelog in each patch with my changes. Basically, I've forward ported it to 4.12-rc6 and tried incorporating the feedback which was given to every individual patch (I've included link with that

[PATCH 4/4] writeback: introduce super_operations->write_metadata

viewed-by: Tejun Heo Signed-off-by: Nikolay Borisov --- Changes since previous posting [1] : - Forward ported to 4.12-rc6 kernel I've retained the review-by tags since I didn't introduce any changes. [1] https://patchwork.kernel.org/patch/9395213/ fs/fs-writeback.c

[PATCH 2/4] writeback: convert WB_WRITTEN/WB_DIRITED counters to bytes

the counters as well. Additionally, scale WB_STAT_BATCH based on whether we are incrementing byte-based or page-based counters. Signed-off-by: Josef Bacik Signed-off-by: Nikolay Borisov --- Changes since previous posting [1]: - Incorporated Jan Kara's feedback to rename __wb_writeout_inc

Re: [PATCH] mm: Refactor conversion of pages to bytes macro definitions

On 22.06.2017 09:44, Michal Hocko wrote: > On Tue 20-06-17 18:14:28, Nikolay Borisov wrote: >> Currently there are a multiple files with the following code: >> #define K(x) ((x) << (PAGE_SHIFT - 10)) >> ... some code.. >> #undef K >> >> This is

Re: [PATCH] mm: Refactor conversion of pages to bytes macro definitions

On 22.06.2017 09:44, Michal Hocko wrote: > On Tue 20-06-17 18:14:28, Nikolay Borisov wrote: >> Currently there are a multiple files with the following code: >> #define K(x) ((x) << (PAGE_SHIFT - 10)) >> ... some code.. >> #undef K >> >> This is

[PATCH v3] writeback: Rework wb_[dec|inc]_stat family of functions

. This will likely result in better runtime of code which deals with modifying the stat counters. While at it also document why percpu_counter_add_batch is in fact preempt and irq-safe since at least 3 people got confused. Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- Changes si

[PATCH v3] writeback: Rework wb_[dec|inc]_stat family of functions

. This will likely result in better runtime of code which deals with modifying the stat counters. While at it also document why percpu_counter_add_batch is in fact preempt and irq-safe since at least 3 people got confused. Signed-off-by: Nikolay Borisov --- Changes since v2: * Fixed build failure

Re: [PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

t; > --- > include/uapi/linux/mroute6.h | 12 > net/ipv6/ip6mr.c | 71 > ++-- > 2 files changed, 81 insertions(+), 2 deletions(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

++ > net/ipv6/ip6mr.c | 71 > ++-- > 2 files changed, 81 insertions(+), 2 deletions(-) > Reviewed-by: Nikolay Aleksandrov

Re: [PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

gt; > --- > include/uapi/linux/mroute.h | 12 > net/ipv4/ipmr.c | 69 > +++-- > 2 files changed, 79 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

+++ > net/ipv4/ipmr.c | 69 > +++-- > 2 files changed, 79 insertions(+), 2 deletions(-) > Thanks, Reviewed-by: Nikolay Aleksandrov

Re: [PATCH v2 2/2] writeback: Rework wb_[dec|inc]_stat family of functions

On 20.06.2017 23:30, Tejun Heo wrote: > Hello, > > On Tue, Jun 20, 2017 at 11:28:30PM +0300, Nikolay Borisov wrote: >>> Heh, looks like I was confused. __percpu_counter_add() is not >>> irq-safe. It disables preemption and uses __this_cpu_read(), so >>&g

Re: [PATCH v2 2/2] writeback: Rework wb_[dec|inc]_stat family of functions

On 20.06.2017 23:30, Tejun Heo wrote: > Hello, > > On Tue, Jun 20, 2017 at 11:28:30PM +0300, Nikolay Borisov wrote: >>> Heh, looks like I was confused. __percpu_counter_add() is not >>> irq-safe. It disables preemption and uses __this_cpu_read(), so >>&g

Re: [PATCH v2 2/2] writeback: Rework wb_[dec|inc]_stat family of functions

On 20.06.2017 22:37, Tejun Heo wrote: > Hello, Nikolay. > > On Tue, Jun 20, 2017 at 09:02:00PM +0300, Nikolay Borisov wrote: >> Currently the writeback statistics code uses a percpu counters to hold >> various statistics. Furthermore we have 2 families of functions - t

Re: [PATCH v2 2/2] writeback: Rework wb_[dec|inc]_stat family of functions

On 20.06.2017 22:37, Tejun Heo wrote: > Hello, Nikolay. > > On Tue, Jun 20, 2017 at 09:02:00PM +0300, Nikolay Borisov wrote: >> Currently the writeback statistics code uses a percpu counters to hold >> various statistics. Furthermore we have 2 families of functions - t

[PATCH v2 2/2] writeback: Rework wb_[dec|inc]_stat family of functions

. This will likely result in better runtime of code which deals with modifying the stat counters. Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- include/linux/backing-dev.h | 24 ++-- mm/page-writeback.c | 10 +- 2 files changed, 7 insertions(+), 27 del

[PATCH v2 2/2] writeback: Rework wb_[dec|inc]_stat family of functions

. This will likely result in better runtime of code which deals with modifying the stat counters. Signed-off-by: Nikolay Borisov --- include/linux/backing-dev.h | 24 ++-- mm/page-writeback.c | 10 +- 2 files changed, 7 insertions(+), 27 deletions(-) diff --git

[PATCH v2 1/2] percpu_counter: Rename __percpu_counter_add to percpu_counter_add_batch

of CONFIG_SMP. The only difference is that the __ version takes a batch parameter. Make this a bit more explicit by just renaming __percpu_counter_add to percpu_counter_add_batch. Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- fs/btrfs/disk-io.c | 4 ++-- fs/btrfs/exten

[PATCH v2 1/2] percpu_counter: Rename __percpu_counter_add to percpu_counter_add_batch

of CONFIG_SMP. The only difference is that the __ version takes a batch parameter. Make this a bit more explicit by just renaming __percpu_counter_add to percpu_counter_add_batch. Signed-off-by: Nikolay Borisov --- fs/btrfs/disk-io.c | 4 ++-- fs/btrfs/extent_io.c | 2

[PATCH] mm: Refactor conversion of pages to bytes macro definitions

since currently it's being included in all files which exhibit this pattern. Also let's rename it to something a bit more verbose. This patch doesn't introduce any functional changes [1] https://patchwork.kernel.org/patch/9395205/ Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- arch/tile/

[PATCH] mm: Refactor conversion of pages to bytes macro definitions

since currently it's being included in all files which exhibit this pattern. Also let's rename it to something a bit more verbose. This patch doesn't introduce any functional changes [1] https://patchwork.kernel.org/patch/9395205/ Signed-off-by: Nikolay Borisov --- arch/tile/mm/pgtable.c

[PATCH 1/2] percpu_counter: Rename __percpu_counter_add to percpu_counter_add_batch

respective of CONFIG_SNMP value. The only difference is that the __ version takes a batch parameter. Make this a bit more explicit by just renaming __percpu_counter_add to percpu_counter_add_batch. Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- fs/btrfs/disk-io.c | 4 ++-- fs/b

[PATCH 1/2] percpu_counter: Rename __percpu_counter_add to percpu_counter_add_batch

respective of CONFIG_SNMP value. The only difference is that the __ version takes a batch parameter. Make this a bit more explicit by just renaming __percpu_counter_add to percpu_counter_add_batch. Signed-off-by: Nikolay Borisov --- fs/btrfs/disk-io.c | 4 ++-- fs/btrfs/extent_io.c

[PATCH 2/2] writeback: Rework wb_[dec|inc]_stat family of functions

result in better runtime of code which deals with modifying the stat counters. Signed-off-by: Nikolay Borisov <nbori...@suse.com> --- Hello Tejun, This patch resulted from me reading your feedback on Josef's memory throttling prep patch https://patchwork.kernel.org/patch/9

[PATCH 2/2] writeback: Rework wb_[dec|inc]_stat family of functions

result in better runtime of code which deals with modifying the stat counters. Signed-off-by: Nikolay Borisov --- Hello Tejun, This patch resulted from me reading your feedback on Josef's memory throttling prep patch https://patchwork.kernel.org/patch/9395219/ . If these changes are merged

Re: [PATCH net-next v2 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

On 19/06/17 23:44, Julien Gomes wrote: > Add Netlink notifications on cache reports in ip6mr, in addition to the > existing mrt6msg sent to mroute6_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. > > MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

Re: [PATCH net-next v2 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

On 19/06/17 23:44, Julien Gomes wrote: > Add Netlink notifications on cache reports in ip6mr, in addition to the > existing mrt6msg sent to mroute6_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. > > MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

Re: [PATCH net-next v2 3/4] ipmr: add netlink notifications on igmpmsg cache reports

On 19/06/17 23:44, Julien Gomes wrote: > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the > same

Re: [PATCH net-next v2 3/4] ipmr: add netlink notifications on igmpmsg cache reports

On 19/06/17 23:44, Julien Gomes wrote: > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the > same

Re: [PATCH net-next v2 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

ned-off-by: Julien Gomes <jul...@arista.com> > --- > include/uapi/linux/rtnetlink.h | 4 > net/core/rtnetlink.c | 13 + > 2 files changed, 17 insertions(+) Thanks! Suggested-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v2 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

ned-off-by: Julien Gomes > --- > include/uapi/linux/rtnetlink.h | 4 > net/core/rtnetlink.c | 13 + > 2 files changed, 17 insertions(+) Thanks! Suggested-by: Nikolay Aleksandrov Signed-off-by: Nikolay Aleksandrov

Re: [PATCH net-next v2 1/4] rtnetlink: add NEWCACHEREPORT message type

ff-by: Julien Gomes <jul...@arista.com> > --- > include/uapi/linux/rtnetlink.h | 3 +++ > security/selinux/nlmsgtab.c| 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com>

Re: [PATCH net-next v2 1/4] rtnetlink: add NEWCACHEREPORT message type

> include/uapi/linux/rtnetlink.h | 3 +++ > security/selinux/nlmsgtab.c| 3 ++- > 2 files changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Nikolay Aleksandrov

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

sorry. >>> >>> I agree. Noisy logging output is not good. >>> >>> Perhaps a general conversion of the dozens >>> of existing netdev_info uses in this file to >>> netdev_dbg and adding this at netdev_dbg is >>> appropriate. >&g

Re: [PATCH] Add printk for bonding module packets_per_slave parameter

agree. Noisy logging output is not good. >>> >>> Perhaps a general conversion of the dozens >>> of existing netdev_info uses in this file to >>> netdev_dbg and adding this at netdev_dbg is >>> appropriate. >> >> In general I agree. The few tim

Re: [PATCH] memcg: refactor mem_cgroup_resize_limit()

On 2.06.2017 02:02, Yu Zhao wrote: > mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() have > identical logics. Refactor code so we don't need to keep two pieces > of code that does same thing. > > Signed-off-by: Yu Zhao > --- > mm/memcontrol.c | 71 >

Re: [PATCH] memcg: refactor mem_cgroup_resize_limit()

On 2.06.2017 02:02, Yu Zhao wrote: > mem_cgroup_resize_limit() and mem_cgroup_resize_memsw_limit() have > identical logics. Refactor code so we don't need to keep two pieces > of code that does same thing. > > Signed-off-by: Yu Zhao > --- > mm/memcontrol.c | 71 >

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 01/06/17 17:16, Nikolay Aleksandrov wrote: > On 01/06/17 17:00, Nikolay Aleksandrov wrote: >> On 01/06/17 15:34, Sebastian Ott wrote: >>> On Thu, 1 Jun 2017, Xin Long wrote: >>>> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott >>>> <seb...@linux.vne

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 01/06/17 17:16, Nikolay Aleksandrov wrote: > On 01/06/17 17:00, Nikolay Aleksandrov wrote: >> On 01/06/17 15:34, Sebastian Ott wrote: >>> On Thu, 1 Jun 2017, Xin Long wrote: >>>> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott >>>> wrote: >>>&g

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 01/06/17 17:00, Nikolay Aleksandrov wrote: > On 01/06/17 15:34, Sebastian Ott wrote: >> On Thu, 1 Jun 2017, Xin Long wrote: >>> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott >>> <seb...@linux.vnet.ibm.com> wrote: >>>> [...] >>> I could

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 01/06/17 17:00, Nikolay Aleksandrov wrote: > On 01/06/17 15:34, Sebastian Ott wrote: >> On Thu, 1 Jun 2017, Xin Long wrote: >>> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott >>> wrote: >>>> [...] >>> I couldn't see any bridge-related thing her

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 01/06/17 15:34, Sebastian Ott wrote: > On Thu, 1 Jun 2017, Xin Long wrote: >> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott >> wrote: >>> [...] >> I couldn't see any bridge-related thing here, and it couldn't be reproduced >> with virbr0 (stp=1) on my box (on both

Re: Oops with commit 6d18c73 bridge: start hello_timer when enabling KERNEL_STP in br_stp_start

On 01/06/17 15:34, Sebastian Ott wrote: > On Thu, 1 Jun 2017, Xin Long wrote: >> On Thu, Jun 1, 2017 at 12:32 AM, Sebastian Ott >> wrote: >>> [...] >> I couldn't see any bridge-related thing here, and it couldn't be reproduced >> with virbr0 (stp=1) on my box (on both s390x and x86_64), I guess

Re: [PATCH net-next 5/6] net: bridge: get msgtype from nlmsghdr in mdb ops

On 5/18/17 12:27 AM, Vivien Didelot wrote: Retrieve the message type from the nlmsghdr structure instead of hardcoding it in both br_mdb_add and br_mdb_del. Signed-off-by: Vivien Didelot --- net/bridge/br_mdb.c | 10 ++ 1 file changed, 6

Re: [PATCH net-next 5/6] net: bridge: get msgtype from nlmsghdr in mdb ops

On 5/18/17 12:27 AM, Vivien Didelot wrote: Retrieve the message type from the nlmsghdr structure instead of hardcoding it in both br_mdb_add and br_mdb_del. Signed-off-by: Vivien Didelot --- net/bridge/br_mdb.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

On 5/18/17 6:08 PM, Vivien Didelot wrote: Hi Nikolay, Nikolay Aleksandrov <niko...@cumulusnetworks.com> writes: err = __br_mdb_del(br, entry); - if (!err) - __br_mdb_notify(dev, p, entry, RTM_

Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

On 5/18/17 6:08 PM, Vivien Didelot wrote: Hi Nikolay, Nikolay Aleksandrov writes: err = __br_mdb_del(br, entry); - if (!err) - __br_mdb_notify(dev, p, entry, RTM_DELMDB); + if (err

Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

On 5/18/17 12:27 AM, Vivien Didelot wrote: Be symmetric with br_mdb_add and break if __br_mdb_del returns an error. Signed-off-by: Vivien Didelot --- net/bridge/br_mdb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails

On 5/18/17 12:27 AM, Vivien Didelot wrote: Be symmetric with br_mdb_add and break if __br_mdb_del returns an error. Signed-off-by: Vivien Didelot --- net/bridge/br_mdb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index

Re: [GIT PULL] Please pull NFS client fixes for 4.12

On 10.05.2017 19:47, Trond Myklebust wrote: > Hi Linus, > > The following changes since commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3: > > Linux 4.11-rc7 (2017-04-16 13:00:18 -0700) > > are available in the git repository at: > > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git

Re: [GIT PULL] Please pull NFS client fixes for 4.12

On 10.05.2017 19:47, Trond Myklebust wrote: > Hi Linus, > > The following changes since commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3: > > Linux 4.11-rc7 (2017-04-16 13:00:18 -0700) > > are available in the git repository at: > > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git

Re: [PATCH net] ip6mr: fix notification device destruction

On 21/04/17 22:50, Nikolay Aleksandrov wrote: > On 21/04/17 22:36, David Miller wrote: >> From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> >> Date: Fri, 21 Apr 2017 21:30:42 +0300 >> >>> On 21/04/17 20:42, Nikolay Aleksandrov wrote: >>>> And

Re: [PATCH net] ip6mr: fix notification device destruction

On 21/04/17 22:50, Nikolay Aleksandrov wrote: > On 21/04/17 22:36, David Miller wrote: >> From: Nikolay Aleksandrov >> Date: Fri, 21 Apr 2017 21:30:42 +0300 >> >>> On 21/04/17 20:42, Nikolay Aleksandrov wrote: >>>> Andrey Konovalov reported a BU

Re: [PATCH net] ip6mr: fix notification device destruction

On 21/04/17 22:36, David Miller wrote: > From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > Date: Fri, 21 Apr 2017 21:30:42 +0300 > >> On 21/04/17 20:42, Nikolay Aleksandrov wrote: >>> Andrey Konovalov reported a BUG caused by the ip6mr code which

Re: [PATCH net] ip6mr: fix notification device destruction

On 21/04/17 22:36, David Miller wrote: > From: Nikolay Aleksandrov > Date: Fri, 21 Apr 2017 21:30:42 +0300 > >> On 21/04/17 20:42, Nikolay Aleksandrov wrote: >>> Andrey Konovalov reported a BUG caused by the ip6mr code which is caused >>> because we call unreg

Re: [PATCH net] ip6mr: fix notification device destruction

On 21/04/17 20:42, Nikolay Aleksandrov wrote: > Andrey Konovalov reported a BUG caused by the ip6mr code which is caused > because we call unregister_netdevice_many for a device that is already > being destroyed. In IPv4's ipmr that has been resolved by two commits > long time ago by

Re: [PATCH net] ip6mr: fix notification device destruction

On 21/04/17 20:42, Nikolay Aleksandrov wrote: > Andrey Konovalov reported a BUG caused by the ip6mr code which is caused > because we call unregister_netdevice_many for a device that is already > being destroyed. In IPv4's ipmr that has been resolved by two commits > long time ago by

Re: net/core: BUG in unregister_netdevice_many

On 21/04/17 20:42, Linus Torvalds wrote: > On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds > wrote: >> >> I'm assuming that the real cause is simply that "dev->reg_state" ends >> up being NETREG_UNREGISTERING or something. Maybe the BUG_ON() could >> be just

Re: net/core: BUG in unregister_netdevice_many

On 21/04/17 20:42, Linus Torvalds wrote: > On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds > wrote: >> >> I'm assuming that the real cause is simply that "dev->reg_state" ends >> up being NETREG_UNREGISTERING or something. Maybe the BUG_ON() could >> be just removed, and replaced by the previous

Re: [PATCH 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev()

On 14.04.2017 17:07, Andrey Ryabinin wrote: > invalidate_bdev() calls cleancache_invalidate_inode() iff ->nrpages != 0 > which doen't make any sense. > Make invalidate_bdev() always invalidate cleancache data. > > Fixes: c515e1fd361c ("mm/fs: add hooks to support cleancache") > Signed-off-by:

Re: [PATCH 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev()

On 14.04.2017 17:07, Andrey Ryabinin wrote: > invalidate_bdev() calls cleancache_invalidate_inode() iff ->nrpages != 0 > which doen't make any sense. > Make invalidate_bdev() always invalidate cleancache data. > > Fixes: c515e1fd361c ("mm/fs: add hooks to support cleancache") > Signed-off-by:

Re: [RFC PATCH 1/4] fs: new infrastructure for writeback error handling and reporting

On 31.03.2017 22:26, Jeff Layton wrote: > Most filesystems currently use mapping_set_error and > filemap_check_errors for setting and reporting/clearing writeback errors > at the mapping level. filemap_check_errors is indirectly called from > most of the filemap_fdatawait_* functions and from >

<    1   2   3   4   5   6   7   8   9   10   >