[PATCH 1/2] goldfish: Add missing includes to goldfish.h

2018-07-23 Thread rkir
From: Roman Kiryanov goldfish.h refers to external symbols such as dma_addr_t and writel. This causes compilation errors if this file is included before other header files. The mentioned symbols are defined in types.h (dma_addr_t) and io.h (writel). Signed-off-by: Roman Kiryanov ---

[PATCH 2/2] goldfish: Use dedicated macros instead of manual bit shifting

2018-07-23 Thread rkir
From: Roman Kiryanov There are dedicated macros (lower_32_bits and upper_32_bits) available to extract the lower and upper 32 bits. They provide better readability and could prevent some compilation warnings. Signed-off-by: Roman Kiryanov --- include/linux/goldfish.h | 11 +++ 1 file

[PATCH] platform: goldfish: Retire pdev_bus

2018-07-19 Thread rkir
From: Roman Kiryanov Not used by goldfish. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/Kconfig| 5 - drivers/platform/goldfish/Makefile | 1 - drivers/platform/goldfish/pdev_bus.c | 232 --- 3 files changed, 238 deletions(-) delete mode

[PATCH] platform: goldfish: Retire pdev_bus

2018-07-19 Thread rkir
From: Roman Kiryanov Not used by goldfish. Signed-off-by: Roman Kiryanov --- drivers/platform/goldfish/Kconfig| 5 - drivers/platform/goldfish/Makefile | 1 - drivers/platform/goldfish/pdev_bus.c | 232 --- 3 files changed, 238 deletions(-) delete mode

[PATCH 3/3] tty: Mark goldfish_tty_line_count as const

2018-07-17 Thread rkir
From: Roman Kiryanov The driver never mutates this variable - no benefits of keeping it mutable. Signed-off-by: Roman Kiryanov --- drivers/tty/goldfish.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index

[PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c

2018-07-17 Thread rkir
From: Roman Kiryanov enums produce better compilation errors than defines. Signed-off-by: Roman Kiryanov --- drivers/tty/goldfish.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index

[PATCH 3/3] tty: Mark goldfish_tty_line_count as const

2018-07-17 Thread rkir
From: Roman Kiryanov The driver never mutates this variable - no benefits of keeping it mutable. Signed-off-by: Roman Kiryanov --- drivers/tty/goldfish.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index

[PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c

2018-07-17 Thread rkir
From: Roman Kiryanov enums produce better compilation errors than defines. Signed-off-by: Roman Kiryanov --- drivers/tty/goldfish.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index

[PATCH 1/3] tty: Address checkpatch warnings in goldfish.c

2018-07-17 Thread rkir
From: Roman Kiryanov To make further maintenance easier. Signed-off-by: Roman Kiryanov --- drivers/tty/goldfish.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index 37caba7c3aff..a92fcb2b0002 100644 ---

[PATCH 1/3] tty: Address checkpatch warnings in goldfish.c

2018-07-17 Thread rkir
From: Roman Kiryanov To make further maintenance easier. Signed-off-by: Roman Kiryanov --- drivers/tty/goldfish.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c index 37caba7c3aff..a92fcb2b0002 100644 ---

<    1   2   3