Re: [PATCH] [v2] Input: Add "Share" button to Microsoft Xbox One controller.

2021-03-04 Thread Roderick Colenbrander
, Roderick On Thu, Mar 4, 2021 at 6:25 PM Chris Ye wrote: > > Hi Bastien, just want to follow up again on this. I've checked again > with the Xbox team that the "Share button" is given for the product, > the HID usage profile and mapping to RECORD is what Xbox team expects &g

Re: [PATCH] HID: sony: Fix for broken buttons on DS3 USB dongles

2020-05-13 Thread Colenbrander, Roderick
altogether and e.g. have a "sony_register_gamepad" and do it all ourselves and put more logic into the sixaxis_parse_report call. With many buggy devices of which we don't have most it feels fragile to have the HID parser do the work. Thanks, Roderick From: Scott Shumate Sent: Wedn

Re: [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-05-11 Thread Roderick Colenbrander
On Fri, May 10, 2019 at 1:57 AM Bastien Nocera wrote: > > On Sun, 2019-04-14 at 09:26 -0700, Roderick Colenbrander wrote: > > > > > We at the time were one of the first to expose acceleration and gyro > > data through /dev/input for DualShock 4 as supported

Re: [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-04-14 Thread Roderick Colenbrander
Android work as well, I will jump in more from the sidelines to make sure things are done in a consistent manner. The main concern are resolution and value ranges. Thanks, Roderick On Sun, Apr 14, 2019 at 4:41 AM Jonathan Cameron wrote: > > On Mon, 8 Apr 2019 15:15:56 +0200 > H. Nikolaus

Re: NULL pointer dereference when writing fuzzed data to /dev/uhid

2019-01-04 Thread Roderick Colenbrander
a bunch of data structures on the HID device. The code probably makes some assumptions. Fixing this issue requires some more sanity checking, if it is worth it. Thanks, Roderick On Fri, Jan 4, 2019 at 9:04 AM Anatoly Trosinenko wrote: > > > Would you be able to share the sony.bin fil

Re: NULL pointer dereference when writing fuzzed data to /dev/uhid

2019-01-04 Thread Roderick Colenbrander
01/2014 > > [ 16.935372] Workqueue: events uhid_device_add_worker > > [ 16.936321] RIP: 0010:hid_validate_values+0x48/0x110 > > In a sense, it's good to have a fault there because this was added to > make sure we do not blindly accept any data. The fact that it doesn't >

Re: [PATCH] HID: Add support for 146b:0902 Bigben Interactive Kids' gamepad

2018-05-28 Thread Roderick Colenbrander
remap buttons as well. I suspect the current button mapping is all over the place as well. Make sure axis and button mapping complies to the Linux gamepad spec (see Documentation/input/gamepad.rst). Thanks, Roderick On Wed, May 23, 2018 at 8:57 AM, Hanno Zulla wrote: > Hello, > > this is

Re: [PATCH] HID: Add support for 146b:0902 Bigben Interactive Kids' gamepad

2018-05-28 Thread Roderick Colenbrander
remap buttons as well. I suspect the current button mapping is all over the place as well. Make sure axis and button mapping complies to the Linux gamepad spec (see Documentation/input/gamepad.rst). Thanks, Roderick On Wed, May 23, 2018 at 8:57 AM, Hanno Zulla wrote: > Hello, > > this is

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-11-07 Thread Roderick Colenbrander
On Thu, Sep 29, 2016 at 12:25 AM, Benjamin Tissoires <benjamin.tissoi...@redhat.com> wrote: > > On Sep 28 2016 or thereabouts, Roderick Colenbrander wrote: > > On Wed, Sep 28, 2016 at 10:39 AM, Dmitry Torokhov > > <dmitry.torok...@gmail.com> wrote: > > >

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-11-07 Thread Roderick Colenbrander
On Thu, Sep 29, 2016 at 12:25 AM, Benjamin Tissoires wrote: > > On Sep 28 2016 or thereabouts, Roderick Colenbrander wrote: > > On Wed, Sep 28, 2016 at 10:39 AM, Dmitry Torokhov > > wrote: > > > > > > On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-29 Thread Roderick Colenbrander
On Thu, Sep 29, 2016 at 1:55 AM, <ji...@jic23.retrosnub.co.uk> wrote: > On 28.09.2016 18:39, Dmitry Torokhov wrote: >> >> On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander >> <roder...@gaikai.com> wrote: >>> >>> From: Roderick Colenbrander

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-29 Thread Roderick Colenbrander
On Thu, Sep 29, 2016 at 1:55 AM, wrote: > On 28.09.2016 18:39, Dmitry Torokhov wrote: >> >> On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander >> wrote: >>> >>> From: Roderick Colenbrander >>> >>> This patch introduces new axes fo

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-28 Thread Roderick Colenbrander
On Wed, Sep 28, 2016 at 10:39 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > > On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander > <roder...@gaikai.com> wrote: > > From: Roderick Colenbrander <roderick.colenbran...@sony.com> > > > > Th

Re: [PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-28 Thread Roderick Colenbrander
On Wed, Sep 28, 2016 at 10:39 AM, Dmitry Torokhov wrote: > > On Tue, Sep 27, 2016 at 4:38 PM, Roderick Colenbrander > wrote: > > From: Roderick Colenbrander > > > > This patch introduces new axes for acceleration and angular velocity. > > David Herrmann's work

[PATCH 1/2] Input: introduce ABS_MAX2/CNT2 and friends

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander <roderick.colenbran...@sony.com> David Herrmann's original patch was ported over to a modern Linux kernel. In the process, we went over all the feedback to the original patch series and added various improvements: - evdev_handle_get_abs2 returns valid_cnt instea

[PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander <roderick.colenbran...@sony.com> This patch introduces new axes for acceleration and angular velocity. David Herrmann's work served as a base, but we extended the specification with various changes inspired by real devices and challenges we see when doing

[PATCH 1/2] Input: introduce ABS_MAX2/CNT2 and friends

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander David Herrmann's original patch was ported over to a modern Linux kernel. In the process, we went over all the feedback to the original patch series and added various improvements: - evdev_handle_get_abs2 returns valid_cnt instead of 0 when succesfull - Updated

[PATCH 2/2] Input: add motion-tracking ABS_* bits and docs

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander This patch introduces new axes for acceleration and angular velocity. David Herrmann's work served as a base, but we extended the specification with various changes inspired by real devices and challenges we see when doing motion tracking. - Changed unit

[PATCH 0/2] Input: ABS2 and motion tracking

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander <roderick.colenbran...@sony.com> For some input driver work we have been doing, we were limited by not having a wide enough ABS range in evdev. The current ABS range is mostly full and due to limitations on the ioctl design, it can't be extended. About 3 yea

[PATCH 0/2] Input: ABS2 and motion tracking

2016-09-27 Thread Roderick Colenbrander
From: Roderick Colenbrander For some input driver work we have been doing, we were limited by not having a wide enough ABS range in evdev. The current ABS range is mostly full and due to limitations on the ioctl design, it can't be extended. About 3 years ago, David Herrmann did work

[PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-05-18 Thread Roderick Colenbrander
issue. Signed-off-by: Roderick Colenbrander <roderick.colenbran...@sony.com> Cc: sta...@vger.kernel.org --- drivers/hid/uhid.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 16b6f11..9

[PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-05-18 Thread Roderick Colenbrander
issue. Signed-off-by: Roderick Colenbrander Cc: sta...@vger.kernel.org --- drivers/hid/uhid.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c index 16b6f11..99ec3ff 100644 --- a/drivers/hid/uhid.c +++ b

[PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations v2

2016-04-21 Thread roderick
From: Roderick Colenbrander <roderick.colenbran...@sony.com> Many devices use userspace bluetooth stacks like BlueZ or Bluedroid in combination with uhid. If any of these stacks is used with a HID device for which the driver performs a HID request as part .probe (or technically anoth

[PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations v2

2016-04-21 Thread roderick
From: Roderick Colenbrander Many devices use userspace bluetooth stacks like BlueZ or Bluedroid in combination with uhid. If any of these stacks is used with a HID device for which the driver performs a HID request as part .probe (or technically another HID operation), this results

Re: [PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-04-21 Thread Roderick Colenbrander
your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: > https://github.com/0day-ci/linux/commits/roderick-gaikai-com/HID-uhid-Fixes-a-bug-with-userspace-bluetooth-stacks-which-causes-hangs-during-certain-operations/20160422-050505

Re: [PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-04-21 Thread Roderick Colenbrander
o the wrong git tree, please drop us a note to > help improving the system] > > url: > https://github.com/0day-ci/linux/commits/roderick-gaikai-com/HID-uhid-Fixes-a-bug-with-userspace-bluetooth-stacks-which-causes-hangs-during-certain-operations/20160422-050505 > base: https:

[PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-04-21 Thread roderick
From: Roderick Colenbrander <roderick.colenbran...@sony.com> Many devices use userspace bluetooth stacks like BlueZ or Bluedroid in combination with uhid. If any of these stacks is used with a HID device for which the driver performs a HID request as part .probe (or technically anoth

[PATCH] HID: uhid: Fixes a bug with userspace bluetooth stacks, which causes hangs during certain operations

2016-04-21 Thread roderick
From: Roderick Colenbrander Many devices use userspace bluetooth stacks like BlueZ or Bluedroid in combination with uhid. If any of these stacks is used with a HID device for which the driver performs a HID request as part .probe (or technically another HID operation), this results