in file ./drivers/net/forcedeth.c
line 2142 of current git I have a
for (i=0;i=np-register_size;i+= 32) {
^
shouldn't this be a ''
In the same file on line 4015:
for (i = 0;i = np-register_size/sizeof(u32); i++)
shouldn't the = be a ''?
Roel
-
To unsubscribe from this list: send
without this return statement (and the brackets) since rc is
returned anyway...
+ } else {
+ printk(KERN_INFO No iBFT detected.\n);
+ }
these brackets are not required either
+ return rc;
... here
+}
[...]
Roel
-
To unsubscribe from this list: send the line
Matthew Wilcox wrote:
Check that 'align' is a power of two, like the API specifies.
Align 'size' to 'align' correctly -- the current code has an off-by-one.
The ALIGN macro in kernel.h doesn't.
Signed-off-by: Matthew Wilcox [EMAIL PROTECTED]
---
mm/dmapool.c | 15 ---
1
Matthew Wilcox wrote:
[...]
@@ -113,9 +133,12 @@ struct dma_pool *dma_pool_create(const char *name,
struct device *dev,
return NULL;
}
- if (size == 0)
+ if (size == 0) {
return NULL;
-
+ } else if (size 4) {
+ size = 4;
+
Matthew Wilcox wrote:
[...]
@@ -142,14 +144,13 @@ struct dma_pool *dma_pool_create(const char *name,
struct device *dev,
if ((size % align) != 0)
size = ALIGN(size, align);
- if (allocation == 0) {
- if (PAGE_SIZE size)
-
Guillaume Chazarain wrote:
[...]
@@ -65,13 +65,15 @@ void bacct_add_tsk(struct taskstats *stats, struct
task_struct *tsk)
void bacct_fill_threadgroup(struct taskstats *stats, struct task_struct *tsk,
bool tg_stats)
{
+ int group_exit_code;
+
Matthew Wilcox wrote:
On Wed, Sep 26, 2007 at 09:47:41PM +0200, roel wrote:
The brackets in the first if/else are not required, and you could combine
the two statements:
You mean braces, not brackets. And I find this little fetish of yours
highly disturbing. I prefer to use braces
Erez Zadok wrote:
Signed-off-by: Erez Zadok [EMAIL PROTECTED]
---
fs/unionfs/debug.c | 108 +++
1 files changed, 57 insertions(+), 51 deletions(-)
diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c
index 9546a41..09b52ce 100644
---
Erez Zadok wrote:
@@ -194,7 +194,7 @@ int check_empty(struct dentry *dentry, struct
unionfs_dir_state **namelist)
BUG_ON(!S_ISDIR(dentry-d_inode-i_mode));
- if ((err = unionfs_partial_lookup(dentry)))
+ if (unlikely((err = unionfs_partial_lookup(dentry
Dave Jones wrote:
> to add a single line reply>
Ok, sorry, I don't know these rules
> On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote:
>
> > > --- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c
> > > +++ b/arch/i386/kernel/cpu/cpufreq/powernow-k6.c
>
Davide Libenzi wrote:
> On Tue, 25 Sep 2007, roel wrote:
>
>>> + if (!(ap->flags & ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
>> if (!((ap->flags & ATA_FLAG_IPM) && ata_dev_enabled(dev))) {
>
> int foo(int i, int j) {
>
>
Srivatsa Vaddagiri wrote:
> Enable user-id based fair group scheduling. This is usefull for anyone
> who wants to test the group scheduler w/o having to enable
> CONFIG_CGROUPS.
>
> A separate scheduling group (i.e struct task_grp) is automatically created
> for
> every new user added to the
Kristen Carlson Accardi wrote:
> Device Initiated Power Management, which is defined
> in SATA 2.5 can be enabled for disks which support it.
> This patch enables DIPM when the user sets the link
> power management policy to "min_power".
>
> Additionally, libata drivers can define a function
>
Davide Libenzi wrote:
> This is the new timerfd API as it is implemented by the following patch:
>
> int timerfd_create(int clockid);
> int timerfd_settime(int ufd, int flags,
> const struct itimerspec *utmr,
> struct itimerspec *otmr);
> int
I could only point to three nitpicks
Randy Dunlap wrote:
> This is RFC patch 2/2.
> Patch 1/2 introduces the samples/ infrastructure:
> http://lkml.org/lkml/2007/9/24/397
>
>
> ---
>
> From: Randy Dunlap <[EMAIL PROTECTED]>
>
> Move kprobes source files from Documentation/kprobes.txt to
>
can't we also decrease the number of brackets here?
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1021,7 +1021,7 @@ int ipv6_dev_get_saddr(struct net_device
hiscore.rule++;
}
if
[EMAIL PROTECTED] wrote:
> v3: fix compile errors in arch-i386-allmodconfig build
>
> v2: rebasing on 2.6.23-rc6-mm1
>
> cpu_data is currently an array defined using NR_CPUS. This means that
> we overallocate since we will rarely really use maximum configured cpus.
> When NR_CPU count is raised
[EMAIL PROTECTED] wrote:
v3: fix compile errors in arch-i386-allmodconfig build
v2: rebasing on 2.6.23-rc6-mm1
cpu_data is currently an array defined using NR_CPUS. This means that
we overallocate since we will rarely really use maximum configured cpus.
When NR_CPU count is raised to 4096
can't we also decrease the number of brackets here?
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -1021,7 +1021,7 @@ int ipv6_dev_get_saddr(struct net_device
hiscore.rule++;
}
if
I could only point to three nitpicks
Randy Dunlap wrote:
This is RFC patch 2/2.
Patch 1/2 introduces the samples/ infrastructure:
http://lkml.org/lkml/2007/9/24/397
---
From: Randy Dunlap [EMAIL PROTECTED]
Move kprobes source files from Documentation/kprobes.txt to
Davide Libenzi wrote:
This is the new timerfd API as it is implemented by the following patch:
int timerfd_create(int clockid);
int timerfd_settime(int ufd, int flags,
const struct itimerspec *utmr,
struct itimerspec *otmr);
int timerfd_gettime(int ufd,
Kristen Carlson Accardi wrote:
Device Initiated Power Management, which is defined
in SATA 2.5 can be enabled for disks which support it.
This patch enables DIPM when the user sets the link
power management policy to min_power.
Additionally, libata drivers can define a function
Srivatsa Vaddagiri wrote:
Enable user-id based fair group scheduling. This is usefull for anyone
who wants to test the group scheduler w/o having to enable
CONFIG_CGROUPS.
A separate scheduling group (i.e struct task_grp) is automatically created
for
every new user added to the system.
Davide Libenzi wrote:
On Tue, 25 Sep 2007, roel wrote:
+ if (!(ap-flags ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
if (!((ap-flags ATA_FLAG_IPM) ata_dev_enabled(dev))) {
int foo(int i, int j) {
return !(i 8) || !j;
}
int moo(int i, int j
Dave Jones wrote:
excessive quoting trimmed, please don't quote 40K of text
to add a single line reply
Ok, sorry, I don't know these rules
On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote:
--- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c
+++ b/arch/i386/kernel/cpu/cpufreq
WANG Cong wrote:
> This patch does the following things:
>
> - Make hidp_setup_input() return int to indicate errors.
> - Check its return value to handle errors.
>
> Signed-off-by: WANG Cong <[EMAIL PROTECTED]>
>
> ---
> net/bluetooth/hidp/core.c |7 ---
> 1 file changed, 4
WANG Cong wrote:
This patch does the following things:
- Make hidp_setup_input() return int to indicate errors.
- Check its return value to handle errors.
Signed-off-by: WANG Cong [EMAIL PROTECTED]
---
net/bluetooth/hidp/core.c |7 ---
1 file changed, 4 insertions(+), 3
Andreas Herrmann wrote:
> Fix compile error if !CONFIG_SYSCTL:
>
> ...
> LD .tmp_vmlinux1
> net/built-in.o: In function `init_p9':
> net/9p/mod.c:59: undefined reference to `p9_sysctl_register'
> net/built-in.o: In function `exit_p9':
> net/9p/mod.c:75: undefined reference to
Andreas Herrmann wrote:
Fix compile error if !CONFIG_SYSCTL:
...
LD .tmp_vmlinux1
net/built-in.o: In function `init_p9':
net/9p/mod.c:59: undefined reference to `p9_sysctl_register'
net/built-in.o: In function `exit_p9':
net/9p/mod.c:75: undefined reference to
Hello All,
I am seeing the exact same 'problem'. I have 4 WDC WD2500KS-00MJB0
drives connected to a promise SATA300 TX4. The messages have been
flooding syslog since the drives were installed. Running 2.6.18 or
2.6.19 vanilla kernels.
Best regards,
Roel Teuwen
On 10/25/06, Gregory Brauer
Hello All,
I am seeing the exact same 'problem'. I have 4 WDC WD2500KS-00MJB0
drives connected to a promise SATA300 TX4. The messages have been
flooding syslog since the drives were installed. Running 2.6.18 or
2.6.19 vanilla kernels.
Best regards,
Roel Teuwen
On 10/25/06, Gregory Brauer
these errors, but I do know they appear
in -ac24 only, relatively quickly.
Hope this helps,
kind regards,
Roel Teuwen
Jul 7 14:55:43 Terra kernel: invalid operand:
Jul 7 14:55:43 Terra kernel: CPU:0
Jul 7 14:55:43 Terra kernel: EIP:0010:[deactivate_page_nolock+144/240]
Jul 7 14:55
these errors, but I do know they appear
in -ac24 only, relatively quickly.
Hope this helps,
kind regards,
Roel Teuwen
Jul 7 14:55:43 Terra kernel: invalid operand:
Jul 7 14:55:43 Terra kernel: CPU:0
Jul 7 14:55:43 Terra kernel: EIP:0010:[deactivate_page_nolock+144/240]
Jul 7 14:55
, the machine boots fine.
Attached is my .config and the decoded oops
If any more information is needed, do not hesitate to contact me.
kind regards,
Roel
Oops:
CPU: 0
EIP: 0010:[]
Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010086
eax: ebx: c025ccd8 ecx:
, the machine boots fine.
Attached is my .config and the decoded oops
If any more information is needed, do not hesitate to contact me.
kind regards,
Roel
Oops:
CPU: 0
EIP: 0010:[c0204004]
Using defaults from ksymoops -t elf32-i386 -a i386
EFLAGS: 00010086
eax: ebx: c025ccd8 ecx
301 - 335 of 335 matches
Mail list logo
