Re: VDPA Debug/Statistics

2020-08-11 Thread Roopa Prabhu
On 8/11/20 5:44 AM, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Tue, Aug 11, 2020 at 11:58:23AM +, Eli Cohen wrote: On Tue, Aug 11, 2020 at 11:26:20AM +, Eli Cohen wrote: Hi All Currently, the only statistics we get for a VDPA instance come

Re: [RFC PATCH] Don't copy mark from encapsulated packet when routing VXLAN

2019-10-01 Thread Roopa Prabhu
On Sun, Sep 29, 2019 at 11:27 PM Jethro Beekman wrote: > > When using rule-based routing to send traffic via VXLAN, a routing > loop may occur. Say you have the following routing setup: > > ip rule add from all fwmark 0x2/0x2 lookup 2 > ip route add table 2 default via 10.244.2.0 dev vxlan1 onlink

Re: [PATCH] trace: events: fix error directive in argument list

2019-03-30 Thread Roopa Prabhu
On Sat, Mar 30, 2019 at 5:40 AM Steven Rostedt wrote: > > On Sat, 30 Mar 2019 13:01:41 +0100 > Luc Van Oostenryck wrote: > > > OK, I see. IMO, it would be better to have 2 patches for this: > > one for the redundant assignment to pin6 and anotther one for > > the IS_ENABLED() change but feel free

Re: [PATCH] trace: events: fix error directive in argument list

2019-03-26 Thread Roopa Prabhu
On Mon, Mar 25, 2019 at 1:11 PM Steven Rostedt wrote: > > On Tue, 26 Mar 2019 01:23:03 +0530 > Hariprasad Kelam wrote: > > > > --- > > include/trace/events/neigh.h | 19 +-- > > 1 file changed, 5 insertions(+), 14 deletions(-) > > > > diff --git a/include/trace/events/neigh.h b/i

Re: [PATCH] trace: events: fix error directive in argument list

2019-03-26 Thread Roopa Prabhu
if (n->tbl->family == AF_INET6) { > to if (IS_ENABLED(CONFIG_IPV6) && n->tbl->family == AF_INET6) > > and removes reassigning pin6 pointer when IPV6 is enabled > > Signed-off-by: Hariprasad Kelam Acked-by: Roopa Prabhu Thanks!

Re: [PATCH][next] neighbour: remove stray semicolon

2018-12-20 Thread Roopa Prabhu
ression result unused > [-Wunused-value] > > Fixes: 82cbb5c631a0 ("neighbour: register rtnl doit handler") > Signed-off-by: Colin Ian King Acked-By: Roopa Prabhu Thanks!. > --- > net/core/neighbour.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [net-next regression] kselftest failure in fib_nl_newrule()

2018-04-24 Thread Roopa Prabhu
On Tue, Apr 24, 2018 at 2:46 AM, Anders Roxell wrote: > Hi, > > fib-onlink-tests.sh (from kselftest) found a regression between > next-20180424 [1] (worked with tag next-20180423 [2]) > > here is tree commits that look suspicious specially this patch (sha: > f9d4b0c1e969) > rewrites fib_nl_newrule

Re: [RFC PATCH 0/9] ethtool netlink interface (WiP)

2017-12-12 Thread Roopa Prabhu
On Mon, Dec 11, 2017 at 5:53 AM, Michal Kubecek wrote: > This is still work in progress and only a very small part of the ioctl > interface is reimplemented but I would like to get some comments before > the patchset becomes too big and changing things becomes too tedious. > > The interface used f

Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes

2017-04-16 Thread Roopa Prabhu
On 4/16/17, 8:03 AM, Matthias Schiffer wrote: > On 04/14/2017 07:36 PM, Stephen Hemminger wrote: >> On Fri, 14 Apr 2017 18:44:44 +0200 >> Matthias Schiffer wrote: >> >>> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c >>> index 07f89b037681..95a71546e8f2 100644 >>> --- a/drivers/net/vxlan.c

Re: [PATCH] ipv6: fix ifnullfree.cocci warnings

2015-09-09 Thread roopa
some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Roopa Prabhu Signed-off-by: Fengguang Wu FWIW, Acked

Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread roopa
x and multicast_router attributes can be changed even if the according bridge (port) is down, just like other other bridge (port) attributes allow too. Signed-off-by: Linus Lüssing --- Changelog: * [RFC PATCH net-next] -> [PATCH net-next] Acked-by: Roopa Prabhu we have a similar patch

Re: [PATCH net 1/2] ipv6: do not delete previously existing ECMP routes if add fails

2015-05-13 Thread roopa
On 5/13/15, 5:49 AM, Michal Kubecek wrote: On Wed, May 13, 2015 at 02:28:57PM +0200, Nicolas Dichtel wrote: Le 13/05/2015 11:50, Michal Kubecek a écrit : If adding a nexthop of an IPv6 multipath route fails, comment in ip6_route_multipath() says we are going to delete all nexthops already added

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-19 Thread Roopa Prabhu
:14:57AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 05:18, Roopa Prabhu wrote: On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: We also need an interface to set per-switch attributes. Can this work? bridge link set dev sw0 sw_attr bcast_flooding 1 master where sw0 is a bridge

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: On 12/18/2014 3:07 PM, Roopa Prabhu wrote: On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: On 12/18/14, 10:02 AM, Varlese, Marco wrote: Removed unnecessary content for ease of reading... +/* Switch

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: On 12/18/14, 10:02 AM, Varlese, Marco wrote: Removed unnecessary content for ease of reading... +/* Switch Port Attributes section */ + +enum { +IFLA_ATTR_UNSPEC, +IFLA_ATTR_LEARNING, Any reason

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
if you use 'self' and ndo_bridge_setlink/getlink. Roopa, one of the comments I got from Thomas Graf on my v1 patch was that your patch and mine were supplementary ("I think Roopa's patches are supplementary. Not all switchdev users will be backed with a Linux Bridge. I therefo

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 9:25 AM, Varlese, Marco wrote: -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev- ow...@vger.kernel.org] On Behalf Of Roopa Prabhu Sent: Thursday, December 18, 2014 3:16 PM To: Varlese, Marco Cc: net...@vger.kernel.org; Fastabend, John R; Thomas Graf; Jiri

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 6:55 AM, Varlese, Marco wrote: -Original Message- From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] Sent: Thursday, December 18, 2014 2:45 PM To: Varlese, Marco Cc: net...@vger.kernel.org; Fastabend, John R; Thomas Graf; Jiri Pirko; sfel...@gmail.com; linux-kernel

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

2014-12-18 Thread Roopa Prabhu
On 12/18/14, 3:29 AM, Varlese, Marco wrote: From: Marco Varlese Switch hardware offers a list of attributes that are configurable on a per port basis. This patch provides a mechanism to configure switch ports by adding an NDO for setting specific values to specific attributes. There will be a s

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Roopa Prabhu
On 12/15/14, 6:40 AM, Thomas Graf wrote: On 12/15/14 at 02:29pm, Varlese, Marco wrote: All of these are highly generic and should *not* be passed through from user space to the driver directly but rather be properly abstracted as Roopa proposed. The value of this API is abstraction. How would

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-15 Thread Roopa Prabhu
On 12/15/14, 1:39 AM, Varlese, Marco wrote: -Original Message- From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] Sent: Saturday, December 13, 2014 7:06 AM To: Varlese, Marco Cc: Jiri Pirko; John Fastabend; net...@vger.kernel.org; step...@networkplumber.org; Fastabend, John R; sfel

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-12 Thread Roopa Prabhu
On 12/12/14, 1:19 AM, Varlese, Marco wrote: -Original Message- From: Roopa Prabhu [mailto:ro...@cumulusnetworks.com] Sent: Thursday, December 11, 2014 5:41 PM To: Jiri Pirko Cc: Varlese, Marco; John Fastabend; net...@vger.kernel.org; step...@networkplumber.org; Fastabend, John R; sfel

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Roopa Prabhu
ght become handy for other generic non-bridge attrs. Thanks, Roopa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH net-next 1/1] net: Support for switch port configuration

2014-12-11 Thread Roopa Prabhu
getlink): http://www.spinics.net/lists/netdev/msg305473.html Thanks, Roopa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/