On 2021/3/26 17:14, Herbert Xu wrote:
On Fri, Mar 19, 2021 at 03:33:07PM +0800, Yang Shen wrote:
+const struct hisi_zip_sqe_ops hisi_zip_ops_v2 = {
+ .sqe_type = 0x3,
+ .fill_addr = hisi_zip_fill_addr,
+ .fill_buf_size =
On 2020/9/4 15:40, Herbert Xu wrote:
On Wed, Aug 26, 2020 at 04:56:40PM +0800, shenyang (M) wrote:
@@ -514,13 +514,16 @@ static int hisi_zip_core_debug_init(struct hisi_qm *qm)
struct debugfs_regset32 *regset;
struct dentry *tmp_d;
char buf[HZIP_BUF_SIZE
any comment?
Thanks,
Yang
On 2020/8/24 11:11, Yang Shen wrote:
This patchset make some clean up:
patch 1:remove useless parameters
patch 4:replace 'sprintf' with 'scnprintf'
patch 7:fix static check warning
and the rest patch fix some coding style
Resend this patch series because it depends
On 2020/8/24 16:29, David Laight wrote:
From: Yang Shen
Sent: 24 August 2020 04:12
Replace 'sprintf' with 'scnprintf' to avoid overrun.
Signed-off-by: Yang Shen
Reviewed-by: Zhou Wang
---
drivers/crypto/hisilicon/zip/zip_main.c | 11 +++
1 file changed, 7 insertions(+), 4
On 2020/8/6 15:23, Markus Elfring wrote:
Would you become interested to look if any other software components
would be similarly affected?
Yeah, I'll check the rest and fix if any and send those in a
clean up patch.
Thanks,
Yang
On 2020/8/5 14:04, Markus Elfring wrote:
Thanks for your review. There is only one error branch need to do
something uninit. So I think the jump is not necessary and will
affect code reading.:)
How does this concern fit to the Linux coding style?
On 2020/8/5 2:34, Markus Elfring wrote:
…
+++ b/drivers/crypto/hisilicon/qm.c
@@ -1420,16 +1420,17 @@ static int qm_dbg_help(struct hisi_qm *qm, char *s)
…
+ s_tmp = s;
presult = strsep(, " ");
if (!presult) {
- kfree(s);
+ kfree(s_tmp);
On 2020/7/31 16:28, Herbert Xu wrote:
On Sat, Jul 25, 2020 at 02:06:46PM +0800, Yang Shen wrote:
This patchset fix some bug:
patch 1:clear the debug registers when remove driver
patch 2:intercept invalid input when using decompress
patch 3:replace the return value '-EBUSY' with '-EAGAIN'
On 2020/7/31 16:12, Herbert Xu wrote:
On Sat, Jul 25, 2020 at 11:44:36AM +0800, Yang Shen wrote:
From: Shukun Tan
Update debugfs interface parameters
Signed-off-by: Shukun Tan
Signed-off-by: Yang Shen
Reviewed-by: Zhou Wang
---
drivers/crypto/hisilicon/zip/zip_main.c | 55
9 matches
Mail list logo
