Re: [Outreachy kernel] Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

On Tue, Mar 6, 2018 at 2:33 AM, Julia Lawall wrote: > > > On Mon, 5 Mar 2018, Arushi Singhal wrote: > >> >> >> On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter >> wrote: >> On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: >>

Re: [Outreachy kernel] Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited()

On Tue, Mar 6, 2018 at 2:33 AM, Julia Lawall wrote: > > > On Mon, 5 Mar 2018, Arushi Singhal wrote: > >> >> >> On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter >> wrote: >> On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: >> > Replace printk having a log level with the

[PATCH] staging: rtl8192u: ieee80211: Convert printks to pr_

Use the current logging style. Coalesce formats where appropriate. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 34 ++- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rt

[PATCH] staging: rtl8192u: ieee80211: Convert printks to pr_

Use the current logging style. Coalesce formats where appropriate. Signed-off-by: simran singhal --- drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 34 ++- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c

[PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool

This patch changes the type of variable done from int to boolean. As it is been used as a boolean in the function sfw_test_rpc_done(). It also makes the code more readable and bool data type also requires less memory in comparison to int data type. Signed-off-by: simran singhal <singhals

[PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool

This patch changes the type of variable done from int to boolean. As it is been used as a boolean in the function sfw_test_rpc_done(). It also makes the code more readable and bool data type also requires less memory in comparison to int data type. Signed-off-by: simran singhal --- drivers

[PATCH] staging: rtl8723bs: hal: Use (true/false) in assignment to bool

This patch assigns (true/false) to boolean EDCCA_State instead of (1/0). And, there is no need of comparing EDCCA_State explicitly with constant 1. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/staging/rtl8723bs/hal/odm_DIG.c | 8 1 file changed, 4 inse

[PATCH] staging: rtl8723bs: hal: Use (true/false) in assignment to bool

This patch assigns (true/false) to boolean EDCCA_State instead of (1/0). And, there is no need of comparing EDCCA_State explicitly with constant 1. Signed-off-by: simran singhal --- drivers/staging/rtl8723bs/hal/odm_DIG.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] staging: sm750fb: Remove typedefs from _logical_chip_type_t and _clock_type_t

This patch removes typedefs from enum _logical_chip_type_t and enum _clock_type_t and rename them to logical_chip_type_t and clock_type_t respectively. Fix checkpatch warning: WARNING: do not add new typedefs Signed-off-by: Simran Singhal <singhalsimr...@gmail.com> --- drivers/staging/s

[PATCH] staging: sm750fb: Remove typedefs from _logical_chip_type_t and _clock_type_t

This patch removes typedefs from enum _logical_chip_type_t and enum _clock_type_t and rename them to logical_chip_type_t and clock_type_t respectively. Fix checkpatch warning: WARNING: do not add new typedefs Signed-off-by: Simran Singhal --- drivers/staging/sm750fb/ddk750_chip.c | 4

[PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/pressure/zpa2326.c | 4 ++-- 1 file c

[PATCH] iio: pressure: zpa2326: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/iio/pressure/zpa2326.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deleti

[PATCH] iio: imu: st_lsm6dsx: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 4 ++-

[PATCH] iio: imu: st_lsm6dsx: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 4 ++-- 1 file changed, 2 inserti

[PATCH] iio: humidity: hts221_buffer: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/humidity/hts221_buffer.c | 2 +- 1 file c

[PATCH] iio: humidity: hts221_buffer: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/iio/humidity/hts221_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH] iio: dac: ad5504: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/dac/ad5504.c | 2 +- 1 file changed, 1

[PATCH] iio: dac: ad5504: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/iio/dac/ad5504.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH] iio: common: ms_sensors: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 4 ++-

[PATCH] iio: common: ms_sensors: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/iio/common/ms_sensors/ms_sensors_i2c.c | 4 ++-- 1 file changed, 2 inserti

[PATCH] iio: adc: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/adc/exynos_adc.c | 2 +- driver

[PATCH] iio: adc: Remove unnecessary cast on void pointer

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/iio/adc/exynos_adc.c | 2 +- drivers/iio/adc/imx7d_adc.c

[PATCH] net: ipv4: netfilter: Remove unused function nf_nat_need_gre()

The function nf_nat_need_gre() on being called, simply returns back. The function doesn't have FIXME code around. Hence, nf_nat_need_gre() and its calls have been removed. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- net/ipv4/netfilter/nf_nat_pptp.c | 2 -- ne

[PATCH] net: ipv4: netfilter: Remove unused function nf_nat_need_gre()

The function nf_nat_need_gre() on being called, simply returns back. The function doesn't have FIXME code around. Hence, nf_nat_need_gre() and its calls have been removed. Signed-off-by: simran singhal --- net/ipv4/netfilter/nf_nat_pptp.c | 2 -- net/ipv4/netfilter/nf_nat_proto_gre.c | 6

[PATCH] iio: proximity: as3935: constify attribute_group structures

4101 256 043571105 drivers/iio/proximity/as3935.o Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/proximity/as3935.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c

[PATCH] iio: proximity: as3935: constify attribute_group structures

4101 256 043571105 drivers/iio/proximity/as3935.o Signed-off-by: simran singhal --- drivers/iio/proximity/as3935.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/proximity/as3935.c b/drivers/iio/proximity/as3935.c index 5656deb..1b8b472 100644

[PATCH] iio: light: bh1750: constify attribute_group structures

320 02660 a64 drivers/iio/light/bh1750.o Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/light/bh1750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c index b059466..6

[PATCH] iio: light: bh1750: constify attribute_group structures

320 02660 a64 drivers/iio/light/bh1750.o Signed-off-by: simran singhal --- drivers/iio/light/bh1750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c index b059466..6c61187 100644 --- a/drivers/iio

[PATCH] iio: light: apds9960: constify attribute_group structures

8567 424 08991231f drivers/iio/light/apds9960.o Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/light/apds9960.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c index 9

[PATCH] iio: light: apds9960: constify attribute_group structures

8567 424 08991231f drivers/iio/light/apds9960.o Signed-off-by: simran singhal --- drivers/iio/light/apds9960.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c index 90bc98d..c7af36d 100644

[PATCH] iio: humidity: hdc100x: constify attribute_group structures

3507 424 03931 f5b drivers/iio/humidity/hdc100x.o Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/humidity/hdc100x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c

[PATCH] iio: humidity: hdc100x: constify attribute_group structures

3507 424 03931 f5b drivers/iio/humidity/hdc100x.o Signed-off-by: simran singhal --- drivers/iio/humidity/hdc100x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c index 265c34d..aa17115 100644

[PATCH] iio: adc: hx711: constify attribute_group structures

416 03514 dba drivers/iio/adc/hx711.o Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/adc/hx711.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c index 139639f..27005d8

[PATCH] iio: adc: hx711: constify attribute_group structures

416 03514 dba drivers/iio/adc/hx711.o Signed-off-by: simran singhal --- drivers/iio/adc/hx711.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c index 139639f..27005d8 100644 --- a/drivers/iio/adc/hx711.c +++ b

[PATCH] staging: iio: light: constify attribute_group structures

: textdata bss dec hex filename 151921400 0 1659240d0 drivers/staging/iio/light/tsl2x7x_core.o Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/staging/iio/light/tsl2x7x_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] staging: iio: light: constify attribute_group structures

: textdata bss dec hex filename 151921400 0 1659240d0 drivers/staging/iio/light/tsl2x7x_core.o Signed-off-by: simran singhal --- drivers/staging/iio/light/tsl2x7x_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/light

Re: [PATCH 1/3] iio: health: afe440x: Remove code in comments

Please ignore this Patch. This Patch is wrong. On Sat, Apr 1, 2017 at 12:20 AM, Joe Perches <j...@perches.com> wrote: > On Sat, 2017-04-01 at 00:13 +0530, SIMRAN SINGHAL wrote: >> On Sat, Apr 1, 2017 at 12:03 AM, Joe Perches <j...@perches.com> wrote: >> > On Fri, 201

Re: [PATCH 1/3] iio: health: afe440x: Remove code in comments

Please ignore this Patch. This Patch is wrong. On Sat, Apr 1, 2017 at 12:20 AM, Joe Perches wrote: > On Sat, 2017-04-01 at 00:13 +0530, SIMRAN SINGHAL wrote: >> On Sat, Apr 1, 2017 at 12:03 AM, Joe Perches wrote: >> > On Fri, 2017-03-31 at 22:16 +0530, simran singhal wrote:

Re: [PATCH 0/3] iio: health: Clean up

Please ignore this Patch. As this patch is completely wrong due to my lack of understanding. On Fri, Mar 31, 2017 at 10:16 PM, simran singhal <singhalsimr...@gmail.com> wrote: > This patch-series removes commented code in afe440x.h and > removes unused functions in afe4404.c a

Re: [PATCH 0/3] iio: health: Clean up

Please ignore this Patch. As this patch is completely wrong due to my lack of understanding. On Fri, Mar 31, 2017 at 10:16 PM, simran singhal wrote: > This patch-series removes commented code in afe440x.h and > removes unused functions in afe4404.c and afe4403.c. > > simran singhal

Re: [PATCH 1/3] iio: health: afe440x: Remove code in comments

On Sat, Apr 1, 2017 at 12:03 AM, Joe Perches <j...@perches.com> wrote: > On Fri, 2017-03-31 at 22:16 +0530, simran singhal wrote: >> Commenting out code is a bad idea. >> As comments are for explaining what code is about. > > patch doesn't match commit message. In

Re: [PATCH 1/3] iio: health: afe440x: Remove code in comments

On Sat, Apr 1, 2017 at 12:03 AM, Joe Perches wrote: > On Fri, 2017-03-31 at 22:16 +0530, simran singhal wrote: >> Commenting out code is a bad idea. >> As comments are for explaining what code is about. > > patch doesn't match commit message. In commit message I am clearly

[PATCH 1/3] iio: health: afe440x: Remove code in comments

Commenting out code is a bad idea. As comments are for explaining what code is about. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/health/afe440x.h | 58 1 file changed, 58 deletions(-) diff --git a/drivers/iio/

[PATCH 1/3] iio: health: afe440x: Remove code in comments

Commenting out code is a bad idea. As comments are for explaining what code is about. Signed-off-by: simran singhal --- drivers/iio/health/afe440x.h | 58 1 file changed, 58 deletions(-) diff --git a/drivers/iio/health/afe440x.h b/drivers/iio/health

[PATCH 2/3] iio: health: afe4404: Remove all unused functions

The functions afe440x_show_register and afe440x_store_register are never used anywhere in the kernel. So, remove their definitions. Grepped to find occurences. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/health/afe4404.

[PATCH 3/3] iio: health: afe4403: Remove all unused functions

The functions afe440x_show_register and afe440x_store_register are never used anywhere in the kernel. So, remove their definitions. Grepped to find occurences. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/health/afe4403.

[PATCH 2/3] iio: health: afe4404: Remove all unused functions

The functions afe440x_show_register and afe440x_store_register are never used anywhere in the kernel. So, remove their definitions. Grepped to find occurences. Signed-off-by: simran singhal --- drivers/iio/health/afe4404.c | 51 1 file changed, 51

[PATCH 3/3] iio: health: afe4403: Remove all unused functions

The functions afe440x_show_register and afe440x_store_register are never used anywhere in the kernel. So, remove their definitions. Grepped to find occurences. Signed-off-by: simran singhal --- drivers/iio/health/afe4403.c | 51 1 file changed, 51

[PATCH 0/3] iio: health: Clean up

This patch-series removes commented code in afe440x.h and removes unused functions in afe4404.c and afe4403.c. simran singhal (3): iio: health: afe440x: Remove code in comments iio: health: afe4404: Remove all unused functions iio: health: afe4403: Remove all unused functions drivers/iio

[PATCH 0/3] iio: health: Clean up

This patch-series removes commented code in afe440x.h and removes unused functions in afe4404.c and afe4403.c. simran singhal (3): iio: health: afe440x: Remove code in comments iio: health: afe4404: Remove all unused functions iio: health: afe4403: Remove all unused functions drivers/iio

[PATCH 0/3] staging: iio: Remove useless type conversion

This patch-series removes some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. simran singhal (3): staging: iio: accel: Remove useless type conversion staging: iio: frequency: Remove useless type conver

[PATCH 0/3] staging: iio: Remove useless type conversion

This patch-series removes some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. simran singhal (3): staging: iio: accel: Remove useless type conversion staging: iio: frequency: Remove useless type conver

[PATCH 2/3] staging: iio: frequency: Remove useless type conversion

Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)() + ) Signed-off-by: si

[PATCH 2/3] staging: iio: frequency: Remove useless type conversion

Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)() + ) Signed-off-by: si

[PATCH 3/3] staging: iio: light: Remove useless type conversion

Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)() + ) Signed-off-by: si

[PATCH 3/3] staging: iio: light: Remove useless type conversion

Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)() + ) Signed-off-by: si

[PATCH 1/3] staging: iio: accel: Remove useless type conversion

Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)() + ) Signed-off-by: si

[PATCH 1/3] staging: iio: accel: Remove useless type conversion

Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)() + ) Signed-off-by: si

[PATCH v2] iio: gyro: adis16060: Change the name of function.

Change the name of function from adis16060_spi_write_than_read() to adis16060_spi_write_then_read(). change "than" to "then" as its time depended. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- v2: -Change the subject. -Add signed-off-by.

[PATCH v2] iio: gyro: adis16060: Change the name of function.

Change the name of function from adis16060_spi_write_than_read() to adis16060_spi_write_then_read(). change "than" to "then" as its time depended. Signed-off-by: simran singhal --- v2: -Change the subject. -Add signed-off-by. drivers/staging/iio/gyro/adis16060_cor

Re: [Outreachy kernel] [PATCH v4] staging: iio: ade7753: Replace mlock with driver private lock

On Fri, Mar 31, 2017 at 1:18 AM, Jonathan Cameron <ji...@jic23.retrosnub.co.uk> wrote: > > > On 30 March 2017 19:44:26 BST, SIMRAN SINGHAL <singhalsimr...@gmail.com> > wrote: >>On Fri, Mar 31, 2017 at 12:02 AM, Jonathan Cameron <ji...@kernel.org> >>wrot

Re: [Outreachy kernel] [PATCH v4] staging: iio: ade7753: Replace mlock with driver private lock

On Fri, Mar 31, 2017 at 1:18 AM, Jonathan Cameron wrote: > > > On 30 March 2017 19:44:26 BST, SIMRAN SINGHAL > wrote: >>On Fri, Mar 31, 2017 at 12:02 AM, Jonathan Cameron >>wrote: >>> On 28/03/17 19:37, Alison Schofield wrote: >>>> On Tue, Mar 28, 2

[PATCH] iio: gyro: adis16060: Change the function's name

Change the name of function from adis16060_spi_write_than_read() to adis16060_spi_write_then_read(). change "than" to "then" as its time depended. --- drivers/staging/iio/gyro/adis16060_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] iio: gyro: adis16060: Change the function's name

Change the name of function from adis16060_spi_write_than_read() to adis16060_spi_write_then_read(). change "than" to "then" as its time depended. --- drivers/staging/iio/gyro/adis16060_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Outreachy kernel] [PATCH v4] staging: iio: ade7753: Replace mlock with driver private lock

On Fri, Mar 31, 2017 at 12:02 AM, Jonathan Cameron <ji...@kernel.org> wrote: > On 28/03/17 19:37, Alison Schofield wrote: >> On Tue, Mar 28, 2017 at 10:55:17PM +0530, SIMRAN SINGHAL wrote: >>> On Fri, Mar 24, 2017 at 12:51 AM, Alison Schofield <amsfiel...@gmail.com>

Re: [Outreachy kernel] [PATCH v4] staging: iio: ade7753: Replace mlock with driver private lock

On Fri, Mar 31, 2017 at 12:02 AM, Jonathan Cameron wrote: > On 28/03/17 19:37, Alison Schofield wrote: >> On Tue, Mar 28, 2017 at 10:55:17PM +0530, SIMRAN SINGHAL wrote: >>> On Fri, Mar 24, 2017 at 12:51 AM, Alison Schofield >>> wrote: >>>> On Fri, M

[PATCH v2] iio: light: lm3533-als: constify attribute_group structures

dec hex filename 57982376 081741fee drivers/iio/light/lm3533-als.o File size after: textdata bss dec hex filename 59262248 081741fee drivers/iio/light/lm3533-als.o Signed-off-by: simran singhal <singhalsimr...@gmail.com> -

[PATCH v2] iio: light: lm3533-als: constify attribute_group structures

dec hex filename 57982376 081741fee drivers/iio/light/lm3533-als.o File size after: textdata bss dec hex filename 59262248 081741fee drivers/iio/light/lm3533-als.o Signed-off-by: simran singhal --- v2: -make one more

Re: [PATCH] iio: adc: ad799x: constify attribute_group structures

On Thu, Mar 30, 2017 at 3:06 AM, Jonathan Cameron <ji...@kernel.org> wrote: > On 29/03/17 22:28, SIMRAN SINGHAL wrote: >> On Thu, Mar 30, 2017 at 2:43 AM, Jonathan Cameron <ji...@kernel.org> wrote: >>> On 28/03/17 21:07, simran singhal wrote: >>>> Check fo

Re: [PATCH] iio: adc: ad799x: constify attribute_group structures

On Thu, Mar 30, 2017 at 3:06 AM, Jonathan Cameron wrote: > On 29/03/17 22:28, SIMRAN SINGHAL wrote: >> On Thu, Mar 30, 2017 at 2:43 AM, Jonathan Cameron wrote: >>> On 28/03/17 21:07, simran singhal wrote: >>>> Check for attribute_group structures that are only

Re: [PATCH] iio: adc: ad799x: constify attribute_group structures

On Thu, Mar 30, 2017 at 2:43 AM, Jonathan Cameron <ji...@kernel.org> wrote: > On 28/03/17 21:07, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info

Re: [PATCH] iio: adc: ad799x: constify attribute_group structures

On Thu, Mar 30, 2017 at 2:43 AM, Jonathan Cameron wrote: > On 28/03/17 21:07, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info struc

Re: [PATCH] iio: adc: max1363: constify attribute_group structures

On Thu, Mar 30, 2017 at 2:41 AM, Jonathan Cameron <ji...@kernel.org> wrote: > On 28/03/17 21:15, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info

Re: [PATCH] iio: dac: ad5504: constify attribute_group structures

On Thu, Mar 30, 2017 at 2:39 AM, Jonathan Cameron <ji...@kernel.org> wrote: > On 28/03/17 21:21, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info

Re: [PATCH] iio: adc: max1363: constify attribute_group structures

On Thu, Mar 30, 2017 at 2:41 AM, Jonathan Cameron wrote: > On 28/03/17 21:15, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info struc

Re: [PATCH] iio: dac: ad5504: constify attribute_group structures

On Thu, Mar 30, 2017 at 2:39 AM, Jonathan Cameron wrote: > On 28/03/17 21:21, simran singhal wrote: >> Check for attribute_group structures that are only stored in the >> event_attrs filed of iio_info structure. As the event_attrs field of >> iio_info struc

Re: [Outreachy kernel] [PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro

On Wed, Mar 29, 2017 at 9:46 PM, Daniel Baluta <daniel.bal...@gmail.com> wrote: > On Wed, Mar 29, 2017 at 3:33 PM, simran singhal > <singhalsimr...@gmail.com> wrote: >> Use macro min() to get the minimum of two values for brevity and >> readability. >> >>

Re: [Outreachy kernel] [PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro

On Wed, Mar 29, 2017 at 9:46 PM, Daniel Baluta wrote: > On Wed, Mar 29, 2017 at 3:33 PM, simran singhal > wrote: >> Use macro min() to get the minimum of two values for brevity and >> readability. >> >> Signed-off-by: simran singhal >> --- >> drivers/

Re: [Outreachy kernel] [PATCH 4/4] iio: light: si1145: Replace ternary operator with min macro

On Wed, Mar 29, 2017 at 8:22 PM, SIMRAN SINGHAL <singhalsimr...@gmail.com> wrote: > On Wed, Mar 29, 2017 at 6:23 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: >> On 03/29/2017 02:40 PM, Julia Lawall wrote: >>> >>> >>> On Wed, 29 Mar 2017, simra

Re: [Outreachy kernel] [PATCH 4/4] iio: light: si1145: Replace ternary operator with min macro

On Wed, Mar 29, 2017 at 8:22 PM, SIMRAN SINGHAL wrote: > On Wed, Mar 29, 2017 at 6:23 PM, Lars-Peter Clausen wrote: >> On 03/29/2017 02:40 PM, Julia Lawall wrote: >>> >>> >>> On Wed, 29 Mar 2017, simran singhal wrote: >>> >>>> Use

Re: [Outreachy kernel] [PATCH 4/4] iio: light: si1145: Replace ternary operator with min macro

On Wed, Mar 29, 2017 at 6:23 PM, Lars-Peter Clausen <l...@metafoo.de> wrote: > On 03/29/2017 02:40 PM, Julia Lawall wrote: >> >> >> On Wed, 29 Mar 2017, simran singhal wrote: >> >>> Use macro min() to get the minimum of two values for brevity and >

Re: [Outreachy kernel] [PATCH 4/4] iio: light: si1145: Replace ternary operator with min macro

On Wed, Mar 29, 2017 at 6:23 PM, Lars-Peter Clausen wrote: > On 03/29/2017 02:40 PM, Julia Lawall wrote: >> >> >> On Wed, 29 Mar 2017, simran singhal wrote: >> >>> Use macro min() to get the minimum of two values for brevity and >>> reada

[PATCH] iio: accel: bma180: Set up buffer timestamps for non-zero values

Use the iio_pollfunc_store_time parameter during triggered buffer set-up to get valid timestamps. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/accel/bma180.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/bma180.c b/drive

[PATCH] iio: accel: bma180: Set up buffer timestamps for non-zero values

Use the iio_pollfunc_store_time parameter during triggered buffer set-up to get valid timestamps. Signed-off-by: simran singhal --- drivers/iio/accel/bma180.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c index

[PATCH 3/4] iio: imu: st_lsm6dsx: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/st_l

[PATCH 4/4] iio: light: si1145: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/light/si1145.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c

[PATCH 3/4] iio: imu: st_lsm6dsx: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/imu

[PATCH 4/4] iio: light: si1145: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal --- drivers/iio/light/si1145.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/si1145.c b/drivers/iio/light/si1145.c index 096034c..e7ad6fb 100644

[PATCH 2/4] iio: imu: st_lsm6dsx: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/humidity/hts221_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/humidity/hts221_core.c b/drive

[PATCH 0/4] drivers: iio: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. simran singhal (4): iio: common: st_sensors: Replace ternary operator with min macro iio: imu: st_lsm6dsx: Replace ternary operator with min macro iio: imu: st_lsm6dsx: Replace ternary operator with min macro

[PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- drivers/iio/common/st_sensors/st_sensors_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/st_s

[PATCH 2/4] iio: imu: st_lsm6dsx: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal --- drivers/iio/humidity/hts221_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/humidity/hts221_core.c b/drivers/iio/humidity/hts221_core.c index

[PATCH 0/4] drivers: iio: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. simran singhal (4): iio: common: st_sensors: Replace ternary operator with min macro iio: imu: st_lsm6dsx: Replace ternary operator with min macro iio: imu: st_lsm6dsx: Replace ternary operator with min macro

[PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro

Use macro min() to get the minimum of two values for brevity and readability. Signed-off-by: simran singhal --- drivers/iio/common/st_sensors/st_sensors_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/st_sensors/st_sensors_i2c.c b/drivers/iio/common

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

On Wed, Mar 29, 2017 at 2:19 PM, SIMRAN SINGHAL <singhalsimr...@gmail.com> wrote: > On Wed, Mar 29, 2017 at 12:25 PM, Jan Engelhardt <jeng...@inai.de> wrote: >> >> On Tuesday 2017-03-28 18:23, SIMRAN SINGHAL wrote: >>>On Tue, Mar 28, 2017 at 7:24 PM, Ja

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

On Wed, Mar 29, 2017 at 2:19 PM, SIMRAN SINGHAL wrote: > On Wed, Mar 29, 2017 at 12:25 PM, Jan Engelhardt wrote: >> >> On Tuesday 2017-03-28 18:23, SIMRAN SINGHAL wrote: >>>On Tue, Mar 28, 2017 at 7:24 PM, Jan Engelhardt wrote: >>>> On Tuesday 20

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

On Wed, Mar 29, 2017 at 12:25 PM, Jan Engelhardt <jeng...@inai.de> wrote: > > On Tuesday 2017-03-28 18:23, SIMRAN SINGHAL wrote: >>On Tue, Mar 28, 2017 at 7:24 PM, Jan Engelhardt <jeng...@inai.de> wrote: >>> On Tuesday 2017-03-28 15:13, simran singhal wrote: &g

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

On Wed, Mar 29, 2017 at 12:25 PM, Jan Engelhardt wrote: > > On Tuesday 2017-03-28 18:23, SIMRAN SINGHAL wrote: >>On Tue, Mar 28, 2017 at 7:24 PM, Jan Engelhardt wrote: >>> On Tuesday 2017-03-28 15:13, simran singhal wrote: >>> >>>>Some functions like km

[PATCH] net: netfilter: Use list_{next/prev}_entry instead of list_entry

This patch replace list_entry with list_prev_entry as it makes the code more clear to read. Signed-off-by: simran singhal <singhalsimr...@gmail.com> --- net/netfilter/nf_tables_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_api.c b/net/net

[PATCH] net: netfilter: Use list_{next/prev}_entry instead of list_entry

This patch replace list_entry with list_prev_entry as it makes the code more clear to read. Signed-off-by: simran singhal --- net/netfilter/nf_tables_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index

  1   2   3   4   5   6   7   8   >