ges or
> depend on patches that are not yet merged. I will work on sending those
> once these base patches here have settled.
>
> [...]
Applied, thanks!
[2/7] nvmem: qfprom: Mark core clk as optional
commit: 844ac302b2aa81c47a4323fc34a0a454cc749dbc
Best regards,
--
Srinivas Kandagatla
On 15/04/2021 17:29, Rob Herring wrote:
+codec {
+compatible = "qcom,wcd9380-codec";
+reset-gpios = < 32 0>;
+#sound-dai-cells = <1>;
+qcom,tx-device = <_tx>;
+qcom,rx-device = <_rx>;
+qcom,micbias1-microvolt = <180>;
+
On 15/04/2021 17:39, Rob Herring wrote:
On Wed, Apr 14, 2021 at 04:48:40PM +0100, Srinivas Kandagatla wrote:
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire. This device has two SoundWire devices RX and
TX respectively. This bindings is for those
Thanks Rob for quick review,
On 15/04/2021 17:29, Rob Herring wrote:
On Wed, Apr 14, 2021 at 04:48:37PM +0100, Srinivas Kandagatla wrote:
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire. This device has two SoundWire device RX and
TX respectively
On 15/04/2021 08:38, zhuguangqin...@gmail.com wrote:
From: Guangqing Zhu
Coccinelle noticed:
sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT
Signed-off-by: Guangqing Zhu
---
Thanks for the patch,
Reviewed-by: Srinivas
This patch adds required dapm widgets for playback.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 687 +
1 file changed, 687 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index ae503d1d6379
This patch adds required dapm widgets for capture path.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 785 +
1 file changed, 785 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index bfd8d8ea6f04
This patch adds basic controls found in wcd938x codec.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 409 +
1 file changed, 409 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 0803b5e72326
This patch adds audio routing for both playback and capture.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 94 ++
1 file changed, 94 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 05e1b0fc4f5f
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire. This device has two SoundWire devices RX and
TX respectively. This bindings is for those slave devices on WCD9380/WCD9385.
Signed-off-by: Srinivas Kandagatla
---
.../bindings/sound/qcom,wcd938x
This patch adds support to SoundWire devices on WCD9380/WCD9385 Codec
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig | 9 ++
sound/soc/codecs/Makefile | 2 +
sound/soc/codecs/wcd938x-sdw.c | 230 +
3 files changed, 241 insertions
>From WCD937X Class H controller has changed significantly, so add support
to this new version for WCD937X and WCD938X Codecs.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd-clsh-v2.c | 348 -
sound/soc/codecs/wcd-clsh-v2.h | 16 ++
2 files chan
This patch adds basic SoundWire codec driver to support for
WCD938X TX and RX devices.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig |4 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/wcd938x.c | 1811
sound/soc/codecs
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire. This device has two SoundWire device RX and
TX respectively, supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH,
7 x TX diff inputs, 8 DMICs, MBHC.
Signed-off-by: Srinivas Kandagatla
---
.../bindings
for reviewing v3.
Changes since v3:
- Moved to using driver component framework
- Added device links to allow correct runtime PM
- added runtime pm support
- split codec bindings into two parts one for codec and other for soundwire
device.
-
Srinivas Kandagatla (9):
ASoC: dt-bindings: wcd938x: add
On 12/04/2021 13:17, Jerome Brunet wrote:
-return of_clk_add_provider(np, of_clk_src_simple_get, va->hw.clk);
+ return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, >hw);
Now that we convert this to devm, You missed error path and driver remove
where we delete clk
On 10/04/2021 04:50, Bixuan Cui wrote:
This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.
Reported-by: Hulk Robot
Signed-off-by: Bixuan Cui
---
Applied thanks,
--srini
Thanks Jerome for the patch,
On 10/04/2021 12:13, Jerome Brunet wrote:
Clock providers should be registered using the clk_hw API.
Signed-off-by: Jerome Brunet
---
sound/soc/codecs/lpass-va-macro.c | 2 +-
sound/soc/codecs/lpass-wsa-macro.c | 9 +++--
2 files changed, 4
MIC2", "MIC BIAS2",
+ "AMIC3", "MIC BIAS3",
+ "MM_DL1", "MultiMedia1 Playback",
+ "MM_DL2", "MultiMedia2 Playback",
+ "MultiMedia3 Capture", "MM_UL3&q
On 01/04/2021 15:36, Pierre-Louis Bossart wrote:
On 4/1/21 4:00 AM, Srinivas Kandagatla wrote:
If we write registers very fast we can endup in a situation where some
of the writes will be dropped without any notice.
So wait for the fifo space to be available before reading/writing
confusing to the reader so, make this bit more obvious by only
copying the parameters to offset 1 instead of zero. This will avoid doing
-1 every time when we try to get port params.
Similar thing has been recently done with din/dout_port_mask.
Signed-off-by: Srinivas Kandagatla
---
drivers
Looks like return from reg_write is set but not checked.
Fix this by adding error return path.
Reported-by: coverity-bot
Addresses-Coverity-ID: 1503591 ("UNUSED_VALUE")
Fixes: 128eaf937adb ("soundwire: qcom: add support to missing transport params")
Signed-off-by:
If we write registers very fast we can endup in a situation where some
of the writes will be dropped without any notice.
So wait for the fifo space to be available before reading/writing the
soundwire registers.
Signed-off-by: Srinivas Kandagatla
---
Changes since v1:
merged some
NPL clock rate is twice the MCLK rate, so set this correctly to
avoid soundwire timeouts.
Fixes: af3d54b99764 ("ASoC: codecs: lpass-rx-macro: add support for lpass rx
macro")
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-rx-macro.c | 2 +-
1 file changed, 1 inser
NPL clock rate is twice the MCLK rate, so set this correctly to
avoid soundwire timeouts.
Fixes: c39667ddcfc5 ("ASoC: codecs: lpass-tx-macro: add support for lpass tx
macro")
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/lpass-tx-macro.c | 2 +-
1 file changed, 1 inser
If we write registers very fast we can endup in a situation where some
of the writes will be dropped without any notice.
So wait for the fifo space to be available before reading/writing the
soundwire registers.
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 74
On 14/03/2021 06:10, Srinivasa Rao Mandadapu wrote:
This is a trgodor variant, required to have sound node variable
for coachz specific platform.
Signed-off-by: Srinivasa Rao Mandadapu
Reviewed-by: Stephen Boyd
---
Reviewed-by: Srinivas Kandagatla
arch/arm64/boot/dts/qcom/sc7180
Sujith Kumar Reddy
Signed-off-by: Srinivasa Rao Mandadapu
---
LGTM,
Reviewed-by: Srinivas Kandagatla
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 58
1 file changed, 58 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
b/arch/arm64/boot/dts/qcom
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index b1dbaf8263e5..b08ecb9b418c 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers
Exporting these three functions makes sense as it can be used by
other controllers like Qualcomm during auto-enumeration!
Reported-by: kernel test robot
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/bus.c | 4 +++-
drivers/soundwire/slave.c | 1 +
include/linux/soundwire
Qualcomm SoundWire controller supports Auto Enumeration of the
devices within the IP. This patch enables support for this feature.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 86 +---
1 file changed, 81
-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 161 ---
1 file changed, 135 insertions(+), 26 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index faa4c84dcf61..1ad07784db4b 100644
--- a/drivers
during streaming!
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 179 ++-
1 file changed, 100 insertions(+), 79 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index
version 1.5.1 and higher IPs of this controller required to set
continue execution on ignored command flag. This patch sets this flag.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 11 ++-
1 file changed, 10 insertions(+), 1
Some of the transport parameters derived from device tree
are not fully parsed by the driver.
This patch adds support to parse those missing parameters.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 106
Start the clock during initialization, doing this explicitly
will add more clarity when we are adding clock stop feature.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soundwire
Some of the parameters for data ports are not applicable or not implemented
in IP. So mark them as invalid/not applicable in DT so that controller is
aware of this.
Add comment to these bindings to provide more clarity on the values!
Signed-off-by: Srinivas Kandagatla
Acked-by: Rob Herring
speakers, HeadPhones on
WCD938x via lpass-rx-macro and Analog MICs via lpass-tx-macro.
Also tested on DragonBoard DB845c with 2xWSA881x speakers.
Changes since v5:
- Use BIT macro in interrupt routine
- add comment for fifo write
Srinivas Kandagatla (9):
dt-bindings: soundwire
From: Rajendra Nayak
Handle the differences across LDO voltage needed for blowing fuses,
and the blow timer value, identified using a minor version of 15
on sc7280.
Signed-off-by: Rajendra Nayak
Signed-off-by: Ravi Kumar Bokka
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/qfprom.c
-extension. Fix this by casting buf[i] to
a u64 before the shift.
Addresses-Coverity: ("Unintended sign extension")
Fixes: 097eb1136ebb ("nvmem: core: Add functions to make number reading easy")
Signed-off-by: Colin Ian King
Reviewed-by: Douglas Anderson
Signed-off-by:
ese
functions. Adding the "big endian" version would require adding "big
endian" support to nvmem_shift_read_buffer_in_place().
Signed-off-by: Douglas Anderson
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/core.c | 95 ++
include/l
From: Rajendra Nayak
Document SoC compatible for sc7280
Signed-off-by: Rajendra Nayak
Acked-by: Rob Herring
Signed-off-by: Srinivas Kandagatla
---
Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings
From: Rafał Miłecki
This driver provides access to Broadcom's NVRAM.
Signed-off-by: Rafał Miłecki
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/Kconfig | 9 +
drivers/nvmem/Makefile | 2 +
drivers/nvmem/brcm_nvram.c | 78 ++
3 files
)
Reviewed-by: Nicolas Saenz Julienne
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 642ddc699fd1..dd2019006838 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -27
at a lower rate when we're
not blowing fuses.
Fixes: 93b4e49f8c86 ("nvmem: qfprom: Add fuse blowing support")
Reported-by: Douglas Anderson
Suggested-by: Douglas Anderson
Signed-off-by: Ravi Kumar Bokka
Reviewed-by: Douglas Anderson
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/qfp
From: Rafał Miłecki
Broadcom's NVRAM structure contains device data and can be accessed
using I/O mapping.
Signed-off-by: Rafał Miłecki
Reviewed-by: Rob Herring
Signed-off-by: Srinivas Kandagatla
---
.../devicetree/bindings/nvmem/brcm,nvram.yaml | 34 +++
1 file changed, 34
From: Ryan Wu
This updates dt-binding documentation for MediaTek mt8192
Signed-off-by: Ryan Wu
Acked-by: Rob Herring
Signed-off-by: Srinivas Kandagatla
---
Documentation/devicetree/bindings/nvmem/mtk-efuse.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree
Srinivas Kandagatla (1):
nvmem: rmem: fix undefined reference to memremap
Zheng Yongjun (1):
nvmem: convert comma to semicolon
.../devicetree/bindings/nvmem/brcm,nvram.yaml | 34 +++
.../devicetree/bindings/nvmem/mtk-efuse.txt | 1 +
.../bindings/nvmem/qcom,qfprom.yaml | 1
From: Zheng Yongjun
Replace a comma between expression statements by a semicolon.
Signed-off-by: Zheng Yongjun
Reviewed-by: Bjorn Andersson
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/qcom-spmi-sdam.c | 2 +-
drivers/nvmem/snvs_lpgpr.c | 2 +-
2 files changed, 2 insertions
On 25/03/2021 05:44, Rajendra Nayak wrote:
Document SoC compatible for sc7280
Signed-off-by: Rajendra Nayak
---
Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
el Walle
---
Patch is fine as it its.
If you plan to take this via mtd tree here is my Ack
Acked-by: Srinivas Kandagatla
--srini
drivers/nvmem/core.c | 4 +++-
include/linux/nvmem-provider.h | 2 ++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/nvmem/
Hi Michael,
On 22/03/2021 18:19, Michael Walle wrote:
The goal is to fetch a (base) MAC address from the OTP region of a SPI NOR
flash.
This is the first part, where I try to add the nvmem provider support to
the MTD core.
I'm not sure about the device tree bindings. Consider the following
Exporting these three functions makes sense as it can be used by
other controllers like Qualcomm during auto-enumeration!
Reported-by: kernel test robot
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/bus.c | 4 +++-
drivers/soundwire/slave.c | 1 +
include/linux/soundwire
Start the clock during initialization, doing this explicitly
will add more clarity when we are adding clock stop feature.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soundwire
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index c6c923329b15..706d44200a36 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers
-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 161 ---
1 file changed, 135 insertions(+), 26 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 0cbd611fb8c6..6a563fb52444 100644
--- a/drivers
Qualcomm SoundWire controller supports Auto Enumeration of the
devices within the IP. This patch enables support for this feature.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 86 +---
1 file changed, 81
during streaming!
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 178 ++-
1 file changed, 99 insertions(+), 79 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index
version 1.5.1 and higher IPs of this controller required to set
continue execution on ignored command flag. This patch sets this flag.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 11 ++-
1 file changed, 10 insertions(+), 1
Some of the transport parameters derived from device tree
are not fully parsed by the driver.
This patch adds support to parse those missing parameters.
Signed-off-by: Srinivas Kandagatla
Reviewed-by: Pierre-Louis Bossart
---
drivers/soundwire/qcom.c | 107
speakers, HeadPhones on
WCD938x via lpass-rx-macro and Analog MICs via lpass-tx-macro.
Also tested on DragonBoard DB845c with 2xWSA881x speakers.
Changes since v4:
- exported sdw_slave_add as kernel test robot reported error
Srinivas Kandagatla (9):
dt-bindings: soundwire: qcom: clarify
Some of the parameters for data ports are not applicable or not implemented
in IP. So mark them as invalid/not applicable in DT so that controller is
aware of this.
Add comment to these bindings to provide more clarity on the values!
Signed-off-by: Srinivas Kandagatla
Acked-by: Rob Herring
On 25/03/2021 07:15, Rajendra Nayak wrote:
Looks right to me. Assuming that this works.
Reviewed-by: Douglas Anderson
Srini, any plans to queue this up for merge?
On 19/03/2021 15:59, Pierre-Louis Bossart wrote:
On 3/19/21 4:29 AM, Srinivas Kandagatla wrote:
This patch adds basic SoundWire codec driver to support for
WCD938X TX and RX devices.
It took me a while to figure out that you are adding support for a codec
that has 2 Slave interfaces
Many thanks Pierre for reviewing the patches,
On 19/03/2021 16:09, Pierre-Louis Bossart wrote:
On 3/19/21 4:29 AM, Srinivas Kandagatla wrote:
This patchset adds support for Qualcomm WCD938X codec.
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire
On 19/03/2021 15:23, Pierre-Louis Bossart wrote:
+static void wcd_clsh_v3_set_hph_mode(struct snd_soc_component
*component,
+ int mode)
+{
+ u8 val = 0;
initialization not needed.
I agree, will remove this in next spin.
+
+ switch (mode) {
+ case
This patch adds audio routing for both playback and capture.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 97 ++
1 file changed, 97 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 31e3cf729568
This patch adds required dapm widgets for playback.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 700 +
1 file changed, 700 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 9b5dda775a17
This patch adds basic SoundWire codec driver to support for
WCD938X TX and RX devices.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig |9 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/wcd938x-sdw.c | 291 ++
sound/soc/codecs/wcd938x.c | 1615
This patch adds required dapm widgets for capture path.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 796 +
1 file changed, 796 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 59e41296a489
This patch adds basic controls found in wcd938x codec.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 415 +
1 file changed, 415 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 9e8d588e2235
>From WCD937X Class H controller has changed significantly, so add support
to this new version for WCD937X and WCD938X Codecs.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd-clsh-v2.c | 350 -
sound/soc/codecs/wcd-clsh-v2.h | 16 ++
2 files chan
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire. This device has two SoundWire device RX and
TX respectively, supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH,
7 x TX diff inputs, 8 DMICs, MBHC.
Signed-off-by: Srinivas Kandagatla
---
.../bindings
,
srini
Many thanks for reviewing v2.
Changes since v2:
- fixed dt_binding_check error
Srinivas Kandagatla (7):
ASoC: dt-bindings: wcd938x: add bindings for wcd938x
ASoC: codecs: wcd-clsh: add new version support
ASoC: codecs: wcd938x: add basic driver
ASoC: codecs: wcd938x: add
: Linus Walleij
Cc: Bartosz Golaszewski
Cc: Bjorn Andersson
Cc: Krzysztof Kozlowski
Cc: Marc Kleine-Budde
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Srinivas Kandagatla
Cc: Ohad Ben-Cohen
Cc: Mark Brown
Cc: Cheng-Yi Chiang
Cc: Benson Leung
Cc: Zhang Rui
Cc: Daniel Lezcano
Cc: Greg Kroah-
On 16/03/2021 19:51, Rob Herring wrote:
Common consumer schemas need to use the base.yaml meta-schema because
they need to define different constraints (e.g. the type) from what
users of the common schema need to define (e.g. how many entries).
Cc: Srinivas Kandagatla
Signed-off-by: Rob
This patch adds required dapm widgets for capture path.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 796 +
1 file changed, 796 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 59e41296a489
This patch adds audio routing for both playback and capture.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 97 ++
1 file changed, 97 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 31e3cf729568
This patch adds required dapm widgets for playback.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 700 +
1 file changed, 700 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 9b5dda775a17
This patch adds basic SoundWire codec driver to support for
WCD938X TX and RX devices.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/Kconfig |9 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/wcd938x-sdw.c | 291 ++
sound/soc/codecs/wcd938x.c | 1615
This patch adds basic controls found in wcd938x codec.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd938x.c | 415 +
1 file changed, 415 insertions(+)
diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
index 9e8d588e2235
>From WCD937X Class H controller has changed significantly, so add support
to this new version for WCD937X and WCD938X Codecs.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wcd-clsh-v2.c | 350 -
sound/soc/codecs/wcd-clsh-v2.h | 16 ++
2 files chan
Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
connected over SoundWire. This device has two SoundWire device RX and
TX respectively, supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH,
7 x TX diff inputs, 8 DMICs, MBHC.
Signed-off-by: Srinivas Kandagatla
---
.../bindings
the gain tlvs correctly
- update dt-bindings to use microvolt for button thresholds
- removed unnecessary debug at various places.
Srinivas Kandagatla (7):
ASoC: dt-bindings: wcd938x: add bindings for wcd938x
ASoC: codecs: wcd-clsh: add new version support
ASoC: codecs: wcd938x
WSA881x SoundWire device ports are statically assigned to master ports
at design time. So add bindings required to specify these mappings!
Signed-off-by: Srinivas Kandagatla
---
.../devicetree/bindings/sound/qcom,wsa881x.yaml | 9 +
1 file changed, 9 insertions(+)
diff --git
-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 9e70c53e2c7b..39222b04a2e0 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -460,6
Two instances of WSA881x(Speaker Right, Speaker Left) ports
are statically mapped to master ports. Allow the driver to parse
those mappings from device tree.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wsa881x.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/sound/soc
currently the internal bitmask used for allocating ports starts with offset 0.
This is bit confusing as data port numbers on Qualcomm controller are valid
from 1 to 14. So adjust this bit mask accordingly, this will also help while
adding static port map support.
Signed-off-by: Srinivas
is not possible in this cases!
So this patch adds a new member m_port_map to struct sdw_slave to expose
this static map.
Signed-off-by: Srinivas Kandagatla
---
include/linux/soundwire/sdw.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
speaker which has 4 ports which are statically mapped
to the 3 output and 1 input port of the controller.
Tested it on DB845c and SM8250 MTP.
thanks,
srini
Changes since v3:
- updated kernel doc for more clarity on m_port_map
Srinivas Kandagatla (5):
soundwire: add static port mapping
Fix below error reporte by kernel test robot
rmem.c:(.text+0x14e): undefined reference to memremap
s390x-linux-gnu-ld: rmem.c:(.text+0x1b6): undefined reference to memunmap
Reported-by: kernel test robot
Signed-off-by: Srinivas Kandagatla
---
drivers/nvmem/Kconfig | 1 +
1 file changed, 1
Thanks for your feedback,
On 12/03/2021 15:21, Mark Brown wrote:
On Thu, Mar 11, 2021 at 05:34:10PM +, Srinivas Kandagatla wrote:
+ qcom,mbhc-hphl-switch:
+description: Indicates that HPHL switch type is normally closed!
+type: boolean
+
+ qcom,mbhc-ground-switch
On 12/03/2021 15:34, Mark Brown wrote:
On Thu, Mar 11, 2021 at 05:34:12PM +, Srinivas Kandagatla wrote:
+static int wcd9380_update_status(struct sdw_slave *slave,
+enum sdw_slave_status status)
+{
+ return 0;
+}
+
+static int wcd9380_port_prep
Thanks Mark for review,
On 12/03/2021 15:55, Mark Brown wrote:
On Thu, Mar 11, 2021 at 05:34:13PM +, Srinivas Kandagatla wrote:
+ if (wcd938x->variant == WCD9380) {
switch statements please.
+ if (mode_val == CLS_H_HIFI || mode_val == CLS_AB_H
On 12/03/2021 16:56, Pierre-Louis Bossart wrote:
On 3/12/21 5:39 AM, Srinivas Kandagatla wrote:
Some of the SoundWire device ports are statically mapped to Controller
ports during design, however there is no way to expose this information
to the controller. Controllers like Qualcomm ones
Two instances of WSA881x(Speaker Right, Speaker Left) ports
are statically mapped to master ports. Allow the driver to parse
those mappings from device tree.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/codecs/wsa881x.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/sound/soc
currently the internal bitmask used for allocating ports starts with offset 0.
This is bit confusing as data port numbers on Qualcomm controller are valid
from 1 to 14. So adjust this bit mask accordingly, this will also help while
adding static port map support.
Signed-off-by: Srinivas
-by: Srinivas Kandagatla
---
drivers/soundwire/qcom.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 9e70c53e2c7b..39222b04a2e0 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -460,6
WSA881x SoundWire device ports are statically assigned to master ports
at design time. So add bindings required to specify these mappings!
Signed-off-by: Srinivas Kandagatla
---
.../devicetree/bindings/sound/qcom,wsa881x.yaml | 9 +
1 file changed, 9 insertions(+)
diff --git
is not possible in this cases!
So this patch adds a new member m_port_map to struct sdw_slave to expose
this static map.
Signed-off-by: Srinivas Kandagatla
---
include/linux/soundwire/sdw.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
1 - 100 of 6454 matches
Mail list logo
