[PATCH v2 4/6] arm64: dts: qcom: sm8250: add wsa and va codec macros

2020-12-02 Thread Srinivas Kandagatla
Add support for WSA and VA codec macros along with WSA soundwire controller required for getting audio on RB5. Signed-off-by: Srinivas Kandagatla Tested-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 56 1 file changed, 56 insertions(+) diff --git

[PATCH v2 1/6] arm64: dts: qcom: sm8250: add apr and its services

2020-12-02 Thread Srinivas Kandagatla
Add apr node and its associated services required for audio on RB5. Signed-off-by: Srinivas Kandagatla Tested-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 56 1 file changed, 56 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b

[PATCH v2 3/6] arm64: dts: qcom: sm8250: add lpass lpi pin controller node

2020-12-02 Thread Srinivas Kandagatla
Add LPASS LPI pinctrl node required for Audio functionality on RB5. Signed-off-by: Srinivas Kandagatla Tested-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 84 1 file changed, 84 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b

[PATCH v2 0/6] arm64: dts: qcom: qrb5165-rb5 audio support

2020-12-02 Thread Srinivas Kandagatla
. - removed unnecessary spaces - used mbn instead of mdt for adsp firmware Srinivas Kandagatla (6): arm64: dts: qcom: sm8250: add apr and its services arm64: dts: qcom: sm8250: add audio clock controllers arm64: dts: qcom: sm8250: add lpass lpi pin controller node arm64: dts: qcom

[RESEND PATCH v6 1/2] dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

2020-12-02 Thread Srinivas Kandagatla
Add device tree binding Documentation details for Qualcomm SM8250 LPASS(Low Power Audio Sub System) LPI(Low Power Island) pinctrl driver. Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson --- .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 130

[RESEND PATCH v6 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-12-02 Thread Srinivas Kandagatla
pin controller except setting them as gpios. Apart from this, slew rate is also available in this block for certain pins which are connected to SLIMbus or SoundWire Bus. Signed-off-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/Kconfig | 8 + drivers/pinctrl/qcom/Makef

[RESEND PATCH v6 0/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl support

2020-12-02 Thread Srinivas Kandagatla
the SHIFT constants - updated function groups as suggested by Bjorn - updated setting slew rate as suggested by Bjorn Srinivas Kandagatla (2): dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver .../pinctrl/qcom,lpass

[PATCH v6 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-12-02 Thread Srinivas Kandagatla
pin controller except setting them as gpios. Apart from this, slew rate is also available in this block for certain pins which are connected to SLIMbus or SoundWire Bus. Signed-off-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/Kconfig | 8 + drivers/pinctrl/qcom/Makef

[PATCH v6 0/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl support

2020-12-02 Thread Srinivas Kandagatla
setting slew rate as suggested by Bjorn Srinivas Kandagatla (2): dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 130 drivers/pinctrl/qcom/Kconfig | 8

[PATCH v6 1/2] dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

2020-12-02 Thread Srinivas Kandagatla
Add device tree binding Documentation details for Qualcomm SM8250 LPASS(Low Power Audio Sub System) LPI(Low Power Island) pinctrl driver. Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring Reviewed-by: Bjorn Andersson --- .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 130

Re: [PATCH 1/6] arm64: dts: qcom: sm8250: add apr and its services

2020-12-02 Thread Srinivas Kandagatla
Many thanks Bjorn for review, On 01/12/2020 19:25, Bjorn Andersson wrote: On Tue 01 Dec 09:37 CST 2020, Srinivas Kandagatla wrote: Add apr node and its associated services required for audio on RB5. Signed-off-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 56

Re: [PATCH v4 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-12-02 Thread Srinivas Kandagatla
On 01/12/2020 17:28, Bjorn Andersson wrote: On Tue 01 Dec 04:01 CST 2020, Srinivas Kandagatla wrote: Many thanks for review Bjorn, On 01/12/2020 00:47, Bjorn Andersson wrote: On Mon 16 Nov 08:34 CST 2020, Srinivas Kandagatla wrote: Add initial pinctrl driver to support pin

Re: [PATCH v5 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-12-02 Thread Srinivas Kandagatla
On 02/12/2020 09:56, Srinivas Kandagatla wrote: +    case PIN_CONFIG_SLEW_RATE: +    if (arg > LPI_SLEW_RATE_MAX) { +    dev_err(pctldev->dev, "invalid slew rate %u for pin: %d\n", +    arg, group); +  

Re: [PATCH v5 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-12-02 Thread Srinivas Kandagatla
Thanks Alex for the comments, On 01/12/2020 20:21, Alex Elder wrote: On 12/1/20 8:28 AM, Srinivas Kandagatla wrote: Add initial pinctrl driver to support pin configuration for LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl on SM8250. This IP is an additional pin control

Re: [PATCH v5 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-12-02 Thread Srinivas Kandagatla
Thanks Bjorn for the review, On 01/12/2020 19:48, Bjorn Andersson wrote: On Tue 01 Dec 08:28 CST 2020, Srinivas Kandagatla wrote: Add initial pinctrl driver to support pin configuration for LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl on SM8250. This IP is an additional

[PATCH 6/6] arm64: dts: qcom: qrb5165-rb5: Add Audio support

2020-12-01 Thread Srinivas Kandagatla
This patch add support for two WSA881X smart speakers attached via Soundwire and a DMIC0 on the main board. Signed-off-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 125 +++ 1 file changed, 125 insertions(+) diff --git a/arch/arm64/boot/dts/qcom

[PATCH 5/6] arm64: dts: qcom: sm8250: add mi2s pinconfs

2020-12-01 Thread Srinivas Kandagatla
Add primary and tertinary mi2s pinconfs required to get I2S audio. Signed-off-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 98 1 file changed, 98 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom

[PATCH 4/6] arm64: dts: qcom: sm8250: add wsa and va codec macros

2020-12-01 Thread Srinivas Kandagatla
Add support for WSA and VA codec macros along with WSA soundwire controller required for getting audio on RB5. Signed-off-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 56 1 file changed, 56 insertions(+) diff --git a/arch/arm64/boot/dts/qcom

[PATCH 2/6] arm64: dts: qcom: sm8250: add audio clock controllers

2020-12-01 Thread Srinivas Kandagatla
Add audiocc and aoncc clock controller nodes required for audio on RB5. Signed-off-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250

[PATCH 3/6] arm64: dts: qcom: sm8250: add lpass lpi pin controller node

2020-12-01 Thread Srinivas Kandagatla
Add LPASS LPI pinctrl node required for Audio functionality on RB5. Signed-off-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 95 1 file changed, 95 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom

[PATCH 1/6] arm64: dts: qcom: sm8250: add apr and its services

2020-12-01 Thread Srinivas Kandagatla
Add apr node and its associated services required for audio on RB5. Signed-off-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 56 1 file changed, 56 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom

[PATCH 0/6] arm64: dts: qcom: qrb5165-rb5 audio support

2020-12-01 Thread Srinivas Kandagatla
maintainer trees along with bindings. Only LPI pinctrl driver is not merged yet, however the bindings are acked by Rob, so am guessing that the dt changes should be okay to go! Thanks, srini Srinivas Kandagatla (6): arm64: dts: qcom: sm8250: add apr and its services arm64: dts: qcom: sm8250: add

[PATCH v5 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-12-01 Thread Srinivas Kandagatla
pin controller except setting them as gpios. Apart from this, slew rate is also available in this block for certain pins which are connected to SLIMbus or SoundWire Bus. Signed-off-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/Kconfig | 8 + drivers/pinctrl/qcom/Makef

[PATCH v5 1/2] dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

2020-12-01 Thread Srinivas Kandagatla
Add device tree binding Documentation details for Qualcomm SM8250 LPASS(Low Power Audio Sub System) LPI(Low Power Island) pinctrl driver. Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 132 ++ 1 file changed, 132

[PATCH v5 0/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl support

2020-12-01 Thread Srinivas Kandagatla
from Bjorn Srinivas Kandagatla (2): dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 132 drivers/pinctrl/qcom/Kconfig | 8 + drivers/pinctrl/qcom/Makefile

Re: [PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

2020-12-01 Thread Srinivas Kandagatla
On 01/12/2020 00:55, Bjorn Andersson wrote: +reg = <0x33c 0x2>, + <0x355a000 0x1000>; We shouldn't reference parts of blocks, so this should be 16KB at yes, makes sense! Will change the example accordingly! 0x3550 and if we have multiple drivers that

Re: [PATCH v4 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-12-01 Thread Srinivas Kandagatla
Many thanks for review Bjorn, On 01/12/2020 00:47, Bjorn Andersson wrote: On Mon 16 Nov 08:34 CST 2020, Srinivas Kandagatla wrote: Add initial pinctrl driver to support pin configuration for LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl on SM8250. This IP is an additional

[PATCH] slimbus: qcom-ngd-ctrl: fix SSR dependencies

2020-12-01 Thread Srinivas Kandagatla
NGD should depend on QCOM_RPROC_COMMON instead of selecting it, as this will be selected by respective remoteproc driver. Reported-by: kernel test robot Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH v4 2/2] ASoC: qcom: Add support for playback recover after resume

2020-11-30 Thread Srinivas Kandagatla
On 28/11/2020 04:59, Srinivasa Rao Mandadapu wrote: To support playback continuation after hard suspend(bypass powerd) and resume add component driver ops and do regcache sync. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu LGTM, Reviewed-by: Srinivas

Re: [PATCH v4 1/2] Partially revert ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state

2020-11-30 Thread Srinivas Kandagatla
On 28/11/2020 04:59, Srinivasa Rao Mandadapu wrote: This reverts part of commit b1824968221c ("ASoC: qcom: Fix enabling BCLK and LRCLK in LPAIF invalid state") This should probably go to Fixes tag! To identify LPAIF invalid state after device suspend and resume, made I2S and DMA

Re: [PATCH v3 1/2] arm64: dts: qcom: sc7180: Update lpass cpu node for audio over dp

2020-11-30 Thread Srinivas Kandagatla
On 30/09/2020 07:42, Srinivasa Rao Mandadapu wrote: From: V Sujith Kumar Reddy Updaate lpass dts node with HDMI reg, interrupt and iommu for supporting audio over dp. Signed-off-by: Srinivasa Rao Mandadapu Signed-off-by: V Sujith Kumar Reddy Reviewed-by: Srinivas Kandagatla

Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI

2020-11-30 Thread Srinivas Kandagatla
On 30/09/2020 07:42, Srinivasa Rao Mandadapu wrote: From: V Sujith Kumar Reddy Add dai link in sc7180-trogdor.dtsi for supporting audio over DP Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu Reviewed-by: Srinivas Kandagatla --- arch/arm64/boot/dts/qcom

Re: [PATCH v4] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver

2020-11-30 Thread Srinivas Kandagatla
Mandadapu --- Reviewed-by: Srinivas Kandagatla Changes since v3: -- The typo error fix Changes since v2: -- The plement of lpass_cpu node is changed Changes since v1: -- Updated I2S pin control nodes with grouping common pin controls -- Updated lpass_cpu node with proper control names

Re: [PATCH v3] ASoC: qcom: Fix playback recover problem in suspend resume

2020-11-27 Thread Srinivas Kandagatla
On 27/11/2020 09:56, Srinivasa Rao Mandadapu wrote: To support playback continuation after hard suspend(bypass powerd) and resume: Prepare device in platform trigger callback. Make I2s and DMA control registers as non volatile. Looks like there are two changes here, One is fixing the

[PATCH 3/5] dt-bindings: nvmem: Add soc qfprom compatible strings

2020-11-27 Thread Srinivas Kandagatla
From: Evan Green Add SoC-specific compatible strings so that data can be attached to it in the driver. Signed-off-by: Evan Green Reviewed-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- .../devicetree/bindings/nvmem/qcom,qfprom.yaml | 17 ++--- 1 file changed, 14

[PATCH 5/5] nvmem: imx-ocotp: add support for the unaliged word count

2020-11-27 Thread Srinivas Kandagatla
data from buffer to caller and free buffer. Signed-off-by: Peng Fan Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/imx-ocotp.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index

[PATCH 0/5] nvmem: patches (set 1) for 5.11

2020-11-27 Thread Srinivas Kandagatla
Hi Greg, Here are some nvmem patches for 5.11 which includes - adding support to keepout regions in nvmem core - support for unaligned word count in imx provider - imx and qfprom new compatible strings. Can you please queue them up for 5.11. thanks for you help, srini Evan Green (3): nvmem:

[PATCH 4/5] nvmem: qfprom: Don't touch certain fuses

2020-11-27 Thread Srinivas Kandagatla
-by: Evan Green Reviewed-by: Douglas Anderson Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/qfprom.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index 5e9e60e2e591..6cace24dfbf7 100644 --- a/drivers

[PATCH 1/5] dt-bindings: nvmem: mtk-efuse: add documentation for MT8516 SoC

2020-11-27 Thread Srinivas Kandagatla
From: Fabien Parent Add binding documentation for MT8516 SoCs. Signed-off-by: Fabien Parent Acked-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/nvmem/mtk-efuse.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH 2/5] nvmem: core: Add support for keepout regions

2020-11-27 Thread Srinivas Kandagatla
if certain efuse regions are protected from access by Linux because they contain secret info to another part of the system (like an integrated modem). Signed-off-by: Evan Green Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/core.c | 153 - include

[PATCH 7/7] slimbus: qcom-ngd-ctrl: remove redundant out of memory messages

2020-11-27 Thread Srinivas Kandagatla
Failure of dma_alloc_coherent will already throw a error message, so addition message is really redundant here. Remove it! Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers

[PATCH 2/7] slimbus: qcom-ngd-ctrl: add Sub System Restart support

2020-11-27 Thread Srinivas Kandagatla
of SSR up followed by QMI server up notification. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 3 +- drivers/slimbus/qcom-ngd-ctrl.c | 97 +++-- 2 files changed, 95 insertions(+), 5 deletions(-) diff --git a/drivers/slimbus/Kconfig b/drivers

[PATCH 5/7] slimbus: qcom-ngd-ctrl: Constify static structs

2020-11-27 Thread Srinivas Kandagatla
-by: Rikard Falkeborn Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 943d55a0bc59..172ddcc2a241 100644 --- a/drivers/slimbus/qcom-ngd

[PATCH 0/7] slimbus: patches for 5.11

2020-11-27 Thread Srinivas Kandagatla
: Avoid sending power requests without QMI Gustavo A. R. Silva (1): slimbus: messaging: Fix fall-through warnings for Clang Mauro Carvalho Chehab (1): slimbus: fix a kernel-doc markup Rikard Falkeborn (1): slimbus: qcom-ngd-ctrl: Constify static structs Srinivas Kandagatla (3): slimbus

[PATCH 6/7] slimbus: qcom-ngd-ctrl: Avoid sending power requests without QMI

2020-11-27 Thread Srinivas Kandagatla
qcom SLIMBus NGD driver") Signed-off-by: Bjorn Andersson Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/qcom-ngd-ctrl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 172ddcc2a241..82dad7490

[PATCH 3/7] slimbus: qcom-ngd-ctrl: add Protection Domain Restart Support

2020-11-27 Thread Srinivas Kandagatla
Add support to protection domain restart. Protection domain restart would also restart the service just like SSR. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 1 + drivers/slimbus/qcom-ngd-ctrl.c | 24 2 files changed, 25 insertions(+) diff

[PATCH 4/7] slimbus: messaging: Fix fall-through warnings for Clang

2020-11-27 Thread Srinivas Kandagatla
Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/messaging.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/slimbus/messaging.c b/drivers/slimbus/messaging.c index d5879142dbef..f2b5d347d227 100644 --- a/drivers/slimbus/messaging.c +++ b/drivers/slimbus/messaging.c @@ -258,6 +25

[PATCH 1/7] slimbus: fix a kernel-doc markup

2020-11-27 Thread Srinivas Kandagatla
From: Mauro Carvalho Chehab Fix the name of the enum on its kernel-doc markup: enum slim_ch_aux_fmt -> enum slim_ch_aux_bit_fmt Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/slimbus.h | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'

2020-11-25 Thread Srinivas Kandagatla
efined reference to `slimbus_bus' or1k-linux-ld: drivers/soundwire/qcom.c:771: undefined reference to `slimbus_bus' 09309093d5e8f87 Jonathan Marek 2020-09-08 770 #if IS_ENABLED(CONFIG_SLIMBUS) 02efb49aa805cee Srinivas Kandagatla 2020-01-13 @771if (dev->parent->

Re: [PATCH] slimbus: qcom-ngd-ctrl: Avoid sending power requests without QMI

2020-11-25 Thread Srinivas Kandagatla
On 25/11/2020 05:42, Bjorn Andersson wrote: Attempting to send a power request during PM operations, when the QMI handle isn't initialized results in a NULL pointer dereference. So check if the QMI handle has been initialized before attempting to post the power requests. Fixes: 917809e2280b

Re: [PATCH 1/2] dt-bindings: nvmem: mtk-efuse: add documentation for MT8516 SoC

2020-11-24 Thread Srinivas Kandagatla
On 16/10/2020 18:18, Fabien Parent wrote: Add binding documentation for MT8516 SoCs. Signed-off-by: Fabien Parent I have picked up the dt-bindings patch, but dts changes have to go via arm-soc tree! --srini

Re: [PATCH] nvmem: imx-ocotp: add support for the unaliged word count

2020-11-24 Thread Srinivas Kandagatla
On 22/10/2020 08:44, peng@nxp.com wrote: From: Peng Fan When offset is not 4 bytes aligned, directly shift righty by 2 bits will cause reading out wrong data. Since imx ocotp only supports 4 bytes reading once, we need handle offset is not 4 bytes aligned and enlarge the bytes to 4

Re: [PATCH 126/141] slimbus: messaging: Fix fall-through warnings for Clang

2020-11-24 Thread Srinivas Kandagatla
On 20/11/2020 18:39, Gustavo A. R. Silva wrote: In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A.

Re: [PATCH] slimbus: qcom-ngd-ctrl: Constify static structs

2020-11-24 Thread Srinivas Kandagatla
On 22/11/2020 23:42, Rikard Falkeborn wrote: qcom_slim_qmi_msg_handlers[] and qcom_slim_ngd_qmi_svc_event_ops are only used as input arguments to qmi_handle_init() which accepts const pointers to both qmi_ops and qmi_msg_handler. Make them const to allow the compiler to put them in read-only

[PATCH] ASoC: codecs: lpass-va-macro: add missing MODULE_DEVICE_TABLE

2020-11-20 Thread Srinivas Kandagatla
Fix module loading due by adding missing MODULE_DEVICE_TABLE. Fixes: 908e6b1df26e ("ASoC: codecs: lpass-va-macro: Add support to VA Macro") Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-va-macro.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codec

[PATCH 2/2] slimbus: qcom-ngd-ctrl: add Protection Domain Restart Support

2020-11-18 Thread Srinivas Kandagatla
Add support to protection domain restart. Protection domain restart would also restart the service just like SSR. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 1 + drivers/slimbus/qcom-ngd-ctrl.c | 24 2 files changed, 25 insertions(+) diff

[PATCH 0/2] slimbus: qcom-ngd: Add SSR and PDR support

2020-11-18 Thread Srinivas Kandagatla
support to these two events to address those race conditions. Tested it on Dragon Board DB845c. Srinivas Kandagatla (2): slimbus: qcom-ngd-ctrl: add Sub System Restart support slimbus: qcom-ngd-ctrl: add Protection Domain Restart Support drivers/slimbus/Kconfig | 2 + drivers/slimbus

[PATCH 1/2] slimbus: qcom-ngd-ctrl: add Sub System Restart support

2020-11-18 Thread Srinivas Kandagatla
of SSR up followed by QMI server up notification. Signed-off-by: Srinivas Kandagatla --- drivers/slimbus/Kconfig | 1 + drivers/slimbus/qcom-ngd-ctrl.c | 97 +++-- 2 files changed, 94 insertions(+), 4 deletions(-) diff --git a/drivers/slimbus/Kconfig b/drivers

[PATCH] mfd: core: update mfd_of_node_list list on mfd_remove_devices

2020-11-18 Thread Srinivas Kandagatla
disappear and reappear when ADSP either restarts or its services restarts. Fix this issue by removing the state entry in global mfd_of_node_list during mfd_remove_devices. Fixes: 466a62d7642f ("mfd: core: Make a best effort attempt to match devices with the correct of_nodes") Signed-off-by

Re: [PATCH v3 0/2] nvmem: skip nodes with compatibles other than "nvmem-cell"

2020-11-16 Thread Srinivas Kandagatla
On 16/11/2020 17:04, Ahmad Fatoum wrote: To allow for co-existence of NVMEM cells and other subnodes, would following patch be acceptable to you and Srini? Gentle ping. Would the patch below be acceptable? Did you have time to look at this? I did reply back to this thread way back in

[PATCH v4 1/2] dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

2020-11-16 Thread Srinivas Kandagatla
Add device tree binding Documentation details for Qualcomm SM8250 LPASS(Low Power Audio Sub System) LPI(Low Power Island) pinctrl driver. Signed-off-by: Srinivas Kandagatla --- .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 132 ++ 1 file changed, 132 insertions(+) create mode

[PATCH v4 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-11-16 Thread Srinivas Kandagatla
pin controller except setting them as gpios. Apart from this, slew rate is also available in this block for certain pins which are connected to SLIMbus or SoundWire Bus. Signed-off-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/Kconfig | 8 + drivers/pinctrl/qcom/Makef

[PATCH v4 0/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl support

2020-11-16 Thread Srinivas Kandagatla
additional patch to consolidate this along with other Audio related drivers in Maintainer file! Changes since v3: - updated bindings as per Rob's review! Srinivas Kandagatla (2): dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

[PATCH v3 1/2] dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

2020-11-09 Thread Srinivas Kandagatla
Add device tree binding Documentation details for Qualcomm SM8250 LPASS(Low Power Audio Sub System) LPI(Low Power Island) pinctrl driver. Signed-off-by: Srinivas Kandagatla --- .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 129 ++ 1 file changed, 129 insertions(+) create mode

[PATCH v3 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-11-09 Thread Srinivas Kandagatla
pin controller except setting them as gpios. Apart from this, slew rate is also available in this block for certain pins which are connected to SLIMbus or SoundWire Bus. Signed-off-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/Kconfig | 8 + drivers/pinctrl/qcom/Makef

[PATCH v3 0/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl support

2020-11-09 Thread Srinivas Kandagatla
- updated comment log to reflect few similarities between other msm TLMM blocks. Srinivas Kandagatla (2): dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 129 +++ drivers

Re: [PATCH v2 1/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-11-06 Thread Srinivas Kandagatla
Thanks Andy for the review, On 05/11/2020 12:32, Andy Shevchenko wrote: On Thu, Nov 5, 2020 at 2:06 PM Srinivas Kandagatla wrote: Add initial pinctrl driver to support pin configuration for LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl on SM8250. +config

Re: [PATCH v2 1/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-11-06 Thread Srinivas Kandagatla
Thanks Linus for review! On 06/11/2020 09:50, Linus Walleij wrote: Hi Srinivas, thanks for your patch! On Thu, Nov 5, 2020 at 1:04 PM Srinivas Kandagatla wrote: Add initial pinctrl driver to support pin configuration for LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl

[PATCH v2 2/2] dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

2020-11-05 Thread Srinivas Kandagatla
Add device tree binding Documentation details for Qualcomm SM8250 LPASS(Low Power Audio Sub System) LPI(Low Power Island) pinctrl driver. Signed-off-by: Srinivas Kandagatla --- .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 129 ++ 1 file changed, 129 insertions(+) create mode

[PATCH v2 1/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-11-05 Thread Srinivas Kandagatla
Add initial pinctrl driver to support pin configuration for LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl on SM8250. Signed-off-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/Kconfig | 8 + drivers/pinctrl/qcom/Makefile| 1 + drivers/pinctrl/qcom

[PATCH v2 0/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl support

2020-11-05 Thread Srinivas Kandagatla
as suggested by Rob. Srinivas Kandagatla (2): pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 129 +++ drivers/pinctrl/qcom/Kconfig | 8 + drivers

[PATCH] ASoC: q6afe-clocks: fix warning on symbol scope

2020-11-05 Thread Srinivas Kandagatla
This patch fixes below warning when module is compiled with W=1 C=1 sound/soc/qcom/qdsp6/q6afe-clocks.c:122:18: warning: symbol 'q6afe_clks' was not declared. Should it be static? Fixes: 520a1c396d196 ("ASoC: q6afe-clocks: add q6afe clock controller") Signed-off-by: Srinivas

[PATCH] ASoc: qcom: lpass-cpu: fix warning on symbol scope

2020-11-05 Thread Srinivas Kandagatla
This patch fixes below warning when module is compiled with W=1 C=1 lpass-cpu.c:677:22: warning: symbol 'lpass_hdmi_regmap_config' was not declared. Should it be static? Fixes: 7cb37b7bd0d3 ("ASoC: qcom: Add support for lpass hdmi driver") Signed-off-by: Srinivas Kandagatla --- soun

[PATCH v3 0/6] ASoC: codecs: add support for LPASS Codec macros

2020-11-05 Thread Srinivas Kandagatla
unnecessary variable intializations removed, suggested by Pierre - fixed a static checker error - collected reviews for dt-bindings. - fixed licence headers as suggested by Pierre. Srinivas Kandagatla (6): ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec ASoC: codecs: lpass-wsa-macro

[PATCH v3 1/6] ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec

2020-11-05 Thread Srinivas Kandagatla
This binding is for LPASS has internal codec WSA macro which is for connecting with WSA Smart speakers. Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../bindings/sound/qcom,lpass-wsa-macro.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644

[PATCH v3 6/6] ASoC: codecs: lpass-va-macro: add dapm widgets and routes

2020-11-05 Thread Srinivas Kandagatla
Add dapm widgets and routes for this codec. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-va-macro.c | 620 ++ 1 file changed, 620 insertions(+) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index e7590e70f2c0

[PATCH v3 5/6] ASoC: codecs: lpass-va-macro: Add support to VA Macro

2020-11-05 Thread Srinivas Kandagatla
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec VA macro block which is used for connecting with DMICs. This patch adds support to the codec part of the VA Macro block Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile

[PATCH v3 4/6] ASoC: qcom: dt-bindings: add bindings for lpass va macro codec

2020-11-05 Thread Srinivas Kandagatla
This binding is for LPASS has internal codec VA macro which is for connecting with DMICs. Signed-off-by: Srinivas Kandagatla Reviewed-by: Rob Herring --- .../bindings/sound/qcom,lpass-va-macro.yaml | 67 +++ 1 file changed, 67 insertions(+) create mode 100644 Documentation

[PATCH v3 2/6] ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro

2020-11-05 Thread Srinivas Kandagatla
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec WSA macro block which is used for connecting with WSA Smart speakers over soundwire. This patch adds support to the codec part of the WSA Macro block. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/Kconfig |4

[PATCH v3 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route

2020-11-05 Thread Srinivas Kandagatla
This patch adds dapm widgets and routes on this codec Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-wsa-macro.c | 1081 1 file changed, 1081 insertions(+) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index

[PATCH] soundwire: Fix DEBUG_LOCKS_WARN_ON for uninitialized attribute

2020-11-04 Thread Srinivas Kandagatla
lockdep happy! Fixes: bcac59029955 ("soundwire: add Slave sysfs support") Signed-off-by: Srinivas Kandagatla --- drivers/soundwire/sysfs_slave_dpn.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soundwire/sysfs_slave_dpn.c b/drivers/soundwire/sysfs_slave_dpn.c index 05

Re: [PATCH v2 2/6] ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro

2020-11-03 Thread Srinivas Kandagatla
On 29/10/2020 15:47, Pierre-Louis Bossart wrote: +static void wsa_macro_mclk_enable(struct wsa_macro *wsa, bool mclk_enable) +{ +    struct regmap *regmap = wsa->regmap; + +    if (mclk_enable) { +    if (wsa->wsa_mclk_users == 0) { +    regcache_mark_dirty(regmap); +   

Re: [PATCH v2 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route

2020-11-03 Thread Srinivas Kandagatla
On 29/10/2020 15:52, Pierre-Louis Bossart wrote: +static int wsa_macro_enable_mix_path(struct snd_soc_dapm_widget *w, + struct snd_kcontrol *kcontrol, int event) +{ +    struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); +    u16 gain_reg; +   

Re: [PATCH] ASoC: wcd9335: remove unneeded semicolon

2020-11-03 Thread Srinivas Kandagatla
Thanks for the patch, On 01/11/2020 17:21, t...@redhat.com wrote: From: Tom Rix A semicolon is not needed after a switch statement. Signed-off-by: Tom Rix Reviewed-by: Srinivas Kandagatla --- sound/soc/codecs/wcd-clsh-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 5/6] ASoC: codecs: lpass-va-macro: Add support to VA Macro

2020-11-03 Thread Srinivas Kandagatla
Thanks Pierre for review, On 29/10/2020 15:56, Pierre-Louis Bossart wrote: diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c new file mode 100644 index ..8cb23c32631d --- /dev/null +++ b/sound/soc/codecs/lpass-va-macro.c @@ -0,0 +1,882 @@ +//

Re: [PATCH v3 0/4] nvmem: qfprom: Avoid untouchable regions

2020-11-02 Thread Srinivas Kandagatla
On 29/10/2020 00:28, Evan Green wrote: Certain fuses are protected by the XPU such that the AP cannot access them. Attempting to do so causes an SError. Introduce an SoC-specific compatible string, and introduce support into the nvmem core to avoid accessing specified regions. Then use those

[PATCH 0/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl support

2020-10-30 Thread Srinivas Kandagatla
LPASS codec via WSA and VA macros respectively. Most of the work is derived from downstream Qualcomm kernels. Credits to various Qualcomm authors from Patrick Lai's team who have contributed to this code. Srinivas Kandagatla (2): dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

[PATCH 1/2] dt-bindings: pinctrl: qcom: Add sm8250 lpass lpi pinctrl bindings

2020-10-30 Thread Srinivas Kandagatla
Add device tree binding Documentation details for Qualcomm SM8250 LPASS(Low Power Audio Sub System) LPI(Low Power Island) pinctrl driver. Signed-off-by: Srinivas Kandagatla --- .../pinctrl/qcom,lpass-lpi-pinctrl.yaml | 129 ++ 1 file changed, 129 insertions(+) create mode

[PATCH 2/2] pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver

2020-10-30 Thread Srinivas Kandagatla
Add initial pinctrl driver to support pin configuration for LPASS (Low Power Audio SubSystem) LPI (Low Power Island) pinctrl on SM8250. Signed-off-by: Srinivas Kandagatla --- drivers/pinctrl/qcom/Kconfig | 8 + drivers/pinctrl/qcom/Makefile| 1 + drivers/pinctrl/qcom

Re: [PATCH v2 19/39] docs: ABI: stable: make files ReST compatible

2020-10-30 Thread Srinivas Kandagatla
/stable/firewire-cdev| 4 + Documentation/ABI/stable/sysfs-acpi-pmprofile | 22 +++-- Documentation/ABI/stable/sysfs-bus-firewire | 3 + Documentation/ABI/stable/sysfs-bus-nvmem | 19 ++-- for nvmem parts: Acked-by: Srinivas Kandagatla --srini Documentation/ABI/stable

Re: [PATCH v3 3/4] nvmem: core: Add support for keepout regions

2020-10-29 Thread Srinivas Kandagatla
Thanks Evan for doing this, On 29/10/2020 00:28, Evan Green wrote: Introduce support into the nvmem core for arrays of register ranges that should not result in actual device access. For these regions a constant byte (repeated) is returned instead on read, and writes are quietly ignored and

[PATCH v2 6/6] ASoC: codecs: lpass-va-macro: add dapm widgets and routes

2020-10-29 Thread Srinivas Kandagatla
Add dapm widgets and routes for this codec. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-va-macro.c | 618 ++ 1 file changed, 618 insertions(+) diff --git a/sound/soc/codecs/lpass-va-macro.c b/sound/soc/codecs/lpass-va-macro.c index 8cb23c32631d

[PATCH v2 4/6] ASoC: qcom: dt-bindings: add bindings for lpass va macro codec

2020-10-29 Thread Srinivas Kandagatla
This binding is for LPASS has internal codec VA macro which is for connecting with DMICs. Signed-off-by: Srinivas Kandagatla --- .../bindings/sound/qcom,lpass-va-macro.yaml | 67 +++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound

[PATCH v2 3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route

2020-10-29 Thread Srinivas Kandagatla
This patch adds dapm widgets and routes on this codec Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/lpass-wsa-macro.c | 1006 1 file changed, 1006 insertions(+) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index

[PATCH v2 5/6] ASoC: codecs: lpass-va-macro: Add support to VA Macro

2020-10-29 Thread Srinivas Kandagatla
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec VA macro block which is used for connecting with DMICs. This patch adds support to the codec part of the VA Macro block Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/Kconfig | 4 + sound/soc/codecs/Makefile

[PATCH v2 2/6] ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro

2020-10-29 Thread Srinivas Kandagatla
Qualcomm LPASS (Low Power Audio SubSystem) has internal codec WSA macro block which is used for connecting with WSA Smart speakers over soundwire. This patch adds support to the codec part of the WSA Macro block. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/Kconfig |4

[PATCH v2 1/6] ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec

2020-10-29 Thread Srinivas Kandagatla
This binding is for LPASS has internal codec WSA macro which is for connecting with WSA Smart speakers. Signed-off-by: Srinivas Kandagatla --- .../bindings/sound/qcom,lpass-wsa-macro.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v2 0/6] ASoC: codecs: add support for LPASS Codec macros

2020-10-29 Thread Srinivas Kandagatla
to fix cppcheck errors suggested by Pierre - fixed various coding style and variable initialization suggested by Pierre. - yaml bindings clock names replaced with constants. Srinivas Kandagatla (6): ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec ASoC: codecs: lpass-wsa-macro

[PATCH 1/2] ASoC: qcom: dt-bindings: sm8250: update compatibles

2020-10-29 Thread Srinivas Kandagatla
: Add SM8250 sound card bindings") Reported-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/qcom,sm82

[PATCH 2/2] ASoC: qcom: sm8250: update compatible with new bindings

2020-10-29 Thread Srinivas Kandagatla
Update compatible string as board compatible and device compatible should not be same!. Make the driver inline with the new bindings. Fixes: aa2e2785545a ("ASoC: qcom: sm8250: add sound card qrb5165-rb5 support") Reported-by: Rob Herring Signed-off-by: Srinivas Kandagatla --- soun

<    1   2   3   4   5   6   7   8   9   10   >