Re: [virtio-dev] [RFC for Linux v4 0/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES to report continuous pages

2020-07-16 Thread teawater
> 2020年7月16日 18:45,Michael S. Tsirkin 写道: > > On Thu, Jul 16, 2020 at 03:01:18PM +0800, teawater wrote: >> >> >>> 2020年7月16日 14:38,Michael S. Tsirkin 写道: >>> >>> On Thu, Jul 16, 2020 at 10:41:50AM +0800, Hui Zhu wrote: >>>>

Re: [RFC for Linux v4 1/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES and inflate_cont_vq

2020-07-16 Thread teawater
e? > Could you write up something about it? Continuous pages are report by num_pfns and pfns in virtio_balloon too. The function to set pfns is set_page_pfns_size in https://github.com/teawater/linux/blob/balloon_conts/drivers/virtio/virtio_balloon.c#L221 static void set_page_pfns_siz

Re: [virtio-dev] [RFC for qemu v4 2/2] virtio_balloon: Add dcvq to deflate continuous pages

2020-07-16 Thread teawater
> 2020年7月16日 14:39,Michael S. Tsirkin 写道: > > On Thu, Jul 16, 2020 at 10:41:55AM +0800, Hui Zhu wrote: >> This commit adds a vq dcvq to deflate continuous pages. >> When VIRTIO_BALLOON_F_CONT_PAGES is set, try to get continuous pages >> from icvq and use madvise MADV_WILLNEED with the pages.

Re: [virtio-dev] [RFC for Linux v4 0/2] virtio_balloon: Add VIRTIO_BALLOON_F_CONT_PAGES to report continuous pages

2020-07-16 Thread teawater
t; // This is the THP number after this operation. >> cat /proc/meminfo | grep AnonHugePages: >> AnonHugePages:907264 kB These lines are from host. > > I'm a bit confused about which of the above run within guest, > and which run within host. Could you explain pls? >

Re: [PATCH] virtio_mem: prevent overflow with subblock size

2020-06-08 Thread teawater
> 2020年6月8日 14:58,David Hildenbrand 写道: > > On 08.06.20 08:14, Michael S. Tsirkin wrote: >> If subblock size is large (e.g. 1G) 32 bit math involving it >> can overflow. Rather than try to catch all instances of that, >> let's tweak block size to 64 bit. > > I fail to see where we could

Re: [PATCH v4 00/15] virtio-mem: paravirtualized memory

2020-05-19 Thread teawater
Hi David, Thanks for your work. I tried this version with cloud-hypervisor master. It worked very well. Best, Hui > 2020年5月7日 22:01,David Hildenbrand 写道: > > This series is based on v5.7-rc4. The patches are located at: >https://github.com/davidhildenbrand/linux.git virtio-mem-v4 > >

Re: [virtio-dev] [PATCH v3 00/15] virtio-mem: paravirtualized memory

2020-05-14 Thread teawater
> 2020年5月14日 20:19,David Hildenbrand 写道: > > On 14.05.20 13:47, David Hildenbrand wrote: >> On 14.05.20 13:10, David Hildenbrand wrote: >>> On 14.05.20 12:12, David Hildenbrand wrote: >>>> On 14.05.20 12:02, teawater wrote: >>>>> &

Re: [virtio-dev] [PATCH v3 00/15] virtio-mem: paravirtualized memory

2020-05-14 Thread teawater
> 2020年5月14日 16:48,David Hildenbrand 写道: > > On 14.05.20 08:44, teawater wrote: >> Hi David, >> >> I got a kernel warning with v2 and v3. > > Hi Hui, > > thanks for playing with the latest versions. Surprisingly, I can > reproduce even by hotplu

Re: [virtio-dev] [PATCH v3 00/15] virtio-mem: paravirtualized memory

2020-05-14 Thread teawater
Hi David, I got a kernel warning with v2 and v3. // start a QEMU that is get from https://github.com/davidhildenbrand/qemu/tree/virtio-mem-v2 and setup a file as a ide disk. /home/teawater/qemu/qemu/x86_64-softmmu/qemu-system-x86_64 -machine pc-i440fx-2.1,accel=kvm,usb=off -cpu host -no-reboot