[patch V2 04/13] x86/apic: Split out spurious handling code

2021-02-09 Thread Thomas Gleixner
From: Thomas Gleixner sysvec_spurious_apic_interrupt() calls into the handling body of __spurious_interrupt() which is not obvious as that function is declared inside the DEFINE_IDTENTRY_IRQ(spurious_interrupt) macro. As __spurious_interrupt() is currently always inlined this ends up with two

[patch V2 10/13] x86: Select CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK

2021-02-09 Thread Thomas Gleixner
From: Thomas Gleixner Now that all invocations of irq_exit_rcu() happen on the irq stack, turn on CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK which causes the core code to invoke __do_softirq() directly without going through do_softirq_own_stack(). That means do_softirq_own_stack() is only invoked from

[patch V2 01/13] x86/entry: Fix instrumentation annotation

2021-02-09 Thread Thomas Gleixner
From: Thomas Gleixner Embracing a callout into instrumentation_begin() / instrumentation_begin() does not really make sense. Make the latter instrumentation_end(). Fixes: 2f6474e4636b ("x86/entry: Switch XEN/PV hypercall entry to IDTENTRY") Signed-off-by: Thomas Gleixner Reviewed-by:

[patch V2 00/13] x86/irq/64: Inline irq stack switching

2021-02-09 Thread Thomas Gleixner
This is the second version of this series. V1 is available here: https://lore.kernel.org/r/20210204204903.350275...@linutronix.de The recent effort to make the ASM entry code slim and unified moved the irq stack switching out of the low level ASM code so that the whole return from interrupt wor

[patch V2 07/13] x86/entry: Convert device interrupts to inline stack switching

2021-02-09 Thread Thomas Gleixner
From: Thomas Gleixner Convert device interrupts to inline stack switching by replacing the existing macro implementation with the new inline version. Tweak the function signature of the actual handler function to have the vector argument as u32. That allows the inline macro to avoid extra

[patch V2 09/13] x86/softirq: Remove indirection in do_softirq_own_stack()

2021-02-09 Thread Thomas Gleixner
From: Thomas Gleixner Use the new inline stack switching and remove the old ASM indirect call implementation. Signed-off-by: Thomas Gleixner Reviewed-by: Kees Cook --- arch/x86/entry/entry_64.S| 39 - arch/x86/include/asm/irq_stack.h | 52

[patch V2 05/13] x86/irq: Provide macro for inlining irq stack switching

2021-02-09 Thread Thomas Gleixner
From: Thomas Gleixner The effort to make the ASM entry code slim and unified moved the irq stack switching out of the low level ASM code so that the whole return from interrupt work and state handling can be done in C and the ASM code just handles the low level details of entry and exit. This

[patch V2 03/13] x86/irq/64: Adjust the per CPU irq stack pointer by 8

2021-02-09 Thread Thomas Gleixner
From: Thomas Gleixner The per CPU hardirq_stack_ptr contains the pointer to the irq stack in the form that it is ready to be assigned to [ER]SP so that the first push ends up on the top entry of the stack. But the stack switching on 64 bit has the following rules: 1) Store the current

[patch V2 02/13] x86/irq: Sanitize irq stack tracking

2021-02-09 Thread Thomas Gleixner
From: Thomas Gleixner The recursion protection for hard interrupt stacks is an unsigned int per CPU variable initialized to -1 named __irq_count. The irq stack switching is only done when the variable is -1, which creates worse code than just checking for 0. When the stack switching happens it

Re: [patch 11/12] softirq: Allow inlining do_softirq_own_stack()

2021-02-09 Thread Thomas Gleixner
Lai, On Fri, Feb 05 2021 at 12:38, Thomas Gleixner wrote: > On Fri, Feb 05 2021 at 18:14, Lai Jiangshan wrote: >> On Fri, Feb 5, 2021 at 10:04 AM Thomas Gleixner wrote: >>> static inline void do_softirq_own_stack(void) >>> { >> >> Hello >> >>

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-09 Thread Thomas Gleixner
On Tue, Feb 09 2021 at 10:22, Josh Poimboeuf wrote: > On Tue, Feb 09, 2021 at 04:12:33PM +0100, Thomas Gleixner wrote: >> On Mon, Feb 08 2021 at 14:42, Josh Poimboeuf wrote: >> > On Thu, Feb 04, 2021 at 09:49:08PM +0100, Thomas Gleixner wrote: >> >> #ifdef CONFI

Re: [PATCH v2 2/4] MIPS: microMIPS: Fix the judgment of mm_jr16_op and mm_jalr_op

2021-02-09 Thread Thomas Bogendoerfer
return ((ip->u_format.uimmediate >> 6) & mm_jalr_op) == mm_jalr_op; > > + return ((ip->u_format.uimmediate >> 6) & GENMASK(9, 0)) == mm_jalr_op; > > You've now excluded JALR.HB, JALRS, and JALRS.HB instructions. The mask > was there for a reason

Re: [PATCH 2/6] MIPS: Loongson64: Distinguish firmware dependencies DTB/LEFI.

2021-02-09 Thread Thomas Bogendoerfer
GSON_DTB = 1, > +}; > + > struct loongson_system_configuration { > + enum loongson_fw_interface fw_interface; do you need this for future use ? Right now this information is only needed in init.c and doesn't need to be exported... > + if (fw_arg2 == 0 || (be32_to_cpup((__be32 *)fw_ar

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-09 Thread Thomas Gleixner
On Mon, Feb 08 2021 at 14:42, Josh Poimboeuf wrote: > On Thu, Feb 04, 2021 at 09:49:08PM +0100, Thomas Gleixner wrote: >> #ifdef CONFIG_X86_64 >> + >> +#ifdef CONFIG_UNWINDER_FRAME_POINTER >> +# define IRQSTACK_CALL_CONSTRAINT , ASM_CALL_CONSTR

Re: [PATCH v2] MIPS: Make check condition for SDBBP consistent with EJTAG spec

2021-02-09 Thread Thomas Bogendoerfer
On Tue, Feb 09, 2021 at 09:09:52PM +0800, Tiezhu Yang wrote: > On 02/09/2021 08:11 PM, Thomas Bogendoerfer wrote: > > On Tue, Feb 09, 2021 at 01:05:25PM +0800, Tiezhu Yang wrote: > > > According to MIPS EJTAG Specification [1], a Debug Breakpoint > > > exception occurs w

Re: [PATCH 5/6] driver core: lift dma_default_coherent into common code

2021-02-09 Thread Thomas Bogendoerfer
pr_info("Hardware DMA cache coherency disabled\n"); > return; this hunk needs to be in patch 1, otherwise it's not compilable Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH 4/6] MIPS: refactor the maybe coherent DMA indicators

2021-02-09 Thread Thomas Bogendoerfer
{ > - return coherentio == IO_COHERENCE_ENABLED || > - (coherentio == IO_COHERENCE_DEFAULT && hw_coherentio); > + return dma_default_coherent; this breaks overriding of coherentio via command line. plat_mem_setup/ plat_setup_iocoherency is calle

Re: [PATCH mips-fixes] MIPS: compressed: fix build with enabled UBSAN

2021-02-09 Thread Thomas Bogendoerfer
le to exclude > it from instrumentation scope and fix this issue. > > Fixes: 1e35918ad9d1 ("MIPS: Enable Undefined Behavior Sanitizer UBSAN") > Cc: sta...@vger.kernel.org # 5.0+ > Signed-off-by: Alexander Lobakin > --- > arch/mips/boot/compressed/Makefile | 1 + >

Re: [PATCH v3 1/2] MIPS: relocatable: Provide kaslr_offset() to get the kernel offset

2021-02-09 Thread Thomas Bogendoerfer
4: Add KASLR support") > Reported-by: kernel test robot > Signed-off-by: Jinyang He > --- > arch/mips/include/asm/page.h | 6 ++ > arch/mips/kernel/relocate.c | 10 ++ > arch/mips/kernel/setup.c | 3 +++ > 3 files changed, 19 insertions(+) applied to mips-n

Re: [PATCH v2] MIPS: crash_dump.c: Simplify copy_oldmem_page()

2021-02-09 Thread Thomas Bogendoerfer
mp.c | 41 ++--- > 1 file changed, 6 insertions(+), 35 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH v3 2/2] MIPS: relocatable: Use __kaslr_offset in show_kernel_relocation

2021-02-09 Thread Thomas Bogendoerfer
off-by: Jinyang He > --- > arch/mips/kernel/relocate.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH] MIPS: process: Fix no previous prototype warning

2021-02-09 Thread Thomas Bogendoerfer
t robot > Signed-off-by: Jinyang He > --- > arch/mips/kernel/process.c | 2 ++ > 1 file changed, 2 insertions(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH v2] MIPS: Make check condition for SDBBP consistent with EJTAG spec

2021-02-09 Thread Thomas Bogendoerfer
IZE, sp) > MTC0k0, CP0_DESAVE > mfc0k0, CP0_DEBUG > > - sll k0, k0, 30 # Check for SDBBP. > - bgezk0, ejtag_return > + andik0, k0, MIPS_DEBUG_DBP # Check for SDBBP. > + beqzk0, ejtag_return IMHO bot

Re: [PATCH] Revert "mips: Manually call fdt_init_reserved_mem() method"

2021-02-09 Thread Thomas Bogendoerfer
eing created twice bigger than implied. > > Fixes: a94e4f24ec83 ("MIPS: init: Drop boot_mem_map") > Reported-by: Paul Cercueil > Signed-off-by: Serge Semin > --- > arch/mips/kernel/setup.c | 3 --- > 1 file changed, 3 deletions

Re Thanks.

2021-02-08 Thread Mr.Richard Thomas
Dear Friend, I will be pleased if you can allow me to invest $104M Dollars in Estate Management,in your company or any area you best that will be of good profit to both of us Please do well to respond including your information for more details. Thanks. Mr.Richard Thomas

Re: [RFC v3 10/10] drm/dp: Extract i915's eDP backlight code into DRM helpers

2021-02-08 Thread Thomas Zimmermann
return 0; +} +EXPORT_SYMBOL(drm_edp_backlight_set_level); + +static int +drm_edp_backlight_set_enable(struct drm_dp_aux *aux, const struct drm_edp_backlight_info *bl, +bool enable) +{ + int ret; + u8 buf; + + /* The panel uses something other then DPCD for e

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2021-02-05 Thread Thomas Gleixner
On Fri, Feb 05 2021 at 23:23, Thomas Gleixner wrote: > On Thu, Feb 04 2021 at 14:17, Nitesh Narayan Lal wrote: >> On 2/4/21 2:06 PM, Marcelo Tosatti wrote: >>>>> How about adding a new flag for isolcpus instead? >>>>> >>>> Do you mean a fla

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2021-02-05 Thread Thomas Gleixner
eeping for all the devices at the time of IRQ distribution? >> Yes a new flag for isolcpus. HK_FLAG_IRQ_SPREAD or some better name. > > Does sounds like a nice idea to explore, lets see what Thomas thinks about it. I just read back up on that whole discussion and stared into the usage sites a bi

[tip: sched/urgent] Revert "lib: Restrict cpumask_local_spread to houskeeping CPUs"

2021-02-05 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the sched/urgent branch of tip: Commit-ID: 2452483d9546de1c540f330469dc4042ff089731 Gitweb: https://git.kernel.org/tip/2452483d9546de1c540f330469dc4042ff089731 Author:Thomas Gleixner AuthorDate:Fri, 05 Feb 2021 23:28:29 +01:00

Re: [PATCH] hrtimer: Interrupt storm on clock_settime

2021-02-05 Thread Thomas Gleixner
On Thu, Jan 28 2021 at 15:02, Mikael Beckius wrote: > During clock_settime absolute realtime timers may get updated to expire > sooner in absolute monotonic time but if hrtimer_force_reprogram is > called as part of a clock_settime and the next hard hrtimer expires > before the next soft hrtimer s

Re: [PATCH][V2] drm/mgag200: make a const array static, makes object smaller

2021-02-05 Thread Thomas Zimmermann
39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o After: text data bss dechex filename 34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o (gcc version 10.2.0) Signed-off-by: Colin Ian King Reviewed-by: Thomas Zimmermann --- V2: move s

Re: [patch 03/12] x86/irq/64: Adjust the per CPU irq stack pointer by 8

2021-02-05 Thread Thomas Gleixner
On Fri, Feb 05 2021 at 14:53, Peter Zijlstra wrote: > On Thu, Feb 04, 2021 at 09:49:06PM +0100, Thomas Gleixner wrote: >> Move the definition >> next to the inuse flag so they end up in the same cache line. > >> -DEFINE_PER_CPU(struct irq_stack *, hardirq_stack_ptr);

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2021-02-05 Thread Thomas Gleixner
On Fri, Jan 29 2021 at 09:35, Nitesh Narayan Lal wrote: > On 1/29/21 9:23 AM, Marcelo Tosatti wrote: >>> I am not sure about the PCI patch as I don't think we can control that from >>> the userspace or maybe I am wrong? >> You mean "lib: Restrict cpumask_local_spread to housekeeping CPUs" ? > > No,

Re: [PATCH] ntp: use memset and offsetof init

2021-02-05 Thread Thomas Gleixner
On Wed, Jan 20 2021 at 10:51, Yejune Deng wrote: > In pps_fill_timex(), use memset and offsetof instead of '= 0'. > > Signed-off-by: Yejune Deng > --- > kernel/time/ntp.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c >

Re: [PATCH] kernel: irq: Some words replce with better alternatives in the file timings.c

2021-02-05 Thread Thomas Gleixner
Bhaskar, On Fri, Feb 05 2021 at 17:58, Bhaskar Chowdhury wrote: The correct prefix for this file is: genirq/timings: which you can find via: git log kernel/irq/timings.c Also if you send a patch with spelling fixes then you might take care that your subject line does not contain spelling mi

Re: [RFC: timer passthrough 5/9] KVM: vmx: use tsc_adjust to enable tsc_offset timer passthrough

2021-02-05 Thread Thomas Gleixner
On Fri, Feb 05 2021 at 13:43, Peter Zijlstra wrote: > On Fri, Feb 05, 2021 at 06:03:13PM +0800, Zhimin Feng wrote: >> +static void vmx_adjust_tsc_offset(struct kvm_vcpu *vcpu, bool to_host) >> +{ >> +u64 tsc_adjust; >> +struct timer_passth_info *local_timer_info; >> + >> +local_timer_in

Re: [RFC: timer passthrough 1/9] KVM: vmx: hook set_next_event for getting the host tscd

2021-02-05 Thread Thomas Gleixner
On Fri, Feb 05 2021 at 18:03, Zhimin Feng wrote: > @@ -520,6 +521,24 @@ struct kvm_vcpu_hv { > cpumask_t tlb_flush; > }; > > +enum tick_device_mode { > + TICKDEV_MODE_PERIODIC, > + TICKDEV_MODE_ONESHOT, > +}; > + > +struct tick_device { > + struct clock_event_device *evtdev; >

Re: [PATCH] alarmtimer: Do not mess with an enqueued hrtimer

2021-02-05 Thread Thomas Gleixner
On Thu, Jan 07 2021 at 13:33, Li RongQing wrote: > when an hrtimer is enqueued already, its expires should be not > changed, otherwise, this will corrupts the ordering of the > timerqueue RB tree, if other hrtimer is enqueued before this > hrtimer is restarted, whole RB tree is completely hosed > >

Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-05 Thread Thomas Gleixner
Uros, On Fri, Feb 05 2021 at 12:03, Uros Bizjak wrote: can you please fix your mail client to generate at least the 'In-Reply-to:' header? Lacking that header breaks threading on lore: https://lore.kernel.org/lkml/20210204204903.350275...@linutronix.de/ Your mail is missing there. Ideal

Re: [PATCH 1/2] x86/hw_breakpoint: Prevent data breakpoints on __per_cpu_offset

2021-02-05 Thread Thomas Gleixner
On Thu, Feb 04 2021 at 16:11, Andy Lutomirski wrote: > On Thu, Feb 4, 2021 at 6:26 AM Lai Jiangshan wrote: >> When FSGSBASE is enabled, paranoid_entry() fetches the per-CPU >> GSBASE value via __per_cpu_offset or pcpu_unit_offsets. >> >> When data breakpoint is set on __per_cpu_offset[cpu] (read-w

Re: [patch 11/12] softirq: Allow inlining do_softirq_own_stack()

2021-02-05 Thread Thomas Gleixner
On Fri, Feb 05 2021 at 18:14, Lai Jiangshan wrote: > On Fri, Feb 5, 2021 at 10:04 AM Thomas Gleixner wrote: >> static inline void do_softirq_own_stack(void) >> { > > Hello > > This patch and the next patch have three "#if[n]def" with > __ARCH_HAS_DO_

Re: [PATCH v4 2/5] KVM: X86: Expose PKS to guest

2021-02-05 Thread Thomas Gleixner
On Fri, Feb 05 2021 at 11:10, Paolo Bonzini wrote: > On 05/02/21 10:56, Borislav Petkov wrote: >>> This would need an ack from the x86 people. Andy, Boris? >> >> This looks like the PKS baremetal pile needs to be upstream first. > > Yes, it does. I would like to have an ack for including the abo

Re: [PATCH RESEND] entry: Use different define for selector variable in SUD

2021-02-05 Thread Thomas Gleixner
Gabriel, On Thu, Feb 04 2021 at 13:40, Gabriel Krisman Bertazi wrote: > Michael Kerrisk suggested that, from an API perspective, it is a bad > idea to share the PR_SYS_DISPATCH_ defines between the prctl operation > and the selector variable. Therefore, define two new constants to be > used by SU

[patch 11/12] softirq: Allow inlining do_softirq_own_stack()

2021-02-04 Thread Thomas Gleixner
The function to switch to the irq stack on x86 is now minimal and there is only a single caller. Allow the stack switch to be inlined. Signed-off-by: Thomas Gleixner --- include/linux/interrupt.h |2 ++ kernel/softirq.c |4 2 files changed, 6 insertions(+) --- a/include

[patch 00/12] x86/irq/64: Inline irq stack switching

2021-02-04 Thread Thomas Gleixner
The recent effort to make the ASM entry code slim and unified moved the irq stack switching out of the low level ASM code so that the whole return from interrupt work and state handling can be done in C and the ASM code just handles the true low level details of entry and exit (which is horrible en

[patch 09/12] x86/softirq: Remove indirection in do_softirq_own_stack()

2021-02-04 Thread Thomas Gleixner
Use the new inline stack switching and remove the old ASM indirect call implementation. Signed-off-by: Thomas Gleixner --- arch/x86/entry/entry_64.S| 39 - arch/x86/include/asm/irq_stack.h | 52 --- arch/x86/kernel

[patch 12/12] x86/softirq/64: Inline do_softirq_own_stack()

2021-02-04 Thread Thomas Gleixner
There is no reason to have this as a seperate function for a single caller. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/irq.h |3 +++ arch/x86/include/asm/irq_stack.h |3 +-- arch/x86/kernel/irq_64.c |5 - 3 files changed, 4 insertions(+), 7 deletions

[patch 07/12] x86/entry: Convert device interrupts to inline stack switching

2021-02-04 Thread Thomas Gleixner
compiler be smarter about the whole thing. Signed-off-by: Thomas Gleixner --- arch/x86/entry/entry_64.S|1 arch/x86/include/asm/idtentry.h |9 ++ arch/x86/include/asm/irq_stack.h | 58 --- arch/x86/kernel/irq.c|2 - 4 files

[patch 08/12] x86/entry: Use run_sysvec_on_irqstack_cond() for XEN upcall

2021-02-04 Thread Thomas Gleixner
To avoid yet another macro implementation reuse the existing run_sysvec_on_irqstack_cond() and move the set_irq_regs() handling into the called function. Makes the code even simpler. Signed-off-by: Thomas Gleixner --- arch/x86/entry/common.c | 19 ++- 1 file changed, 6

[patch 02/12] x86/irq: Sanitize irq stack tracking

2021-02-04 Thread Thomas Gleixner
), but there is no reason to do so. It simply can use straight writes. This is a historical leftover from the low level ASM code which used inc and jz to make a decision. Rename it to hardirq_stack_inuse, make it a bool and use plain stores. Signed-off-by: Thomas Gleixner --- arch/x86/include

[patch 10/12] x86: Select CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK

2021-02-04 Thread Thomas Gleixner
it can't be on the irq stack. Remove the conditional from run_softirq_on_irqstack_cond() and rename the function accordingly. Signed-off-by: Thomas Gleixner --- arch/x86/Kconfig |1 + arch/x86/include/asm/irq_stack.h | 19 --- arch/x86/kernel/irq

[patch 01/12] x86/entry: Fix instrumentation annotation

2021-02-04 Thread Thomas Gleixner
Embracing a callout into instrumentation_begin() / instrumentation_begin() does not really make sense. Make the latter instrumentation_end(). Signed-off-by: Thomas Gleixner --- arch/x86/entry/common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/entry/common.c +++ b

[patch 06/12] x86/entry: Convert system vectors to irq stack macro

2021-02-04 Thread Thomas Gleixner
To inline the stack switching and to prepare for enabling CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK provide a macro template for system vectors and device interrupts and convert the system vectors over to it. Signed-off-by: Thomas Gleixner --- arch/x86/entry/entry_64.S|1 arch/x86/include

[patch 04/12] x86/apic: Split out spurious handling code

2021-02-04 Thread Thomas Gleixner
for no reason. Split the handling function out and invoke it from both entry points. Signed-off-by: Thomas Gleixner --- arch/x86/kernel/apic/apic.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel

[patch 05/12] x86/irq: Provide macro for inlining irq stack switching

2021-02-04 Thread Thomas Gleixner
RSP back Document the unholy asm() logic while at it to reduce the amount of head scratching required a half year from now. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/irq_stack.h | 104 +++ 1 file changed, 104 insertions(+) --- a/arch/x86/include

[patch 03/12] x86/irq/64: Adjust the per CPU irq stack pointer by 8

2021-02-04 Thread Thomas Gleixner
stack data type which is on 64bit only used to declare the backing store. Move the definition next to the inuse flag so they end up in the same cache line. Signed-off-by: Thomas Gleixner --- arch/x86/include/asm/irq_stack.h |6 +++--- arch/x86/include/asm/processor.h |7 +++ arch/x86/

Re: [PATCH v2 1/3] MIPS: kernel: Support extracting off-line stack traces from user-space with perf

2021-02-04 Thread Thomas Bogendoerfer
reate mode 100644 arch/mips/include/uapi/asm/perf_regs.h > create mode 100644 arch/mips/kernel/perf_regs.c applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH mips-next] MIPS: pistachio: remove obsolete include/asm/mach-pistachio

2021-02-04 Thread Thomas Bogendoerfer
644 arch/mips/include/asm/mach-pistachio/irq.h applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH v4 0/5] Add support for Realtek RTL838x/RTL839x switch SoCs

2021-02-04 Thread Thomas Bogendoerfer
s/realtek-rtl.yaml > create mode 100644 arch/mips/boot/dts/realtek/Makefile > create mode 100644 arch/mips/boot/dts/realtek/cisco_sg220-26.dts > create mode 100644 arch/mips/boot/dts/realtek/rtl838x.dtsi > create mode 100644 arch/mips/boot/dts/realtek/rtl83xx.dtsi

Re: [PATCH v4 5/5] mips: dts: Add support for Cisco SG220-26 switch

2021-02-04 Thread Thomas Bogendoerfer
6 > + bool "Cisco SG220-26" > +endchoice > +endif > + I've dropped that while applying, because it's just one DT so far and if there are more of them, please move to arch/mips/realtek/Kconfig Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH v6 02/10] Revert "drm/qxl: do not run release if qxl failed to init"

2021-02-04 Thread Thomas Zimmermann
Hi Tong Am 04.02.21 um 19:52 schrieb Tong Zhang: Hi Thomas, The original problem was qxl_device_init() can fail, when it fails there is no need to call qxl_modeset_fini(qdev); qxl_device_fini(qdev); But those two functions are otherwise called in the qxl_drm_release() - OK

Re: [PATCH v6 02/10] Revert "drm/qxl: do not run release if qxl failed to init"

2021-02-04 Thread Thomas Zimmermann
have to be reordered correctly. With the citation style address: Acked-by: Thomas Zimmermann qxl_modeset_fini(qdev); qxl_device_fini(qdev); } -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB

Re: [PATCH] drm/mgag200: make a const array static, makes object smaller

2021-02-04 Thread Thomas Zimmermann
er doesn't figure this out automatically. When I once tested this (in userspace) it did so. Maybe the kernel is different? For style reasons, I would have moved the static definition to the top of the function; before the variable declarations. In any case: Reviewed-by: Thomas Zimmerma

Re: [PATCH v6 10/10] drm/qxl: allocate dumb buffers in ram

2021-02-04 Thread Thomas Zimmermann
go into system ram by default, and only move into device memory when they have to. Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_dumb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_dumb.c b/drivers

Re: [PATCH v6 06/10] drm/qxl: properly pin/unpin shadow

2021-02-04 Thread Thomas Zimmermann
Am 04.02.21 um 15:57 schrieb Gerd Hoffmann: Suggested-by: Thomas Zimmermann Signed-off-by: Gerd Hoffmann Thanks for this. Acked-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_display.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b

Re: [PATCH v6 05/10] drm/qxl: release shadow on shutdown

2021-02-04 Thread Thomas Zimmermann
Am 04.02.21 um 15:57 schrieb Gerd Hoffmann: In case we have a shadow surface on shutdown release it so it doesn't leak. Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_display.c | 4 1 file changed, 4 insertions(+) diff --git a/driver

Re: [PATCH v2 2/2] MIPS: relocatable: Use __kaslr_offset in show_kernel_relocation

2021-02-04 Thread Thomas Bogendoerfer
*)offset); > + pr_cont("Kernel relocated by 0x%pK\n", &__kaslr_offset); are you sure ? I would have expected (void *)__kaslr_offset here. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH] MIPS: of: Introduce helper function to get DTB

2021-02-04 Thread Thomas Bogendoerfer
On Wed, Jan 27, 2021 at 02:24:30PM +0100, Thomas Bogendoerfer wrote: > Selection of the DTB to be used was burried in more or less readable > code in head.S. Move this code into a inline helper function and > use it. > > Signed-off-by: Thomas Bogendoerfer > --- > ar

Re: [PATCH] MIPS: ralink: manage low reset lines

2021-02-04 Thread Thomas Bogendoerfer
the internal switch, and cleared the mcm reset line. In this > case the switch could be used from the OS. With this patch applied, the > switch works both in an initramfs, and when (cold) booting from flash. > > arch/mips/ralink/reset.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH v5 6/6] drm/qxl: simplify qxl_fence_wait

2021-02-03 Thread Thomas Zimmermann
Am 03.02.21 um 14:16 schrieb Gerd Hoffmann: Now that we have the new release_event wait queue we can just use that in qxl_fence_wait() and simplify the code alot. Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_release.c | 42

Re: [PATCH v5 5/6] drm/qxl: properly free qxl releases

2021-02-03 Thread Thomas Zimmermann
Am 03.02.21 um 14:16 schrieb Gerd Hoffmann: Reorganize qxl_device_fini() a bit. Add missing unpin() calls. Count releases. Add wait queue for releases. That way qxl_device_fini() can easily wait until everything is ready for proper shutdown. Signed-off-by: Gerd Hoffmann Acked-by: Thomas

Re: [PATCH v5 4/6] drm/qxl: handle shadow in primary destroy

2021-02-03 Thread Thomas Zimmermann
Am 03.02.21 um 14:16 schrieb Gerd Hoffmann: qxl_primary_atomic_disable must check whenever the framebuffer bo has a shadow surface and in case it has check the shadow primary status. I believe you :) Acked-by: Thomas Zimmermann Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl

Re: [PATCH v5 3/6] drm/qxl: release shadow on shutdown

2021-02-03 Thread Thomas Zimmermann
re and during the release in qxl_plane_prepare_fb()? Best regards Thomas qxl_destroy_monitors_object(qdev); } -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer

Re: [PATCH v5 2/6] drm/qxl: unpin release objects

2021-02-03 Thread Thomas Zimmermann
Am 03.02.21 um 14:16 schrieb Gerd Hoffmann: Balances the qxl_create_bo(..., pinned=true, ...); call in qxl_release_bo_alloc(). Signed-off-by: Gerd Hoffmann Acked-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_release.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH 1/3] MIPS: kernel: Support extracting off-line stack traces from user-space with perf

2021-02-03 Thread Thomas Bogendoerfer
On Wed, Feb 03, 2021 at 09:12:28PM +0800, Tiezhu Yang wrote: > On 2/3/21 6:40 PM, Thomas Bogendoerfer wrote: > > On Mon, Feb 01, 2021 at 08:56:06PM +0800, Tiezhu Yang wrote: > > > On 02/01/2021 06:43 PM, Thomas Bogendoerfer wrote: > > > > On Tue, Dec 29, 2020 at 08:55

Re: [PATCH] KVM: MIPS: remove unneeded semicolon

2021-02-03 Thread Thomas Bogendoerfer
insertion(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH V2] arch: mips: kernel: Fix two spelling in smp.c

2021-02-03 Thread Thomas Bogendoerfer
suggested to put better spelling casing,so inducted >Subject line adjusted accoring to the change > arch/mips/kernel/smp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but

Re: [PATCH] MIPS: malta-time: remove unneeded semicolon

2021-02-03 Thread Thomas Bogendoerfer
> 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

Re: [PATCH 1/3] MIPS: kernel: Support extracting off-line stack traces from user-space with perf

2021-02-03 Thread Thomas Bogendoerfer
On Mon, Feb 01, 2021 at 08:56:06PM +0800, Tiezhu Yang wrote: > On 02/01/2021 06:43 PM, Thomas Bogendoerfer wrote: > > On Tue, Dec 29, 2020 at 08:55:59PM +0800, Tiezhu Yang wrote: > > > +++ b/arch/mips/include/uapi/asm/perf_regs.h > > > @@ -0,0 +1,42 @@ > > >

Re: [PATCH] drm/nouveau: remove set but not used variable ‘pdev’ in nouveau_bios_init

2021-02-03 Thread Thomas Zimmermann
devices */ if (!dev_is_pci(dev->dev)) return 0; - pdev = to_pci_dev(dev->dev); if (!NVInitVBIOS(dev)) return -ENODEV; -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (

Re: fbcon: remove soft scrollback code (missing Doc. patch)

2021-02-03 Thread Thomas Zimmermann
case. We did have some complaints about performance of the emulation. So that might be worth looking into. Best regards Thomas Also I said "a pile more", most of the issues in fbcon/fbdev code apply for all drivers. Specifically the locking is somewhere between yolo and outright

[tip: timers/urgent] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-02 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the timers/urgent branch of tip: Commit-ID: ebb22a05943666155e6da04407cc6e913974c78c Gitweb: https://git.kernel.org/tip/ebb22a05943666155e6da04407cc6e913974c78c Author:Thomas Gleixner AuthorDate:Mon, 01 Feb 2021 20:24:17 +01:00

Re: [PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Thomas Gleixner
On Mon, Feb 01 2021 at 11:32, Linus Torvalds wrote: > On Mon, Feb 1, 2021 at 11:24 AM Thomas Gleixner wrote: >> >> While it cures the problem on the reporters machine it breaks machines >> with Intel chipsets which use bit 0-5 of the D register. So check only >> for

[PATCH V2] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Thomas Gleixner
: 211e5db19d15 ("rtc: mc146818: Detect and handle broken RTCs") Reported-by: Serge Belyshev Reported-by: Dirk Gouders Signed-off-by: Thomas Gleixner --- V2: Provide the actual delta patch. Should have stayed away from computers today --- drivers/rtc/rtc-cmos.c |4 ++-- drive

[PATCH] rtc: mc146818: Dont test for bit 0-5 in Register D

2021-02-01 Thread Thomas Gleixner
: 211e5db19d15 ("rtc: mc146818: Detect and handle broken RTCs") Reported-by: Serge Belyshev Reported-by: Dirk Gouders Signed-off-by: Thomas Gleixner --- drivers/rtc/rtc-cmos.c |8 drivers/rtc/rtc-mc146818-lib.c |7 +++ 2 files changed, 15 insertions(+) --- a/drive

Re: [PATCH] MIPS: relocatable: Provide kaslr_offset() to get the kernel offset

2021-02-01 Thread Thomas Bogendoerfer
On Wed, Jan 27, 2021 at 12:12:25PM +0800, Jinyang He wrote: > Use kimage_vaddr to indicate kernel start address. Provide kaslr_offset() > to get the kernel offset when KASLR is enabled. Error may occur before > update_kimage_vaddr(), so put it at the end of the offset branch. > > Fixes: a307a4ce9e

Re: [PATCH 1/3] MIPS: kernel: Support extracting off-line stack traces from user-space with perf

2021-02-01 Thread Thomas Bogendoerfer
> + */ haveing this hole here make all code more complicated. Does it hurt to have R26 and R27 in the list ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea.[ RFC1925, 2.3 ]

[GIT pull] core/urgent for v5.11-rc6

2021-01-31 Thread Thomas Gleixner
Linus, please pull the latest core/urgent branch from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core-urgent-2021-01-31 up to: 41c1a06d1d15: entry: Unbreak single step reporting behaviour A single fix for the single step reporting regression caused by getting the condition

[GIT pull] timers/urgent for v5.11-rc6

2021-01-31 Thread Thomas Gleixner
recent UIP handling changes the time readout of non-existent RTCs hangs forever as the read returns always 0xFF which means the UIP bit is set. Sanity check the RTC before registering by checking the RTC_VALID register for correctness. Thanks, tglx --> Thomas Gleixner

Re: [PATCH] selftests: breakpoints: Add "WINE" test for x86

2021-01-29 Thread Thomas Gleixner
On Fri, Jan 29 2021 at 10:08, Peter Zijlstra wrote: > On Fri, Jan 29, 2021 at 12:28:41AM +0100, Thomas Gleixner wrote: > >> Add a test case which covers this scenario. This is modeled after the >> WINE testcase, but changes the expect in step #2 to: >> >>- Ex

Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()

2021-01-29 Thread Thomas Petazzoni
On Fri, 29 Jan 2021 17:01:35 +0100 Gregory CLEMENT wrote: > Could you sent me the patch I don't have it in my emails boxes. https://lore.kernel.org/lkml/20201112032149.21906-1-chris.pack...@alliedtelesis.co.nz/raw Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel eng

[PATCH] selftests: breakpoints: Add "WINE" test for x86

2021-01-28 Thread Thomas Gleixner
the GDB expectations are met as well. Make it work for both 32 and 64 bit and fix the broken calculation of number of tests for 32 bit as well. Signed-off-by: Thomas Gleixner --- tools/testing/selftests/breakpoints/breakpoint_test.c | 115 -- 1 file changed, 107 insertions(+), 8

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2021-01-28 Thread Thomas Gleixner
imitations. > Nitesh, is there anything preventing this from being fixed > in userspace ? (as Thomas suggested previously). Everything with is not managed can be steered by user space. Thanks, tglx

Re: [PATCH v3 01/12] genirq: add IRQF_NO_AUTOEN for request_irq

2021-01-28 Thread Thomas Gleixner
Barry, On Fri, Jan 08 2021 at 11:39, Barry Song wrote: > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index ab8567f32501..2b28314e2572 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -1693,6 +1693,9 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, > struct i

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2021-01-28 Thread Thomas Gleixner
On Wed, Jan 27 2021 at 09:19, Marcelo Tosatti wrote: > On Wed, Jan 27, 2021 at 11:57:16AM +, Robin Murphy wrote: >> > + hk_flags = HK_FLAG_DOMAIN | HK_FLAG_MANAGED_IRQ; >> > + mask = housekeeping_cpumask(hk_flags); >> >> AFAICS, this generally resolves to something based on cpu_possible_mask

Re: [Patch v4 1/3] lib: Restrict cpumask_local_spread to houskeeping CPUs

2021-01-28 Thread Thomas Gleixner
On Wed, Jan 27 2021 at 10:09, Marcelo Tosatti wrote: > On Wed, Jan 27, 2021 at 12:36:30PM +, Robin Murphy wrote: >> > > >/** >> > > > * cpumask_next - get the next cpu in a cpumask >> > > > @@ -205,22 +206,27 @@ void __init >> > > > free_bootmem_cpumask_var(cpumask_var_t mask) >> > > >

Re: [PATCH] ptrace: restore the previous single step reporting behavior

2021-01-28 Thread Thomas Gleixner
On Wed, Jan 27 2021 at 20:55, Gabriel Krisman Bertazi wrote: > Yuxuan Shui writes: > > To gather the right attention, you should directly CC the correct > maintainers. You could have cc'ed them on your reply > Fixes: 64eb35f701f0 ("ptrace: Migrate TIF_SYSCALL_EMU to use SYSCALL_WORK > flag

Re: [tip:locking/core 10/10] sclp_early_core.c:undefined reference to `warn_bogus_irq_restore'

2021-01-28 Thread Thomas Gleixner
On Thu, Jan 28 2021 at 16:29, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking/core > head: 997acaf6b4b59c6a9c259740312a69ea549cc684 > commit: 997acaf6b4b59c6a9c259740312a69ea549cc684 [10/10] lockdep: report > broken irq restoration > conf

Re: linux-5.10.11 build failure

2021-01-28 Thread Thomas Backlund
gt; > > It's built from the 10-20210123 snapshot tarball. > > I can report this to the binutils folks, but might it be better if the > objtool maintainer looks at it first? The > binutils change might just have opened the gate to a bug in objtool. > >> thanks, >> >> greg k-h >> > AFAIK you need this in stable trees: From 1d489151e9f9d1647110277ff77282fe4d96d09b Mon Sep 17 00:00:00 2001 From: Josh Poimboeuf Date: Thu, 14 Jan 2021 16:14:01 -0600 Subject: [PATCH] objtool: Don't fail on missing symbol table -- Thomas

Re: [PATCH] genirq: Limit irq_calc_affinity_vectors to housekeeping CPUs

2021-01-27 Thread Thomas Gleixner
Liu, On Fri, Jan 22 2021 at 08:47, Liu Chao wrote: > Replace the cpumask used in irq_calc_affinity_vectors from all possible > CPUs to only housekeeping CPUs. > > When we have isolated CPUs used by real-time tasks, IRQs will be move to > housekeeping CPUs. No. > If there are too many IRQ vectors

<    3   4   5   6   7   8   9   10   11   12   >