> On 12 Sep 2019, at 10:34, Dan Carpenter wrote:
>
> You did it. Well done. :P
>
> Reviewed-by: Dan Carpenter
Thanks :D Had some issues with my git configuration
setting up a home workstation but now it is all fine
Use strscpy instead of strcpy in exfat_core.c, and add a check
for length that will return already known FFS_INVALIDPATH.
Suggested-by: Rasmus Villemoes
Signed-off-by: Sandro Volery
---
v5: Fixed some whitespaces
v4: Replaced strlen check
v3: Failed to replace check
v2: Forgot to replace strlen
> On 11 Sep 2019, at 21:06, Dan Carpenter wrote:
>
> On Wed, Sep 11, 2019 at 09:53:03PM +0200, Sandro Volery wrote:
>> diff --git a/drivers/staging/exfat/exfat_core.c
>> b/drivers/staging/exfat/exfat_core.c
>> index da8c58149c35..4336fee444ce 100644
>
Replacing strcpy with strscpy and moving the length check to the
same function.
Suggested-by: Rasmus Villemoes
Signed-off-by: Sandro Volery
---
Took a couple attempts to finaly get this right :P
v4: Replaced strlen check
v3: Failed to replace check
v2: Forgot to replace strlen check
v1
Use strscpy instead of strcpy in exfat_core.c, and add a check
for length that will return already known FFS_INVALIDPATH.
Suggested-by: Rasmus Villemoes
Signed-off-by: Sandro Volery
---
v3: Fixed replacing mistake
v2: Introduced length check
v1: Original patch
drivers/staging/exfat
> On 11 Sep 2019, at 12:06, Dan Carpenter wrote:
>
> On Wed, Sep 11, 2019 at 11:42:19AM +0200, Sandro Volery wrote:
>> Use strscpy instead of strcpy in exfat_core.c, and add a check
>> for length that will return already known FFS_INVALIDPATH.
>>
>> Suggeste
Use strscpy instead of strcpy in exfat_core.c, and add a check
for length that will return already known FFS_INVALIDPATH.
Suggested-by: Rasmus Villemoes
Signed-off-by: Sandro Volery
---
v2: Implement length check and return in one
v1: Original Patch
drivers/staging/exfat/exfat_core.c | 3
On 11 Sep 2019, at 11:17, Dan Carpenter wrote:
>
> On Wed, Sep 11, 2019 at 11:04:38AM +0200, Sandro Volery wrote:
>>
>>
>>>> On 11 Sep 2019, at 10:52, Dan Carpenter wrote:
>>>
>>> On Wed, Sep 11, 2019 at 08:23:59AM +0200, Sandro Volery wrot
> On 11 Sep 2019, at 10:52, Dan Carpenter wrote:
>
> On Wed, Sep 11, 2019 at 08:23:59AM +0200, Sandro Volery wrote:
>> strcpy was used multiple times in strcpy to write into dev->name.
>> I replaced them with strscpy.
>>
>> Signed-off-by: Sandro Vole
strcpy was used multiple times in strcpy to write into dev->name.
I replaced them with strscpy.
Signed-off-by: Sandro Volery
---
drivers/staging/octeon/ethernet.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c
b/driv
Replaced strcpy with strscpy in exfat_core.c.
Signed-off-by: Sandro Volery
---
drivers/staging/exfat/exfat_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/exfat/exfat_core.c
b/drivers/staging/exfat/exfat_core.c
index da8c58149c35..c71b145e8a24 100644
Using temporaries for gasket_page_table entries to remove scnprintf()
statements and reduce line length, as suggested by Joe Perches. Thanks!
Signed-off-by: Sandro Volery
---
v3: Fixed faulty copy/paste of function
v2: Attempt to fix
v1: Original patch
drivers/staging/gasket/apex_driver.c
Wow... I checked, compiled and still sent the wrong thing again. I'm gonna have
to give this up soon if i can't get it right.
Sandro V
> On 10 Sep 2019, at 07:06, Sandro Volery wrote:
>
> Using temporaries for gasket_page_table entries to remove scnprintf()
> statements and
Using temporaries for gasket_page_table entries to remove scnprintf()
statements and reduce line length, as suggested by Joe Perches. Thanks!
Signed-off-by: Sandro Volery
---
drivers/staging/gasket/apex_driver.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff
> On 10 Sep 2019, at 00:30, Joe Perches wrote:
>
> On Mon, 2019-09-09 at 22:28 +0200, Sandro Volery wrote:
>> Using temporaries for gasket_page_table entries to remove scnprintf()
>> statements and reduce line length, as suggested by Joe Perches. Thanks!
>
>
Using temporaries for gasket_page_table entries to remove scnprintf()
statements and reduce line length, as suggested by Joe Perches. Thanks!
Signed-off-by: Sandro Volery
---
drivers/staging/gasket/apex_driver.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff
> On 9 Sep 2019, at 18:15, Joe Perches wrote:
>
> On Sat, 2019-09-07 at 18:12 +0200, Sandro Volery wrote:
>> Alright, I'll do that when I get home tonight!
>
> I'm going to assume this is not an actual problem.
>
Oh yeah I'm sorry, I was all busy reading document
> strongly encouraged to restrict their checkpatch cleanups to the
> staging tree, since when such cleanup patches are considered welcome
> very much depends on the kernel subsystem and the maintainers
> involved.)
Should I still send the ones I tried to submit in this thread again
as separate
> On 8 Sep 2019, at 22:59, Theodore Y. Ts'o wrote:
>
Hi Ted,
Thank you, for elaborating all this to me! I will try to limit my patches to
the staging tree, until I feel confident enough to tackle a real coding issue
in the kernel.
Thanks,
Sandro V
Fixed open parenthesis at the end of the line on line 327.
Signed-off-by: Sandro Volery
---
drivers/staging/wlan-ng/cfg80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
b/drivers/staging/wlan-ng/cfg80211.c
index eee1998c4b18
Sandro V
>> On 7 Sep 2019, at 22:04, Joe Perches wrote:
>>
>> On Sat, 2019-09-07 at 11:09 +0200, volery wrote:
>> There were a lot of styling problems using space then tab or spaces
>> instead of tabs in that file. Especially the entire function at line
>>
> On 7 Sep 2019, at 21:27, Joe Perches wrote:
>
> On Sat, 2019-09-07 at 18:42 +0100, Greg KH wrote:
>>> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
>>>
>>>>>> On 7 Sep 2019, at 19:29, Greg KH wrote:
>>>>> O
Sandro V
> On 7 Sep 2019, at 20:03, Greg KH wrote:
>
> On Sat, Sep 07, 2019 at 07:49:43PM +0200, Sandro Volery wrote:
>>
>>
>>
>>
>>>> On 7 Sep 2019, at 19:42, Greg KH wrote:
>>>
>>> On Sat, Sep 07, 2019 at 07:35:42PM
> On 7 Sep 2019, at 19:42, Greg KH wrote:
>
> On Sat, Sep 07, 2019 at 07:35:42PM +0200, Sandro Volery wrote:
>>
>>
>>>>>> On 7 Sep 2019, at 19:29, Greg KH wrote:
>>>>> On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wr
>>> On 7 Sep 2019, at 19:29, Greg KH wrote:
>> On Sat, Sep 07, 2019 at 07:23:59PM +0200, Sandro Volery wrote:
>> Dear Greg,
>> I am pretty sure the issue was, that I did too many things at once. However,
>> all the things I did are related to spac
Alright, I'll do that when I get home tonight!
Thanks,
Sandro V
> On 7 Sep 2019, at 18:08, Joe Perches wrote:
>
> On Sat, 2019-09-07 at 17:56 +0200, Sandro Volery wrote:
>>>> On 7 Sep 2019, at 17:44, Joe Perches wrote:
>>>
>>> On Sat, 2019-09
> On 7 Sep 2019, at 17:44, Joe Perches wrote:
>
> On Sat, 2019-09-07 at 17:34 +0200, Sandro Volery wrote:
>> On patchwork I entered 'volery' as my username because I didn't know better,
>> and now checkpatch always complains when I add 'signed-off-by' with my
>>
> On 7 Sep 2019, at 16:52, Dan Carpenter wrote:
>
Alright, thanks!
Some stupid other question:
On patchwork I entered 'volery' as my username because I didn't know better,
and now checkpatch always complains when I add 'signed-off-by' with my actual
full name.
How can I
y "Fix" is considered better style than "Fixed". We aren't
> going to care about that in staging, but the patch prefix is mandatory
> so you will need to redo it anyway and might as well fix that as well.
>
>> On Fri, Sep 06, 2019 at 08:38:01PM +0200, volery wrote:
&
There were a lot of styling problems using space then tab or spaces
instead of tabs in that file. Especially the entire function at line
2677.
Also added a space before the : on line 2221.
Signed-off-by: Sandro Volery
---
drivers/tty/tty_io.c | 60 ++--
1
There were some parentheses at the end of lines, which I took care of.
This is my first patch.
Signed-off-by: Sandro Volery
---
drivers/staging/gasket/apex_driver.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gasket/apex_driver.c
b/drivers
31 matches
Mail list logo
