watchdog_next_keepalive(struct watchdog_device *wdd)
> @@ -107,7 +111,7 @@ static long watchdog_next_keepalive(struct
> watchdog_device *wdd)
> unsigned int hw_heartbeat_ms;
>
> virt_timeout = wd_data->last_keepalive + msecs_to_jiffies(timeout_ms);
> - hw_heartbeat_ms = min(timeout_ms, wdd->max_hw_heartbeat_ms);
> + hw_heartbeat_ms = min_not_zero(timeout_ms, wdd->max_hw_heartbeat_ms);
> keepalive_interval = msecs_to_jiffies(hw_heartbeat_ms / 2);
>
> if (!watchdog_active(wdd))
> --
> 2.5.0
>
Kind regards,
Wim.
h
> +++ b/include/linux/watchdog.h
> @@ -180,4 +180,7 @@ extern int watchdog_init_timeout(struct watchdog_device
> *wdd,
> extern int watchdog_register_device(struct watchdog_device *);
> extern void watchdog_unregister_device(struct watchdog_device *);
>
> +/* devres register variant */
> +int devm_watchdog_register_device(struct device *dev, struct watchdog_device
> *);
> +
> #endif /* ifndef _LINUX_WATCHDOG_H */
> --
> 2.7.0
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
h
> @@ -180,4 +180,7 @@ extern int watchdog_init_timeout(struct watchdog_device
> *wdd,
> extern int watchdog_register_device(struct watchdog_device *);
> extern void watchdog_unregister_device(struct watchdog_device *);
>
> +/* devres register variant */
> +int devm_watchdog_register_device(struct device *dev, struct watchdog_device
> *);
> +
> #endif /* ifndef _LINUX_WATCHDOG_H */
> --
> 2.7.0
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
t is quite similar to the one from kernel-4.6 .
Tested-by: Wim Osterholt. <w...@djo.tudelft.nl>
t is quite similar to the one from kernel-4.6 .
Tested-by: Wim Osterholt.
t; you something to test before posting the official version.
The 510m just finished compiling and now it works fine too.
Thanks.
Regards, Wim.
- w...@djo.tudelft.nl -
t; you something to test before posting the official version.
The 510m just finished compiling and now it works fine too.
Thanks.
Regards, Wim.
- w...@djo.tudelft.nl -
On Sat, Jun 25, 2016 at 04:51:03AM -0400, ok...@codeaurora.org wrote:
> On 2016-06-24 21:39, Wim Osterholt wrote:
>
> Please apply the patches on top of clean 4.7-rc4 tree and apply them in
> order with
>
> git am 0001...
> git am 0002...
It doesn't work that way.
Beginn
On Sat, Jun 25, 2016 at 04:51:03AM -0400, ok...@codeaurora.org wrote:
> On 2016-06-24 21:39, Wim Osterholt wrote:
>
> Please apply the patches on top of clean 4.7-rc4 tree and apply them in
> order with
>
> git am 0001...
> git am 0002...
It doesn't work that way.
Beginn
ISA_IRQS)
> - penalty += acpi_isa_irq_penalty[irq];
> + return acpi_isa_irq_penalty[irq];
>
> /*
> * Penalize IRQ used by ACPI SCI. If ACPI SCI pin attributes conflict
Regards, Wim.
- w...@djo.tudelft.nl -
ISA_IRQS)
> - penalty += acpi_isa_irq_penalty[irq];
> + return acpi_isa_irq_penalty[irq];
>
> /*
> * Penalize IRQ used by ACPI SCI. If ACPI SCI pin attributes conflict
Regards, Wim.
- w...@djo.tudelft.nl -
p, Dell Inspiron 4100.
The same problem arises at a Dell Inspiron 510m.
I've not seen it on a workstation Dell XW4300.
Groeten, Wim.
- w...@djo.tudelft.nl -
p, Dell Inspiron 4100.
The same problem arises at a Dell Inspiron 510m.
I've not seen it on a workstation Dell XW4300.
Groeten, Wim.
- w...@djo.tudelft.nl -
On Wed, Jun 22, 2016 at 11:54:39PM -0400, ok...@codeaurora.org wrote:
> On 2016-06-21 18:13, Wim Osterholt wrote:
> >>
> >>pr_info("%s:%d irq = %d penalty = %d\n", __func__, __LINE__, irq,
> >>penalty);
> >>
> >
> >
On Wed, Jun 22, 2016 at 11:54:39PM -0400, ok...@codeaurora.org wrote:
> On 2016-06-21 18:13, Wim Osterholt wrote:
> >>
> >>pr_info("%s:%d irq = %d penalty = %d\n", __func__, __LINE__, irq,
> >>penalty);
> >>
> >
> >
unction and then send
> the output?
>
> pr_info("%s:%d irq = %d penalty = %d\n", __func__, __LINE__, irq,
> penalty);
>
This produced some 60 lines extra. Too much to include here.
The entire dmesg file is here:
http://webserver.djo.tudelft.nl/d
unction and then send
> the output?
>
> pr_info("%s:%d irq = %d penalty = %d\n", __func__, __LINE__, irq,
> penalty);
>
This produced some 60 lines extra. Too much to include here.
The entire dmesg file is here:
http://webserver.djo.tudelft.nl/d
> PIRQ_PENALTY_PCI_USING;
> +
>
>
>
> > Bjorn
I tried this on kernel 4.7.0-rc4, but that didn't help. It still tried to
grab irq7.
Regards, Wim.
- w...@djo.tudelft.nl -
> PIRQ_PENALTY_PCI_USING;
> +
>
>
>
> > Bjorn
I tried this on kernel 4.7.0-rc4, but that didn't help. It still tried to
grab irq7.
Regards, Wim.
- w...@djo.tudelft.nl -
+ACPI
http://webserver.djo.tudelft.nl/dmesg473+ACPI
http://webserver.djo.tudelft.nl/dmesg473noACPI
(with excuses for the silly hostname which is out of our control)
Regards, Wim.
- w...@djo.tudelft.nl -
+ACPI
http://webserver.djo.tudelft.nl/dmesg473+ACPI
http://webserver.djo.tudelft.nl/dmesg473noACPI
(with excuses for the silly hostname which is out of our control)
Regards, Wim.
- w...@djo.tudelft.nl -
On my first message I stated:
It looks to me that the code in floppy.c is quite old; no changes here.
So the bug is elsewhere in the kernel.
That was because the changelog at the beginning of floppy.c ended in 2003.
Wouln't it be wise to keep these items updated?
Groeten, Wim.
- w
On my first message I stated:
It looks to me that the code in floppy.c is quite old; no changes here.
So the bug is elsewhere in the kernel.
That was because the changelog at the beginning of floppy.c ended in 2003.
Wouln't it be wise to keep these items updated?
Groeten, Wim.
- w
On Wed, Jun 15, 2016 at 04:13:53PM +0200, Jiri Kosina wrote:
>
> Wim, could you please test whether the patch below, applied on top of
> vanilla kernel (i.e. drop the revert), everything you are using still
> works as expected?
>
Applied on kernel-4.7-rc3 it looks like it's w
On Wed, Jun 15, 2016 at 04:13:53PM +0200, Jiri Kosina wrote:
>
> Wim, could you please test whether the patch below, applied on top of
> vanilla kernel (i.e. drop the revert), everything you are using still
> works as expected?
>
Applied on kernel-4.7-rc3 it looks like it's w
r some such.
Problem is that fdutils is probably unmaintained for ten years or so.
Regards, Wim.
- w...@djo.tudelft.nl -
r some such.
Problem is that fdutils is probably unmaintained for ten years or so.
Regards, Wim.
- w...@djo.tudelft.nl -
rst 'wrong' kernel would be best)
git revert 09954bad448(that did something, which I assume te be good)
copied the .config file from 4.5 I had lying around and ran make.
Surprising or not, the thusly compiled kernel ran fine and I could handle
floppies like before!
(open(/dev/fd0,O_ACCMODE) succeeds.)
Regards, Wim.
- w...@djo.tudelft.nl -
rst 'wrong' kernel would be best)
git revert 09954bad448(that did something, which I assume te be good)
copied the .config file from 4.5 I had lying around and ran make.
Surprising or not, the thusly compiled kernel ran fine and I could handle
floppies like before!
(open(/dev/fd0,O_ACCMODE) succeeds.)
Regards, Wim.
- w...@djo.tudelft.nl -
gt;
> int main(int argc, char *argv[])
> {
> if (open("foo", 3) == -1)
> perror("foo");
> return 0;
> }
No errors get printed for kernel 4.4 to 4.7 .
Regards, Wim.
- w...@djo.tudelft.nl -
gt;
> int main(int argc, char *argv[])
> {
> if (open("foo", 3) == -1)
> perror("foo");
> return 0;
> }
No errors get printed for kernel 4.4 to 4.7 .
Regards, Wim.
- w...@djo.tudelft.nl -
ere in the kernel.
Could someone please explain and repair the magic that is happening here?
Thanks in advance, Wim Osterholt.
- w...@djo.tudelft.nl -
ere in the kernel.
Could someone please explain and repair the magic that is happening here?
Thanks in advance, Wim Osterholt.
- w...@djo.tudelft.nl -
tation may forget to CC
the subsystem maintainer if this is missing.
Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
Signed-off-by: Guenter Roeck <li...@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <w...@iguana.be>
Cc: linux-watch...
the subsystem maintainer if this is missing.
Signed-off-by: Geert Uytterhoeven
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
Cc: linux-watch...@vger.kernel.org
commit ae67643edc6edcab41d8d5d35cb796416b253a01
Author: William Breathitt Gray
Date: Wed May 11 08
Hi Geert,
> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
>
> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
> Cc: Wim Van Sebroeck <w...@iguana.be>
> Cc: Guenter Roeck <li..
Hi Geert,
> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
>
> Signed-off-by: Geert Uytterhoeven
> Cc: Wim Van Sebroeck
> Cc: Guenter Roeck
> Cc: linux-watch...@vger.kernel.org
> ---
> Please apply
t; timeout: Watchdog timeout in seconds. (1<=timeout<=3600, default=TBD)
> --
> 2.7.3
>
This patch was added to linux-watchdog-next.
Kind Regards,
Wim.
. (1<=timeout<=3600, default=TBD)
> --
> 2.7.3
>
This patch was added to linux-watchdog-next.
Kind Regards,
Wim.
setup_timer(>timer, sh_wdt_ping, (unsigned long)wdt);
> wdt->timer.expires = next_ping_period(clock_division_ratio);
>
> dev_info(>dev, "initialized.\n");
> --
> 1.9.1
>
This patch was added to linux-watchdog-next.
Kind Regards,
Wim.
_timer(>timer, sh_wdt_ping, (unsigned long)wdt);
> wdt->timer.expires = next_ping_period(clock_division_ratio);
>
> dev_info(>dev, "initialized.\n");
> --
> 1.9.1
>
This patch was added to linux-watchdog-next.
Kind Regards,
Wim.
;
> + setup_timer(_timer, cpwd_brokentimer, (unsigned long)p);
> cpwd_timer.expires = WD_BTIMEOUT;
>
> pr_info("PLD defect workaround enabled for model %s\n",
> --
> 1.9.1
>
This patch was added to linux-watchdog-next.
Kind Regards,
Wim.
+ setup_timer(_timer, cpwd_brokentimer, (unsigned long)p);
> cpwd_timer.expires = WD_BTIMEOUT;
>
> pr_info("PLD defect workaround enabled for model %s\n",
> --
> 1.9.1
>
This patch was added to linux-watchdog-next.
Kind Regards,
Wim.
alloacate watchdog device\n");
> + if (!drvdata)
> return -ENOMEM;
> - }
>
> if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT)
> heartbeat = DEFAULT_HEARTBEAT;
> --
> 2.7.4
>
This patch was added to linux-watchdog-next.
Kind Regards,
Wim.
turn -ENOMEM;
> - }
>
> if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT)
> heartbeat = DEFAULT_HEARTBEAT;
> --
> 2.7.4
>
This patch was added to linux-watchdog-next.
Kind Regards,
Wim.
Hi Guenter,
> On 05/14/2016 10:07 AM, Guenter Roeck wrote:
> >Hi Wim,
> >
> >On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote:
> >>Hi Guenter,
> >>
> >>>lockdep reports the following circular locking dependency.
> >>>
> >
>
Hi Guenter,
> On 05/14/2016 10:07 AM, Guenter Roeck wrote:
> >Hi Wim,
> >
> >On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote:
> >>Hi Guenter,
> >>
> >>>lockdep reports the following circular locking dependency.
> >>>
> >
>
/qcom-wdt.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
This patch has been added into linux-watchdog-next.
Kind regards,
Wim.
e it whenever the CPU goes
> back online. As a result, the suspended state is no longer a special
> case that leaves the watchdog active.
>
> Cc: Wim Van Sebroeck <w...@iguana.be>
> Cc: Guenter Roeck <li...@roeck-us.net>
> Cc: linux-watch...@vger.kernel.org
> Signed
nsertions(+), 1 deletion(-)
This patch has been added into linux-watchdog-next.
Kind regards,
Wim.
e it whenever the CPU goes
> back online. As a result, the suspended state is no longer a special
> case that leaves the watchdog active.
>
> Cc: Wim Van Sebroeck
> Cc: Guenter Roeck
> Cc: linux-watch...@vger.kernel.org
> Signed-off-by: Richard Cochran
> ---
> dr
++-
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
10 insertions(+), 5 deletions(-)
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
1d7aba9ceb7 ("watchdog: imx2: Convert to use infrastructure triggered
> keepalives")
> Signed-off-by: Guenter Roeck <li...@roeck-us.net>
> ---
> drivers/watchdog/watchdog_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
> index e2c5abbb45ff..3595cffa24ea 100644
> --- a/drivers/watchdog/watchdog_dev.c
> +++ b/drivers/watchdog/watchdog_dev.c
> @@ -736,7 +736,6 @@ static int watchdog_release(struct inode *inode, struct
> file *file)
> watchdog_ping(wdd);
> }
>
> - cancel_delayed_work_sync(_data->work);
> watchdog_update_worker(wdd);
>
> /* make sure that /dev/watchdog can be re-opened */
> --
> 2.5.0
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
rastructure triggered
> keepalives")
> Signed-off-by: Guenter Roeck
> ---
> drivers/watchdog/watchdog_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
> index e2c5abbb45ff..3595cffa24ea 100644
> --- a/drivers/watchdog/watchdog_dev.c
> +++ b/drivers/watchdog/watchdog_dev.c
> @@ -736,7 +736,6 @@ static int watchdog_release(struct inode *inode, struct
> file *file)
> watchdog_ping(wdd);
> }
>
> - cancel_delayed_work_sync(_data->work);
> watchdog_update_worker(wdd);
>
> /* make sure that /dev/watchdog can be re-opened */
> --
> 2.5.0
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
mutex protection to avoid use-after-free problems.
Fixes: e6c71e84e4c0 ("watchdog: Introduce WDOG_HW_RUNNING flag")
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
Signed-off-by: Guenter Roeck <li...@roeck-us.net>
Signed-off-by: Wim Van Sebro
use-after-free problems.
Fixes: e6c71e84e4c0 ("watchdog: Introduce WDOG_HW_RUNNING flag")
Reported-by: Dan Carpenter
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
commit 11d7aba9ceb726d86aaaca3eb5f7d79de38989c5
Author: Guenter Roeck
Date: Sun Fe
tree once you picked it up.
Kind regards,
Wim.
tree once you picked it up.
Kind regards,
Wim.
Hi Guenter,
> Hi Wim,
>
> On Sun, Mar 06, 2016 at 11:49:56AM +0100, Wim Van Sebroeck wrote:
> > Hi Guenter,
> >
> > > The watchdog infrastructure is currently purely passive, meaning
> > > it only passes information from user space to drivers and vice ver
Hi Guenter,
> Hi Wim,
>
> On Sun, Mar 06, 2016 at 11:49:56AM +0100, Wim Van Sebroeck wrote:
> > Hi Guenter,
> >
> > > The watchdog infrastructure is currently purely passive, meaning
> > > it only passes information from user space to drivers and vice ver
arameter in
> Documentation/watchdog/watchdog-parameters.txt, so one could argue
> that using module_param_named() would be a bug fix and not an ABI change.
>
> Not really sure what the best approach is here. Wim, any comments ?
> Provide module_param_named() in _addition_ to t
the case. Wonder if anyone ever noticed.
> The correct fix would be to use something like
> module_param_named(timeout, pnx833x_wdt_timeout, int, 0);
> but of course that would change the ABI. On the other side,
> 'timeout' is the documented module parameter in
> Documen
at it will now stop early, while there
> may still be a substantial amount of time for keepalives from user space
> to arrive. If such keepalives arrive late (for example if user space
> is configured to send keepalives just a few seconds before the watchdog
> times out), the message would just be noise and not provide any value.
Patches 1 till 7 of this series has been added to linux-watchdog-next.
Kind regards,
Wim.
at it will now stop early, while there
> may still be a substantial amount of time for keepalives from user space
> to arrive. If such keepalives arrive late (for example if user space
> is configured to send keepalives just a few seconds before the watchdog
> times out), the message would just be noise and not provide any value.
Patches 1 till 7 of this series has been added to linux-watchdog-next.
Kind regards,
Wim.
uct platform_device *pdev)
> dev_info(>dev, "SMP86xx/SMP87xx watchdog registered\n");
>
> return 0;
> +
> + err:
> + clk_disable_unprepare(dev->clk);
> + return err;
> }
>
> static int tangox_wdt_remove(struct platform_device *pdev)
> --
> 2.7.0
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
6xx/SMP87xx watchdog registered\n");
>
> return 0;
> +
> + err:
> + clk_disable_unprepare(dev->clk);
> + return err;
> }
>
> static int tangox_wdt_remove(struct platform_device *pdev)
> --
> 2.7.0
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
ret = -EINVAL;
> + goto err1;
> + }
> +
> wdt->clk = clk;
> atlas7_wdd.min_timeout = 1;
> atlas7_wdd.max_timeout = UINT_MAX / wdt->tick_rate;
> --
> 2.7.0
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
; wdt->clk = clk;
> atlas7_wdd.min_timeout = 1;
> atlas7_wdd.max_timeout = UINT_MAX / wdt->tick_rate;
> --
> 2.7.0
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
ransition);
> @@ -567,6 +580,9 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
> return ret;
> }
>
> + wdt->wdt_device.min_timeout = 1;
> + wdt->wdt_device.max_timeout = s3c2410wdt_max_timeout(wdt->clock);
> +
> ret = s3c2410wdt_cpufreq_register(wdt);
> if (ret < 0) {
> dev_err(dev, "failed to register cpufreq\n");
> --
> 2.5.0
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
tatic int s3c2410wdt_probe(struct platform_device *pdev)
> return ret;
> }
>
> + wdt->wdt_device.min_timeout = 1;
> + wdt->wdt_device.max_timeout = s3c2410wdt_max_timeout(wdt->clock);
> +
> ret = s3c2410wdt_cpufreq_register(wdt);
> if (ret < 0) {
> dev_err(dev, "failed to register cpufreq\n");
> --
> 2.5.0
>
This patch has been added to linux-watchdog-next.
Kind regards,
Wim.
device node in amd-seattle-soc.dtsi
> Watchdog: introduce ARM SBSA watchdog driver
>
> .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 31 ++
> Documentation/watchdog/watchdog-parameters.txt | 7 +
> arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 8 +
> arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +
> drivers/watchdog/Kconfig | 20 +
> drivers/watchdog/Makefile | 1 +
> drivers/watchdog/sbsa_gwdt.c | 408
> +
> 7 files changed, 482 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt
> create mode 100644 drivers/watchdog/sbsa_gwdt.c
>
> --
> 2.5.0
>
Patchset added to linux-watchdog-next.
Kind regards,
Wim.
-seattle-soc.dtsi
> Watchdog: introduce ARM SBSA watchdog driver
>
> .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 31 ++
> Documentation/watchdog/watchdog-parameters.txt | 7 +
> arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 8 +
> arch/arm64/boot/dts/arm/foundation-v8.dts | 7 +
> drivers/watchdog/Kconfig | 20 +
> drivers/watchdog/Makefile | 1 +
> drivers/watchdog/sbsa_gwdt.c | 408
> +
> 7 files changed, 482 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt
> create mode 100644 drivers/watchdog/sbsa_gwdt.c
>
> --
> 2.5.0
>
Patchset added to linux-watchdog-next.
Kind regards,
Wim.
if (err)
> + goto err_platform_device;
> +
> + err = platform_driver_probe(_c384_wdt_driver, ebc_c384_wdt_probe);
> + if (err)
> + goto err_platform_driver;
> +
> + return 0;
> +
> +err_platform_driver:
> + platform_device_del(ebc_c384_wdt_device);
> +err_platform_device:
> + platform_device_put(ebc_c384_wdt_device);
> + return err;
> +}
> +
> +static void __exit ebc_c384_wdt_exit(void)
> +{
> + platform_device_unregister(ebc_c384_wdt_device);
> + platform_driver_unregister(_c384_wdt_driver);
> +}
> +
> +module_init(ebc_c384_wdt_init);
> +module_exit(ebc_c384_wdt_exit);
> +
> +MODULE_AUTHOR("William Breathitt Gray <vilhelm.g...@gmail.com>");
> +MODULE_DESCRIPTION("WinSystems EBC-C384 watchdog timer driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:" MODULE_NAME);
> --
> 2.4.10
>
Patch added to linux-watchdog-next.
Kind regards,
Wim.
ce_alloc(MODULE_NAME, -1);
> + if (!ebc_c384_wdt_device)
> + return -ENOMEM;
> +
> + err = platform_device_add(ebc_c384_wdt_device);
> + if (err)
> + goto err_platform_device;
> +
> + err = platform_driver_probe(_c384_wdt_driver, ebc_c384_wdt_probe);
> + if (err)
> + goto err_platform_driver;
> +
> + return 0;
> +
> +err_platform_driver:
> + platform_device_del(ebc_c384_wdt_device);
> +err_platform_device:
> + platform_device_put(ebc_c384_wdt_device);
> + return err;
> +}
> +
> +static void __exit ebc_c384_wdt_exit(void)
> +{
> + platform_device_unregister(ebc_c384_wdt_device);
> + platform_driver_unregister(_c384_wdt_driver);
> +}
> +
> +module_init(ebc_c384_wdt_init);
> +module_exit(ebc_c384_wdt_exit);
> +
> +MODULE_AUTHOR("William Breathitt Gray ");
> +MODULE_DESCRIPTION("WinSystems EBC-C384 watchdog timer driver");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:" MODULE_NAME);
> --
> 2.4.10
>
Patch added to linux-watchdog-next.
Kind regards,
Wim.
int ret;
>
> - ret = wdd->ops->restart(wdd);
> + ret = wdd->ops->restart(wdd, action, data);
> if (ret)
> return NOTIFY_BAD;
>
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index 537e84e2592a..f1fccc7aea68 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -47,7 +47,7 @@ struct watchdog_ops {
> unsigned int (*status)(struct watchdog_device *);
> int (*set_timeout)(struct watchdog_device *, unsigned int);
> unsigned int (*get_timeleft)(struct watchdog_device *);
> - int (*restart)(struct watchdog_device *);
> + int (*restart)(struct watchdog_device *, unsigned long, void *);
> long (*ioctl)(struct watchdog_device *, unsigned int, unsigned long);
> };
>
> --
> 2.5.0
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
start(wdd);
> + ret = wdd->ops->restart(wdd, action, data);
> if (ret)
> return NOTIFY_BAD;
>
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index 537e84e2592a..f1fccc7aea68 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -47,7 +47,7 @@ struct watchdog_ops {
> unsigned int (*status)(struct watchdog_device *);
> int (*set_timeout)(struct watchdog_device *, unsigned int);
> unsigned int (*get_timeleft)(struct watchdog_device *);
> - int (*restart)(struct watchdog_device *);
> + int (*restart)(struct watchdog_device *, unsigned long, void *);
> long (*ioctl)(struct watchdog_device *, unsigned int, unsigned long);
> };
>
> --
> 2.5.0
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
"host request", NULL, "illegal configuration",
> "illegal instruction", "illegal trap",
> "unknown"};
> --
> 2.1.4
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
quot;illegal configuration",
> "illegal instruction", "illegal trap",
> "unknown"};
> --
> 2.1.4
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
/* Fall through */
> case WDIOC_GETTIMEOUT:
> - return copy_to_user(argp, , sizeof(int));
> + return copy_to_user(argp, , sizeof(int)) ? -EFAULT : 0;
> default:
> return -ENOTTY;
> }
> --
> MST
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
ugh */
> case WDIOC_GETTIMEOUT:
> - return copy_to_user(argp, , sizeof(int));
> + return copy_to_user(argp, , sizeof(int)) ? -EFAULT : 0;
> default:
> return -ENOTTY;
> }
> --
> MST
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
epends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU
> + depends on ARM
> select WATCHDOG_CORE
> help
> Say Y here if to include support for the watchdog timer
> --
> 2.7.1
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
CH_MVEBU
> + depends on ARM
> select WATCHDOG_CORE
> help
> Say Y here if to include support for the watchdog timer
> --
> 2.7.1
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
et = nct6102;
> + cr_wdt_timeout = NCT6102D_WDT_TIMEOUT;
> + cr_wdt_control = NCT6102D_WDT_CONTROL;
> + cr_wdt_csr = NCT6102D_WDT_CSR;
> + break;
> case 0xff:
> ret = -ENODEV;
> break;
> @@ -422,6 +437,7 @@ static int __init wdt_init(void)
> "NCT6779",
> "NCT6791",
> "NCT6792",
> + "NCT6102",
> };
>
> wdt_io = 0x2e;
> --
> 2.6.2
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
cr_wdt_timeout = NCT6102D_WDT_TIMEOUT;
> + cr_wdt_control = NCT6102D_WDT_CONTROL;
> + cr_wdt_csr = NCT6102D_WDT_CSR;
> + break;
> case 0xff:
> ret = -ENODEV;
> break;
> @@ -422,6 +437,7 @@ static int __init wdt_init(void)
> "NCT6779",
> "NCT6791",
> "NCT6792",
> + "NCT6102",
> };
>
> wdt_io = 0x2e;
> --
> 2.6.2
>
Patch has been added to linux-watchdog-next.
Kind regards,
Wim.
x.com>
> Cc: Rob Herring <r...@kernel.org>
> Cc: Guenter Roeck <li...@roeck-us.net>
> Cc: Wim Van Sebroeck <w...@iguana.be>
> ---
> drivers/watchdog/Kconfig |1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-4.5-rc3.orig/drivers/watchdog/Kconfig
Hi Jean,
> The Technologic Systems TS-4800 is an i.MX515 board, so its drivers
> are useless unless building a SOC_IMX51 kernel, except for build
> testing purposes.
>
> Signed-off-by: Jean Delvare
> Cc: Damien Riegel
> Cc: Rob Herring
> Cc: Guenter Roeck
Hi Guenter,
> On 02/28/2016 06:07 AM, Wim Van Sebroeck wrote:
> >>>+static int ebc_c384_wdt_set_timeout(struct watchdog_device *wdev,
> >>>unsigned t)
> >>>+{
> >>>+ /* resolution is in minutes for timeouts greater than 255 seconds */
> &
Hi Guenter,
> On 02/28/2016 06:07 AM, Wim Van Sebroeck wrote:
> >>>+static int ebc_c384_wdt_set_timeout(struct watchdog_device *wdev,
> >>>unsigned t)
> >>>+{
> >>>+ /* resolution is in minutes for timeouts greater than 255 seconds */
> &
es 300
t = 300 -> gives 300
t = 301 -> gives 360
t = 15299 -> gives 15300
t = 15300 -> gives 15300
t = 15301 -> gives 15360
So I am also for going late.
Kind regards,
Wim.
es 300
t = 300 -> gives 300
t = 301 -> gives 360
t = 15299 -> gives 15300
t = 15300 -> gives 15300
t = 15301 -> gives 15360
So I am also for going late.
Kind regards,
Wim.
the series.
This patch can be used even without the other patches.
I also like the WDOG_HW_RUNNING flag. But I would split the patch that adds
this into 2 patches:
* a patch that adds the WDOG_HW_RUNNING flag
* and a patch that makes the stop function optional.
Thanks in advance,
Wim.
> From:
the series.
This patch can be used even without the other patches.
I also like the WDOG_HW_RUNNING flag. But I would split the patch that adds
this into 2 patches:
* a patch that adds the WDOG_HW_RUNNING flag
* and a patch that makes the stop function optional.
Thanks in advance,
Wim.
> From:
+0100
watchdog: Fix dependencies for !HAS_IOMEM archs
Not every arch has io memory.
So, unbreak the build by fixing the dependencies.
Signed-off-by: Richard Weinberger
Signed-off-by: Guenter Roeck
Signed-off-by: Wim Van Sebroeck
commit
gt;
Signed-off-by: Wim Van Sebroeck <w...@iguana.be>
commit df1a3e64f79b3e277a22b2e789896f86c63eec1f
Author: Arnd Bergmann <a...@arndb.de>
Date: Mon Jan 25 17:06:27 2016 +0100
watchdog: imgdpc: select WATCHDOG_CORE
The imgpdc_wdt driver can be built on all architecture
l device removal in the driver core code, and file access
> functions won't be called before the function returns.
> Remove previously added message "watchdog still running". It wasn't
> there before, and we should avoid user visible changes.
> Add missing kfree(
l device removal in the driver core code, and file access
> functions won't be called before the function returns.
> Remove previously added message "watchdog still running". It wasn't
> there before, and we should avoid user visible changes.
> Add missing kfree(
790b42f23..b1e3da7dc393 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11602,6 +11602,7 @@ F:drivers/input/tablet/wacom_serial4.c
>
> WATCHDOG DEVICE DRIVERS
> M: Wim Van Sebroeck
> +R: Guenter Roeck
> L: linux-watch...@vger.kernel.org
> W: http://www.lin
or changed to use the parent device.
> One driver sets the variable during initialization to the watchdog
> driver's parent device, which is wrong and was removed.
>
> v2: Use parent device for dev_XXX messages instead of pr_XXX.
This patchset has been added to linux-wat
");
> +
> + return 0;
> +}
> +
> +static int tangox_wdt_remove(struct platform_device *pdev)
> +{
> + struct tangox_wdt_device *dev = platform_get_drvdata(pdev);
> +
> + tangox_wdt_stop(>wdt);
> + clk_disable_unprepare(dev->clk);
> +
> + unr
201 - 300 of 937 matches
Mail list logo
