On Thu, Dec 13, 2018 at 12:22:49PM -0800, Christoph Hellwig wrote:
> On Wed, Dec 12, 2018 at 12:26:10PM -0800, Eric Biggers wrote:
> > > As this apparently got merged despite no proper reviews from VFS
> > > level persons:
> >
> > fs-verity has been out for review since August, and Cc'ed to all
On Thu, Dec 13, 2018 at 10:48:07AM +0100, Ard Biesheuvel wrote:
> > @@ -64,13 +65,19 @@ static size_t rng_buffer_size(void)
> > static void add_early_randomness(struct hwrng *rng)
> > {
> > int bytes_read;
> > - size_t size = min_t(size_t, 16, rng_buffer_size());
> > + /*
The fscrypt.git tree has been updated with for the problem. Apologies
for not testing the !CONFIG_FS_VERITY case.
- Ted
On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> Hi,
>
> Bisect from today's next pointed me to:
> commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> Author: Chandan Rajendra
> Date: Sat Dec 8 12:21:43 2018 +0530
> fsverity: Move verity status check to
On Mon, Nov 26, 2018 at 11:27:37AM -0800, Eric Biggers wrote:
> From: Eric Biggers
>
> Add support for the Adiantum encryption mode to fscrypt. Adiantum is a
> tweakable, length-preserving encryption mode with security provably
> reducible to that of XChaCha12 and AES-256, subject to a security
On Sat, Dec 08, 2018 at 12:56:29PM +0100, Greg KH wrote:
> A nice step forward would have been if someone could have at least
> _told_ the stable maintainer (i.e. me) that there was such a serious bug
> out there. That didn't happen here and I only found out about it
> accidentally by happening
On Sat, Dec 08, 2018 at 12:56:29PM +0100, Greg KH wrote:
> A nice step forward would have been if someone could have at least
> _told_ the stable maintainer (i.e. me) that there was such a serious bug
> out there. That didn't happen here and I only found out about it
> accidentally by happening
On Mon, Nov 26, 2018 at 02:56:32PM +0100, Jan Kara wrote:
> On Fri 23-11-18 16:40:53, Colin King wrote:
> > From: Colin Ian King
> >
> > There is a statement that is indented with spaces, replace it with
> > a tab.
> >
> > Signed-off-by: Colin Ian King
>
> Looks good. You can add:
>
>
On Mon, Nov 26, 2018 at 02:56:32PM +0100, Jan Kara wrote:
> On Fri 23-11-18 16:40:53, Colin King wrote:
> > From: Colin Ian King
> >
> > There is a statement that is indented with spaces, replace it with
> > a tab.
> >
> > Signed-off-by: Colin Ian King
>
> Looks good. You can add:
>
>
On Tue, Nov 27, 2018 at 10:28:36AM +0100, Jan Kara wrote:
> On Fri 23-11-18 16:30:43, Colin King wrote:
> > From: Colin Ian King
> >
> > There are several lines that are indented too far, clean these
> > up by removing the tabs.
> >
> > Signed-off-by: Colin Ian King
>
> The patch looks good.
On Tue, Nov 27, 2018 at 10:28:36AM +0100, Jan Kara wrote:
> On Fri 23-11-18 16:30:43, Colin King wrote:
> > From: Colin Ian King
> >
> > There are several lines that are indented too far, clean these
> > up by removing the tabs.
> >
> > Signed-off-by: Colin Ian King
>
> The patch looks good.
On Tue, Nov 27, 2018 at 10:14:53AM +0100, Jan Kara wrote:
> On Mon 26-11-18 11:21:06, Pan Bian wrote:
> > The function frees qf_inode via iput but then pass qf_inode to
> > lockdep_set_quota_inode on the failure path. This may result in a
> > use-after-free bug. The patch frees df_inode only when
On Tue, Nov 27, 2018 at 10:14:53AM +0100, Jan Kara wrote:
> On Mon 26-11-18 11:21:06, Pan Bian wrote:
> > The function frees qf_inode via iput but then pass qf_inode to
> > lockdep_set_quota_inode on the failure path. This may result in a
> > use-after-free bug. The patch frees df_inode only when
On Wed, Nov 28, 2018 at 04:56:51PM +0100, Rainer Fiebig wrote:
>
> If you still see the errors, at least the Ubuntu-kernel could be ruled out.
My impression is that some of the people reporting problems have been
using stock upstream kernels, so I wasn't really worried about the
Ubuntu kernel
On Wed, Nov 28, 2018 at 04:56:51PM +0100, Rainer Fiebig wrote:
>
> If you still see the errors, at least the Ubuntu-kernel could be ruled out.
My impression is that some of the people reporting problems have been
using stock upstream kernels, so I wasn't really worried about the
Ubuntu kernel
On Wed, Nov 28, 2018 at 08:50:39AM +, Willy Wolff wrote:
> I got a Oops when the hard drive was COMPLETELY full using a ext4 fs.
> After it, any command on the directory where the last write should have
> occurred freezes, while any other directory behave just fine.
Was this true after you
On Wed, Nov 28, 2018 at 08:50:39AM +, Willy Wolff wrote:
> I got a Oops when the hard drive was COMPLETELY full using a ext4 fs.
> After it, any command on the directory where the last write should have
> occurred freezes, while any other directory behave just fine.
Was this true after you
On Wed, Nov 28, 2018 at 03:16:33AM +0300, Andrey Jr. Melnikov wrote:
> Corrupted inodes - always directory, not touched at least year or
> more for writing. Something wrong when updating atime?
We're not sure. The frustrating thing is that it's not reproducing
for me. I run extensive regression
On Wed, Nov 28, 2018 at 03:16:33AM +0300, Andrey Jr. Melnikov wrote:
> Corrupted inodes - always directory, not touched at least year or
> more for writing. Something wrong when updating atime?
We're not sure. The frustrating thing is that it's not reproducing
for me. I run extensive regression
On Mon, Nov 19, 2018 at 11:31:21AM -0800, Randy Dunlap wrote:
>
> Yes, all of that.
> Having some kind of pstore on x86 would be wonderful.
>
> kexec/kdump used to be an option also. I haven't tried it lately.
Sure, but kexec/kdump won't work to debug a boot failure during early
boot. You
On Mon, Nov 19, 2018 at 11:31:21AM -0800, Randy Dunlap wrote:
>
> Yes, all of that.
> Having some kind of pstore on x86 would be wonderful.
>
> kexec/kdump used to be an option also. I haven't tried it lately.
Sure, but kexec/kdump won't work to debug a boot failure during early
boot. You
On Mon, Nov 19, 2018 at 08:51:17PM +0530, AIAMUZZ wrote:
> Hi,
>
> I have this nagging and frustrating boot freeze i often face on my
> Deepin OS boot ... Deepin OS i think uses 'journalctl' to record logs
> on its system.
>
> 'journalctl' however seems to record boot logs ONLY for successful
>
On Mon, Nov 19, 2018 at 08:51:17PM +0530, AIAMUZZ wrote:
> Hi,
>
> I have this nagging and frustrating boot freeze i often face on my
> Deepin OS boot ... Deepin OS i think uses 'journalctl' to record logs
> on its system.
>
> 'journalctl' however seems to record boot logs ONLY for successful
>
On Sun, Nov 18, 2018 at 3:55 PM Ard Biesheuvel
wrote:
>
> On Sat, 17 Nov 2018 at 23:47, Y Song wrote:
> >
> > On Sat, Nov 17, 2018 at 6:58 PM Ard Biesheuvel
> > wrote:
> > >
> > > All arch overrides of the __weak bpf_jit_free() amount to the same
&
On Sun, Nov 18, 2018 at 3:55 PM Ard Biesheuvel
wrote:
>
> On Sat, 17 Nov 2018 at 23:47, Y Song wrote:
> >
> > On Sat, Nov 17, 2018 at 6:58 PM Ard Biesheuvel
> > wrote:
> > >
> > > All arch overrides of the __weak bpf_jit_free() amount to the same
&
On Wed, Nov 14, 2018 at 6:01 PM Roman Gushchin wrote:
>
> Naresh reported an issue with the non-atomic memory allocation of
> cgroup local storage buffers:
>
> [ 73.047526] BUG: sleeping function called from invalid context at
>
On Wed, Nov 14, 2018 at 6:01 PM Roman Gushchin wrote:
>
> Naresh reported an issue with the non-atomic memory allocation of
> cgroup local storage buffers:
>
> [ 73.047526] BUG: sleeping function called from invalid context at
>
On Thu, Nov 15, 2018 at 04:29:43PM +, Joseph Myers wrote:
> On Thu, 15 Nov 2018, Theodore Y. Ts'o wrote:
>
> > That's great. But is it or is it not true (either de jure or de
> > facto) that "a single active glibc developer" can block a system call
>
On Thu, Nov 15, 2018 at 04:29:43PM +, Joseph Myers wrote:
> On Thu, 15 Nov 2018, Theodore Y. Ts'o wrote:
>
> > That's great. But is it or is it not true (either de jure or de
> > facto) that "a single active glibc developer" can block a system call
>
On Wed, Nov 14, 2018 at 06:47:57PM +, Joseph Myers wrote:
> On Wed, 14 Nov 2018, Daniel Colascione wrote:
>
> > A good demonstration of a new commitment to pragmatism would be
> > merging the trivial wrappers for gettid(2).
>
> I support the addition of gettid (for use with those syscalls
On Wed, Nov 14, 2018 at 06:47:57PM +, Joseph Myers wrote:
> On Wed, 14 Nov 2018, Daniel Colascione wrote:
>
> > A good demonstration of a new commitment to pragmatism would be
> > merging the trivial wrappers for gettid(2).
>
> I support the addition of gettid (for use with those syscalls
On Tue, Nov 13, 2018 at 12:18:05PM +1100, Dave Chinner wrote:
> I'm not interested in making code fast if distro support engineers
> can't debug problems on user systems easily. Optimising for
> performance over debuggability is a horrible trade off for us to
> make because it means users and
On Tue, Nov 13, 2018 at 12:18:05PM +1100, Dave Chinner wrote:
> I'm not interested in making code fast if distro support engineers
> can't debug problems on user systems easily. Optimising for
> performance over debuggability is a horrible trade off for us to
> make because it means users and
On Mon, Nov 12, 2018 at 12:45:26PM +, Szabolcs Nagy wrote:
> >> A lot of the new system calls lack clear specifications or are just
> >> somewhat misdesigned. For example, pkey_alloc
> > [snip]
> >> getrandom still causes boot delays
I'll note that what some people consider misdesigns,
On Mon, Nov 12, 2018 at 12:45:26PM +, Szabolcs Nagy wrote:
> >> A lot of the new system calls lack clear specifications or are just
> >> somewhat misdesigned. For example, pkey_alloc
> > [snip]
> >> getrandom still causes boot delays
I'll note that what some people consider misdesigns,
On Sun, Nov 11, 2018 at 05:14:45AM -0800, Christoph Hellwig wrote:
> I think this goes in the wrong way. There isn't really any point
> in filtering at all if we have access to the whole device by the
> file persmissions, and we generally should not allow any access for
> partitions.
It really
On Sun, Nov 11, 2018 at 05:14:45AM -0800, Christoph Hellwig wrote:
> I think this goes in the wrong way. There isn't really any point
> in filtering at all if we have access to the whole device by the
> file persmissions, and we generally should not allow any access for
> partitions.
It really
The following changes since commit 33458eaba4dfe778a426df6a19b7aad2ff9f7eec:
ext4: fix use-after-free race in ext4_remount()'s error path (2018-10-12
09:28:09 -0400)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git
The following changes since commit 33458eaba4dfe778a426df6a19b7aad2ff9f7eec:
ext4: fix use-after-free race in ext4_remount()'s error path (2018-10-12
09:28:09 -0400)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git
On Thu, Nov 08, 2018 at 04:15:40PM -0500, Theodore Y. Ts'o wrote:
> On Thu, Nov 08, 2018 at 06:00:59PM +, mario.limoncie...@dell.com wrote:
> > > Sortly after 12:30am US/Eastern, I got a low power warning on my
> > > system, and the battery power had dropped b
On Thu, Nov 08, 2018 at 04:15:40PM -0500, Theodore Y. Ts'o wrote:
> On Thu, Nov 08, 2018 at 06:00:59PM +, mario.limoncie...@dell.com wrote:
> > > Sortly after 12:30am US/Eastern, I got a low power warning on my
> > > system, and the battery power had dropped b
On Fri, Nov 09, 2018 at 08:49:48AM +0300, Vasily Averin wrote:
> According to Ted Ts'o ext4_getblk() called in ext4_xattr_inode_write()
> should not return bh = NULL
>
> The only time that bh could be NULL, then, would be in the case of
> something really going wrong; a programming error
On Fri, Nov 09, 2018 at 08:49:48AM +0300, Vasily Averin wrote:
> According to Ted Ts'o ext4_getblk() called in ext4_xattr_inode_write()
> should not return bh = NULL
>
> The only time that bh could be NULL, then, would be in the case of
> something really going wrong; a programming error
On Thu, Nov 08, 2018 at 01:04:49PM -0800, Greg KH wrote:
> > (Also note that even with fast SSD's and/or everything in page cache,
> > runnning "tag --contains " will take a good 3-4 seconds, and
> > if the git packs are not in the page cache, and/or you're unfortunate
> > enough to have your git
On Thu, Nov 08, 2018 at 01:04:49PM -0800, Greg KH wrote:
> > (Also note that even with fast SSD's and/or everything in page cache,
> > runnning "tag --contains " will take a good 3-4 seconds, and
> > if the git packs are not in the page cache, and/or you're unfortunate
> > enough to have your git
On Thu, Nov 08, 2018 at 06:00:59PM +, mario.limoncie...@dell.com wrote:
> > Sortly after 12:30am US/Eastern, I got a low power warning on my
> > system, and the battery power had dropped below 10%. Apparently the
> > laptop was not accepting any charge any more. I tried doing a suspend
> >
On Thu, Nov 08, 2018 at 06:00:59PM +, mario.limoncie...@dell.com wrote:
> > Sortly after 12:30am US/Eastern, I got a low power warning on my
> > system, and the battery power had dropped below 10%. Apparently the
> > laptop was not accepting any charge any more. I tried doing a suspend
> >
On Thu, Nov 08, 2018 at 09:19:33AM -0800, Dan Williams wrote:
>
> I know at least StGit mail does not grok that "#"notation. I've
> stopped using it in favor of a "Fixes:" tag. I would think "Fixes:" is
> preferred over "# " if only because it can be used to track
> fixes to commits that have
On Thu, Nov 08, 2018 at 09:19:33AM -0800, Dan Williams wrote:
>
> I know at least StGit mail does not grok that "#"notation. I've
> stopped using it in favor of a "Fixes:" tag. I would think "Fixes:" is
> preferred over "# " if only because it can be used to track
> fixes to commits that have
On Thu, Nov 08, 2018 at 09:33:47AM -0700, Jonathan Corbet wrote:
>
> > I thought there was a slot already scheduled on the refereed track,
> > "Towards a Linux Kernel Mainainer Handbook" (Tuesday at 4:45pm) for
> > this purpose?
>
> My expectation is that this will be an actual talk; it seemed
On Thu, Nov 08, 2018 at 09:33:47AM -0700, Jonathan Corbet wrote:
>
> > I thought there was a slot already scheduled on the refereed track,
> > "Towards a Linux Kernel Mainainer Handbook" (Tuesday at 4:45pm) for
> > this purpose?
>
> My expectation is that this will be an actual talk; it seemed
On Thu, Nov 08, 2018 at 04:05:17PM +0100, Peter Zijlstra wrote:
> On Thu, Nov 08, 2018 at 07:49:20AM -0700, Jonathan Corbet wrote:
> > Might it be worth asking Ted for a kernel summit slot to talk about this
> > next week?
>
> Ah, on that, let me complain :-)
>
> My plumbers schedule is already
On Thu, Nov 08, 2018 at 04:05:17PM +0100, Peter Zijlstra wrote:
> On Thu, Nov 08, 2018 at 07:49:20AM -0700, Jonathan Corbet wrote:
> > Might it be worth asking Ted for a kernel summit slot to talk about this
> > next week?
>
> Ah, on that, let me complain :-)
>
> My plumbers schedule is already
On Thu, Nov 08, 2018 at 09:46:30AM +0300, Vasily Averin wrote:
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index 0b9688683526..415f73d4c9e6 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1384,6 +1384,12 @@ static int ext4_xattr_inode_write(handle_t *handle,
> struct inode
On Thu, Nov 08, 2018 at 09:46:30AM +0300, Vasily Averin wrote:
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index 0b9688683526..415f73d4c9e6 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/ext4/xattr.c
> @@ -1384,6 +1384,12 @@ static int ext4_xattr_inode_write(handle_t *handle,
> struct inode
On Wed, Nov 07, 2018 at 08:30:17PM +0300, Vasily Averin wrote:
> Fixes dc6982ff4db1 ("ext4: refactor code to read directory blocks ...")
> Cc: sta...@kernel.org # 3.9
>
> Signed-off-by: Vasily Averin
Thanks, applied. I used the commit description:
ext4: fix buffer leak in
On Wed, Nov 07, 2018 at 08:30:17PM +0300, Vasily Averin wrote:
> Fixes dc6982ff4db1 ("ext4: refactor code to read directory blocks ...")
> Cc: sta...@kernel.org # 3.9
>
> Signed-off-by: Vasily Averin
Thanks, applied. I used the commit description:
ext4: fix buffer leak in
On Wed, Oct 31, 2018 at 10:13:09PM +0300, Vasily Averin wrote:
> Fixes de05ca852679 ("ext4: move call to ext4_error() into ...") # 4.17
>
> Signed-off-by: Vasily Averin
Thanks, applied. I used the commit description:
ext4: fix buffer leak in ext4_expand_extra_isize_ea() on error path
On Wed, Oct 31, 2018 at 10:13:09PM +0300, Vasily Averin wrote:
> Fixes de05ca852679 ("ext4: move call to ext4_error() into ...") # 4.17
>
> Signed-off-by: Vasily Averin
Thanks, applied. I used the commit description:
ext4: fix buffer leak in ext4_expand_extra_isize_ea() on error path
On Wed, Nov 07, 2018 at 05:06:08PM -0800, Vito Caputo wrote:
> In reading the news today, I stumbled across an article talking about a
> $20 "linux-based distro" app for Windows 10.
>
> This is just a bundled userspace for WSL, there is no actual Linux in
> this thing, yet the trademarked Linux
On Wed, Nov 07, 2018 at 05:06:08PM -0800, Vito Caputo wrote:
> In reading the news today, I stumbled across an article talking about a
> $20 "linux-based distro" app for Windows 10.
>
> This is just a bundled userspace for WSL, there is no actual Linux in
> this thing, yet the trademarked Linux
On Fri, Nov 02, 2018 at 12:04:47PM +0100, Rasmus Villemoes wrote:
> Since the definition of struct crng_state is private to random.c, and
> primary_crng is neither declared or used elsewhere, there's no reason
> for that symbol to have external linkage.
>
> Signed-off-by: Rasmus Villemoes
On Fri, Nov 02, 2018 at 12:04:45PM +0100, Rasmus Villemoes wrote:
> Never modified, might as well be put in .rodata.
>
> Signed-off-by: Rasmus Villemoes
Thanks, applied.
- Ted
On Fri, Nov 02, 2018 at 12:04:47PM +0100, Rasmus Villemoes wrote:
> Since the definition of struct crng_state is private to random.c, and
> primary_crng is neither declared or used elsewhere, there's no reason
> for that symbol to have external linkage.
>
> Signed-off-by: Rasmus Villemoes
On Fri, Nov 02, 2018 at 12:04:45PM +0100, Rasmus Villemoes wrote:
> Never modified, might as well be put in .rodata.
>
> Signed-off-by: Rasmus Villemoes
Thanks, applied.
- Ted
On Fri, Nov 02, 2018 at 12:04:46PM +0100, Rasmus Villemoes wrote:
> This field is never used, might as well remove it.
>
> Signed-off-by: Rasmus Villemoes
Thanks, applied.
- Ted
On Fri, Nov 02, 2018 at 12:04:46PM +0100, Rasmus Villemoes wrote:
> This field is never used, might as well remove it.
>
> Signed-off-by: Rasmus Villemoes
Thanks, applied.
- Ted
On Wed, Nov 07, 2018 at 10:47:24AM -0800, Olof Johansson wrote:
>
> Can we have 3pm-3:30pm on Thursday? It seems relatively low on
> embedded-related conflicts and at 3 people would have time to migrate
> from Daniel Vetter's gitlab talk if needed.
I'd really like to keep the slots all 45
On Wed, Nov 07, 2018 at 10:47:24AM -0800, Olof Johansson wrote:
>
> Can we have 3pm-3:30pm on Thursday? It seems relatively low on
> embedded-related conflicts and at 3 people would have time to migrate
> from Daniel Vetter's gitlab talk if needed.
I'd really like to keep the slots all 45
On Wed, Nov 07, 2018 at 09:35:09AM -0800, Olof Johansson wrote:
>
> Tuesday afternoon looks least conflict-y when I squint at the
> schedule, or Thursday afternoon (but ideally not overlapping with
> Daniel's DRM/gitlab session).
I've posted a draft schedule, so why d
On Wed, Nov 07, 2018 at 09:35:09AM -0800, Olof Johansson wrote:
>
> Tuesday afternoon looks least conflict-y when I squint at the
> schedule, or Thursday afternoon (but ideally not overlapping with
> Daniel's DRM/gitlab session).
I've posted a draft schedule, so why d
On Tue, Nov 06, 2018 at 02:16:27PM -0800, Olof Johansson wrote:
>
> Olof Johansson (arm-soc)
> Arnd Bergmann (arm-soc)
> Kevin Hilman (arm-soc)
> Mike Turquette (clk)
> Stephen Boyd (clk)
> Linus Walleij (pinctrl + more)
> Mike Brown (gpio/regmap + more)
Could the poeple listed on this list
On Tue, Nov 06, 2018 at 02:16:27PM -0800, Olof Johansson wrote:
>
> Olof Johansson (arm-soc)
> Arnd Bergmann (arm-soc)
> Kevin Hilman (arm-soc)
> Mike Turquette (clk)
> Stephen Boyd (clk)
> Linus Walleij (pinctrl + more)
> Mike Brown (gpio/regmap + more)
Could the poeple listed on this list
On Sun, Nov 04, 2018 at 08:29:39PM +0300, Vasily Averin wrote:
> ext4_getblk() called with map_flags=0 can return NULL,
> it can lead to oops on bh dereferemce
>
> Fixes e50e5129f384 ("ext4: xattr-in-inode support")
> Cc: sta...@kernel.org # 4.13
>
> Signed-off-by: Vasily Averin
> ---
>
On Sun, Nov 04, 2018 at 08:29:39PM +0300, Vasily Averin wrote:
> ext4_getblk() called with map_flags=0 can return NULL,
> it can lead to oops on bh dereferemce
>
> Fixes e50e5129f384 ("ext4: xattr-in-inode support")
> Cc: sta...@kernel.org # 4.13
>
> Signed-off-by: Vasily Averin
> ---
>
On Wed, Nov 07, 2018 at 02:50:16PM +0100, Jan Kara wrote:
> On Wed 31-10-18 22:13:00, Vasily Averin wrote:
> > Fixes 3f2571c1f91f ("ext4: factor out xattr moving")
> > cc: Jan Kara
> > however issue was present in original ext4_expand_extra_isize_ea()
> > Fixes 6dd4ee7cab7e ("ext4: Expand
On Wed, Nov 07, 2018 at 02:50:16PM +0100, Jan Kara wrote:
> On Wed 31-10-18 22:13:00, Vasily Averin wrote:
> > Fixes 3f2571c1f91f ("ext4: factor out xattr moving")
> > cc: Jan Kara
> > however issue was present in original ext4_expand_extra_isize_ea()
> > Fixes 6dd4ee7cab7e ("ext4: Expand
On Wed, Oct 31, 2018 at 10:12:52PM +0300, Vasily Averin wrote:
> bs.bh was taken in previous ext4_xattr_block_find() call,
> it should be released before re-using
>
> Fixes 7e01c8e5420b ("ext3/4: fix uninitialized bs in ...") # 2.6.26
> cc: Tiger Yang
>
> Signed-off-by: Vasily Averin
Thanks,
On Wed, Oct 31, 2018 at 10:12:52PM +0300, Vasily Averin wrote:
> bs.bh was taken in previous ext4_xattr_block_find() call,
> it should be released before re-using
>
> Fixes 7e01c8e5420b ("ext3/4: fix uninitialized bs in ...") # 2.6.26
> cc: Tiger Yang
>
> Signed-off-by: Vasily Averin
Thanks,
On Wed, Oct 31, 2018 at 10:12:43PM +0300, Vasily Averin wrote:
> Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13
>
> Signed-off-by: Vasily Averin
Thanks, applied. I used the description line:
ext4: fix buffer leak in ext4_xattr_get_block() on error path
On Wed, Oct 31, 2018 at 10:12:43PM +0300, Vasily Averin wrote:
> Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13
>
> Signed-off-by: Vasily Averin
Thanks, applied. I used the description line:
ext4: fix buffer leak in ext4_xattr_get_block() on error path
On Wed, Oct 31, 2018 at 10:12:35PM +0300, Vasily Averin wrote:
> Fixes c8585c6fcaf2 ("ext4: fix races between changing inode journal ...") #
> 4.7
>
> cc: Daeho Jeong
> Signed-off-by: Vasily Averin
Thanks, applied.
- Ted
On Wed, Oct 31, 2018 at 10:12:35PM +0300, Vasily Averin wrote:
> Fixes c8585c6fcaf2 ("ext4: fix races between changing inode journal ...") #
> 4.7
>
> cc: Daeho Jeong
> Signed-off-by: Vasily Averin
Thanks, applied.
- Ted
On Wed, Oct 31, 2018 at 10:12:27PM +0300, Vasily Averin wrote:
> Fixes bfe0a5f47ada ("ext4: add more mount time checks of the superblock") #
> 4.18
>
> Signed-off-by: Vasily Averin
> ---
> fs/ext4/super.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
On Wed, Oct 31, 2018 at 10:12:27PM +0300, Vasily Averin wrote:
> Fixes bfe0a5f47ada ("ext4: add more mount time checks of the superblock") #
> 4.18
>
> Signed-off-by: Vasily Averin
> ---
> fs/ext4/super.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
On Wed, Oct 31, 2018 at 10:12:18PM +0300, Vasily Averin wrote:
> Fixes dc6982ff4db1 ("ext4: refactor code to read directory blocks ...") # 3.9
>
> Signed-off-by: Vasily Averin
> ---
> fs/ext4/namei.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
>
On Wed, Oct 31, 2018 at 10:12:18PM +0300, Vasily Averin wrote:
> Fixes dc6982ff4db1 ("ext4: refactor code to read directory blocks ...") # 3.9
>
> Signed-off-by: Vasily Averin
> ---
> fs/ext4/namei.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
>
On Wed, Oct 31, 2018 at 12:58:46AM +0300, Vasily Averin wrote:
> brelse(iloc.bh) is useless here, it is always called with iloc.bh = NULL
>
> Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13
> cc: Tahsin Erdogan
>
> Signed-off-by: Vasily Averin
Applied. I droppped the "Fixes"
On Wed, Oct 31, 2018 at 12:58:46AM +0300, Vasily Averin wrote:
> brelse(iloc.bh) is useless here, it is always called with iloc.bh = NULL
>
> Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13
> cc: Tahsin Erdogan
>
> Signed-off-by: Vasily Averin
Applied. I droppped the "Fixes"
On Wed, Oct 31, 2018 at 12:58:38AM +0300, Vasily Averin wrote:
> iloc.bh was taken in ext4_reserve_inode_write() and released
> in ext4_mark_iloc_dirty(). It should not be released 2nd time
> in rollback after failed ext4_handle_dirty_metadata(gdb_bh)
>
> Fixes b40971426a83 ("ext4: add error
On Wed, Oct 31, 2018 at 12:58:38AM +0300, Vasily Averin wrote:
> iloc.bh was taken in ext4_reserve_inode_write() and released
> in ext4_mark_iloc_dirty(). It should not be released 2nd time
> in rollback after failed ext4_handle_dirty_metadata(gdb_bh)
>
> Fixes b40971426a83 ("ext4: add error
On Wed, Oct 31, 2018 at 12:58:31AM +0300, Vasily Averin wrote:
> iloc.bh os taken in ext4_reserve_inode_write().
> If (dirty == true) it is released in ext4_mark_iloc_dirty(),
> however it is not released in (dirty == false) case.
>
> Fixes d745a8c20c1f ("ext4: reduce contention on
On Wed, Oct 31, 2018 at 12:58:31AM +0300, Vasily Averin wrote:
> iloc.bh os taken in ext4_reserve_inode_write().
> If (dirty == true) it is released in ext4_mark_iloc_dirty(),
> however it is not released in (dirty == false) case.
>
> Fixes d745a8c20c1f ("ext4: reduce contention on
On Wed, Oct 31, 2018 at 12:58:24AM +0300, Vasily Averin wrote:
> ext4_mark_iloc_dirty() callers expect that it releases iloc->bh
> even if it returns an error.
>
> Fixes 0db1ff222d40 ("ext4: add shutdown bit and check for it") # 4.11
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed
On Wed, Oct 31, 2018 at 12:58:24AM +0300, Vasily Averin wrote:
> ext4_mark_iloc_dirty() callers expect that it releases iloc->bh
> even if it returns an error.
>
> Fixes 0db1ff222d40 ("ext4: add shutdown bit and check for it") # 4.11
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed
On Wed, Oct 31, 2018 at 12:58:16AM +0300, Vasily Averin wrote:
> Fixes 1c6bd7173d66 ("ext4: convert file system to meta_bg if needed ...") #
> 3.7
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed up the commit description and Fixes/Cc
trailers.
On Wed, Oct 31, 2018 at 12:58:16AM +0300, Vasily Averin wrote:
> Fixes 1c6bd7173d66 ("ext4: convert file system to meta_bg if needed ...") #
> 3.7
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed up the commit description and Fixes/Cc
trailers.
On Wed, Oct 31, 2018 at 12:58:09AM +0300, Vasily Averin wrote:
> Fixes 117fff10d7f1 ("ext4: grow the s_flex_groups array as needed ...") # 3.7
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed up the commit description and Fixes/Cc
trailers.
-
On Wed, Oct 31, 2018 at 12:58:09AM +0300, Vasily Averin wrote:
> Fixes 117fff10d7f1 ("ext4: grow the s_flex_groups array as needed ...") # 3.7
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed up the commit description and Fixes/Cc
trailers.
-
On Wed, Oct 31, 2018 at 12:58:03AM +0300, Vasily Averin wrote:
> bh was not released after error in ext4_journal_get_write_access()
>
> Fixes ac27a0ec112a ("ext4: initial copy of files from ext3") # 2.6.19
>
> Signed-off-by: Vasily Averin
Thanks, applied. I fixed up the commit description and
301 - 400 of 3865 matches
Mail list logo
