Re: [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself

2012-11-07 Thread yongd
On 2012年11月06日 20:52, Shawn Guo wrote: On Tue, Nov 06, 2012 at 04:49:42PM +0800, yongd wrote: From your info, we can see that on your platform, those pins (including power, clk, DATA) necessary for MMC_SEND_STATUS transaction still keep connected for some time just after the GPIO's level

Re: [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself

2012-11-07 Thread yongd
On 2012年11月06日 20:52, Shawn Guo wrote: On Tue, Nov 06, 2012 at 04:49:42PM +0800, yongd wrote: From your info, we can see that on your platform, those pins (including power, clk, DATA) necessary for MMC_SEND_STATUS transaction still keep connected for some time just after the GPIO's level

Re: [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself

2012-11-06 Thread yongd
On 2012年11月05日 20:48, Shawn Guo wrote: On Mon, Nov 05, 2012 at 11:34:49AM +0800, yongd wrote: From the code logic, without SDHCI_QUIRK_BROKEN_CARD_DETECTION for ESDHC_CD_GPIO, when your card (using GPIO detection) is removed, we can know the card's absence through the fake CARD_PRESENT flag

Re: [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself

2012-11-06 Thread yongd
On 2012年11月05日 20:48, Shawn Guo wrote: On Mon, Nov 05, 2012 at 11:34:49AM +0800, yongd wrote: From the code logic, without SDHCI_QUIRK_BROKEN_CARD_DETECTION for ESDHC_CD_GPIO, when your card (using GPIO detection) is removed, we can know the card's absence through the fake CARD_PRESENT flag

Re: [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself

2012-11-04 Thread yongd
On 2012年11月05日 09:54, Shawn Guo wrote: On Fri, Nov 02, 2012 at 08:37:41PM +0800, yongd wrote: I got it. So how do you think of such below partition/reorganization? It looks fine to me for imx. Ok. I will update like this way if we have no other issues. Thanks. Patch-1: For sdhci-esdhc

Re: [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself

2012-11-04 Thread yongd
On 2012年11月05日 09:54, Shawn Guo wrote: On Fri, Nov 02, 2012 at 08:37:41PM +0800, yongd wrote: I got it. So how do you think of such below partition/reorganization? It looks fine to me for imx. Ok. I will update like this way if we have no other issues. Thanks. Patch-1: For sdhci-esdhc

Re: [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself

2012-11-02 Thread yongd
On 2012年10月31日 23:20, Shawn Guo wrote: On Tue, Oct 30, 2012 at 05:30:01PM +0800, yongd wrote: In the current code logic, sdhci_add_host() will enable the polling method (set MMC_CAP_NEEDS_POLL) for a removable card (MMC_CAP_ NONREMOVABLE is not set) whose host's internal card detection method

Re: [PATCH V2 1/3] mmc: esdhc: enable polling to detect card by itself

2012-11-02 Thread yongd
On 2012年10月31日 23:20, Shawn Guo wrote: On Tue, Oct 30, 2012 at 05:30:01PM +0800, yongd wrote: In the current code logic, sdhci_add_host() will enable the polling method (set MMC_CAP_NEEDS_POLL) for a removable card (MMC_CAP_ NONREMOVABLE is not set) whose host's internal card detection method

Re: [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-10-31 Thread yongd
On 2012年10月31日 07:11, Anton Vorontsov wrote: On Tue, Oct 30, 2012 at 05:30:00PM +0800, yongd wrote: Sorry for my so late. And eventually these updated patches are here for your review. Thanks in advance. For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type

Re: [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-10-31 Thread yongd
On 2012年10月31日 07:11, Anton Vorontsov wrote: On Tue, Oct 30, 2012 at 05:30:00PM +0800, yongd wrote: Sorry for my so late. And eventually these updated patches are here for your review. Thanks in advance. For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type

Re: [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-10-31 Thread yongd
On 2012年10月31日 07:11, Anton Vorontsov wrote: On Tue, Oct 30, 2012 at 05:30:00PM +0800, yongd wrote: Sorry for my so late. And eventually these updated patches are here for your review. Thanks in advance. For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type

Re: [PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-10-31 Thread yongd
On 2012年10月31日 07:11, Anton Vorontsov wrote: On Tue, Oct 30, 2012 at 05:30:00PM +0800, yongd wrote: Sorry for my so late. And eventually these updated patches are here for your review. Thanks in advance. For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type

[PATCH V2 3/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-10-30 Thread yongd
. Actually, some host driver has already been like this. Eg, in drivers/mmc/host/Au1xmmc.c, polling will be enabled only after the board-specific card detection can't be set up successfully. Change-Id: I27774488a7b9191d7bc39699fd7d62ee21bbf157 Signed-off-by: yongd --- drivers/mmc/host/sdhci.c

[PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-10-30 Thread yongd
Hi all, Sorry for my so late. And eventually these updated patches are here for your review. Thanks in advance. For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type, or the host controller detection interrupts will be redundantly enabled. And its comment is

[PATCH V2 0/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-10-30 Thread yongd
Hi all, Sorry for my so late. And eventually these updated patches are here for your review. Thanks in advance. For patch 1, add SDHCI_QUIRK_BROKEN_CARD_DETECTION setting for ESDHC_CD_GPIO type, or the host controller detection interrupts will be redundantly enabled. And its comment is

[PATCH V2 3/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-10-30 Thread yongd
. Actually, some host driver has already been like this. Eg, in drivers/mmc/host/Au1xmmc.c, polling will be enabled only after the board-specific card detection can't be set up successfully. Change-Id: I27774488a7b9191d7bc39699fd7d62ee21bbf157 Signed-off-by: yongd yo...@marvell.com --- drivers/mmc

[no subject]

2012-09-28 Thread yongd
n...@marvell.com> # This line is ignored. From: yongd Subject:[PATCH 0/3] mmc: enable card-detection polling in host driver rather than in sdhci_add_host In-Reply-To: Hi all, As checked, SDHCI_QUICK_BROKEN_CARD_DETECTION was previously introduced by Anton Vorontsov in com

[PATCH 3/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-09-28 Thread yongd
. Actually, some host driver has already been like this. Eg, in drivers/mmc/host/Au1xmmc.c, polling will be enabled only after the board-specific card detection can't be set up successfully. Change-Id: I27774488a7b9191d7bc39699fd7d62ee21bbf157 Signed-off-by: yongd --- drivers/mmc/host/sdhci.c

[PATCH 3/3] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-09-28 Thread yongd
. Actually, some host driver has already been like this. Eg, in drivers/mmc/host/Au1xmmc.c, polling will be enabled only after the board-specific card detection can't be set up successfully. Change-Id: I27774488a7b9191d7bc39699fd7d62ee21bbf157 Signed-off-by: yongd yo...@marvell.com --- drivers/mmc

[no subject]

2012-09-28 Thread yongd
n...@marvell.com # This line is ignored. From: yongd yo...@marvell.com Subject:[PATCH 0/3] mmc: enable card-detection polling in host driver rather than in sdhci_add_host In-Reply-To: Hi all, As checked, SDHCI_QUICK_BROKEN_CARD_DETECTION was previously introduced by Anton Vorontsov in commit