Re: [PATCH] perf evsel: Enable ignore_missing_thread for pid option

2017-12-07 Thread zhangmengting
Hi Jiri, Thanks for your review! I've sent a patch V2 to address these issues. On 2017/12/6 20:59, Jiri Olsa wrote: On Tue, Dec 05, 2017 at 05:03:33PM +0800, Mengting Zhang wrote: While monitoring a multithread process with pid option, perf sometimes may return sys_perf_event_open failure

Re: [PATCH] perf evsel: Enable ignore_missing_thread for pid option

2017-12-07 Thread zhangmengting
Hi Jiri, Thanks for your review! I've sent a patch V2 to address these issues. On 2017/12/6 20:59, Jiri Olsa wrote: On Tue, Dec 05, 2017 at 05:03:33PM +0800, Mengting Zhang wrote: While monitoring a multithread process with pid option, perf sometimes may return sys_perf_event_open failure

Re: [PATCH] perf parse events: Fix invalid precise_ip handling

2017-11-21 Thread zhangmengting
On 2017/11/20 15:33, Jiri Olsa wrote: On Wed, Nov 15, 2017 at 09:00:03AM +0800, zhangmengting wrote: Hi Jiri, thanks for your detailed review, please see my comments inline. On 2017/11/10 18:39, Jiri Olsa wrote: On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote: SNIP diff

Re: [PATCH] perf parse events: Fix invalid precise_ip handling

2017-11-21 Thread zhangmengting
On 2017/11/20 15:33, Jiri Olsa wrote: On Wed, Nov 15, 2017 at 09:00:03AM +0800, zhangmengting wrote: Hi Jiri, thanks for your detailed review, please see my comments inline. On 2017/11/10 18:39, Jiri Olsa wrote: On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote: SNIP diff

Re: [PATCH] perf parse events: Fix invalid precise_ip handling

2017-11-14 Thread zhangmengting
Hi Jiri, thanks for your detailed review, please see my comments inline. On 2017/11/10 18:39, Jiri Olsa wrote: On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote: SNIP diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 39b1596..25225f4 100644 ---

Re: [PATCH] perf parse events: Fix invalid precise_ip handling

2017-11-14 Thread zhangmengting
Hi Jiri, thanks for your detailed review, please see my comments inline. On 2017/11/10 18:39, Jiri Olsa wrote: On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote: SNIP diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 39b1596..25225f4 100644 ---

Re: [PATCH] perf evsel: Fix incorrect precise_ip in default event name

2017-11-09 Thread zhangmengting
Hi Namhyung, Yeah, you are right. I'll send a new patch later. Thanks, Mengting Zhang On 2017/11/10 14:30, Namhyung Kim wrote: Hello, On Fri, Nov 10, 2017 at 01:49:06PM +0800, Mengting Zhang wrote: When no event is specified with -e option, perf will specify a "cycles" event with the

Re: [PATCH] perf evsel: Fix incorrect precise_ip in default event name

2017-11-09 Thread zhangmengting
Hi Namhyung, Yeah, you are right. I'll send a new patch later. Thanks, Mengting Zhang On 2017/11/10 14:30, Namhyung Kim wrote: Hello, On Fri, Nov 10, 2017 at 01:49:06PM +0800, Mengting Zhang wrote: When no event is specified with -e option, perf will specify a "cycles" event with the

Re: [PATCH] perf script: Add option to display guest samples in host

2017-10-23 Thread zhangmengting
Hi all, For sched_switch tracepoint, I guess maybe it would be more reasonable to show guest samples together with host samples by default, instead of setting an option to display guest samples when we meet with this confused situation. To take care of this issue, the code should be changed

Re: [PATCH] perf script: Add option to display guest samples in host

2017-10-23 Thread zhangmengting
Hi all, For sched_switch tracepoint, I guess maybe it would be more reasonable to show guest samples together with host samples by default, instead of setting an option to display guest samples when we meet with this confused situation. To take care of this issue, the code should be changed

Re: [PATCH] perf report: Fix debug messages with --call-graph option

2017-09-23 Thread zhangmengting
Hi Jiri, Thanks for the review. Agreed, the patch seems confused. I'll add more details in the next version patch and resend it later. Thanks, Mengting Zhang On 2017/9/22 17:18, Jiri Olsa wrote: On Fri, Sep 22, 2017 at 10:06:53AM +0800, zhangmengting wrote: With --call-graph option, perf

Re: [PATCH] perf report: Fix debug messages with --call-graph option

2017-09-23 Thread zhangmengting
Hi Jiri, Thanks for the review. Agreed, the patch seems confused. I'll add more details in the next version patch and resend it later. Thanks, Mengting Zhang On 2017/9/22 17:18, Jiri Olsa wrote: On Fri, Sep 22, 2017 at 10:06:53AM +0800, zhangmengting wrote: With --call-graph option, perf

[PATCH] perf report: Fix debug messages with --call-graph option

2017-09-21 Thread zhangmengting
Invalid callchain order: percent Invalid callchain sort key: percent The patch fixes this issue. Signed-off-by: zhangmengting <zhangmengt...@huawei.com> --- tools/perf/util/callchain.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a

[PATCH] perf report: Fix debug messages with --call-graph option

2017-09-21 Thread zhangmengting
Invalid callchain order: percent Invalid callchain sort key: percent The patch fixes this issue. Signed-off-by: zhangmengting --- tools/perf/util/callchain.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/tools/perf/util/callchain.c b