Hi Jiri,
Thanks for your review! I've sent a patch V2 to address these issues.
On 2017/12/6 20:59, Jiri Olsa wrote:
On Tue, Dec 05, 2017 at 05:03:33PM +0800, Mengting Zhang wrote:
While monitoring a multithread process with pid option, perf sometimes
may return sys_perf_event_open failure
Hi Jiri,
Thanks for your review! I've sent a patch V2 to address these issues.
On 2017/12/6 20:59, Jiri Olsa wrote:
On Tue, Dec 05, 2017 at 05:03:33PM +0800, Mengting Zhang wrote:
While monitoring a multithread process with pid option, perf sometimes
may return sys_perf_event_open failure
On 2017/11/20 15:33, Jiri Olsa wrote:
On Wed, Nov 15, 2017 at 09:00:03AM +0800, zhangmengting wrote:
Hi Jiri, thanks for your detailed review, please see my comments inline.
On 2017/11/10 18:39, Jiri Olsa wrote:
On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote:
SNIP
diff
On 2017/11/20 15:33, Jiri Olsa wrote:
On Wed, Nov 15, 2017 at 09:00:03AM +0800, zhangmengting wrote:
Hi Jiri, thanks for your detailed review, please see my comments inline.
On 2017/11/10 18:39, Jiri Olsa wrote:
On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote:
SNIP
diff
Hi Jiri, thanks for your detailed review, please see my comments inline.
On 2017/11/10 18:39, Jiri Olsa wrote:
On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote:
SNIP
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 39b1596..25225f4 100644
---
Hi Jiri, thanks for your detailed review, please see my comments inline.
On 2017/11/10 18:39, Jiri Olsa wrote:
On Fri, Nov 10, 2017 at 04:28:37PM +0800, Mengting Zhang wrote:
SNIP
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 39b1596..25225f4 100644
---
Hi Namhyung,
Yeah, you are right. I'll send a new patch later.
Thanks,
Mengting Zhang
On 2017/11/10 14:30, Namhyung Kim wrote:
Hello,
On Fri, Nov 10, 2017 at 01:49:06PM +0800, Mengting Zhang wrote:
When no event is specified with -e option, perf will specify a
"cycles" event with the
Hi Namhyung,
Yeah, you are right. I'll send a new patch later.
Thanks,
Mengting Zhang
On 2017/11/10 14:30, Namhyung Kim wrote:
Hello,
On Fri, Nov 10, 2017 at 01:49:06PM +0800, Mengting Zhang wrote:
When no event is specified with -e option, perf will specify a
"cycles" event with the
Hi all,
For sched_switch tracepoint, I guess maybe it would be more reasonable
to show guest samples together with host samples by default, instead of
setting an option to display guest samples when we meet with this
confused situation.
To take care of this issue, the code should be changed
Hi all,
For sched_switch tracepoint, I guess maybe it would be more reasonable
to show guest samples together with host samples by default, instead of
setting an option to display guest samples when we meet with this
confused situation.
To take care of this issue, the code should be changed
Hi Jiri,
Thanks for the review. Agreed, the patch seems confused.
I'll add more details in the next version patch and resend it later.
Thanks,
Mengting Zhang
On 2017/9/22 17:18, Jiri Olsa wrote:
On Fri, Sep 22, 2017 at 10:06:53AM +0800, zhangmengting wrote:
With --call-graph option, perf
Hi Jiri,
Thanks for the review. Agreed, the patch seems confused.
I'll add more details in the next version patch and resend it later.
Thanks,
Mengting Zhang
On 2017/9/22 17:18, Jiri Olsa wrote:
On Fri, Sep 22, 2017 at 10:06:53AM +0800, zhangmengting wrote:
With --call-graph option, perf
Invalid callchain order: percent
Invalid callchain sort key: percent
The patch fixes this issue.
Signed-off-by: zhangmengting <zhangmengt...@huawei.com>
---
tools/perf/util/callchain.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a
Invalid callchain order: percent
Invalid callchain sort key: percent
The patch fixes this issue.
Signed-off-by: zhangmengting
---
tools/perf/util/callchain.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/tools/perf/util/callchain.c b
14 matches
Mail list logo