Re: [v2] time: Validate the usec before covert to nsec in do_adjtimex

2019-07-08 Thread zhangxiaoxu (A)
在 2019/7/8 21:04, Thomas Gleixner 写道: On Mon, 8 Jul 2019, ZhangXiaoxu wrote: When covert the usec to nsec, it will multiple 1000, it maybe overflow and lead an undefined behavior. For example, users may input an negative tv_usec values when call adjtimex syscall, then multiple 1000 maybe

Re: [PATCH] time: Validate the usec before covert to nsec in do_adjtimex

2019-07-08 Thread zhangxiaoxu (A)
在 2019/7/8 17:24, Thomas Gleixner 写道: On Mon, 8 Jul 2019, ZhangXiaoxu wrote: When covert the usec to nsec, it will multiple 1000, it maybe overflow and lead an undefined behavior. For example, users may input an negative tv_usec values when call adjtimex syscall, then multiple 1000 maybe

[v2] time: Validate the usec before covert to nsec in do_adjtimex

2019-07-08 Thread ZhangXiaoxu
coverted it to nsec. Signed-off-by: ZhangXiaoxu --- kernel/time/timekeeping.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 44b726b..778796d 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -2321,6

[PATCH] time: Validate the usec before covert to nsec in do_adjtimex

2019-07-08 Thread ZhangXiaoxu
coverted it to nsec. Signed-off-by: ZhangXiaoxu --- kernel/time/timekeeping.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 44b726b..e5c1d00 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time

Re: [PATCH] futex: Fix futex lock the wrong page

2019-06-11 Thread zhangxiaoxu (A)
This patch is for stable branch linux-4.4-y. On 2019/6/12 9:54, ZhangXiaoxu wrote: The upstram commit 65d8fc777f6d ("futex: Remove requirement for lock_page() in get_futex_key()") use variable 'page' as the page head, when merge it to stable branch, the variable `page_head` is

[PATCH] futex: Fix futex lock the wrong page

2019-06-11 Thread ZhangXiaoxu
page head, we should lock 'page_head', rather than 'page'. It maybe lead a hung task problem. Signed-off-by: ZhangXiaoxu Cc: sta...@vger.kernel.org --- kernel/futex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/futex.c b/kernel/futex.c index ec9df5b..15d8

Re: [PATCH] fs/buffer.c: Fix data corruption when buffer write with IO error

2019-04-09 Thread zhangxiaoxu (A)
On 4/8/2019 7:11 PM, Jan Kara wrote: On Sat 06-04-19 15:13:13, ZhangXiaoxu wrote: When the buffer write failed, 'end_buffer_write_sync' and 'end_buffer_async_write' will clear the uptodate flag. But the data in the buffer maybe newer than disk. In some case, this will lead data corruption

[PATCH] fs/buffer.c: Fix data corruption when buffer write with IO error

2019-04-06 Thread ZhangXiaoxu
flag when write the buffer failed. Signed-off-by: ZhangXiaoxu --- fs/buffer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index ce35760..9fe1827 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -172,7 +172,6 @@ void end_buffer_write_sync(struct buffer_head *bh, int