[PATCH 1/2] phy:phy-brcm-us: Use PTR_ERR_OR_ZERO to replace the open code

PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So just replace them rather than duplicating its implement. Signed-off-by: zhong jiang --- drivers/phy/broadcom/phy-brcm-usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/broadcom/phy-brcm

[PATCH 0/2] phy: Use PTR_ERR_OR_ZERO to replace the open code

The issue is detected with the help of Coccinelle. zhong jiang (2): phy:phy-brcm-us: Use PTR_ERR_OR_ZERO to replace the open code phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open code drivers/phy/broadcom/phy-brcm-usb.c | 4 +--- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c

[PATCH 0/2] phy: Use PTR_ERR_OR_ZERO to replace the open code

The issue is detected with the help of Coccinelle. zhong jiang (2): phy:phy-brcm-us: Use PTR_ERR_OR_ZERO to replace the open code phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open code drivers/phy/broadcom/phy-brcm-usb.c | 4 +--- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c

[PATCH 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open code

PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So just replace them rather than duplicating its implement. Signed-off-by: zhong jiang --- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/lantiq/phy-lantiq

[PATCH 2/2] phy:phy-lantiq-rcu-usb2: Use PTR_ERR_OR_ZERO to replace the open code

PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So just replace them rather than duplicating its implement. Signed-off-by: zhong jiang --- drivers/phy/lantiq/phy-lantiq-rcu-usb2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/lantiq/phy-lantiq

Re: [PATCH] staging:pci-mt7621: Use PTR_ERR_OR_ZERO to replace the open code

On 2018/8/13 19:26, Sergio Paracuellos wrote: > On Mon, Aug 13, 2018 at 12:54 PM, zhong jiang wrote: >> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So >> just replace them rather than duplicating its implement. >> >> Signed-off-by: zhong jiang >&g

Re: [PATCH] staging:pci-mt7621: Use PTR_ERR_OR_ZERO to replace the open code

On 2018/8/13 19:26, Sergio Paracuellos wrote: > On Mon, Aug 13, 2018 at 12:54 PM, zhong jiang wrote: >> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So >> just replace them rather than duplicating its implement. >> >> Signed-off-by: zhong jiang >&g

[PATCH] staging:pci-mt7621: Use PTR_ERR_OR_ZERO to replace the open code

PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So just replace them rather than duplicating its implement. Signed-off-by: zhong jiang --- drivers/staging/mt7621-pci/pci-mt7621.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci

[PATCH] staging:pci-mt7621: Use PTR_ERR_OR_ZERO to replace the open code

PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So just replace them rather than duplicating its implement. Signed-off-by: zhong jiang --- drivers/staging/mt7621-pci/pci-mt7621.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci

[PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

kmemdup is better than kmalloc() + memcpy(), and we do not like open code. So just use kmemdup instead. Signed-off-by: zhong jiang --- arch/arm/mach-lpc32xx/pm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c

[PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

kmemdup is better than kmalloc() + memcpy(), and we do not like open code. So just use kmemdup instead. Signed-off-by: zhong jiang --- arch/arm/mach-lpc32xx/pm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c

[PATCH] ia64:tioce_provider: Use kmemdup rather than implement the function

The kmemdup has implemented the function that kmalloc() + memcpy will do. So just replace them to make the code concise. Signed-off-by: zhong jiang --- arch/ia64/sn/pci/tioce_provider.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ia64/sn/pci/tioce_provider.c b

[PATCH] ia64:tioce_provider: Use kmemdup rather than implement the function

The kmemdup has implemented the function that kmalloc() + memcpy will do. So just replace them to make the code concise. Signed-off-by: zhong jiang --- arch/ia64/sn/pci/tioce_provider.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ia64/sn/pci/tioce_provider.c b

[PATCH] arm:pmsa-v8: remove some extra semicolon

There are some extra semicolon in pmsa-v8.c. So just remove them. I detect the issue with the help of Coccinelle. Signed-off-by: zhong jiang --- arch/arm/mm/pmsa-v8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/pmsa-v8.c b/arch/arm/mm/pmsa-v8.c index

[PATCH] arm:pmsa-v8: remove some extra semicolon

There are some extra semicolon in pmsa-v8.c. So just remove them. I detect the issue with the help of Coccinelle. Signed-off-by: zhong jiang --- arch/arm/mm/pmsa-v8.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mm/pmsa-v8.c b/arch/arm/mm/pmsa-v8.c index

[PATCH 0/2] arm64: remove some extra semicolon

There are some extra semicolon in arm64 architecture. Just remove them. zhong jiang (2): arm64/kprobes: remove an extra semicolon in arch_prepare_kprobe arm64:guest: remove some extra semicolon in kvm_target_cpu arch/arm64/kernel/probes/kprobes.c | 2 +- arch/arm64/kvm/guest.c

[PATCH 0/2] arm64: remove some extra semicolon

There are some extra semicolon in arm64 architecture. Just remove them. zhong jiang (2): arm64/kprobes: remove an extra semicolon in arch_prepare_kprobe arm64:guest: remove some extra semicolon in kvm_target_cpu arch/arm64/kernel/probes/kprobes.c | 2 +- arch/arm64/kvm/guest.c

[PATCH 1/2] arm64/kprobes: remove an extra semicolon in arch_prepare_kprobe

There is an extra semicolon in arch_prepare_kprobe, remove it. Signed-off-by: zhong jiang --- arch/arm64/kernel/probes/kprobes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c index e78c3ef..9b65132

[PATCH 2/2] arm64:guest: remove some extra semicolon in kvm_target_cpu

There are some extra semicolon in kvm_target_cpu, remove it. Signed-off-by: zhong jiang --- arch/arm64/kvm/guest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c index 07256b0..a74f84d 100644 --- a/arch/arm64/kvm/guest.c

[PATCH 1/2] arm64/kprobes: remove an extra semicolon in arch_prepare_kprobe

There is an extra semicolon in arch_prepare_kprobe, remove it. Signed-off-by: zhong jiang --- arch/arm64/kernel/probes/kprobes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c index e78c3ef..9b65132

[PATCH 2/2] arm64:guest: remove some extra semicolon in kvm_target_cpu

There are some extra semicolon in kvm_target_cpu, remove it. Signed-off-by: zhong jiang --- arch/arm64/kvm/guest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c index 07256b0..a74f84d 100644 --- a/arch/arm64/kvm/guest.c

[PATCH] drivers/thermal/tegra: fix a doule free devce node

Device node iterators will get the return node. Meawhile, It is also put the previous device node. An explicit put will cause a double put. Signed-off-by: zhong jiang --- drivers/thermal/tegra/soctherm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/thermal/tegra/soctherm.c b

[PATCH] drivers/thermal/tegra: fix a doule free devce node

Device node iterators will get the return node. Meawhile, It is also put the previous device node. An explicit put will cause a double put. Signed-off-by: zhong jiang --- drivers/thermal/tegra/soctherm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/thermal/tegra/soctherm.c b

[PATCH] drivers/block/drbd: remove the null check for kmem_cache_destroy

kmem_cache_destroy has taken null pointer into account. So it is safe to drop the null check before calling the function. Signed-off-by: zhong jiang --- drivers/block/drbd/drbd_main.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c

[PATCH] drivers/block/drbd: remove the null check for kmem_cache_destroy

kmem_cache_destroy has taken null pointer into account. So it is safe to drop the null check before calling the function. Signed-off-by: zhong jiang --- drivers/block/drbd/drbd_main.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c

[PATCH] drivers/block/aoe/aoedev: NULL check is not needed for mempool_destroy

mempool_destroy has taken the null pointer into account. So it is safe to remove the null check. Signed-off-by: zhong jiang --- drivers/block/aoe/aoedev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index

[PATCH] drivers/block/aoe/aoedev: NULL check is not needed for mempool_destroy

mempool_destroy has taken the null pointer into account. So it is safe to remove the null check. Signed-off-by: zhong jiang --- drivers/block/aoe/aoedev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index

[PATCH] drivers/block/mtip32xx: remove the null check for debugfs_remove_recursive

debugfs_remove_recursive has taken null pointer into account. So it is safe to drop the null check before calling the funtion. Signed-off-by: zhong jiang --- drivers/block/mtip32xx/mtip32xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c

[PATCH] drivers/block/mtip32xx: remove the null check for debugfs_remove_recursive

debugfs_remove_recursive has taken null pointer into account. So it is safe to drop the null check before calling the funtion. Signed-off-by: zhong jiang --- drivers/block/mtip32xx/mtip32xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c

[PATCH] staging: gasket: remove some extra semicolon

That semicolons are unneeded, Just remove them. Signed-off-by: zhong jiang --- drivers/staging/gasket/gasket_interrupt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c index 09c3d07

[PATCH] staging: gasket: remove some extra semicolon

That semicolons are unneeded, Just remove them. Signed-off-by: zhong jiang --- drivers/staging/gasket/gasket_interrupt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c index 09c3d07

Re: [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded variable "err"

On 2018/8/5 23:27, Joe Perches wrote: > On Sun, 2018-08-05 at 23:02 +0800, zhong jiang wrote: >> The err is not used after initalization, So remove it and make >> the function to be void function. > [] >> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > [] >>

Re: [PATCH 1/3] fs/btrfs/disk-io: Remove unneeded variable "err"

On 2018/8/5 23:27, Joe Perches wrote: > On Sun, 2018-08-05 at 23:02 +0800, zhong jiang wrote: >> The err is not used after initalization, So remove it and make >> the function to be void function. > [] >> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c > [] >>

Re: [PATCH 0/3] Remove uneeded variable "err"

On 2018/8/6 3:14, Nikolay Borisov wrote: > > On 5.08.2018 18:02, zhong jiang wrote: >> zhong jiang (3): >> fs/btrfs/disk-io: Remove unneeded variable "err" >> fs/btrfs/extent-tree: remove redudant variable "err" >> fs/btrfs/tree-log: remov

Re: [PATCH 0/3] Remove uneeded variable "err"

On 2018/8/6 3:14, Nikolay Borisov wrote: > > On 5.08.2018 18:02, zhong jiang wrote: >> zhong jiang (3): >> fs/btrfs/disk-io: Remove unneeded variable "err" >> fs/btrfs/extent-tree: remove redudant variable "err" >> fs/btrfs/tree-log: remov

Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

On 2018/8/6 8:33, David Miller wrote: > From: zhong jiang > Date: Sun, 5 Aug 2018 22:18:43 +0800 > >> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br, >> struct sk_buff *skb_trimmed = NULL; >> const unsigned char *src; >>

Re: [PATCH] net/bridge/br_multicast: remove redundant variable "err"

On 2018/8/6 8:33, David Miller wrote: > From: zhong jiang > Date: Sun, 5 Aug 2018 22:18:43 +0800 > >> @@ -1797,7 +1795,7 @@ static int br_multicast_ipv4_rcv(struct net_bridge *br, >> struct sk_buff *skb_trimmed = NULL; >> const unsigned char *src; >>

Re: [PATCH] drivers/staging: Remove some unneeded semicolon

On 2018/8/6 9:27, Gao Xiang wrote: > Hi Jiang, > > On 2018/8/5 21:57, zhong jiang wrote: >> That semicolons are unneeded, JUst remove them. >> >> Signed-off-by: zhong jiang > Thanks for your patch. Since erofs and gasket are different feature, it is > be

Re: [PATCH] drivers/staging: Remove some unneeded semicolon

On 2018/8/6 9:27, Gao Xiang wrote: > Hi Jiang, > > On 2018/8/5 21:57, zhong jiang wrote: >> That semicolons are unneeded, JUst remove them. >> >> Signed-off-by: zhong jiang > Thanks for your patch. Since erofs and gasket are different feature, it is > be

[PATCH] drivers/staging: Remove some unneeded semicolon

That semicolons are unneeded, JUst remove them. Signed-off-by: zhong jiang --- drivers/staging/erofs/unzip_vle.c | 2 +- drivers/staging/gasket/gasket_interrupt.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers

[PATCH] drivers/staging: Remove some unneeded semicolon

That semicolons are unneeded, JUst remove them. Signed-off-by: zhong jiang --- drivers/staging/erofs/unzip_vle.c | 2 +- drivers/staging/gasket/gasket_interrupt.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers

Re: [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static

On 2018/8/3 21:21, Steven Rostedt wrote: > On Fri, 3 Aug 2018 20:40:02 +0800 > zhong jiang wrote: > >> Fix the following warning. >> >> kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was >> not declared. Should it be static? > &

Re: [PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static

On 2018/8/3 21:21, Steven Rostedt wrote: > On Fri, 3 Aug 2018 20:40:02 +0800 > zhong jiang wrote: > >> Fix the following warning. >> >> kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was >> not declared. Should it be static? > &

Re: [PATCH] ext4/mballoc: Remove unneeded variable "err"

On 2018/8/5 5:24, Theodore Y. Ts'o wrote: > On Sat, Aug 04, 2018 at 07:04:56PM +0800, zhong jiang wrote: >> The err is not used after initalization. So just remove the variable. >> >> Signed-off-by: zhong jiang > I'll apply this patch, but how did you generate the diff?

Re: [PATCH] ext4/mballoc: Remove unneeded variable "err"

On 2018/8/5 5:24, Theodore Y. Ts'o wrote: > On Sat, Aug 04, 2018 at 07:04:56PM +0800, zhong jiang wrote: >> The err is not used after initalization. So just remove the variable. >> >> Signed-off-by: zhong jiang > I'll apply this patch, but how did you generate the diff?

[PATCH] ext4/mballoc: Remove unneeded variable "err"

The err is not used after initalization. So just remove the variable. Signed-off-by: zhong jiang --- fs/ext4/mballoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 8b24d3d..e29fce2 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4

[PATCH] ext4/mballoc: Remove unneeded variable "err"

The err is not used after initalization. So just remove the variable. Signed-off-by: zhong jiang --- fs/ext4/mballoc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 8b24d3d..e29fce2 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4

[PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static

Fix the following warning. kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static? Signed-off-by: zhong jiang --- kernel/kthread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kthread.c b/kernel/kthread.c

[PATCH] kernel/kthread: Make function __kthread_queue_delayed_work static

Fix the following warning. kernel/kthread.c:859:6: warning: symbol '__kthread_queue_delayed_work' was not declared. Should it be static? Signed-off-by: zhong jiang --- kernel/kthread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kthread.c b/kernel/kthread.c

[PATCH] sched/topology: Make some local variable static

Fix the following warning. kernel/sched/topology.c:10:15: warning: symbol 'sched_domains_tmpmask' was not declared. Should it be static? kernel/sched/topology.c:11:15: warning: symbol 'sched_domains_tmpmask2' was not declared. Should it be static? Signed-off-by: zhong jiang --- kernel/sched

[PATCH] sched/topology: Make some local variable static

Fix the following warning. kernel/sched/topology.c:10:15: warning: symbol 'sched_domains_tmpmask' was not declared. Should it be static? kernel/sched/topology.c:11:15: warning: symbol 'sched_domains_tmpmask2' was not declared. Should it be static? Signed-off-by: zhong jiang --- kernel/sched

Re: [PATCH linux-next] driver/gpu: Fix mismatch in funciton argument type

On 2018/7/22 13:41, zhong jiang wrote: > Fix the following warning: > > drivers/gpu/drm/nouveau/dispnv50/wndw.c:570:1: error: symbol 'nv50_wndw_new_' > redeclared with different type > (originally declared at drivers/gpu/drm/nouveau/dispnv50/wndw.h:39) - > incompatible arg

Re: [PATCH linux-next] driver/gpu: Fix mismatch in funciton argument type

On 2018/7/22 13:41, zhong jiang wrote: > Fix the following warning: > > drivers/gpu/drm/nouveau/dispnv50/wndw.c:570:1: error: symbol 'nv50_wndw_new_' > redeclared with different type > (originally declared at drivers/gpu/drm/nouveau/dispnv50/wndw.h:39) - > incompatible arg

Re: [Question] A novel case happened when using mempool allocate memory.

On 2018/8/2 21:31, Matthew Wilcox wrote: > On Thu, Aug 02, 2018 at 02:22:03PM +0800, zhong jiang wrote: >> On 2018/8/1 23:37, Matthew Wilcox wrote: >>> Please post the code. >> when module is loaded. we create the specific mempool. The code flow is as >> follows. >

Re: [Question] A novel case happened when using mempool allocate memory.

On 2018/8/2 21:31, Matthew Wilcox wrote: > On Thu, Aug 02, 2018 at 02:22:03PM +0800, zhong jiang wrote: >> On 2018/8/1 23:37, Matthew Wilcox wrote: >>> Please post the code. >> when module is loaded. we create the specific mempool. The code flow is as >> follows. >

[tip:x86/cleanups] x86/iommu: Use NULL instead of 0

Commit-ID: 0b2c1aec49ddb2260894df6c69ae7b34142ff936 Gitweb: https://git.kernel.org/tip/0b2c1aec49ddb2260894df6c69ae7b34142ff936 Author: Zhong Jiang AuthorDate: Sat, 21 Jul 2018 16:33:24 +0800 Committer: Thomas Gleixner CommitDate: Thu, 2 Aug 2018 14:33:19 +0200 x86/iommu: Use NULL

[tip:x86/cleanups] x86/iommu: Use NULL instead of 0

Commit-ID: 0b2c1aec49ddb2260894df6c69ae7b34142ff936 Gitweb: https://git.kernel.org/tip/0b2c1aec49ddb2260894df6c69ae7b34142ff936 Author: Zhong Jiang AuthorDate: Sat, 21 Jul 2018 16:33:24 +0800 Committer: Thomas Gleixner CommitDate: Thu, 2 Aug 2018 14:33:19 +0200 x86/iommu: Use NULL

[tip:x86/platform] x86/platform/olpc: Use PTR_ERR_OR_ZERO()

Commit-ID: c7ba9f7cb55926605983187a68624999b93abb94 Gitweb: https://git.kernel.org/tip/c7ba9f7cb55926605983187a68624999b93abb94 Author: zhong jiang AuthorDate: Wed, 1 Aug 2018 00:08:06 +0800 Committer: Thomas Gleixner CommitDate: Thu, 2 Aug 2018 14:25:40 +0200 x86/platform/olpc: Use

[tip:x86/platform] x86/platform/olpc: Use PTR_ERR_OR_ZERO()

Commit-ID: c7ba9f7cb55926605983187a68624999b93abb94 Gitweb: https://git.kernel.org/tip/c7ba9f7cb55926605983187a68624999b93abb94 Author: zhong jiang AuthorDate: Wed, 1 Aug 2018 00:08:06 +0800 Committer: Thomas Gleixner CommitDate: Thu, 2 Aug 2018 14:25:40 +0200 x86/platform/olpc: Use

[tip:core/debugobjects] debugobjects: Remove redundant NULL pointer check

Commit-ID: 3ff4f80a74fd38398ae1bd8a458ba9c51aa0dd44 Gitweb: https://git.kernel.org/tip/3ff4f80a74fd38398ae1bd8a458ba9c51aa0dd44 Author: Zhong Jiang AuthorDate: Wed, 1 Aug 2018 00:24:58 +0800 Committer: Thomas Gleixner CommitDate: Thu, 2 Aug 2018 13:53:04 +0200 debugobjects: Remove

[tip:core/debugobjects] debugobjects: Remove redundant NULL pointer check

Commit-ID: 3ff4f80a74fd38398ae1bd8a458ba9c51aa0dd44 Gitweb: https://git.kernel.org/tip/3ff4f80a74fd38398ae1bd8a458ba9c51aa0dd44 Author: Zhong Jiang AuthorDate: Wed, 1 Aug 2018 00:24:58 +0800 Committer: Thomas Gleixner CommitDate: Thu, 2 Aug 2018 13:53:04 +0200 debugobjects: Remove

[PATCH v2 0/4] Use dma_zalloc_coherent and kvcalloc to replace open code

do nothing. just add Andy's review-by. zhong jiang (4): driver/scsi/fnic/fnic_trace: Use kvcalloc instead of vmalloc+memset drivers/scsi/dpt_i2o: Use dma_zalloc_coherent to repalce dma_alloc_coherent+memset drivers/scsi/snic/snic_trc: Use kvcalloc instead of vmalloc+memset drivers/scsi/mv

[PATCH v2 0/4] Use dma_zalloc_coherent and kvcalloc to replace open code

do nothing. just add Andy's review-by. zhong jiang (4): driver/scsi/fnic/fnic_trace: Use kvcalloc instead of vmalloc+memset drivers/scsi/dpt_i2o: Use dma_zalloc_coherent to repalce dma_alloc_coherent+memset drivers/scsi/snic/snic_trc: Use kvcalloc instead of vmalloc+memset drivers/scsi/mv

[PATCH v2 3/4] drivers/scsi/snic/snic_trc: Use kvcalloc instead of vmalloc+memset

The kvcalloc is better than vmalloc() + memset() , So replace them. Signed-off-by: zhong jiang --- drivers/scsi/snic/snic_trc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/snic/snic_trc.c b/drivers/scsi/snic/snic_trc.c index fc60c93..e766fa2 100644

[PATCH v2 3/4] drivers/scsi/snic/snic_trc: Use kvcalloc instead of vmalloc+memset

The kvcalloc is better than vmalloc() + memset() , So replace them. Signed-off-by: zhong jiang --- drivers/scsi/snic/snic_trc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/snic/snic_trc.c b/drivers/scsi/snic/snic_trc.c index fc60c93..e766fa2 100644

Re: [Question] A novel case happened when using mempool allocate memory.

On 2018/8/1 23:37, Matthew Wilcox wrote: > On Wed, Aug 01, 2018 at 11:31:15PM +0800, zhong jiang wrote: >> Hi, Everyone >> >> I ran across the following novel case similar to memory leak in linux-4.1 >> stable when allocating >> memory object by kmem_cache_all

Re: [Question] A novel case happened when using mempool allocate memory.

On 2018/8/1 23:37, Matthew Wilcox wrote: > On Wed, Aug 01, 2018 at 11:31:15PM +0800, zhong jiang wrote: >> Hi, Everyone >> >> I ran across the following novel case similar to memory leak in linux-4.1 >> stable when allocating >> memory object by kmem_cache_all

Re: [PATCH] fs/binfmt_elf: remove the same condition check

On 2018/8/2 11:04, Al Viro wrote: > On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: >> dump_align is used to double check in a expression. It is redundant. >> so just remove one of them. > > What makes you think that it is redundant? > I am sorry for that.

Re: [PATCH] fs/binfmt_elf: remove the same condition check

On 2018/8/2 11:04, Al Viro wrote: > On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: >> dump_align is used to double check in a expression. It is redundant. >> so just remove one of them. > > What makes you think that it is redundant? > I am sorry for that.

Re: [PATCH] fs/binfmt_elf: remove the same condition check

On 2018/8/2 10:34, Matthew Wilcox wrote: > On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: >> dump_align is used to double check in a expression. It is redundant. >> so just remove one of them. > You're wrong. Functions in C can have side-effects (and this one does

Re: [PATCH] fs/binfmt_elf: remove the same condition check

On 2018/8/2 10:34, Matthew Wilcox wrote: > On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote: >> dump_align is used to double check in a expression. It is redundant. >> so just remove one of them. > You're wrong. Functions in C can have side-effects (and this one does

Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

plese ingore it. On 2018/8/2 10:04, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. > > Signed-off-by: zhong jiang > --- > fs/binfmt_elf_fdpic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

plese ingore it. On 2018/8/2 10:04, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. > > Signed-off-by: zhong jiang > --- > fs/binfmt_elf_fdpic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

It is unncessary to use double test for a expression. so just remove one of them. Signed-off-by: zhong jiang --- fs/binfmt_elf_fdpic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index b53bb37..5162372 100644 --- a/fs

[PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

It is unncessary to use double test for a expression. so just remove one of them. Signed-off-by: zhong jiang --- fs/binfmt_elf_fdpic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c index b53bb37..5162372 100644 --- a/fs

[PATCH] fs/binfmt_elf: remove the same condition check

dump_align is used to double check in a expression. It is redundant. so just remove one of them. Signed-off-by: zhong jiang --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index efae2fb..b6c5b02 100644 --- a/fs

[PATCH] fs/binfmt_elf: remove the same condition check

dump_align is used to double check in a expression. It is redundant. so just remove one of them. Signed-off-by: zhong jiang --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index efae2fb..b6c5b02 100644 --- a/fs

[Question] A novel case happened when using mempool allocate memory.

gister the moudle. but I check the code(mm/slub.c) carefully . I can not find any clue to prove my assumption. I will be appreciate if anyone have any idea about the case. Thanks zhong jiang

[Question] A novel case happened when using mempool allocate memory.

gister the moudle. but I check the code(mm/slub.c) carefully . I can not find any clue to prove my assumption. I will be appreciate if anyone have any idea about the case. Thanks zhong jiang

[PATCH] drivers/staging/mt7621-eth: Use dma_zalloc_coherent to replace dma_alloc_coherent+memset

we prefer to use dma_zalloc_coherent rather than dam_alloc_coherent+memset Signed-off-by: zhong jiang --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth

[PATCH] drivers/staging/mt7621-eth: Use dma_zalloc_coherent to replace dma_alloc_coherent+memset

we prefer to use dma_zalloc_coherent rather than dam_alloc_coherent+memset Signed-off-by: zhong jiang --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth

[PATCH] kernel/module: Use kmemdup to replace kmalloc+memcpy

we prefer to the kmemdup rather than kmalloc+memcpy. so just replace them. Signed-off-by: zhong jiang --- kernel/module.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 20344e4..6746c85 100644 --- a/kernel/module.c +++ b/kernel

[PATCH] kernel/module: Use kmemdup to replace kmalloc+memcpy

we prefer to the kmemdup rather than kmalloc+memcpy. so just replace them. Signed-off-by: zhong jiang --- kernel/module.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index 20344e4..6746c85 100644 --- a/kernel/module.c +++ b/kernel

[PATCH] lib/debugobjects: remove redundant check when free the object

kmem_cache_destroy has taken the null check into account. so just remove the unnecessary check. Signed-off-by: zhong jiang --- lib/debugobjects.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/debugobjects.c b/lib/debugobjects.c index 994be48..7a6d80b 100644 --- a/lib

[PATCH] lib/debugobjects: remove redundant check when free the object

kmem_cache_destroy has taken the null check into account. so just remove the unnecessary check. Signed-off-by: zhong jiang --- lib/debugobjects.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/debugobjects.c b/lib/debugobjects.c index 994be48..7a6d80b 100644 --- a/lib

[PATCH] lib/sg_pool: remove unnecessary null check when free the object

kmem_cache_destroy/mempool_destroy has taken null check into account. so remove the redundant check. Signed-off-by: zhong jiang --- lib/sg_pool.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/sg_pool.c b/lib/sg_pool.c index 6dd3061..d1c1e63 100644 --- a/lib

[PATCH] lib/sg_pool: remove unnecessary null check when free the object

kmem_cache_destroy/mempool_destroy has taken null check into account. so remove the redundant check. Signed-off-by: zhong jiang --- lib/sg_pool.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/sg_pool.c b/lib/sg_pool.c index 6dd3061..d1c1e63 100644 --- a/lib

Re: [PATCH] lib/sg_pool,debugobjects: remove unnecessary null check when free the object

On 2018/8/1 0:21, Thomas Gleixner wrote: > On Tue, 31 Jul 2018, zhong jiang wrote: > >> kmem_cache_destroy/mempool_destroy has taken null check into account. >> so remove the redundant check. > Please split the patch so they can be applied independently by the relevant >

Re: [PATCH] lib/sg_pool,debugobjects: remove unnecessary null check when free the object

On 2018/8/1 0:21, Thomas Gleixner wrote: > On Tue, 31 Jul 2018, zhong jiang wrote: > >> kmem_cache_destroy/mempool_destroy has taken null check into account. >> so remove the redundant check. > Please split the patch so they can be applied independently by the relevant >

[PATCH] x86/platform/olpc: Use the PTR_ERR_OR_ZERO to simplify the code

use PTR_ERR_OR_ZERO is better than the open code Signed-off-by: zhong jiang --- arch/x86/platform/olpc/olpc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/platform/olpc/olpc.c b/arch/x86/platform/olpc/olpc.c index 7c3077e..f0e920f 100644 --- a/arch/x86

[PATCH] x86/platform/olpc: Use the PTR_ERR_OR_ZERO to simplify the code

use PTR_ERR_OR_ZERO is better than the open code Signed-off-by: zhong jiang --- arch/x86/platform/olpc/olpc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/platform/olpc/olpc.c b/arch/x86/platform/olpc/olpc.c index 7c3077e..f0e920f 100644 --- a/arch/x86

[PATCH] lib/sg_pool,debugobjects: remove unnecessary null check when free the object

kmem_cache_destroy/mempool_destroy has taken null check into account. so remove the redundant check. Signed-off-by: zhong jiang --- lib/debugobjects.c | 3 +-- lib/sg_pool.c | 7 +++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/debugobjects.c b/lib/debugobjects.c

[PATCH] lib/sg_pool,debugobjects: remove unnecessary null check when free the object

kmem_cache_destroy/mempool_destroy has taken null check into account. so remove the redundant check. Signed-off-by: zhong jiang --- lib/debugobjects.c | 3 +-- lib/sg_pool.c | 7 +++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/debugobjects.c b/lib/debugobjects.c

[PATCH] driver/hwtracing: use ERR_CAST instead of ERR_PTR

Use ERR_CAT inlined function to replace the ERR_PTR(PTR_ERR). It make the code more concise. Signed-off-by: zhong jiang --- drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b

[PATCH] driver/hwtracing: use ERR_CAST instead of ERR_PTR

Use ERR_CAT inlined function to replace the ERR_PTR(PTR_ERR). It make the code more concise. Signed-off-by: zhong jiang --- drivers/hwtracing/coresight/coresight-tmc-etr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b

[tip:x86/boot] x86/boot/KASLR: Make local variable mem_limit static

Commit-ID: 5db1b1e1ee34871b1965b3f890e3ccbdb185fa52 Gitweb: https://git.kernel.org/tip/5db1b1e1ee34871b1965b3f890e3ccbdb185fa52 Author: zhong jiang AuthorDate: Mon, 30 Jul 2018 21:44:33 +0800 Committer: Thomas Gleixner CommitDate: Mon, 30 Jul 2018 19:46:03 +0200 x86/boot/KASLR: Make

[tip:x86/boot] x86/boot/KASLR: Make local variable mem_limit static

Commit-ID: 5db1b1e1ee34871b1965b3f890e3ccbdb185fa52 Gitweb: https://git.kernel.org/tip/5db1b1e1ee34871b1965b3f890e3ccbdb185fa52 Author: zhong jiang AuthorDate: Mon, 30 Jul 2018 21:44:33 +0800 Committer: Thomas Gleixner CommitDate: Mon, 30 Jul 2018 19:46:03 +0200 x86/boot/KASLR: Make

[PATCH] x86/boot/KASLR: Make local variable mem_limit static

Fix the following sparse warning: arch/x86/boot/compressed/kaslr.c:102:20: warning: symbol 'mem_limit' was not declared. Should it be static? Signed-off-by: zhong jiang --- arch/x86/boot/compressed/kaslr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot

[PATCH] x86/boot/KASLR: Make local variable mem_limit static

Fix the following sparse warning: arch/x86/boot/compressed/kaslr.c:102:20: warning: symbol 'mem_limit' was not declared. Should it be static? Signed-off-by: zhong jiang --- arch/x86/boot/compressed/kaslr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/boot

Re: [PATCH v11 19/26] mm: provide speculative fault infrastructure

On 2018/7/25 18:44, Laurent Dufour wrote: > > On 25/07/2018 11:04, zhong jiang wrote: >> On 2018/7/25 0:10, Laurent Dufour wrote: >>> On 24/07/2018 16:26, zhong jiang wrote: >>>> On 2018/5/17 19:06, Laurent Dufour wrote: >>>>> From: Peter Zi

<    1   2   3   4   5   6   7   8   >