Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-18 Thread Jiri Olsa
On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP > > | > | - to add an ABI to support those vendor files > | > | And those are IMHO five good technical reasons to disagree with your > | approach. > | > | My suggestion to resolve the technical objections and lift

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-18 Thread Jiri Olsa
On Fri, Apr 17, 2015 at 01:09:54PM -0700, Andi Kleen wrote: > On Fri, Apr 17, 2015 at 05:31:26PM +0200, Jiri Olsa wrote: > > On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: > > > > SNIP > > > > > | > > > | - to blindly follow some poorly constructed vendor format with no

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-18 Thread Jiri Olsa
On Fri, Apr 17, 2015 at 01:09:54PM -0700, Andi Kleen wrote: On Fri, Apr 17, 2015 at 05:31:26PM +0200, Jiri Olsa wrote: On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP | | - to blindly follow some poorly constructed vendor format with no |high

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-18 Thread Jiri Olsa
On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP | | - to add an ABI to support those vendor files | | And those are IMHO five good technical reasons to disagree with your | approach. | | My suggestion to resolve the technical objections and lift the NAK

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-17 Thread Andi Kleen
On Fri, Apr 17, 2015 at 05:31:26PM +0200, Jiri Olsa wrote: > On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: > > SNIP > > > | > > | - to blindly follow some poorly constructed vendor format with no > > |high level structure, that IMHO didn't work very well when

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-17 Thread Jiri Olsa
On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP > | > | - to blindly follow some poorly constructed vendor format with no > |high level structure, that IMHO didn't work very well when OProfile > |was written, and misrepresenting it as 'symbolic event names'.

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-17 Thread Jiri Olsa
On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP | | - to blindly follow some poorly constructed vendor format with no |high level structure, that IMHO didn't work very well when OProfile |was written, and misrepresenting it as 'symbolic event names'. |

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-17 Thread Andi Kleen
On Fri, Apr 17, 2015 at 05:31:26PM +0200, Jiri Olsa wrote: On Wed, Apr 15, 2015 at 01:50:42PM -0700, Sukadev Bhattiprolu wrote: SNIP | | - to blindly follow some poorly constructed vendor format with no |high level structure, that IMHO didn't work very well when OProfile |

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-16 Thread Sukadev Bhattiprolu
| | * Michael Ellerman wrote: | | > > We just merged a patch series that was first sent in 2013. Some | > > things take time to get right. | > | > The first attempt to get symbolic event name support into perf was | > sent in 2010, that's FIVE years ago [1]. | | kgdb took even longer, I

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-16 Thread Sukadev Bhattiprolu
Ingo Molnar [mi...@kernel.org] wrote: Meant to Cc Tom Huynh as they had a related patchset a few months ago. | | * Michael Ellerman wrote: | | > On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: | > > * Sukadev Bhattiprolu wrote: | > > | > > > This is another attempt to resurrect Andi

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-16 Thread Sukadev Bhattiprolu
| | * Michael Ellerman m...@ellerman.id.au wrote: | | We just merged a patch series that was first sent in 2013. Some | things take time to get right. | | The first attempt to get symbolic event name support into perf was | sent in 2010, that's FIVE years ago [1]. | | kgdb took even

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-16 Thread Sukadev Bhattiprolu
Ingo Molnar [mi...@kernel.org] wrote: Meant to Cc Tom Huynh as they had a related patchset a few months ago. | | * Michael Ellerman m...@ellerman.id.au wrote: | | On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: | * Sukadev Bhattiprolu suka...@linux.vnet.ibm.com wrote: | |This

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-15 Thread Andi Kleen
> My suggestion to resolve the technical objections and lift the NAK > would be: > > - to add the tables to the source code, in a more human readable >format and (optionally) structure the event names better into a >higher level hierarchy, than the humungous linear dumps with no >

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-15 Thread Ingo Molnar
* Michael Ellerman wrote: > > We just merged a patch series that was first sent in 2013. Some > > things take time to get right. > > The first attempt to get symbolic event name support into perf was > sent in 2010, that's FIVE years ago [1]. kgdb took even longer, I think it was first

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-15 Thread Andi Kleen
My suggestion to resolve the technical objections and lift the NAK would be: - to add the tables to the source code, in a more human readable format and (optionally) structure the event names better into a higher level hierarchy, than the humungous linear dumps with no

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-15 Thread Ingo Molnar
* Michael Ellerman m...@ellerman.id.au wrote: We just merged a patch series that was first sent in 2013. Some things take time to get right. The first attempt to get symbolic event name support into perf was sent in 2010, that's FIVE years ago [1]. kgdb took even longer, I think it

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Michael Ellerman
On Tue, 2015-04-14 at 14:58 +0200, Ingo Molnar wrote: > * Michael Ellerman wrote: > > > On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: > > > * Sukadev Bhattiprolu wrote: > > > > > > > This is another attempt to resurrect Andi Kleen's patchset so users > > > > can specify perf events by

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Andi Kleen
On Tue, Apr 14, 2015 at 10:55:41AM +0200, Ingo Molnar wrote: > > * Sukadev Bhattiprolu wrote: > > > This is another attempt to resurrect Andi Kleen's patchset so users > > can specify perf events by their event names rather than raw codes. > > > > This is a rebase of Andi Kleen's patchset from

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Ingo Molnar
* Michael Ellerman wrote: > On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: > > * Sukadev Bhattiprolu wrote: > > > > > This is another attempt to resurrect Andi Kleen's patchset so users > > > can specify perf events by their event names rather than raw codes. > > > > > > This is a

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Michael Ellerman
On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: > * Sukadev Bhattiprolu wrote: > > > This is another attempt to resurrect Andi Kleen's patchset so users > > can specify perf events by their event names rather than raw codes. > > > > This is a rebase of Andi Kleen's patchset from Jul 30,

'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Ingo Molnar
* Sukadev Bhattiprolu wrote: > This is another attempt to resurrect Andi Kleen's patchset so users > can specify perf events by their event names rather than raw codes. > > This is a rebase of Andi Kleen's patchset from Jul 30, 2014[1] to 4.0. > (I fixed minor and not so minor conflicts). So

'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Ingo Molnar
* Sukadev Bhattiprolu suka...@linux.vnet.ibm.com wrote: This is another attempt to resurrect Andi Kleen's patchset so users can specify perf events by their event names rather than raw codes. This is a rebase of Andi Kleen's patchset from Jul 30, 2014[1] to 4.0. (I fixed minor and not so

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Michael Ellerman
On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: * Sukadev Bhattiprolu suka...@linux.vnet.ibm.com wrote: This is another attempt to resurrect Andi Kleen's patchset so users can specify perf events by their event names rather than raw codes. This is a rebase of Andi Kleen's

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Andi Kleen
On Tue, Apr 14, 2015 at 10:55:41AM +0200, Ingo Molnar wrote: * Sukadev Bhattiprolu suka...@linux.vnet.ibm.com wrote: This is another attempt to resurrect Andi Kleen's patchset so users can specify perf events by their event names rather than raw codes. This is a rebase of Andi

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Michael Ellerman
On Tue, 2015-04-14 at 14:58 +0200, Ingo Molnar wrote: * Michael Ellerman m...@ellerman.id.au wrote: On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: * Sukadev Bhattiprolu suka...@linux.vnet.ibm.com wrote: This is another attempt to resurrect Andi Kleen's patchset so users

Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.)

2015-04-14 Thread Ingo Molnar
* Michael Ellerman m...@ellerman.id.au wrote: On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: * Sukadev Bhattiprolu suka...@linux.vnet.ibm.com wrote: This is another attempt to resurrect Andi Kleen's patchset so users can specify perf events by their event names rather than raw