Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-12 Thread Jan Kara
On Thu 08-05-14 15:34:07, Will Deacon wrote: > Hi Alan, > > On Wed, May 07, 2014 at 05:41:51PM +0100, One Thousand Gnomes wrote: > > > Possibly, but I fear we'd incur the wrath of Alan after reading that other > > > thread. Having a CONFIG_ option or similar to control the amount of > > >

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-12 Thread Jan Kara
On Thu 08-05-14 15:34:07, Will Deacon wrote: Hi Alan, On Wed, May 07, 2014 at 05:41:51PM +0100, One Thousand Gnomes wrote: Possibly, but I fear we'd incur the wrath of Alan after reading that other thread. Having a CONFIG_ option or similar to control the amount of printing we do

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-08 Thread Will Deacon
Hi Alan, On Wed, May 07, 2014 at 05:41:51PM +0100, One Thousand Gnomes wrote: > > Possibly, but I fear we'd incur the wrath of Alan after reading that other > > thread. Having a CONFIG_ option or similar to control the amount of printing > > we do is very similar to the command-line option Jan

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-08 Thread Will Deacon
Hi Alan, On Wed, May 07, 2014 at 05:41:51PM +0100, One Thousand Gnomes wrote: Possibly, but I fear we'd incur the wrath of Alan after reading that other thread. Having a CONFIG_ option or similar to control the amount of printing we do is very similar to the command-line option Jan proposed

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-07 Thread One Thousand Gnomes
> Possibly, but I fear we'd incur the wrath of Alan after reading that other > thread. Having a CONFIG_ option or similar to control the amount of printing > we do is very similar to the command-line option Jan proposed in his series. I've nothing against a configuration option, and having a

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-07 Thread Will Deacon
On Tue, May 06, 2014 at 11:05:53PM +0100, Andrew Morton wrote: > On Tue, 6 May 2014 14:12:34 +0100 Will Deacon wrote: > > > > > My opinion is that when you are printing from each and every interrupt > > > > > which happens so often, then you have a problem and disabling IRQs in > > > > > printk

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-07 Thread Will Deacon
On Tue, May 06, 2014 at 09:00:22PM +0100, Jan Kara wrote: > On Tue 06-05-14 16:00:37, Will Deacon wrote: > > On Tue, May 06, 2014 at 03:00:32PM +0100, Jan Kara wrote: > > > On Tue 06-05-14 14:12:34, Will Deacon wrote: > > > > Right, so there's the usual compromise here between throughput and > >

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-07 Thread Will Deacon
On Tue, May 06, 2014 at 09:00:22PM +0100, Jan Kara wrote: On Tue 06-05-14 16:00:37, Will Deacon wrote: On Tue, May 06, 2014 at 03:00:32PM +0100, Jan Kara wrote: On Tue 06-05-14 14:12:34, Will Deacon wrote: Right, so there's the usual compromise here between throughput and latency.

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-07 Thread Will Deacon
On Tue, May 06, 2014 at 11:05:53PM +0100, Andrew Morton wrote: On Tue, 6 May 2014 14:12:34 +0100 Will Deacon will.dea...@arm.com wrote: My opinion is that when you are printing from each and every interrupt which happens so often, then you have a problem and disabling IRQs in

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-07 Thread One Thousand Gnomes
Possibly, but I fear we'd incur the wrath of Alan after reading that other thread. Having a CONFIG_ option or similar to control the amount of printing we do is very similar to the command-line option Jan proposed in his series. I've nothing against a configuration option, and having a printk

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Andrew Morton
On Tue, 6 May 2014 14:12:34 +0100 Will Deacon wrote: > > > > My opinion is that when you are printing from each and every interrupt > > > > which happens so often, then you have a problem and disabling IRQs in > > > > printk so that your interrupt doesn't happen that often seems like a > > > >

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Jan Kara
On Tue 06-05-14 16:00:37, Will Deacon wrote: > On Tue, May 06, 2014 at 03:00:32PM +0100, Jan Kara wrote: > > On Tue 06-05-14 14:12:34, Will Deacon wrote: > > > On Tue, May 06, 2014 at 01:29:58PM +0100, Jan Kara wrote: > > > > Well, with serial console the backlog can get actually pretty big. >

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Will Deacon
On Tue, May 06, 2014 at 03:00:32PM +0100, Jan Kara wrote: > On Tue 06-05-14 14:12:34, Will Deacon wrote: > > On Tue, May 06, 2014 at 01:29:58PM +0100, Jan Kara wrote: > > > Well, with serial console the backlog can get actually pretty big. > > > During > > > boot on large machines I've seen

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Jan Kara
On Tue 06-05-14 14:12:34, Will Deacon wrote: > On Tue, May 06, 2014 at 01:29:58PM +0100, Jan Kara wrote: > > On Tue 06-05-14 13:06:48, Will Deacon wrote: > > > On Fri, May 02, 2014 at 11:46:51PM +0100, Jan Kara wrote: > > > > I really dislike this patch. It goes completely against my efforts of

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Peter Zijlstra
On Tue, May 06, 2014 at 02:12:34PM +0100, Will Deacon wrote: > That said, printing one message each time seems to go too far in the > opposite direction for my liking, so the best bet is likely to limit the > work to some fixed number of messages. Do you have any feeling for such a > limit? 42!

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Will Deacon
On Tue, May 06, 2014 at 01:29:58PM +0100, Jan Kara wrote: > On Tue 06-05-14 13:06:48, Will Deacon wrote: > > On Fri, May 02, 2014 at 11:46:51PM +0100, Jan Kara wrote: > > > I really dislike this patch. It goes completely against my efforts of > > > lowering irq latency caused by printing to

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Jan Kara
On Tue 06-05-14 13:06:48, Will Deacon wrote: > Hello, > > On Fri, May 02, 2014 at 11:46:51PM +0100, Jan Kara wrote: > > On Fri 02-05-14 14:22:20, Andrew Morton wrote: > > > From: Will Deacon > > > Subject: printk: print initial logbuf contents before re-enabling > > > interrupts > > > > > >

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Will Deacon
Hello, On Fri, May 02, 2014 at 11:46:51PM +0100, Jan Kara wrote: > On Fri 02-05-14 14:22:20, Andrew Morton wrote: > > From: Will Deacon > > Subject: printk: print initial logbuf contents before re-enabling interrupts > > > > When running on a hideously slow system (~10Mhz FPGA) with a bunch of

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Will Deacon
Hello, On Fri, May 02, 2014 at 11:46:51PM +0100, Jan Kara wrote: On Fri 02-05-14 14:22:20, Andrew Morton wrote: From: Will Deacon will.dea...@arm.com Subject: printk: print initial logbuf contents before re-enabling interrupts When running on a hideously slow system (~10Mhz FPGA) with a

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Jan Kara
On Tue 06-05-14 13:06:48, Will Deacon wrote: Hello, On Fri, May 02, 2014 at 11:46:51PM +0100, Jan Kara wrote: On Fri 02-05-14 14:22:20, Andrew Morton wrote: From: Will Deacon will.dea...@arm.com Subject: printk: print initial logbuf contents before re-enabling interrupts

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Will Deacon
On Tue, May 06, 2014 at 01:29:58PM +0100, Jan Kara wrote: On Tue 06-05-14 13:06:48, Will Deacon wrote: On Fri, May 02, 2014 at 11:46:51PM +0100, Jan Kara wrote: I really dislike this patch. It goes completely against my efforts of lowering irq latency caused by printing to console

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Peter Zijlstra
On Tue, May 06, 2014 at 02:12:34PM +0100, Will Deacon wrote: That said, printing one message each time seems to go too far in the opposite direction for my liking, so the best bet is likely to limit the work to some fixed number of messages. Do you have any feeling for such a limit? 42!

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Jan Kara
On Tue 06-05-14 14:12:34, Will Deacon wrote: On Tue, May 06, 2014 at 01:29:58PM +0100, Jan Kara wrote: On Tue 06-05-14 13:06:48, Will Deacon wrote: On Fri, May 02, 2014 at 11:46:51PM +0100, Jan Kara wrote: I really dislike this patch. It goes completely against my efforts of

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Will Deacon
On Tue, May 06, 2014 at 03:00:32PM +0100, Jan Kara wrote: On Tue 06-05-14 14:12:34, Will Deacon wrote: On Tue, May 06, 2014 at 01:29:58PM +0100, Jan Kara wrote: Well, with serial console the backlog can get actually pretty big. During boot on large machines I've seen CPUs stuck in

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Jan Kara
On Tue 06-05-14 16:00:37, Will Deacon wrote: On Tue, May 06, 2014 at 03:00:32PM +0100, Jan Kara wrote: On Tue 06-05-14 14:12:34, Will Deacon wrote: On Tue, May 06, 2014 at 01:29:58PM +0100, Jan Kara wrote: Well, with serial console the backlog can get actually pretty big. During

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-06 Thread Andrew Morton
On Tue, 6 May 2014 14:12:34 +0100 Will Deacon will.dea...@arm.com wrote: My opinion is that when you are printing from each and every interrupt which happens so often, then you have a problem and disabling IRQs in printk so that your interrupt doesn't happen that often seems like a

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-02 Thread Jan Kara
On Fri 02-05-14 14:22:20, Andrew Morton wrote: > From: Will Deacon > Subject: printk: print initial logbuf contents before re-enabling interrupts > > When running on a hideously slow system (~10Mhz FPGA) with a bunch of > debug printk invocations on the timer interrupt path, we end up filling >

Re: + printk-print-initial-logbuf-contents-before-re-enabling-interrupts.patch added to -mm tree

2014-05-02 Thread Jan Kara
On Fri 02-05-14 14:22:20, Andrew Morton wrote: From: Will Deacon will.dea...@arm.com Subject: printk: print initial logbuf contents before re-enabling interrupts When running on a hideously slow system (~10Mhz FPGA) with a bunch of debug printk invocations on the timer interrupt path, we end