Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Len Brown
On Monday 07 January 2008 16:33, Mark Lord wrote: > Len Brown wrote: > > 1. Why does VMware need max_cstate=1 to load quickly? > .. > > Eh? Nothing to do with "loading" anything, > but rather it's simple responsiveness to guest keyboard > input that we're experiencing trouble with. > The guest

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Mark Lord
Len Brown wrote: 1. Why does VMware need max_cstate=1 to load quickly? .. Eh? Nothing to do with "loading" anything, but rather it's simple responsiveness to guest keyboard input that we're experiencing trouble with. The guest OS is probably "broken" in that regard, but setting max_cstate=1

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Len Brown
1. Why does VMware need max_cstate=1 to load quickly? It should not, and the fact that it does means that something somewhere is seriously broken. 2. Why does the "max_csate=1" workaround help only on the dual-core boxes, while the single-core boxes still fail to load quickly? I'm

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Mark Lord
Arjan van de Ven wrote: .. if we take a step back; Mark afaics only wants to put 1 in there... And that makes sense; either you want the "no latency" C1, or you want the lot (esp given that C2 and deeper are at the whim of the bios, what they mean varies over time. Actually even C1 does that on

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Mark Lord
Andrew Morton wrote: .. umm, OK, I queued it for 2.6.24. I'll give people a day or so to comment on this. I had to invent some silly changlelog for it. Please review it for accuracy and completeness? .. From: Venki Pallipadi <[EMAIL PROTECTED]> This was writeable in 2.6.23 but the cpuidle

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Pallipadi, Venkatesh
IL PROTECTED]; [EMAIL PROTECTED] >Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch >added to -mm tree > >On Sun, 06 Jan 2008 16:34:16 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > >> Venki Pallipadi wrote: >> > Reintroduce run time configurable max_cstate for !

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Arjan van de Ven
On Sun, 6 Jan 2008 23:18:48 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Sun, 06 Jan 2008 16:34:16 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > > > Venki Pallipadi wrote: > > > Reintroduce run time configurable max_cstate for !CPU_IDLE case. > > > > > > Signed-off-by: Venkatesh Pallipadi

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Arjan van de Ven
On Sun, 6 Jan 2008 23:18:48 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Sun, 06 Jan 2008 16:34:16 -0500 Mark Lord [EMAIL PROTECTED] wrote: Venki Pallipadi wrote: Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi [EMAIL

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Mark Lord
Andrew Morton wrote: .. umm, OK, I queued it for 2.6.24. I'll give people a day or so to comment on this. I had to invent some silly changlelog for it. Please review it for accuracy and completeness? .. From: Venki Pallipadi [EMAIL PROTECTED] This was writeable in 2.6.23 but the cpuidle

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Mark Lord
Arjan van de Ven wrote: .. if we take a step back; Mark afaics only wants to put 1 in there... And that makes sense; either you want the no latency C1, or you want the lot (esp given that C2 and deeper are at the whim of the bios, what they mean varies over time. Actually even C1 does that on

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Len Brown
1. Why does VMware need max_cstate=1 to load quickly? It should not, and the fact that it does means that something somewhere is seriously broken. 2. Why does the max_csate=1 workaround help only on the dual-core boxes, while the single-core boxes still fail to load quickly? I'm glad

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Mark Lord
Len Brown wrote: 1. Why does VMware need max_cstate=1 to load quickly? .. Eh? Nothing to do with loading anything, but rather it's simple responsiveness to guest keyboard input that we're experiencing trouble with. The guest OS is probably broken in that regard, but setting max_cstate=1 makes

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-07 Thread Len Brown
On Monday 07 January 2008 16:33, Mark Lord wrote: Len Brown wrote: 1. Why does VMware need max_cstate=1 to load quickly? .. Eh? Nothing to do with loading anything, but rather it's simple responsiveness to guest keyboard input that we're experiencing trouble with. The guest OS is

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-06 Thread Andrew Morton
On Sun, 06 Jan 2008 16:34:16 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > Venki Pallipadi wrote: > > Reintroduce run time configurable max_cstate for !CPU_IDLE case. > > > > Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]> > > > > Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c > >

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-06 Thread Mark Lord
Venki Pallipadi wrote: Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]> Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c === ---

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-06 Thread Andrew Morton
On Sun, 06 Jan 2008 16:34:16 -0500 Mark Lord [EMAIL PROTECTED] wrote: Venki Pallipadi wrote: Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-06 Thread Mark Lord
Venki Pallipadi wrote: Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c === ---

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-05 Thread Mark Lord
Pallipadi, Venkatesh wrote: -Original Message- From: Mark Lord [mailto:[EMAIL PROTECTED] .. Okay, with !CONFIG_CPU_IDLE, this works fine -- same as 2.6.23 and earlier. Good to know. Atleast we do not have a regression for 2.6.24 now. .. Agreed. We're happy here, for now.

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-05 Thread Mark Lord
Pallipadi, Venkatesh wrote: -Original Message- From: Mark Lord [mailto:[EMAIL PROTECTED] .. Okay, with !CONFIG_CPU_IDLE, this works fine -- same as 2.6.23 and earlier. Good to know. Atleast we do not have a regression for 2.6.24 now. .. Agreed. We're happy here, for now.

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-04 Thread Pallipadi, Venkatesh
ED]; [EMAIL PROTECTED] >Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch >added to -mm tree > >Mark Lord wrote: >> Venki Pallipadi wrote: >>> Reintroduce run time configurable max_cstate for !CPU_IDLE case. >>> >>> Signed-off-by: Venkatesh Pa

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-04 Thread Mark Lord
Mark Lord wrote: Venki Pallipadi wrote: Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]> Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c === ---

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-04 Thread Mark Lord
Mark Lord wrote: Venki Pallipadi wrote: Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c === ---

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-04 Thread Pallipadi, Venkatesh
] Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree Mark Lord wrote: Venki Pallipadi wrote: Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-03 Thread Mark Lord
Venki Pallipadi wrote: Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]> Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c === ---

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-03 Thread Venki Pallipadi
Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi <[EMAIL PROTECTED]> Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c === --- linux-2.6.24-rc.orig/drivers/acpi/processor_idle.c

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-03 Thread Venki Pallipadi
Reintroduce run time configurable max_cstate for !CPU_IDLE case. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index: linux-2.6.24-rc/drivers/acpi/processor_idle.c === --- linux-2.6.24-rc.orig/drivers/acpi/processor_idle.c

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
PROTECTED] Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree On Wed, 2 Jan 2008 16:06:20 -0800 "Pallipadi, Venkatesh" <[EMAIL PROTECTED]> wrote: -Original Message- From: Mark Lord [mailto:[EMAIL PROTECTED] Sent: Wednesday, January

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
PROTECTED] Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord <[EMAIL PROTECTED]> wro

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Pallipadi, Venkatesh
OTECTED] >Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch >added to -mm tree > >On Wed, 2 Jan 2008 16:06:20 -0800 "Pallipadi, Venkatesh" ><[EMAIL PROTECTED]> wrote: > >> >> >> >-Original Message- >> >Fro

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Andrew Morton
allipadi, Venkatesh; Andrew Morton; [EMAIL PROTECTED]; > >[EMAIL PROTECTED]; Ingo Molnar; linux-kernel@vger.kernel.org; > >[EMAIL PROTECTED] > >Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch > >added to -mm tree > > > >Arjan van de Ven

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Pallipadi, Venkatesh
OTECTED] >Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch >added to -mm tree > >Arjan van de Ven wrote: >> On Fri, 30 Nov 2007 22:31:17 -0500 >> Mark Lord <[EMAIL PROTECTED]> wrote: >> >>> Arjan van de Ven wrote: >>>&g

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: in -mm there is.. the QoS stuff allows you to set maximum tolerable .. That's encouraging, I

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord [EMAIL PROTECTED] wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord [EMAIL PROTECTED] wrote: in -mm there is.. the QoS stuff allows you to set maximum tolerable .. That's encouraging, I think,

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Pallipadi, Venkatesh
: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord [EMAIL PROTECTED] wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord [EMAIL PROTECTED] wrote: in -mm there is.. the QoS stuff allows you

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Andrew Morton
PROTECTED]; Ingo Molnar; linux-kernel@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord [EMAIL PROTECTED] wrote: Arjan van de Ven wrote: On Fri, 30 Nov

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Pallipadi, Venkatesh
: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree On Wed, 2 Jan 2008 16:06:20 -0800 Pallipadi, Venkatesh [EMAIL PROTECTED] wrote: -Original Message- From: Mark Lord [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 02, 2008 3:42 PM To: Arjan van de Ven Cc: Pallipadi

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
PROTECTED] Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord [EMAIL PROTECTED] wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord [EMAIL PROTECTED] wrote: in -mm

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2008-01-02 Thread Mark Lord
PROTECTED] Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree On Wed, 2 Jan 2008 16:06:20 -0800 Pallipadi, Venkatesh [EMAIL PROTECTED] wrote: -Original Message- From: Mark Lord [mailto:[EMAIL PROTECTED] Sent: Wednesday, January 02, 2008 3:42 PM To: Arjan

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-12-07 Thread Pallipadi, Venkatesh
ernel@vger.kernel.org; [EMAIL PROTECTED] >Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch >added to -mm tree > >Hi! > >> >It is not known whether Mark is actually writing to this >> >thing. Perhaps >> >read-only permissions would be a suitable f

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-12-07 Thread Pavel Machek
Hi! > >It is not known whether Mark is actually writing to this > >thing. Perhaps > >read-only permissions would be a suitable fix? > > > > Exporting it as read only should be OK. We also need to know if there > are hard user space dependency on writing to this from userspace. Some people are

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-12-07 Thread Pavel Machek
Hi! It is not known whether Mark is actually writing to this thing. Perhaps read-only permissions would be a suitable fix? Exporting it as read only should be OK. We also need to know if there are hard user space dependency on writing to this from userspace. Some people are

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-12-07 Thread Pallipadi, Venkatesh
PROTECTED] Subject: Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree Hi! It is not known whether Mark is actually writing to this thing. Perhaps read-only permissions would be a suitable fix? Exporting it as read only should be OK. We also need to know

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-12-01 Thread Arjan van de Ven
On Sat, 1 Dec 2007 02:17:40 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > > > > latency. If your app cant take any latency, you should set > > > those... and the side effect is that the kernel will not do > > >

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-12-01 Thread Andrew Morton
On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > > latency. If your app cant take any latency, you should set those... and > > the side effect is that the kernel will not do long-latency C-states or > > P-state transitions.. > .. > > I don't mind the cpufreq changing

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-12-01 Thread Andrew Morton
On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord [EMAIL PROTECTED] wrote: latency. If your app cant take any latency, you should set those... and the side effect is that the kernel will not do long-latency C-states or P-state transitions.. .. I don't mind the cpufreq changing (actually, I

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-12-01 Thread Arjan van de Ven
On Sat, 1 Dec 2007 02:17:40 -0800 Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord [EMAIL PROTECTED] wrote: latency. If your app cant take any latency, you should set those... and the side effect is that the kernel will not do long-latency C-states

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Mark Lord wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:44:25 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: all you need to do in your kernel module is call ... set_acceptable_latency("mark", 5); and to remove the constraint again you just do remove_acceptable_latency("mark"); ..

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:44:25 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: all you need to do in your kernel module is call add_latency_constraint("mark_wants_his_mouse", 5); Okay, and how to change it back again? (thanks) sorry I misremember it's called

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Mark Lord wrote: .. And I just figured out the powertop: it needed the kernel timers patch from the powertop site that was originally for 2.6.21.. Any chance of somebody actually pushing that patch upstream some year ?? Patch reproduced here for interest's sake only. Hey, look who's on the

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: in -mm there is.. the QoS stuff allows you to set maximum tolerable .. That's encouraging, I

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: in -mm there is.. the QoS stuff allows you to set maximum tolerable .. That's encouraging, I think, but not for 2.6.24. latency. If your app cant take any latency, you should set those... and

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Arjan van de Ven
On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > > in -mm there is.. the QoS stuff allows you to set maximum tolerable > .. > > That's encouraging, I think, but not for 2.6.24. > > > latency. If your app cant take any latency, you should set those... > > and the side

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 21:52:40 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: Pallipadi, Venkatesh wrote: Exporting it as read only should be OK. We also need to know if there are hard user space dependency on writing to this from userspace. .. Well, actually.. my

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Arjan van de Ven
On Fri, 30 Nov 2007 21:52:40 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > Pallipadi, Venkatesh wrote: > > > > Exporting it as read only should be OK. We also need to know if > > there are hard user space dependency on writing to this from > > userspace. > .. > > Well, actually.. my scripts

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Pallipadi, Venkatesh wrote: On Fri, 30 Nov 2007 14:06:55 -0800 "Pallipadi, Venkatesh" <[EMAIL PROTECTED]> wrote: Please dont go off-list like this. I put Mark's original mailing list cc's back. Sorry for missing some cc's earlier. I blindly did a reply-all to the mm-commits mail I got.

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Pallipadi, Venkatesh
>On Fri, 30 Nov 2007 14:06:55 -0800 >"Pallipadi, Venkatesh" <[EMAIL PROTECTED]> wrote: > >Please dont go off-list like this. I put Mark's original >mailing list cc's >back. Sorry for missing some cc's earlier. I blindly did a reply-all to the mm-commits mail I got. >> I will have to Nack

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Andrew Morton
On Fri, 30 Nov 2007 14:06:55 -0800 "Pallipadi, Venkatesh" <[EMAIL PROTECTED]> wrote: Please dont go off-list like this. I put Mark's original mailing list cc's back. > > I will have to Nack this. The reason max_cstate was initentionally > removed due to couple of reasons: It broke userspace

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord [EMAIL PROTECTED] wrote: in -mm there is.. the QoS stuff allows you to set maximum tolerable .. That's encouraging, I think, but not for 2.6.24. latency. If your app cant take any latency, you should set those... and the

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:44:25 -0500 Mark Lord [EMAIL PROTECTED] wrote: all you need to do in your kernel module is call add_latency_constraint(mark_wants_his_mouse, 5); Okay, and how to change it back again? (thanks) sorry I misremember it's called

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Mark Lord wrote: .. And I just figured out the powertop: it needed the kernel timers patch from the powertop site that was originally for 2.6.21.. Any chance of somebody actually pushing that patch upstream some year ?? Patch reproduced here for interest's sake only. Hey, look who's on the

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:31:17 -0500 Mark Lord [EMAIL PROTECTED] wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord [EMAIL PROTECTED] wrote: in -mm there is.. the QoS stuff allows you to set maximum tolerable .. That's encouraging, I think,

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Arjan van de Ven wrote: On Fri, 30 Nov 2007 21:52:40 -0500 Mark Lord [EMAIL PROTECTED] wrote: Pallipadi, Venkatesh wrote: Exporting it as read only should be OK. We also need to know if there are hard user space dependency on writing to this from userspace. .. Well, actually.. my scripts

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Pallipadi, Venkatesh wrote: On Fri, 30 Nov 2007 14:06:55 -0800 Pallipadi, Venkatesh [EMAIL PROTECTED] wrote: Please dont go off-list like this. I put Mark's original mailing list cc's back. Sorry for missing some cc's earlier. I blindly did a reply-all to the mm-commits mail I got. I

RE: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Pallipadi, Venkatesh
On Fri, 30 Nov 2007 14:06:55 -0800 Pallipadi, Venkatesh [EMAIL PROTECTED] wrote: Please dont go off-list like this. I put Mark's original mailing list cc's back. Sorry for missing some cc's earlier. I blindly did a reply-all to the mm-commits mail I got. I will have to Nack this. The

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Arjan van de Ven
On Fri, 30 Nov 2007 22:14:08 -0500 Mark Lord [EMAIL PROTECTED] wrote: in -mm there is.. the QoS stuff allows you to set maximum tolerable .. That's encouraging, I think, but not for 2.6.24. latency. If your app cant take any latency, you should set those... and the side effect is that

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Arjan van de Ven
On Fri, 30 Nov 2007 21:52:40 -0500 Mark Lord [EMAIL PROTECTED] wrote: Pallipadi, Venkatesh wrote: Exporting it as read only should be OK. We also need to know if there are hard user space dependency on writing to this from userspace. .. Well, actually.. my scripts have a firm need

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Andrew Morton
On Fri, 30 Nov 2007 14:06:55 -0800 Pallipadi, Venkatesh [EMAIL PROTECTED] wrote: Please dont go off-list like this. I put Mark's original mailing list cc's back. I will have to Nack this. The reason max_cstate was initentionally removed due to couple of reasons: It broke userspace without

Re: + restore-missing-sysfs-max_cstate-attr.patch added to -mm tree

2007-11-30 Thread Mark Lord
Mark Lord wrote: Arjan van de Ven wrote: On Fri, 30 Nov 2007 22:44:25 -0500 Mark Lord [EMAIL PROTECTED] wrote: all you need to do in your kernel module is call ... set_acceptable_latency(mark, 5); and to remove the constraint again you just do remove_acceptable_latency(mark); .. Then why