Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-28 Thread Heiko Carstens
On Sat, Apr 27, 2019 at 06:42:51AM -0400, Prarit Bhargava wrote: > On 4/27/19 6:24 AM, Heiko Carstens wrote: > > > > > diff --git a/kernel/module.c b/kernel/module.c > > index 410eeb7e4f1d..48748cfec991 100644 > > --- a/kernel/module.c > > +++ b/kernel/module.c > > @@ -3585,6 +3585,7 @@ again: >

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-27 Thread Prarit Bhargava
On 4/27/19 6:24 AM, Heiko Carstens wrote: > > diff --git a/kernel/module.c b/kernel/module.c > index 410eeb7e4f1d..48748cfec991 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -3585,6 +3585,7 @@ again: > finished_loading(mod->name)); >

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-27 Thread Prarit Bhargava
On 4/27/19 6:24 AM, Heiko Carstens wrote: > On Fri, Apr 26, 2019 at 08:20:52PM -0400, Prarit Bhargava wrote: >> Heiko and Jessica, >> >> The issue doesn't appear to be with my patch AFAICT. The s390_trng fails to >> load and then the kernel occasionally hangs (as Heiko mentioned) calling >> syn

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-27 Thread Heiko Carstens
On Fri, Apr 26, 2019 at 08:20:52PM -0400, Prarit Bhargava wrote: > Heiko and Jessica, > > The issue doesn't appear to be with my patch AFAICT. The s390_trng fails to > load and then the kernel occasionally hangs (as Heiko mentioned) calling > synchronize_rcu(). > > The call sequence is > > modu

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-26 Thread Prarit Bhargava
On 4/26/19 3:45 PM, Prarit Bhargava wrote: > > > On 4/26/19 2:10 PM, Prarit Bhargava wrote: >> >> >> On 4/26/19 12:09 PM, Jessica Yu wrote: >>> +++ Heiko Carstens [26/04/19 17:07 +0200]: On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote: > On 4/26/19 9:07 AM, Heiko Carst

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-26 Thread Prarit Bhargava
On 4/26/19 2:10 PM, Prarit Bhargava wrote: > > > On 4/26/19 12:09 PM, Jessica Yu wrote: >> +++ Heiko Carstens [26/04/19 17:07 +0200]: >>> On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote: On 4/26/19 9:07 AM, Heiko Carstens wrote: > Hello Prarit, > > it looks lik

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-26 Thread Prarit Bhargava
On 4/26/19 12:09 PM, Jessica Yu wrote: > +++ Heiko Carstens [26/04/19 17:07 +0200]: >> On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote: >>> On 4/26/19 9:07 AM, Heiko Carstens wrote: >>> > Hello Prarit, >>> > >>> > it looks like your commit f9a75c1d717f ("modules: Only return -EEX

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-26 Thread Prarit Bhargava
On 4/26/19 12:09 PM, Jessica Yu wrote: > +++ Heiko Carstens [26/04/19 17:07 +0200]: >> On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote: >>> On 4/26/19 9:07 AM, Heiko Carstens wrote: >>> > Hello Prarit, >>> > >>> > it looks like your commit f9a75c1d717f ("modules: Only return -EEX

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-26 Thread Jessica Yu
+++ Heiko Carstens [26/04/19 17:07 +0200]: On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote: On 4/26/19 9:07 AM, Heiko Carstens wrote: > Hello Prarit, > > it looks like your commit f9a75c1d717f ("modules: Only return -EEXIST > for modules that have finished loading") _sometimes_ c

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-26 Thread Heiko Carstens
On Fri, Apr 26, 2019 at 09:22:34AM -0400, Prarit Bhargava wrote: > On 4/26/19 9:07 AM, Heiko Carstens wrote: > > Hello Prarit, > > > > it looks like your commit f9a75c1d717f ("modules: Only return -EEXIST > > for modules that have finished loading") _sometimes_ causes hangs on > > s390. This is un

Re: [-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-26 Thread Prarit Bhargava
On 4/26/19 9:07 AM, Heiko Carstens wrote: > Hello Prarit, > > it looks like your commit f9a75c1d717f ("modules: Only return -EEXIST > for modules that have finished loading") _sometimes_ causes hangs on > s390. This is unfortunately not 100% reproducible, however the > mentioned commit seems to

[-next] system hangs likely due to "modules: Only return -EEXIST for modules that have finished loading"

2019-04-26 Thread Heiko Carstens
Hello Prarit, it looks like your commit f9a75c1d717f ("modules: Only return -EEXIST for modules that have finished loading") _sometimes_ causes hangs on s390. This is unfortunately not 100% reproducible, however the mentioned commit seems to be the only relevant one in modules.c. What I see is a