Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-12 Thread Ben Hutchings
On Mon, 2013-01-07 at 20:20 +0100, Stanislaw Gruszka wrote: > On Mon, Jan 07, 2013 at 07:38:35PM +0100, Andreas Hartmann wrote: > > Stanislaw Gruszka wrote: > > > On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: > > >> Ben Hutchings wrote: > > >>> On Mon, 2013-01-07 at 09:10

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-12 Thread Ben Hutchings
On Mon, 2013-01-07 at 20:20 +0100, Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 07:38:35PM +0100, Andreas Hartmann wrote: Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: Ben Hutchings wrote: On Mon, 2013-01-07 at 09:10 +0100, Stanislaw

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Andreas Hartmann
Hello Stanislaw! Stanislaw Gruszka wrote: > On Mon, Jan 07, 2013 at 07:38:35PM +0100, Andreas Hartmann wrote: >> Stanislaw Gruszka wrote: >>> On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: Ben Hutchings wrote: > On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Mon, Jan 07, 2013 at 07:38:35PM +0100, Andreas Hartmann wrote: > Stanislaw Gruszka wrote: > > On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: > >> Ben Hutchings wrote: > >>> On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: > On Mon, Jan 07, 2013 at 09:05:32AM

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Andreas Hartmann
Hello Helmut! Helmut Schaa wrote: > On Mon, Jan 7, 2013 at 4:04 PM, Andreas Hartmann > wrote: >> The solution would be IMHO, to implement an own aggregation handling, >> maybe the same way as it was done for carl9170, which had the same problem: >> >>

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Andreas Hartmann
Stanislaw Gruszka wrote: > On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: >> Ben Hutchings wrote: >>> On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: >> To be clear, I have all of these in

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: > Ben Hutchings wrote: > > On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: > >> On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: > To be clear, I have all of these in the queue: > >

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Helmut Schaa
On Mon, Jan 7, 2013 at 4:04 PM, Andreas Hartmann wrote: > The solution would be IMHO, to implement an own aggregation handling, > maybe the same way as it was done for carl9170, which had the same problem: > > http://thread.gmane.org/gmane.linux.kernel.wireless.general/100793/focus=1405 > > I

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Andreas Hartmann
Ben Hutchings wrote: > On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: >> On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: To be clear, I have all of these in the queue: be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Ben Hutchings
On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: > On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: > > > To be clear, I have all of these in the queue: > > > > > > be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe > > > fails > > >

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: > > To be clear, I have all of these in the queue: > > > > be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe > > fails > > 5b632fe85ec8 mac80211: introduce IEEE80211_HW_TEARDOWN_AGGR_ON_BAR_FAIL > >

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Mon, Jan 07, 2013 at 12:18:21AM -0800, Jonathan Nieder wrote: > Stanislaw Gruszka wrote: > > On Sun, Dec 30, 2012 at 01:42:37PM +0100, Ben Hutchings wrote: > > >> To be clear, I have all of these in the queue: > >> > >> be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Jonathan Nieder
Stanislaw Gruszka wrote: > On Sun, Dec 30, 2012 at 01:42:37PM +0100, Ben Hutchings wrote: >> To be clear, I have all of these in the queue: >> >> be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe >> fails >> 5b632fe85ec8 mac80211: introduce

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Sun, Dec 30, 2012 at 01:42:37PM +0100, Ben Hutchings wrote: > On Sun, 2012-12-30 at 13:38 +0100, Ben Hutchings wrote: > > On Sat, 2012-12-29 at 09:04 +0100, Andreas Hartmann wrote: > > > Ben Hutchings wrote: > > > > 3.2-stable review patch. If anyone has any objections, please let me > > > >

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Sun, Dec 30, 2012 at 01:42:37PM +0100, Ben Hutchings wrote: On Sun, 2012-12-30 at 13:38 +0100, Ben Hutchings wrote: On Sat, 2012-12-29 at 09:04 +0100, Andreas Hartmann wrote: Ben Hutchings wrote: 3.2-stable review patch. If anyone has any objections, please let me know.

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Jonathan Nieder
Stanislaw Gruszka wrote: On Sun, Dec 30, 2012 at 01:42:37PM +0100, Ben Hutchings wrote: To be clear, I have all of these in the queue: be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails 5b632fe85ec8 mac80211: introduce IEEE80211_HW_TEARDOWN_AGGR_ON_BAR_FAIL

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Mon, Jan 07, 2013 at 12:18:21AM -0800, Jonathan Nieder wrote: Stanislaw Gruszka wrote: On Sun, Dec 30, 2012 at 01:42:37PM +0100, Ben Hutchings wrote: To be clear, I have all of these in the queue: be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: To be clear, I have all of these in the queue: be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails 5b632fe85ec8 mac80211: introduce IEEE80211_HW_TEARDOWN_AGGR_ON_BAR_FAIL ab9d6e4ffe19

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Ben Hutchings
On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: To be clear, I have all of these in the queue: be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails 5b632fe85ec8 mac80211:

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Andreas Hartmann
Ben Hutchings wrote: On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: To be clear, I have all of these in the queue: be03d4a45c09 rt2x00: Don't let mac80211 send a BAR when an AMPDU subframe fails 5b632fe85ec8

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Helmut Schaa
On Mon, Jan 7, 2013 at 4:04 PM, Andreas Hartmann andihartm...@01019freenet.de wrote: The solution would be IMHO, to implement an own aggregation handling, maybe the same way as it was done for carl9170, which had the same problem:

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: Ben Hutchings wrote: On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: To be clear, I have all of these in the queue: be03d4a45c09 rt2x00: Don't

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Andreas Hartmann
Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: Ben Hutchings wrote: On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw Gruszka wrote: To be clear, I have all of these in the queue:

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Andreas Hartmann
Hello Helmut! Helmut Schaa wrote: On Mon, Jan 7, 2013 at 4:04 PM, Andreas Hartmann andihartm...@01019freenet.de wrote: The solution would be IMHO, to implement an own aggregation handling, maybe the same way as it was done for carl9170, which had the same problem:

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Stanislaw Gruszka
On Mon, Jan 07, 2013 at 07:38:35PM +0100, Andreas Hartmann wrote: Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: Ben Hutchings wrote: On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 09:05:32AM +0100, Stanislaw

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2013-01-07 Thread Andreas Hartmann
Hello Stanislaw! Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 07:38:35PM +0100, Andreas Hartmann wrote: Stanislaw Gruszka wrote: On Mon, Jan 07, 2013 at 04:04:01PM +0100, Andreas Hartmann wrote: Ben Hutchings wrote: On Mon, 2013-01-07 at 09:10 +0100, Stanislaw Gruszka wrote: On Mon, Jan

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2012-12-30 Thread Ben Hutchings
On Sun, 2012-12-30 at 13:38 +0100, Ben Hutchings wrote: > On Sat, 2012-12-29 at 09:04 +0100, Andreas Hartmann wrote: > > Ben Hutchings wrote: > > > 3.2-stable review patch. If anyone has any objections, please let me > > > know. > > > > > > -- > > > > > > From: Andreas Hartmann

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2012-12-30 Thread Ben Hutchings
On Sat, 2012-12-29 at 09:04 +0100, Andreas Hartmann wrote: > Ben Hutchings wrote: > > 3.2-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Andreas Hartmann > > > > commit be03d4a45c09ee5100d3aaaedd087f19bc20d01f upstream. > >

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2012-12-30 Thread Ben Hutchings
On Sat, 2012-12-29 at 09:04 +0100, Andreas Hartmann wrote: Ben Hutchings wrote: 3.2-stable review patch. If anyone has any objections, please let me know. -- From: Andreas Hartmann andihartm...@01019freenet.de commit be03d4a45c09ee5100d3aaaedd087f19bc20d01f

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2012-12-30 Thread Ben Hutchings
On Sun, 2012-12-30 at 13:38 +0100, Ben Hutchings wrote: On Sat, 2012-12-29 at 09:04 +0100, Andreas Hartmann wrote: Ben Hutchings wrote: 3.2-stable review patch. If anyone has any objections, please let me know. -- From: Andreas Hartmann

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2012-12-29 Thread Andreas Hartmann
Ben Hutchings wrote: > 3.2-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Andreas Hartmann > > commit be03d4a45c09ee5100d3aaaedd087f19bc20d01f upstream. [...] This patch is a workaround for mac80211: retry sending failed BAR frames

Re: [ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2012-12-29 Thread Andreas Hartmann
Ben Hutchings wrote: 3.2-stable review patch. If anyone has any objections, please let me know. -- From: Andreas Hartmann andihartm...@01019freenet.de commit be03d4a45c09ee5100d3aaaedd087f19bc20d01f upstream. [...] This patch is a workaround for mac80211: retry

[ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2012-12-28 Thread Ben Hutchings
3.2-stable review patch. If anyone has any objections, please let me know. -- From: Andreas Hartmann commit be03d4a45c09ee5100d3aaaedd087f19bc20d01f upstream. There are connection stalls or very poor throughputs with rt2800 hardware using 802.11n in AP mode since patch

[ 104/173] rt2x00: Dont let mac80211 send a BAR when an AMPDU subframe fails

2012-12-28 Thread Ben Hutchings
3.2-stable review patch. If anyone has any objections, please let me know. -- From: Andreas Hartmann andihartm...@01019freenet.de commit be03d4a45c09ee5100d3aaaedd087f19bc20d01f upstream. There are connection stalls or very poor throughputs with rt2800 hardware using 802.11n