Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-07 Thread Ben Hutchings
On Fri, 2013-04-05 at 00:47 -0400, David Miller wrote: > From: Sven Joachim > Date: Wed, 03 Apr 2013 13:41:32 +0200 > > > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > > > >> 3.8-stable review patch. If anyone has any objections, please let me know. > > > > I'm seeing several

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-07 Thread Ben Hutchings
On Fri, 2013-04-05 at 00:47 -0400, David Miller wrote: From: Sven Joachim svenj...@gmx.de Date: Wed, 03 Apr 2013 13:41:32 +0200 On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-05 Thread Greg KH
On Fri, Apr 05, 2013 at 12:47:15AM -0400, David Miller wrote: > From: Sven Joachim > Date: Wed, 03 Apr 2013 13:41:32 +0200 > > > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > > > >> 3.8-stable review patch. If anyone has any objections, please let me know. > > > > I'm seeing several

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-05 Thread Greg KH
On Fri, Apr 05, 2013 at 12:47:15AM -0400, David Miller wrote: From: Sven Joachim svenj...@gmx.de Date: Wed, 03 Apr 2013 13:41:32 +0200 On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-04 Thread David Miller
From: Sven Joachim Date: Wed, 03 Apr 2013 13:41:32 +0200 > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > >> 3.8-stable review patch. If anyone has any objections, please let me know. > > I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and > 3.9-rc5: "udevd[56]:

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-04 Thread David Miller
From: Sven Joachim svenj...@gmx.de Date: Wed, 03 Apr 2013 13:41:32 +0200 On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and 3.9-rc5:

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Andy Lutomirski writes: > On Wed, Apr 3, 2013 at 5:47 PM, Eric W. Biederman > wrote: >> >> No. The patch is still bogus. >> >> If the problem is that we are not coallescing messages in stream_recvmsg >> we need a different fix. >> >> Probably something like: >> >> if

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Eric Dumazet writes: > On Wed, 2013-04-03 at 17:19 -0700, Eric Dumazet wrote: > >> Well, yes, this commit fixes a real bug : We were coalescing two >> messages into a single one, even if the senders were different. > > By the way, the 'LSB' test program can be found here : > >

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Andy Lutomirski
On Wed, Apr 3, 2013 at 5:47 PM, Eric W. Biederman wrote: > Eric Dumazet writes: > >> On Wed, 2013-04-03 at 17:05 -0700, Eric W. Biederman wrote: >>> Sven Joachim writes: >>> >>> > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: >>> > >>> >> 3.8-stable review patch. If anyone has any

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Eric Dumazet writes: > On Wed, 2013-04-03 at 17:05 -0700, Eric W. Biederman wrote: >> Sven Joachim writes: >> >> > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: >> > >> >> 3.8-stable review patch. If anyone has any objections, please let me >> >> know. >> > >> > I'm seeing several

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 17:19 -0700, Eric Dumazet wrote: > Well, yes, this commit fixes a real bug : We were coalescing two > messages into a single one, even if the senders were different. By the way, the 'LSB' test program can be found here :

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 17:05 -0700, Eric W. Biederman wrote: > Sven Joachim writes: > > > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > > > >> 3.8-stable review patch. If anyone has any objections, please let me know. > > > > I'm seeing several complaints from udevd at boot in both

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Andy Lutomirski writes: > On Wed, Apr 3, 2013 at 11:43 AM, Eric Dumazet wrote: >> On Wed, 2013-04-03 at 10:58 -0700, Andy Lutomirski wrote: >> >>> >>> This sounds suspiciously like an SCM_CREDENTIALS bug triggered by a >>> race. There's a fix (that needs both a new version from me and a review

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Sven Joachim writes: > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > >> 3.8-stable review patch. If anyone has any objections, please let me know. > > I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and > 3.9-rc5: "udevd[56]: sender uid=65534, message ignored".

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Stefan Lippers-Hollmann
Hi On Wednesday 03 April 2013, Greg Kroah-Hartman wrote: > On Wed, Apr 03, 2013 at 05:10:40PM +0200, Sven Joachim wrote: > > On 2013-04-03 16:00 +0200, Eric Dumazet wrote: > > > On Wed, 2013-04-03 at 13:41 +0200, Sven Joachim wrote: > > >> On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > >

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Andy Lutomirski
On Wed, Apr 3, 2013 at 11:43 AM, Eric Dumazet wrote: > On Wed, 2013-04-03 at 10:58 -0700, Andy Lutomirski wrote: > >> >> This sounds suspiciously like an SCM_CREDENTIALS bug triggered by a >> race. There's a fix (that needs both a new version from me and a review >> by someone) here: >> >>

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 10:58 -0700, Andy Lutomirski wrote: > > This sounds suspiciously like an SCM_CREDENTIALS bug triggered by a > race. There's a fix (that needs both a new version from me and a review > by someone) here: > > http://www.spinics.net/lists/netdev/msg229948.html Hmm... this is

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Andy Lutomirski
On 04/03/2013 08:35 AM, Eric Dumazet wrote: > On Wed, 2013-04-03 at 17:10 +0200, Sven Joachim wrote: >> On 2013-04-03 16:00 +0200, Eric Dumazet wrote: > >> >>> It might be a wrong sender (application bug or bad identity), and udevd >>> correctly discards the incoming message. >> >> How would I

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 17:10 +0200, Sven Joachim wrote: > On 2013-04-03 16:00 +0200, Eric Dumazet wrote: > > > It might be a wrong sender (application bug or bad identity), and udevd > > correctly discards the incoming message. > > How would I find out the culprit? Change udevd to display the

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Greg Kroah-Hartman
On Wed, Apr 03, 2013 at 05:10:40PM +0200, Sven Joachim wrote: > On 2013-04-03 16:00 +0200, Eric Dumazet wrote: > > > On Wed, 2013-04-03 at 13:41 +0200, Sven Joachim wrote: > >> On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > >> > >> > 3.8-stable review patch. If anyone has any

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Sven Joachim
On 2013-04-03 16:00 +0200, Eric Dumazet wrote: > On Wed, 2013-04-03 at 13:41 +0200, Sven Joachim wrote: >> On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: >> >> > 3.8-stable review patch. If anyone has any objections, please let me know. >> >> I'm seeing several complaints from udevd at

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 13:41 +0200, Sven Joachim wrote: > On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > > > 3.8-stable review patch. If anyone has any objections, please let me know. > > I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and > 3.9-rc5: "udevd[56]: sender

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Sven Joachim
On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: > 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and 3.9-rc5: "udevd[56]: sender uid=65534, message ignored". Reverting the patch below on top of

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Andy Lutomirski l...@amacapital.net writes: On Wed, Apr 3, 2013 at 5:47 PM, Eric W. Biederman ebied...@xmission.com wrote: No. The patch is still bogus. If the problem is that we are not coallescing messages in stream_recvmsg we need a different fix. Probably something like:

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Sven Joachim
On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and 3.9-rc5: udevd[56]: sender uid=65534, message ignored. Reverting the patch below on top of

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 13:41 +0200, Sven Joachim wrote: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and 3.9-rc5: udevd[56]: sender

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Sven Joachim
On 2013-04-03 16:00 +0200, Eric Dumazet wrote: On Wed, 2013-04-03 at 13:41 +0200, Sven Joachim wrote: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several complaints from udevd at boot in both

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Greg Kroah-Hartman
On Wed, Apr 03, 2013 at 05:10:40PM +0200, Sven Joachim wrote: On 2013-04-03 16:00 +0200, Eric Dumazet wrote: On Wed, 2013-04-03 at 13:41 +0200, Sven Joachim wrote: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 17:10 +0200, Sven Joachim wrote: On 2013-04-03 16:00 +0200, Eric Dumazet wrote: It might be a wrong sender (application bug or bad identity), and udevd correctly discards the incoming message. How would I find out the culprit? Change udevd to display the pid as

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Andy Lutomirski
On 04/03/2013 08:35 AM, Eric Dumazet wrote: On Wed, 2013-04-03 at 17:10 +0200, Sven Joachim wrote: On 2013-04-03 16:00 +0200, Eric Dumazet wrote: It might be a wrong sender (application bug or bad identity), and udevd correctly discards the incoming message. How would I find out the

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 10:58 -0700, Andy Lutomirski wrote: This sounds suspiciously like an SCM_CREDENTIALS bug triggered by a race. There's a fix (that needs both a new version from me and a review by someone) here: http://www.spinics.net/lists/netdev/msg229948.html Hmm... this is not a

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Andy Lutomirski
On Wed, Apr 3, 2013 at 11:43 AM, Eric Dumazet eric.duma...@gmail.com wrote: On Wed, 2013-04-03 at 10:58 -0700, Andy Lutomirski wrote: This sounds suspiciously like an SCM_CREDENTIALS bug triggered by a race. There's a fix (that needs both a new version from me and a review by someone) here:

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Stefan Lippers-Hollmann
Hi On Wednesday 03 April 2013, Greg Kroah-Hartman wrote: On Wed, Apr 03, 2013 at 05:10:40PM +0200, Sven Joachim wrote: On 2013-04-03 16:00 +0200, Eric Dumazet wrote: On Wed, 2013-04-03 at 13:41 +0200, Sven Joachim wrote: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Sven Joachim svenj...@gmx.de writes: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several complaints from udevd at boot in both 3.8.6-rc1 and 3.9-rc5: udevd[56]: sender uid=65534, message ignored.

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Andy Lutomirski l...@amacapital.net writes: On Wed, Apr 3, 2013 at 11:43 AM, Eric Dumazet eric.duma...@gmail.com wrote: On Wed, 2013-04-03 at 10:58 -0700, Andy Lutomirski wrote: This sounds suspiciously like an SCM_CREDENTIALS bug triggered by a race. There's a fix (that needs both a new

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 17:05 -0700, Eric W. Biederman wrote: Sven Joachim svenj...@gmx.de writes: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing several complaints from udevd at boot in both

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric Dumazet
On Wed, 2013-04-03 at 17:19 -0700, Eric Dumazet wrote: Well, yes, this commit fixes a real bug : We were coalescing two messages into a single one, even if the senders were different. By the way, the 'LSB' test program can be found here :

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Eric Dumazet eric.duma...@gmail.com writes: On Wed, 2013-04-03 at 17:05 -0700, Eric W. Biederman wrote: Sven Joachim svenj...@gmx.de writes: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable review patch. If anyone has any objections, please let me know. I'm seeing

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Andy Lutomirski
On Wed, Apr 3, 2013 at 5:47 PM, Eric W. Biederman ebied...@xmission.com wrote: Eric Dumazet eric.duma...@gmail.com writes: On Wed, 2013-04-03 at 17:05 -0700, Eric W. Biederman wrote: Sven Joachim svenj...@gmx.de writes: On 2013-04-03 00:11 +0200, Greg Kroah-Hartman wrote: 3.8-stable

Re: [ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-03 Thread Eric W. Biederman
Eric Dumazet eric.duma...@gmail.com writes: On Wed, 2013-04-03 at 17:19 -0700, Eric Dumazet wrote: Well, yes, this commit fixes a real bug : We were coalescing two messages into a single one, even if the senders were different. By the way, the 'LSB' test program can be found here :

[ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-02 Thread Greg Kroah-Hartman
3.8-stable review patch. If anyone has any objections, please let me know. -- From: dingtianhong [ Upstream commit 14134f6584212d585b310ce95428014b653dfaf6 ] SCM_SCREDENTIALS should apply to write() syscalls only either source or destination socket asserted SOCK_PASSCRED.

[ 105/124] af_unix: dont send SCM_CREDENTIAL when dest socket is NULL

2013-04-02 Thread Greg Kroah-Hartman
3.8-stable review patch. If anyone has any objections, please let me know. -- From: dingtianhong dingtianh...@huawei.com [ Upstream commit 14134f6584212d585b310ce95428014b653dfaf6 ] SCM_SCREDENTIALS should apply to write() syscalls only either source or destination socket