Re: [ patch 3/7] drivers/serial/jsm: new serial device driver

2005-03-04 Thread Wen Xiong
Jeff Garzik wrote: Wen Xiong wrote: +static inline void neo_set_rts_flow_control(struct channel_t *ch) +{ +uchar ier = readb(>ch_neo_uart->ier); +uchar efr = readb(>ch_neo_uart->efr); Do not invent new types like "ushort" or "uchar". For situations where specific size is required, use a

Re: [ patch 3/7] drivers/serial/jsm: new serial device driver

2005-03-04 Thread Wen Xiong
Jeff Garzik wrote: Wen Xiong wrote: +static inline void neo_set_rts_flow_control(struct channel_t *ch) +{ +uchar ier = readb(ch-ch_neo_uart-ier); +uchar efr = readb(ch-ch_neo_uart-efr); Do not invent new types like ushort or uchar. For situations where specific size is required, use a

Re: [ patch 3/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Jeff Garzik
Wen Xiong wrote: +static inline void neo_set_rts_flow_control(struct channel_t *ch) +{ + uchar ier = readb(>ch_neo_uart->ier); + uchar efr = readb(>ch_neo_uart->efr); Do not invent new types like "ushort" or "uchar". For situations where specific size is required, use a size-specific

[ patch 3/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Wen Xiong
The third patch is for jsm_tty_neo.c and includes all low level adapter functions. Signed-off-by: Wen Xiong <[EMAIL PROTECTED]> diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_neo.c linux-2.6.9.new/drivers/serial/jsm/jsm_neo.c --- linux-2.6.9.orig/drivers/serial/jsm/jsm_neo.c

[ patch 3/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Wen Xiong
The third patch is for jsm_tty_neo.c and includes all low level adapter functions. Signed-off-by: Wen Xiong [EMAIL PROTECTED] diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_neo.c linux-2.6.9.new/drivers/serial/jsm/jsm_neo.c --- linux-2.6.9.orig/drivers/serial/jsm/jsm_neo.c

Re: [ patch 3/7] drivers/serial/jsm: new serial device driver

2005-02-27 Thread Jeff Garzik
Wen Xiong wrote: +static inline void neo_set_rts_flow_control(struct channel_t *ch) +{ + uchar ier = readb(ch-ch_neo_uart-ier); + uchar efr = readb(ch-ch_neo_uart-efr); Do not invent new types like ushort or uchar. For situations where specific size is required, use a size-specific