Re: [12/24] proc: Add fs_context support to procfs [ver #7]

On Tue, Jun 26, 2018 at 09:57:07AM +0100, David Howells wrote: > Andrei Vagin wrote: > > > > > > - mnt = kern_mount_data(_fs_type, ns, 0); > > > > > > Here ns->user_ns and get_current_cred()->user_ns are not always equal > > > > What do you think about the attached patch? > > ... > > -

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

On Tue, Jun 26, 2018 at 09:57:07AM +0100, David Howells wrote: > Andrei Vagin wrote: > > > > > > - mnt = kern_mount_data(_fs_type, ns, 0); > > > > > > Here ns->user_ns and get_current_cred()->user_ns are not always equal > > > > What do you think about the attached patch? > > ... > > -

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

Andrei Vagin wrote: > > > > - mnt = kern_mount_data(_fs_type, ns, 0); > > > > Here ns->user_ns and get_current_cred()->user_ns are not always equal > > What do you think about the attached patch? > ... > - fc = vfs_new_fs_context(_fs_type, NULL, 0, > -

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

Andrei Vagin wrote: > > > > - mnt = kern_mount_data(_fs_type, ns, 0); > > > > Here ns->user_ns and get_current_cred()->user_ns are not always equal > > What do you think about the attached patch? > ... > - fc = vfs_new_fs_context(_fs_type, NULL, 0, > -

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

On Mon, Jun 25, 2018 at 11:13:20PM -0700, Andrei Vagin wrote: > On Mon, Jun 18, 2018 at 08:34:50PM -0700, Andrei Vagin wrote: > > Hi David, > > > > We run CRIU tests for vfs/for-next, and today a few of these test failed. I > > found that the problem appears after this patch.. > > > > > int

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

On Mon, Jun 25, 2018 at 11:13:20PM -0700, Andrei Vagin wrote: > On Mon, Jun 18, 2018 at 08:34:50PM -0700, Andrei Vagin wrote: > > Hi David, > > > > We run CRIU tests for vfs/for-next, and today a few of these test failed. I > > found that the problem appears after this patch.. > > > > > int

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

On Mon, Jun 18, 2018 at 08:34:50PM -0700, Andrei Vagin wrote: > Hi David, > > We run CRIU tests for vfs/for-next, and today a few of these test failed. I > found that the problem appears after this patch.. > > > int pid_ns_prepare_proc(struct pid_namespace *ns) > > { > > + struct

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

On Mon, Jun 18, 2018 at 08:34:50PM -0700, Andrei Vagin wrote: > Hi David, > > We run CRIU tests for vfs/for-next, and today a few of these test failed. I > found that the problem appears after this patch.. > > > int pid_ns_prepare_proc(struct pid_namespace *ns) > > { > > + struct

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

Hi David, We run CRIU tests for vfs/for-next, and today a few of these test failed. I found that the problem appears after this patch.. https://travis-ci.org/avagin/linux/jobs/393766778 The reproducer is attached. It creates a process in a new set of namespaces (user, mount, etc) and then this

Re: [12/24] proc: Add fs_context support to procfs [ver #7]

Hi David, We run CRIU tests for vfs/for-next, and today a few of these test failed. I found that the problem appears after this patch.. https://travis-ci.org/avagin/linux/jobs/393766778 The reproducer is attached. It creates a process in a new set of namespaces (user, mount, etc) and then this

[PATCH 12/24] proc: Add fs_context support to procfs [ver #7]

Add fs_context support to procfs. Signed-off-by: David Howells --- fs/proc/inode.c|2 - fs/proc/internal.h |2 - fs/proc/root.c | 169 ++-- 3 files changed, 113 insertions(+), 60 deletions(-) diff --git

[PATCH 12/24] proc: Add fs_context support to procfs [ver #7]

Add fs_context support to procfs. Signed-off-by: David Howells --- fs/proc/inode.c|2 - fs/proc/internal.h |2 - fs/proc/root.c | 169 ++-- 3 files changed, 113 insertions(+), 60 deletions(-) diff --git a/fs/proc/inode.c