Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-04 Thread Bill Irwin
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: >> + Allocates the stack physically discontiguously and from high >> + memory. Furthermore an unmapped guard page follows the stack. >> + This is not for end-users. It's intended to trigger fatal >> + system

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-04 Thread Bill Irwin
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: + Allocates the stack physically discontiguously and from high + memory. Furthermore an unmapped guard page follows the stack. + This is not for end-users. It's intended to trigger fatal + system errors

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-03 Thread Joseph Fannin
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: > + Allocates the stack physically discontiguously and from high > + memory. Furthermore an unmapped guard page follows the stack. > + This is not for end-users. It's intended to trigger fatal > +

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-03 Thread Joseph Fannin
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: + Allocates the stack physically discontiguously and from high + memory. Furthermore an unmapped guard page follows the stack. + This is not for end-users. It's intended to trigger fatal + system

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Bill Irwin
On Tue, May 01, 2007 at 05:36:06PM -0500, Matt Mackall wrote: >>> Can we register them lazily at request_irq time? On Tue, May 01, 2007 at 03:51:25PM -0700, Bill Irwin wrote: >> These IRQ stacks are per-cpu, not per-IRQ. It may make sense to >> implement per-IRQ stacks, in which case dynamic

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Bill Irwin
At some point in the past, I wrote: >> These IRQ stacks are per-cpu, not per-IRQ. It may make sense to >> implement per-IRQ stacks, in which case dynamic allocation at the time >> of request_irq() will make sense. On Wed, May 02, 2007 at 12:07:45AM +0100, Alan Cox wrote: > This depends if active

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Matt Mackall
On Tue, May 01, 2007 at 03:51:25PM -0700, Bill Irwin wrote: > On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: > >> So if you want to invest some time into getting this into mergeable > >> shape I'd suggest you redo the patch series in the following way: > >> patch 1: dynamic

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Alan Cox
> These IRQ stacks are per-cpu, not per-IRQ. It may make sense to > implement per-IRQ stacks, in which case dynamic allocation at the time > of request_irq() will make sense. This depends if active IRQ count exceeds active CPU count worst cases. For the big boxes it might well do but for small

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Bill Irwin
On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: >> So if you want to invest some time into getting this into mergeable >> shape I'd suggest you redo the patch series in the following way: >> patch 1: dynamic allocated irq stacks On Tue, May 01, 2007 at 05:36:06PM -0500, Matt

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Matt Mackall
On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: > So if you want to invest some time into getting this into mergeable > shape I'd suggest you redo the patch series in the following way: > > patch 1: dynamic allocated irq stacks Can we register them lazily at request_irq time?

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Matt Mackall
On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: So if you want to invest some time into getting this into mergeable shape I'd suggest you redo the patch series in the following way: patch 1: dynamic allocated irq stacks Can we register them lazily at request_irq time? --

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Bill Irwin
On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: So if you want to invest some time into getting this into mergeable shape I'd suggest you redo the patch series in the following way: patch 1: dynamic allocated irq stacks On Tue, May 01, 2007 at 05:36:06PM -0500, Matt Mackall

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Alan Cox
These IRQ stacks are per-cpu, not per-IRQ. It may make sense to implement per-IRQ stacks, in which case dynamic allocation at the time of request_irq() will make sense. This depends if active IRQ count exceeds active CPU count worst cases. For the big boxes it might well do but for small ones

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Matt Mackall
On Tue, May 01, 2007 at 03:51:25PM -0700, Bill Irwin wrote: On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: So if you want to invest some time into getting this into mergeable shape I'd suggest you redo the patch series in the following way: patch 1: dynamic allocated

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Bill Irwin
At some point in the past, I wrote: These IRQ stacks are per-cpu, not per-IRQ. It may make sense to implement per-IRQ stacks, in which case dynamic allocation at the time of request_irq() will make sense. On Wed, May 02, 2007 at 12:07:45AM +0100, Alan Cox wrote: This depends if active IRQ

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-01 Thread Bill Irwin
On Tue, May 01, 2007 at 05:36:06PM -0500, Matt Mackall wrote: Can we register them lazily at request_irq time? On Tue, May 01, 2007 at 03:51:25PM -0700, Bill Irwin wrote: These IRQ stacks are per-cpu, not per-IRQ. It may make sense to implement per-IRQ stacks, in which case dynamic allocation

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Bill Irwin
On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: > So if you want to invest some time into getting this into mergeable > shape I'd suggest you redo the patch series in the following way: > patch 1: dynamic allocated irq stacks > patch 2: make irqstacks unconditional, but allow

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Bill Irwin
On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: > So if you want to invest some time into getting this into mergeable > shape I'd suggest you redo the patch series in the following way: > patch 1: dynamic allocated irq stacks > patch 2: make irqstacks unconditional, but allow

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Christoph Hellwig
So if you want to invest some time into getting this into mergeable shape I'd suggest you redo the patch series in the following way: patch 1: dynamic allocated irq stacks patch 2: make irqstacks unconditional, but allow selecting 4/8k stacks patch 3: introduce a DEBUG_STACK option that

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread William Lee Irwin III
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: >> Add a config option to vmalloc() task stacks so that stack overflows are >> detected without fail, and with a fatal failure mode at that. On Mon, Apr 30, 2007 at 07:11:04PM +0100, Christoph Hellwig wrote: > Whee, this

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 19:11, Christoph Hellwig wrote: >On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: >> On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote: >> > Here's what I did for i386 for someone concerned about blowing the stack. >> >> Add a config

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Christoph Hellwig
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: > On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote: > > Here's what I did for i386 for someone concerned about blowing the stack. > > Add a config option to vmalloc() task stacks so that stack overflows

[2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread William Lee Irwin III
On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote: > Here's what I did for i386 for someone concerned about blowing the stack. Add a config option to vmalloc() task stacks so that stack overflows are detected without fail, and with a fatal failure mode at that. Signed-off-by:

[2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread William Lee Irwin III
On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote: Here's what I did for i386 for someone concerned about blowing the stack. Add a config option to vmalloc() task stacks so that stack overflows are detected without fail, and with a fatal failure mode at that. Signed-off-by:

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Christoph Hellwig
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote: Here's what I did for i386 for someone concerned about blowing the stack. Add a config option to vmalloc() task stacks so that stack overflows are

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Jan Engelhardt
On Apr 30 2007 19:11, Christoph Hellwig wrote: On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: On Mon, Apr 30, 2007 at 10:38:19AM -0700, William Lee Irwin III wrote: Here's what I did for i386 for someone concerned about blowing the stack. Add a config option to

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread William Lee Irwin III
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: Add a config option to vmalloc() task stacks so that stack overflows are detected without fail, and with a fatal failure mode at that. On Mon, Apr 30, 2007 at 07:11:04PM +0100, Christoph Hellwig wrote: Whee, this sounds

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Christoph Hellwig
So if you want to invest some time into getting this into mergeable shape I'd suggest you redo the patch series in the following way: patch 1: dynamic allocated irq stacks patch 2: make irqstacks unconditional, but allow selecting 4/8k stacks patch 3: introduce a DEBUG_STACK option that

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Bill Irwin
On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: So if you want to invest some time into getting this into mergeable shape I'd suggest you redo the patch series in the following way: patch 1: dynamic allocated irq stacks patch 2: make irqstacks unconditional, but allow

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-04-30 Thread Bill Irwin
On Mon, Apr 30, 2007 at 08:15:11PM +0100, Christoph Hellwig wrote: So if you want to invest some time into getting this into mergeable shape I'd suggest you redo the patch series in the following way: patch 1: dynamic allocated irq stacks patch 2: make irqstacks unconditional, but allow