[2.6 patch] drivers/net/ne3210.c: cleanups

2005-04-18 Thread Adrian Bunk
This patch contains the following cleanups: - make two needlessly global functions static - kill an ancient version variable Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/ne3210.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) ---

[2.6 patch] drivers/net/ne3210.c: cleanups

2005-04-18 Thread Adrian Bunk
This patch contains the following cleanups: - make two needlessly global functions static - kill an ancient version variable Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/ne3210.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) ---

Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-24 Thread Adrian Bunk
On Mon, Feb 21, 2005 at 03:39:54PM -0500, Jeff Garzik wrote: > Adrian Bunk wrote: > >@@ -197,7 +194,7 @@ > > ei_status.priv = phys_mem; > > > > if (ei_debug > 0) > >-printk(version); > >+printk("ne3210 driver"); > > > missing newline. Do something like "ns3210

Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-24 Thread Adrian Bunk
On Mon, Feb 21, 2005 at 03:39:54PM -0500, Jeff Garzik wrote: Adrian Bunk wrote: @@ -197,7 +194,7 @@ ei_status.priv = phys_mem; if (ei_debug 0) -printk(version); +printk(ne3210 driver); missing newline. Do something like ns3210 __DATE__ loaded.\n

Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-21 Thread Jeff Garzik
Adrian Bunk wrote: @@ -197,7 +194,7 @@ ei_status.priv = phys_mem; if (ei_debug > 0) - printk(version); + printk("ne3210 driver"); missing newline. Do something like "ns3210 __DATE__ loaded.\n" Ditto for seeq8002. Jeff - To unsubscribe from this list: send the line "unsubscribe

[2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-21 Thread Adrian Bunk
On Sun, Feb 20, 2005 at 08:40:13PM -0500, Jeff Garzik wrote: > Adrian Bunk wrote: > >-if (ei_debug > 0) > >-printk(version); > > > I agree the version variable is outdated, but I disagree that the driver > intro banner should be removed completely. A few lines above, the driver

[2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-21 Thread Adrian Bunk
On Sun, Feb 20, 2005 at 08:40:13PM -0500, Jeff Garzik wrote: Adrian Bunk wrote: -if (ei_debug 0) -printk(version); I agree the version variable is outdated, but I disagree that the driver intro banner should be removed completely. A few lines above, the driver already

Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-21 Thread Jeff Garzik
Adrian Bunk wrote: @@ -197,7 +194,7 @@ ei_status.priv = phys_mem; if (ei_debug 0) - printk(version); + printk(ne3210 driver); missing newline. Do something like ns3210 __DATE__ loaded.\n Ditto for seeq8002. Jeff - To unsubscribe from this list: send the line unsubscribe

Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-20 Thread Jeff Garzik
Adrian Bunk wrote: - if (ei_debug > 0) - printk(version); I agree the version variable is outdated, but I disagree that the driver intro banner should be removed completely. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-20 Thread Jeff Garzik
Adrian Bunk wrote: - if (ei_debug 0) - printk(version); I agree the version variable is outdated, but I disagree that the driver intro banner should be removed completely. Jeff - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

[2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-18 Thread Adrian Bunk
This patch contains the following cleanups: - make two needlessly global functions static - kill an ancient version variable Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/ne3210.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) ---

[2.6 patch] drivers/net/ne3210.c: cleanups

2005-02-18 Thread Adrian Bunk
This patch contains the following cleanups: - make two needlessly global functions static - kill an ancient version variable Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/ne3210.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) ---