Roland Dreier schrieb:
> Prakash> If I am not totally mistaken this is not gcc4 friendly
> Prakash> code. (lvalue thing...)
>
> Actually you misread the code slightly. It's a little subtle, but
> code like
>
> *(__le32 *)prd = cpu_to_le32(len);
>
> is not using a cast as an
Prakash> If I am not totally mistaken this is not gcc4 friendly
Prakash> code. (lvalue thing...)
Actually you misread the code slightly. It's a little subtle, but
code like
*(__le32 *)prd = cpu_to_le32(len);
is not using a cast as an lvalue. It's dereferencing a cast
Alexey Dobriyan schrieb:
> On Wednesday 23 February 2005 21:57, Jeff Garzik wrote:
>>+ addr = sg_dma_address(sg);
>>+ *(u64 *)prd = cpu_to_le64(addr);
>
>
> *(__le64 *) prd
>
>
>>+ prd += sizeof(u64);
>
>
>>+ len = sg_dma_len(sg);
>>+
Thanks. All this stuff was minor, so I'll wait until 2.6.11 release to
update.
I forwarded the qstor stuff to maintainer Mark Lord.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Wednesday 23 February 2005 23:45, Alexey Dobriyan wrote:
> > +static void qs_ata_setup_port(struct ata_ioports *port, unsigned long base)
> > +{
> > + port->cmd_addr =
>
> > + port->error_addr=
>
> > + port->status_addr =
>
> > + port->altstatus_addr=
>
>
On Wednesday 23 February 2005 21:57, Jeff Garzik wrote:
> This BK push includes additional hardware support, but that's only
> because it's (a) obviously low impact and (b) it was in the queue.
> --- a/drivers/scsi/ahci.c
> +++ b/drivers/scsi/ahci.c
> +static u8 ahci_check_err(struct ata_port
This BK push includes additional hardware support, but that's only
because it's (a) obviously low impact and (b) it was in the queue.
Far more important are:
1) API additions, to fix a severe bug: advanced drivers such as AHCI
were directly bitbanging --non-existent-- PCI IDE registers,
This BK push includes additional hardware support, but that's only
because it's (a) obviously low impact and (b) it was in the queue.
Far more important are:
1) API additions, to fix a severe bug: advanced drivers such as AHCI
were directly bitbanging --non-existent-- PCI IDE registers,
On Wednesday 23 February 2005 21:57, Jeff Garzik wrote:
This BK push includes additional hardware support, but that's only
because it's (a) obviously low impact and (b) it was in the queue.
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
+static u8 ahci_check_err(struct ata_port *ap)
On Wednesday 23 February 2005 23:45, Alexey Dobriyan wrote:
+static void qs_ata_setup_port(struct ata_ioports *port, unsigned long base)
+{
+ port-cmd_addr =
+ port-error_addr=
+ port-status_addr =
+ port-altstatus_addr=
Oo-oops...
Too much
Thanks. All this stuff was minor, so I'll wait until 2.6.11 release to
update.
I forwarded the qstor stuff to maintainer Mark Lord.
Jeff
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Alexey Dobriyan schrieb:
On Wednesday 23 February 2005 21:57, Jeff Garzik wrote:
+ addr = sg_dma_address(sg);
+ *(u64 *)prd = cpu_to_le64(addr);
*(__le64 *) prd
+ prd += sizeof(u64);
+ len = sg_dma_len(sg);
+ *(u32 *)prd =
Prakash If I am not totally mistaken this is not gcc4 friendly
Prakash code. (lvalue thing...)
Actually you misread the code slightly. It's a little subtle, but
code like
*(__le32 *)prd = cpu_to_le32(len);
is not using a cast as an lvalue. It's dereferencing a cast and
Roland Dreier schrieb:
Prakash If I am not totally mistaken this is not gcc4 friendly
Prakash code. (lvalue thing...)
Actually you misread the code slightly. It's a little subtle, but
code like
*(__le32 *)prd = cpu_to_le32(len);
is not using a cast as an lvalue.
14 matches
Mail list logo
